1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
//! Content-addressable object storage with streaming reads.
//!
//! # Purpose
//!
//! This module defines the [`ObjectStore`] trait, which represents the
//! persistence layer for raw, serialized version control objects. An object
//! store is a key-value database where the key is a [`Hash`] (the content
//! address) and the value is the raw byte representation of a
//! [`Blob`](crate::Blob), [`Tree`](crate::Tree), [`Commit`](crate::Commit),
//! or [`Tag`](crate::Tag).
//!
//! # Design Rationale
//!
//! Separating object storage into a trait provides several benefits:
//!
//! - **Backend agnosticism**: Implementations can be in-memory, on-disk,
//! remote, or backed by a database without altering the rest of the
//! system.
//! - **Testability**: Dummy or in-memory stores simplify unit testing of
//! higher-level components.
//! - **Streaming efficiency**: The [`ObjectStore::get`] method returns a
//! reader instead of a [`Vec<u8>`], enabling large objects to be consumed
//! incrementally without allocating their full contents at once.
//! - **Immutability focus**: Objects are content-addressed and therefore
//! immutable once written. The trait does not expose update operations.
//!
//! # Streaming Semantics
//!
//! The [`ObjectStore::get`] method returns a [`Box<dyn std::io::Read>`].
//! This design allows callers to stream the object bytes directly from the
//! backing store. The reader is tied to the lifetime of `&self`, meaning the
//! store cannot be mutated while a reader is alive. This is enforced by
//! Rust's borrow checker and prevents data races in single-threaded code.
//!
//! # How It Works Internally
//!
//! An implementation stores byte vectors under [`Hash`] keys. When
//! [`ObjectStore::put`] is called, the implementation should copy or move
//! the provided `data` into its internal storage. When
//! [`ObjectStore::get`] is called, the implementation looks up the hash and
//! returns a reader over the stored bytes, or
//! [`VctrlError::ObjectNotFound`] if the hash does not exist. The
//! [`ObjectStore::delete`] and [`ObjectStore::exists`] methods provide
//! additional lifecycle management.
//!
//! # Examples
//!
//! A complete in-memory implementation demonstrates all methods:
//!
//! ```
//! use libvctrl_handler::{Hash, ObjectStore, VctrlError};
//! use std::collections::HashMap;
//! use std::io::Read;
//!
//! #[derive(Default)]
//! struct InMemoryStore(HashMap<Hash, Vec<u8>>);
//!
//! impl ObjectStore for InMemoryStore {
//! fn put(&mut self, hash: &Hash, data: &[u8]) -> Result<(), VctrlError> {
//! self.0.insert(*hash, data.to_vec());
//! Ok(())
//! }
//!
//! fn get(&self, hash: &Hash) -> Result<Box<dyn Read + '_>, VctrlError> {
//! self.0
//! .get(hash)
//! .cloned()
//! .map(|v| Box::new(std::io::Cursor::new(v)) as Box<dyn Read>)
//! .ok_or_else(|| VctrlError::ObjectNotFound(*hash))
//! }
//!
//! fn delete(&mut self, hash: &Hash) -> Result<(), VctrlError> {
//! self.0.remove(hash);
//! Ok(())
//! }
//!
//! fn exists(&self, hash: &Hash) -> Result<bool, VctrlError> {
//! Ok(self.0.contains_key(hash))
//! }
//! }
//!
//! let mut store = InMemoryStore::default();
//! let hash = Hash::from_bytes(&[0u8; 64]).unwrap();
//! store.put(&hash, b"data").unwrap();
//!
//! let mut reader = store.get(&hash).unwrap();
//! let mut buf = Vec::new();
//! reader.read_to_end(&mut buf).unwrap();
//! assert_eq!(buf, b"data");
//! ```
use crateVctrlError;
use crateHash;
use Read;
/// Defines the interface for a content-addressable object database.
///
/// # Purpose
///
/// An `ObjectStore` is responsible for storing and retrieving raw,
/// serialized version control objects (blobs, trees, commits, tags) using
/// their [`Hash`] as the primary key. This trait is the low-level
/// persistence contract that all storage backends must implement.
///
/// # Design Rationale
///
/// - **`&Hash` lookups**: The trait uses borrowed [`Hash`] references for
/// lookups rather than owned values. A [`Hash`] is 64 bytes; borrowing
/// avoids unnecessary stack copies and permits the store to implement
/// efficient in-place key comparisons.
/// - **`&[u8]` for `put`**: The `put` method accepts a byte slice instead of
/// a [`Vec<u8>`] to avoid forcing ownership transfer. The implementation
/// may choose to copy, move, or stream the data into its internal storage.
/// - **Streaming reads**: The `get` method returns a
/// [`Box<dyn Read>`](std::io::Read) rather than a concrete byte vector.
/// This enables callers to process large objects incrementally and
/// prevents large contiguous allocations when only a portion of the data
/// is needed.
/// - **Immutable objects**: Objects are content-addressed, meaning their
/// hash is derived from their bytes. Mutating stored data would break the
/// hash invariant, so the trait does not provide an update method. The
/// store is conceptually append-only (with `delete` as the exception).
///
/// # Streaming Semantics (`get`)
///
/// Implementations of `get` should return a reader that yields the exact
/// byte content of the stored object. The reader is borrowed from `&self`,
/// so the store cannot be mutated (e.g., via `put` or `delete`) while a
/// reader exists. This is enforced by Rust's borrow checker. Callers must
/// consume the reader (e.g., via
/// [`Read::read_to_end`](std::io::Read::read_to_end)) to obtain the raw
/// bytes.
///
/// # Error Handling
///
/// All methods return a [`Result`] with [`VctrlError`]. This unifies error
/// handling across all backends and allows callers to match on specific
/// failure conditions such as
/// [`ObjectNotFound`](VctrlError::ObjectNotFound) or
/// [`IoError`](VctrlError::IoError).
///
/// # Examples
///
/// A complete in-memory implementation:
///
/// ```
/// use libvctrl_handler::{Hash, ObjectStore, VctrlError};
/// use std::collections::HashMap;
/// use std::io::Read;
///
/// #[derive(Default)]
/// struct InMemoryStore(HashMap<Hash, Vec<u8>>);
///
/// impl ObjectStore for InMemoryStore {
/// fn put(&mut self, hash: &Hash, data: &[u8]) -> Result<(), VctrlError> {
/// self.0.insert(*hash, data.to_vec());
/// Ok(())
/// }
///
/// fn get(&self, hash: &Hash) -> Result<Box<dyn Read + '_>, VctrlError> {
/// self.0
/// .get(hash)
/// .cloned()
/// .map(|v| Box::new(std::io::Cursor::new(v)) as Box<dyn Read>)
/// .ok_or_else(|| VctrlError::ObjectNotFound(*hash))
/// }
///
/// fn delete(&mut self, hash: &Hash) -> Result<(), VctrlError> {
/// self.0.remove(hash);
/// Ok(())
/// }
///
/// fn exists(&self, hash: &Hash) -> Result<bool, VctrlError> {
/// Ok(self.0.contains_key(hash))
/// }
/// }
///
/// let mut store = InMemoryStore::default();
/// let hash = Hash::from_bytes(&[0u8; 64]).unwrap();
/// store.put(&hash, b"data").unwrap();
///
/// // Read back the object using the streaming interface
/// let mut reader = store.get(&hash).unwrap();
/// let mut buf = Vec::new();
/// reader.read_to_end(&mut buf).unwrap();
/// assert_eq!(buf, b"data");
/// ```