libstorage 0.4.8

Storage helper functions
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
1278
1279
1280
1281
1282
1283
1284
1285
1286
1287
1288
1289
1290
1291
1292
1293
1294
1295
1296
1297
1298
1299
1300
1301
1302
1303
1304
1305
1306
1307
1308
1309
1310
1311
1312
1313
1314
1315
1316
1317
1318
1319
1320
1321
1322
1323
1324
1325
1326
1327
1328
1329
1330
1331
1332
1333
1334
1335
1336
1337
1338
1339
1340
1341
/**
* Copyright 2019 Comcast Cable Communications Management, LLC
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*
* SPDX-License-Identifier: Apache-2.0
*/
use crate::error::MetricsResult;
use crate::ChildPoint;
use crate::IntoPoint;

use std::fmt::Debug;
use std::str;

use crate::ir::{TsPoint, TsValue};
use log::{debug, trace};
use reqwest::header::ACCEPT;
use serde::de::DeserializeOwned;
use serde::ser::Serialize;
use serde_json::{json, Value};

#[derive(Clone, Deserialize, Debug)]
pub struct VmaxConfig {
    /// The scaleio endpoint to use
    pub endpoint: String,
    pub user: String,
    /// This gets replaced with the token at runtime
    pub password: String,
    /// Optional certificate file to use against the server
    /// der encoded
    pub certificate: Option<String>,
    /// The region this cluster is located in
    pub region: String,
}

pub struct Vmax {
    client: reqwest::Client,
    config: VmaxConfig,
}

impl Vmax {
    pub fn new(client: &reqwest::Client, config: VmaxConfig) -> Self {
        Vmax {
            client: client.clone(),
            config,
        }
    }
}

#[derive(Debug, Deserialize)]
pub struct Srps {
    pub srp: Vec<Srp>,
    pub success: bool,
}

impl IntoPoint for Srps {
    fn into_point(&self, name: Option<&str>, is_time_series: bool) -> Vec<TsPoint> {
        let mut points: Vec<TsPoint> = Vec::new();
        for s in &self.srp {
            points.extend(s.into_point(name, is_time_series));
        }
        points
    }
}

#[allow(non_snake_case)]
#[derive(Debug, Deserialize, IntoPoint)]
pub struct Srp {
    pub srpId: String,
    pub num_of_disk_groups: Option<i64>,
    pub description: Option<String>,
    pub emulation: Option<String>,
    pub overall_efficiency: Option<String>,
    pub compression_state: Option<String>,
    pub reserved_cap_percent: Option<i64>,
    pub total_usable_cap_gb: Option<f64>,
    pub total_subscribed_cap_gb: Option<f64>,
    pub total_allocated_cap_gb: Option<f64>,
    pub total_snapshot_allocated_cap_gb: Option<f64>,
    pub total_srdf_dse_allocated_cap_gb: Option<f64>,
    pub rdfa_dse: Option<bool>,
    pub num_of_srp_slo_demands: Option<i64>,
    pub num_of_srp_sg_demands: Option<i64>,
    pub diskGroupId: Option<Vec<String>>,
    pub srpSgDemandId: Option<Vec<String>>,
    pub srpSloDemandId: Option<Vec<String>>,
}

#[allow(non_snake_case)]
#[derive(Debug, Deserialize)]
pub struct StorageGroups {
    pub storageGroup: Vec<StorageGroup>,
    pub success: bool,
}

impl IntoPoint for StorageGroups {
    fn into_point(&self, name: Option<&str>, is_time_series: bool) -> Vec<TsPoint> {
        let mut points: Vec<TsPoint> = Vec::new();
        for s in &self.storageGroup {
            points.extend(s.into_point(name, is_time_series));
        }
        points
    }
}

#[allow(non_snake_case)]
#[derive(Debug, Deserialize, IntoPoint)]
pub struct StorageGroup {
    #[serde(rename = "storageGroupId")]
    pub storage_group_id: String,
    pub slo: Option<String>,
    pub srp: Option<String>,
    pub workload: Option<String>,
    pub slo_compliance: Option<String>,
    pub num_of_vols: Option<i64>,
    pub num_of_child_sgs: Option<i64>,
    pub num_of_parent_sgs: Option<i64>,
    pub num_of_masking_views: Option<i64>,
    pub num_of_snapshots: Option<i64>,
    pub cap_gb: Option<f64>,
    pub device_emulation: Option<String>,
    #[serde(rename = "type")]
    pub group_type: Option<String>,
    pub child_storage_group: Option<Vec<String>>,
    pub parent_storage_group: Option<Vec<String>>,
    #[serde(rename = "maskingview")]
    pub masking_view: Option<Vec<String>>,
}

#[derive(Debug, Deserialize)]
pub struct SloArray {
    pub symmetrix: Vec<Symmetrix>,
    pub success: bool,
}

impl IntoPoint for SloArray {
    fn into_point(&self, name: Option<&str>, is_time_series: bool) -> Vec<TsPoint> {
        let mut points: Vec<TsPoint> = Vec::new();
        for s in &self.symmetrix {
            points.extend(s.into_point(name, is_time_series));
        }
        points
    }
}

#[allow(non_snake_case)]
#[derive(Debug, Deserialize)]
pub struct Symmetrix {
    pub symmetrixId: String,
    pub device_count: Option<i64>,
    pub ucode: Option<String>,
    pub model: Option<String>,
    pub local: Option<bool>,
    pub sloCompliance: Option<SloCompliance>,
    pub virtualCapacity: Option<VirtualCapacity>,
}

impl IntoPoint for Symmetrix {
    fn into_point(&self, name: Option<&str>, is_time_series: bool) -> Vec<TsPoint> {
        let mut p = TsPoint::new(name.unwrap_or("vmax_symmetrix"), is_time_series);
        p.add_tag("symmetrixId", TsValue::String(self.symmetrixId.clone()));
        if let Some(d) = self.device_count {
            p.add_field("device_count", TsValue::SignedLong(d));
        }
        if let Some(ref s) = self.ucode {
            p.add_tag("device_count", TsValue::String(s.clone()));
        }
        if let Some(ref s) = self.model {
            p.add_tag("model", TsValue::String(s.clone()));
        }
        if let Some(b) = self.local {
            p.add_field("model", TsValue::Boolean(b));
        }
        if let Some(ref s) = self.sloCompliance {
            if let Some(stable) = s.slo_stable {
                p.add_field("slo_stable", TsValue::SignedLong(stable));
            }
            if let Some(marginal) = s.slo_marginal {
                p.add_field("slo_marginal", TsValue::SignedLong(marginal));
            }
            if let Some(critical) = s.slo_critical {
                p.add_field("slo_critical", TsValue::SignedLong(critical));
            }
        }
        if let Some(ref v) = self.virtualCapacity {
            p.add_field("used_capacity_gb", TsValue::Float(v.used_capacity_gb));
            p.add_field("total_capacity_gb", TsValue::Float(v.total_capacity_gb));
        }

        vec![p]
    }
}

#[derive(Debug, Deserialize)]
pub struct SloCompliance {
    pub slo_stable: Option<i64>,
    pub slo_marginal: Option<i64>,
    pub slo_critical: Option<i64>,
}

#[derive(Debug, Deserialize)]
pub struct VirtualCapacity {
    pub used_capacity_gb: f64,
    pub total_capacity_gb: f64,
}

#[test]
fn test_get_slo_arrays() {
    use std::fs::File;
    use std::io::Read;

    let mut f = File::open("tests/vmax/slo_array.json").unwrap();
    let mut buff = String::new();
    f.read_to_string(&mut buff).unwrap();

    let i: SloArray = serde_json::from_str(&buff).unwrap();
    println!("result: {:#?}", i);
    println!("point: {:#?}", i.into_point(Some("slo_arrays"), true));
}

#[test]
fn test_get_slo_array_srps() {
    use std::fs::File;
    use std::io::Read;

    let mut f = File::open("tests/vmax/slo_array_srp.json").unwrap();
    let mut buff = String::new();
    f.read_to_string(&mut buff).unwrap();

    let i: Srps = serde_json::from_str(&buff).unwrap();
    println!("result: {:#?}", i);
    println!("point: {:#?}", i.into_point(Some("srp"), true));
}

#[test]
fn test_get_slo_array_storagegroups() {
    use std::fs::File;
    use std::io::Read;

    let mut f = File::open("tests/vmax/slo_array_storagegroup.json").unwrap();
    let mut buff = String::new();
    f.read_to_string(&mut buff).unwrap();

    let i: StorageGroups = serde_json::from_str(&buff).unwrap();
    println!("result: {:#?}", i);
    println!("point: {:#?}", i.into_point(Some("storage_group"), true));
}

//START Section for Collecting VMAX Front-End Port list and Front-End Port Metrics
//For Collecting the VMAX Array Front-end Directors
#[serde(rename_all = "camelCase")]
#[derive(Debug, Deserialize, IntoPoint)]
pub struct FeDirector {
    pub director_id: String,
    pub first_available_date: u64,
    pub last_available_date: u64,
}

#[serde(rename_all = "camelCase")]
#[derive(Debug, Deserialize)]
pub struct FedArray {
    pub fe_director_info: Vec<FeDirector>,
}

impl IntoPoint for FedArray {
    fn into_point(&self, name: Option<&str>, is_time_series: bool) -> Vec<TsPoint> {
        let mut points: Vec<TsPoint> = Vec::new();
        for s in &self.fe_director_info {
            points.extend(s.into_point(name, is_time_series));
        }
        points
    }
}

//For Collecting the VMAX Array Front-end Directors Metrics
#[serde(rename_all = "PascalCase")]
#[derive(Debug, Deserialize, IntoPoint)]
pub struct FeDirectorMetrics {
    #[serde(rename = "AvgWPDiscTime")]
    pub avg_wpdisc_time: f64,
    #[serde(rename = "AvgReadMissResponseTime")]
    pub avg_read_miss_response_time: f64,
    pub percent_busy: f64,
    #[serde(rename = "HostIOs")]
    pub host_ios: f64,
    #[serde(rename = "HostMBs")]
    pub host_mbs: f64,
    pub reqs: f64,
    pub read_reqs: f64,
    pub write_reqs: f64,
    pub hit_reqs: f64,
    pub read_hit_reqs: f64,
    pub write_hit_reqs: f64,
    pub miss_reqs: f64,
    pub read_miss_reqs: f64,
    pub write_miss_reqs: f64,
    pub percent_read_reqs: f64,
    pub percent_write_reqs: f64,
    pub percent_hit_reqs: f64,
    pub percent_read_req_hit: f64,
    #[serde(rename = "SystemWPEvents")]
    pub system_device_wpevents: f64,
    #[serde(rename = "DeviceWPEvents")]
    pub device_wpevents: f64,
    pub avg_time_per_syscall: f64,
    pub slot_collisions: f64,
    pub percent_write_req_hit: f64,
    pub total_read_count: f64,
    pub total_write_count: f64,
    pub read_response_time: f64,
    pub write_response_time: f64,
    #[serde(rename = "HostIOLimitIOs")]
    pub host_io_limit_ios: f64,
    #[serde(rename = "HostIOLimitMBs")]
    pub host_io_limit_mbs: f64,
    pub optimized_read_misses: f64,
    #[serde(rename = "OptimizedMBReadMisses")]
    pub optimized_mb_read_misses: f64,
    pub avg_optimized_read_miss_size: f64,
    pub queue_depth_utilization: f64,
    #[serde(rename = "timestamp")]
    pub timestamp: u64,
}

//Since the returned value are an Object--> Object-Array of values, resultlist-result
#[serde(rename_all = "camelCase")]
#[derive(Debug, Deserialize)]
pub struct FedArrayMetrics {
    pub result_list: FedResult,
}

impl IntoPoint for FedArrayMetrics {
    fn into_point(&self, name: Option<&str>, is_time_series: bool) -> Vec<TsPoint> {
        self.result_list.into_point(name, is_time_series)
    }
}

impl IntoPoint for FedResult {
    fn into_point(&self, name: Option<&str>, is_time_series: bool) -> Vec<TsPoint> {
        let mut points: Vec<TsPoint> = Vec::new();
        for r in &self.result {
            let res = r.into_point(name, is_time_series);
            points.extend(res);
        }
        points
    }
}

//Since the returned value are Object-Object-Array of values, result-array of objects
#[serde(rename_all = "camelCase")]
#[derive(Debug, Deserialize)]
pub struct FedResult {
    pub result: Vec<FeDirectorMetrics>,
}

//START Section for Collecting VMAX PortGroup list and PortGroup Metrics
//For Collecting the VMAX Array PortGroup Listings
/* https://{server}/univmax/restapi/performance/PortGroup/keys
{
  "symmetrixId" : "000196702346"
}
*/
#[serde(rename_all = "camelCase")]
#[derive(Debug, Deserialize, IntoPoint)]
pub struct PortGroup {
    pub port_group_id: String,
    pub first_available_date: u64,
    pub last_available_date: u64,
}

#[serde(rename_all = "camelCase")]
#[derive(Debug, Deserialize)]
pub struct PortGroupArray {
    pub port_group_info: Vec<PortGroup>,
}

impl IntoPoint for PortGroupArray {
    fn into_point(&self, name: Option<&str>, is_time_series: bool) -> Vec<TsPoint> {
        let mut points: Vec<TsPoint> = Vec::new();
        for s in &self.port_group_info {
            points.extend(s.into_point(name, is_time_series));
        }
        points
    }
}

//For Collecting the VMAX Array PortGroup Metrics
#[serde(rename_all = "PascalCase")]
#[derive(Debug, Deserialize, IntoPoint)]
pub struct PortGroupMetrics {
    pub reads: f64,
    pub writes: f64,
    #[serde(rename = "IOs")]
    pub ios: f64,
    #[serde(rename = "MBRead")]
    pub mb_read: f64,
    #[serde(rename = "MBWritten")]
    pub mb_written: f64,
    #[serde(rename = "MBs")]
    pub mbs: f64,
    #[serde(rename = "AvgIOSize")]
    pub avg_io_size: f64,
    pub percent_busy: f64,
    #[serde(rename = "timestamp")]
    pub timestamp: u64,
}

//Since the returned value are an Object--> Object-Array of values, resultlist-result
#[serde(rename_all = "camelCase")]
#[derive(Debug, Deserialize)]
pub struct PortGroupArrayMetrics {
    pub result_list: PgResult,
}

impl IntoPoint for PortGroupArrayMetrics {
    fn into_point(&self, name: Option<&str>, is_time_series: bool) -> Vec<TsPoint> {
        self.result_list.into_point(name, is_time_series)
    }
}

impl IntoPoint for PgResult {
    fn into_point(&self, name: Option<&str>, is_time_series: bool) -> Vec<TsPoint> {
        let mut points: Vec<TsPoint> = Vec::new();
        for r in &self.result {
            let res = r.into_point(name, is_time_series);
            points.extend(res);
        }
        points
    }
}

//Since the returned value are Object-Object-Array of values, result-array of objects
#[serde(rename_all = "camelCase")]
#[derive(Debug, Deserialize)]
pub struct PgResult {
    pub result: Vec<PortGroupMetrics>,
}

//START Section for Collecting VMAX StorageGroup list and StorageGroup Metrics different from the SLO information
//For Collecting the VMAX Array StorageGroup Listings
/* https://{server}/univmax/restapi/performance/StorageGroup/keys
{
  "symmetrixId" : "000196702346"
}
*/
#[serde(rename_all = "camelCase")]
#[derive(Debug, Deserialize, IntoPoint)]
pub struct StorageGroupsInfo {
    pub storage_group_id: String,
    pub first_available_date: u64,
    pub last_available_date: u64,
}

#[serde(rename_all = "camelCase")]
#[derive(Debug, Deserialize)]
pub struct StorageGroupArray {
    pub storage_group_info: Vec<StorageGroupsInfo>,
}

impl IntoPoint for StorageGroupArray {
    fn into_point(&self, name: Option<&str>, is_time_series: bool) -> Vec<TsPoint> {
        let mut points: Vec<TsPoint> = Vec::new();
        for s in &self.storage_group_info {
            points.extend(s.into_point(name, is_time_series));
        }
        points
    }
}

//For Collecting the VMAX Array StorageGroup Metrics
#[serde(rename_all = "PascalCase")]
#[derive(Debug, Deserialize, IntoPoint)]
pub struct StorageGroupMetrics {
    #[serde(rename = "HostIOs")]
    pub host_ios: f64,
    pub host_reads: f64,
    pub host_writes: f64,
    pub host_hits: f64,
    pub host_read_hits: f64,
    pub host_write_hits: f64,
    pub host_misses: f64,
    pub host_read_misses: f64,
    pub host_write_misses: f64,
    #[serde(rename = "HostMBs")]
    pub host_mbs: f64,
    #[serde(rename = "HostMBReads")]
    pub host_mb_reads: f64,
    #[serde(rename = "HostMBWritten")]
    pub host_mb_written: f64,
    pub read_response_time: f64,
    pub write_response_time: f64,
    pub read_miss_response_time: f64,
    pub write_miss_response_time: f64,
    pub percent_read: f64,
    pub percent_write: f64,
    pub percent_read_hit: f64,
    pub percent_write_hit: f64,
    pub percent_read_miss: f64,
    pub percent_write_miss: f64,
    #[serde(rename = "SeqIOs")]
    pub seq_ios: f64,
    #[serde(rename = "RandomIOs")]
    pub random_ios: f64,
    #[serde(rename = "AvgIOSize")]
    pub avg_io_size: f64,
    pub avg_read_size: f64,
    pub avg_write_size: f64,
    pub percent_hit: f64,
    pub percent_misses: f64,
    pub response_time: f64,
    pub allocated_capacity: f64,
    #[serde(rename = "PercentRandomIO")]
    pub percent_random_io: f64,
    #[serde(rename = "timestamp")]
    pub timestamp: u64,
}

//Since the returned value are an Object--> Object-Array of values, resultlist-result
#[serde(rename_all = "camelCase")]
#[derive(Debug, Deserialize)]
pub struct StorageGroupArrayMetrics {
    pub result_list: SgResult,
}

impl IntoPoint for StorageGroupArrayMetrics {
    fn into_point(&self, name: Option<&str>, is_time_series: bool) -> Vec<TsPoint> {
        self.result_list.into_point(name, is_time_series)
    }
}

impl IntoPoint for SgResult {
    fn into_point(&self, name: Option<&str>, is_time_series: bool) -> Vec<TsPoint> {
        let mut points: Vec<TsPoint> = Vec::new();
        for r in &self.result {
            let res = r.into_point(name, is_time_series);
            points.extend(res);
        }
        points
    }
}

//Since the returned value are Object-Object-Array of values, result-array of objects
#[serde(rename_all = "camelCase")]
#[derive(Debug, Deserialize)]
pub struct SgResult {
    pub result: Vec<StorageGroupMetrics>,
}

//START Section for Test Functions
//For Collecting the VMAX Array Front-end Directors Listing
#[test]
fn test_get_per_array_fed() {
    use std::fs::File;
    use std::io::Read;

    let mut f = File::open("tests/vmax/per_array_fed.json").unwrap();
    let mut buff = String::new();
    f.read_to_string(&mut buff).unwrap();

    let i: FedArray = serde_json::from_str(&buff).unwrap();
    println!("result: {:#?}", i);
}

//For Collecting the VMAX Array Metrics based upon the FED Listing
#[test]
fn test_get_per_array_fed_metrics() {
    use std::fs::File;
    use std::io::Read;

    let mut f = File::open("tests/vmax/per_array_fed_metrics.json").unwrap();
    let mut buff = String::new();
    f.read_to_string(&mut buff).unwrap();

    let i: FedArrayMetrics = serde_json::from_str(&buff).unwrap();
    println!("result: {:#?}", i);
}

//For Collecting the VMAX Array PortGroup Listings
#[test]
fn test_get_per_array_portgroup() {
    use std::fs::File;
    use std::io::Read;

    let mut f = File::open("tests/vmax/per_array_portgroup.json").unwrap();
    let mut buff = String::new();
    f.read_to_string(&mut buff).unwrap();

    let i: PortGroupArray = serde_json::from_str(&buff).unwrap();
    println!("result: {:#?}", i);
}

//For Collecting the VMAX Array PortGroups Metrics
#[test]
fn test_get_per_array_portgroup_metrics() {
    use std::fs::File;
    use std::io::Read;

    let mut f = File::open("tests/vmax/per_array_portgroup_metrics.json").unwrap();
    let mut buff = String::new();
    f.read_to_string(&mut buff).unwrap();

    let i: PortGroupArrayMetrics = serde_json::from_str(&buff).unwrap();
    println!("result: {:#?}", i);
}

//For Collecting the VMAX Array StorageGroup Listings
#[test]
fn test_get_per_array_storagegroup() {
    use std::fs::File;
    use std::io::Read;

    let mut f = File::open("tests/vmax/per_array_storagegroup.json").unwrap();
    let mut buff = String::new();
    f.read_to_string(&mut buff).unwrap();

    let i: StorageGroupArray = serde_json::from_str(&buff).unwrap();
    println!("result: {:#?}", i);
}

//For Collecting the VMAX Array StorageGroups Metrics
#[test]
fn test_get_per_array_storagegroup_metrics() {
    use std::fs::File;
    use std::io::Read;

    let mut f = File::open("tests/vmax/per_array_storagegroup_metrics2.json").unwrap();
    let mut buff = String::new();
    f.read_to_string(&mut buff).unwrap();

    let i: StorageGroupArrayMetrics = serde_json::from_str(&buff).unwrap();
    println!("result: {:#?}", i);
}

//For Collecting the VMAX Array System Properties Metrics. This includes the RAW array values for capacity
//which is found in the GUI Unisphere --> Array --> System --> Symmetrix Properties
//https://[username]:[password]@[Unisphere Server]:8443/univmax/restapi/90/sloprovisioning/symmetrix/[Array S/N]
#[test]
fn test_get_slo_provisioning_system_properties() {
    use std::fs::File;
    use std::io::Read;

    let mut f = File::open("tests/vmax/slo_provisioning_system_properties.json").unwrap();
    let mut buff = String::new();
    f.read_to_string(&mut buff).unwrap();

    let i: VmaxSystemCapacity = serde_json::from_str(&buff).unwrap();
    println!("result: {:#?}", i);
}
// END Section for Test Functions

// This is split into objects and sub-objects based upon the new Unisphere release v9
// Added Option here since some of the arrays polled are not returning the same output, may need to be updated again down the road
#[derive(Debug, Deserialize)]
pub struct VmaxSystemCapacity {
    #[serde(rename = "symmetrixId")]
    pub symmetrix_id: String,
    pub device_count: u64,
    pub ucode: String,
    #[serde(rename = "targetUcode")]
    pub targetucode: Option<String>,
    pub model: String,
    pub local: bool,
    pub default_fba_srp: String,
    pub host_visible_device_count: u64,
    pub system_capacity: SystemCapacity,
    pub system_efficiency: SystemEfficiency,
    pub meta_data_usage: MetaDataUsage,
    #[serde(rename = "sloCompliance")]
    pub slo_compliance: SloComplianceSys,
    #[serde(rename = "physicalCapacity")]
    pub physical_capacity: PhysicalCapacity,
}

impl IntoPoint for VmaxSystemCapacity {
    fn into_point(&self, name: Option<&str>, is_time_series: bool) -> Vec<TsPoint> {
        let mut p = TsPoint::new(name.unwrap_or("vmax_system_capacity"), is_time_series);
        p.add_tag("symmetrix_id", TsValue::String(self.symmetrix_id.clone()));
        p.add_field("device_count", TsValue::Long(self.device_count));
        p.add_field("ucode", TsValue::String(self.ucode.clone()));
        if let Some(ref target_ucode) = self.targetucode {
            p.add_field("targetucode", TsValue::String(target_ucode.clone()));
        }
        p.add_field("model", TsValue::String(self.model.clone()));
        p.add_field("local", TsValue::Boolean(self.local));
        p.add_tag(
            "default_fba_srp",
            TsValue::String(self.default_fba_srp.clone()),
        );
        p.add_field(
            "host_visible_device_count",
            TsValue::Long(self.host_visible_device_count),
        );
        self.system_capacity.sub_point(&mut p);
        self.system_efficiency.sub_point(&mut p);
        self.meta_data_usage.sub_point(&mut p);
        self.slo_compliance.sub_point(&mut p);
        self.physical_capacity.sub_point(&mut p);
        vec![p]
    }
}

#[allow(non_snake_case)]
#[derive(Debug, Deserialize)]
pub struct SystemCapacity {
    pub subscribed_allocated_tb: f64,
    pub subscribed_total_tb: f64,
    pub snapshot_modified_tb: f64,
    pub snapshot_total_tb: f64,
    pub usable_used_tb: f64,
    pub usable_total_tb: f64,
    pub subscribed_usable_capacity_percent: f64,
}

// This implements a new impl for sub_point based upon EMC metrics
// Use a tags for the those metrics defined as String value and field for the remaining, but not both
impl ChildPoint for SystemCapacity {
    fn sub_point(&self, p: &mut TsPoint) {
        p.add_field(
            "subscribed_allocated_tb",
            TsValue::Float(self.subscribed_allocated_tb),
        );
        p.add_field(
            "subscribed_total_tb",
            TsValue::Float(self.subscribed_total_tb),
        );
        p.add_field(
            "snapshot_modified_tb",
            TsValue::Float(self.snapshot_modified_tb),
        );
        p.add_field("snapshot_total_tb", TsValue::Float(self.snapshot_total_tb));
        p.add_field("usable_used_tb", TsValue::Float(self.usable_used_tb));
        p.add_field("usable_total_tb", TsValue::Float(self.usable_total_tb));
        p.add_field(
            "subscribed_usable_capacity_percent",
            TsValue::Float(self.subscribed_usable_capacity_percent),
        );
    }
}

#[allow(non_snake_case)]
#[derive(Debug, Deserialize)]
pub struct SystemEfficiency {
    pub overall_efficiency_ratio_to_one: f64,
    pub data_reduction_enabled_percent: f64,
    pub virtual_provisioning_savings_ratio_to_one: f64,
}

impl ChildPoint for SystemEfficiency {
    fn sub_point(&self, p: &mut TsPoint) {
        p.add_field(
            "overall_efficiency_ratio_to_one",
            TsValue::Float(self.overall_efficiency_ratio_to_one),
        );
        p.add_field(
            "data_reduction_enabled_percent",
            TsValue::Float(self.data_reduction_enabled_percent),
        );
        p.add_field(
            "virtual_provisioning_savings_ratio_to_one",
            TsValue::Float(self.virtual_provisioning_savings_ratio_to_one),
        );
    }
}

// Added Option here since some of the arrays polled are not returning the same output, may need to be updated again down the road
#[allow(non_snake_case)]
#[derive(Debug, Deserialize)]
pub struct MetaDataUsage {
    pub system_meta_data_used_percent: Option<f64>,
    pub replication_cache_used_percent: u64,
}

impl ChildPoint for MetaDataUsage {
    fn sub_point(&self, p: &mut TsPoint) {
        if let Some(system_meta_data) = self.system_meta_data_used_percent {
            p.add_field(
                "system_meta_data_used_percent",
                TsValue::Float(system_meta_data),
            );
        }
        p.add_field(
            "replication_cache_used_percent",
            TsValue::Long(self.replication_cache_used_percent),
        );
    }
}

#[allow(non_snake_case)]
#[derive(Debug, Deserialize)]
pub struct SloComplianceSys {
    pub slo_stable: i64,
    pub slo_marginal: i64,
    pub slo_critical: i64,
    pub no_slo: i64,
}

impl ChildPoint for SloComplianceSys {
    fn sub_point(&self, p: &mut TsPoint) {
        p.add_field("slo_stable", TsValue::SignedLong(self.slo_stable));
        p.add_field("slo_marginal", TsValue::SignedLong(self.slo_marginal));
        p.add_field("slo_critical", TsValue::SignedLong(self.slo_critical));
        p.add_field("no_slo", TsValue::SignedLong(self.no_slo));
    }
}

#[allow(non_snake_case)]
#[derive(Debug, Deserialize)]
pub struct PhysicalCapacity {
    pub used_capacity_gb: f64,
    pub total_capacity_gb: f64,
}

impl ChildPoint for PhysicalCapacity {
    fn sub_point(&self, p: &mut TsPoint) {
        p.add_field("used_capacity_gb", TsValue::Float(self.used_capacity_gb));
        p.add_field("total_capacity_gb", TsValue::Float(self.total_capacity_gb));
    }
}

#[derive(Debug, Deserialize, IntoPoint)]
pub struct Volume {
    #[serde(rename = "volumeId")]
    pub volume_id: String,
    #[serde(rename = "type")]
    pub volume_type: Option<String>,
    pub emulation: Option<String>,
    pub ssid: Option<String>,
    pub allocated_percent: Option<u64>,
    pub cap_gb: Option<f64>,
    pub cap_mb: Option<f64>,
    pub cap_cyl: Option<u64>,
    pub status: Option<String>,
    pub reserved: Option<bool>,
    pub pinned: Option<bool>,
    pub physical_name: Option<String>,
    pub volume_identifier: Option<String>,
    pub wwn: Option<String>,
    pub encapsulated: Option<bool>,
    pub num_of_storage_groups: Option<u64>,
    pub num_of_front_end_paths: Option<u64>,
    #[serde(rename = "storageGroupId")]
    pub storage_group_id: Option<Vec<String>>,
    // ignoring these two fields as they are not needed,
    // and don't have to store an array unnecessarily
    //#[serde(rename = "symmetrixPortKey")]
    //pub symmetrix_port_key: Option<Vec<SymmetrixPortKey>>,
    //#[serde(rename = "rdfGroupId")]
    //pub rdf_group_id: Option<Vec<u64>>,
    pub snapvx_source: Option<bool>,
    pub snapvx_target: Option<bool>,
    pub cu_image_base_address: Option<String>,
    pub has_effective_wwn: Option<bool>,
    pub effective_wwn: Option<String>,
    pub encapsulated_wwn: Option<String>,
}

#[test]
fn test_get_vmax_json_volume() {
    use std::fs::File;
    use std::io::Read;

    let mut f = File::open("tests/vmax/slo_volume.json").unwrap();
    let mut buff = String::new();
    f.read_to_string(&mut buff).unwrap();

    let i: Volume = serde_json::from_str(&buff).unwrap();
    println!("result: {:#?}", i);
    let v: Vec<TsPoint> = i
        .into_point(Some("vmax_slo_volume"), false)
        .into_iter()
        .map(|mut v| {
            v.add_tag("symmetrix_id", TsValue::String("some_string".to_string()));
            v
        })
        .collect();
    println!("point: {:#?}", v);
}

#[test]
/// Test retrieving one page of volumes from json
fn test_get_vmax_json_volumes() {
    use std::fs::File;
    use std::io::Read;

    let mut f = File::open("tests/vmax/slo_volumes.json").unwrap();
    let mut buff = String::new();
    f.read_to_string(&mut buff).unwrap();

    let data: Value = serde_json::from_str(&buff).unwrap();

    // grab the list from what was returned before calling the iterator
    let all_volume_ids = match data["resultList"]["result"].as_array() {
        Some(v) => v
            .iter()
            .map(|val| {
                val.as_object()
                    .unwrap()
                    .values()
                    .map(|v_i| v_i.as_str().unwrap().to_string())
                    .collect::<String>()
            })
            .collect(),
        None => vec![],
    };

    println!("Volume IDs: {:?}", all_volume_ids);
}

impl Vmax {
    /* These are the GET and POST functions depending upon the output needed
     */
    fn get_data<T>(
        &self,
        api_endpoint: &str,
        point_name: &str,
        is_time_series: bool,
    ) -> MetricsResult<Vec<TsPoint>>
    where
        T: DeserializeOwned + Debug + IntoPoint,
    {
        let url = format!(
            "https://{}/univmax/restapi/{}",
            self.config.endpoint, api_endpoint,
        );
        let j: T = crate::get(
            &self.client,
            &url,
            &self.config.user,
            Some(&self.config.password),
        )?;

        Ok(j.into_point(Some(point_name), is_time_series))
    }

    /* Changed the GET to POST and added body parameter to pass additional fields to
     */
    fn post_data_to_points<T, U>(
        &self,
        api_endpoint: &str,
        body: &U,
        point_name: &str,
        is_time_series: bool,
    ) -> MetricsResult<Vec<TsPoint>>
    where
        T: DeserializeOwned + Debug + IntoPoint,
        U: Serialize + ?Sized,
    {
        let array_output = self
            .client
            .post(&format!(
                "https://{}/univmax/restapi/{}",
                self.config.endpoint, api_endpoint,
            ))
            .basic_auth(&self.config.user, Some(&self.config.password))
            .header(ACCEPT, "application/json")
            .json(body)
            .send()?
            .error_for_status()?
            .text()?;
        trace!("{}", array_output);
        let json_res: Result<T, serde_json::Error> = serde_json::from_str(&array_output);
        trace!("json result: {:?}", json_res);
        let json_res = json_res?;
        Ok(json_res.into_point(Some(point_name), is_time_series))
    }

    /* Changed the GET to POST and added body parameter to pass additional field to w/o IntoPoint
    So this is good for capturing info w/o reporting into the back-end
    */
    fn post_data<T, U>(&self, api_endpoint: &str, body: &U) -> MetricsResult<T>
    where
        T: DeserializeOwned + Debug,
        U: Serialize + ?Sized,
    {
        let array_output = self
            .client
            .post(&format!(
                "https://{}/univmax/restapi/{}",
                self.config.endpoint, api_endpoint,
            ))
            .basic_auth(&self.config.user, Some(&self.config.password))
            .header(ACCEPT, "application/json")
            .json(body)
            .send()?
            .error_for_status()?
            .text()?;
        trace!("{}", array_output);
        let json_res: Result<T, serde_json::Error> = serde_json::from_str(&array_output);
        trace!("json result: {:?}", json_res);
        let json_res = json_res?;
        Ok(json_res)
    }

    // This function is for get_data only, the get_list was not needed. Note the '90' for v9 of the EMC Unisphere software
    pub fn get_vmax_array_raw(&self, symmetrixid: &str) -> MetricsResult<Vec<TsPoint>> {
        let vmax_raw = self.get_data::<VmaxSystemCapacity>(
            &format!("90/sloprovisioning/symmetrix/{}", symmetrixid),
            "vmax_array_raw",
            true,
        )?;
        debug!("result: {:#?}", vmax_raw);
        Ok(vmax_raw)
    }
    // Grab the list of things to operate on from vmax
    fn get_list(&self, api_endpoint: &str, key: &str) -> MetricsResult<Vec<String>> {
        let data: Value = self
            .client
            .get(&format!(
                "https://{}/univmax/restapi/{}",
                self.config.endpoint, api_endpoint,
            ))
            .basic_auth(&self.config.user, Some(&self.config.password))
            .send()?
            .error_for_status()?
            .json()?;

        // Grab the list from the json
        match data[key].as_array() {
            Some(v) => Ok(v
                .iter()
                .map(|val| val.as_str().expect("Failed to retrieve key").to_string())
                .collect::<Vec<String>>()),
            None => Ok(vec![]),
        }
    }

    /*Setting up new function for Metrics Collection. StartDate and endDate are in milliseconds
    https://{server}/univmax/restapi/performance/FEDirector/metrics
    {
      "startDate"   : "1522104538975",
      "endDate"     : "1522104573437",
      "symmetrixId" : "000196702346",
      "dataFormat"  : "Average",
      "metrics"     : [ "AvgRDFSWriteResponseTime","AvgReadMissResponseTime","AvgWPDiscTime", "AvgTimePerSyscall", "DeviceWPEvents","HostMBs","HitReqs","HostIOs","MissReqs","PercentBusy","PercentWriteReqs","PercentReadReqs" ],
      "directorId"  : "FA-1D"
    }
    The startDate and endDate are timestamp in milliseconds, the dataFormat is set to static "Average"
    */
    pub fn get_fed_metrics(
        &self,
        startdate: u64,
        enddate: u64,
        symmetrix_id: &str,
        director_id: &str,
        _dataformat: &str,
    ) -> MetricsResult<Vec<TsPoint>> {
        let vmaxmetrics = json! ({
            "startDate" : startdate.to_string(),
            "endDate" : enddate.to_string(),
            "symmetrixId" : symmetrix_id,
            "dataFormat" : "Average",
            "directorId" : director_id,
            "metrics" : [
                "AvgReadMissResponseTime","AvgWPDiscTime", "AvgTimePerSyscall", "DeviceWPEvents","HostMBs","HitReqs","HostIOs","MissReqs","PercentBusy","PercentWriteReqs","PercentReadReqs","PercentHitReqs","HostIOLimitMBs","AvgOptimizedReadMissSize","OptimizedMBReadMisses","OptimizedReadMisses","PercentReadReqHit","PercentWriteReqHit","QueueDepthUtilization","HostIOLimitIOs","ReadReqs","ReadHitReqs","ReadMissReqs","Reqs","ReadResponseTime","WriteResponseTime","SlotCollisions","SystemWPEvents","TotalReadCount","TotalWriteCount","WriteReqs","WriteHitReqs","WriteMissReqs"
            ]
        });
        debug!("Sending: {} to array", vmaxmetrics);
        let points = self.post_data_to_points::<FedArrayMetrics, Value>(
            "performance/FEDirector/metrics/",
            &vmaxmetrics,
            "fedvmaxmetrics",
            true,
        )?;
        Ok(points)
    }

    /*This is for adding the information for the Directors based upon the symmetrixId
    https://{server}/univmax/restapi/performance/FEDirector/keys
    {
      "symmetrixId" : "000196702346"
    }
    */
    pub fn get_fed_directors(&self, symmetrixid: &str) -> MetricsResult<Vec<String>> {
        let vmaxdirectors = json! ({
            "symmetrixId" : symmetrixid,
        });
        let fedmet: FedArray =
            self.post_data::<FedArray, Value>("performance/FEDirector/keys/", &vmaxdirectors)?;
        let ids: Vec<String> = fedmet
            .fe_director_info
            .iter()
            .map(|f| f.director_id.clone())
            .collect();
        Ok(ids)
    }
    //END Section for Collecting VMAX Front-End Port list and Front-End Port Metrics

    pub fn get_storagegroup_metrics(
        &self,
        startdate: u64,
        enddate: u64,
        symmetrix_id: &str,
        storage_group_id: &str,
        _dataformat: &str,
    ) -> MetricsResult<Vec<TsPoint>> {
        let vmaxsgmetrics = json! ({
            "startDate" : startdate.to_string(),
            "endDate" : enddate.to_string(),
            "symmetrixId" : symmetrix_id,
            "dataFormat" : "Average",
            "storageGroupId" : storage_group_id,
            "metrics" : [
                "HostIOs", "HostReads", "HostWrites", "HostHits", "HostReadHits", "HostWriteHits", "HostMisses", "HostReadMisses", "HostWriteMisses", "HostMBs", "HostMBReads", "HostMBWritten", "ReadResponseTime", "WriteResponseTime", "ReadMissResponseTime", "WriteMissResponseTime", "PercentRead", "PercentWrite", "PercentReadHit", "PercentWriteHit", "PercentReadMiss", "PercentWriteMiss", "SeqIOs", "RandomIOs", "AvgIOSize", "AvgReadSize", "AvgWriteSize", "PercentHit", "PercentMisses", "ResponseTime", "AllocatedCapacity", "PercentRandomIO"
            ]
        });
        let points = self.post_data_to_points::<StorageGroupArrayMetrics, Value>(
            "performance/StorageGroup/metrics/",
            &vmaxsgmetrics,
            "storagegroupvmaxmetrics",
            true,
        )?;
        Ok(points)
    }

    pub fn get_storagegroups(&self, symmetrix_id: &str) -> MetricsResult<Vec<String>> {
        let vmaxstoragegroups = json! ({
            "symmetrixId" : symmetrix_id,
        });
        let sgmet: StorageGroupArray = self.post_data::<StorageGroupArray, Value>(
            "performance/StorageGroup/keys/",
            &vmaxstoragegroups,
        )?;
        let ids: Vec<String> = sgmet
            .storage_group_info
            .iter()
            .map(|f| f.storage_group_id.clone())
            .collect();
        Ok(ids)
    }
    //END Section for Collecting VMAX StorageGroup list and StorageGroup Metrics
    pub fn get_portgroup_metrics(
        &self,
        startdate: u64,
        enddate: u64,
        symmetrix_id: &str,
        port_group_id: &str,
        _dataformat: &str,
    ) -> MetricsResult<Vec<TsPoint>> {
        let vmaxpgmetrics = json! ({
            "startDate" : startdate.to_string(),
            "endDate" : enddate.to_string(),
            "symmetrixId" : symmetrix_id,
            "dataFormat" : "Average",
            "portGroupId" : port_group_id,
            "metrics" : [
                "Reads","Writes","IOs","MBRead","MBWritten","MBs","AvgIOSize","PercentBusy"
            ]
        });
        let points = self.post_data_to_points::<PortGroupArrayMetrics, Value>(
            "performance/PortGroup/metrics/",
            &vmaxpgmetrics,
            "portgroupvmaxmetrics",
            true,
        )?;
        Ok(points)
    }

    pub fn get_portgroups(&self, symmetrix_id: &str) -> MetricsResult<Vec<String>> {
        let vmaxportgroups = json! ({
            "symmetrixId" : symmetrix_id,
        });
        let pgmet: PortGroupArray = self
            .post_data::<PortGroupArray, Value>("performance/PortGroup/keys/", &vmaxportgroups)?;
        let ids: Vec<String> = pgmet
            .port_group_info
            .iter()
            .map(|f| f.port_group_id.clone())
            .collect();
        Ok(ids)
    }
    //END Section for Collecting VMAX PortGroup list and PortGroup Metrics
    pub fn get_slo_array_storagegroups(&self, id: &str) -> MetricsResult<Vec<String>> {
        let groups = self.get_list(
            &format!("sloprovisioning/symmetrix/{}/storagegroup", id),
            "storageGroupId",
        )?;
        Ok(groups)
    }

    pub fn get_slo_array_storagegroup(&self, id: &str, group: &str) -> MetricsResult<Vec<TsPoint>> {
        let points = self.get_data::<StorageGroups>(
            &format!("sloprovisioning/symmetrix/{}/storagegroup/{}", id, group),
            "vmax_slo_array_storagegroup",
            false,
        )?;
        let points_with_symid = points
            .into_iter()
            .map(|mut s| {
                s.add_tag("symmetrix_id", TsValue::String(id.to_string()));
                s
            })
            .collect();
        Ok(points_with_symid)
    }

    pub fn get_slo_array_srps(&self, id: &str) -> MetricsResult<Vec<String>> {
        let srps = self.get_list(&format!("sloprovisioning/symmetrix/{}/srp", id), "srpId")?;
        Ok(srps)
    }

    pub fn get_slo_array_srp(&self, id: &str, srp: &str) -> MetricsResult<Vec<TsPoint>> {
        let points = self.get_data::<Srps>(
            &format!("sloprovisioning/symmetrix/{}/srp/{}", id, srp),
            "slo_array_srp",
            true,
        )?;
        Ok(points)
    }

    pub fn get_slo_arrays(&self) -> MetricsResult<Vec<String>> {
        let arrays = self.get_list("sloprovisioning/symmetrix", "symmetrixId")?;
        Ok(arrays)
    }

    pub fn get_slo_array(&self, id: &str) -> MetricsResult<Vec<TsPoint>> {
        let points = self.get_data::<Symmetrix>(
            &format!("sloprovisioning/symmetrix/{}", id),
            "symmetrix",
            true,
        )?;
        Ok(points)
    }

    /// Returns a list of volume IDs for this array
    // TODO: combine this with the other getters and generalize along with other metrics
    pub fn get_all_slo_volumes(&self, symmetrixid: &str) -> MetricsResult<Vec<String>> {
        let data: Value = super::get(
            &self.client,
            &format!(
                "https://{}/univmax/restapi/90/sloprovisioning/symmetrix/{}/volume",
                self.config.endpoint, symmetrixid
            ),
            &self.config.user,
            Some(&self.config.password),
        )?;

        let vol_count = data["count"].as_u64().unwrap_or(0);
        let iterator_id = data["id"].as_str().unwrap_or("");
        let max_count_per_page = data["maxPageSize"].as_u64().unwrap_or(0);
        debug!(
            "Volume count {}, max count per page {}, iterator id {}",
            vol_count, max_count_per_page, iterator_id
        );

        if vol_count == 0 || max_count_per_page == 0 || iterator_id.is_empty() {
            return Ok(vec![]);
        }
        let mut num_iterations = vol_count / max_count_per_page;

        // grab the list from what was returned before calling the iterator
        let mut all_volume_ids = match data["resultList"]["result"].as_array() {
            Some(v) => v
                .iter()
                .map(|val| {
                    val.as_object()
                        .expect("Failed to find volume ID object")
                        .values()
                        .map(|v_i| {
                            v_i.as_str()
                                .expect("Failed to retrieve volume ID")
                                .to_string()
                        })
                        .collect::<String>()
                })
                .collect(),
            None => vec![],
        };
        while num_iterations != 0 {
            let from = all_volume_ids.len() + 1;
            let mut to = all_volume_ids.len() as u64 + max_count_per_page;
            if to > vol_count {
                to = vol_count;
            }
            debug!("Gathering volumes from {} to {}", from, to);
            let data: Value = super::get(
                &self.client,
                &format!(
                    "https://{}/univmax/restapi/common/Iterator/{}/page?from={}&to={}",
                    self.config.endpoint, iterator_id, from, to
                ),
                &self.config.user,
                Some(&self.config.password),
            )?;

            let page_vols = match data["result"].as_array() {
                Some(v) => v
                    .iter()
                    .map(|val| {
                        val.as_object()
                            .expect("Failed to find volume ID object")
                            .values()
                            .map(|v_i| {
                                v_i.as_str()
                                    .expect("Failed to retrieve volume ID")
                                    .to_string()
                            })
                            .collect::<String>()
                    })
                    .collect(),
                None => vec![],
            };
            all_volume_ids.extend(page_vols);
            debug!("Gathered {} volume IDs", all_volume_ids.len());
            num_iterations -= 1;
        }
        Ok(all_volume_ids)
    }

    pub fn get_slo_volume(
        &self,
        volume_id: &str,
        symmetrixid: &str,
    ) -> MetricsResult<Vec<TsPoint>> {
        let volume = self.get_data::<Volume>(
            &format!(
                "90/sloprovisioning/symmetrix/{}/volume/{}",
                symmetrixid, volume_id
            ),
            "vmax_slo_volume",
            true,
        )?;
        let new_vol = volume
            .into_iter()
            .map(|mut v| {
                v.add_tag("symmetrix_id", TsValue::String(symmetrixid.to_string()));
                v
            })
            .collect();
        Ok(new_vol)
    }
}