1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
use std::time::Duration;
use axum::body::Bytes;
use futures_util::Stream;
use rusty_s3::actions::{GetObject, HeadObject, ListObjectsV2, PutObject, S3Action};
use rusty_s3::{Bucket, Credentials, UrlStyle};
use crate::error::Error;
use crate::namespace::Namespace;
// The same layout as the local store, for the same reasons. The bytes live once
// under a key derived from their digest, and a repository that holds them owns
// an empty marker beside it — the object store's answer to a hard link. It is
// what keeps two projects sharing an asset pack from paying twice, and what
// stops a repository reading an object it never pushed: the marker is the proof
// of possession, and it is the only thing the permission check consults.
#[derive(Clone)]
pub struct S3Store {
bucket: Bucket,
credentials: Credentials,
client: reqwest::Client,
lifetime: Duration,
redirect: bool,
}
pub struct S3Config {
pub endpoint: String,
pub bucket: String,
pub region: String,
pub access_key: String,
pub secret_key: String,
pub path_style: bool,
pub redirect: bool,
// How long a signature is good for. It is the same number the batch
// response advertises as `expires_in`, because a client told it has half an
// hour and handed a URL that dies in five minutes will fail a resume it had
// every reason to expect to work.
pub lifetime: Duration,
}
impl S3Store {
pub fn new(config: &S3Config) -> Result<Self, Error> {
let style = if config.path_style {
UrlStyle::Path
} else {
UrlStyle::VirtualHost
};
let bucket = Bucket::new(
config
.endpoint
.parse()
.map_err(|_| Error::Misconfigured("LFSX_S3_ENDPOINT is not a URL"))?,
style,
config.bucket.clone(),
config.region.clone(),
)
.map_err(|_| Error::Misconfigured("LFSX_S3_BUCKET is not a usable bucket name"))?;
Ok(Self {
bucket,
credentials: Credentials::new(config.access_key.clone(), config.secret_key.clone()),
client: reqwest::Client::new(),
lifetime: config.lifetime,
redirect: config.redirect,
})
}
fn content_key(oid: &str) -> String {
format!(".content/{}/{}/{oid}", &oid[0..2], &oid[2..4])
}
fn marker_key(ns: &Namespace, oid: &str) -> String {
format!(
"{}/{}/{}/{}/{oid}",
ns.org(),
ns.repo(),
&oid[0..2],
&oid[2..4]
)
}
pub async fn exists(&self, ns: &Namespace, oid: &str) -> bool {
if crate::storage::LocalStore::validate_oid(oid).is_err() {
return false;
}
self.head(&Self::marker_key(ns, oid)).await.is_ok()
}
// Signed as a HEAD rather than reusing a GET signature: SigV4 covers the
// method, and an implementation that checks it — which is the point of
// testing against MinIO and Garage rather than only AWS — is entitled to
// refuse the mismatch.
async fn head(&self, key: &str) -> Result<u64, Error> {
let action = HeadObject::new(&self.bucket, Some(&self.credentials), key);
let url = action.sign(self.lifetime);
let response = self.client.head(url).send().await.map_err(|_| {
Error::Storage(std::io::Error::other("the object store is unreachable"))
})?;
if !response.status().is_success() {
return Err(Error::NotFound);
}
// Read the header rather than the body length: a HEAD has no body, and
// asking the response how long it is answers about what was received
// rather than what is there.
response
.headers()
.get(reqwest::header::CONTENT_LENGTH)
.and_then(|value| value.to_str().ok())
.and_then(|value| value.parse().ok())
.ok_or_else(|| {
Error::Storage(std::io::Error::other(
"the object store gave no object size",
))
})
}
pub async fn size_of(&self, oid: &str) -> Result<u64, Error> {
// Every entry point validates before slicing an oid into a key: the
// fanout takes the first four characters, so a short one is a panic
// rather than a refusal, and a panic is a 500 for something that should
// have been a 422.
crate::storage::LocalStore::validate_oid(oid)?;
self.head(&Self::content_key(oid)).await
}
// A download is streamed through this server rather than redirected, so the
// features that live in the byte path — the counters, the ranges, and the
// compression that will follow — keep working. The pre-signed redirect is a
// separate mode for operators who would rather spend the object store's
// bandwidth than their own.
pub async fn read(
&self,
oid: &str,
start: u64,
length: u64,
) -> Result<impl Stream<Item = Result<Bytes, reqwest::Error>> + use<>, Error> {
crate::storage::LocalStore::validate_oid(oid)?;
let key = Self::content_key(oid);
let action = GetObject::new(&self.bucket, Some(&self.credentials), &key);
let url = action.sign(self.lifetime);
let response = self
.client
.get(url)
.header(
reqwest::header::RANGE,
format!("bytes={start}-{}", start + length.saturating_sub(1)),
)
.send()
.await
.map_err(|_| {
Error::Storage(std::io::Error::other("the object store is unreachable"))
})?;
if !response.status().is_success() {
return Err(Error::NotFound);
}
Ok(response.bytes_stream())
}
// A URL the client fetches from the bucket directly, so the bytes never
// cross this server. Whether the caller is entitled to them has already been
// settled by the marker before this is called: the signature is scoped to
// one content key and expires, and it grants nothing the batch response was
// not about to grant anyway.
pub fn presigned_download(&self, oid: &str) -> Option<String> {
if !self.redirect || crate::storage::LocalStore::validate_oid(oid).is_err() {
return None;
}
let key = Self::content_key(oid);
Some(
GetObject::new(&self.bucket, Some(&self.credentials), &key)
.sign(self.lifetime)
.to_string(),
)
}
async fn put(&self, key: &str, body: reqwest::Body, length: u64) -> Result<(), Error> {
let action = PutObject::new(&self.bucket, Some(&self.credentials), key);
let url = action.sign(self.lifetime);
let response = self
.client
.put(url)
// S3 has no use for a chunked body and answers 501 rather than
// starting the upload. reqwest cannot infer a length from a stream,
// so it comes from the staging file being sent.
.header(reqwest::header::CONTENT_LENGTH, length)
.body(body)
.send()
.await
.map_err(|_| {
Error::Storage(std::io::Error::other("the object store is unreachable"))
})?;
let status = response.status();
if !status.is_success() {
// The store says why in the body, and an operator staring at a
// failing push has nothing else to go on: a bucket that does not
// exist, a key that is denied and a clock that has drifted are three
// different afternoons.
let detail = response.text().await.unwrap_or_default();
return Err(Error::Storage(std::io::Error::other(format!(
"the object store refused a write with {status}: {}",
detail.trim()
))));
}
Ok(())
}
// The upload has already been streamed to a staging file, hashed and checked
// against everything the server enforces, so that file is what goes up —
// streamed from disk rather than read into memory, because an object here is
// measured in gigabytes and the whole storage layer is built on holding at
// most a few megabytes of one at a time.
//
// The bytes go up once, keyed by their digest, and the marker records that
// this repository holds them. Content that is already there is skipped: the
// key would receive the same bytes it already has.
pub async fn store(
&self,
ns: &Namespace,
oid: &str,
staged: &std::path::Path,
) -> Result<(), Error> {
crate::storage::LocalStore::validate_oid(oid)?;
if self.head(&Self::content_key(oid)).await.is_err() {
let file = tokio::fs::File::open(staged).await?;
let length = file.metadata().await?.len();
let stream = tokio_util::io::ReaderStream::new(file);
self.put(
&Self::content_key(oid),
reqwest::Body::wrap_stream(stream),
length,
)
.await?;
}
self.put(
&Self::marker_key(ns, oid),
reqwest::Body::from(Vec::new()),
0,
)
.await
}
// What the bucket holds for this repository, counted from its markers and
// the content they point at. The markers are empty, so their own size says
// nothing — this is a listing plus one head per object, which is why the
// figure is cached the same way the local one is.
pub async fn usage_of(&self, ns: &Namespace) -> (u64, u64) {
let prefix = format!("{}/{}/", ns.org(), ns.repo());
let mut objects = 0;
let mut bytes = 0;
for oid in self.list(&prefix).await {
objects += 1;
bytes += self.size_of(&oid).await.unwrap_or_default();
}
(objects, bytes)
}
async fn list(&self, prefix: &str) -> Vec<String> {
let mut action = ListObjectsV2::new(&self.bucket, Some(&self.credentials));
action.with_prefix(prefix);
// Every step logs what stopped it rather than returning an empty
// listing: a capacity figure that silently reads zero is worse than one
// that is missing, because it looks like an answer.
let response = match self.client.get(action.sign(self.lifetime)).send().await {
Ok(response) => response,
Err(error) => {
tracing::warn!(%error, "the object store could not be listed");
return Vec::new();
}
};
let body = match response.text().await {
Ok(body) => body,
Err(error) => {
tracing::warn!(%error, "the listing could not be read");
return Vec::new();
}
};
let listing = match ListObjectsV2::parse_response(&body) {
Ok(listing) => listing,
Err(error) => {
tracing::warn!(%error, "the listing could not be parsed");
return Vec::new();
}
};
listing
.contents
.into_iter()
.filter_map(|object| object.key.rsplit('/').next().map(str::to_owned))
.filter(|oid| crate::storage::LocalStore::validate_oid(oid).is_ok())
.collect()
}
}
#[cfg(test)]
pub(crate) mod tests;