1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
pub(crate) mod keyspace;
use std::time::Duration;
use axum::body::Bytes;
use futures_util::Stream;
use base64::Engine;
use crate::error::Error;
use crate::namespace::Namespace;
use crate::storage::Reclaimed;
pub use keyspace::{Keyspace, Presigned};
const CHECKSUM: &str = "x-amz-checksum-sha256";
pub struct S3Config {
pub endpoint: String,
pub bucket: String,
pub region: String,
pub access_key: String,
pub secret_key: String,
pub path_style: bool,
// How long a signature is good for. It is the same number the batch
// response advertises as `expires_in`, because a client told it has half an
// hour and handed a URL that dies in five minutes will fail a resume it had
// every reason to expect to work.
pub lifetime: Duration,
}
// The same layout as the local store, for the same reasons. The bytes live once
// under a key derived from their digest, and a repository that holds them owns
// an empty marker beside it — the object store's answer to a hard link. It is
// what keeps two projects sharing an asset pack from paying twice, and what
// stops a repository reading an object it never pushed: the marker is the proof
// of possession, and it is the only thing the permission check consults.
//
// Everything below is object semantics. What it takes to talk to the store at
// all — signing, retrying, listing, the client — is the keyspace underneath.
#[derive(Clone)]
pub struct S3Store {
keys: Keyspace,
redirect: bool,
}
impl S3Store {
pub fn new(keys: Keyspace, redirect: bool) -> Self {
Self { keys, redirect }
}
fn content_key(oid: &str) -> String {
format!(".content/{}/{}/{oid}", &oid[0..2], &oid[2..4])
}
// Where a client uploads to when the bytes never pass through this server.
// Per repository on purpose: the shared content key would take bytes from
// anyone allowed to write, and then nothing distinguishes a repository that
// uploaded an object from one that merely knew its digest. A key only this
// repository was handed a signature for is the proof of possession that the
// marker stands for everywhere else.
fn incoming_key(ns: &Namespace, oid: &str) -> String {
format!(
".incoming/{}/{}/{}/{}/{oid}",
ns.org(),
ns.repo(),
&oid[0..2],
&oid[2..4]
)
}
fn marker_key(ns: &Namespace, oid: &str) -> String {
format!(
"{}/{}/{}/{}/{oid}",
ns.org(),
ns.repo(),
&oid[0..2],
&oid[2..4]
)
}
pub async fn reachable(&self) -> Result<(), Error> {
self.keys.reachable().await
}
pub async fn exists(&self, ns: &Namespace, oid: &str) -> bool {
if crate::storage::LocalStore::validate_oid(oid).is_err() {
return false;
}
self.keys.head(&Self::marker_key(ns, oid)).await.is_ok()
}
pub async fn size_of(&self, oid: &str) -> Result<u64, Error> {
// Every entry point validates before slicing an oid into a key: the
// fanout takes the first four characters, so a short one is a panic
// rather than a refusal, and a panic is a 500 for something that should
// have been a 422.
crate::storage::LocalStore::validate_oid(oid)?;
self.keys.head(&Self::content_key(oid)).await
}
// A download is streamed through this server rather than redirected, so the
// features that live in the byte path — the counters, the ranges, and the
// compression that will follow — keep working. The pre-signed redirect is a
// separate mode for operators who would rather spend the object store's
// bandwidth than their own.
pub async fn read(
&self,
oid: &str,
start: u64,
length: u64,
) -> Result<impl Stream<Item = Result<Bytes, reqwest::Error>> + use<>, Error> {
crate::storage::LocalStore::validate_oid(oid)?;
self.keys
.get_range(&Self::content_key(oid), start, length)
.await
}
// A URL the client fetches from the bucket directly, so the bytes never
// cross this server. Whether the caller is entitled to them has already been
// settled by the marker before this is called: the signature is scoped to
// one content key and expires, and it grants nothing the batch response was
// not about to grant anyway.
pub fn presigned_download(&self, oid: &str) -> Option<String> {
if !self.redirect || crate::storage::LocalStore::validate_oid(oid).is_err() {
return None;
}
Some(self.keys.signed_download(&Self::content_key(oid)))
}
// A URL the client PUTs the object to, and the headers it has to send with
// it. The digest is bound into the signature, so the store refuses anything
// that does not hash to the object it was signed for: a client with this URL
// cannot put arbitrary bytes anywhere, which is what makes handing one out
// safe at all.
pub fn presigned_upload(&self, ns: &Namespace, oid: &str) -> Option<Presigned> {
if !self.redirect || crate::storage::LocalStore::validate_oid(oid).is_err() {
return None;
}
let digest = base64::engine::general_purpose::STANDARD.encode(hex::decode(oid).ok()?);
Some(self.keys.signed_upload(
&Self::incoming_key(ns, oid),
vec![(CHECKSUM.to_owned(), digest)],
))
}
// How big the object a client uploaded actually is, which is the first thing
// this server learns about it: nothing measured the bytes on the way past.
pub async fn uploaded_size(&self, ns: &Namespace, oid: &str) -> Result<u64, Error> {
crate::storage::LocalStore::validate_oid(oid)?;
self.keys.head(&Self::incoming_key(ns, oid)).await
}
// Take an upload that landed under this repository's own key into the shared
// keyspace. The bytes are already known to hash to the oid, because the store
// refused everything else.
pub async fn adopt(&self, ns: &Namespace, oid: &str) -> Result<(), Error> {
crate::storage::LocalStore::validate_oid(oid)?;
let incoming = Self::incoming_key(ns, oid);
let content = Self::content_key(oid);
// Already there means another repository pushed the same object, and the
// bytes are identical by construction.
if self.keys.head(&content).await.is_err() {
self.keys.copy(&incoming, &content).await?;
}
self.keys
.put(
&Self::marker_key(ns, oid),
reqwest::Body::from(Vec::new()),
0,
)
.await?;
// Leaving it would pay for the object twice. A failure here is not worth
// failing the push over: the object is adopted, and what is left is a key
// the operator can see.
if let Err(error) = self.keys.delete(&incoming).await {
tracing::warn!(%error, key = incoming, "an adopted upload could not be cleaned up");
}
Ok(())
}
// The upload has already been streamed to a staging file, hashed and checked
// against everything the server enforces, so that file is what goes up —
// streamed from disk rather than read into memory, because an object here is
// measured in gigabytes and the whole storage layer is built on holding at
// most a few megabytes of one at a time.
//
// The bytes go up once, keyed by their digest, and the marker records that
// this repository holds them. Content that is already there is skipped: the
// key would receive the same bytes it already has.
pub async fn store(
&self,
ns: &Namespace,
oid: &str,
staged: &std::path::Path,
) -> Result<(), Error> {
crate::storage::LocalStore::validate_oid(oid)?;
if self.keys.head(&Self::content_key(oid)).await.is_err() {
let file = tokio::fs::File::open(staged).await?;
let length = file.metadata().await?.len();
let stream = tokio_util::io::ReaderStream::new(file);
self.keys
.put(
&Self::content_key(oid),
reqwest::Body::wrap_stream(stream),
length,
)
.await?;
}
self.keys
.put(
&Self::marker_key(ns, oid),
reqwest::Body::from(Vec::new()),
0,
)
.await
}
// What an interrupted upload leaves behind. A client can negotiate, PUT the
// object, and never report it: the bytes sit under its own upload key and
// nothing else will ever look at them. The local path has had a reclaimer for
// this since the beginning, and a bucket had none, so the cost was unbounded
// over time and invisible.
pub async fn reclaim_incoming(&self, older_than: Duration) -> Result<Reclaimed, Error> {
let mut reclaimed = Reclaimed::default();
for entry in self.keys.entries(".incoming/").await? {
// A slow client on a bad connection is not an abandoned one.
if entry.age().is_none_or(|age| age < older_than) {
continue;
}
if self.keys.delete(&entry.key).await.is_ok() {
reclaimed.files += 1;
reclaimed.bytes += entry.size;
}
}
Ok(reclaimed)
}
// Collection, with the marker keyspace standing in for the link count a
// filesystem keeps. A repository's marker is its claim on the bytes, and the
// bytes go when the last claim does.
//
// One listing of the whole bucket answers all three questions at once: which
// markers this repository holds, which oids any other repository still
// claims, and how big each content object is. Asked separately they would
// cost a request per object, which on a bucket is the difference between a
// collection an operator runs and one they read about.
//
// A listing that did not finish is the dangerous case. It cannot be used to
// conclude that nothing references an object, because the reference may sit
// in the pages that never arrived. So an incomplete listing still drops this
// repository's markers, which the retained set alone decides, and leaves
// every content key exactly where it is.
pub async fn sweep(
&self,
ns: &Namespace,
retained: &std::collections::HashSet<String>,
grace: Duration,
dry_run: bool,
) -> Result<crate::storage::SweepReport, Error> {
let listing = self.keys.listing("").await;
let mut report = crate::storage::SweepReport {
dry_run,
incomplete: !listing.complete,
..Default::default()
};
let ours = format!("{}/{}/", ns.org(), ns.repo());
let mut mine = Vec::new();
let mut claimed_elsewhere = std::collections::HashSet::new();
let mut sizes = std::collections::HashMap::new();
for entry in listing.entries {
if let Some(rest) = entry.key.strip_prefix(".content/") {
if let Some(oid) = rest.rsplit('/').next() {
sizes.insert(oid.to_owned(), entry.size);
}
continue;
}
// Locks live at `.locks/{org}/{repo}/{id}`, so they never match the
// marker prefix and are never swept. Skipped explicitly all the same:
// falling through would file every lock id in the claimed set, and an
// object whose digest happened to equal a lock id would then never be
// collected. The odds are absurd today and the line costs nothing,
// but the code should not depend on ids and digests never colliding.
if entry.key.starts_with(".incoming/") || entry.key.starts_with(".locks/") {
continue;
}
let Some(oid) = entry.key.rsplit('/').next().map(str::to_owned) else {
continue;
};
if entry.key.starts_with(&ours) {
mine.push((entry, oid));
} else {
claimed_elsewhere.insert(oid);
}
}
for (entry, oid) in mine {
if retained.contains(&oid) {
continue;
}
// A slow push is not an abandoned object: the same window the local
// store honours.
if entry.age().is_none_or(|age| age < grace) {
report.within_grace += 1;
continue;
}
report.swept += 1;
// Only what this call actually frees is counted. Another repository
// holding the same bytes means dropping this marker frees nothing,
// and a dry run that said otherwise would promise space it cannot
// deliver.
let frees = listing.complete && !claimed_elsewhere.contains(&oid);
let size = sizes.get(&oid).copied().unwrap_or_default();
if dry_run {
if frees {
report.bytes += size;
}
continue;
}
self.keys.delete(&entry.key).await?;
// Counted only when this call is the one that removed them, so two
// repositories letting go at once cannot each claim the same space.
if frees && self.keys.delete(&Self::content_key(&oid)).await? {
report.bytes += size;
}
}
Ok(report)
}
// What the bucket holds for this repository, counted from its markers and
// the content they point at. The markers are empty, so their own size says
// nothing — this is a listing plus one head per object, which is why the
// figure is cached the same way the local one is.
pub async fn usage_of(&self, ns: &Namespace) -> (u64, u64) {
let prefix = format!("{}/{}/", ns.org(), ns.repo());
let mut objects = 0;
let mut bytes = 0;
for oid in self.list(&prefix).await {
objects += 1;
bytes += self.size_of(&oid).await.unwrap_or_default();
}
(objects, bytes)
}
async fn list(&self, prefix: &str) -> Vec<String> {
// A capacity figure that silently reads zero is worse than one that is
// missing, because it looks like an answer.
let keys = match self.keys.keys(prefix).await {
Ok(keys) => keys,
Err(error) => {
tracing::warn!(%error, "the object store could not be listed");
return Vec::new();
}
};
keys.into_iter()
.filter_map(|key| key.rsplit('/').next().map(str::to_owned))
.filter(|oid| crate::storage::LocalStore::validate_oid(oid).is_ok())
.collect()
}
}
#[cfg(test)]
pub(crate) mod tests;