lemma/planning/

semantics.rs

//! Resolved semantic types for Lemma
//!
//! This module contains all types that represent resolved semantics after planning.
//! These types are created during the planning phase and used by evaluation, inversion, etc.

// Re-exported parsing types: downstream modules (evaluation, inversion, computation,
// serialization) import these from `planning::semantics`, never from `parsing` directly.
#[cfg(test)]
pub use crate::parsing::ast::Span;
pub use crate::parsing::ast::{
    ArithmeticComputation, ComparisonComputation, LogicalComputation, MathematicalComputation,
    NegationType, VetoExpression,
};
pub use crate::parsing::source::Source;

/// Logical computation operators (defined in semantics, not used by the parser).
/// Returns the logical negation of a comparison (for displaying conditions as true in explanations).
#[must_use]
pub fn negated_comparison(op: ComparisonComputation) -> ComparisonComputation {
    match op {
        ComparisonComputation::LessThan => ComparisonComputation::GreaterThanOrEqual,
        ComparisonComputation::LessThanOrEqual => ComparisonComputation::GreaterThan,
        ComparisonComputation::GreaterThan => ComparisonComputation::LessThanOrEqual,
        ComparisonComputation::GreaterThanOrEqual => ComparisonComputation::LessThan,
        ComparisonComputation::Is => ComparisonComputation::IsNot,
        ComparisonComputation::IsNot => ComparisonComputation::Is,
    }
}

// Internal-only parsing imports (used only within this module for value/type resolution).
use crate::computation::rational::{checked_div, checked_mul, rational_new, RationalInteger};
use crate::parsing::ast::Constraint;
use crate::parsing::ast::{
    BooleanValue, CalendarPeriodUnit, CommandArg, ConversionTarget, DateCalendarKind,
    DateRelativeKind, DateTimeValue, LemmaSpec, PrimitiveKind, TimeValue, TypeConstraintCommand,
};
use crate::Error;
use rust_decimal::Decimal;
use serde::{Deserialize, Deserializer, Serialize, Serializer};
use std::collections::HashMap;
use std::fmt;
use std::hash::Hash;
use std::str::FromStr;
use std::sync::{Arc, OnceLock};

// -----------------------------------------------------------------------------
// Type specification and units (resolved type shape; apply constraints is planning)
// -----------------------------------------------------------------------------

// Unit tables live in `crate::literals` (no dependency on parsing/ast). Re-exported
// here so downstream modules importing from `planning::semantics` keep working.
pub use crate::literals::{BaseQuantityVector, QuantityUnit, QuantityUnits, RatioUnit, RatioUnits};

/// Combine two `BaseQuantityVector`s by adding (for multiply) or subtracting (for divide) exponents.
/// Entries that reach zero exponent are removed (they cancel out).
pub fn combine_decompositions(
    left: &BaseQuantityVector,
    right: &BaseQuantityVector,
    is_multiply: bool,
) -> BaseQuantityVector {
    let mut result = left.clone();
    for (dim, &exp) in right {
        let delta = if is_multiply { exp } else { -exp };
        let entry = result.entry(dim.clone()).or_insert(0);
        *entry += delta;
        if *entry == 0 {
            result.remove(dim);
        }
    }
    result
}

/// Combine two symbolic unit signatures (sorted-by-unit-name, no-zero-exponent vectors)
/// under multiplication or division. The result is in canonical form: sorted by unit name
/// ascending, no zero exponents.
pub fn combine_signatures(
    left: &[(String, i32)],
    right: &[(String, i32)],
    is_multiply: bool,
) -> Vec<(String, i32)> {
    use std::collections::BTreeMap;
    let mut accumulator: BTreeMap<String, i32> = BTreeMap::new();
    for (name, exponent) in left {
        *accumulator.entry(name.clone()).or_insert(0) += exponent;
    }
    for (name, exponent) in right {
        let delta = if is_multiply { *exponent } else { -*exponent };
        *accumulator.entry(name.clone()).or_insert(0) += delta;
    }
    accumulator
        .into_iter()
        .filter(|(_, exponent)| *exponent != 0)
        .collect()
}

/// Canonicalize a unit signature: sum duplicate entries by name, drop zero exponents,
/// sort ascending by unit name. Idempotent.
/// Format a canonical unit signature into human-readable operator style.
///
/// Rules:
/// - Numerator units (positive exponents) sorted alphabetically, joined by `*`.
/// - Denominator units (negative exponents) sorted alphabetically, joined by `*`, exponents shown
///   as positive values.
/// - Separated by `/`. Empty numerator: `1/<denominator>`. No denominator: numerator only.
/// - Exponents > 1 suffixed as `^n`.
///
/// Examples: `eur/hour`, `kilogram*meter^2/second^2`, `1/meter`.
pub fn format_signature_operator_style(signature: &[(String, i32)]) -> String {
    let canonical = canonicalize_signature(signature);
    let mut numerator: Vec<(String, i32)> = Vec::new();
    let mut denominator: Vec<(String, i32)> = Vec::new();
    for (name, exponent) in canonical {
        if exponent > 0 {
            numerator.push((name, exponent));
        } else if exponent < 0 {
            denominator.push((name, -exponent));
        }
    }
    let render = |terms: &[(String, i32)]| -> String {
        terms
            .iter()
            .map(|(name, exp)| {
                if *exp == 1 {
                    name.clone()
                } else {
                    format!("{name}^{exp}")
                }
            })
            .collect::<Vec<_>>()
            .join("*")
    };
    match (numerator.is_empty(), denominator.is_empty()) {
        (true, true) => String::new(),
        (false, true) => render(&numerator),
        (true, false) => format!("1/{}", render(&denominator)),
        (false, false) => format!("{}/{}", render(&numerator), render(&denominator)),
    }
}

/// Returns the intra-calendar-dimension factor for `name`, if it is a known calendar unit.
///
/// Month is canonical (factor 1). Year = 12.
/// Keys are **singular** (`"month"`, `"year"`).
///
/// Returns `None` for names that are not calendar units.
pub fn calendar_unit_factor(name: &str) -> Option<crate::computation::rational::RationalInteger> {
    use crate::computation::rational::rational_one;
    match name {
        "month" | "months" => Some(rational_one()),
        "year" | "years" => Some(rational_new(12, 1)),
        _ => None,
    }
}

fn owner_declares_quantity_unit(owner: &LemmaType, unit_name: &str) -> bool {
    owner
        .quantity_unit_names()
        .is_some_and(|names| names.contains(&unit_name))
}

/// Compute the numeric factor of a symbolic unit signature relative to canonical bases.
///
/// For each `(unit_name, exponent)` in `signature`:
/// 1. When `owner` declares the unit, use `owner.quantity_unit_factor(unit_name)`.
/// 2. Fall back to `expression_units[unit_name].quantity_unit_factor(unit_name)`.
/// 3. Unknown names panic with `"BUG: signature_factor called with unresolved unit name"`.
///
/// Returns the product of `factor^exponent` over all pairs.
pub fn signature_factor(
    signature: &[(String, i32)],
    expression_units: &std::collections::HashMap<String, Arc<LemmaType>>,
    owner: Option<&LemmaType>,
) -> crate::computation::rational::RationalInteger {
    use crate::computation::rational::{checked_div, checked_mul, rational_one};
    let mut acc = rational_one();
    for (name, exponent) in signature {
        let factor =
            if let Some(owner) = owner.filter(|owner| owner_declares_quantity_unit(owner, name)) {
                owner.quantity_unit_factor(name).clone()
            } else if let Some(lemma_type) = expression_units.get(name) {
                lemma_type.quantity_unit_factor(name).clone()
            } else {
                panic!(
                    "BUG: signature_factor called with unresolved unit name '{}'",
                    name
                );
            };
        let mut term = rational_one();
        let abs_exp = exponent.unsigned_abs();
        for _ in 0..abs_exp {
            term = checked_mul(&term, &factor)
                .expect("BUG: signature_factor overflow during exponent expansion");
        }
        if *exponent >= 0 {
            acc = checked_mul(&acc, &term)
                .expect("BUG: signature_factor overflow during multiplication");
        } else {
            acc = checked_div(&acc, &term).expect("BUG: signature_factor overflow during division");
        }
    }
    acc
}

pub fn canonicalize_signature(signature: &[(String, i32)]) -> Vec<(String, i32)> {
    use std::collections::BTreeMap;
    let mut accumulator: BTreeMap<String, i32> = BTreeMap::new();
    for (name, exponent) in signature {
        *accumulator.entry(name.clone()).or_insert(0) += exponent;
    }
    accumulator
        .into_iter()
        .filter(|(_, exponent)| *exponent != 0)
        .collect()
}

pub const DURATION_DIMENSION: &str = "duration";
pub const CALENDAR_DIMENSION: &str = "calendar";

#[derive(Debug, Clone, Copy, PartialEq, Eq, Hash, Serialize, Deserialize)]
#[serde(rename_all = "snake_case")]
pub enum QuantityTrait {
    Duration,
    Calendar,
}

pub fn duration_decomposition() -> BaseQuantityVector {
    [(DURATION_DIMENSION.to_string(), 1i32)]
        .into_iter()
        .collect()
}

pub fn calendar_decomposition() -> BaseQuantityVector {
    [(CALENDAR_DIMENSION.to_string(), 1i32)]
        .into_iter()
        .collect()
}

/// Marker `LemmaType` for a Quantity value whose signature has not been resolved to
/// a named quantity type. Carries an empty decomposition; the value's own signature
/// (on `ValueKind::Quantity`) is authoritative for arithmetic and display.
pub fn anonymous_quantity_type() -> LemmaType {
    LemmaType::anonymous_for_decomposition(BaseQuantityVector::new())
}

/// Return a copy of `signature` with every exponent negated. Used by Number/Quantity
/// reciprocal construction (`1 / Q`).
pub fn negate_signature(signature: &[(String, i32)]) -> Vec<(String, i32)> {
    signature.iter().map(|(n, e)| (n.clone(), -*e)).collect()
}

mod stored_quantity_declared_bound_serde {
    use super::RationalInteger;
    use crate::computation::rational::commit_rational_to_decimal;
    use rust_decimal::Decimal;
    use serde::{Deserialize, Deserializer, Serialize, Serializer};

    fn lift(decimal: Decimal) -> Result<RationalInteger, String> {
        crate::computation::rational::decimal_to_rational(decimal)
            .map_err(|failure| failure.to_string())
    }

    pub mod option {
        use super::*;

        pub fn serialize<S: Serializer>(
            value: &Option<(RationalInteger, String)>,
            serializer: S,
        ) -> Result<S::Ok, S::Error> {
            match value {
                None => serializer.serialize_none(),
                Some((magnitude, unit_name)) => {
                    let decimal = commit_rational_to_decimal(magnitude)
                        .expect("BUG: planned quantity declared bound must commit to decimal");
                    (decimal, unit_name.as_str()).serialize(serializer)
                }
            }
        }

        pub fn deserialize<'de, D: Deserializer<'de>>(
            deserializer: D,
        ) -> Result<Option<(RationalInteger, String)>, D::Error> {
            let parsed: Option<(Decimal, String)> = Option::deserialize(deserializer)?;
            parsed
                .map(|(decimal, unit_name)| lift(decimal).map(|magnitude| (magnitude, unit_name)))
                .transpose()
                .map_err(serde::de::Error::custom)
        }
    }
}

#[derive(Clone, Debug, PartialEq, Eq, Hash, Serialize, Deserialize)]
#[serde(tag = "kind", rename_all = "lowercase")]
pub enum TypeSpecification {
    Boolean {
        help: String,
    },
    Quantity {
        #[serde(with = "stored_quantity_declared_bound_serde::option", default)]
        minimum: Option<(RationalInteger, String)>,
        #[serde(with = "stored_quantity_declared_bound_serde::option", default)]
        maximum: Option<(RationalInteger, String)>,
        decimals: Option<u8>,
        units: QuantityUnits,
        #[serde(default)]
        traits: Vec<QuantityTrait>,
        /// Common dimensional decomposition vector shared by all units in this quantity.
        /// `None` until the decomposition pass runs. Base quantities (no compound unit expression)
        /// are assigned `Some({quantity_name: 1})` by the pass. `Some(empty_map)` means resolved
        /// to dimensionless (e.g. `kg/kg`).
        #[serde(default)]
        decomposition: Option<BaseQuantityVector>,
        help: String,
    },
    Number {
        #[serde(with = "crate::literals::stored_rational_serde::option", default)]
        minimum: Option<RationalInteger>,
        #[serde(with = "crate::literals::stored_rational_serde::option", default)]
        maximum: Option<RationalInteger>,
        decimals: Option<u8>,
        help: String,
    },
    NumberRange {
        help: String,
    },
    Ratio {
        #[serde(with = "crate::literals::stored_rational_serde::option", default)]
        minimum: Option<RationalInteger>,
        #[serde(with = "crate::literals::stored_rational_serde::option", default)]
        maximum: Option<RationalInteger>,
        decimals: Option<u8>,
        units: RatioUnits,
        help: String,
    },
    RatioRange {
        units: RatioUnits,
        help: String,
    },
    Text {
        length: Option<usize>,
        options: Vec<String>,
        help: String,
    },
    Date {
        minimum: Option<DateTimeValue>,
        maximum: Option<DateTimeValue>,
        help: String,
    },
    DateRange {
        help: String,
    },
    Time {
        minimum: Option<TimeValue>,
        maximum: Option<TimeValue>,
        help: String,
    },
    TimeRange {
        help: String,
    },
    QuantityRange {
        units: QuantityUnits,
        #[serde(default)]
        decomposition: Option<BaseQuantityVector>,
        help: String,
    },
    Veto {
        message: Option<String>,
    },
    /// Sentinel used during type inference when the type could not be determined.
    /// Propagates through expressions without generating cascading errors.
    /// Must never appear in a successfully validated graph or execution plan.
    Undetermined,
}

impl std::fmt::Display for TypeSpecification {
    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
        let label = match self {
            Self::Boolean { .. } => "boolean",
            Self::Quantity { .. } => "quantity",
            Self::QuantityRange { .. } => "quantity range",
            Self::Number { .. } => "number",
            Self::NumberRange { .. } => "number range",
            Self::Text { .. } => "text",
            Self::Date { .. } => "date",
            Self::DateRange { .. } => "date range",
            Self::Time { .. } => "time",
            Self::TimeRange { .. } => "time range",
            Self::Ratio { .. } => "ratio",
            Self::RatioRange { .. } => "ratio range",
            Self::Veto { .. } => "veto",
            Self::Undetermined => "undetermined",
        };
        f.write_str(label)
    }
}

impl TypeSpecification {
    /// Returns the help text associated with this type, or an empty string if none.
    pub fn help(&self) -> &str {
        match self {
            Self::Boolean { help, .. }
            | Self::Quantity { help, .. }
            | Self::Number { help, .. }
            | Self::NumberRange { help, .. }
            | Self::Text { help, .. }
            | Self::Date { help, .. }
            | Self::DateRange { help, .. }
            | Self::Time { help, .. }
            | Self::TimeRange { help, .. }
            | Self::Ratio { help, .. }
            | Self::RatioRange { help, .. }
            | Self::QuantityRange { help, .. } => help.as_str(),
            Self::Veto { .. } | Self::Undetermined => "",
        }
    }
}

/// Extract a typed [`Value`] from the first `CommandArg`, requiring `Literal` shape.
///
/// `Label` args carry identifiers (unit names, option keywords) and never satisfy a
/// command position that wants a literal value. Returning a typed `Value` keeps the
/// caller's match exhaustive over [`Value`] variants — no string coercion path.
fn require_literal<'a>(
    args: &'a [CommandArg],
    cmd: &str,
) -> Result<&'a crate::literals::Value, String> {
    let arg = args
        .first()
        .ok_or_else(|| format!("{} requires an argument", cmd))?;
    match arg {
        CommandArg::Literal(v) => Ok(v),
        CommandArg::Label(name) => Err(format!(
            "{} requires a literal value, got identifier '{}'",
            cmd, name
        )),
        CommandArg::UnitExpr(_) => Err(format!(
            "{} requires a literal value, got a unit expression (only valid for 'unit' command)",
            cmd
        )),
    }
}

fn apply_type_help_command(help: &mut String, args: &[CommandArg]) -> Result<(), String> {
    match require_literal(args, "help")? {
        crate::literals::Value::Text(s) => {
            *help = s.clone();
            Ok(())
        }
        other => Err(format!(
            "help requires a text literal (quoted string), got {}",
            value_kind_name(other)
        )),
    }
}

fn format_quantity_units_list(units: &QuantityUnits) -> String {
    units
        .iter()
        .map(|u| u.name.as_str())
        .collect::<Vec<_>>()
        .join(", ")
}

/// What kind of value `-> default` expects when rejecting a calendar literal.
#[derive(Debug, Clone, Copy, PartialEq, Eq)]
pub(crate) enum DefaultExpectation {
    QuantityUnits,
    Text,
    Number,
    Boolean,
    Date,
    Time,
    Ratio,
    NumberRange,
    DateRange,
    TimeRange,
    QuantityRange,
    RatioRange,
}

pub(crate) fn default_value_mismatch_error(
    calendar_unit: &str,
    type_name: &str,
    expectation: DefaultExpectation,
    quantity_units: Option<&QuantityUnits>,
) -> String {
    let unit_label = calendar_unit;
    let first = format!("Unit '{unit_label}' is for calendar data.");
    match expectation {
        DefaultExpectation::QuantityUnits => {
            let list = quantity_units
                .map(format_quantity_units_list)
                .unwrap_or_default();
            format!("{first} Valid '{type_name}' units are: {list}.")
        }
        DefaultExpectation::Text => format!(
            "{first} Please provide a text value in double quotes, for example `-> default \"my default value\"`."
        ),
        DefaultExpectation::Number => format!(
            "{first} Please provide a number, for example `-> default 42`."
        ),
        DefaultExpectation::Boolean => format!(
            "{first} Please provide true or false, for example `-> default true`."
        ),
        DefaultExpectation::Date => format!(
            "{first} Please provide a date, for example `-> default 2024-06-15`."
        ),
        DefaultExpectation::Time => format!(
            "{first} Please provide a time, for example `-> default 09:00:00`."
        ),
        DefaultExpectation::Ratio | DefaultExpectation::RatioRange => format!(
            "{first} Please provide a ratio, for example `-> default 25%`."
        ),
        DefaultExpectation::NumberRange => format!(
            "{first} Please provide a number range, for example `-> default 10...100`."
        ),
        DefaultExpectation::DateRange => format!(
            "{first} Please provide a date range, for example `-> default 2024-01-01...2024-12-31`."
        ),
        DefaultExpectation::TimeRange => format!(
            "{first} Please provide a time range, for example `-> default 09:00...17:00`."
        ),
        DefaultExpectation::QuantityRange => format!(
            "{first} Please provide a range with units valid for '{type_name}', for example `-> default 30 kilogram...35 kilogram`."
        ),
    }
}

fn quantity_default_unit_error(unit: &str, type_name: &str, units: &QuantityUnits) -> String {
    format!(
        "Unit '{unit}' is not defined on '{type_name}'. Valid '{type_name}' units are: {}.",
        format_quantity_units_list(units)
    )
}

fn quantity_default_wrong_shape_error(type_name: &str, traits: &[QuantityTrait]) -> String {
    let example = if traits.contains(&QuantityTrait::Duration) {
        "4 weeks"
    } else if traits.contains(&QuantityTrait::Calendar) {
        "3 month"
    } else {
        "30 kilogram"
    };
    format!(
        "Please provide a value with a unit valid for '{type_name}', for example `-> default {example}`."
    )
}

fn validate_calendar_range_default_endpoint(
    value: &crate::literals::Value,
    type_name: &str,
    units: &QuantityUnits,
) -> Result<(), String> {
    let unit_name = match value {
        crate::literals::Value::NumberWithUnit(_, u) => u.as_str(),
        _ => {
            return Err(
                "Please provide a range with calendar units, for example `-> default 18 year...67 year`."
                    .to_string(),
            );
        }
    };
    if calendar_unit_factor(unit_name).is_none() {
        return Err(
            "Please provide a range with calendar units, for example `-> default 18 year...67 year`."
                .to_string(),
        );
    }
    if units.get(unit_name).is_err() {
        return Err(quantity_default_unit_error(unit_name, type_name, units));
    }
    Ok(())
}

fn reject_calendar_for_default(
    value: &crate::literals::Value,
    type_name: &str,
    expectation: DefaultExpectation,
    quantity_units: Option<&QuantityUnits>,
) -> Result<(), String> {
    if let crate::literals::Value::NumberWithUnit(_, unit) = value {
        if calendar_unit_factor(unit).is_some() {
            return Err(default_value_mismatch_error(
                unit,
                type_name,
                expectation,
                quantity_units,
            ));
        }
    }
    Ok(())
}

/// Human-readable name for a [`Value`] variant — used in mismatch error messages.
fn value_kind_name(v: &crate::literals::Value) -> &'static str {
    use crate::literals::Value;
    match v {
        Value::Number(_) => "number",
        Value::NumberWithUnit(_, _) => "number_with_unit",
        Value::Text(_) => "text",
        Value::Date(_) => "date",
        Value::Time(_) => "time",
        Value::Boolean(_) => "boolean",
        Value::Range(_, _) => "range",
    }
}

fn require_default_range_endpoints<'a>(
    args: &'a [CommandArg],
    type_name: &str,
    expectation: DefaultExpectation,
    quantity_units: Option<&QuantityUnits>,
) -> Result<(&'a crate::literals::Value, &'a crate::literals::Value), String> {
    match require_literal(args, "default")? {
        crate::literals::Value::NumberWithUnit(_, unit)
            if calendar_unit_factor(unit).is_some() =>
        {
            Err(default_value_mismatch_error(
                unit,
                type_name,
                expectation,
                quantity_units,
            ))
        }
        crate::literals::Value::Range(left, right) => Ok((left.as_ref(), right.as_ref())),
        _ => Err(match expectation {
            DefaultExpectation::NumberRange => {
                "Please provide a number range, for example `-> default 10...100`.".to_string()
            }
            DefaultExpectation::DateRange => {
                "Please provide a date range, for example `-> default 2024-01-01...2024-12-31`."
                    .to_string()
            }
            DefaultExpectation::RatioRange => {
                "Please provide a ratio range, for example `-> default 10%...50%`.".to_string()
            }
            DefaultExpectation::QuantityRange => format!(
                "Please provide a range with units valid for '{type_name}', for example `-> default 30 kilogram...35 kilogram`."
            ),
            _ => unreachable!("BUG: require_default_range_endpoints called with non-range expectation"),
        }),
    }
}

fn lift_parser_decimal(decimal: rust_decimal::Decimal) -> Result<RationalInteger, String> {
    crate::computation::rational::decimal_to_rational(decimal)
        .map_err(|failure| format!("literal failed rational lift: {failure}"))
}

/// Element spec for a range type, used for parsing endpoints and lifting literal endpoints.
pub fn range_element_type_specification(
    range_spec: &TypeSpecification,
) -> Option<TypeSpecification> {
    range_spec.element_from_range()
}

fn range_endpoints_compatible(left: &LemmaType, right: &LemmaType) -> bool {
    match (&left.specifications, &right.specifications) {
        (TypeSpecification::Date { .. }, TypeSpecification::Date { .. }) => true,
        (TypeSpecification::Time { .. }, TypeSpecification::Time { .. }) => true,
        (TypeSpecification::Number { .. }, TypeSpecification::Number { .. }) => true,
        (TypeSpecification::Quantity { .. }, TypeSpecification::Quantity { .. }) => {
            left.same_quantity_family(right)
                || left.compatible_with_anonymous_quantity(right)
                || right.compatible_with_anonymous_quantity(left)
        }
        (TypeSpecification::Ratio { .. }, TypeSpecification::Ratio { .. }) => true,
        _ => false,
    }
}

/// Infer the range type specification from two compatible endpoint types.
pub fn range_type_specification_from_endpoints(
    left: &LemmaType,
    right: &LemmaType,
) -> Option<TypeSpecification> {
    if !range_endpoints_compatible(left, right) {
        return None;
    }
    left.specifications.range_from_element()
}

/// Lift a parser literal range endpoint to a [`LiteralValue`] with the element's primitive type.
/// Routes [`Value::NumberWithUnit`] through [`parser_value_to_value_kind`] so ratio endpoints
/// (e.g. `10%` in a `ratio range`) canonicalize to ratios, not anonymous quantities.
fn lift_range_endpoint(
    value: &crate::parsing::ast::Value,
    element_spec: &TypeSpecification,
) -> Result<LiteralValue, String> {
    use crate::parsing::ast::Value;
    let kind = match value {
        Value::NumberWithUnit(_, _) => parser_value_to_value_kind(value, element_spec)?,
        _ => value_to_semantic(value)?,
    };
    Ok(LiteralValue {
        value: kind,
        lemma_type: Arc::new(LemmaType::primitive(element_spec.clone())),
    })
}

fn literal_value_from_parser_value(
    value: &crate::parsing::ast::Value,
) -> Result<LiteralValue, String> {
    use crate::parsing::ast::Value;

    match value {
        Value::Number(n) => Ok(LiteralValue::number(lift_parser_decimal(*n)?)),
        Value::Text(s) => Ok(LiteralValue::text(s.clone())),
        Value::Date(dt) => Ok(LiteralValue::date(date_time_to_semantic(dt))),
        Value::Time(t) => Ok(LiteralValue::time(time_to_semantic(t))),
        Value::Boolean(b) => Ok(LiteralValue::from_bool(bool::from(*b))),
        Value::NumberWithUnit(n, unit) => Ok(LiteralValue::number_interpreted_as_quantity(
            lift_parser_decimal(*n)?,
            unit.clone(),
        )),
        Value::Range(left, right) => {
            let left = literal_value_from_parser_value(left)?;
            let right = literal_value_from_parser_value(right)?;
            let compatible = match (
                &left.lemma_type.specifications,
                &right.lemma_type.specifications,
            ) {
                (TypeSpecification::Date { .. }, TypeSpecification::Date { .. }) => true,
                (TypeSpecification::Time { .. }, TypeSpecification::Time { .. }) => true,
                (TypeSpecification::Number { .. }, TypeSpecification::Number { .. }) => true,
                (TypeSpecification::Quantity { .. }, TypeSpecification::Quantity { .. }) => {
                    left.lemma_type.same_quantity_family(&right.lemma_type)
                        || left
                            .lemma_type
                            .compatible_with_anonymous_quantity(&right.lemma_type)
                        || right
                            .lemma_type
                            .compatible_with_anonymous_quantity(&left.lemma_type)
                }
                (TypeSpecification::Ratio { .. }, TypeSpecification::Ratio { .. }) => true,
                _ => false,
            };
            if !compatible {
                return Err(format!(
                    "range endpoints must have the same supported base type, got {} and {}",
                    left.lemma_type.name(),
                    right.lemma_type.name()
                ));
            }
            Ok(LiteralValue::range(left, right))
        }
    }
}

/// Cast a [`RationalInteger`] to `u8`, requiring it to be a non-negative whole number that fits.
fn decimal_to_u8(d: RationalInteger, ctx: &str) -> Result<u8, String> {
    use crate::computation::bigint::BigInt;
    if d.denom() != &BigInt::one() {
        return Err(format!(
            "{} requires a whole number, got fractional value",
            ctx
        ));
    }
    d.numer()
        .to_u8()
        .ok_or_else(|| format!("{} value out of range for u8", ctx))
}

/// Cast a [`RationalInteger`] to `usize`, requiring it to be a non-negative whole number that fits.
fn decimal_to_usize(d: RationalInteger, ctx: &str) -> Result<usize, String> {
    use crate::computation::bigint::BigInt;
    if d.denom() != &BigInt::one() {
        return Err(format!(
            "{} requires a whole number, got fractional value",
            ctx
        ));
    }
    d.numer()
        .to_usize()
        .ok_or_else(|| format!("{} value out of range for usize", ctx))
}

/// Extract a number literal from a [`Value::Number`] arg and lift it to [`RationalInteger`].
///
/// Numeric meta-constraints (`decimals`, `length`, `minimum`/`maximum`
/// on `Number` and `Quantity`) take a bare number literal — not a ratio, not a quantity. Reject
/// any other variant to honour the no-coercion contract.
fn ratio_bound_to_canonical_rational(
    args: &[CommandArg],
    cmd: &str,
    units: &RatioUnits,
) -> Result<RationalInteger, String> {
    use crate::computation::rational::{checked_div, decimal_to_rational};
    let lit = require_literal(args, cmd)?;
    match lit {
        crate::literals::Value::NumberWithUnit(magnitude, unit_name) => {
            let unit = units.get(unit_name.as_str())?;
            let magnitude_rational = decimal_to_rational(*magnitude)
                .map_err(|failure| format!("{cmd} literal failed rational lift: {failure}"))?;
            checked_div(&magnitude_rational, &unit.value)
                .map_err(|failure| format!("{cmd}: unit conversion failed: {failure}"))
        }
        other => Err(format!(
            "{cmd} requires a ratio literal with a unit, got {}",
            value_kind_name(other)
        )),
    }
}

fn require_decimal_literal(args: &[CommandArg], cmd: &str) -> Result<RationalInteger, String> {
    use crate::computation::rational::decimal_to_rational;
    match require_literal(args, cmd)? {
        crate::literals::Value::Number(d) => decimal_to_rational(*d)
            .map_err(|failure| format!("{} literal failed rational lift: {}", cmd, failure)),
        other => Err(format!(
            "{} requires a number literal, got {}",
            cmd,
            value_kind_name(other)
        )),
    }
}

enum UnitConstraintField {
    Minimum,
    Maximum,
    DefaultMagnitude,
}

fn quantity_declared_bound_to_canonical(
    magnitude: &RationalInteger,
    unit_name: &str,
    units: &QuantityUnits,
    type_name: &str,
    command: &str,
) -> Result<RationalInteger, String> {
    use crate::computation::rational::checked_mul;
    let unit = units.get(unit_name).map_err(|_| {
        format!(
            "Unit '{unit_name}' is not defined on '{type_name}'. Valid units are: {}.",
            format_quantity_units_list(units)
        )
    })?;
    checked_mul(magnitude, &unit.factor)
        .map_err(|failure| format!("{command}: unit conversion overflow: {failure}"))
}

fn parse_quantity_declared_bound(
    args: &[CommandArg],
    cmd: &str,
    units: &QuantityUnits,
    type_name: &str,
) -> Result<(RationalInteger, String), String> {
    use crate::computation::rational::decimal_to_rational;
    let lit = require_literal(args, cmd)?;
    let (magnitude, unit_name) = match lit {
        crate::literals::Value::NumberWithUnit(n, unit) => (*n, unit.clone()),
        other => {
            return Err(format!(
                "{cmd} requires a quantity literal with a unit, got {}",
                value_kind_name(other)
            ));
        }
    };
    units.get(unit_name.as_str()).map_err(|_| {
        format!(
            "Unit '{unit_name}' is not defined on '{type_name}'. Valid units are: {}.",
            format_quantity_units_list(units)
        )
    })?;
    let magnitude_rational = decimal_to_rational(magnitude)
        .map_err(|failure| format!("{cmd} literal failed rational lift: {failure}"))?;
    Ok((magnitude_rational, unit_name))
}

fn sync_quantity_units_from_canonical(
    units: &mut QuantityUnits,
    canonical: &RationalInteger,
    field: UnitConstraintField,
) -> Result<(), String> {
    use crate::computation::rational::checked_div;
    for unit in &mut units.0 {
        let magnitude = checked_div(canonical, &unit.factor).map_err(|failure| {
            format!(
                "cannot derive per-unit constraint for unit '{}': {failure}",
                unit.name
            )
        })?;
        match field {
            UnitConstraintField::Minimum => unit.minimum = Some(magnitude),
            UnitConstraintField::Maximum => unit.maximum = Some(magnitude),
            UnitConstraintField::DefaultMagnitude => unit.default_magnitude = Some(magnitude),
        }
    }
    Ok(())
}

fn sync_ratio_units_from_canonical(
    units: &mut RatioUnits,
    canonical: &RationalInteger,
    field: UnitConstraintField,
) -> Result<(), String> {
    use crate::computation::rational::checked_mul;
    for unit in &mut units.0 {
        let magnitude = checked_mul(canonical, &unit.value).map_err(|failure| {
            format!(
                "cannot derive per-unit constraint for ratio unit '{}': {failure}",
                unit.name
            )
        })?;
        match field {
            UnitConstraintField::Minimum => unit.minimum = Some(magnitude),
            UnitConstraintField::Maximum => unit.maximum = Some(magnitude),
            UnitConstraintField::DefaultMagnitude => unit.default_magnitude = Some(magnitude),
        }
    }
    Ok(())
}

fn sync_quantity_default_units(
    units: &mut QuantityUnits,
    default: &ValueKind,
    type_name: &str,
) -> Result<(), String> {
    let ValueKind::Quantity(magnitude, signature) = default else {
        return Ok(());
    };
    let unit_name = signature.first().map(|(n, _)| n.as_str()).expect(
        "BUG: Quantity default value has empty signature; literal lift must produce single-term",
    );
    units.get(unit_name).map_err(|_| {
        format!("Default unit '{unit_name}' is not defined on quantity type '{type_name}'.")
    })?;
    sync_quantity_units_from_canonical(units, magnitude, UnitConstraintField::DefaultMagnitude)
}

pub(crate) fn finalize_quantity_unit_constraint_magnitudes(
    specification: &mut TypeSpecification,
    declared_default: Option<&ValueKind>,
    type_name: &str,
) -> Result<(), String> {
    let TypeSpecification::Quantity {
        minimum,
        maximum,
        units,
        traits,
        ..
    } = specification
    else {
        return Ok(());
    };

    if let Some((magnitude, unit_name)) = minimum.clone() {
        let canonical = quantity_declared_bound_to_canonical(
            &magnitude, &unit_name, units, type_name, "minimum",
        )?;
        sync_quantity_units_from_canonical(units, &canonical, UnitConstraintField::Minimum)?;
    }
    if let Some((magnitude, unit_name)) = maximum.clone() {
        let canonical = quantity_declared_bound_to_canonical(
            &magnitude, &unit_name, units, type_name, "maximum",
        )?;
        sync_quantity_units_from_canonical(units, &canonical, UnitConstraintField::Maximum)?;
    }
    if let Some(default) = declared_default {
        sync_quantity_default_units(units, default, type_name)?;
    }

    if minimum.is_some() {
        for unit in units.iter() {
            assert!(
                unit.minimum.is_some(),
                "BUG: type '{type_name}' has minimum but unit '{}' missing per-unit minimum after finalize",
                unit.name
            );
        }
    }
    if maximum.is_some() {
        for unit in units.iter() {
            assert!(
                unit.maximum.is_some(),
                "BUG: type '{type_name}' has maximum but unit '{}' missing per-unit maximum after finalize",
                unit.name
            );
        }
    }
    let calendar_range_default = traits.contains(&QuantityTrait::Calendar)
        && matches!(declared_default, Some(ValueKind::Range(_, _)));
    if declared_default.is_some() && !calendar_range_default {
        for unit in units.iter() {
            assert!(
                unit.default_magnitude.is_some(),
                "BUG: type '{type_name}' has default but unit '{}' missing per-unit default after finalize",
                unit.name
            );
        }
    }

    Ok(())
}

pub(crate) fn quantity_declared_bound_canonical(
    bound: &(RationalInteger, String),
    units: &QuantityUnits,
    type_name: &str,
    command: &str,
) -> Result<RationalInteger, String> {
    let (magnitude, unit_name) = bound;
    quantity_declared_bound_to_canonical(magnitude, unit_name, units, type_name, command)
}

fn sync_ratio_default_units(units: &mut RatioUnits, default: &ValueKind) -> Result<(), String> {
    let ValueKind::Ratio(canonical, _) = default else {
        return Ok(());
    };
    sync_ratio_units_from_canonical(units, canonical, UnitConstraintField::DefaultMagnitude)
}

/// Extract an option name from a single arg.
///
/// Both `option red` (bare identifier, parsed as `Label`) and `option "red"`
/// (quoted text literal) are valid lemma syntax for option enumeration; the
/// grammar accepts either form. All other variants are rejected.
fn option_name(arg: &CommandArg, cmd: &str) -> Result<String, String> {
    match arg {
        CommandArg::Literal(crate::literals::Value::Text(s)) => Ok(s.clone()),
        CommandArg::Label(name) => Ok(name.clone()),
        CommandArg::Literal(other) => Err(format!(
            "{} requires a text literal or identifier, got {}",
            cmd,
            value_kind_name(other)
        )),
        CommandArg::UnitExpr(_) => Err(format!(
            "{} requires a text literal or identifier, got a unit expression",
            cmd
        )),
    }
}

fn label_name(arg: &CommandArg, cmd: &str) -> Result<String, String> {
    match arg {
        CommandArg::Label(name) => Ok(name.clone()),
        CommandArg::Literal(other) => Err(format!(
            "{} requires an identifier, got {}",
            cmd,
            value_kind_name(other)
        )),
        CommandArg::UnitExpr(_) => Err(format!(
            "{} requires an identifier, got a unit expression",
            cmd
        )),
    }
}

fn quantity_trait_name(quantity_trait: QuantityTrait) -> &'static str {
    match quantity_trait {
        QuantityTrait::Duration => "duration",
        QuantityTrait::Calendar => "calendar",
    }
}

fn parse_quantity_trait(args: &[CommandArg]) -> Result<QuantityTrait, String> {
    if args.len() != 1 {
        return Err("trait requires exactly one identifier argument".to_string());
    }
    match label_name(&args[0], "trait")?
        .trim()
        .to_lowercase()
        .as_str()
    {
        "duration" => Ok(QuantityTrait::Duration),
        "calendar" => Ok(QuantityTrait::Calendar),
        other => Err(format!("Unknown quantity trait '{}'", other)),
    }
}

fn validate_calendar_trait_requirements(units: &QuantityUnits) -> Result<(), String> {
    let month_unit = units
        .iter()
        .find(|unit| unit.name == "month")
        .ok_or_else(|| {
            "trait calendar requires a canonical 'month' unit declared before 'trait calendar'"
                .to_string()
        })?;
    if !month_unit.is_canonical_factor() {
        return Err("trait calendar requires unit month 1".to_string());
    }
    Ok(())
}

fn validate_duration_trait_requirements(units: &QuantityUnits) -> Result<(), String> {
    let second_unit = units
        .iter()
        .find(|unit| unit.name == "second")
        .ok_or_else(|| {
            "trait duration requires a canonical 'second' unit declared before 'trait duration'"
                .to_string()
        })?;
    if !second_unit.is_canonical_factor() {
        return Err("trait duration requires unit second 1".to_string());
    }
    Ok(())
}

/// Extract a [`DateTimeValue`] from a [`Value::Date`] literal arg.
fn require_date_literal(args: &[CommandArg], cmd: &str) -> Result<DateTimeValue, String> {
    match require_literal(args, cmd)? {
        crate::literals::Value::Date(dt) => Ok(dt.clone()),
        other => Err(format!(
            "{} requires a date literal (e.g. 2024-01-01), got {}",
            cmd,
            value_kind_name(other)
        )),
    }
}

/// Extract a [`TimeValue`] from a [`Value::Time`] literal arg.
fn require_time_literal(args: &[CommandArg], cmd: &str) -> Result<TimeValue, String> {
    match require_literal(args, cmd)? {
        crate::literals::Value::Time(t) => Ok(t.clone()),
        other => Err(format!(
            "{} requires a time literal (e.g. 12:30:00), got {}",
            cmd,
            value_kind_name(other)
        )),
    }
}

/// Default `help` for a built-in primitive (goal-oriented; syntax lives in [`LemmaType::example_value`]).
#[must_use]
pub fn default_help_for_primitive(kind: PrimitiveKind) -> &'static str {
    use PrimitiveKind::*;
    match kind {
        Boolean => "Whether this holds (true or false).",
        Number => "A dimensionless number.",
        NumberRange => "The lower and upper bound of the number range.",
        Text => "A text value.",
        Quantity => "A numeric amount in one of this type's units.",
        QuantityRange => "The lower and upper bound of the quantity range in the same unit.",
        Ratio | Percent => "A ratio in one of this type's units (e.g. percent).",
        RatioRange => "The lower and upper bound of the ratio range.",
        Date => "A date, or a date and time with optional timezone.",
        DateRange => "The start date and end date of the date range.",
        Time => "A time of day, with optional timezone.",
        TimeRange => "The start time and end time of the time range.",
    }
}

impl TypeSpecification {
    pub fn boolean() -> Self {
        TypeSpecification::Boolean {
            help: default_help_for_primitive(PrimitiveKind::Boolean).to_string(),
        }
    }
    pub fn quantity() -> Self {
        TypeSpecification::Quantity {
            minimum: None,
            maximum: None,
            decimals: None,
            units: QuantityUnits::new(),
            traits: Vec::new(),
            decomposition: None,
            help: default_help_for_primitive(PrimitiveKind::Quantity).to_string(),
        }
    }
    pub fn number() -> Self {
        TypeSpecification::Number {
            minimum: None,
            maximum: None,
            decimals: None,
            help: default_help_for_primitive(PrimitiveKind::Number).to_string(),
        }
    }
    pub fn number_range() -> Self {
        TypeSpecification::NumberRange {
            help: default_help_for_primitive(PrimitiveKind::NumberRange).to_string(),
        }
    }
    pub fn ratio() -> Self {
        TypeSpecification::Ratio {
            minimum: None,
            maximum: None,
            decimals: None,
            units: RatioUnits(vec![
                RatioUnit {
                    name: "percent".to_string(),
                    value: crate::computation::rational::rational_new(100, 1),
                    minimum: None,
                    maximum: None,
                    default_magnitude: None,
                },
                RatioUnit {
                    name: "permille".to_string(),
                    value: crate::computation::rational::rational_new(1000, 1),
                    minimum: None,
                    maximum: None,
                    default_magnitude: None,
                },
            ]),
            help: default_help_for_primitive(PrimitiveKind::Ratio).to_string(),
        }
    }
    pub fn ratio_range() -> Self {
        TypeSpecification::RatioRange {
            units: match TypeSpecification::ratio() {
                TypeSpecification::Ratio { units, .. } => units,
                _ => unreachable!("BUG: ratio constructor must return a ratio type"),
            },
            help: default_help_for_primitive(PrimitiveKind::RatioRange).to_string(),
        }
    }
    pub fn text() -> Self {
        TypeSpecification::Text {
            length: None,
            options: vec![],
            help: default_help_for_primitive(PrimitiveKind::Text).to_string(),
        }
    }
    pub fn date() -> Self {
        TypeSpecification::Date {
            minimum: None,
            maximum: None,
            help: default_help_for_primitive(PrimitiveKind::Date).to_string(),
        }
    }
    pub fn date_range() -> Self {
        TypeSpecification::DateRange {
            help: default_help_for_primitive(PrimitiveKind::DateRange).to_string(),
        }
    }
    pub fn time() -> Self {
        TypeSpecification::Time {
            minimum: None,
            maximum: None,
            help: default_help_for_primitive(PrimitiveKind::Time).to_string(),
        }
    }
    pub fn time_range() -> Self {
        TypeSpecification::TimeRange {
            help: default_help_for_primitive(PrimitiveKind::TimeRange).to_string(),
        }
    }
    pub fn quantity_range() -> Self {
        TypeSpecification::QuantityRange {
            units: QuantityUnits::new(),
            decomposition: None,
            help: default_help_for_primitive(PrimitiveKind::QuantityRange).to_string(),
        }
    }

    /// Element spec for a range type (e.g. `QuantityRange` → `Quantity`).
    #[must_use]
    pub fn element_from_range(&self) -> Option<Self> {
        match self {
            TypeSpecification::NumberRange { .. } => Some(TypeSpecification::number()),
            TypeSpecification::QuantityRange {
                units,
                decomposition,
                ..
            } => Some(TypeSpecification::Quantity {
                minimum: None,
                maximum: None,
                decimals: None,
                units: units.clone(),
                traits: Vec::new(),
                decomposition: decomposition.clone(),
                help: String::new(),
            }),
            TypeSpecification::DateRange { .. } => Some(TypeSpecification::date()),
            TypeSpecification::TimeRange { .. } => Some(TypeSpecification::time()),
            TypeSpecification::RatioRange { units, .. } => Some(TypeSpecification::Ratio {
                minimum: None,
                maximum: None,
                decimals: None,
                units: units.clone(),
                help: String::new(),
            }),
            _ => None,
        }
    }

    /// Range spec for an element type (e.g. `Quantity` → `QuantityRange`).
    #[must_use]
    pub fn range_from_element(&self) -> Option<Self> {
        match self {
            TypeSpecification::Number { .. } => Some(TypeSpecification::number_range()),
            TypeSpecification::Quantity {
                units,
                decomposition,
                ..
            } => Some(TypeSpecification::QuantityRange {
                units: units.clone(),
                decomposition: decomposition.clone(),
                help: default_help_for_primitive(PrimitiveKind::QuantityRange).to_string(),
            }),
            TypeSpecification::Date { .. } => Some(TypeSpecification::date_range()),
            TypeSpecification::Time { .. } => Some(TypeSpecification::time_range()),
            TypeSpecification::Ratio { units, .. } => Some(TypeSpecification::RatioRange {
                units: units.clone(),
                help: default_help_for_primitive(PrimitiveKind::RatioRange).to_string(),
            }),
            _ => None,
        }
    }

    /// Minimum bound as decimal for interactive numeric prompts (number, quantity, ratio).
    #[must_use]
    pub fn minimum_decimal(&self) -> Option<Decimal> {
        use crate::computation::rational::commit_rational_to_decimal;
        match self {
            TypeSpecification::Number { minimum, .. }
            | TypeSpecification::Ratio { minimum, .. } => minimum.as_ref().map(|bound| {
                commit_rational_to_decimal(bound)
                    .expect("BUG: planned minimum must commit to decimal")
            }),
            TypeSpecification::Quantity { minimum, .. } => {
                minimum.as_ref().map(|(bound, _unit)| {
                    commit_rational_to_decimal(bound)
                        .expect("BUG: planned minimum must commit to decimal")
                })
            }
            _ => None,
        }
    }

    /// Maximum bound as decimal for interactive numeric prompts (number, quantity, ratio).
    #[must_use]
    pub fn maximum_decimal(&self) -> Option<Decimal> {
        use crate::computation::rational::commit_rational_to_decimal;
        match self {
            TypeSpecification::Number { maximum, .. }
            | TypeSpecification::Ratio { maximum, .. } => maximum.as_ref().map(|bound| {
                commit_rational_to_decimal(bound)
                    .expect("BUG: planned maximum must commit to decimal")
            }),
            TypeSpecification::Quantity { maximum, .. } => {
                maximum.as_ref().map(|(bound, _unit)| {
                    commit_rational_to_decimal(bound)
                        .expect("BUG: planned maximum must commit to decimal")
                })
            }
            _ => None,
        }
    }

    pub fn veto() -> Self {
        TypeSpecification::Veto { message: None }
    }

    /// Apply a single constraint command to this spec.
    ///
    /// The `declared_default` out-parameter receives the default value (if the command
    /// is `Default`), encoded as [`RawDefault`]. Defaults are owned by the data binding
    /// or typedef entry, not by the type specification itself; callers thread a single
    /// `&mut Option<RawDefault>` across all constraint applications for one type so the
    /// latest `-> default` command wins. Quantity scalars stay raw until unit factors
    /// are resolved; callers materialize via [`materialize_raw_default`].
    pub fn apply_constraint(
        mut self,
        type_name: &str,
        command: TypeConstraintCommand,
        args: &[CommandArg],
        declared_default: &mut Option<RawDefault>,
    ) -> Result<Self, String> {
        if command == TypeConstraintCommand::Trait
            && !matches!(&self, TypeSpecification::Quantity { .. })
        {
            return Err("trait command is only valid on quantity types".to_string());
        }
        match &mut self {
            TypeSpecification::Boolean { help } => match command {
                TypeConstraintCommand::Help => {
                    apply_type_help_command(help, args)?;
                }
                TypeConstraintCommand::Default => {
                    let lit = require_literal(args, "default")?;
                    reject_calendar_for_default(lit, type_name, DefaultExpectation::Boolean, None)?;
                    match lit {
                        crate::literals::Value::Boolean(bv) => {
                            *declared_default =
                                Some(RawDefault::Value(ValueKind::Boolean(bool::from(bv))));
                        }
                        _ => {
                            return Err(
                                "Please provide true or false, for example `-> default true`."
                                    .to_string(),
                            );
                        }
                    }
                }
                other => {
                    return Err(format!(
                        "Invalid command '{}' for boolean type. Valid commands: help, default",
                        other
                    ));
                }
            },
            TypeSpecification::Quantity {
                decimals,
                minimum,
                maximum,
                units,
                traits,
                decomposition,
                help,
                ..
            } => match command {
                TypeConstraintCommand::Decimals => {
                    let d = require_decimal_literal(args, "decimals")?;
                    *decimals = Some(decimal_to_u8(d, "decimals")?);
                }
                TypeConstraintCommand::Unit => {
                    let (unit_name, value, derived_quantity_factors) = match args {
                        [CommandArg::Label(name), CommandArg::UnitExpr(crate::parsing::ast::UnitArg::Factor(v))] => {
                            (name.clone(), *v, Vec::new())
                        }
                        [CommandArg::Label(name), CommandArg::UnitExpr(crate::parsing::ast::UnitArg::Expr(
                            prefix,
                            factors,
                        ))] => {
                            let raw: Vec<(String, i32)> = factors
                                .iter()
                                .map(|f| (f.quantity_ref.clone(), f.exp))
                                .collect();
                            (name.clone(), *prefix, raw)
                        }
                        _ => {
                            return Err(
                                "unit requires a unit name followed by a conversion factor or compound unit expression (e.g., 'unit eur 1.00' or 'unit mps meter/second')"
                                    .to_string(),
                            );
                        }
                    };
                    if let Some(existing) = units.0.iter().find(|u| u.name == unit_name) {
                        let new_factor = crate::computation::rational::decimal_to_rational(value)
                            .map_err(|failure| failure.to_string())?;
                        if existing.factor != new_factor
                            || existing.derived_quantity_factors != derived_quantity_factors
                        {
                            return Err(format!(
                                "Unit '{unit_name}' is already defined in this type's inherited units; \
                                 cannot change factor or decomposition. Add a new unit name instead."
                            ));
                        }
                    } else {
                        units.0.push(QuantityUnit::from_decimal_factor(
                            unit_name,
                            value,
                            derived_quantity_factors,
                        )?);
                    }
                }
                TypeConstraintCommand::Trait => {
                    let quantity_trait = parse_quantity_trait(args)?;
                    if traits.contains(&quantity_trait) {
                        return Err(format!(
                            "Duplicate trait '{}' for quantity type.",
                            quantity_trait_name(quantity_trait)
                        ));
                    }
                    if quantity_trait == QuantityTrait::Duration {
                        validate_duration_trait_requirements(units)?;
                    }
                    if quantity_trait == QuantityTrait::Calendar {
                        validate_calendar_trait_requirements(units)?;
                    }
                    traits.push(quantity_trait);
                }
                TypeConstraintCommand::Minimum => {
                    *minimum = Some(parse_quantity_declared_bound(
                        args, "minimum", units, type_name,
                    )?);
                }
                TypeConstraintCommand::Maximum => {
                    *maximum = Some(parse_quantity_declared_bound(
                        args, "maximum", units, type_name,
                    )?);
                }
                TypeConstraintCommand::Help => {
                    apply_type_help_command(help, args)?;
                }
                TypeConstraintCommand::Default => {
                    let lit = require_literal(args, "default")?;
                    if traits.contains(&QuantityTrait::Calendar) {
                        match lit {
                            crate::literals::Value::Range(left, right) => {
                                validate_calendar_range_default_endpoint(left, type_name, units)?;
                                validate_calendar_range_default_endpoint(right, type_name, units)?;
                                let element_spec = TypeSpecification::Quantity {
                                    minimum: minimum.clone(),
                                    maximum: maximum.clone(),
                                    decimals: *decimals,
                                    units: units.clone(),
                                    traits: traits.clone(),
                                    decomposition: decomposition.clone(),
                                    help: String::new(),
                                };
                                let left = lift_range_endpoint(left, &element_spec)?;
                                let right = lift_range_endpoint(right, &element_spec)?;
                                *declared_default = Some(RawDefault::Value(ValueKind::Range(
                                    Box::new(left),
                                    Box::new(right),
                                )));
                            }
                            crate::literals::Value::NumberWithUnit(_, _) => {
                                let (magnitude, unit_name) = parse_quantity_declared_bound(
                                    args, "default", units, type_name,
                                )?;
                                *declared_default = Some(RawDefault::Quantity {
                                    magnitude,
                                    unit_name,
                                });
                            }
                            _ => {
                                return Err(quantity_default_wrong_shape_error(type_name, traits));
                            }
                        }
                    } else {
                        reject_calendar_for_default(
                            lit,
                            type_name,
                            DefaultExpectation::QuantityUnits,
                            Some(units),
                        )?;
                        let (magnitude, unit_name) =
                            parse_quantity_declared_bound(args, "default", units, type_name)?;
                        *declared_default = Some(RawDefault::Quantity {
                            magnitude,
                            unit_name,
                        });
                    }
                }
                _ => {
                    return Err(format!(
                        "Invalid command '{}' for quantity type. Valid commands: unit, trait, minimum, maximum, decimals, help, default",
                        command
                    ));
                }
            },
            TypeSpecification::Number {
                decimals,
                minimum,
                maximum,
                help,
            } => match command {
                TypeConstraintCommand::Decimals => {
                    let d = require_decimal_literal(args, "decimals")?;
                    *decimals = Some(decimal_to_u8(d, "decimals")?);
                }
                TypeConstraintCommand::Unit => {
                    return Err(
                        "Invalid command 'unit' for number type. Number types are dimensionless and cannot have units. Use 'quantity' type instead.".to_string()
                    );
                }
                TypeConstraintCommand::Minimum => {
                    *minimum = Some(require_decimal_literal(args, "minimum")?);
                }
                TypeConstraintCommand::Maximum => {
                    *maximum = Some(require_decimal_literal(args, "maximum")?);
                }
                TypeConstraintCommand::Help => {
                    apply_type_help_command(help, args)?;
                }
                TypeConstraintCommand::Default => {
                    let lit = require_literal(args, "default")?;
                    reject_calendar_for_default(lit, type_name, DefaultExpectation::Number, None)?;
                    match lit {
                        crate::literals::Value::Number(d) => {
                            *declared_default = Some(RawDefault::Value(ValueKind::Number(
                                lift_parser_decimal(*d)?,
                            )));
                        }
                        _ => {
                            return Err(
                                "Please provide a number, for example `-> default 42`.".to_string()
                            );
                        }
                    }
                }
                _ => {
                    return Err(format!(
                        "Invalid command '{}' for number type. Valid commands: minimum, maximum, decimals, help, default",
                        command
                    ));
                }
            },
            TypeSpecification::NumberRange { help } => match command {
                TypeConstraintCommand::Help => {
                    apply_type_help_command(help, args)?;
                }
                TypeConstraintCommand::Default => {
                    let (left, right) = require_default_range_endpoints(
                        args,
                        type_name,
                        DefaultExpectation::NumberRange,
                        None,
                    )?;
                    let left = literal_value_from_parser_value(left)?;
                    let right = literal_value_from_parser_value(right)?;
                    if !left.lemma_type.is_number() || !right.lemma_type.is_number() {
                        return Err(
                            "Please provide a number range, for example `-> default 10...100`."
                                .to_string(),
                        );
                    }
                    *declared_default = Some(RawDefault::Value(ValueKind::Range(
                        Box::new(left),
                        Box::new(right),
                    )));
                }
                _ => {
                    return Err(format!(
                        "Invalid command '{}' for number range type. Valid commands: help, default",
                        command
                    ));
                }
            },
            TypeSpecification::Ratio {
                decimals,
                minimum,
                maximum,
                units,
                help,
            } => match command {
                TypeConstraintCommand::Decimals => {
                    let d = require_decimal_literal(args, "decimals")?;
                    *decimals = Some(decimal_to_u8(d, "decimals")?);
                }
                TypeConstraintCommand::Unit => {
                    let (unit_name, value_dec) = match args {
                        [CommandArg::Label(name), CommandArg::UnitExpr(crate::parsing::ast::UnitArg::Factor(v))] => {
                            (name.clone(), *v)
                        }
                        _ => {
                            return Err(
                                "unit requires a unit name followed by a numeric conversion factor (e.g., 'unit percent 100'). Compound unit expressions are not supported for ratio types."
                                    .to_string(),
                            );
                        }
                    };
                    let value = crate::computation::rational::decimal_to_rational(value_dec)
                        .map_err(|failure| {
                            format!(
                                "ratio unit value is not exactly representable as a rational: {}",
                                failure
                            )
                        })?;
                    if let Some(existing) = units.0.iter().find(|u| u.name == unit_name) {
                        if existing.value != value {
                            return Err(format!(
                                "Unit '{unit_name}' is already defined in this type's inherited units; \
                                 cannot change factor. Add a new unit name instead."
                            ));
                        }
                    } else {
                        units.0.push(RatioUnit {
                            name: unit_name,
                            value,
                            minimum: None,
                            maximum: None,
                            default_magnitude: None,
                        });
                    }
                }
                TypeConstraintCommand::Minimum => {
                    let canonical = ratio_bound_to_canonical_rational(args, "minimum", units)?;
                    sync_ratio_units_from_canonical(
                        units,
                        &canonical,
                        UnitConstraintField::Minimum,
                    )?;
                    *minimum = Some(canonical);
                }
                TypeConstraintCommand::Maximum => {
                    let canonical = ratio_bound_to_canonical_rational(args, "maximum", units)?;
                    sync_ratio_units_from_canonical(
                        units,
                        &canonical,
                        UnitConstraintField::Maximum,
                    )?;
                    *maximum = Some(canonical);
                }
                TypeConstraintCommand::Help => {
                    apply_type_help_command(help, args)?;
                }
                TypeConstraintCommand::Default => {
                    let lit = require_literal(args, "default")?;
                    reject_calendar_for_default(lit, type_name, DefaultExpectation::Ratio, None)?;
                    let default = match lit {
                        crate::literals::Value::NumberWithUnit(_, _) => {
                            let element_spec = TypeSpecification::Ratio {
                                decimals: *decimals,
                                minimum: minimum.clone(),
                                maximum: maximum.clone(),
                                units: units.clone(),
                                help: help.clone(),
                            };
                            parser_value_to_value_kind(lit, &element_spec)?
                        }
                        other => {
                            return Err(format!(
                                "default requires a ratio literal with a unit, got {}. Please provide a ratio value with a unit, for example `-> default 25%`.",
                                value_kind_name(other)
                            ));
                        }
                    };
                    sync_ratio_default_units(units, &default)?;
                    *declared_default = Some(RawDefault::Value(default));
                }
                _ => {
                    return Err(format!(
                        "Invalid command '{}' for ratio type. Valid commands: unit, minimum, maximum, decimals, help, default",
                        command
                    ));
                }
            },
            TypeSpecification::RatioRange { units, help } => match command {
                TypeConstraintCommand::Unit => {
                    let (unit_name, value_dec) = match args {
                        [CommandArg::Label(name), CommandArg::UnitExpr(crate::parsing::ast::UnitArg::Factor(v))] => {
                            (name.clone(), *v)
                        }
                        _ => {
                            return Err(
                                "unit requires a unit name followed by a numeric conversion factor (e.g., 'unit percent 100'). Compound unit expressions are not supported for ratio range types."
                                    .to_string(),
                            );
                        }
                    };
                    let value = crate::computation::rational::decimal_to_rational(value_dec)
                        .map_err(|e| {
                            format!(
                                "ratio unit value is not exactly representable as a rational: {e}"
                            )
                        })?;
                    if let Some(existing) = units.0.iter().find(|u| u.name == unit_name) {
                        if existing.value != value {
                            return Err(format!(
                                "Unit '{unit_name}' is already defined in this type's inherited units; \
                                 cannot change factor. Add a new unit name instead."
                            ));
                        }
                    } else {
                        units.0.push(RatioUnit {
                            name: unit_name,
                            value,
                            minimum: None,
                            maximum: None,
                            default_magnitude: None,
                        });
                    }
                }
                TypeConstraintCommand::Help => {
                    apply_type_help_command(help, args)?;
                }
                TypeConstraintCommand::Default => {
                    let (left, right) = require_default_range_endpoints(
                        args,
                        type_name,
                        DefaultExpectation::RatioRange,
                        None,
                    )?;
                    let element_spec = TypeSpecification::Ratio {
                        decimals: None,
                        minimum: None,
                        maximum: None,
                        units: units.clone(),
                        help: String::new(),
                    };
                    let left = lift_range_endpoint(left, &element_spec)?;
                    let right = lift_range_endpoint(right, &element_spec)?;
                    if !left.lemma_type.is_ratio() || !right.lemma_type.is_ratio() {
                        return Err(
                            "Please provide a ratio range, for example `-> default 10%...50%`."
                                .to_string(),
                        );
                    }
                    *declared_default = Some(RawDefault::Value(ValueKind::Range(
                        Box::new(left),
                        Box::new(right),
                    )));
                }
                _ => {
                    return Err(format!(
                        "Invalid command '{}' for ratio range type. Valid commands: unit, help, default",
                        command
                    ));
                }
            },
            TypeSpecification::Text {
                length,
                options,
                help,
            } => match command {
                TypeConstraintCommand::Option => {
                    if args.len() != 1 {
                        return Err("option takes exactly one argument".to_string());
                    }
                    options.push(option_name(&args[0], "option")?);
                }
                TypeConstraintCommand::Options => {
                    let mut collected = Vec::with_capacity(args.len());
                    for arg in args {
                        collected.push(option_name(arg, "options")?);
                    }
                    *options = collected;
                }
                TypeConstraintCommand::Length => {
                    let d = require_decimal_literal(args, "length")?;
                    *length = Some(decimal_to_usize(d, "length")?);
                }
                TypeConstraintCommand::Help => {
                    apply_type_help_command(help, args)?;
                }
                TypeConstraintCommand::Default => {
                    let lit = require_literal(args, "default")?;
                    reject_calendar_for_default(lit, type_name, DefaultExpectation::Text, None)?;
                    match lit {
                        crate::literals::Value::Text(s) => {
                            *declared_default = Some(RawDefault::Value(ValueKind::Text(s.clone())));
                        }
                        _ => {
                            return Err(
                                "Please provide a text value in double quotes, for example `-> default \"my default value\"`."
                                    .to_string(),
                            );
                        }
                    }
                }
                _ => {
                    return Err(format!(
                        "Invalid command '{}' for text type. Valid commands: options, length, help, default",
                        command
                    ));
                }
            },
            TypeSpecification::Date {
                minimum,
                maximum,
                help,
            } => match command {
                TypeConstraintCommand::Minimum => {
                    let dt = require_date_literal(args, "minimum")?;
                    *minimum = Some(dt);
                }
                TypeConstraintCommand::Maximum => {
                    let dt = require_date_literal(args, "maximum")?;
                    *maximum = Some(dt);
                }
                TypeConstraintCommand::Help => {
                    apply_type_help_command(help, args)?;
                }
                TypeConstraintCommand::Default => {
                    let lit = require_literal(args, "default")?;
                    reject_calendar_for_default(lit, type_name, DefaultExpectation::Date, None)?;
                    match lit {
                        crate::literals::Value::Date(dt) => {
                            *declared_default = Some(RawDefault::Value(ValueKind::Date(
                                date_time_to_semantic(dt),
                            )));
                        }
                        _ => {
                            return Err(
                                "Please provide a date, for example `-> default 2024-06-15`."
                                    .to_string(),
                            );
                        }
                    }
                }
                _ => {
                    return Err(format!(
                        "Invalid command '{}' for date type. Valid commands: minimum, maximum, help, default",
                        command
                    ));
                }
            },
            TypeSpecification::DateRange { help } => match command {
                TypeConstraintCommand::Help => {
                    apply_type_help_command(help, args)?;
                }
                TypeConstraintCommand::Default => {
                    let (left, right) = require_default_range_endpoints(
                        args,
                        type_name,
                        DefaultExpectation::DateRange,
                        None,
                    )?;
                    let left = literal_value_from_parser_value(left)?;
                    let right = literal_value_from_parser_value(right)?;
                    if !left.lemma_type.is_date() || !right.lemma_type.is_date() {
                        return Err(
                            "Please provide a date range, for example `-> default 2024-01-01...2024-12-31`."
                                .to_string(),
                        );
                    }
                    *declared_default = Some(RawDefault::Value(ValueKind::Range(
                        Box::new(left),
                        Box::new(right),
                    )));
                }
                _ => {
                    return Err(format!(
                        "Invalid command '{}' for date range type. Valid commands: help, default",
                        command
                    ));
                }
            },
            TypeSpecification::Time {
                minimum,
                maximum,
                help,
            } => match command {
                TypeConstraintCommand::Minimum => {
                    let t = require_time_literal(args, "minimum")?;
                    *minimum = Some(t);
                }
                TypeConstraintCommand::Maximum => {
                    let t = require_time_literal(args, "maximum")?;
                    *maximum = Some(t);
                }
                TypeConstraintCommand::Help => {
                    apply_type_help_command(help, args)?;
                }
                TypeConstraintCommand::Default => {
                    let lit = require_literal(args, "default")?;
                    reject_calendar_for_default(lit, type_name, DefaultExpectation::Time, None)?;
                    match lit {
                        crate::literals::Value::Time(t) => {
                            *declared_default =
                                Some(RawDefault::Value(ValueKind::Time(time_to_semantic(t))));
                        }
                        _ => {
                            return Err(
                                "Please provide a time, for example `-> default 09:00:00`."
                                    .to_string(),
                            );
                        }
                    }
                }
                _ => {
                    return Err(format!(
                        "Invalid command '{}' for time type. Valid commands: minimum, maximum, help, default",
                        command
                    ));
                }
            },
            TypeSpecification::TimeRange { help } => match command {
                TypeConstraintCommand::Help => {
                    apply_type_help_command(help, args)?;
                }
                TypeConstraintCommand::Default => {
                    let (left, right) = require_default_range_endpoints(
                        args,
                        type_name,
                        DefaultExpectation::TimeRange,
                        None,
                    )?;
                    let left = literal_value_from_parser_value(left)?;
                    let right = literal_value_from_parser_value(right)?;
                    if !left.lemma_type.is_time() || !right.lemma_type.is_time() {
                        return Err(
                            "Please provide a time range, for example `-> default 09:00...17:00`."
                                .to_string(),
                        );
                    }
                    *declared_default = Some(RawDefault::Value(ValueKind::Range(
                        Box::new(left),
                        Box::new(right),
                    )));
                }
                _ => {
                    return Err(format!(
                        "Invalid command '{}' for time range type. Valid commands: help, default",
                        command
                    ));
                }
            },
            TypeSpecification::QuantityRange {
                units,
                decomposition,
                help,
                ..
            } => match command {
                TypeConstraintCommand::Unit => {
                    let (unit_name, value, derived_quantity_factors) = match args {
                        [CommandArg::Label(name), CommandArg::UnitExpr(crate::parsing::ast::UnitArg::Factor(v))] => {
                            (name.clone(), *v, Vec::new())
                        }
                        [CommandArg::Label(name), CommandArg::UnitExpr(crate::parsing::ast::UnitArg::Expr(
                            prefix,
                            factors,
                        ))] => {
                            let raw: Vec<(String, i32)> = factors
                                .iter()
                                .map(|f| (f.quantity_ref.clone(), f.exp))
                                .collect();
                            (name.clone(), *prefix, raw)
                        }
                        _ => {
                            return Err(
                                "unit requires a unit name followed by a conversion factor or compound unit expression (e.g., 'unit eur 1.00' or 'unit mps meter/second')"
                                    .to_string(),
                            );
                        }
                    };
                    if let Some(existing) = units.0.iter().find(|u| u.name == unit_name) {
                        let new_factor = crate::computation::rational::decimal_to_rational(value)
                            .map_err(|failure| failure.to_string())?;
                        if existing.factor != new_factor
                            || existing.derived_quantity_factors != derived_quantity_factors
                        {
                            return Err(format!(
                                "Unit '{unit_name}' is already defined in this type's inherited units; \
                                 cannot change factor or decomposition. Add a new unit name instead."
                            ));
                        }
                    } else {
                        units.0.push(QuantityUnit::from_decimal_factor(
                            unit_name,
                            value,
                            derived_quantity_factors,
                        )?);
                    }
                }
                TypeConstraintCommand::Help => {
                    apply_type_help_command(help, args)?;
                }
                TypeConstraintCommand::Default => {
                    let (left, right) = require_default_range_endpoints(
                        args,
                        type_name,
                        DefaultExpectation::QuantityRange,
                        Some(units),
                    )?;
                    let element_spec = TypeSpecification::Quantity {
                        minimum: None,
                        maximum: None,
                        decimals: None,
                        units: units.clone(),
                        traits: vec![],
                        decomposition: decomposition.clone(),
                        help: String::new(),
                    };
                    let left = lift_range_endpoint(left, &element_spec)?;
                    let right = lift_range_endpoint(right, &element_spec)?;
                    if !left.lemma_type.is_quantity() || !right.lemma_type.is_quantity() {
                        return Err(format!(
                            "Please provide a range with units valid for '{type_name}', for example `-> default 30 kilogram...35 kilogram`."
                        ));
                    }
                    *declared_default = Some(RawDefault::Value(ValueKind::Range(
                        Box::new(left),
                        Box::new(right),
                    )));
                }
                _ => {
                    return Err(format!(
                        "Invalid command '{}' for quantity range type. Valid commands: unit, help, default",
                        command
                    ));
                }
            },
            TypeSpecification::Veto { .. } => {
                return Err(format!(
                    "Invalid command '{}' for veto type. Veto is not a user-declarable type and cannot have constraints",
                    command
                ));
            }
            TypeSpecification::Undetermined => {
                return Err(format!(
                    "Invalid command '{}' for undetermined sentinel type. Undetermined is an internal type used during type inference and cannot have constraints",
                    command
                ));
            }
        }
        Ok(self)
    }
}

/// Parse a "number unit" string into a Quantity or Ratio value according to the type.
/// Caller must have obtained the TypeSpecification via unit_index from the unit in the string.
pub fn parse_number_unit(
    value_str: &str,
    type_spec: &TypeSpecification,
) -> Result<crate::parsing::ast::Value, String> {
    use crate::literals::{NumberWithUnit, RatioLiteral};
    use crate::parsing::ast::Value;

    let trimmed = value_str.trim();
    match type_spec {
        TypeSpecification::Quantity { units, .. } => {
            if units.is_empty() {
                unreachable!(
                    "BUG: Quantity type has no units; should have been validated during planning"
                );
            }
            match trimmed.parse::<NumberWithUnit>() {
                Ok(n) => {
                    let unit = units.get(&n.1).map_err(|e| e.to_string())?;
                    Ok(Value::NumberWithUnit(n.0, unit.name.clone()))
                }
                Err(e) => {
                    if trimmed.split_whitespace().count() == 1 && !trimmed.is_empty() {
                        let valid: Vec<&str> = units.iter().map(|u| u.name.as_str()).collect();
                        let example_unit = units
                            .iter()
                            .next()
                            .expect("BUG: units non-empty after guard")
                            .name
                            .as_str();
                        Err(format!(
                            "Quantity value must include a unit, for example: '{} {}'. Valid units: {}.",
                            trimmed,
                            example_unit,
                            valid.join(", ")
                        ))
                    } else {
                        Err(e)
                    }
                }
            }
        }
        TypeSpecification::Ratio { units, .. } => {
            if units.is_empty() {
                unreachable!(
                    "BUG: Ratio type has no units; should have been validated during planning"
                );
            }
            match trimmed.parse::<RatioLiteral>()? {
                RatioLiteral::Bare(_) => {
                    Err("Ratio value requires a unit (e.g. '50%', '500 basis_points').".to_string())
                }
                RatioLiteral::Percent(n) => {
                    let unit = units.get("percent").map_err(|e| e.to_string())?;
                    Ok(Value::NumberWithUnit(n, unit.name.clone()))
                }
                RatioLiteral::Permille(n) => {
                    let unit = units.get("permille").map_err(|e| e.to_string())?;
                    Ok(Value::NumberWithUnit(n, unit.name.clone()))
                }
                RatioLiteral::Named { value, unit } => {
                    let resolved = units.get(&unit).map_err(|e| e.to_string())?;
                    Ok(Value::NumberWithUnit(value, resolved.name.clone()))
                }
            }
        }
        _ => Err("parse_number_unit only accepts Quantity or Ratio type".to_string()),
    }
}

/// Parse a string value according to a TypeSpecification.
/// Used to parse runtime user input into typed values.
pub fn parse_value_from_string(
    value_str: &str,
    type_spec: &TypeSpecification,
    source: &Source,
) -> Result<crate::parsing::ast::Value, Error> {
    use crate::parsing::ast::Value;

    let to_err = |msg: String| Error::validation(msg, Some(source.clone()), None::<String>);

    let parse_range_value = |element_spec: TypeSpecification| -> Result<Value, Error> {
        let (left_str, right_str) = value_str.split_once("...").ok_or_else(|| {
            to_err("Range value must use '...' between the two endpoints".to_string())
        })?;
        if left_str.trim().is_empty() || right_str.trim().is_empty() {
            return Err(to_err(
                "Range value must contain a non-empty left and right endpoint".to_string(),
            ));
        }
        let left = parse_value_from_string(left_str.trim(), &element_spec, source)?;
        let right = parse_value_from_string(right_str.trim(), &element_spec, source)?;
        Ok(Value::Range(Box::new(left), Box::new(right)))
    };

    match type_spec {
        TypeSpecification::Text { .. } => value_str
            .parse::<crate::literals::TextLiteral>()
            .map(|t| Value::Text(t.0))
            .map_err(to_err),
        TypeSpecification::Number { .. } => value_str
            .parse::<crate::literals::NumberLiteral>()
            .map(|n| Value::Number(n.0))
            .map_err(to_err),
        TypeSpecification::Quantity { .. } => {
            parse_number_unit(value_str, type_spec).map_err(to_err)
        }
        TypeSpecification::Boolean { .. } => value_str
            .parse::<BooleanValue>()
            .map(Value::Boolean)
            .map_err(to_err),
        TypeSpecification::Date { .. } => {
            let date = value_str.parse::<DateTimeValue>().map_err(to_err)?;
            Ok(Value::Date(date))
        }
        TypeSpecification::Time { .. } => {
            let time = value_str.parse::<TimeValue>().map_err(to_err)?;
            Ok(Value::Time(time))
        }
        TypeSpecification::Ratio { .. } => {
            parse_number_unit(value_str, type_spec).map_err(to_err)
        }
        TypeSpecification::NumberRange { .. }
        | TypeSpecification::QuantityRange { .. }
        | TypeSpecification::DateRange { .. }
        | TypeSpecification::TimeRange { .. }
        | TypeSpecification::RatioRange { .. } => {
            let element_spec = range_element_type_specification(type_spec).unwrap_or_else(|| {
                unreachable!("BUG: range_element_type_specification missing arm for known range type")
            });
            parse_range_value(element_spec)
        }
        TypeSpecification::Veto { .. } => Err(to_err(
            "Veto type cannot be parsed from string".to_string(),
        )),
        TypeSpecification::Undetermined => unreachable!(
            "BUG: parse_value_from_string called with Undetermined sentinel type; this type exists only during type inference"
        ),
    }
}

// -----------------------------------------------------------------------------
// Semantic value types (no parser dependency - used by evaluation, inversion, etc.)
// -----------------------------------------------------------------------------

#[derive(Debug, Clone, PartialEq, Eq, Hash, Serialize, Deserialize)]
#[serde(rename_all = "snake_case")]
pub enum SemanticCalendarUnit {
    Month,
    Year,
}

impl fmt::Display for SemanticCalendarUnit {
    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
        let s = match self {
            SemanticCalendarUnit::Month => "month",
            SemanticCalendarUnit::Year => "year",
        };
        write!(f, "{}", s)
    }
}

pub fn semantic_calendar_unit_from_unit_name(unit_name: &str) -> SemanticCalendarUnit {
    match unit_name {
        "month" | "months" => SemanticCalendarUnit::Month,
        "year" | "years" => SemanticCalendarUnit::Year,
        other => unreachable!(
            "BUG: calendar quantity signature unit must be month or year, got '{other}'"
        ),
    }
}

pub fn semantic_calendar_unit_from_quantity_signature(
    signature: &[(String, i32)],
) -> SemanticCalendarUnit {
    let unit_name = signature
        .first()
        .map(|(name, _)| name.as_str())
        .expect("BUG: calendar quantity must carry a unit signature");
    semantic_calendar_unit_from_unit_name(unit_name)
}

mod arc_lemma_type {
    use super::LemmaType;
    use serde::{Deserialize, Deserializer, Serialize, Serializer};
    use std::sync::Arc;

    pub fn serialize<S>(value: &Arc<LemmaType>, serializer: S) -> Result<S::Ok, S::Error>
    where
        S: Serializer,
    {
        value.as_ref().serialize(serializer)
    }

    pub fn deserialize<'de, D>(deserializer: D) -> Result<Arc<LemmaType>, D::Error>
    where
        D: Deserializer<'de>,
    {
        LemmaType::deserialize(deserializer).map(Arc::new)
    }
}

/// Target type for `as` casts (semantic; used by evaluation/computation).
#[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize)]
#[serde(rename_all = "snake_case")]
pub enum SemanticConversionTarget {
    Type(PrimitiveKind),
    /// `number as eur` — construct, convert, relabel, or range-span into `unit_name`.
    Unit {
        unit_name: String,
        /// Quantity/ratio type resolved in the spec where the conversion was written.
        #[serde(with = "arc_lemma_type")]
        owning_type: Arc<LemmaType>,
    },
}

impl std::hash::Hash for SemanticConversionTarget {
    fn hash<H: std::hash::Hasher>(&self, state: &mut H) {
        match self {
            Self::Type(kind) => {
                0u8.hash(state);
                kind.hash(state);
            }
            Self::Unit {
                unit_name,
                owning_type,
            } => {
                1u8.hash(state);
                unit_name.hash(state);
                owning_type.hash(state);
            }
        }
    }
}

impl SemanticConversionTarget {
    #[must_use]
    pub fn primitive_kind(&self) -> Option<PrimitiveKind> {
        match self {
            SemanticConversionTarget::Type(kind) => Some(*kind),
            SemanticConversionTarget::Unit { .. } => None,
        }
    }
}

impl fmt::Display for SemanticConversionTarget {
    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
        match self {
            SemanticConversionTarget::Type(kind) => write!(f, "{:?}", kind),
            SemanticConversionTarget::Unit { unit_name, .. } => write!(f, "{unit_name}"),
        }
    }
}

/// Timezone for semantic date/time values
#[derive(Debug, Clone, PartialEq, Eq, PartialOrd, Ord, Hash, Serialize, Deserialize)]
pub struct SemanticTimezone {
    pub offset_hours: i8,
    pub offset_minutes: u8,
}

impl fmt::Display for SemanticTimezone {
    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
        if self.offset_hours == 0 && self.offset_minutes == 0 {
            write!(f, "Z")
        } else {
            let sign = if self.offset_hours >= 0 { "+" } else { "-" };
            let hours = self.offset_hours.abs();
            write!(f, "{}{:02}:{:02}", sign, hours, self.offset_minutes)
        }
    }
}

/// Time-of-day for semantic values
#[derive(Debug, Clone, PartialEq, Eq, PartialOrd, Ord, Hash, Serialize, Deserialize)]
pub struct SemanticTime {
    pub hour: u32,
    pub minute: u32,
    pub second: u32,
    pub microsecond: u32,
    pub timezone: Option<SemanticTimezone>,
}

impl fmt::Display for SemanticTime {
    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
        write!(f, "{:02}:{:02}:{:02}", self.hour, self.minute, self.second)?;
        if self.microsecond != 0 {
            write!(f, ".{:06}", self.microsecond)?;
        }
        if let Some(timezone) = &self.timezone {
            write!(f, "{}", timezone)?;
        }
        Ok(())
    }
}

/// Date-time for semantic values
#[derive(Debug, Clone, PartialEq, Eq, PartialOrd, Ord, Hash, Serialize, Deserialize)]
pub struct SemanticDateTime {
    pub year: i32,
    pub month: u32,
    pub day: u32,
    pub hour: u32,
    pub minute: u32,
    pub second: u32,
    #[serde(default)]
    pub microsecond: u32,
    pub timezone: Option<SemanticTimezone>,
}

impl fmt::Display for SemanticDateTime {
    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
        let has_time = self.hour != 0
            || self.minute != 0
            || self.second != 0
            || self.microsecond != 0
            || self.timezone.is_some();
        if !has_time {
            write!(f, "{:04}-{:02}-{:02}", self.year, self.month, self.day)
        } else {
            write!(
                f,
                "{:04}-{:02}-{:02}T{:02}:{:02}:{:02}",
                self.year, self.month, self.day, self.hour, self.minute, self.second
            )?;
            if self.microsecond != 0 {
                write!(f, ".{:06}", self.microsecond)?;
            }
            if let Some(tz) = &self.timezone {
                write!(f, "{}", tz)?;
            }
            Ok(())
        }
    }
}

/// Default captured during type constraint application, before quantity unit factors are final.
/// Materialized into [`ValueKind`] after `resolve_quantity_decompositions` (or immediately for
/// reference-local defaults, which run after that pass).
#[derive(Debug, Clone, PartialEq, Eq, Hash)]
pub enum RawDefault {
    Value(ValueKind),
    Quantity {
        magnitude: RationalInteger,
        unit_name: String,
    },
}

pub fn materialize_raw_default(
    raw: RawDefault,
    specifications: &TypeSpecification,
    type_name: &str,
) -> Result<ValueKind, String> {
    match raw {
        RawDefault::Value(vk) => Ok(vk),
        RawDefault::Quantity {
            magnitude,
            unit_name,
        } => {
            let TypeSpecification::Quantity { units, .. } = specifications else {
                return Err(format!(
                    "BUG: RawDefault::Quantity for non-quantity type '{type_name}'"
                ));
            };
            let canonical = quantity_declared_bound_to_canonical(
                &magnitude, &unit_name, units, type_name, "default",
            )?;
            Ok(ValueKind::Quantity(canonical, vec![(unit_name, 1)]))
        }
    }
}

/// Value payload (shape of a literal). No type attached.
/// Quantity unit is required; Ratio unit is optional (see plan ratio-units-optional.md).
#[derive(Debug, Clone, PartialEq, Eq, Hash)]
pub enum ValueKind {
    Number(RationalInteger),
    /// Quantity: magnitude + canonical-form unit signature.
    ///
    /// The signature is always present, always in canonical form (sorted by unit name,
    /// no zero exponents), and never empty for a Quantity value. "Named" vs "anonymous"
    /// is a display-time concern: a signature_index hit yields a friendly unit name,
    /// a miss yields operator-style rendering. The magnitude is in the signature's
    /// natural unit form (no hidden canonical-base layer).
    Quantity(RationalInteger, Vec<(String, i32)>),
    Text(String),
    Date(SemanticDateTime),
    Time(SemanticTime),
    Boolean(bool),
    /// Ratio: value + optional unit
    Ratio(RationalInteger, Option<String>),
    Range(Box<LiteralValue>, Box<LiteralValue>),
}

impl ValueKind {
    /// Decimal magnitude for numeric variants (number, quantity, ratio).
    pub fn as_decimal_magnitude(&self) -> Result<Decimal, String> {
        use crate::computation::rational::commit_rational_to_decimal;
        match self {
            ValueKind::Number(n) | ValueKind::Quantity(n, _) | ValueKind::Ratio(n, _) => {
                commit_rational_to_decimal(n).map_err(|failure| failure.to_string())
            }
            other => Err(format!("expected numeric value kind, got {other}")),
        }
    }
}

fn format_rational_magnitude_for_display(rational: &RationalInteger) -> String {
    crate::computation::rational::rational_to_display_str(rational)
}

fn format_number_with_unit_for_display(rational: &RationalInteger, unit: &str) -> String {
    use crate::computation::rational::{commit_rational_to_decimal, rational_to_display_str};
    use crate::parsing::ast::Value;
    match commit_rational_to_decimal(rational) {
        Ok(decimal) => format!("{}", Value::NumberWithUnit(decimal, unit.to_string())),
        Err(_) => format!("{} {}", rational_to_display_str(rational), unit),
    }
}

impl fmt::Display for ValueKind {
    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
        use crate::computation::rational::{checked_mul, rational_to_display_str};
        match self {
            ValueKind::Number(rational) => {
                write!(f, "{}", format_rational_magnitude_for_display(rational))
            }
            ValueKind::Quantity(rational, signature) => {
                let unit = signature.first().map(|(n, _)| n.as_str()).unwrap_or("");
                write!(f, "{}", format_number_with_unit_for_display(rational, unit))
            }
            ValueKind::Text(s) => write!(f, "{}", crate::parsing::ast::Value::Text(s.clone())),
            ValueKind::Ratio(rational, unit) => match unit.as_deref() {
                Some("percent") => {
                    let display = match checked_mul(rational, &rational_new(100, 1)) {
                        Ok(scaled) => format_number_with_unit_for_display(&scaled, "percent"),
                        Err(_) => format!("{} percent", rational_to_display_str(rational)),
                    };
                    write!(f, "{}", display)
                }
                Some("permille") => {
                    let display = match checked_mul(rational, &rational_new(1000, 1)) {
                        Ok(scaled) => format_number_with_unit_for_display(&scaled, "permille"),
                        Err(_) => format!("{} permille", rational_to_display_str(rational)),
                    };
                    write!(f, "{}", display)
                }
                Some(unit_name) => {
                    write!(
                        f,
                        "{}",
                        format_number_with_unit_for_display(rational, unit_name)
                    )
                }
                None => write!(f, "{}", format_rational_magnitude_for_display(rational)),
            },
            ValueKind::Date(dt) => write!(f, "{}", dt),
            ValueKind::Time(t) => write!(
                f,
                "{}",
                crate::parsing::ast::Value::Time(crate::parsing::ast::TimeValue {
                    hour: t.hour as u8,
                    minute: t.minute as u8,
                    second: t.second as u8,
                    microsecond: t.microsecond,
                    timezone: t
                        .timezone
                        .as_ref()
                        .map(|tz| crate::parsing::ast::TimezoneValue {
                            offset_hours: tz.offset_hours,
                            offset_minutes: tz.offset_minutes,
                        }),
                })
            ),
            ValueKind::Boolean(b) => write!(f, "{}", b),
            ValueKind::Range(left, right) => write!(f, "{}...{}", left, right),
        }
    }
}

fn decimal_from_serialized_str(s: &str) -> Result<Decimal, String> {
    Decimal::from_str(s.trim()).map_err(|e| format!("invalid decimal '{s}': {e}"))
}

#[derive(Serialize, Deserialize)]
struct SerializedValueUnit {
    value: String,
    unit: String,
}

#[derive(Serialize, Deserialize)]
struct SerializedQuantity {
    value: String,
    signature: Vec<(String, i32)>,
}

#[derive(Serialize, Deserialize)]
struct SerializedRange {
    from: ValueKind,
    to: ValueKind,
}

impl Serialize for ValueKind {
    fn serialize<S: Serializer>(&self, serializer: S) -> Result<S::Ok, S::Error> {
        use serde::ser::SerializeMap;
        let mut map = serializer.serialize_map(Some(1))?;
        match self {
            ValueKind::Number(rational) => {
                map.serialize_entry(
                    "number",
                    &crate::literals::rational_to_serialized_str(rational)
                        .map_err(serde::ser::Error::custom)?,
                )?;
            }
            ValueKind::Quantity(rational, signature) => {
                map.serialize_entry(
                    "quantity",
                    &SerializedQuantity {
                        value: crate::literals::rational_to_serialized_str(rational)
                            .map_err(serde::ser::Error::custom)?,
                        signature: signature.clone(),
                    },
                )?;
            }
            ValueKind::Text(s) => {
                map.serialize_entry("text", s)?;
            }
            ValueKind::Date(dt) => {
                map.serialize_entry("date", dt)?;
            }
            ValueKind::Time(t) => {
                map.serialize_entry("time", t)?;
            }
            ValueKind::Boolean(b) => {
                map.serialize_entry("boolean", b)?;
            }
            ValueKind::Ratio(rational, unit) => {
                map.serialize_entry(
                    "ratio",
                    &SerializedValueUnit {
                        value: crate::literals::rational_to_serialized_str(rational)
                            .map_err(serde::ser::Error::custom)?,
                        unit: unit.clone().unwrap_or_default(),
                    },
                )?;
            }
            ValueKind::Range(left, right) => {
                map.serialize_entry(
                    "range",
                    &SerializedRange {
                        from: left.value.clone(),
                        to: right.value.clone(),
                    },
                )?;
            }
        }
        map.end()
    }
}

impl<'de> Deserialize<'de> for ValueKind {
    fn deserialize<D: Deserializer<'de>>(deserializer: D) -> Result<Self, D::Error> {
        let map = <serde_json::Map<String, serde_json::Value>>::deserialize(deserializer)?;
        if map.len() != 1 {
            return Err(serde::de::Error::custom(format!(
                "ValueKind must have exactly one variant key, got {}",
                map.len()
            )));
        }
        let (tag, payload) = map.into_iter().next().expect("BUG: len checked");
        deserialize_value_kind_variant(&tag, payload).map_err(serde::de::Error::custom)
    }
}

fn deserialize_value_kind_variant(
    tag: &str,
    payload: serde_json::Value,
) -> Result<ValueKind, String> {
    match tag {
        "number" => {
            let s = payload
                .as_str()
                .ok_or_else(|| "number must be a JSON string".to_string())?;
            let decimal = decimal_from_serialized_str(s)?;
            Ok(ValueKind::Number(
                crate::literals::rational_from_parsed_decimal(decimal)?,
            ))
        }
        "quantity" => {
            let pair: SerializedQuantity =
                serde_json::from_value(payload).map_err(|e| e.to_string())?;
            let decimal = decimal_from_serialized_str(&pair.value)?;
            Ok(ValueKind::Quantity(
                crate::literals::rational_from_parsed_decimal(decimal)?,
                pair.signature,
            ))
        }
        "ratio" => {
            let pair: SerializedValueUnit =
                serde_json::from_value(payload).map_err(|e| e.to_string())?;
            let unit = if pair.unit.is_empty() {
                None
            } else {
                Some(pair.unit)
            };
            let decimal = decimal_from_serialized_str(&pair.value)?;
            Ok(ValueKind::Ratio(
                crate::literals::rational_from_parsed_decimal(decimal)?,
                unit,
            ))
        }
        "calendar" => {
            let pair: SerializedValueUnit =
                serde_json::from_value(payload).map_err(|e| e.to_string())?;
            let unit = match pair.unit.as_str() {
                "month" | "months" => SemanticCalendarUnit::Month,
                "year" | "years" => SemanticCalendarUnit::Year,
                other => {
                    return Err(format!(
                        "unknown calendar unit '{other}' (expected 'month' or 'year')"
                    ));
                }
            };
            let decimal = decimal_from_serialized_str(&pair.value)?;
            Ok(ValueKind::Quantity(
                crate::literals::rational_from_parsed_decimal(decimal)?,
                vec![(unit.to_string(), 1)],
            ))
        }
        "text" => {
            let s = payload
                .as_str()
                .ok_or_else(|| "text must be a JSON string".to_string())?;
            Ok(ValueKind::Text(s.to_string()))
        }
        "date" => {
            let dt: SemanticDateTime =
                serde_json::from_value(payload).map_err(|e| e.to_string())?;
            Ok(ValueKind::Date(dt))
        }
        "time" => {
            let t: SemanticTime = serde_json::from_value(payload).map_err(|e| e.to_string())?;
            Ok(ValueKind::Time(t))
        }
        "boolean" => {
            let b = payload
                .as_bool()
                .ok_or_else(|| "boolean must be a JSON bool".to_string())?;
            Ok(ValueKind::Boolean(b))
        }
        "range" => {
            let range: SerializedRange =
                serde_json::from_value(payload).map_err(|e| e.to_string())?;
            Ok(ValueKind::Range(
                Box::new(LiteralValue {
                    value: range.from,
                    lemma_type: primitive_number_arc().clone(),
                }),
                Box::new(LiteralValue {
                    value: range.to,
                    lemma_type: primitive_number_arc().clone(),
                }),
            ))
        }
        other => Err(format!("unknown ValueKind variant '{other}'")),
    }
}

// -----------------------------------------------------------------------------
// Resolved path types (moved from parsing::ast)
// -----------------------------------------------------------------------------

/// A single segment in a resolved path traversal
///
/// Used in both DataPath and RulePath for cross-spec traversal.
/// Each segment contains a data name that resolves to another spec.
#[derive(Debug, Clone, PartialEq, Eq, PartialOrd, Ord, Hash, Serialize, Deserialize)]
pub struct PathSegment {
    /// The data name in this segment
    pub data: String,
    /// The spec this data references (resolved during planning)
    pub spec: String,
}

/// Resolved path to a data (created during planning from AST DataReference)
///
/// Represents a fully resolved path through specs to reach a datum.
#[derive(Debug, Clone, PartialEq, Eq, PartialOrd, Ord, Hash, Serialize, Deserialize)]
pub struct DataPath {
    /// Path segments (each is a cross-spec step)
    pub segments: Vec<PathSegment>,
    /// Final data name
    pub data: String,
}

impl DataPath {
    /// Create a data path from segments and data name (matches AST DataReference shape)
    pub fn new(segments: Vec<PathSegment>, data: String) -> Self {
        Self { segments, data }
    }

    /// Create a local data path (no cross-spec steps)
    pub fn local(data: String) -> Self {
        Self {
            segments: vec![],
            data,
        }
    }

    /// Dot-separated key used for matching user-provided data values (e.g. `"order.payment_method"`).
    /// Unlike `Display`, this omits the resolved spec name.
    pub fn input_key(&self) -> String {
        let mut s = String::new();
        for segment in &self.segments {
            s.push_str(&segment.data);
            s.push('.');
        }
        s.push_str(&self.data);
        s
    }
}

/// Resolved path to a rule (created during planning from RuleReference)
///
/// Represents a fully resolved path through specs to reach a rule.
#[derive(Debug, Clone, PartialEq, Eq, PartialOrd, Ord, Hash, Serialize, Deserialize)]
pub struct RulePath {
    /// Path segments (each is a cross-spec step)
    pub segments: Vec<PathSegment>,
    /// Final rule name
    pub rule: String,
}

impl RulePath {
    /// Create a rule path from segments and rule name (matches AST RuleReference shape)
    pub fn new(segments: Vec<PathSegment>, rule: String) -> Self {
        Self { segments, rule }
    }
}

// -----------------------------------------------------------------------------
// Resolved expression types (created during planning)
// -----------------------------------------------------------------------------

/// Resolved expression (all references resolved to paths, all literals typed)
///
/// Created during planning from AST Expression. All unresolved references
/// are converted to DataPath/RulePath, and all literals are typed.
#[derive(Debug, Clone, PartialEq, Serialize, Deserialize)]
pub struct Expression {
    pub kind: ExpressionKind,
    pub source_location: Option<Source>,
}

impl Expression {
    pub fn new(kind: ExpressionKind, source_location: Source) -> Self {
        Self {
            kind,
            source_location: Some(source_location),
        }
    }

    /// Create an expression with an optional source location
    pub fn with_source(kind: ExpressionKind, source_location: Option<Source>) -> Self {
        Self {
            kind,
            source_location,
        }
    }

    /// Collect all DataPath references from this resolved expression tree
    pub fn collect_data_paths(&self, data: &mut std::collections::HashSet<DataPath>) {
        self.kind.collect_data_paths(data);
    }

    /// Collect all RulePath references from this resolved expression tree
    pub fn collect_rule_paths(&self, rules: &mut std::collections::HashSet<RulePath>) {
        self.kind.collect_rule_paths(rules);
    }
}

/// Resolved expression kind (only resolved variants, no unresolved references)
#[derive(Debug, Clone, PartialEq, Serialize, Deserialize)]
#[serde(rename_all = "snake_case")]
pub enum ExpressionKind {
    /// Resolved literal with type (boxed to keep enum small)
    Literal(Box<LiteralValue>),
    /// Resolved data path
    DataPath(DataPath),
    /// Resolved rule path
    RulePath(RulePath),
    LogicalAnd(Arc<Expression>, Arc<Expression>),
    LogicalOr(Arc<Expression>, Arc<Expression>),
    Arithmetic(Arc<Expression>, ArithmeticComputation, Arc<Expression>),
    Comparison(Arc<Expression>, ComparisonComputation, Arc<Expression>),
    UnitConversion(Arc<Expression>, SemanticConversionTarget),
    LogicalNegation(Arc<Expression>, NegationType),
    MathematicalComputation(MathematicalComputation, Arc<Expression>),
    Veto(VetoExpression),
    /// The `now` keyword — resolved at evaluation to the effective datetime.
    Now,
    /// Date-relative sugar: `<date_expr> in past` / `in future`
    DateRelative(DateRelativeKind, Arc<Expression>),
    /// Calendar-period sugar: `<date_expr> in [past|future] calendar year|month|week`
    DateCalendar(DateCalendarKind, CalendarPeriodUnit, Arc<Expression>),
    RangeLiteral(Arc<Expression>, Arc<Expression>),
    PastFutureRange(DateRelativeKind, Arc<Expression>),
    RangeContainment(Arc<Expression>, Arc<Expression>),
    /// Whether evaluating the operand produced a veto (no value). Parses as `is veto` syntax.
    ResultIsVeto(Arc<Expression>),
    /// Unless structure: (condition, result) pairs in source order; last true condition wins.
    /// First arm is the default (condition is always-true literal).
    Piecewise(Vec<(Arc<Expression>, Arc<Expression>)>),
}

impl ExpressionKind {
    /// Collect all DataPath references from this expression kind
    pub(crate) fn collect_data_paths(&self, data: &mut std::collections::HashSet<DataPath>) {
        match self {
            ExpressionKind::DataPath(fp) => {
                data.insert(fp.clone());
            }
            ExpressionKind::LogicalAnd(left, right) | ExpressionKind::LogicalOr(left, right) => {
                left.collect_data_paths(data);
                right.collect_data_paths(data);
            }
            ExpressionKind::Arithmetic(left, _, right)
            | ExpressionKind::Comparison(left, _, right)
            | ExpressionKind::RangeLiteral(left, right)
            | ExpressionKind::RangeContainment(left, right) => {
                left.collect_data_paths(data);
                right.collect_data_paths(data);
            }
            ExpressionKind::UnitConversion(inner, _)
            | ExpressionKind::LogicalNegation(inner, _)
            | ExpressionKind::MathematicalComputation(_, inner)
            | ExpressionKind::PastFutureRange(_, inner) => {
                inner.collect_data_paths(data);
            }
            ExpressionKind::DateRelative(_, date_expr) => {
                date_expr.collect_data_paths(data);
            }
            ExpressionKind::DateCalendar(_, _, date_expr) => {
                date_expr.collect_data_paths(data);
            }
            ExpressionKind::Literal(_)
            | ExpressionKind::RulePath(_)
            | ExpressionKind::Veto(_)
            | ExpressionKind::Now => {}
            ExpressionKind::ResultIsVeto(operand) => {
                operand.collect_data_paths(data);
            }
            ExpressionKind::Piecewise(arms) => {
                for (condition, result) in arms {
                    condition.collect_data_paths(data);
                    result.collect_data_paths(data);
                }
            }
        }
    }

    /// Collect all RulePath references from this expression kind
    pub(crate) fn collect_rule_paths(&self, rules: &mut std::collections::HashSet<RulePath>) {
        match self {
            ExpressionKind::RulePath(rule_path) => {
                rules.insert(rule_path.clone());
            }
            ExpressionKind::LogicalAnd(left, right) | ExpressionKind::LogicalOr(left, right) => {
                left.collect_rule_paths(rules);
                right.collect_rule_paths(rules);
            }
            ExpressionKind::Arithmetic(left, _, right)
            | ExpressionKind::Comparison(left, _, right)
            | ExpressionKind::RangeLiteral(left, right)
            | ExpressionKind::RangeContainment(left, right) => {
                left.collect_rule_paths(rules);
                right.collect_rule_paths(rules);
            }
            ExpressionKind::UnitConversion(inner, _)
            | ExpressionKind::LogicalNegation(inner, _)
            | ExpressionKind::MathematicalComputation(_, inner)
            | ExpressionKind::PastFutureRange(_, inner) => {
                inner.collect_rule_paths(rules);
            }
            ExpressionKind::DateRelative(_, date_expr) => {
                date_expr.collect_rule_paths(rules);
            }
            ExpressionKind::DateCalendar(_, _, date_expr) => {
                date_expr.collect_rule_paths(rules);
            }
            ExpressionKind::Literal(_)
            | ExpressionKind::DataPath(_)
            | ExpressionKind::Veto(_)
            | ExpressionKind::Now => {}
            ExpressionKind::ResultIsVeto(operand) => {
                operand.collect_rule_paths(rules);
            }
            ExpressionKind::Piecewise(arms) => {
                for (condition, result) in arms {
                    condition.collect_rule_paths(rules);
                    result.collect_rule_paths(rules);
                }
            }
        }
    }
}

// -----------------------------------------------------------------------------
// Resolved types and values
// -----------------------------------------------------------------------------

/// Where the custom extension chain is rooted: same spec as this type, or imported from another resolved spec.
#[derive(Clone, Debug, Serialize, Deserialize)]
#[serde(tag = "kind", rename_all = "snake_case")]
pub enum TypeDefiningSpec {
    /// Parent type is defined in the same spec as this type.
    Local,
    /// Parent type was resolved from types loaded from this dependency.
    Import { spec: Arc<LemmaSpec> },
}

/// What this type extends (primitive built-in or custom type by name).
#[derive(Clone, Debug, Serialize, Deserialize)]
#[serde(rename_all = "snake_case")]
pub enum TypeExtends {
    /// Extends a primitive built-in type (number, boolean, text, etc.)
    Primitive,
    /// Extends a custom type: parent is the immediate parent type name; family is the root of the extension chain (topmost custom type name).
    /// `defining_spec` records whether the parent chain is local or imported from another spec.
    Custom {
        parent: String,
        family: String,
        defining_spec: TypeDefiningSpec,
    },
}

impl PartialEq for TypeExtends {
    fn eq(&self, other: &Self) -> bool {
        match (self, other) {
            (TypeExtends::Primitive, TypeExtends::Primitive) => true,
            (
                TypeExtends::Custom {
                    parent: lp,
                    family: lf,
                    defining_spec: ld,
                },
                TypeExtends::Custom {
                    parent: rp,
                    family: rf,
                    defining_spec: rd,
                },
            ) => {
                lp == rp
                    && lf == rf
                    && match (ld, rd) {
                        (TypeDefiningSpec::Local, TypeDefiningSpec::Local) => true,
                        (
                            TypeDefiningSpec::Import { spec: left },
                            TypeDefiningSpec::Import { spec: right },
                        ) => Arc::ptr_eq(left, right),
                        _ => false,
                    }
            }
            _ => false,
        }
    }
}

impl Eq for TypeExtends {}

impl std::hash::Hash for TypeDefiningSpec {
    fn hash<H: std::hash::Hasher>(&self, state: &mut H) {
        match self {
            TypeDefiningSpec::Local => {
                0u8.hash(state);
            }
            TypeDefiningSpec::Import { spec } => {
                1u8.hash(state);
                Arc::as_ptr(spec).hash(state);
            }
        }
    }
}

impl std::hash::Hash for TypeExtends {
    fn hash<H: std::hash::Hasher>(&self, state: &mut H) {
        match self {
            TypeExtends::Primitive => {
                0u8.hash(state);
            }
            TypeExtends::Custom {
                parent,
                family,
                defining_spec,
            } => {
                1u8.hash(state);
                parent.hash(state);
                family.hash(state);
                defining_spec.hash(state);
            }
        }
    }
}

impl TypeExtends {
    /// Custom extension in the same spec as the defining type (no cross-spec import for the parent chain).
    #[must_use]
    pub fn custom_local(parent: String, family: String) -> Self {
        TypeExtends::Custom {
            parent,
            family,
            defining_spec: TypeDefiningSpec::Local,
        }
    }

    /// Returns the parent type name if this type extends a custom type.
    #[must_use]
    pub fn parent_name(&self) -> Option<&str> {
        match self {
            TypeExtends::Primitive => None,
            TypeExtends::Custom { parent, .. } => Some(parent.as_str()),
        }
    }
}

/// Resolved type after planning
///
/// Contains a type specification and optional name. Created during planning
/// from TypeSpecification in the AST.
#[derive(Clone, Debug, PartialEq, Eq, Hash, Serialize, Deserialize)]
pub struct LemmaType {
    /// Optional type name (e.g., "age", "temperature")
    pub name: Option<String>,
    /// The type specification (Boolean, Number, Quantity, etc.).
    /// Serialized as a discriminated union: the variant tag appears as
    /// `"kind"` alongside `name` and `extends`, and the variant's fields
    /// are flattened to the top level.
    #[serde(flatten)]
    pub specifications: TypeSpecification,
    /// What this type extends (primitive or custom from a spec)
    pub extends: TypeExtends,
}

impl LemmaType {
    /// Functional update of the `Quantity` payload (units + decomposition).
    /// Non-Quantity variants pass through unchanged. The transform receives the owned
    /// units and decomposition and returns the replacements.
    pub fn map_quantity<F>(self, f: F) -> Self
    where
        F: FnOnce(
            QuantityUnits,
            Option<BaseQuantityVector>,
        ) -> (QuantityUnits, Option<BaseQuantityVector>),
    {
        let LemmaType {
            name,
            specifications,
            extends,
        } = self;
        let specifications = match specifications {
            TypeSpecification::Quantity {
                minimum,
                maximum,
                decimals,
                units,
                traits,
                decomposition,
                help,
            } => {
                let (units, decomposition) = f(units, decomposition);
                TypeSpecification::Quantity {
                    minimum,
                    maximum,
                    decimals,
                    units,
                    traits,
                    decomposition,
                    help,
                }
            }
            other => other,
        };
        LemmaType {
            name,
            specifications,
            extends,
        }
    }

    /// Create a new type with a name
    pub fn new(name: String, specifications: TypeSpecification, extends: TypeExtends) -> Self {
        Self {
            name: Some(name),
            specifications,
            extends,
        }
    }

    /// Create a type without a name (anonymous/inline type)
    pub fn without_name(specifications: TypeSpecification, extends: TypeExtends) -> Self {
        Self {
            name: None,
            specifications,
            extends,
        }
    }

    /// Create a primitive type (no name, extends Primitive)
    pub fn primitive(specifications: TypeSpecification) -> Self {
        Self {
            name: None,
            specifications,
            extends: TypeExtends::Primitive,
        }
    }

    /// Get the type name, or a default based on the type specification
    pub fn name(&self) -> String {
        self.name
            .clone()
            .unwrap_or_else(|| self.specifications.to_string())
    }

    /// Check if this type is boolean
    pub fn is_boolean(&self) -> bool {
        matches!(&self.specifications, TypeSpecification::Boolean { .. })
    }

    pub fn matches_primitive_kind(&self, kind: PrimitiveKind) -> bool {
        matches!(
            (kind, &self.specifications),
            (PrimitiveKind::Number, TypeSpecification::Number { .. })
                | (PrimitiveKind::Text, TypeSpecification::Text { .. })
                | (PrimitiveKind::Boolean, TypeSpecification::Boolean { .. })
                | (PrimitiveKind::Date, TypeSpecification::Date { .. })
                | (PrimitiveKind::Time, TypeSpecification::Time { .. })
                | (PrimitiveKind::Ratio, TypeSpecification::Ratio { .. })
                | (PrimitiveKind::Quantity, TypeSpecification::Quantity { .. })
        )
    }

    /// Check if this type is quantity
    pub fn is_quantity(&self) -> bool {
        matches!(&self.specifications, TypeSpecification::Quantity { .. })
    }

    pub fn is_quantity_range(&self) -> bool {
        matches!(
            &self.specifications,
            TypeSpecification::QuantityRange { .. }
        )
    }

    /// Check if this type is number (dimensionless)
    pub fn is_number(&self) -> bool {
        matches!(&self.specifications, TypeSpecification::Number { .. })
    }

    pub fn is_number_range(&self) -> bool {
        matches!(&self.specifications, TypeSpecification::NumberRange { .. })
    }

    /// Check if this type is numeric (either quantity or number)
    pub fn is_numeric(&self) -> bool {
        matches!(
            &self.specifications,
            TypeSpecification::Quantity { .. } | TypeSpecification::Number { .. }
        )
    }

    /// Check if this type is text
    pub fn is_text(&self) -> bool {
        matches!(&self.specifications, TypeSpecification::Text { .. })
    }

    /// Check if this type is date
    pub fn is_date(&self) -> bool {
        matches!(&self.specifications, TypeSpecification::Date { .. })
    }

    pub fn is_date_range(&self) -> bool {
        matches!(&self.specifications, TypeSpecification::DateRange { .. })
    }

    pub fn is_time_range(&self) -> bool {
        matches!(&self.specifications, TypeSpecification::TimeRange { .. })
    }

    /// Check if this type is time
    pub fn is_time(&self) -> bool {
        matches!(&self.specifications, TypeSpecification::Time { .. })
    }

    pub fn has_trait_duration(&self) -> bool {
        match &self.specifications {
            TypeSpecification::Quantity { traits, .. } => traits.contains(&QuantityTrait::Duration),
            _ => false,
        }
    }

    pub fn is_duration_like_quantity(&self) -> bool {
        if !self.is_quantity() {
            return false;
        }
        if self.has_trait_duration() {
            return true;
        }
        self.is_anonymous_quantity()
            && self
                .quantity_type_decomposition()
                .is_some_and(|d| *d == duration_decomposition())
    }

    pub fn is_duration_like(&self) -> bool {
        self.is_duration_like_quantity()
    }

    pub fn has_trait_calendar(&self) -> bool {
        match &self.specifications {
            TypeSpecification::Quantity { traits, .. } => traits.contains(&QuantityTrait::Calendar),
            _ => false,
        }
    }

    pub fn is_calendar_like_quantity(&self) -> bool {
        if !self.is_quantity() {
            return false;
        }
        if self.has_trait_calendar() {
            return true;
        }
        self.is_anonymous_quantity()
            && self
                .quantity_type_decomposition()
                .is_some_and(|d| *d == calendar_decomposition())
    }

    pub fn is_calendar_like(&self) -> bool {
        self.is_calendar_like_quantity()
    }

    /// Check if this type is ratio
    pub fn is_ratio(&self) -> bool {
        matches!(&self.specifications, TypeSpecification::Ratio { .. })
    }

    pub fn is_ratio_range(&self) -> bool {
        matches!(&self.specifications, TypeSpecification::RatioRange { .. })
    }

    pub fn is_calendar_quantity_range(&self) -> bool {
        matches!(
            &self.specifications,
            TypeSpecification::QuantityRange { decomposition: Some(decomposition), .. }
                if *decomposition == calendar_decomposition()
        )
    }

    pub fn is_calendar_like_range(&self) -> bool {
        self.is_calendar_quantity_range()
    }

    pub fn is_range(&self) -> bool {
        matches!(
            &self.specifications,
            TypeSpecification::DateRange { .. }
                | TypeSpecification::TimeRange { .. }
                | TypeSpecification::NumberRange { .. }
                | TypeSpecification::QuantityRange { .. }
                | TypeSpecification::RatioRange { .. }
        )
    }

    /// Check if this type is veto
    pub fn vetoed(&self) -> bool {
        matches!(&self.specifications, TypeSpecification::Veto { .. })
    }

    /// True if this type is the undetermined sentinel (type could not be inferred).
    pub fn is_undetermined(&self) -> bool {
        matches!(&self.specifications, TypeSpecification::Undetermined)
    }

    /// Check if two types have the same base type specification (ignoring constraints)
    pub fn has_same_base_type(&self, other: &LemmaType) -> bool {
        use TypeSpecification::*;
        matches!(
            (&self.specifications, &other.specifications),
            (Boolean { .. }, Boolean { .. })
                | (Number { .. }, Number { .. })
                | (NumberRange { .. }, NumberRange { .. })
                | (Quantity { .. }, Quantity { .. })
                | (QuantityRange { .. }, QuantityRange { .. })
                | (Text { .. }, Text { .. })
                | (Date { .. }, Date { .. })
                | (DateRange { .. }, DateRange { .. })
                | (Time { .. }, Time { .. })
                | (TimeRange { .. }, TimeRange { .. })
                | (Ratio { .. }, Ratio { .. })
                | (RatioRange { .. }, RatioRange { .. })
                | (Veto { .. }, Veto { .. })
                | (Undetermined, Undetermined)
        )
    }

    /// For quantity types, returns the family name (root of the extension chain). For Custom extends, returns the family field; for Primitive, returns the type's own name (the type is the root). For non-quantity types, returns None.
    #[must_use]
    pub fn quantity_family_name(&self) -> Option<&str> {
        if !self.is_quantity() {
            return None;
        }
        match &self.extends {
            TypeExtends::Custom { family, .. } => Some(family.as_str()),
            TypeExtends::Primitive => self.name.as_deref(),
        }
    }

    /// Returns true if both types are quantity and belong to the same named quantity family.
    #[must_use]
    pub fn same_quantity_family(&self, other: &LemmaType) -> bool {
        if !self.is_quantity() || !other.is_quantity() {
            return false;
        }
        match (self.quantity_family_name(), other.quantity_family_name()) {
            (Some(self_family), Some(other_family)) => self_family == other_family,
            _ => false,
        }
    }

    #[must_use]
    pub fn compatible_with_anonymous_quantity(&self, other: &LemmaType) -> bool {
        if !self.is_quantity() || !other.is_quantity() {
            return false;
        }
        if !self.is_anonymous_quantity() && !other.is_anonymous_quantity() {
            return false;
        }
        match (
            self.quantity_type_decomposition(),
            other.quantity_type_decomposition(),
        ) {
            (Some(a), Some(b)) => a == b,
            _ => false,
        }
    }

    /// Create a Veto LemmaType
    pub fn veto_type() -> Self {
        Self::primitive(TypeSpecification::veto())
    }

    /// LemmaType sentinel for undetermined type (used during inference when a type cannot be determined).
    /// Propagates through expressions and is never present in a validated graph.
    pub fn undetermined_type() -> Self {
        Self::primitive(TypeSpecification::Undetermined)
    }

    /// Decimal places for display (Number, Quantity, and Ratio). Used by formatters.
    /// Ratio: optional, no default; when None display is normalized (no trailing zeros).
    pub fn decimal_places(&self) -> Option<u8> {
        match &self.specifications {
            TypeSpecification::Number { decimals, .. } => *decimals,
            TypeSpecification::Quantity { decimals, .. } => *decimals,
            TypeSpecification::Ratio { decimals, .. } => *decimals,
            _ => None,
        }
    }

    /// Commit a rational magnitude to a decimal string for API materialization.
    ///
    /// Applies this type's `decimal_places` when set. Returns [`NumericFailure`] when the
    /// magnitude cannot commit to `rust_decimal` (callers map this to a decimal-limit Veto).
    pub fn try_materialize_rational_as_decimal_string(
        &self,
        magnitude: &crate::computation::rational::RationalInteger,
    ) -> Result<String, crate::computation::rational::NumericFailure> {
        use crate::computation::rational::commit_rational_to_decimal;
        let decimal = commit_rational_to_decimal(magnitude)?;
        Ok(format_committed_decimal_for_api(
            decimal,
            self.decimal_places(),
        ))
    }

    /// Commit a canonical quantity magnitude in the named declared unit for API materialization.
    pub fn try_materialize_quantity_canonical_in_unit(
        &self,
        canonical_magnitude: &crate::computation::rational::RationalInteger,
        unit_name: &str,
    ) -> Result<String, crate::computation::rational::NumericFailure> {
        use crate::computation::rational::checked_div;
        let unit_factor = self.quantity_unit_factor(unit_name);
        let magnitude_in_unit = checked_div(canonical_magnitude, unit_factor)?;
        self.try_materialize_rational_as_decimal_string(&magnitude_in_unit)
    }

    /// Commit a canonical ratio magnitude in the named declared unit for API materialization.
    pub fn try_materialize_ratio_canonical_in_unit(
        &self,
        canonical_magnitude: &crate::computation::rational::RationalInteger,
        unit_name: &str,
    ) -> Result<String, crate::computation::rational::NumericFailure> {
        use crate::computation::rational::checked_mul;
        let units = match &self.specifications {
            TypeSpecification::Ratio { units, .. } => units,
            _ => unreachable!(
                "BUG: try_materialize_ratio_canonical_in_unit called on non-ratio type {}",
                self.name()
            ),
        };
        let ratio_unit = units
            .iter()
            .find(|unit| unit.name == unit_name)
            .unwrap_or_else(|| {
                let valid: Vec<&str> = units.iter().map(|unit| unit.name.as_str()).collect();
                unreachable!(
                    "BUG: unknown ratio unit '{}' for type {} (valid: {}); planning must reject invalid units",
                    unit_name,
                    self.name(),
                    valid.join(", ")
                )
            });
        let magnitude_in_unit = checked_mul(canonical_magnitude, &ratio_unit.value)?;
        self.try_materialize_rational_as_decimal_string(&magnitude_in_unit)
    }

    /// Get an example value string for this type, suitable for UI help text
    pub fn example_value(&self) -> &'static str {
        match &self.specifications {
            TypeSpecification::Text { .. } => "\"hello world\"",
            TypeSpecification::Quantity { .. } => "12.50 eur",
            TypeSpecification::QuantityRange { .. } => "30 kilogram...35 kilogram",
            TypeSpecification::Number { .. } => "3.14",
            TypeSpecification::NumberRange { .. } => "0...100",
            TypeSpecification::Boolean { .. } => "true",
            TypeSpecification::Date { .. } => "2023-12-25T14:30:00Z",
            TypeSpecification::DateRange { .. } => "2024-01-01...2024-12-31",
            TypeSpecification::TimeRange { .. } => "09:00...17:00",
            TypeSpecification::Veto { .. } => "veto",
            TypeSpecification::Time { .. } => "14:30:00",
            TypeSpecification::Ratio { .. } => "50%",
            TypeSpecification::RatioRange { .. } => "10%...50%",
            TypeSpecification::Undetermined => unreachable!(
                "BUG: example_value called on Undetermined sentinel type; this type must never reach user-facing code"
            ),
        }
    }

    /// Factor for a unit of this quantity type (for unit conversion during evaluation only).
    /// Planning must validate conversions first and return Error for invalid units.
    /// If called with a non-quantity type or unknown unit name, panics (invariant violation).
    #[must_use]
    /// Returns the resolved `BaseQuantityVector` for Quantity types, or `None` if
    /// the decomposition pass has not yet resolved this type.
    /// Panics if called on non-Quantity types.
    pub fn quantity_type_decomposition(&self) -> Option<&BaseQuantityVector> {
        match &self.specifications {
            TypeSpecification::Quantity { decomposition, .. } => decomposition.as_ref(),
            _ => unreachable!(
                "BUG: quantity_type_decomposition called on non-quantity type {}",
                self.name()
            ),
        }
    }

    /// Returns true if this is an anonymous (no-name) Quantity — i.e. an anonymous
    /// intermediate produced by cross-axis arithmetic.
    pub fn is_anonymous_quantity(&self) -> bool {
        self.name.is_none() && matches!(&self.specifications, TypeSpecification::Quantity { .. })
    }

    /// Build an anonymous `LemmaType` for a given dimensional decomposition.
    /// Used at plan time to represent the inferred type of cross-axis intermediates.
    /// Signatures live on the value, not on the type.
    pub fn anonymous_for_decomposition(decomposition: BaseQuantityVector) -> Self {
        Self {
            name: None,
            specifications: TypeSpecification::Quantity {
                minimum: None,
                maximum: None,
                decimals: None,
                units: crate::literals::QuantityUnits::new(),
                traits: Vec::new(),
                decomposition: Some(decomposition),
                help: String::new(),
            },
            extends: TypeExtends::Primitive,
        }
    }

    /// Declared unit names when the type carries a non-empty unit table (`None` otherwise).
    #[must_use]
    pub fn quantity_unit_names(&self) -> Option<Vec<&str>> {
        match &self.specifications {
            TypeSpecification::Quantity { units, .. } if !units.is_empty() => {
                Some(units.iter().map(|unit| unit.name.as_str()).collect())
            }
            TypeSpecification::QuantityRange { units, .. } if !units.is_empty() => {
                Some(units.iter().map(|unit| unit.name.as_str()).collect())
            }
            _ => None,
        }
    }

    /// Return the conversion factor for a declared unit name on this quantity type.
    pub fn quantity_unit_factor(
        &self,
        unit_name: &str,
    ) -> &crate::computation::rational::RationalInteger {
        let units = match &self.specifications {
            TypeSpecification::Quantity { units, .. } => units,
            TypeSpecification::QuantityRange { units, .. } => units,
            _ => unreachable!(
                "BUG: quantity_unit_factor called with non-quantity type {}; only call during evaluation after planning validated quantity conversion",
                self.name()
            ),
        };
        match units.get(unit_name) {
            Ok(QuantityUnit { factor, .. }) => factor,
            Err(_) => {
                let valid: Vec<&str> = units.iter().map(|u| u.name.as_str()).collect();
                unreachable!(
                    "BUG: unknown unit '{}' for quantity type {} (valid: {}); planning must reject invalid conversions with Error",
                    unit_name,
                    self.name(),
                    valid.join(", ")
                );
            }
        }
    }

    pub fn ratio_unit_factor(
        &self,
        unit_name: &str,
    ) -> &crate::computation::rational::RationalInteger {
        let units = match &self.specifications {
            TypeSpecification::Ratio { units, .. } => units,
            _ => unreachable!(
                "BUG: ratio_unit_factor called with non-ratio type {}; only call during evaluation after planning validated ratio conversion",
                self.name()
            ),
        };
        match units.get(unit_name) {
            Ok(RatioUnit { value, .. }) => value,
            Err(_) => {
                let valid: Vec<&str> = units.0.iter().map(|u| u.name.as_str()).collect();
                unreachable!(
                    "BUG: unknown unit '{}' for ratio type {} (valid: {}); planning must reject invalid conversions with Error",
                    unit_name,
                    self.name(),
                    valid.join(", ")
                );
            }
        }
    }
}

/// Literal value with type. The single value type in semantics.
#[derive(Clone, Debug, PartialEq, Eq, Hash)]
pub struct LiteralValue {
    pub value: ValueKind,
    pub lemma_type: Arc<LemmaType>,
}

impl Serialize for LiteralValue {
    fn serialize<S>(&self, serializer: S) -> Result<S::Ok, S::Error>
    where
        S: serde::Serializer,
    {
        use serde::ser::SerializeStruct;
        let mut state = serializer.serialize_struct("LiteralValue", 3)?;
        state.serialize_field("value", &self.value)?;
        state.serialize_field("lemma_type", self.lemma_type.as_ref())?;
        state.serialize_field("display_value", &self.display_value())?;
        state.end()
    }
}

impl<'de> Deserialize<'de> for LiteralValue {
    fn deserialize<D>(deserializer: D) -> Result<Self, D::Error>
    where
        D: serde::Deserializer<'de>,
    {
        #[derive(Deserialize)]
        struct Raw {
            value: ValueKind,
            lemma_type: LemmaType,
        }
        let raw = Raw::deserialize(deserializer)?;
        Ok(Self {
            value: raw.value,
            lemma_type: Arc::new(raw.lemma_type),
        })
    }
}

impl LiteralValue {
    pub fn text(s: String) -> Self {
        Self {
            value: ValueKind::Text(s),
            lemma_type: primitive_text_arc().clone(),
        }
    }

    pub fn text_with_type(s: String, lemma_type: Arc<LemmaType>) -> Self {
        Self {
            value: ValueKind::Text(s),
            lemma_type,
        }
    }

    pub fn number(n: RationalInteger) -> Self {
        Self {
            value: ValueKind::Number(n),
            lemma_type: primitive_number_arc().clone(),
        }
    }

    pub fn number_from_decimal(decimal: Decimal) -> Self {
        Self::number(
            crate::literals::rational_from_parsed_decimal(decimal)
                .expect("BUG: literal number from decimal must lift at boundary"),
        )
    }

    pub fn number_with_type(n: RationalInteger, lemma_type: Arc<LemmaType>) -> Self {
        Self {
            value: ValueKind::Number(n),
            lemma_type,
        }
    }

    pub fn number_with_type_from_decimal(decimal: Decimal, lemma_type: Arc<LemmaType>) -> Self {
        Self::number_with_type(
            crate::literals::rational_from_parsed_decimal(decimal)
                .expect("BUG: literal number from decimal must lift at boundary"),
            lemma_type,
        )
    }

    /// Build a Quantity literal carrying a single user-typed unit name.
    /// The signature is `[(unit_name, 1)]`; the normalize pass expands compound names
    /// against `unit_index` so all stored signatures end up in canonical (base-unit) form.
    pub fn quantity_with_type(
        n: RationalInteger,
        unit: String,
        lemma_type: Arc<LemmaType>,
    ) -> Self {
        Self {
            value: ValueKind::Quantity(n, vec![(unit, 1)]),
            lemma_type,
        }
    }

    /// Build a Quantity literal with an explicit signature (already in canonical form).
    /// Used by arithmetic when combining operand signatures yields a multi-term result.
    pub fn quantity_with_signature(
        n: RationalInteger,
        signature: Vec<(String, i32)>,
        lemma_type: Arc<LemmaType>,
    ) -> Self {
        Self {
            value: ValueKind::Quantity(n, signature),
            lemma_type,
        }
    }

    /// Number interpreted as a quantity value in the given unit (e.g. "3 as usd" where 3 is a number).
    /// Creates an anonymous one-unit quantity type so computation does not depend on parsing types.
    pub fn number_interpreted_as_quantity(value: RationalInteger, unit_name: String) -> Self {
        Self {
            value: ValueKind::Quantity(value, vec![(unit_name, 1)]),
            lemma_type: Arc::new(anonymous_quantity_type()),
        }
    }

    pub fn from_bool(b: bool) -> Self {
        Self {
            value: ValueKind::Boolean(b),
            lemma_type: primitive_boolean_arc().clone(),
        }
    }

    pub fn from_datetime(dt: &crate::parsing::ast::DateTimeValue) -> Self {
        Self::date(date_time_to_semantic(dt))
    }

    /// Magnitude string for decimal input prompts (number, single-unit quantity, ratio with percent/permille scaling).
    #[must_use]
    pub fn magnitude_default_for_decimal_prompt(&self) -> Option<String> {
        use crate::computation::rational::{checked_mul, rational_to_display_str};
        match &self.value {
            ValueKind::Number(n) => Some(rational_to_display_str(n)),
            ValueKind::Quantity(n, signature) if signature.len() == 1 && signature[0].1 == 1 => {
                Some(rational_to_display_str(n))
            }
            ValueKind::Ratio(n, Some(unit)) if unit == "percent" => {
                checked_mul(n, &rational_new(100, 1))
                    .ok()
                    .map(|scaled| rational_to_display_str(&scaled))
            }
            ValueKind::Ratio(n, Some(unit)) if unit == "permille" => {
                checked_mul(n, &rational_new(1000, 1))
                    .ok()
                    .map(|scaled| rational_to_display_str(&scaled))
            }
            ValueKind::Ratio(n, _) => Some(rational_to_display_str(n)),
            _ => None,
        }
    }

    pub fn date(dt: SemanticDateTime) -> Self {
        Self {
            value: ValueKind::Date(dt),
            lemma_type: primitive_date_arc().clone(),
        }
    }

    pub fn date_with_type(dt: SemanticDateTime, lemma_type: Arc<LemmaType>) -> Self {
        Self {
            value: ValueKind::Date(dt),
            lemma_type,
        }
    }

    pub fn time(t: SemanticTime) -> Self {
        Self {
            value: ValueKind::Time(t),
            lemma_type: primitive_time_arc().clone(),
        }
    }

    pub fn time_with_type(t: SemanticTime, lemma_type: Arc<LemmaType>) -> Self {
        Self {
            value: ValueKind::Time(t),
            lemma_type,
        }
    }

    pub fn calendar(
        value: RationalInteger,
        unit: SemanticCalendarUnit,
        lemma_type: Arc<LemmaType>,
    ) -> Self {
        Self::quantity_with_type(value, unit.to_string(), lemma_type)
    }

    pub fn calendar_from_decimal(
        value: Decimal,
        unit: SemanticCalendarUnit,
        lemma_type: Arc<LemmaType>,
    ) -> Self {
        Self::calendar(
            crate::literals::rational_from_parsed_decimal(value)
                .expect("BUG: calendar literal from decimal must lift at boundary"),
            unit,
            lemma_type,
        )
    }

    pub fn calendar_with_type(
        value: RationalInteger,
        unit: SemanticCalendarUnit,
        lemma_type: Arc<LemmaType>,
    ) -> Self {
        Self::calendar(value, unit, lemma_type)
    }

    /// Derive seconds from a duration quantity's canonical magnitude.
    pub fn duration_canonical_seconds(&self) -> RationalInteger {
        let ValueKind::Quantity(magnitude, _) = &self.value else {
            unreachable!(
                "BUG: duration_canonical_seconds called with {:?}",
                self.value
            );
        };
        if !self.lemma_type.is_duration_like_quantity() {
            unreachable!(
                "BUG: duration_canonical_seconds called with type {}",
                self.lemma_type.name()
            );
        }
        let factor = self.lemma_type.quantity_unit_factor("second");
        checked_div(magnitude, factor).expect("BUG: duration unit factor cannot be zero")
    }

    /// Derive months from a calendar quantity's canonical magnitude.
    pub fn calendar_canonical_months(&self) -> RationalInteger {
        let ValueKind::Quantity(magnitude, _) = &self.value else {
            unreachable!(
                "BUG: calendar_canonical_months called with {:?}",
                self.value
            );
        };
        if !self.lemma_type.is_calendar_like() {
            unreachable!(
                "BUG: calendar_canonical_months called with type {}",
                self.lemma_type.name()
            );
        }
        let factor = self.lemma_type.quantity_unit_factor("month");
        checked_div(magnitude, factor).expect("BUG: calendar unit factor cannot be zero")
    }

    pub fn ratio(r: RationalInteger, unit: Option<String>) -> Self {
        Self {
            value: ValueKind::Ratio(r, unit),
            lemma_type: primitive_ratio_arc().clone(),
        }
    }

    pub fn ratio_from_decimal(r: Decimal, unit: Option<String>) -> Self {
        Self::ratio(
            crate::literals::rational_from_parsed_decimal(r)
                .expect("BUG: ratio literal from decimal must lift at boundary"),
            unit,
        )
    }

    pub fn ratio_with_type(
        r: RationalInteger,
        unit: Option<String>,
        lemma_type: Arc<LemmaType>,
    ) -> Self {
        Self {
            value: ValueKind::Ratio(r, unit),
            lemma_type,
        }
    }

    pub fn range(left: LiteralValue, right: LiteralValue) -> Self {
        let specifications =
            range_type_specification_from_endpoints(&left.lemma_type, &right.lemma_type)
                .unwrap_or_else(|| {
                    unreachable!(
                "BUG: attempted to construct a range literal from incompatible endpoint types"
            )
                });

        Self {
            value: ValueKind::Range(Box::new(left), Box::new(right)),
            lemma_type: Arc::new(LemmaType::primitive(specifications)),
        }
    }

    /// Get a display string for this value (for UI/output)
    pub fn display_value(&self) -> String {
        format!("{}", self)
    }

    /// Approximate byte size for resource limit checks (string representation length)
    pub fn byte_size(&self) -> usize {
        format!("{}", self).len()
    }

    /// Get the resolved type of this literal
    pub fn get_type(&self) -> &LemmaType {
        &self.lemma_type
    }
}

/// Response/UI row for spec data: [`LemmaType`] plus optional bound literal (mirrors parse-time `Definition`).
#[derive(Clone, Debug, PartialEq, Eq, Serialize, Deserialize)]
#[serde(rename_all = "snake_case")]
pub enum DataValue {
    Definition {
        schema_type: LemmaType,
        #[serde(default, skip_serializing_if = "Option::is_none")]
        bound_value: Option<LiteralValue>,
    },
}

impl DataValue {
    #[must_use]
    pub fn from_bound_literal(value: LiteralValue) -> Self {
        let schema_type = value.get_type().clone();
        Self::Definition {
            schema_type,
            bound_value: Some(value),
        }
    }
}

/// Data: path, value, and source location.
#[derive(Clone, Debug, PartialEq, Eq, Serialize, Deserialize)]
pub struct Data {
    pub path: DataPath,
    pub value: DataValue,
    pub source: Option<Source>,
}

/// What a [`DataDefinition::Reference`] copies its value from: either another data path
/// or a rule whose result becomes this data's value.
#[derive(Clone, Debug, PartialEq, Eq, Serialize, Deserialize)]
#[serde(rename_all = "snake_case", tag = "kind")]
pub enum ReferenceTarget {
    Data(DataPath),
    Rule(RulePath),
}

/// Resolved data value for the execution plan: aligned with [`DataValue`] but with source per variant.
#[derive(Clone, Debug, Serialize, Deserialize)]
#[serde(rename_all = "snake_case")]
pub enum DataDefinition {
    /// Value-holding data: current value (literal or default); type is on the value.
    Value { value: LiteralValue, source: Source },
    /// Type-only data: schema known, value to be supplied (e.g. via with_values).
    /// `declared_default` carries the `-> default ...` payload for this binding or
    /// the default inherited from the parent type chain, if any; value-promoting code
    /// uses it instead of re-deriving defaults from [`TypeSpecification`].
    TypeDeclaration {
        resolved_type: Arc<LemmaType>,
        declared_default: Option<ValueKind>,
        source: Source,
    },
    /// Import (`uses`): resolved target lemma for this alias.
    Import {
        spec: Arc<crate::parsing::ast::LemmaSpec>,
        source: Source,
    },
    /// Value-copy reference to another data or a rule result.
    ///
    /// `resolved_type` is the merged type that the copied value must satisfy at
    /// evaluation time. Merging folds together: (1) the LHS's own declared type,
    /// if any; (2) the target's type (data schema type or rule return type);
    /// (3) any `local_constraints` written after the `->` on the reference itself.
    /// Merging happens in a dedicated pass once all data and rule types are
    /// known; before that pass, `resolved_type` holds a provisional value and
    /// must not be consumed for type checking.
    ///
    /// `local_constraints` preserves the raw constraint list from the reference's
    /// `-> ...` tail (e.g. `minimum 5` in `data license2: law.other -> minimum 5`)
    /// for that merging pass. It is `None` when the reference has no trailing
    /// constraints.
    ///
    /// `local_default` carries any `default <value>` constraint from the
    /// reference's `-> ...` tail. The reference-merge pass extracts it from the
    /// constraint list during type resolution. It is materialized into a
    /// concrete value by the evaluator when the caller does not supply a value.
    ///
    /// The reference itself is evaluated by copying the target's value (data path)
    /// or the target rule's result in topological order; caller values in
    /// [`crate::planning::execution_plan::DataOverlay`] override the reference.
    Reference {
        target: ReferenceTarget,
        resolved_type: Arc<LemmaType>,
        local_constraints: Option<Vec<Constraint>>,
        local_default: Option<ValueKind>,
        source: Source,
    },
}

impl DataDefinition {
    /// Schema type for value, type-declaration, and reference data; `None` for imports.
    pub fn schema_type(&self) -> Option<&LemmaType> {
        match self {
            DataDefinition::Value { value, .. } => Some(value.lemma_type.as_ref()),
            DataDefinition::TypeDeclaration { resolved_type, .. } => Some(resolved_type.as_ref()),
            DataDefinition::Reference { resolved_type, .. } => Some(resolved_type.as_ref()),
            DataDefinition::Import { .. } => None,
        }
    }

    /// Returns the literal value when the data already holds one. A `Reference`'s
    /// value is produced by the evaluator at runtime, so at plan-time it has no
    /// value yet.
    pub fn value(&self) -> Option<&LiteralValue> {
        match self {
            DataDefinition::Value { value, .. } => Some(value),
            DataDefinition::TypeDeclaration { .. }
            | DataDefinition::Import { .. }
            | DataDefinition::Reference { .. } => None,
        }
    }

    /// Literal explicitly bound in the spec (`data x: literal`) or supplied
    /// by the caller via [`crate::planning::execution_plan::DataOverlay`].
    /// Not a suggestion; see [`Self::default_suggestion`].
    #[inline]
    pub fn bound_value(&self) -> Option<&LiteralValue> {
        self.value()
    }

    /// Suggestion from `-> default ...` on a type declaration or reference.
    /// Surfaces in [`crate::planning::execution_plan::DataEntry::default`] for
    /// prefill/UI; the evaluator applies it when the caller does not supply a value.
    pub fn default_suggestion(&self) -> Option<LiteralValue> {
        match self {
            DataDefinition::TypeDeclaration {
                resolved_type,
                declared_default: Some(dv),
                ..
            } => Some(LiteralValue {
                value: dv.clone(),
                lemma_type: Arc::clone(resolved_type),
            }),
            DataDefinition::Reference {
                resolved_type,
                local_default: Some(dv),
                ..
            } => Some(LiteralValue {
                value: dv.clone(),
                lemma_type: Arc::clone(resolved_type),
            }),
            DataDefinition::Value { .. }
            | DataDefinition::TypeDeclaration {
                declared_default: None,
                ..
            }
            | DataDefinition::Reference {
                local_default: None,
                ..
            }
            | DataDefinition::Import { .. } => None,
        }
    }

    /// Returns the source location for this data.
    pub fn source(&self) -> &Source {
        match self {
            DataDefinition::Value { source, .. } => source,
            DataDefinition::TypeDeclaration { source, .. } => source,
            DataDefinition::Import { source, .. } => source,
            DataDefinition::Reference { source, .. } => source,
        }
    }

    /// Returns the reference target when this data copies a value from another
    /// data path or rule result; `None` otherwise.
    pub fn reference_target(&self) -> Option<&ReferenceTarget> {
        match self {
            DataDefinition::Reference { target, .. } => Some(target),
            _ => None,
        }
    }
}

/// Bind a type-agnostic [`Value::NumberWithUnit`] using the unit index entry for `unit_name`.
pub fn number_with_unit_to_value_kind(
    magnitude: rust_decimal::Decimal,
    unit_name: &str,
    lemma_type: &LemmaType,
) -> Result<ValueKind, String> {
    match &lemma_type.specifications {
        TypeSpecification::Ratio { units, .. } => {
            use crate::computation::rational::{checked_div, decimal_to_rational};
            let unit = units.get(unit_name)?;
            let magnitude_rational = decimal_to_rational(magnitude)
                .map_err(|failure| format!("ratio literal failed rational lift: {failure}"))?;
            let canonical_rational = checked_div(&magnitude_rational, &unit.value)
                .map_err(|failure| format!("ratio literal: unit conversion failed: {failure}"))?;
            Ok(ValueKind::Ratio(
                canonical_rational,
                Some(unit.name.clone()),
            ))
        }
        TypeSpecification::Quantity { units, .. } => {
            use crate::computation::rational::checked_mul;
            let rational = lift_parser_decimal(magnitude)?;
            let unit = units.get(unit_name)?;
            let canonical = checked_mul(&rational, &unit.factor)
                .map_err(|failure| format!("quantity canonicalization overflow: {failure}"))?;
            Ok(ValueKind::Quantity(
                canonical,
                vec![(unit_name.to_string(), 1)],
            ))
        }
        _ => Err(format!(
            "Unit '{}' is defined on type '{}' which is not quantity or ratio",
            unit_name,
            lemma_type.name()
        )),
    }
}

/// Whether a [`ValueKind`] is structurally compatible with a [`TypeSpecification`].
/// Bound validation (min/max/decimals) is separate; this only checks shape.
pub(crate) fn value_kind_matches_spec(value: &ValueKind, type_spec: &TypeSpecification) -> bool {
    matches!(
        (type_spec, value),
        (TypeSpecification::Number { .. }, ValueKind::Number(_))
            | (TypeSpecification::Text { .. }, ValueKind::Text(_))
            | (TypeSpecification::Boolean { .. }, ValueKind::Boolean(_))
            | (TypeSpecification::Date { .. }, ValueKind::Date(_))
            | (TypeSpecification::Time { .. }, ValueKind::Time(_))
            | (
                TypeSpecification::Quantity { .. },
                ValueKind::Quantity(_, _)
            )
            | (TypeSpecification::Ratio { .. }, ValueKind::Ratio(_, _))
            | (TypeSpecification::Ratio { .. }, ValueKind::Number(_))
            | (
                TypeSpecification::NumberRange { .. },
                ValueKind::Range(_, _)
            )
            | (TypeSpecification::DateRange { .. }, ValueKind::Range(_, _))
            | (TypeSpecification::TimeRange { .. }, ValueKind::Range(_, _))
            | (TypeSpecification::RatioRange { .. }, ValueKind::Range(_, _))
            | (
                TypeSpecification::QuantityRange { .. },
                ValueKind::Range(_, _)
            )
            | (TypeSpecification::Veto { .. }, _)
            | (TypeSpecification::Undetermined, _)
    )
}

fn value_kind_tag_for_type(spec: &TypeSpecification) -> &'static str {
    match spec {
        TypeSpecification::Boolean { .. } => "boolean",
        TypeSpecification::Quantity { .. } => "quantity",
        TypeSpecification::Number { .. } => "number",
        TypeSpecification::NumberRange { .. }
        | TypeSpecification::QuantityRange { .. }
        | TypeSpecification::DateRange { .. }
        | TypeSpecification::TimeRange { .. }
        | TypeSpecification::RatioRange { .. } => "range",
        TypeSpecification::Ratio { .. } => "ratio",
        TypeSpecification::Text { .. } => "text",
        TypeSpecification::Date { .. } => "date",
        TypeSpecification::Time { .. } => "time",
        TypeSpecification::Veto { .. } => "veto",
        TypeSpecification::Undetermined => "undetermined",
    }
}

fn parser_value_type_mismatch(
    value: &crate::literals::Value,
    type_spec: &TypeSpecification,
) -> String {
    use crate::parsing::ast::AsLemmaSource;
    let value_str = format!("{}", AsLemmaSource(value));
    let expected = value_kind_tag_for_type(type_spec);
    match type_spec {
        TypeSpecification::Quantity { units, .. } => {
            let unit_hint = units
                .iter()
                .find(|u| u.factor == crate::computation::rational::rational_one())
                .map(|u| u.name.as_str())
                .or_else(|| units.iter().next().map(|u| u.name.as_str()))
                .unwrap_or("unit");
            format!("cannot use {value_str} as {expected}: expected `<n> {unit_hint}`")
        }
        TypeSpecification::Ratio { units, .. } if !units.is_empty() => {
            let unit_hint = units
                .iter()
                .next()
                .map(|u| u.name.as_str())
                .unwrap_or("unit");
            format!(
                "cannot use {value_str} as {expected}: expected `<n> {unit_hint}` or bare ratio"
            )
        }
        _ => format!("cannot use {value_str} as {expected}"),
    }
}

/// Re-canonicalize a quantity literal after compound unit factors were resolved.
///
/// Literals parsed before derived unit resolution were canonicalized with prefix-only
/// factors; multiply by `resolved_factor / stored_factor` to align with final factors.
pub fn refresh_quantity_literal_canonical_magnitude(
    lit: &mut LiteralValue,
    resolved_type: &LemmaType,
) {
    let ValueKind::Quantity(magnitude, signature) = &mut lit.value else {
        return;
    };
    let (unit_name, exponent) = signature
        .first()
        .expect("BUG: quantity literal has empty signature during canonical magnitude refresh");
    if *exponent != 1 || signature.len() != 1 {
        return;
    }
    let stored_factor = lit.lemma_type.quantity_unit_factor(unit_name);
    let resolved_factor = resolved_type.quantity_unit_factor(unit_name);
    if stored_factor == resolved_factor {
        lit.lemma_type = Arc::new(resolved_type.clone());
        return;
    }
    let scaled = checked_mul(magnitude, resolved_factor)
        .expect("BUG: quantity recanonicalization multiply overflow");
    *magnitude = checked_div(&scaled, stored_factor)
        .expect("BUG: quantity recanonicalization divide failed");
    lit.lemma_type = Arc::new(resolved_type.clone());
}

/// Convert parser [`Value`] to [`ValueKind`] using the target type (canonicalizes ratio at bind).
pub fn parser_value_to_value_kind(
    value: &crate::literals::Value,
    type_spec: &TypeSpecification,
) -> Result<ValueKind, String> {
    use crate::computation::rational::decimal_to_rational;
    use crate::literals::Value;
    match (value, type_spec) {
        (Value::NumberWithUnit(magnitude, unit_name), TypeSpecification::Ratio { units, .. }) => {
            use crate::computation::rational::checked_div;
            let unit = units.get(unit_name.as_str())?;
            let magnitude_rational = decimal_to_rational(*magnitude)
                .map_err(|failure| format!("ratio literal failed rational lift: {failure}"))?;
            let canonical_rational = checked_div(&magnitude_rational, &unit.value)
                .map_err(|failure| format!("ratio literal: unit conversion failed: {failure}"))?;
            Ok(ValueKind::Ratio(
                canonical_rational,
                Some(unit.name.clone()),
            ))
        }
        (
            Value::NumberWithUnit(magnitude, unit_name),
            TypeSpecification::Quantity { units, .. },
        ) => {
            use crate::computation::rational::checked_mul;
            let rational = lift_parser_decimal(*magnitude)?;
            let unit = units.get(unit_name.as_str())?;
            let canonical = checked_mul(&rational, &unit.factor)
                .map_err(|failure| format!("quantity canonicalization overflow: {failure}"))?;
            Ok(ValueKind::Quantity(canonical, vec![(unit_name.clone(), 1)]))
        }
        (Value::NumberWithUnit(_, _), _) => {
            Err("number_with_unit literal requires a quantity or ratio type".to_string())
        }
        (Value::Number(n), TypeSpecification::Number { .. }) => {
            Ok(ValueKind::Number(lift_parser_decimal(*n)?))
        }
        (Value::Number(n), TypeSpecification::Ratio { .. }) => {
            let r = decimal_to_rational(*n)
                .map_err(|failure| format!("ratio literal failed rational lift: {failure}"))?;
            Ok(ValueKind::Ratio(r, None))
        }
        (Value::Text(s), TypeSpecification::Text { .. }) => Ok(ValueKind::Text(s.clone())),
        (Value::Boolean(b), TypeSpecification::Boolean { .. }) => Ok(ValueKind::Boolean(b.into())),
        (Value::Date(dt), TypeSpecification::Date { .. }) => {
            Ok(ValueKind::Date(date_time_to_semantic(dt)))
        }
        (Value::Time(t), TypeSpecification::Time { .. }) => {
            Ok(ValueKind::Time(time_to_semantic(t)))
        }
        (
            Value::Range(left, right),
            range_spec @ (TypeSpecification::NumberRange { .. }
            | TypeSpecification::DateRange { .. }
            | TypeSpecification::TimeRange { .. }
            | TypeSpecification::RatioRange { .. }
            | TypeSpecification::QuantityRange { .. }),
        ) => {
            let endpoint = range_element_type_specification(range_spec).ok_or_else(|| {
                "BUG: range_element_type_specification missing arm for range type".to_string()
            })?;
            let left_lit = lift_range_endpoint(left, &endpoint)?;
            let right_lit = lift_range_endpoint(right, &endpoint)?;
            Ok(ValueKind::Range(Box::new(left_lit), Box::new(right_lit)))
        }
        (value, type_spec) => Err(parser_value_type_mismatch(value, type_spec)),
    }
}

/// Convert parser Value to ValueKind for primitives and ranges only.
///
/// [`Value::NumberWithUnit`] requires [`parser_value_to_value_kind`] with a quantity or ratio type.
pub fn value_to_semantic(value: &crate::parsing::ast::Value) -> Result<ValueKind, String> {
    use crate::parsing::ast::Value;
    Ok(match value {
        Value::Number(n) => ValueKind::Number(lift_parser_decimal(*n)?),
        Value::Text(s) => ValueKind::Text(s.clone()),
        Value::Boolean(b) => ValueKind::Boolean(bool::from(*b)),
        Value::Date(dt) => ValueKind::Date(date_time_to_semantic(dt)),
        Value::Time(t) => ValueKind::Time(time_to_semantic(t)),
        Value::NumberWithUnit(_, _) => {
            return Err(
                "number_with_unit literal requires type context (quantity or ratio)".to_string(),
            );
        }
        Value::Range(_, _) => literal_value_from_parser_value(value)?.value,
    })
}

/// Convert AST date-time to semantic (for tests and planning).
pub(crate) fn date_time_to_semantic(dt: &crate::parsing::ast::DateTimeValue) -> SemanticDateTime {
    SemanticDateTime {
        year: dt.year,
        month: dt.month,
        day: dt.day,
        hour: dt.hour,
        minute: dt.minute,
        second: dt.second,
        microsecond: dt.microsecond,
        timezone: dt.timezone.as_ref().map(|tz| SemanticTimezone {
            offset_hours: tz.offset_hours,
            offset_minutes: tz.offset_minutes,
        }),
    }
}

/// Convert AST time to semantic (for tests and planning).
pub(crate) fn time_to_semantic(t: &crate::parsing::ast::TimeValue) -> SemanticTime {
    SemanticTime {
        hour: t.hour.into(),
        minute: t.minute.into(),
        second: t.second.into(),
        microsecond: t.microsecond,
        timezone: t.timezone.as_ref().map(|tz| SemanticTimezone {
            offset_hours: tz.offset_hours,
            offset_minutes: tz.offset_minutes,
        }),
    }
}

/// Compare two semantic date-time values by year, month, day, hour, minute,
/// second, then microsecond. Timezone normalisation is a separate concern
/// handled at evaluation time.
pub(crate) fn compare_semantic_dates(
    left: &SemanticDateTime,
    right: &SemanticDateTime,
) -> std::cmp::Ordering {
    left.year
        .cmp(&right.year)
        .then_with(|| left.month.cmp(&right.month))
        .then_with(|| left.day.cmp(&right.day))
        .then_with(|| left.hour.cmp(&right.hour))
        .then_with(|| left.minute.cmp(&right.minute))
        .then_with(|| left.second.cmp(&right.second))
        .then_with(|| left.microsecond.cmp(&right.microsecond))
}

/// Compare two semantic time values by hour, minute, second, then microsecond.
/// Timezone is excluded for the same reason as [`compare_semantic_dates`].
pub(crate) fn compare_semantic_times(
    left: &SemanticTime,
    right: &SemanticTime,
) -> std::cmp::Ordering {
    left.hour
        .cmp(&right.hour)
        .then_with(|| left.minute.cmp(&right.minute))
        .then_with(|| left.second.cmp(&right.second))
        .then_with(|| left.microsecond.cmp(&right.microsecond))
}

/// Convert AST conversion target to semantic (planning boundary; evaluation/computation use only semantic).
pub fn conversion_target_to_semantic(
    ct: &ConversionTarget,
    unit_index: Option<&HashMap<String, Arc<LemmaType>>>,
) -> Result<SemanticConversionTarget, String> {
    match ct {
        ConversionTarget::Type(kind) => Ok(SemanticConversionTarget::Type(*kind)),
        ConversionTarget::Unit { unit_name } => {
            let unit_name = crate::parsing::ast::ascii_lowercase_logical_name(unit_name.clone());
            let index = unit_index.ok_or_else(|| format!("Unknown unit '{unit_name}'."))?;
            let owning_type = index
                .get(&unit_name)
                .ok_or_else(|| format!("Unknown unit '{unit_name}'."))?
                .clone();
            Ok(SemanticConversionTarget::Unit {
                unit_name,
                owning_type,
            })
        }
    }
}

// -----------------------------------------------------------------------------
// Primitive type constructors (moved from parsing::ast)
// -----------------------------------------------------------------------------

// Statics for lazy initialization of production-used primitive types.
static PRIMITIVE_BOOLEAN: OnceLock<Arc<LemmaType>> = OnceLock::new();
static PRIMITIVE_NUMBER: OnceLock<Arc<LemmaType>> = OnceLock::new();
static PRIMITIVE_TEXT: OnceLock<Arc<LemmaType>> = OnceLock::new();
static PRIMITIVE_DATE: OnceLock<Arc<LemmaType>> = OnceLock::new();
static PRIMITIVE_DATE_RANGE: OnceLock<Arc<LemmaType>> = OnceLock::new();
static PRIMITIVE_TIME: OnceLock<Arc<LemmaType>> = OnceLock::new();
static PRIMITIVE_RATIO: OnceLock<Arc<LemmaType>> = OnceLock::new();

#[must_use]
pub fn primitive_boolean_arc() -> &'static Arc<LemmaType> {
    PRIMITIVE_BOOLEAN.get_or_init(|| Arc::new(LemmaType::primitive(TypeSpecification::boolean())))
}

#[must_use]
pub fn primitive_number_arc() -> &'static Arc<LemmaType> {
    PRIMITIVE_NUMBER.get_or_init(|| Arc::new(LemmaType::primitive(TypeSpecification::number())))
}

#[must_use]
pub fn primitive_text_arc() -> &'static Arc<LemmaType> {
    PRIMITIVE_TEXT.get_or_init(|| Arc::new(LemmaType::primitive(TypeSpecification::text())))
}

#[must_use]
pub fn primitive_date_arc() -> &'static Arc<LemmaType> {
    PRIMITIVE_DATE.get_or_init(|| Arc::new(LemmaType::primitive(TypeSpecification::date())))
}

#[must_use]
pub fn primitive_date_range_arc() -> &'static Arc<LemmaType> {
    PRIMITIVE_DATE_RANGE
        .get_or_init(|| Arc::new(LemmaType::primitive(TypeSpecification::date_range())))
}

#[must_use]
pub fn primitive_time_arc() -> &'static Arc<LemmaType> {
    PRIMITIVE_TIME.get_or_init(|| Arc::new(LemmaType::primitive(TypeSpecification::time())))
}

#[must_use]
pub fn primitive_ratio_arc() -> &'static Arc<LemmaType> {
    PRIMITIVE_RATIO.get_or_init(|| Arc::new(LemmaType::primitive(TypeSpecification::ratio())))
}

// Test-only non-Arc wrappers used exclusively in unit tests.
#[cfg(test)]
static PRIMITIVE_QUANTITY: OnceLock<Arc<LemmaType>> = OnceLock::new();

#[cfg(test)]
#[must_use]
pub fn primitive_boolean() -> &'static LemmaType {
    primitive_boolean_arc().as_ref()
}

#[cfg(test)]
#[must_use]
pub fn primitive_quantity() -> &'static LemmaType {
    primitive_quantity_arc().as_ref()
}

#[cfg(test)]
#[must_use]
pub fn primitive_quantity_arc() -> &'static Arc<LemmaType> {
    PRIMITIVE_QUANTITY.get_or_init(|| Arc::new(LemmaType::primitive(TypeSpecification::quantity())))
}

#[cfg(test)]
#[must_use]
pub fn primitive_number() -> &'static LemmaType {
    primitive_number_arc().as_ref()
}

#[cfg(test)]
#[must_use]
pub fn primitive_text() -> &'static LemmaType {
    primitive_text_arc().as_ref()
}

#[cfg(test)]
#[must_use]
pub fn primitive_date() -> &'static LemmaType {
    primitive_date_arc().as_ref()
}

#[cfg(test)]
#[must_use]
pub fn primitive_time() -> &'static LemmaType {
    primitive_time_arc().as_ref()
}

#[cfg(test)]
#[must_use]
pub fn primitive_ratio() -> &'static LemmaType {
    primitive_ratio_arc().as_ref()
}

/// Map PrimitiveKind to TypeSpecification. Single source of truth for primitive type resolution.
#[must_use]
pub fn type_spec_for_primitive(kind: PrimitiveKind) -> TypeSpecification {
    match kind {
        PrimitiveKind::Boolean => TypeSpecification::boolean(),
        PrimitiveKind::Quantity => TypeSpecification::quantity(),
        PrimitiveKind::QuantityRange => TypeSpecification::quantity_range(),
        PrimitiveKind::Number => TypeSpecification::number(),
        PrimitiveKind::NumberRange => TypeSpecification::number_range(),
        PrimitiveKind::Percent | PrimitiveKind::Ratio => TypeSpecification::ratio(),
        PrimitiveKind::RatioRange => TypeSpecification::ratio_range(),
        PrimitiveKind::Text => TypeSpecification::text(),
        PrimitiveKind::Date => TypeSpecification::date(),
        PrimitiveKind::DateRange => TypeSpecification::date_range(),
        PrimitiveKind::Time => TypeSpecification::time(),
        PrimitiveKind::TimeRange => TypeSpecification::time_range(),
    }
}

// -----------------------------------------------------------------------------
// Display implementations
// -----------------------------------------------------------------------------

impl fmt::Display for PathSegment {
    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
        write!(f, "{} → {}", self.data, self.spec)
    }
}

impl fmt::Display for DataPath {
    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
        for segment in &self.segments {
            write!(f, "{}.", segment)?;
        }
        write!(f, "{}", self.data)
    }
}

impl fmt::Display for RulePath {
    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
        for segment in &self.segments {
            write!(f, "{}.", segment)?;
        }
        write!(f, "{}", self.rule)
    }
}

impl fmt::Display for LemmaType {
    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
        write!(f, "{}", self.name())
    }
}

fn decimal_places_in_display_value(decimal: &rust_decimal::Decimal) -> u32 {
    if decimal.is_integer() {
        return 0;
    }
    decimal.fract().normalize().scale()
}

fn format_committed_decimal_for_api(
    decimal: rust_decimal::Decimal,
    decimal_places: Option<u8>,
) -> String {
    match decimal_places {
        Some(decimal_places) => {
            let rounded = decimal.round_dp(u32::from(decimal_places));
            format!("{:.prec$}", rounded, prec = decimal_places as usize)
        }
        None => {
            let normalized = decimal.normalize();
            if normalized.fract().is_zero() {
                normalized.trunc().to_string()
            } else {
                normalized.to_string()
            }
        }
    }
}

fn format_committed_decimal_for_human_display(
    decimal: rust_decimal::Decimal,
    decimal_places: Option<u8>,
) -> String {
    match decimal_places {
        Some(decimal_places) => {
            let rounded = decimal.round_dp(u32::from(decimal_places));
            format!("{:.prec$}", rounded, prec = decimal_places as usize)
        }
        None => decimal.normalize().to_string(),
    }
}

fn format_rational_for_human_display(
    magnitude: &crate::computation::rational::RationalInteger,
    decimal_places: Option<u8>,
) -> String {
    use crate::computation::rational::{commit_rational_to_decimal, rational_to_display_str};
    match commit_rational_to_decimal(magnitude) {
        Ok(decimal) => format_committed_decimal_for_human_display(decimal, decimal_places),
        Err(_) => rational_to_display_str(magnitude),
    }
}

fn format_quantity_canonical_for_display(
    canonical: &crate::computation::rational::RationalInteger,
    lemma_type: &LemmaType,
    signature: &[(String, i32)],
) -> String {
    use crate::computation::rational::{checked_div, commit_rational_to_decimal};
    use rust_decimal::Decimal;

    let decimals = lemma_type.decimal_places();

    if let TypeSpecification::Quantity { units, .. } = &lemma_type.specifications {
        if !units.is_empty() {
            if let [(sig_unit, 1)] = signature {
                if let Some(unit) = units.iter().find(|u| u.name == *sig_unit) {
                    let in_unit = checked_div(canonical, &unit.factor)
                        .expect("BUG: de-canonicalization for quantity display must not fail");
                    let formatted = format_rational_for_human_display(&in_unit, decimals);
                    return format!("{} {}", formatted, unit.name);
                }
            }

            struct UnitDisplayCandidate {
                unit_name: String,
                decimal_places: u32,
                under_1000: bool,
                abs_magnitude: Decimal,
                formatted: String,
            }

            let mut candidates: Vec<UnitDisplayCandidate> = Vec::with_capacity(units.len());
            for unit in units.iter() {
                let in_unit = checked_div(canonical, &unit.factor)
                    .expect("BUG: de-canonicalization for quantity display must not fail");
                let formatted = format_rational_for_human_display(&in_unit, decimals);
                let abs_magnitude = match commit_rational_to_decimal(&in_unit) {
                    Ok(decimal) => decimal.abs(),
                    Err(_) => Decimal::MAX,
                };
                let decimal_places = match commit_rational_to_decimal(&in_unit) {
                    Ok(decimal) => decimal_places_in_display_value(&decimal),
                    Err(_) => u32::MAX,
                };
                let under_1000 = abs_magnitude < Decimal::from(1000);
                candidates.push(UnitDisplayCandidate {
                    unit_name: unit.name.clone(),
                    decimal_places,
                    under_1000,
                    abs_magnitude,
                    formatted,
                });
            }

            let pool: Vec<&UnitDisplayCandidate> = {
                let under: Vec<_> = candidates.iter().filter(|c| c.under_1000).collect();
                if under.is_empty() {
                    candidates.iter().collect()
                } else {
                    under
                }
            };
            let best = pool
                .iter()
                .min_by(|left, right| {
                    left.decimal_places
                        .cmp(&right.decimal_places)
                        .then_with(|| left.abs_magnitude.cmp(&right.abs_magnitude))
                })
                .expect("BUG: quantity type must have at least one declared unit");
            return format!("{} {}", best.formatted, best.unit_name);
        }
    }

    let unit_label = match signature {
        [] => String::new(),
        [(name, 1)] => name.clone(),
        _ => format_signature_operator_style(signature),
    };
    let formatted = format_rational_for_human_display(canonical, decimals);
    if unit_label.is_empty() {
        formatted
    } else {
        format!("{formatted} {unit_label}")
    }
}

impl fmt::Display for LiteralValue {
    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
        match &self.value {
            ValueKind::Quantity(n, signature) => {
                write!(
                    f,
                    "{}",
                    format_quantity_canonical_for_display(n, &self.lemma_type, signature)
                )
            }
            ValueKind::Ratio(_, Some(_unit_name)) => write!(f, "{}", self.value),
            ValueKind::Range(left, right) => write!(f, "{}...{}", left, right),
            _ => write!(f, "{}", self.value),
        }
    }
}

// -----------------------------------------------------------------------------
// Tests
// -----------------------------------------------------------------------------

#[cfg(test)]
mod tests {
    use super::*;
    use crate::computation::rational::decimal_to_rational;
    use crate::literals::DateGranularity;
    use crate::literals::Value;
    use crate::parsing::ast::{BooleanValue, DateTimeValue, LemmaSpec, PrimitiveKind, TimeValue};
    use rust_decimal::Decimal;
    use std::str::FromStr;
    use std::sync::Arc;

    #[test]
    fn default_primitive_help_is_goal_oriented() {
        let kinds = [
            PrimitiveKind::Boolean,
            PrimitiveKind::Quantity,
            PrimitiveKind::QuantityRange,
            PrimitiveKind::Number,
            PrimitiveKind::NumberRange,
            PrimitiveKind::Percent,
            PrimitiveKind::Ratio,
            PrimitiveKind::RatioRange,
            PrimitiveKind::Text,
            PrimitiveKind::Date,
            PrimitiveKind::DateRange,
            PrimitiveKind::Time,
            PrimitiveKind::TimeRange,
        ];
        for kind in kinds {
            let spec = type_spec_for_primitive(kind);
            let help = match &spec {
                TypeSpecification::Boolean { help, .. }
                | TypeSpecification::Number { help, .. }
                | TypeSpecification::NumberRange { help }
                | TypeSpecification::Text { help, .. }
                | TypeSpecification::Quantity { help, .. }
                | TypeSpecification::QuantityRange { help, .. }
                | TypeSpecification::Ratio { help, .. }
                | TypeSpecification::RatioRange { help, .. }
                | TypeSpecification::Date { help, .. }
                | TypeSpecification::DateRange { help }
                | TypeSpecification::TimeRange { help }
                | TypeSpecification::Time { help, .. } => help,
                TypeSpecification::Veto { .. } | TypeSpecification::Undetermined => {
                    unreachable!(
                        "BUG: primitive kind {:?} mapped to non-primitive spec",
                        kind
                    )
                }
            };
            assert!(!help.is_empty(), "help for {:?}", kind);
            assert!(
                !help.to_ascii_lowercase().contains("format:"),
                "help for {:?} must not describe syntax: {:?}",
                kind,
                help
            );
            assert_eq!(help, default_help_for_primitive(kind));
        }
    }

    #[test]
    fn test_negated_comparison() {
        assert_eq!(
            negated_comparison(ComparisonComputation::LessThan),
            ComparisonComputation::GreaterThanOrEqual
        );
        assert_eq!(
            negated_comparison(ComparisonComputation::GreaterThanOrEqual),
            ComparisonComputation::LessThan
        );
        assert_eq!(
            negated_comparison(ComparisonComputation::Is),
            ComparisonComputation::IsNot
        );
        assert_eq!(
            negated_comparison(ComparisonComputation::IsNot),
            ComparisonComputation::Is
        );
    }

    #[test]
    fn value_to_semantic_number_is_decimal() {
        let kind = value_to_semantic(&Value::Number(Decimal::from(42))).unwrap();
        assert!(matches!(kind, ValueKind::Number(d) if d == rational_new(42, 1)));
    }

    #[test]
    fn value_kind_quantity_serializes_with_signature() {
        let kind = ValueKind::Quantity(
            decimal_to_rational(Decimal::from_str("99.50").unwrap()).unwrap(),
            vec![("eur".to_string(), 1)],
        );
        let json = serde_json::to_value(&kind).unwrap();
        assert_eq!(json["quantity"]["value"], "99.5");
        assert_eq!(json["quantity"]["signature"][0][0], "eur");
        assert_eq!(json["quantity"]["signature"][0][1], 1);
    }

    #[test]
    fn value_kind_quantity_compound_signature_roundtrips() {
        let original = ValueKind::Quantity(
            decimal_to_rational(Decimal::from_str("4800").unwrap()).unwrap(),
            vec![
                ("eur".to_string(), 1),
                ("hour".to_string(), 1),
                ("minute".to_string(), -1),
            ],
        );
        let json = serde_json::to_string(&original).unwrap();
        let parsed: ValueKind = serde_json::from_str(&json).unwrap();
        assert_eq!(original, parsed);
    }

    #[test]
    fn value_kind_quantity_empty_signature_roundtrips() {
        let original = ValueKind::Quantity(
            decimal_to_rational(Decimal::from_str("12.5").unwrap()).unwrap(),
            Vec::new(),
        );
        let json = serde_json::to_string(&original).unwrap();
        let parsed: ValueKind = serde_json::from_str(&json).unwrap();
        assert_eq!(original, parsed);
    }

    #[test]
    fn literal_value_number_serde_not_rational_array() {
        let lit = LiteralValue::number_from_decimal(Decimal::from(20));
        let json = serde_json::to_value(&lit).unwrap();
        let number = json
            .get("value")
            .and_then(|v| v.get("number"))
            .expect("number field");
        assert!(number.is_string());
        assert_eq!(number.as_str(), Some("20"));
        assert!(
            !number.is_array(),
            "stored number must not serialize as [n,d]"
        );
    }

    #[test]
    fn test_literal_value_to_primitive_type() {
        let one = rational_new(1, 1);

        assert_eq!(LiteralValue::text("".to_string()).lemma_type.name(), "text");
        assert_eq!(
            LiteralValue::number(one.clone()).lemma_type.name(),
            "number"
        );
        assert_eq!(
            LiteralValue::from_bool(bool::from(BooleanValue::True))
                .lemma_type
                .name(),
            "boolean"
        );

        let dt = DateTimeValue {
            year: 2024,
            month: 1,
            day: 1,
            hour: 0,
            minute: 0,
            second: 0,
            microsecond: 0,
            timezone: None,

            granularity: DateGranularity::Full,
        };
        assert_eq!(
            LiteralValue::date(date_time_to_semantic(&dt))
                .lemma_type
                .name(),
            "date"
        );
        assert_eq!(
            LiteralValue::ratio_from_decimal(Decimal::new(1, 2), Some("percent".to_string()))
                .lemma_type
                .name(),
            "ratio"
        );
        let dur_type = LemmaType::new(
            "duration".to_string(),
            TypeSpecification::Quantity {
                minimum: None,
                maximum: None,
                decimals: None,
                units: QuantityUnits::from(vec![QuantityUnit {
                    name: "second".to_string(),
                    factor: crate::computation::rational::rational_one(),
                    derived_quantity_factors: Vec::new(),
                    decomposition: BaseQuantityVector::new(),
                    minimum: None,
                    maximum: None,
                    default_magnitude: None,
                }]),
                traits: vec![QuantityTrait::Duration],
                decomposition: None,
                help: String::new(),
            },
            TypeExtends::Primitive,
        );
        assert_eq!(
            LiteralValue::quantity_with_type(one.clone(), "second".to_string(), Arc::new(dur_type))
                .lemma_type
                .name(),
            "duration"
        );
    }

    #[test]
    fn test_type_display() {
        let specs = TypeSpecification::text();
        let lemma_type = LemmaType::new("name".to_string(), specs, TypeExtends::Primitive);
        assert_eq!(format!("{}", lemma_type), "name");
    }

    #[test]
    fn test_type_serialization() {
        let specs = TypeSpecification::number();
        let lemma_type = LemmaType::new("dice".to_string(), specs, TypeExtends::Primitive);
        let serialized = serde_json::to_string(&lemma_type).unwrap();
        let deserialized: LemmaType = serde_json::from_str(&serialized).unwrap();
        assert_eq!(lemma_type, deserialized);
    }

    #[test]
    fn test_literal_value_display_value() {
        let ten = rational_new(10, 1);

        assert_eq!(
            LiteralValue::text("hello".to_string()).display_value(),
            "hello"
        );
        assert_eq!(LiteralValue::number(ten).display_value(), "10");
        assert_eq!(LiteralValue::from_bool(true).display_value(), "true");
        assert_eq!(LiteralValue::from_bool(false).display_value(), "false");

        // 0.10 ratio with "percent" unit displays as 10% (unit conversion applied)
        let ten_percent_ratio =
            LiteralValue::ratio_from_decimal(Decimal::new(1, 1), Some("percent".to_string()));
        assert_eq!(ten_percent_ratio.display_value(), "10%");

        let time = TimeValue {
            hour: 14,
            minute: 30,
            second: 0,
            microsecond: 0,
            timezone: None,
        };
        let time_display = LiteralValue::time(time_to_semantic(&time)).display_value();
        assert!(time_display.contains("14"));
        assert!(time_display.contains("30"));
    }

    #[test]
    fn test_quantity_display_respects_type_decimals() {
        let money_type = LemmaType {
            name: Some("money".to_string()),
            specifications: TypeSpecification::Quantity {
                minimum: None,
                maximum: None,
                decimals: Some(2),
                units: QuantityUnits::from(vec![QuantityUnit {
                    name: "eur".to_string(),
                    factor: crate::computation::rational::rational_one(),
                    derived_quantity_factors: Vec::new(),
                    decomposition: BaseQuantityVector::new(),
                    minimum: None,
                    maximum: None,
                    default_magnitude: None,
                }]),
                traits: Vec::new(),
                decomposition: None,
                help: String::new(),
            },
            extends: TypeExtends::Primitive,
        };
        let money_type = Arc::new(money_type);
        let val = LiteralValue::quantity_with_type(
            decimal_to_rational(Decimal::from_str("1.8").unwrap()).unwrap(),
            "eur".to_string(),
            money_type.clone(),
        );
        assert_eq!(val.display_value(), "1.80 eur");
        let more_precision = LiteralValue::quantity_with_type(
            decimal_to_rational(Decimal::from_str("1.80000").unwrap()).unwrap(),
            "eur".to_string(),
            money_type,
        );
        assert_eq!(more_precision.display_value(), "1.80 eur");
        let quantity_no_decimals = LemmaType {
            name: Some("count".to_string()),
            specifications: TypeSpecification::Quantity {
                minimum: None,
                maximum: None,
                decimals: None,
                units: QuantityUnits::from(vec![QuantityUnit {
                    name: "items".to_string(),
                    factor: crate::computation::rational::rational_one(),
                    derived_quantity_factors: Vec::new(),
                    decomposition: BaseQuantityVector::new(),
                    minimum: None,
                    maximum: None,
                    default_magnitude: None,
                }]),
                traits: Vec::new(),
                decomposition: None,
                help: String::new(),
            },
            extends: TypeExtends::Primitive,
        };
        let val_any = LiteralValue::quantity_with_type(
            decimal_to_rational(Decimal::from_str("42.50").unwrap()).unwrap(),
            "items".to_string(),
            Arc::new(quantity_no_decimals),
        );
        assert_eq!(val_any.display_value(), "42.5 items");
    }

    #[test]
    fn test_literal_value_time_type() {
        let time = TimeValue {
            hour: 14,
            minute: 30,
            second: 0,
            microsecond: 0,
            timezone: None,
        };
        let lit = LiteralValue::time(time_to_semantic(&time));
        assert_eq!(lit.lemma_type.name(), "time");
    }

    #[test]
    fn test_quantity_family_name_primitive_root() {
        let quantity_spec = TypeSpecification::quantity();
        let money_primitive = LemmaType::new(
            "money".to_string(),
            quantity_spec.clone(),
            TypeExtends::Primitive,
        );
        assert_eq!(money_primitive.quantity_family_name(), Some("money"));
    }

    #[test]
    fn test_quantity_family_name_custom() {
        let quantity_spec = TypeSpecification::quantity();
        let money_custom = LemmaType::new(
            "money".to_string(),
            quantity_spec,
            TypeExtends::custom_local("money".to_string(), "money".to_string()),
        );
        assert_eq!(money_custom.quantity_family_name(), Some("money"));
    }

    #[test]
    fn test_same_quantity_family_same_name_different_extends() {
        let quantity_spec = TypeSpecification::quantity();
        let money_primitive = LemmaType::new(
            "money".to_string(),
            quantity_spec.clone(),
            TypeExtends::Primitive,
        );
        let money_custom = LemmaType::new(
            "money".to_string(),
            quantity_spec,
            TypeExtends::custom_local("money".to_string(), "money".to_string()),
        );
        assert!(money_primitive.same_quantity_family(&money_custom));
        assert!(money_custom.same_quantity_family(&money_primitive));
    }

    #[test]
    fn test_same_quantity_family_parent_and_child() {
        let quantity_spec = TypeSpecification::quantity();
        let type_x = LemmaType::new(
            "x".to_string(),
            quantity_spec.clone(),
            TypeExtends::Primitive,
        );
        let type_x2 = LemmaType::new(
            "x2".to_string(),
            quantity_spec,
            TypeExtends::custom_local("x".to_string(), "x".to_string()),
        );
        assert_eq!(type_x.quantity_family_name(), Some("x"));
        assert_eq!(type_x2.quantity_family_name(), Some("x"));
        assert!(type_x.same_quantity_family(&type_x2));
        assert!(type_x2.same_quantity_family(&type_x));
    }

    #[test]
    fn test_same_quantity_family_siblings() {
        let quantity_spec = TypeSpecification::quantity();
        let type_x2_a = LemmaType::new(
            "x2a".to_string(),
            quantity_spec.clone(),
            TypeExtends::custom_local("x".to_string(), "x".to_string()),
        );
        let type_x2_b = LemmaType::new(
            "x2b".to_string(),
            quantity_spec,
            TypeExtends::custom_local("x".to_string(), "x".to_string()),
        );
        assert!(type_x2_a.same_quantity_family(&type_x2_b));
    }

    #[test]
    fn test_same_quantity_family_different_families() {
        let quantity_spec = TypeSpecification::quantity();
        let money = LemmaType::new(
            "money".to_string(),
            quantity_spec.clone(),
            TypeExtends::Primitive,
        );
        let temperature = LemmaType::new(
            "temperature".to_string(),
            quantity_spec,
            TypeExtends::Primitive,
        );
        assert!(!money.same_quantity_family(&temperature));
        assert!(!temperature.same_quantity_family(&money));
    }

    #[test]
    fn test_same_quantity_family_quantity_vs_non_quantity() {
        let quantity_spec = TypeSpecification::quantity();
        let number_spec = TypeSpecification::number();
        let quantity_type =
            LemmaType::new("money".to_string(), quantity_spec, TypeExtends::Primitive);
        let number_type = LemmaType::new("amount".to_string(), number_spec, TypeExtends::Primitive);
        assert!(!quantity_type.same_quantity_family(&number_type));
        assert!(!number_type.same_quantity_family(&quantity_type));
    }

    #[test]
    fn test_same_quantity_family_anonymous_quantitys_are_not_family_compatible() {
        let left = LemmaType::anonymous_for_decomposition(duration_decomposition());
        let right = LemmaType::anonymous_for_decomposition(duration_decomposition());

        assert!(!left.same_quantity_family(&right));
        assert!(left.compatible_with_anonymous_quantity(&right));
    }

    #[test]
    fn test_quantity_family_name_non_quantity_returns_none() {
        let number_spec = TypeSpecification::number();
        let number_type = LemmaType::new("amount".to_string(), number_spec, TypeExtends::Primitive);
        assert_eq!(number_type.quantity_family_name(), None);
    }

    #[test]
    fn test_lemma_type_inequality_local_vs_import_same_shape() {
        let dep = Arc::new(LemmaSpec::new("dep".to_string()));
        let quantity_spec = TypeSpecification::quantity();
        let local = LemmaType::new(
            "t".to_string(),
            quantity_spec.clone(),
            TypeExtends::custom_local("money".to_string(), "money".to_string()),
        );
        let imported = LemmaType::new(
            "t".to_string(),
            quantity_spec,
            TypeExtends::Custom {
                parent: "money".to_string(),
                family: "money".to_string(),
                defining_spec: TypeDefiningSpec::Import {
                    spec: Arc::clone(&dep),
                },
            },
        );
        assert_ne!(local, imported);
    }

    #[test]
    fn test_lemma_type_equality_import_same_arc_pointer_identity() {
        // TypeDefiningSpec equality is by Arc pointer identity (Arc::ptr_eq).
        // Two types are equal iff they hold the same interned Arc, matching
        // the Context::insert_spec invariant.
        let shared_spec = Arc::new(LemmaSpec::new("dep".to_string()));
        let quantity_spec = TypeSpecification::quantity();
        let left = LemmaType::new(
            "t".to_string(),
            quantity_spec.clone(),
            TypeExtends::Custom {
                parent: "money".to_string(),
                family: "money".to_string(),
                defining_spec: TypeDefiningSpec::Import {
                    spec: Arc::clone(&shared_spec),
                },
            },
        );
        let right = LemmaType::new(
            "t".to_string(),
            quantity_spec,
            TypeExtends::Custom {
                parent: "money".to_string(),
                family: "money".to_string(),
                defining_spec: TypeDefiningSpec::Import {
                    spec: Arc::clone(&shared_spec),
                },
            },
        );
        assert_eq!(left, right);
    }

    #[test]
    fn test_lemma_type_inequality_import_different_arc_pointer() {
        // Two distinct Arc<LemmaSpec> (even with identical content) are not equal.
        let spec_a = Arc::new(LemmaSpec::new("dep".to_string()));
        let spec_b = Arc::new(LemmaSpec::new("dep".to_string()));
        let quantity_spec = TypeSpecification::quantity();
        let left = LemmaType::new(
            "t".to_string(),
            quantity_spec.clone(),
            TypeExtends::Custom {
                parent: "money".to_string(),
                family: "money".to_string(),
                defining_spec: TypeDefiningSpec::Import {
                    spec: Arc::clone(&spec_a),
                },
            },
        );
        let right = LemmaType::new(
            "t".to_string(),
            quantity_spec,
            TypeExtends::Custom {
                parent: "money".to_string(),
                family: "money".to_string(),
                defining_spec: TypeDefiningSpec::Import { spec: spec_b },
            },
        );
        assert_ne!(left, right);
    }

    fn month_default_arg() -> CommandArg {
        CommandArg::Literal(crate::literals::Value::NumberWithUnit(
            Decimal::ONE,
            "month".to_string(),
        ))
    }

    fn unit_factor_arg(name: &str, factor: i64) -> [CommandArg; 2] {
        [
            CommandArg::Label(name.to_string()),
            CommandArg::UnitExpr(crate::parsing::ast::UnitArg::Factor(Decimal::from(factor))),
        ]
    }

    #[test]
    fn default_calendar_on_text_reports_hint() {
        let specs = TypeSpecification::text();
        let mut default = None;
        let err = specs
            .apply_constraint(
                "notes",
                TypeConstraintCommand::Default,
                &[month_default_arg()],
                &mut default,
            )
            .unwrap_err();
        assert!(err.contains("Unit 'month' is for calendar data"));
        assert!(err.contains("double quotes"));
    }

    #[test]
    fn default_calendar_on_duration_reports_valid_units() {
        let mut specs = TypeSpecification::quantity();
        specs = specs
            .apply_constraint(
                "duration",
                TypeConstraintCommand::Unit,
                &unit_factor_arg("second", 1),
                &mut None,
            )
            .unwrap();
        specs = specs
            .apply_constraint(
                "duration",
                TypeConstraintCommand::Unit,
                &unit_factor_arg("week", 604_800),
                &mut None,
            )
            .unwrap();
        specs = specs
            .apply_constraint(
                "duration",
                TypeConstraintCommand::Trait,
                &[CommandArg::Label("duration".to_string())],
                &mut None,
            )
            .unwrap();
        let mut default = None;
        let err = specs
            .apply_constraint(
                "duration",
                TypeConstraintCommand::Default,
                &[month_default_arg()],
                &mut default,
            )
            .unwrap_err();
        assert!(err.contains("Unit 'month' is for calendar data"));
        assert!(err.contains("Valid 'duration' units are"));
        assert!(err.contains("week"));
    }

    #[test]
    fn default_valid_duration_weeks_accepted() {
        let mut specs = TypeSpecification::quantity();
        specs = specs
            .apply_constraint(
                "duration",
                TypeConstraintCommand::Unit,
                &unit_factor_arg("second", 1),
                &mut None,
            )
            .unwrap();
        specs = specs
            .apply_constraint(
                "duration",
                TypeConstraintCommand::Unit,
                &unit_factor_arg("week", 604_800),
                &mut None,
            )
            .unwrap();
        specs = specs
            .apply_constraint(
                "duration",
                TypeConstraintCommand::Trait,
                &[CommandArg::Label("duration".to_string())],
                &mut None,
            )
            .unwrap();
        let mut default = None;
        specs
            .apply_constraint(
                "duration",
                TypeConstraintCommand::Default,
                &[CommandArg::Literal(crate::literals::Value::NumberWithUnit(
                    Decimal::from(4),
                    "week".to_string(),
                ))],
                &mut default,
            )
            .unwrap();
        assert!(matches!(
            default,
            Some(RawDefault::Quantity {
                unit_name,
                ..
            }) if unit_name == "week"
        ));
    }

    #[test]
    fn default_unknown_unit_on_duration_lists_valid_units() {
        let mut specs = TypeSpecification::quantity();
        specs = specs
            .apply_constraint(
                "duration",
                TypeConstraintCommand::Unit,
                &unit_factor_arg("second", 1),
                &mut None,
            )
            .unwrap();
        specs = specs
            .apply_constraint(
                "duration",
                TypeConstraintCommand::Trait,
                &[CommandArg::Label("duration".to_string())],
                &mut None,
            )
            .unwrap();
        let mut default = None;
        let err = specs
            .apply_constraint(
                "duration",
                TypeConstraintCommand::Default,
                &[CommandArg::Literal(crate::literals::Value::NumberWithUnit(
                    Decimal::ONE,
                    "fortnight".to_string(),
                ))],
                &mut default,
            )
            .unwrap_err();
        assert!(err.contains("fortnight"));
        assert!(err.contains("not defined on 'duration'"));
        assert!(err.contains("Valid units are"));
    }

    fn money_quantity_type() -> LemmaType {
        LemmaType::new(
            "Money".to_string(),
            TypeSpecification::Quantity {
                minimum: None,
                maximum: None,
                decimals: None,
                units: QuantityUnits::from(vec![
                    QuantityUnit {
                        name: "eur".to_string(),
                        factor: crate::computation::rational::rational_one(),
                        derived_quantity_factors: Vec::new(),
                        decomposition: BaseQuantityVector::new(),
                        minimum: None,
                        maximum: None,
                        default_magnitude: None,
                    },
                    QuantityUnit {
                        name: "usd".to_string(),
                        factor: crate::computation::rational::decimal_to_rational(Decimal::new(
                            91, 2,
                        ))
                        .expect("factor"),
                        derived_quantity_factors: Vec::new(),
                        decomposition: BaseQuantityVector::new(),
                        minimum: None,
                        maximum: None,
                        default_magnitude: None,
                    },
                ]),
                traits: Vec::new(),
                decomposition: None,
                help: String::new(),
            },
            TypeExtends::Primitive,
        )
    }

    #[test]
    fn quantity_unit_names_for_named_quantity() {
        let money = money_quantity_type();
        assert_eq!(money.quantity_unit_names(), Some(vec!["eur", "usd"]));
    }

    // ---------------------------------------------------------------------------
    // Phase 0 — pin combine_signatures and canonicalize_signature behavior
    // ---------------------------------------------------------------------------

    fn sig(pairs: &[(&str, i32)]) -> Vec<(String, i32)> {
        pairs.iter().map(|(s, e)| (s.to_string(), *e)).collect()
    }

    #[test]
    fn combine_signatures_multiply_adds_exponents() {
        let left = sig(&[("eur", 1)]);
        let right = sig(&[("hour", -1)]);
        let result = combine_signatures(&left, &right, true);
        assert_eq!(result, sig(&[("eur", 1), ("hour", -1)]));
    }

    #[test]
    fn combine_signatures_divide_subtracts_exponents() {
        let left = sig(&[("eur", 1)]);
        let right = sig(&[("hour", 1)]);
        let result = combine_signatures(&left, &right, false);
        assert_eq!(result, sig(&[("eur", 1), ("hour", -1)]));
    }

    #[test]
    fn combine_signatures_cancels_to_empty() {
        let left = sig(&[("ce", 1), ("minute", -1)]);
        let right = sig(&[("minute", 1)]);
        let result = combine_signatures(&left, &right, true);
        // ce * (ce/min * min) = ce; minute cancels
        assert_eq!(result, sig(&[("ce", 1)]));
    }

    #[test]
    fn combine_signatures_output_is_canonical_form() {
        let left = sig(&[("eur", 1), ("hour", 1)]);
        let right = sig(&[("minute", 1)]);
        let result = combine_signatures(&left, &right, false); // divide
                                                               // [("eur",1),("hour",1)] / [("minute",1)] = [("eur",1),("hour",1),("minute",-1)]
        let expected = sig(&[("eur", 1), ("hour", 1), ("minute", -1)]);
        assert_eq!(result, expected);
    }

    #[test]
    fn canonicalize_signature_drops_zero_exponents() {
        let sig_with_zero = sig(&[("eur", 1), ("hour", 0), ("minute", -1)]);
        let result = canonicalize_signature(&sig_with_zero);
        assert_eq!(result, sig(&[("eur", 1), ("minute", -1)]));
    }

    #[test]
    fn canonicalize_signature_sorts_by_name() {
        let unsorted = sig(&[("minute", -1), ("eur", 1)]);
        let result = canonicalize_signature(&unsorted);
        assert_eq!(result, sig(&[("eur", 1), ("minute", -1)]));
    }

    // ---------------------------------------------------------------------------
    // Phase 0 — format_signature_operator_style (to be implemented in
    // signature_factor_and_display todo)
    // ---------------------------------------------------------------------------

    #[test]
    fn format_signature_operator_style_numerator_only() {
        let signature = sig(&[("eur", 1)]);
        let result = format_signature_operator_style(&signature);
        assert_eq!(result, "eur");
    }

    #[test]
    fn format_signature_operator_style_with_denominator() {
        let signature = sig(&[("eur", 1), ("hour", -1)]);
        let result = format_signature_operator_style(&signature);
        assert_eq!(result, "eur/hour");
    }

    #[test]
    fn format_signature_operator_style_denominator_only() {
        let signature = sig(&[("meter", -1)]);
        let result = format_signature_operator_style(&signature);
        assert_eq!(result, "1/meter");
    }

    #[test]
    fn format_signature_operator_style_with_exponents() {
        let signature = sig(&[("meter", 2), ("second", -2)]);
        let result = format_signature_operator_style(&signature);
        assert_eq!(result, "meter^2/second^2");
    }

    // ---------------------------------------------------------------------------
    // Phase 0 — calendar_unit_factor (to be implemented in builtin_calendar_factor_table)
    // ---------------------------------------------------------------------------

    #[test]
    fn calendar_unit_factor_table_completeness() {
        // Every SemanticCalendarUnit Display string must resolve to a factor.
        // Today SemanticCalendarUnit only has Month and Year; more may be added.
        for unit in &[SemanticCalendarUnit::Month, SemanticCalendarUnit::Year] {
            let name = unit.to_string();
            assert!(
                calendar_unit_factor(&name).is_some(),
                "calendar_unit_factor('{}') must return Some",
                name
            );
        }
    }

    #[test]
    fn semantic_calendar_unit_display_returns_singular() {
        // Today Month => "months", Year => "years" (plural).
        // After singular_calendar_names_everywhere, must be "month" and "year".
        assert_eq!(SemanticCalendarUnit::Month.to_string(), "month");
        assert_eq!(SemanticCalendarUnit::Year.to_string(), "year");
    }

    // ---------------------------------------------------------------------------
    // Phase 0 — signature_factor (to be implemented in signature_factor_and_display)
    // ---------------------------------------------------------------------------

    #[test]
    fn signature_factor_with_calendar_units() {
        use std::collections::HashMap;
        let calendar = test_calendar_type_for_signature_factor();
        let unit_index: HashMap<String, Arc<LemmaType>> = HashMap::new();
        // month factor = 1, year factor = 12.
        // [(month,1),(year,-1)] = 1/12
        let sig_month_per_year = sig(&[("month", 1), ("year", -1)]);
        let factor = signature_factor(&sig_month_per_year, &unit_index, Some(&calendar));
        let expected = rational_new(1, 12);
        assert_eq!(factor, expected, "month/year factor must be 1/12");
    }

    fn test_calendar_type_for_signature_factor() -> LemmaType {
        use crate::computation::rational::{decimal_to_rational, rational_one};
        use crate::literals::{QuantityUnit, QuantityUnits};
        use rust_decimal::Decimal;
        LemmaType::new(
            "calendar".to_string(),
            TypeSpecification::Quantity {
                minimum: None,
                maximum: None,
                decimals: None,
                units: QuantityUnits::from(vec![
                    QuantityUnit {
                        name: "month".to_string(),
                        factor: rational_one(),
                        minimum: None,
                        maximum: None,
                        default_magnitude: None,
                        decomposition: calendar_decomposition(),
                        derived_quantity_factors: Vec::new(),
                    },
                    QuantityUnit {
                        name: "year".to_string(),
                        factor: decimal_to_rational(Decimal::from(12)).expect("year factor"),
                        minimum: None,
                        maximum: None,
                        default_magnitude: None,
                        decomposition: calendar_decomposition(),
                        derived_quantity_factors: Vec::new(),
                    },
                ]),
                traits: vec![QuantityTrait::Calendar],
                decomposition: Some(calendar_decomposition()),
                help: String::new(),
            },
            TypeExtends::Primitive,
        )
    }

    #[test]
    #[should_panic(expected = "BUG: signature_factor called with unresolved unit name")]
    fn signature_factor_panics_on_unresolved_name() {
        use std::collections::HashMap;
        let unit_index: HashMap<String, Arc<LemmaType>> = HashMap::new();
        let bad_sig = sig(&[("nonexistent_unit_xyz", 1)]);
        signature_factor(&bad_sig, &unit_index, None);
    }

    #[test]
    fn signature_factor_uses_owner_when_expression_index_empty() {
        use std::collections::HashMap;
        let money = test_money_type_for_signature_factor();
        let expression_units: HashMap<String, Arc<LemmaType>> = HashMap::new();
        let sig_usd = sig(&[("usd", 1)]);
        let factor = signature_factor(&sig_usd, &expression_units, Some(&money));
        assert_eq!(factor, rational_new(91, 100));
    }

    fn test_money_type_for_signature_factor() -> LemmaType {
        use crate::computation::rational::decimal_to_rational;
        use crate::literals::{QuantityUnit, QuantityUnits};
        use rust_decimal::Decimal;
        LemmaType::new(
            "money".to_string(),
            TypeSpecification::Quantity {
                minimum: None,
                maximum: None,
                decimals: Some(2),
                units: QuantityUnits::from(vec![
                    QuantityUnit {
                        name: "eur".to_string(),
                        factor: crate::computation::rational::rational_one(),
                        minimum: None,
                        maximum: None,
                        default_magnitude: None,
                        decomposition: BaseQuantityVector::new(),
                        derived_quantity_factors: Vec::new(),
                    },
                    QuantityUnit {
                        name: "usd".to_string(),
                        factor: decimal_to_rational(Decimal::new(91, 2)).expect("usd factor"),
                        minimum: None,
                        maximum: None,
                        default_magnitude: None,
                        decomposition: BaseQuantityVector::new(),
                        derived_quantity_factors: Vec::new(),
                    },
                ]),
                traits: Vec::new(),
                decomposition: None,
                help: String::new(),
            },
            TypeExtends::Primitive,
        )
    }

    fn quantity_type_with_kilogram() -> TypeSpecification {
        use crate::computation::rational::rational_one;
        use crate::literals::{QuantityUnit, QuantityUnits};
        let mut units = QuantityUnits::new();
        units.push(QuantityUnit {
            name: "kilogram".to_string(),
            factor: rational_one(),
            minimum: None,
            maximum: None,
            default_magnitude: None,
            decomposition: BaseQuantityVector::new(),
            derived_quantity_factors: Vec::new(),
        });
        TypeSpecification::Quantity {
            minimum: None,
            maximum: None,
            decimals: None,
            units,
            traits: Vec::new(),
            decomposition: None,
            help: String::new(),
        }
    }

    #[test]
    fn parser_value_to_value_kind_rejects_bare_number_for_quantity() {
        let ten = Value::Number(Decimal::from(10));
        let err = parser_value_to_value_kind(&ten, &quantity_type_with_kilogram())
            .expect_err("bare number must not bind to quantity");
        assert!(
            err.contains("kilogram"),
            "error must hint expected unit, got: {err}"
        );
    }

    #[test]
    fn parser_value_to_value_kind_accepts_number_with_unit_for_quantity() {
        let ten_kg = Value::NumberWithUnit(Decimal::from(10), "kilogram".to_string());
        let kind = parser_value_to_value_kind(&ten_kg, &quantity_type_with_kilogram())
            .expect("10 kilogram must bind to quantity");
        assert!(matches!(kind, ValueKind::Quantity(_, _)));
    }

    #[test]
    fn parser_value_to_value_kind_accepts_bare_number_for_ratio() {
        let ten = Value::Number(Decimal::from(10));
        let kind =
            parser_value_to_value_kind(&ten, &TypeSpecification::ratio()).expect("number -> ratio");
        assert!(matches!(kind, ValueKind::Ratio(_, None)));
    }

    #[test]
    fn value_kind_matches_spec_rejects_number_for_quantity() {
        let n = ValueKind::Number(rational_new(10, 1));
        assert!(!value_kind_matches_spec(&n, &quantity_type_with_kilogram()));
    }

    #[test]
    fn apply_constraint_rejects_inherited_unit_factor_change() {
        let mut specs = TypeSpecification::quantity();
        specs = specs
            .apply_constraint(
                "money",
                TypeConstraintCommand::Unit,
                &unit_factor_arg("eur", 1),
                &mut None,
            )
            .expect("seed eur");
        let err = specs
            .apply_constraint(
                "money",
                TypeConstraintCommand::Unit,
                &[
                    CommandArg::Label("eur".to_string()),
                    CommandArg::UnitExpr(crate::parsing::ast::UnitArg::Factor(Decimal::new(11, 1))),
                ],
                &mut None,
            )
            .expect_err("must not change inherited unit factor");
        assert!(err.contains("eur"), "error must name unit, got: {err}");
        assert!(
            err.contains("inherited") || err.contains("cannot change"),
            "error must reject factor change, got: {err}"
        );
    }

    #[test]
    fn apply_constraint_allows_additive_unit_on_inherited_spec() {
        let mut specs = TypeSpecification::quantity();
        specs = specs
            .apply_constraint(
                "money",
                TypeConstraintCommand::Unit,
                &unit_factor_arg("eur", 1),
                &mut None,
            )
            .expect("seed eur");
        specs = specs
            .apply_constraint(
                "money",
                TypeConstraintCommand::Unit,
                &unit_factor_arg("usd", 1),
                &mut None,
            )
            .expect("add usd");
        match &specs {
            TypeSpecification::Quantity { units, .. } => assert_eq!(units.len(), 2),
            other => panic!("expected Quantity, got {other:?}"),
        }
    }

    #[test]
    fn apply_constraint_idempotent_inherited_unit_redeclare() {
        let mut specs = TypeSpecification::quantity();
        specs = specs
            .apply_constraint(
                "money",
                TypeConstraintCommand::Unit,
                &unit_factor_arg("eur", 1),
                &mut None,
            )
            .expect("seed eur");
        specs = specs
            .apply_constraint(
                "money",
                TypeConstraintCommand::Unit,
                &unit_factor_arg("eur", 1),
                &mut None,
            )
            .expect("idempotent eur");
        match &specs {
            TypeSpecification::Quantity { units, .. } => {
                assert_eq!(units.len(), 1);
                assert_eq!(
                    units.iter().find(|u| u.name == "eur").expect("eur").factor,
                    crate::computation::rational::rational_one()
                );
            }
            other => panic!("expected Quantity, got {other:?}"),
        }
    }
}