laurus 0.3.1

Unified search library for lexical, vector, and semantic retrieval
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
//! IVF (Inverted File) index builder for memory-efficient search.

use std::sync::Arc;

use rayon::prelude::*;

use crate::error::{LaurusError, Result};
use crate::storage::Storage;
use crate::vector::core::vector::Vector;
use crate::vector::index::IvfIndexConfig;
use crate::vector::index::field::LegacyVectorFieldWriter;
use crate::vector::writer::{VectorIndexWriter, VectorIndexWriterConfig};
use serde::{Deserialize, Serialize};

#[derive(Debug)]
/// Builder for IVF vector indexes (memory-efficient search).
pub struct IvfIndexWriter {
    index_config: IvfIndexConfig,
    writer_config: VectorIndexWriterConfig,
    storage: Option<Arc<dyn Storage>>,
    path: String,
    centroids: Vec<Vector>,                          // Cluster centroids
    inverted_lists: Vec<Vec<(u64, String, Vector)>>, // Inverted lists for each cluster
    vectors: Vec<(u64, String, Vector)>,             // All vectors (used during construction)
    is_finalized: bool,
    total_vectors_to_add: Option<usize>,
    next_vec_id: u64,
}

impl IvfIndexWriter {
    /// Create a new IVF index builder.
    ///
    /// # Arguments
    ///
    /// * `config` - Vector index configuration
    /// * `n_clusters` - Number of clusters (cells) to create (typical: sqrt(n_vectors))
    /// * `n_probe` - Number of clusters to search (typical: 1-10, higher = more accurate but slower)
    pub fn new(
        index_config: IvfIndexConfig,
        writer_config: VectorIndexWriterConfig,
        path: impl Into<String>,
    ) -> Result<Self> {
        Ok(Self {
            index_config,
            writer_config,
            storage: None,
            path: path.into(),

            centroids: Vec::new(),
            inverted_lists: Vec::new(),
            vectors: Vec::new(),
            is_finalized: false,
            total_vectors_to_add: None,
            next_vec_id: 0,
        })
    }

    /// Create a new IVF index builder with storage.
    /// Create a new IVF index builder with storage.
    ///
    /// If an existing index file is found on disk, its vectors are loaded
    /// into the writer so that the next commit preserves them. This
    /// prevents data loss across multiple commit cycles.
    pub fn with_storage(
        index_config: IvfIndexConfig,
        writer_config: VectorIndexWriterConfig,
        path: impl Into<String>,
        storage: Arc<dyn Storage>,
    ) -> Result<Self> {
        let path = path.into();
        let file_name = format!("{}.ivf", path);
        if storage.file_exists(&file_name) {
            return Self::load(index_config, writer_config, storage, &path);
        }

        Ok(Self {
            index_config,
            writer_config,
            storage: Some(storage),
            path,
            centroids: Vec::new(),
            inverted_lists: Vec::new(),
            vectors: Vec::new(),
            is_finalized: false,
            total_vectors_to_add: None,
            next_vec_id: 0,
        })
    }

    /// Convert this writer into a doc-centric field writer adapter.
    pub fn into_field_writer(self, field_name: impl Into<String>) -> LegacyVectorFieldWriter<Self> {
        LegacyVectorFieldWriter::new(field_name, self)
    }

    /// Load an existing IVF index from storage.
    pub fn load(
        index_config: IvfIndexConfig,
        writer_config: VectorIndexWriterConfig,
        storage: Arc<dyn Storage>,
        path: &str,
    ) -> Result<Self> {
        use std::io::Read;

        // Open the index file
        let file_name = format!("{}.ivf", path);
        let mut input = storage.open_input(&file_name)?;

        // Read metadata
        let mut num_vectors_buf = [0u8; 4];
        input.read_exact(&mut num_vectors_buf)?;
        let num_vectors = u32::from_le_bytes(num_vectors_buf) as usize;

        let mut dimension_buf = [0u8; 4];
        input.read_exact(&mut dimension_buf)?;
        let dimension = u32::from_le_bytes(dimension_buf) as usize;

        let mut n_clusters_buf = [0u8; 4];
        input.read_exact(&mut n_clusters_buf)?;
        let n_clusters = u32::from_le_bytes(n_clusters_buf) as usize;

        let mut n_probe_buf = [0u8; 4];
        input.read_exact(&mut n_probe_buf)?;
        let _n_probe = u32::from_le_bytes(n_probe_buf) as usize;

        if dimension != index_config.dimension {
            return Err(LaurusError::InvalidOperation(format!(
                "Dimension mismatch: expected {}, found {}",
                index_config.dimension, dimension
            )));
        }

        // Read centroids
        let mut centroids = Vec::with_capacity(n_clusters);
        for _ in 0..n_clusters {
            let mut values = vec![0.0f32; dimension];
            for value in &mut values {
                let mut value_buf = [0u8; 4];
                input.read_exact(&mut value_buf)?;
                *value = f32::from_le_bytes(value_buf);
            }
            centroids.push(Vector::new(values));
        }

        // Read inverted lists
        let mut inverted_lists = vec![Vec::new(); n_clusters];
        for list in &mut inverted_lists {
            let mut list_size_buf = [0u8; 4];
            input.read_exact(&mut list_size_buf)?;
            let list_size = u32::from_le_bytes(list_size_buf) as usize;

            for _ in 0..list_size {
                let mut doc_id_buf = [0u8; 8];
                input.read_exact(&mut doc_id_buf)?;
                let doc_id = u64::from_le_bytes(doc_id_buf);

                // Read field name
                let mut field_name_len_buf = [0u8; 4];
                input.read_exact(&mut field_name_len_buf)?;
                let field_name_len = u32::from_le_bytes(field_name_len_buf) as usize;

                let mut field_name_buf = vec![0u8; field_name_len];
                input.read_exact(&mut field_name_buf)?;
                let field_name = String::from_utf8(field_name_buf).map_err(|e| {
                    LaurusError::InvalidOperation(format!("Invalid UTF-8 in field name: {}", e))
                })?;

                // Read vector data
                let mut values = vec![0.0f32; dimension];
                for value in &mut values {
                    let mut value_buf = [0u8; 4];
                    input.read_exact(&mut value_buf)?;
                    *value = f32::from_le_bytes(value_buf);
                }

                list.push((doc_id, field_name, Vector::new(values)));
            }
        }

        // Reconstruct vectors from inverted lists
        let mut vectors = Vec::with_capacity(num_vectors);
        for list in &inverted_lists {
            vectors.extend(list.iter().cloned());
        }

        // Calculate next_vec_id from loaded vectors
        let max_id = vectors.iter().map(|(id, _, _)| *id).max().unwrap_or(0);
        let next_vec_id = if num_vectors > 0 { max_id + 1 } else { 0 };

        Ok(Self {
            index_config,
            writer_config,
            storage: Some(storage),
            path: path.to_string(),

            centroids,
            inverted_lists,
            vectors,
            is_finalized: true,
            total_vectors_to_add: Some(num_vectors),
            next_vec_id,
        })
    }

    /// Set IVF-specific parameters.
    pub fn with_ivf_params(mut self, n_clusters: usize, n_probe: usize) -> Self {
        self.index_config.n_clusters = n_clusters;
        self.index_config.n_probe = n_probe;
        self
    }

    /// Set the expected total number of vectors (for progress tracking).
    pub fn set_expected_vector_count(&mut self, count: usize) {
        self.total_vectors_to_add = Some(count);
        // Adjust number of clusters based on dataset size
        self.index_config.n_clusters = Self::compute_default_clusters(count);
    }

    /// Compute default number of clusters based on dataset size.
    fn compute_default_clusters(n_vectors: usize) -> usize {
        // Rule of thumb: sqrt(n_vectors), with reasonable min/max bounds
        let clusters = (n_vectors as f64).sqrt() as usize;
        clusters.clamp(10, 10000)
    }

    /// Validate vectors before adding them.
    fn validate_vectors(&self, vectors: &[(u64, String, Vector)]) -> Result<()> {
        if vectors.is_empty() {
            return Ok(());
        }

        for (doc_id, _field_name, vector) in vectors {
            if vector.dimension() != self.index_config.dimension {
                return Err(LaurusError::InvalidOperation(format!(
                    "Vector {} has dimension {}, expected {}",
                    doc_id,
                    vector.dimension(),
                    self.index_config.dimension
                )));
            }

            if !vector.is_valid() {
                return Err(LaurusError::InvalidOperation(format!(
                    "Vector {doc_id} contains invalid values (NaN or infinity)"
                )));
            }
        }

        Ok(())
    }

    /// Normalize vectors if configured to do so.
    fn normalize_vectors(&self, vectors: &mut [(u64, String, Vector)]) {
        if !self.index_config.normalize_vectors {
            return;
        }

        if self.writer_config.parallel_build && vectors.len() > 100 {
            vectors.par_iter_mut().for_each(|(_, _, vector)| {
                vector.normalize();
            });
        } else {
            for (_, _, vector) in vectors {
                vector.normalize();
            }
        }
    }

    /// Train centroids using k-means clustering.
    fn train_centroids(&mut self) -> Result<()> {
        if self.vectors.is_empty() {
            return Err(LaurusError::InvalidOperation(
                "Cannot train centroids on empty vector set".to_string(),
            ));
        }

        if self.vectors.len() < self.index_config.n_clusters {
            return Err(LaurusError::InvalidOperation(format!(
                "Cannot create {} clusters from {} vectors",
                self.index_config.n_clusters,
                self.vectors.len() as u64
            )));
        }

        println!(
            "Training {} centroids using k-means...",
            self.index_config.n_clusters
        );

        // Initialize centroids with k-means++
        self.init_centroids_kmeans_plus_plus()?;

        // Run k-means iterations
        let max_iterations = 100;
        let convergence_threshold = 1e-6;

        for iteration in 0..max_iterations {
            let old_centroids = self.centroids.clone();

            // Assign vectors to clusters
            let assignments = self.assign_vectors_to_clusters();

            // Update centroids
            self.update_centroids(&assignments)?;

            // Check for convergence
            let convergence = self.compute_convergence(&old_centroids);
            if convergence < convergence_threshold {
                println!("K-means converged after {} iterations", iteration + 1);
                break;
            }
        }

        Ok(())
    }

    /// Initialize centroids using k-means++ algorithm.
    fn init_centroids_kmeans_plus_plus(&mut self) -> Result<()> {
        use rand::prelude::*;
        let mut rng = rand::rng();

        self.centroids.clear();

        // Choose first centroid randomly
        let first_idx = rng.random_range(0..self.vectors.len());
        self.centroids.push(self.vectors[first_idx].2.clone());

        // Choose remaining centroids with probability proportional to squared distance
        for _ in 1..self.index_config.n_clusters {
            let mut distances = Vec::with_capacity(self.vectors.len());
            let mut total_weight = 0.0;

            for (_, _, vector) in &self.vectors {
                let min_dist = self
                    .centroids
                    .iter()
                    .map(|centroid| {
                        self.index_config
                            .distance_metric
                            .distance(&vector.data, &centroid.data)
                            .unwrap_or(f32::INFINITY)
                    })
                    .fold(f32::INFINITY, f32::min);

                let weight = min_dist * min_dist;
                distances.push(weight);
                total_weight += weight;
            }

            if total_weight == 0.0 {
                // Fallback to random selection
                let idx = rng.random_range(0..self.vectors.len());
                self.centroids.push(self.vectors[idx].2.clone());
                continue;
            }

            // Select next centroid based on weighted probability
            let target = rng.random::<f32>() * total_weight;
            let mut cumsum = 0.0;
            let mut selected = false;

            for (i, &weight) in distances.iter().enumerate() {
                cumsum += weight;
                if cumsum >= target {
                    self.centroids.push(self.vectors[i].2.clone());
                    selected = true;
                    break;
                }
            }

            // Fallback: floating-point precision may prevent cumsum from reaching target
            if !selected {
                self.centroids
                    .push(self.vectors[self.vectors.len() - 1].2.clone());
            }
        }

        Ok(())
    }

    /// Assign each vector to its nearest cluster.
    fn assign_vectors_to_clusters(&self) -> Vec<usize> {
        if self.writer_config.parallel_build && self.vectors.len() as u64 > 1000 {
            self.vectors
                .par_iter()
                .map(|(_, _, vector)| self.find_nearest_centroid(vector))
                .collect()
        } else {
            self.vectors
                .iter()
                .map(|(_, _, vector)| self.find_nearest_centroid(vector))
                .collect()
        }
    }

    /// Find the index of the nearest centroid for a vector.
    fn find_nearest_centroid(&self, vector: &Vector) -> usize {
        let mut best_cluster = 0;
        let mut best_distance = f32::INFINITY;

        for (i, centroid) in self.centroids.iter().enumerate() {
            if let Ok(distance) = self
                .index_config
                .distance_metric
                .distance(&vector.data, &centroid.data)
                && distance < best_distance
            {
                best_distance = distance;
                best_cluster = i;
            }
        }

        best_cluster
    }

    /// Update centroids based on cluster assignments.
    fn update_centroids(&mut self, assignments: &[usize]) -> Result<()> {
        let mut cluster_sums =
            vec![vec![0.0; self.index_config.dimension]; self.index_config.n_clusters];
        let mut cluster_counts = vec![0; self.index_config.n_clusters];

        // Sum vectors in each cluster
        for (i, (_, _, vector)) in self.vectors.iter().enumerate() {
            let cluster = assignments[i];
            cluster_counts[cluster] += 1;

            for (j, &value) in vector.data.iter().enumerate() {
                cluster_sums[cluster][j] += value;
            }
        }

        // Compute new centroids as averages
        for (i, (sum, count)) in cluster_sums.iter().zip(cluster_counts.iter()).enumerate() {
            if *count == 0 {
                // Keep the old centroid if no vectors assigned
                continue;
            }

            let centroid_data: Vec<f32> = sum.iter().map(|&s| s / *count as f32).collect();

            self.centroids[i] = Vector::new(centroid_data);
        }

        Ok(())
    }

    /// Compute convergence metric between old and new centroids.
    fn compute_convergence(&self, old_centroids: &[Vector]) -> f32 {
        if old_centroids.len() != self.centroids.len() {
            return f32::INFINITY;
        }

        let mut total_movement = 0.0;

        for (old, new) in old_centroids.iter().zip(self.centroids.iter()) {
            if let Ok(distance) = self
                .index_config
                .distance_metric
                .distance(&old.data, &new.data)
            {
                total_movement += distance;
            }
        }

        total_movement / self.centroids.len() as f32
    }

    /// Build inverted lists by assigning vectors to clusters.
    fn build_inverted_lists(&mut self) -> Result<()> {
        self.inverted_lists = vec![Vec::new(); self.index_config.n_clusters];

        for (doc_id, field_name, vector) in &self.vectors {
            let cluster = self.find_nearest_centroid(vector);
            self.inverted_lists[cluster].push((*doc_id, field_name.clone(), vector.clone()));
        }

        // Sort each inverted list by document ID
        if self.writer_config.parallel_build {
            self.inverted_lists.par_iter_mut().for_each(|list| {
                list.sort_by_key(|(doc_id, _, _)| *doc_id);
            });
        } else {
            for list in &mut self.inverted_lists {
                list.sort_by_key(|(doc_id, _, _)| *doc_id);
            }
        }

        Ok(())
    }

    /// Check for memory limits.
    fn check_memory_limit(&self) -> Result<()> {
        if let Some(limit) = self.writer_config.memory_limit {
            let current_usage = self.estimated_memory_usage();
            if current_usage > limit {
                return Err(LaurusError::ResourceExhausted(format!(
                    "Memory usage {current_usage} bytes exceeds limit {limit} bytes"
                )));
            }
        }
        Ok(())
    }

    /// Get the stored vectors (for testing/debugging).
    pub fn vectors(&self) -> &[(u64, String, Vector)] {
        &self.vectors
    }

    /// Get IVF parameters.
    pub fn ivf_params(&self) -> (usize, usize) {
        (self.index_config.n_clusters, self.index_config.n_probe)
    }

    /// Get centroids.
    pub fn centroids(&self) -> &[Vector] {
        &self.centroids
    }

    /// Get inverted lists.
    pub fn inverted_lists(&self) -> &[Vec<(u64, String, Vector)>] {
        &self.inverted_lists
    }
}

type SplitClusterResult = (
    Vector,
    Vec<(u64, String, Vector)>,
    Vector,
    Vec<(u64, String, Vector)>,
);

/// Statistics for a single IVF cluster.
#[derive(Debug, Clone, Serialize, Deserialize)]
pub struct ClusterStats {
    pub cluster_id: usize,
    pub count: usize,
    pub avg_distance: f32,
}

impl IvfIndexWriter {
    /// Get statistics for each cluster in the index.
    pub fn get_cluster_stats(&self) -> Vec<ClusterStats> {
        if !self.is_finalized || self.centroids.is_empty() {
            return Vec::new();
        }

        let mut stats = Vec::with_capacity(self.centroids.len());

        for (i, (centroid, list)) in self
            .centroids
            .iter()
            .zip(self.inverted_lists.iter())
            .enumerate()
        {
            let count = list.len();
            let total_dist: f32 = list
                .iter()
                .map(|(_, _, vec)| {
                    self.index_config
                        .distance_metric
                        .distance(&vec.data, &centroid.data)
                        .unwrap_or(0.0)
                })
                .sum();

            stats.push(ClusterStats {
                cluster_id: i,
                count,
                avg_distance: if count > 0 {
                    total_dist / count as f32
                } else {
                    0.0
                },
            });
        }

        stats
    }

    /// Merge sparse clusters into their nearest neighbors.
    pub fn merge_sparse_clusters(&mut self, threshold: usize) -> Result<usize> {
        if !self.is_finalized || self.centroids.is_empty() {
            return Ok(0);
        }

        let stats = self.get_cluster_stats();
        let sparse_indices: Vec<usize> = stats
            .iter()
            .filter(|s| s.count < threshold)
            .map(|s| s.cluster_id)
            .collect();

        if sparse_indices.is_empty() || sparse_indices.len() == self.centroids.len() {
            return Ok(0);
        }

        let non_sparse_indices: Vec<usize> = stats
            .iter()
            .filter(|s| s.count >= threshold)
            .map(|s| s.cluster_id)
            .collect();

        let merged_count = sparse_indices.len();
        let mut moves = Vec::new();

        for &sparse_idx in &sparse_indices {
            let sparse_centroid = &self.centroids[sparse_idx];
            let mut best_target = non_sparse_indices[0];
            let mut best_dist = f32::INFINITY;

            for &target_idx in &non_sparse_indices {
                if let Ok(dist) = self
                    .index_config
                    .distance_metric
                    .distance(&sparse_centroid.data, &self.centroids[target_idx].data)
                    && dist < best_dist
                {
                    best_dist = dist;
                    best_target = target_idx;
                }
            }
            moves.push((sparse_idx, best_target));
        }

        // Apply moves
        for (sparse_idx, target_idx) in moves {
            let mut vectors_to_move = std::mem::take(&mut self.inverted_lists[sparse_idx]);
            self.inverted_lists[target_idx].append(&mut vectors_to_move);
        }

        // Rebuild centroids and inverted lists
        let mut new_centroids = Vec::new();
        let mut new_inverted_lists = Vec::new();

        for i in 0..self.centroids.len() {
            if !sparse_indices.contains(&i) {
                new_centroids.push(self.centroids[i].clone());
                new_inverted_lists.push(std::mem::take(&mut self.inverted_lists[i]));
            }
        }

        self.centroids = new_centroids;
        self.inverted_lists = new_inverted_lists;
        self.index_config.n_clusters = self.centroids.len();

        // Update centroids for the merged clusters (re-average)
        for (i, list) in self.inverted_lists.iter().enumerate() {
            if !list.is_empty() {
                let dim = self.index_config.dimension;
                let mut sum = vec![0.0; dim];
                for (_, _, vec) in list {
                    for (j, &val) in vec.data.iter().enumerate() {
                        sum[j] += val;
                    }
                }
                let new_data: Vec<f32> = sum.iter().map(|&s| s / list.len() as f32).collect();
                self.centroids[i] = Vector::new(new_data);
            }
        }

        Ok(merged_count)
    }

    /// Split dense clusters into multiple clusters using K-means (k=2).
    pub fn split_dense_clusters(&mut self, threshold: usize) -> Result<usize> {
        if !self.is_finalized || self.centroids.is_empty() {
            return Ok(0);
        }

        let stats = self.get_cluster_stats();
        let dense_indices: Vec<usize> = stats
            .iter()
            .filter(|s| s.count > threshold)
            .map(|s| s.cluster_id)
            .collect();

        if dense_indices.is_empty() {
            return Ok(0);
        }

        let mut additional_clusters = 0;
        let mut new_centroids = Vec::new();
        let mut new_inverted_lists = Vec::new();

        for i in 0..self.centroids.len() {
            if dense_indices.contains(&i) {
                let list = std::mem::take(&mut self.inverted_lists[i]);
                if list.len() < 2 {
                    // Cannot split
                    new_centroids.push(self.centroids[i].clone());
                    new_inverted_lists.push(list);
                    continue;
                }

                // Perform k=2 split
                let (c1, l1, c2, l2) = self.split_cluster_kmeans_k2(list)?;
                new_centroids.push(c1);
                new_inverted_lists.push(l1);
                new_centroids.push(c2);
                new_inverted_lists.push(l2);
                additional_clusters += 1;
            } else {
                new_centroids.push(self.centroids[i].clone());
                new_inverted_lists.push(std::mem::take(&mut self.inverted_lists[i]));
            }
        }

        self.centroids = new_centroids;
        self.inverted_lists = new_inverted_lists;
        self.index_config.n_clusters = self.centroids.len();

        Ok(additional_clusters)
    }

    /// Split a cluster into two using K-means.
    fn split_cluster_kmeans_k2(
        &self,
        vectors: Vec<(u64, String, Vector)>,
    ) -> Result<SplitClusterResult> {
        use rand::prelude::*;
        let mut rng = rand::rng();

        // Pick two initial centroids
        let idx1 = rng.random_range(0..vectors.len());
        let mut idx2 = rng.random_range(0..vectors.len());
        while idx1 == idx2 && vectors.len() > 1 {
            idx2 = rng.random_range(0..vectors.len());
        }

        let mut c1 = vectors[idx1].2.clone();
        let mut c2 = vectors[idx2].2.clone();

        let mut l1 = Vec::new();
        let mut l2 = Vec::new();

        // Simple 10 iterations of K-means
        for _ in 0..10 {
            l1.clear();
            l2.clear();

            for (_, _, vec) in &vectors {
                let d1 = self
                    .index_config
                    .distance_metric
                    .distance(&vec.data, &c1.data)
                    .unwrap_or(f32::INFINITY);
                let d2 = self
                    .index_config
                    .distance_metric
                    .distance(&vec.data, &c2.data)
                    .unwrap_or(f32::INFINITY);

                if d1 < d2 {
                    l1.push((0, String::new(), vec.clone())); // We'll restore the actual IDs later
                } else {
                    l2.push((0, String::new(), vec.clone()));
                }
            }

            // Update centroids
            if !l1.is_empty() {
                c1 = self.calculate_mean_vector(&l1);
            }
            if !l2.is_empty() {
                c2 = self.calculate_mean_vector(&l2);
            }
        }

        // Final assignment with original vectors to preserve IDs
        l1.clear();
        l2.clear();
        for item in vectors {
            let d1 = self
                .index_config
                .distance_metric
                .distance(&item.2.data, &c1.data)
                .unwrap_or(f32::INFINITY);
            let d2 = self
                .index_config
                .distance_metric
                .distance(&item.2.data, &c2.data)
                .unwrap_or(f32::INFINITY);

            if d1 < d2 {
                l1.push(item);
            } else {
                l2.push(item);
            }
        }

        Ok((c1, l1, c2, l2))
    }

    /// Calculate the mean vector for a list of vectors.
    fn calculate_mean_vector(&self, list: &[(u64, String, Vector)]) -> Vector {
        let dim = self.index_config.dimension;
        if list.is_empty() {
            return Vector::new(vec![0.0; dim]);
        }
        let mut sum = vec![0.0; dim];
        for (_, _, vec) in list {
            for (j, &val) in vec.data.iter().enumerate() {
                sum[j] += val;
            }
        }
        let data: Vec<f32> = sum.iter().map(|&s| s / list.len() as f32).collect();
        Vector::new(data)
    }
    // optimize method moved to VectorIndexWriter trait implementation
}

#[async_trait::async_trait]
impl VectorIndexWriter for IvfIndexWriter {
    fn next_vector_id(&self) -> u64 {
        self.next_vec_id
    }

    fn build(&mut self, mut vectors: Vec<(u64, String, Vector)>) -> Result<()> {
        if self.is_finalized {
            self.is_finalized = false;
        }

        self.validate_vectors(&vectors)?;
        self.normalize_vectors(&mut vectors);

        // Update next_vec_id
        if let Some(max_id) = vectors.iter().map(|(id, _, _)| *id).max()
            && max_id >= self.next_vec_id
        {
            self.next_vec_id = max_id + 1;
        }

        self.vectors = vectors;
        self.total_vectors_to_add = Some(self.vectors.len());

        // Adjust cluster count if needed
        if self.vectors.len() < self.index_config.n_clusters {
            self.index_config.n_clusters = self.vectors.len().max(1);
        }

        self.check_memory_limit()?;
        Ok(())
    }

    fn add_vectors(&mut self, mut vectors: Vec<(u64, String, Vector)>) -> Result<()> {
        if self.is_finalized {
            self.is_finalized = false;
        }

        self.validate_vectors(&vectors)?;
        self.normalize_vectors(&mut vectors);

        // Update next_vec_id
        if let Some(max_id) = vectors.iter().map(|(id, _, _)| *id).max()
            && max_id >= self.next_vec_id
        {
            self.next_vec_id = max_id + 1;
        }

        self.vectors.extend(vectors);
        self.check_memory_limit()?;
        Ok(())
    }

    fn finalize(&mut self) -> Result<()> {
        if self.is_finalized {
            return Ok(());
        }

        if self.vectors.is_empty() {
            return Err(LaurusError::InvalidOperation(
                "Cannot finalize empty index".to_string(),
            ));
        }

        // Train centroids using k-means
        self.train_centroids()?;

        // Build inverted lists
        self.build_inverted_lists()?;

        self.is_finalized = true;
        Ok(())
    }

    fn progress(&self) -> f32 {
        if let Some(total) = self.total_vectors_to_add {
            if total == 0 {
                if self.is_finalized { 1.0 } else { 0.0 }
            } else {
                let current = self.vectors.len() as u64 as f32;
                let progress = current / total as f32;
                if self.is_finalized {
                    1.0
                } else {
                    progress.min(0.99) // Never report 100% until finalized
                }
            }
        } else if self.is_finalized {
            1.0
        } else {
            0.0
        }
    }

    fn estimated_memory_usage(&self) -> usize {
        let vector_memory = self.vectors.len()
            * (
                8 + // doc_id
            self.index_config.dimension * 4 + // f32 values
            std::mem::size_of::<Vector>()
                // Vector struct overhead
            );

        // Centroid memory
        let centroid_memory = self.centroids.len()
            * (self.index_config.dimension * 4 + std::mem::size_of::<Vector>());

        // Inverted list overhead (pointers and metadata)
        let inverted_list_memory =
            self.inverted_lists.len() * (std::mem::size_of::<Vec<(u64, String, Vector)>>() + 64); // Rough estimate

        let metadata_memory = self.vectors.len() * 64;

        vector_memory + centroid_memory + inverted_list_memory + metadata_memory
    }

    fn vectors(&self) -> &[(u64, String, Vector)] {
        &self.vectors
    }

    fn write(&self) -> Result<()> {
        use std::io::Write;

        if !self.is_finalized {
            return Err(LaurusError::InvalidOperation(
                "Index must be finalized before writing".to_string(),
            ));
        }

        let storage = self
            .storage
            .as_ref()
            .ok_or_else(|| LaurusError::InvalidOperation("No storage configured".to_string()))?;

        // Create the index file
        let file_name = format!("{}.ivf", self.path);
        let mut output = storage.create_output(&file_name)?;

        // Write metadata
        let vector_count: u32 = self.vectors.len().try_into().map_err(|_| {
            LaurusError::InvalidOperation(format!(
                "Vector count {} exceeds u32::MAX",
                self.vectors.len()
            ))
        })?;
        output.write_all(&vector_count.to_le_bytes())?;
        output.write_all(&(self.index_config.dimension as u32).to_le_bytes())?;
        output.write_all(&(self.index_config.n_clusters as u32).to_le_bytes())?;
        output.write_all(&(self.index_config.n_probe as u32).to_le_bytes())?;

        // Write centroids
        for centroid in &self.centroids {
            for value in &centroid.data {
                output.write_all(&value.to_le_bytes())?;
            }
        }

        // Write inverted lists
        for list in &self.inverted_lists {
            output.write_all(&(list.len() as u32).to_le_bytes())?;
            for (doc_id, field_name, vector) in list {
                output.write_all(&doc_id.to_le_bytes())?;

                // Write field name length and field name
                let field_name_bytes = field_name.as_bytes();
                output.write_all(&(field_name_bytes.len() as u32).to_le_bytes())?;
                output.write_all(field_name_bytes)?;

                // Write vector data
                for value in &vector.data {
                    output.write_all(&value.to_le_bytes())?;
                }
            }
        }

        output.flush()?;
        Ok(())
    }

    fn has_storage(&self) -> bool {
        self.storage.is_some()
    }

    fn delete_document(&mut self, doc_id: u64) -> Result<()> {
        if self.is_finalized {
            self.is_finalized = false;
        }
        self.vectors.retain(|(id, _, _)| *id != doc_id);
        Ok(())
    }

    fn delete_documents(&mut self, _field: &str, _value: &str) -> Result<usize> {
        if self.is_finalized {
            return Err(LaurusError::InvalidOperation(
                "Cannot delete documents from finalized index".to_string(),
            ));
        }

        // Vectors no longer carry metadata; field-based deletion is not supported.
        // Use delete_document(doc_id) for document-level deletion.
        Ok(0)
    }

    fn rollback(&mut self) -> Result<()> {
        self.vectors.clear();
        self.is_finalized = false;
        self.next_vec_id = 0;
        Ok(())
    }

    fn pending_docs(&self) -> u64 {
        if self.is_finalized {
            0
        } else {
            self.vectors.len() as u64
        }
    }

    fn close(&mut self) -> Result<()> {
        self.vectors.clear();
        self.is_finalized = true;
        Ok(())
    }

    fn is_closed(&self) -> bool {
        self.is_finalized && self.vectors.is_empty()
    }

    fn optimize(&mut self) -> Result<()> {
        if !self.is_finalized {
            return Err(LaurusError::InvalidOperation(
                "Index must be finalized before optimization".to_string(),
            ));
        }

        println!("Optimizing IVF index...");

        // Rebalance clusters if they're too uneven
        let total_vectors = self.vectors.len();
        let avg_vectors_per_cluster = total_vectors / self.index_config.n_clusters.max(1);
        let sparse_threshold = avg_vectors_per_cluster / 4;
        let dense_threshold = avg_vectors_per_cluster * 4;

        let merged = self.merge_sparse_clusters(sparse_threshold.max(2))?;
        if merged > 0 {
            println!("Merged {} sparse clusters", merged);
        }

        let split = self.split_dense_clusters(dense_threshold)?;
        if split > 0 {
            println!("Split {} dense clusters", split);
        }

        // For now, just compact memory
        self.vectors.shrink_to_fit();
        self.centroids.shrink_to_fit();
        for list in &mut self.inverted_lists {
            list.shrink_to_fit();
        }

        Ok(())
    }

    fn build_reader(&self) -> Result<Arc<dyn crate::vector::reader::VectorIndexReader>> {
        use crate::vector::index::ivf::reader::IvfIndexReader;

        let storage = self.storage.as_ref().ok_or_else(|| {
            LaurusError::InvalidOperation("Cannot build reader: storage not configured".to_string())
        })?;

        let reader = IvfIndexReader::load(
            storage.as_ref(),
            &self.path,
            self.index_config.distance_metric,
        )?;

        Ok(Arc::new(reader))
    }
}