1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
//! Qwen3.5 model type, safetensors loader, accessors, LoRA setter, train-backward weight accessors, and layer weight statistics.
use super::loading::{load_weights, validate_required_tensor_names};
use super::weights::{AttentionWeights, FeedForwardWeights, ModelWeights};
use crate::error::InferenceError;
use crate::model::qwen35_config::Qwen35Config;
use crate::rope::RopeTable;
use crate::tokenizer::bpe::BpeTokenizer;
use crate::weights::{SafetensorsFile, ShardedSafetensors, TensorSource};
use std::path::Path;
/// **Unstable**: Qwen3.5-2B text generation model; Metal GPU path under development.
pub struct Qwen35Model {
pub(crate) config: Qwen35Config,
pub(crate) weights: ModelWeights,
pub(crate) tokenizer: BpeTokenizer,
pub(crate) rope: RopeTable,
/// Optional LoRA adapter hook. Default: NoopLoraHook (no adapter).
pub(crate) lora: Box<dyn crate::lora_hook::LoraHook>,
}
impl Qwen35Model {
/// **Unstable**: load Qwen3.5-2B or Qwen3.6 from a local safetensors directory.
///
/// Required names are preflighted, then each tensor's own declared
/// payload is decoded and finite-value-checked at the shared ingress
/// seam (`weights::ingress::validate_ingested_tensor`) while owned
/// weights are assembled; a failure there drops the local assembly state
/// and returns an error without exposing a partially built model.
///
/// Every required tensor — embeddings, the LM head, the final norm,
/// per-layer input/post-attention norms, dense FFN weights, full
/// attention Q/K/V/O and their norms, the GDN projection and decay
/// tensors, and the MoE router/expert/shared-expert tensors — is also
/// checked against a config-derived expected shape at assembly
/// (`load_owned_tensor_checked`), so a finite but undersized or
/// otherwise config-incompatible tensor is rejected here rather than
/// reaching a forward pass built for a different shape. A checkpoint
/// whose tensor shapes are incompatible with the config returns
/// `Err(InferenceError::ShapeMismatch)` instead of constructing a model.
pub fn from_safetensors(path: &Path) -> Result<Self, InferenceError> {
let model_path = path.join("model.safetensors");
let index_path = path.join("model.safetensors.index.json");
let mut source: Box<dyn TensorSource> = if model_path.exists() {
Box::new(SafetensorsFile::open(&model_path)?)
} else if index_path.exists() {
Box::new(ShardedSafetensors::open_index(&index_path)?)
} else {
return Err(InferenceError::ModelNotFound(format!(
"missing model.safetensors or model.safetensors.index.json in {}",
path.display()
)));
};
// CLASS C ingress: `from_model_dir_validated` runs `Qwen35Config::validate` before
// this directory's tensors are ever touched, and `validate_required_tensor_names` /
// `load_weights` both require the resulting `ValidatedQwen35Config` -- an
// unvalidated config cannot reach either. See the CLASS C ingress table in the PR
// body.
let validated_config = Qwen35Config::from_model_dir_validated(path)?;
validate_required_tensor_names(source.as_mut(), &validated_config)?;
let weights = load_weights(source.as_mut(), &validated_config)?;
let config = validated_config.into_inner();
let tokenizer_path = path.join("tokenizer.json");
let tokenizer = BpeTokenizer::from_tokenizer_json(&tokenizer_path)?;
let rope_dim = config.rope_dim();
let rope_max = config.max_position_embeddings.min(8192);
// Qwen3.5 uses `theta^(-2i/rope_dim)` (not head_dim) — empirically
// verified by PPL regression when using head_dim. The partial-RoPE
// frequency spectrum is compressed into the first `rope_dim` dimensions
// rather than sliced from a head_dim-wide spectrum.
let rope = RopeTable::new(rope_dim, rope_max, config.rope_theta);
Ok(Self {
config,
weights,
tokenizer,
rope,
lora: Box::new(crate::lora_hook::NoopLoraHook),
})
}
/// **Unstable**: attach a LoRA adapter hook; hook trait API may change.
///
/// Calls [`LoraHook::validate_against`](crate::lora_hook::LoraHook::validate_against)
/// against this model's own config before installing the hook, so a
/// rank/dimension-mismatched adapter is rejected up front instead of
/// silently corrupting projection outputs (or panicking past a
/// `debug_assert` in a release build). The previously-installed hook
/// stays active if validation fails.
///
/// # Errors
///
/// Returns `Err` (via [`InferenceError::InvalidInput`]) when the hook's
/// own `validate_against` reports a rank, dimension, or layer-index
/// mismatch against this model's geometry.
pub fn set_lora(
&mut self,
hook: Box<dyn crate::lora_hook::LoraHook>,
) -> Result<(), InferenceError> {
hook.validate_against(&self.config)
.map_err(InferenceError::InvalidInput)?;
self.lora = hook;
Ok(())
}
/// **Unstable**: access raw model weights.
pub fn weights(&self) -> &ModelWeights {
&self.weights
}
/// **Unstable**: access Qwen3.5 configuration.
pub fn config(&self) -> &Qwen35Config {
&self.config
}
/// **Unstable**: override the post-load model's configured EOS token id.
///
/// CLASS C ingress: replaces the former `config_mut(&mut self) -> &mut Qwen35Config`,
/// which handed out an unrestricted `&mut` onto a config that had already passed
/// [`Qwen35Config::validate`] -- every call site in this crate (grepped before this
/// change) only ever touched `eos_token_id`, so this checked setter covers the real
/// need without reopening a path for a caller to mutate an allocation-driving field
/// (`hidden_size`, `vocab_size`, the GDN dims, ...) post-validation. `eos_token_id`
/// itself drives no allocation or indexing -- it is only ever compared against a
/// generated token id -- so no re-validation is required here. See the CLASS C
/// ingress table in the PR body.
///
/// Established idiom already used throughout this crate's own test suite (e.g.
/// `model.set_eos_token_id(u32::MAX)`) to push the model's configured EOS token id out
/// of the reachable vocab range, which `should_stop_token` (the single shared stop
/// predicate every CPU/Metal decode loop calls) then never matches -- see
/// `qwen35_generate --emit-phase-events` (PR #882), which combines this with
/// `GenerateConfig::stop_token_ids: vec![]` (already public) to force continuation to
/// the exact requested token count for a benchmark trial.
pub fn set_eos_token_id(&mut self, eos_token_id: u32) {
self.config.eos_token_id = eos_token_id;
}
/// **Unstable**: access the BPE tokenizer.
pub fn tokenizer(&self) -> &BpeTokenizer {
&self.tokenizer
}
/// **Unstable**: maximum sequence length the precomputed RoPE table can
/// serve. `forward_step(token, position, ..)` panics if `position` is at
/// or above this value, so callers driving long-context evaluation must
/// keep their per-window position strictly below it.
pub fn max_context(&self) -> usize {
self.rope.max_positions()
}
/// **Unstable**: access raw embedding weights for debugging.
pub fn embed_weights(&self) -> &[f32] {
&self.weights.embed_tokens
}
/// **Unstable (train-backward)**: Return weight slices for a GQA layer that the
/// backward trainer needs to compute gradients.
///
/// Returns `None` if the requested layer is not a full-attention (GQA) layer.
/// All returned slices are views into the model weight storage; their lifetime
/// is tied to `&self`.
///
/// Shapes for Qwen3.5-0.8B (24 layers, 8 Q-heads, 2 KV-heads, head_dim=256):
/// lm_head: [vocab, hidden]
/// final_norm: [hidden]
/// embed: [vocab, hidden]
/// q_proj: [2*q_dim, hidden]
/// k_proj: [kv_dim, hidden]
/// v_proj: [kv_dim, hidden]
/// o_proj: [hidden, q_dim]
/// q_norm: [head_dim]
/// k_norm: [head_dim]
/// pre_attn_norm: [hidden] (input_layernorm)
/// post_attn_norm: [hidden] (post_attention_layernorm)
/// gate_proj: [inter, hidden]
/// up_proj: [inter, hidden]
/// down_proj: [hidden, inter]
#[cfg(feature = "train-backward")]
#[allow(clippy::type_complexity)]
pub fn gqa_layer_weights(
&self,
layer: usize,
) -> Option<(
&[f32], // q_proj
&[f32], // k_proj
&[f32], // v_proj
&[f32], // o_proj
&[f32], // q_norm
&[f32], // k_norm
&[f32], // pre_attn_norm
&[f32], // post_attn_norm
&[f32], // gate_proj
&[f32], // up_proj
&[f32], // down_proj
)> {
let (attn, common) = &self.weights.layers[layer];
let full = match attn {
AttentionWeights::Full(w) => w,
AttentionWeights::Linear(_) => return None,
};
let dense = match &common.ffn {
FeedForwardWeights::Dense(d) => d,
FeedForwardWeights::Moe(_) => return None,
};
Some((
&full.q_proj,
&full.k_proj,
&full.v_proj,
&full.o_proj,
&full.q_norm,
&full.k_norm,
&common.input_layernorm,
&common.post_attention_layernorm,
&dense.gate_proj,
&dense.up_proj,
&dense.down_proj,
))
}
/// **Unstable (train-backward)**: Return GDN (linear-attention) layer weights
/// plus the layer's norm + Dense-FFN weights.
///
/// Returns `None` if the layer is not a GatedDeltaNet layer or its FFN is not
/// Dense. Tuple is `(gdn_mixer, input_layernorm, post_attention_layernorm,
/// gate_proj, up_proj, down_proj)` — the GDN analogue of [`Self::gqa_layer_weights`].
/// `gdn_mixer` is the frozen linear-attention block; `input_layernorm` is the
/// pre-mixer shifted RMSNorm gamma. Used by the GDN differential test and the
/// full-depth backward tape (`gdn_backward` for dx through frozen GDN layers,
/// plus the layer's own FFN block).
#[cfg(feature = "train-backward")]
#[allow(clippy::type_complexity)]
pub fn gdn_layer_weights(
&self,
layer: usize,
) -> Option<(
&crate::attention::gdn::GatedDeltaNetWeights,
&[f32], // input_layernorm
&[f32], // post_attention_layernorm
&[f32], // gate_proj
&[f32], // up_proj
&[f32], // down_proj
)> {
let (attn, common) = &self.weights.layers[layer];
let gdn = match attn {
AttentionWeights::Linear(w) => w,
AttentionWeights::Full(_) => return None,
};
let dense = match &common.ffn {
FeedForwardWeights::Dense(d) => d,
FeedForwardWeights::Moe(_) => return None,
};
Some((
gdn,
&common.input_layernorm,
&common.post_attention_layernorm,
&dense.gate_proj,
&dense.up_proj,
&dense.down_proj,
))
}
/// **Unstable (train-backward)**: Number of layers actually present in the
/// loaded weight storage.
///
/// [`Self::config_mut`] allows a caller to change `config.num_hidden_layers`
/// after load, independently of the weights this model was loaded with.
/// Callers deriving a layer range from `config().num_hidden_layers` must
/// check it against this value first — indexing past it inside
/// [`Self::gqa_layer_weights`]/[`Self::gdn_layer_weights`] panics rather
/// than returning `None`.
#[cfg(feature = "train-backward")]
pub fn loaded_layer_count(&self) -> usize {
self.weights.layers.len()
}
/// **Unstable (train-backward)**: Return lm_head, final_norm, and embed slices.
#[cfg(feature = "train-backward")]
pub fn head_weights(&self) -> (&[f32], &[f32], &[f32]) {
(
self.weights.logits_weight(),
&self.weights.final_norm,
&self.weights.embed_tokens,
)
}
/// **Unstable**: diagnostic weight statistics for a layer.
pub fn layer_weight_stats(&self, layer: usize) -> Vec<(String, f32, f32)> {
fn stats(name: &str, data: &[f32]) -> (String, f32, f32) {
let n = data.len() as f32;
let mean = data.iter().sum::<f32>() / n;
let std = (data.iter().map(|x| (x - mean).powi(2)).sum::<f32>() / n).sqrt();
(name.to_string(), mean, std)
}
let (attn, common) = &self.weights.layers[layer];
let mut v = vec![stats("input_layernorm", &common.input_layernorm)];
match &common.ffn {
FeedForwardWeights::Dense(dense) => {
v.push(stats("gate_proj", &dense.gate_proj));
}
FeedForwardWeights::Moe(moe) => {
v.push(stats("router_gate", &moe.router.gate));
}
}
match attn {
AttentionWeights::Linear(w) => {
v.push(stats("in_proj_qkv", &w.in_proj_qkv));
v.push(stats("in_proj_z", &w.in_proj_z));
v.push(stats("a_log", &w.a_log));
v.push(stats("dt_bias", &w.dt_bias));
v.push(stats("conv1d", &w.conv1d_weight));
v.push(stats("norm", &w.norm_weight));
}
AttentionWeights::Full(w) => {
v.push(stats("q_proj", &w.q_proj));
v.push(stats("k_proj", &w.k_proj));
v.push(stats("o_proj", &w.o_proj));
}
}
v
}
}