laser-dac 0.13.1

Unified laser DAC abstraction supporting multiple protocols
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
//! LaserCube network backend integration.

use crate::backend::{DacBackend, FifoBackend, WriteOutcome};
use crate::buffer_estimate::BufferEstimator;
use crate::device::{DacCapabilities, DacType};
use crate::error::{Error, Result};
use crate::point::LaserPoint;

use super::diagnostics::LaserCubeNetworkDiagnostics;
use super::profiles::ConnectionProfile;
use super::protocol::{Point, CMD_PORT, DATA_PORT, DEFAULT_BUFFER_CAPACITY};
use super::transport::{AddressedDevice, SharedTransportState, TransportHandle};

pub struct LaserCubeNetworkBackend {
    addressed: AddressedDevice,
    transport: Option<TransportHandle>,
    caps: DacCapabilities,
    point_buffer: Vec<Point>,
    fallback_estimator: SharedTransportState,
}

impl LaserCubeNetworkBackend {
    pub(crate) fn new(addressed: AddressedDevice) -> Self {
        let caps = super::capabilities_for_status(addressed.profile, &addressed.status);
        Self {
            fallback_estimator: SharedTransportState::disconnected(addressed.profile),
            addressed,
            transport: None,
            caps,
            point_buffer: Vec::new(),
        }
    }

    pub fn diagnostics(&self) -> Option<LaserCubeNetworkDiagnostics> {
        self.transport.as_ref().map(|t| t.state().diagnostics())
    }
}

impl DacBackend for LaserCubeNetworkBackend {
    fn dac_type(&self) -> DacType {
        DacType::LaserCubeNetwork
    }

    fn caps(&self) -> &DacCapabilities {
        &self.caps
    }

    fn connect(&mut self) -> Result<()> {
        // Reuse the existing transport only if it is still usable; otherwise tear
        // it down and rebuild so a stale/dead transport is not silently kept.
        if let Some(existing) = &self.transport {
            if existing.is_usable() {
                return Ok(());
            }
        }
        if let Some(mut stale) = self.transport.take() {
            stale.shutdown();
        }
        let transport = TransportHandle::connect(self.addressed.clone()).map_err(Error::backend)?;
        self.transport = Some(transport);
        Ok(())
    }

    fn disconnect(&mut self) -> Result<()> {
        if let Some(mut transport) = self.transport.take() {
            transport.shutdown();
        }
        Ok(())
    }

    fn is_connected(&self) -> bool {
        self.transport.as_ref().is_some_and(|t| t.is_usable())
    }

    fn stop(&mut self) -> Result<()> {
        if let Some(transport) = &self.transport {
            transport.stop_output().map_err(Error::backend)?;
        }
        Ok(())
    }

    fn set_shutter(&mut self, open: bool) -> Result<()> {
        if let Some(transport) = &self.transport {
            transport.set_output(open).map_err(Error::backend)?;
        }
        Ok(())
    }
}

impl FifoBackend for LaserCubeNetworkBackend {
    fn try_write_points(&mut self, pps: u32, points: &[LaserPoint]) -> Result<WriteOutcome> {
        let transport = self
            .transport
            .as_ref()
            .ok_or_else(|| Error::disconnected("LaserCube network backend is not connected"))?;
        if !transport.is_usable() {
            return Err(Error::disconnected(
                "LaserCube network communication timed out",
            ));
        }

        self.point_buffer.clear();
        self.point_buffer.extend(points.iter().map(Point::from));

        // Hand the buffer to the transport by move instead of cloning it.
        match transport.enqueue(pps, std::mem::take(&mut self.point_buffer)) {
            Ok(()) => Ok(WriteOutcome::Written),
            Err(super::error::CommunicationError::QueueFull) => Ok(WriteOutcome::WouldBlock),
            Err(err) => Err(Error::backend(err)),
        }
    }

    fn estimator(&self) -> &dyn BufferEstimator {
        match &self.transport {
            Some(t) => t.state(),
            None => &self.fallback_estimator,
        }
    }
}

impl Default for LaserCubeNetworkBackend {
    fn default() -> Self {
        let status = super::status::LaserCubeNetworkStatus::minimal(
            "0.0.0.0".parse().expect("valid default IP"),
        );
        let profile = ConnectionProfile::unknown_conservative(DEFAULT_BUFFER_CAPACITY as usize);
        Self::new(AddressedDevice {
            source_addr: "0.0.0.0:0".parse().expect("valid default socket address"),
            status,
            profile,
            cmd_port: CMD_PORT,
            data_port: DATA_PORT,
        })
    }
}

/// Hermetic loopback mock LaserCube DAC, shared by the backend and transport
/// handle tests. It binds ephemeral UDP ports on `127.0.0.1` (so parallel tests
/// never collide and it works on macOS, which only brings up `127.0.0.1`) and
/// exposes them via [`MockDac::cmd_port`]/[`MockDac::data_port`] so the test
/// `AddressedDevice` targets the mock. It answers full-info requests and sample
/// packets using the wire encodings under test.
#[cfg(test)]
pub(crate) mod mock {
    use std::net::{IpAddr, Ipv4Addr, SocketAddr, UdpSocket};
    use std::sync::atomic::{AtomicBool, Ordering};
    use std::sync::{Arc, Mutex};
    use std::thread::{self, JoinHandle};
    use std::time::{Duration, Instant};

    use super::super::protocol::{CMD_GET_FULL_INFO, CMD_GET_RINGBUFFER_EMPTY, CMD_SAMPLE_DATA};

    /// A valid 64-byte full-info status advertising a 6000-sample buffer.
    pub(crate) fn full_info_status() -> [u8; 64] {
        let mut d = [0u8; 64];
        d[0] = CMD_GET_FULL_INFO;
        d[3] = 1; // firmware major
        d[4] = 24; // firmware minor
        d[10..14].copy_from_slice(&30_000u32.to_le_bytes()); // point_rate
        d[14..18].copy_from_slice(&30_000u32.to_le_bytes()); // point_rate_max
        d[19..21].copy_from_slice(&6000u16.to_le_bytes()); // buffer_free
        d[21..23].copy_from_slice(&6000u16.to_le_bytes()); // buffer_max
        d[25] = 0; // ethernet server
        d[37] = 10; // model number
        d[38..47].copy_from_slice(b"Ultra Mk2");
        d
    }

    /// Poll `predicate` until it holds or `timeout` elapses.
    pub(crate) fn wait_until(timeout: Duration, mut predicate: impl FnMut() -> bool) -> bool {
        let deadline = Instant::now() + timeout;
        loop {
            if predicate() {
                return true;
            }
            if Instant::now() >= deadline {
                return false;
            }
            thread::sleep(Duration::from_millis(2));
        }
    }

    struct Shared {
        cmd_recv: Mutex<Vec<Vec<u8>>>,
        data_recv: Mutex<Vec<Vec<u8>>>,
    }

    pub(crate) struct MockDac {
        ip: IpAddr,
        cmd_port: u16,
        data_port: u16,
        shared: Arc<Shared>,
        stop: Arc<AtomicBool>,
        join: Option<JoinHandle<()>>,
    }

    impl MockDac {
        pub(crate) fn start() -> Self {
            // Bind ephemeral ports on `127.0.0.1` rather than the fixed LaserCube
            // ports on a per-test loopback alias. Only `127.0.0.1` is guaranteed
            // to be up (macOS does not bring up `127.0.0.2+` by default), and the
            // OS hands out a free port per socket so parallel tests never collide.
            let ip = IpAddr::V4(Ipv4Addr::LOCALHOST);
            let cmd_socket = UdpSocket::bind(SocketAddr::new(ip, 0)).expect("bind mock cmd socket");
            let data_socket =
                UdpSocket::bind(SocketAddr::new(ip, 0)).expect("bind mock data socket");
            let cmd_port = cmd_socket.local_addr().expect("mock cmd local addr").port();
            let data_port = data_socket
                .local_addr()
                .expect("mock data local addr")
                .port();
            cmd_socket
                .set_read_timeout(Some(Duration::from_millis(5)))
                .unwrap();
            data_socket
                .set_read_timeout(Some(Duration::from_millis(5)))
                .unwrap();

            let shared = Arc::new(Shared {
                cmd_recv: Mutex::new(Vec::new()),
                data_recv: Mutex::new(Vec::new()),
            });
            let stop = Arc::new(AtomicBool::new(false));

            let thread_shared = shared.clone();
            let thread_stop = stop.clone();
            let join = thread::Builder::new()
                .name("mock-lasercube-dac".to_string())
                .spawn(move || {
                    let mut buf = [0u8; 1500];
                    while !thread_stop.load(Ordering::Relaxed) {
                        if let Ok((len, src)) = cmd_socket.recv_from(&mut buf) {
                            let packet = buf[..len].to_vec();
                            if packet.first() == Some(&CMD_GET_FULL_INFO) {
                                let _ = cmd_socket.send_to(&full_info_status(), src);
                            }
                            thread_shared.cmd_recv.lock().unwrap().push(packet);
                        }
                        if let Ok((len, src)) = data_socket.recv_from(&mut buf) {
                            let packet = buf[..len].to_vec();
                            if packet.first() == Some(&CMD_SAMPLE_DATA) && packet.len() >= 3 {
                                // Echo the packet sequence (byte 2) and report
                                // 3000 free samples (0x0BB8).
                                let ack = [CMD_GET_RINGBUFFER_EMPTY, packet[2], 0xB8, 0x0B];
                                let _ = data_socket.send_to(&ack, src);
                            }
                            thread_shared.data_recv.lock().unwrap().push(packet);
                        }
                    }
                })
                .expect("spawn mock DAC thread");

            Self {
                ip,
                cmd_port,
                data_port,
                shared,
                stop,
                join: Some(join),
            }
        }

        pub(crate) fn ip(&self) -> IpAddr {
            self.ip
        }

        pub(crate) fn cmd_port(&self) -> u16 {
            self.cmd_port
        }

        pub(crate) fn data_port(&self) -> u16 {
            self.data_port
        }

        pub(crate) fn cmd_packets(&self) -> Vec<Vec<u8>> {
            self.shared.cmd_recv.lock().unwrap().clone()
        }

        pub(crate) fn data_packets(&self) -> Vec<Vec<u8>> {
            self.shared.data_recv.lock().unwrap().clone()
        }
    }

    impl Drop for MockDac {
        fn drop(&mut self) {
            self.stop.store(true, Ordering::Relaxed);
            if let Some(join) = self.join.take() {
                let _ = join.join();
            }
        }
    }
}

#[cfg(test)]
mod tests {
    use std::net::SocketAddr;
    use std::time::{Duration, Instant};

    use crate::device::OutputModel;
    use crate::point::LaserPoint;

    use super::super::profiles::{ConnectionProfile, ConnectionType};
    use super::super::status::LaserCubeNetworkStatus;
    use super::mock::{self, MockDac};
    use super::*;

    fn addressed_for(dac: &MockDac) -> AddressedDevice {
        let ip = dac.ip();
        let mut status = LaserCubeNetworkStatus::minimal(ip);
        status.buffer_free = 6000;
        status.buffer_max = 6000;
        status.point_rate_max = 30_000;
        let profile = ConnectionProfile::for_connection(ConnectionType::EthernetServer, 6000);
        AddressedDevice {
            source_addr: SocketAddr::new(ip, dac.cmd_port()),
            status,
            profile,
            cmd_port: dac.cmd_port(),
            data_port: dac.data_port(),
        }
    }

    fn backend_for(dac: &MockDac) -> LaserCubeNetworkBackend {
        LaserCubeNetworkBackend::new(addressed_for(dac))
    }

    #[test]
    fn default_backend_reports_type_and_caps_and_is_disconnected() {
        let backend = LaserCubeNetworkBackend::default();
        assert_eq!(backend.dac_type(), DacType::LaserCubeNetwork);
        assert_eq!(backend.caps().output_model, OutputModel::NetworkFifo);
        assert!(!backend.is_connected());
        assert!(backend.diagnostics().is_none());
    }

    #[test]
    fn connect_disconnect_lifecycle_is_idempotent() {
        let dac = MockDac::start();
        let mut backend = backend_for(&dac);

        assert!(!backend.is_connected());
        assert!(backend.diagnostics().is_none());

        backend.connect().unwrap();
        assert!(backend.is_connected());
        assert!(backend.diagnostics().is_some());

        // Second connect is a no-op and keeps the connection.
        backend.connect().unwrap();
        assert!(backend.is_connected());

        backend.disconnect().unwrap();
        assert!(!backend.is_connected());
        assert!(backend.diagnostics().is_none());

        // Disconnect is idempotent.
        backend.disconnect().unwrap();
        assert!(!backend.is_connected());
    }

    #[test]
    fn try_write_points_requires_connection() {
        let mut backend = LaserCubeNetworkBackend::default();
        let err = backend
            .try_write_points(30_000, &[LaserPoint::default()])
            .unwrap_err();
        assert!(err.is_disconnected());
    }

    #[test]
    fn try_write_points_written_then_backpressure() {
        let dac = MockDac::start();
        let mut backend = backend_for(&dac);
        backend.connect().unwrap();

        let points = vec![LaserPoint::default(); 100];
        assert_eq!(
            backend.try_write_points(30_000, &points).unwrap(),
            WriteOutcome::Written
        );

        // A single write larger than the host-queue capacity (2 * buffer_max)
        // is rejected as backpressure, deterministically and regardless of the
        // worker's drain progress.
        let flood = vec![LaserPoint::default(); 20_000];
        assert_eq!(
            backend.try_write_points(30_000, &flood).unwrap(),
            WriteOutcome::WouldBlock
        );
    }

    #[test]
    fn estimator_is_wired_in_both_connection_states() {
        let dac = MockDac::start();
        let mut backend = backend_for(&dac);
        let now = Instant::now();

        // Disconnected: the fallback estimator answers.
        let _fallback = backend.estimator().estimated_fullness(now, 30_000);

        backend.connect().unwrap();
        // Connected: the shared transport-state estimator answers.
        let _connected = backend.estimator().estimated_fullness(now, 30_000);

        backend.disconnect().unwrap();
        // Back to the fallback estimator.
        let _fallback_again = backend.estimator().estimated_fullness(now, 30_000);
    }

    #[test]
    fn set_shutter_and_stop_are_noops_when_disconnected() {
        let mut backend = LaserCubeNetworkBackend::default();
        assert!(backend.set_shutter(true).is_ok());
        assert!(backend.set_shutter(false).is_ok());
        assert!(backend.stop().is_ok());
    }

    #[test]
    fn set_shutter_open_emits_output_enable_command() {
        let dac = MockDac::start();
        let mut backend = backend_for(&dac);
        backend.connect().unwrap();

        backend.set_shutter(true).unwrap();
        assert!(
            mock::wait_until(Duration::from_millis(1000), || dac
                .cmd_packets()
                .iter()
                .any(|p| p.as_slice() == [0x80, 0x01])),
            "expected set_output(true) command, got {:?}",
            dac.cmd_packets()
        );
    }

    #[test]
    fn stop_emits_additional_output_disable_command() {
        let dac = MockDac::start();
        let mut backend = backend_for(&dac);
        backend.connect().unwrap();

        // Let startup commands settle (they include one set_output(false)).
        mock::wait_until(Duration::from_millis(500), || !dac.cmd_packets().is_empty());
        let before = dac
            .cmd_packets()
            .iter()
            .filter(|p| p.as_slice() == [0x80, 0x00])
            .count();

        backend.stop().unwrap();
        assert!(
            mock::wait_until(Duration::from_millis(1000), || {
                dac.cmd_packets()
                    .iter()
                    .filter(|p| p.as_slice() == [0x80, 0x00])
                    .count()
                    > before
            }),
            "expected an additional set_output(false), got {:?}",
            dac.cmd_packets()
        );
    }

    #[test]
    fn write_points_reach_the_device_as_sample_packets() {
        let dac = MockDac::start();
        let mut backend = backend_for(&dac);
        backend.connect().unwrap();

        for _ in 0..5 {
            let points = vec![LaserPoint::default(); 200];
            let _ = backend.try_write_points(30_000, &points);
            std::thread::sleep(Duration::from_millis(10));
        }

        assert!(
            mock::wait_until(Duration::from_millis(1000), || dac
                .data_packets()
                .iter()
                .any(|p| p.first() == Some(&0xA9))),
            "expected sample-data packets at the device"
        );
    }
}