use std::sync::Arc;
use arrow_array::RecordBatchReader;
use datafusion::error::DataFusionError;
use datafusion::physical_plan::stream::RecordBatchStreamAdapter;
use datafusion::physical_plan::SendableRecordBatchStream;
use futures::{StreamExt, TryStreamExt};
use lance_core::{
datatypes::Schema,
format::Fragment,
io::{
object_store::{ObjectStore, ObjectStoreParams},
FileWriter,
},
Error, Result,
};
use lance_datafusion::chunker::chunk_stream;
use object_store::path::Path;
use tracing::instrument;
use uuid::Uuid;
use super::progress::{NoopFragmentWriteProgress, WriteFragmentProgress};
use super::DATA_DIR;
pub mod update;
#[derive(Debug, Clone, Copy)]
pub enum WriteMode {
Create,
Append,
Overwrite,
}
#[derive(Debug, Clone)]
pub struct WriteParams {
pub max_rows_per_file: usize,
pub max_rows_per_group: usize,
pub max_bytes_per_file: usize,
pub mode: WriteMode,
pub store_params: Option<ObjectStoreParams>,
pub progress: Arc<dyn WriteFragmentProgress>,
}
impl Default for WriteParams {
fn default() -> Self {
Self {
max_rows_per_file: 1024 * 1024, max_rows_per_group: 1024,
max_bytes_per_file: 90 * 1024 * 1024 * 1024, mode: WriteMode::Create,
store_params: None,
progress: Arc::new(NoopFragmentWriteProgress::new()),
}
}
}
pub fn reader_to_stream(
batches: Box<dyn RecordBatchReader + Send>,
) -> Result<(SendableRecordBatchStream, Schema)> {
let arrow_schema = batches.schema();
let mut schema: Schema = Schema::try_from(batches.schema().as_ref())?;
let mut peekable = batches.peekable();
if let Some(batch) = peekable.peek() {
if let Ok(b) = batch {
schema.set_dictionary(b)?;
} else {
return Err(Error::from(batch.as_ref().unwrap_err()));
}
}
schema.validate()?;
let stream = RecordBatchStreamAdapter::new(
arrow_schema,
futures::stream::iter(peekable).map_err(DataFusionError::from),
);
let stream = Box::pin(stream) as SendableRecordBatchStream;
Ok((stream, schema))
}
pub async fn write_fragments(
dataset_uri: &str,
data: impl RecordBatchReader + Send + 'static,
params: WriteParams,
) -> Result<Vec<Fragment>> {
let (object_store, base) = ObjectStore::from_uri_and_params(
dataset_uri,
¶ms.store_params.clone().unwrap_or_default(),
)
.await?;
let (stream, schema) = reader_to_stream(Box::new(data))?;
write_fragments_internal(Arc::new(object_store), &base, &schema, stream, params).await
}
#[instrument(level = "debug", skip_all)]
pub async fn write_fragments_internal(
object_store: Arc<ObjectStore>,
base_dir: &Path,
schema: &Schema,
data: SendableRecordBatchStream,
mut params: WriteParams,
) -> Result<Vec<Fragment>> {
params.max_rows_per_group = std::cmp::min(params.max_rows_per_group, params.max_rows_per_file);
let mut buffered_reader = chunk_stream(data, params.max_rows_per_group);
let writer_generator = WriterGenerator::new(object_store, base_dir, schema);
let mut writer: Option<FileWriter> = None;
let mut num_rows_in_current_file = 0;
let mut fragments = Vec::new();
while let Some(batch_chunk) = buffered_reader.next().await {
let batch_chunk = batch_chunk?;
if writer.is_none() {
let (new_writer, new_fragment) = writer_generator.new_writer().await?;
let multipart_id = new_writer.multipart_id().to_string();
params.progress.begin(&new_fragment, &multipart_id).await?;
writer = Some(new_writer);
fragments.push(new_fragment);
}
writer.as_mut().unwrap().write(&batch_chunk).await?;
for batch in batch_chunk {
num_rows_in_current_file += batch.num_rows();
}
if num_rows_in_current_file >= params.max_rows_per_file
|| writer.as_mut().unwrap().tell().await? >= params.max_bytes_per_file
{
let num_rows = writer.take().unwrap().finish().await?;
debug_assert_eq!(num_rows, num_rows_in_current_file);
params.progress.complete(fragments.last().unwrap()).await?;
fragments.last_mut().unwrap().physical_rows = Some(num_rows);
num_rows_in_current_file = 0;
}
}
if let Some(mut writer) = writer.take() {
let num_rows = writer.finish().await?;
fragments.last_mut().unwrap().physical_rows = Some(num_rows);
}
Ok(fragments)
}
struct WriterGenerator {
object_store: Arc<ObjectStore>,
base_dir: Path,
schema: Schema,
}
impl WriterGenerator {
pub fn new(object_store: Arc<ObjectStore>, base_dir: &Path, schema: &Schema) -> Self {
Self {
object_store,
base_dir: base_dir.clone(),
schema: schema.clone(),
}
}
pub async fn new_writer(&self) -> Result<(FileWriter, Fragment)> {
let data_file_path = format!("{}.lance", Uuid::new_v4());
let mut fragment = Fragment::new(0);
fragment.add_file(&data_file_path, &self.schema);
let full_path = self.base_dir.child(DATA_DIR).child(data_file_path);
let writer = FileWriter::try_new(
self.object_store.as_ref(),
&full_path,
self.schema.clone(),
&Default::default(),
)
.await?;
Ok((writer, fragment))
}
}
#[cfg(test)]
mod tests {
use super::*;
use arrow_array::{Int32Array, RecordBatch};
use arrow_schema::{DataType, Schema as ArrowSchema};
#[tokio::test]
async fn test_chunking_large_batches() {
let schema = Arc::new(ArrowSchema::new(vec![arrow::datatypes::Field::new(
"a",
DataType::Int32,
false,
)]));
let batch =
RecordBatch::try_new(schema.clone(), vec![Arc::new(Int32Array::from_iter(0..28))])
.unwrap();
let batches: Vec<RecordBatch> =
vec![batch.slice(0, 10), batch.slice(10, 10), batch.slice(20, 8)];
let stream = RecordBatchStreamAdapter::new(
schema.clone(),
futures::stream::iter(batches.into_iter().map(Ok::<_, DataFusionError>)),
);
let chunks: Vec<Vec<RecordBatch>> = chunk_stream(Box::pin(stream), 3)
.try_collect()
.await
.unwrap();
assert_eq!(chunks.len(), 10);
assert_eq!(chunks[0].len(), 1);
for (i, chunk) in chunks.iter().enumerate() {
let num_rows = chunk.iter().map(|batch| batch.num_rows()).sum::<usize>();
if i < chunks.len() - 1 {
assert_eq!(num_rows, 3);
} else {
assert_eq!(num_rows, 1);
}
}
assert_eq!(chunks[3].len(), 2);
assert_eq!(chunks[3][0].num_rows(), 1);
assert_eq!(chunks[3][1].num_rows(), 2);
}
#[tokio::test]
async fn test_chunking_small_batches() {
let schema = Arc::new(ArrowSchema::new(vec![arrow::datatypes::Field::new(
"a",
DataType::Int32,
false,
)]));
let batch =
RecordBatch::try_new(schema.clone(), vec![Arc::new(Int32Array::from_iter(0..30))])
.unwrap();
let batches: Vec<RecordBatch> = (0..10).map(|i| batch.slice(i * 3, 3)).collect();
let stream = RecordBatchStreamAdapter::new(
schema.clone(),
futures::stream::iter(batches.into_iter().map(Ok::<_, DataFusionError>)),
);
let chunks: Vec<Vec<RecordBatch>> = chunk_stream(Box::pin(stream), 10)
.try_collect()
.await
.unwrap();
assert_eq!(chunks.len(), 3);
assert_eq!(chunks[0].len(), 4);
assert_eq!(chunks[0][0], batch.slice(0, 3));
assert_eq!(chunks[0][1], batch.slice(3, 3));
assert_eq!(chunks[0][2], batch.slice(6, 3));
assert_eq!(chunks[0][3], batch.slice(9, 1));
for chunk in &chunks {
let num_rows = chunk.iter().map(|batch| batch.num_rows()).sum::<usize>();
assert_eq!(num_rows, 10);
}
}
#[tokio::test]
async fn test_file_size() {
let schema = Arc::new(ArrowSchema::new(vec![arrow::datatypes::Field::new(
"a",
DataType::Int32,
false,
)]));
let batch = RecordBatch::try_new(
schema.clone(),
vec![Arc::new(Int32Array::from_iter(0..1024))],
)
.unwrap();
let write_params = WriteParams {
max_rows_per_file: 1024 * 10, max_rows_per_group: 512,
max_bytes_per_file: 2 * 1024,
mode: WriteMode::Create,
..Default::default()
};
let data_stream = Box::pin(RecordBatchStreamAdapter::new(
schema.clone(),
futures::stream::iter(std::iter::once(Ok(batch))),
));
let schema = Schema::try_from(schema.as_ref()).unwrap();
let object_store = Arc::new(ObjectStore::memory());
let fragments = write_fragments_internal(
object_store,
&Path::from("test"),
&schema,
data_stream,
write_params,
)
.await
.unwrap();
assert_eq!(fragments.len(), 2);
}
}