ktstr 0.23.0

Test harness for Linux process schedulers
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
use crate::monitor::cast_analysis::{AddrSpace, CastHit, CastMap};
use serde::{Deserialize, Serialize};
use std::collections::{BTreeMap, HashMap};
use std::path::PathBuf;

use super::FwdIndexEntry;

// Explicit on-disk FORMAT version for PersistedCastAnalysis. Bump only
// for wire-layout changes (a field add/remove/retype). Analyzer BEHAVIOR
// changes no longer need a manual bump: they self-invalidate via
// ANALYZER_FINGERPRINT (a build.rs hash of the cast-analysis source,
// folded into cache_path below). v13 was the last manual bump — it
// invalidated caches written before the arena_confirmed deferred-resolve
// loop in src/monitor/cast_analysis/mod.rs landed (pre-v13 cast maps lack
// the `target_type_id == 0` arena entries, so a stale v12 cache rendered
// the affected BSS u64 fields as plain integers instead of typed
// pointers).
const SCHEMA_VERSION: u32 = 13;

#[derive(Serialize, Deserialize)]
struct PersistedAddrSpace(u8);

impl From<AddrSpace> for PersistedAddrSpace {
    fn from(a: AddrSpace) -> Self {
        match a {
            AddrSpace::Arena => Self(0),
            AddrSpace::Kernel => Self(1),
        }
    }
}

impl PersistedAddrSpace {
    fn into_addr_space(self) -> Option<AddrSpace> {
        match self.0 {
            0 => Some(AddrSpace::Arena),
            1 => Some(AddrSpace::Kernel),
            _ => None,
        }
    }
}

#[derive(Serialize, Deserialize)]
struct PersistedCastHit {
    target_type_id: u32,
    addr_space: PersistedAddrSpace,
    alloc_size: Option<u64>,
}

impl From<CastHit> for PersistedCastHit {
    fn from(h: CastHit) -> Self {
        Self {
            target_type_id: h.target_type_id,
            addr_space: h.addr_space.into(),
            alloc_size: h.alloc_size,
        }
    }
}

impl PersistedCastHit {
    fn into_cast_hit(self) -> Option<CastHit> {
        Some(CastHit {
            target_type_id: self.target_type_id,
            addr_space: self.addr_space.into_addr_space()?,
            alloc_size: self.alloc_size,
        })
    }
}

#[derive(Serialize, Deserialize)]
struct PersistedFwdIndexEntry {
    btfs_idx: u32,
    type_id: u32,
}

impl From<&FwdIndexEntry> for PersistedFwdIndexEntry {
    fn from(e: &FwdIndexEntry) -> Self {
        Self {
            btfs_idx: e.btfs_idx as u32,
            type_id: e.type_id,
        }
    }
}

impl PersistedFwdIndexEntry {
    fn into_fwd_index_entry(self) -> FwdIndexEntry {
        FwdIndexEntry {
            btfs_idx: self.btfs_idx as usize,
            type_id: self.type_id,
        }
    }
}

#[derive(Serialize, Deserialize)]
struct PersistedCastAnalysis {
    schema_version: u32,
    content_hash: u64,
    cast_entries: Vec<((u32, u32), PersistedCastHit)>,
    fwd_entries: Vec<(String, PersistedFwdIndexEntry)>,
    btf_count: u32,
    alloc_size_types: Vec<(u64, String)>,
}

fn cache_dir() -> Option<PathBuf> {
    let dir = crate::cache::resolve_cache_root_with_suffix("cast_analysis").ok()?;
    // Reclaim `*.bin.tmp.<pid>` staging files left by interrupted prior
    // runs, once per process on first cache access. try_save writes a
    // pid-suffixed temp then renames; a process that dies between the write
    // and the rename (Ctrl-C / crash — notably on the detached precompute
    // threads) orphans the temp, and nothing else reclaims it.
    static SWEEP_ONCE: std::sync::Once = std::sync::Once::new();
    SWEEP_ONCE.call_once(|| sweep_stale_tmp(&dir));
    Some(dir)
}

/// Remove `*.bin.tmp.<pid>` staging files in `dir` whose owning pid is no
/// longer alive (`kill(pid, 0)` -> ESRCH). A file owned by a LIVE pid is a
/// concurrent run's in-flight write and is left untouched; the final
/// `.bin` cache files (no `.tmp.<pid>` suffix) are never matched.
fn sweep_stale_tmp(dir: &std::path::Path) {
    let Ok(entries) = std::fs::read_dir(dir) else {
        return;
    };
    let self_pid = std::process::id();
    for entry in entries.flatten() {
        let name = entry.file_name();
        let Some(pid) = name
            .to_str()
            .and_then(|n| n.rsplit_once(".bin.tmp."))
            .and_then(|(_, p)| p.parse::<i32>().ok())
        else {
            continue;
        };
        // Skip non-positive pids (kill(0)/kill(-N) probe process GROUPS)
        // and our own in-flight writes.
        if pid <= 0 || pid == self_pid as i32 {
            continue;
        }
        let dead = matches!(
            nix::sys::signal::kill(nix::unistd::Pid::from_raw(pid), None),
            Err(nix::errno::Errno::ESRCH),
        );
        if dead {
            let _ = std::fs::remove_file(entry.path());
        }
    }
}

/// Compile-time fingerprint of the cast-analysis source, emitted by
/// build.rs (`cast_analyzer_fingerprint`) from a SipHash-13 of every
/// non-test `.rs` under `src/monitor/cast_analysis`,
/// `src/vmm/cast_analysis_load`, `src/monitor/sdt_alloc` (which
/// resolves the cached `alloc_size_types`), plus `src/monitor/btf_render` and
/// `src/monitor/bpf_map` (whose modifier-peel / struct-resolve helpers
/// resolve every cast's terminal type). Folding it into the cache key makes the
/// cache self-invalidate whenever the analyzer's behavior changes, with
/// no manual `SCHEMA_VERSION` bump — closing the footgun where a stale
/// cache served the old analyzer's output and masked a fixed bug as a
/// flake.
const ANALYZER_FINGERPRINT: &str = env!("KTSTR_CAST_ANALYZER_FINGERPRINT");

/// Compile-time fingerprint of the whole `Cargo.lock`, emitted by
/// build.rs (`cargo_lock_fingerprint`). Folded into the cache key
/// alongside [`ANALYZER_FINGERPRINT`] so a dependency bump — a `btf-rs`
/// (BTF parsing) or `libbpf-rs` / `libbpf-sys` (BPF-opcode constants)
/// version change that can alter the cast map — invalidates the cache
/// even when the analyzer source is unchanged. Only the cast-analysis
/// cache folds this in: the kernels / models / disk_template caches are
/// produced by external tools (Kbuild, downloads, in-VM mkfs) and are
/// dependency-independent, so fingerprinting them would force pointless
/// rebuilds.
const CARGO_LOCK_FINGERPRINT: &str = env!("KTSTR_CARGO_LOCK_FINGERPRINT");

fn cache_path(hash: u64) -> Option<PathBuf> {
    cache_dir().map(|d| {
        d.join(format!(
            "v{SCHEMA_VERSION}_{ANALYZER_FINGERPRINT}_{CARGO_LOCK_FINGERPRINT}_{hash:016x}.bin"
        ))
    })
}

#[allow(clippy::type_complexity)]
pub(super) fn try_load(
    hash: u64,
    expected_btf_count: usize,
) -> Option<(CastMap, HashMap<String, FwdIndexEntry>, Vec<(u64, String)>)> {
    let path = cache_path(hash)?;
    let bytes = std::fs::read(&path).ok()?;
    let persisted: PersistedCastAnalysis = postcard::from_bytes(&bytes).ok()?;

    if persisted.schema_version != SCHEMA_VERSION {
        return None;
    }
    if persisted.content_hash != hash {
        return None;
    }
    if persisted.btf_count as usize != expected_btf_count {
        tracing::debug!(
            expected = expected_btf_count,
            cached = persisted.btf_count,
            "cast_analysis: disk cache btf_count mismatch; treating as miss"
        );
        return None;
    }

    let mut cast_map = BTreeMap::new();
    for (key, hit) in persisted.cast_entries {
        cast_map.insert(key, hit.into_cast_hit()?);
    }

    let mut fwd_index = HashMap::new();
    for (name, entry) in persisted.fwd_entries {
        fwd_index.insert(name, entry.into_fwd_index_entry());
    }

    tracing::info!(
        casts = cast_map.len(),
        fwd = fwd_index.len(),
        path = %path.display(),
        "cast_analysis: loaded from disk cache"
    );
    Some((cast_map, fwd_index, persisted.alloc_size_types))
}

pub(super) fn try_save(
    hash: u64,
    cast_map: &CastMap,
    fwd_index: &HashMap<String, FwdIndexEntry>,
    btf_count: usize,
    alloc_size_types: &[(u64, String)],
) {
    // Symmetric with get_full's read-side collapse (mod.rs:401/442):
    // a result with no cast entries AND an empty fwd index loads back
    // as None, so persisting it only wastes a disk write plus a
    // recompute on every subsequent run. Skip the write. (alloc_size_types
    // alone never resurrects a cached result -- the read-side collapse
    // ignores it -- so it does not gate this guard.)
    if cast_map.is_empty() && fwd_index.is_empty() {
        return;
    }
    let Some(path) = cache_path(hash) else { return };

    let persisted = PersistedCastAnalysis {
        schema_version: SCHEMA_VERSION,
        content_hash: hash,
        cast_entries: cast_map.iter().map(|(&k, &v)| (k, v.into())).collect(),
        fwd_entries: fwd_index
            .iter()
            .map(|(k, v)| (k.clone(), v.into()))
            .collect(),
        btf_count: btf_count as u32,
        alloc_size_types: alloc_size_types.to_vec(),
    };

    let encoded = match postcard::to_stdvec(&persisted) {
        Ok(v) => v,
        Err(e) => {
            tracing::debug!(error = %e, "cast_analysis: failed to encode for disk cache");
            return;
        }
    };

    if let Some(parent) = path.parent() {
        let _ = std::fs::create_dir_all(parent);
    }

    let tmp = path.with_extension(format!("bin.tmp.{}", std::process::id()));
    if std::fs::write(&tmp, &encoded).is_ok() {
        if std::fs::rename(&tmp, &path).is_err() {
            let _ = std::fs::remove_file(&tmp);
        } else {
            tracing::debug!(
                path = %path.display(),
                bytes = encoded.len(),
                "cast_analysis: saved to disk cache"
            );
        }
    }
}

#[cfg(test)]
mod tests {
    use super::*;
    use crate::test_support::test_helpers::{isolated_cache_dir, lock_env};

    #[test]
    fn sweep_removes_dead_pid_tmp_keeps_live_and_final() {
        // A `*.bin.tmp.<pid>` staging file owned by a dead pid is reclaimed;
        // one owned by our own (live) pid and the final `.bin` cache file
        // are kept. pid 2147483647 (i32::MAX) is above pid_max -> ESRCH.
        let base = std::env::temp_dir().join(format!("ktstr-castsweep-{}", std::process::id()));
        let _ = std::fs::remove_dir_all(&base);
        std::fs::create_dir_all(&base).expect("mk temp root");
        let dead = base.join("abc.bin.tmp.2147483647");
        let live = base.join(format!("abc.bin.tmp.{}", std::process::id()));
        let final_cache = base.join("abc.bin");
        for p in [&dead, &live, &final_cache] {
            std::fs::write(p, b"x").expect("write fixture");
        }

        sweep_stale_tmp(&base);

        assert!(!dead.exists(), "a dead-owner .bin.tmp file is reclaimed");
        assert!(live.exists(), "our own (live) .bin.tmp file is kept");
        assert!(
            final_cache.exists(),
            "the final .bin cache file is untouched"
        );

        let _ = std::fs::remove_dir_all(&base);
    }

    #[test]
    fn roundtrip_save_load() {
        let _env_lock = lock_env();
        let _cache = isolated_cache_dir();

        let mut cast_map = BTreeMap::new();
        cast_map.insert(
            (2, 8),
            CastHit {
                target_type_id: 5,
                addr_space: AddrSpace::Arena,
                alloc_size: None,
            },
        );
        cast_map.insert(
            (3, 16),
            CastHit {
                target_type_id: 7,
                addr_space: AddrSpace::Kernel,
                alloc_size: None,
            },
        );
        let mut fwd_index = HashMap::new();
        fwd_index.insert(
            "cgx_target".to_string(),
            FwdIndexEntry {
                btfs_idx: 1,
                type_id: 4,
            },
        );

        let hash = 0xDEAD_BEEF_CAFE_1234u64;
        try_save(hash, &cast_map, &fwd_index, 2, &[]);

        let loaded = try_load(hash, 2);
        assert!(loaded.is_some(), "roundtrip must succeed");
        let (loaded_map, loaded_fwd, _alloc_types) = loaded.unwrap();
        assert_eq!(loaded_map.len(), 2);
        assert_eq!(loaded_map.get(&(2, 8)).unwrap().target_type_id, 5);
        assert_eq!(
            loaded_map.get(&(2, 8)).unwrap().addr_space,
            AddrSpace::Arena
        );
        assert_eq!(
            loaded_map.get(&(3, 16)).unwrap().addr_space,
            AddrSpace::Kernel
        );
        assert_eq!(loaded_fwd.len(), 1);
        assert_eq!(loaded_fwd["cgx_target"].btfs_idx, 1);
        assert_eq!(loaded_fwd["cgx_target"].type_id, 4);
    }

    #[test]
    fn load_wrong_btf_count_returns_none() {
        let _env_lock = lock_env();
        let _cache = isolated_cache_dir();

        // Non-empty cast map so try_save actually persists -- the
        // empty-result guard would otherwise skip the write and this test
        // would pass vacuously via a nonexistent-file miss instead of
        // exercising the btf_count check it names.
        let mut cast_map = BTreeMap::new();
        cast_map.insert(
            (1, 0),
            CastHit {
                target_type_id: 9,
                addr_space: AddrSpace::Arena,
                alloc_size: None,
            },
        );
        let fwd_index = HashMap::new();
        let hash = 0x1234_5678_9ABC_DEF0u64;
        try_save(hash, &cast_map, &fwd_index, 3, &[]);

        assert!(
            try_load(hash, 5).is_none(),
            "btf_count mismatch must return None"
        );
    }

    #[test]
    fn load_nonexistent_returns_none() {
        let _env_lock = lock_env();
        assert!(try_load(0xFFFF_FFFF_FFFF_FFFFu64, 1).is_none());
    }

    #[test]
    fn try_save_skips_empty_result() {
        let _env_lock = lock_env();
        let _cache = isolated_cache_dir();

        // An empty result (no cast entries, empty fwd index) loads back as
        // None via get_full's collapse, so try_save must not persist it --
        // otherwise every run pays a disk write plus a recompute on the
        // next load. Verify the write is skipped: try_load finds no file.
        let cast_map = BTreeMap::new();
        let fwd_index = HashMap::new();
        let hash = 0xABCD_1234_5678_9999u64;
        try_save(hash, &cast_map, &fwd_index, 2, &[]);

        assert!(
            try_load(hash, 2).is_none(),
            "empty result must not be persisted"
        );
    }
}