kranz_engine/

planning.rs

//! Planning turns — extracted from `orchestrator.rs` in the monolith split
//! (pure code motion, no behavior change). The plan-request turn family:
//! demanding the initial plan JSON and the revised plan for a running mission,
//! the large-scope prompt policies those turns embed (considered-alternatives
//! and research), the pre-emit validation gates a proposed (revised) plan must
//! pass, the plan JSON Schema, and the missions-catalog index upsert.

use crate::cost;
use crate::error::{EngineError, Result};
use crate::orchestrator::{MissionEngine, PlanRequest, JSON_RETRY_MSG};
use crate::reducer;
use crate::report_render::extract_research;
use crate::runner;
use crate::types::*;

/// Content identity carried from a plan preview to its approval on every client.
/// Serializing the typed plan fixes field order and includes all consent-bearing
/// fields. Plans contain only infallibly serializable structs, strings and lists.
pub fn plan_identity(plan: &Plan) -> String {
    let json = serde_json::to_vec(plan).expect("Plan serialization cannot fail");
    crate::standards_waiver::sha256_hex(&json)
}

impl MissionEngine {
    /// Demand the plan JSON (types::Plan, camelCase). Lenient parse with one
    /// retry demanding bare JSON; a plan parses to [`PlanRequest::Ready`]
    /// (unapproved). Beside the plan, the planner has two more voices: an
    /// explicit `{"wrongPlan": "…"}` reply maps to [`PlanRequest::WrongPlan`]
    /// (planner-initiated only, never inferred from prose), and when the
    /// retry ALSO answers with prose, the orchestrator is simply not ready to
    /// emit (it wants answers first) — that text comes back as
    /// [`PlanRequest::NotReady`], never as an error.
    pub async fn request_plan(&mut self) -> Result<PlanRequest> {
        let message = format!(
            "Emit the plan now. Output ONLY a JSON object conforming exactly to this JSON \
             Schema — no prose before or after:\n{}\n\n{}\n\n{}\n\n{}",
            plan_schema(),
            considered_alternatives_prompt_policy(&self.state.config),
            research_prompt_policy(&self.state.config),
            WRONG_PLAN_PROMPT_CHANNEL
        );
        let text = self.orch_turn(&message).await?;
        if let Some(plan) = runner::parse_report::<Plan>(&text) {
            self.pending_research = extract_research(&text);
            return self.standards_fixed_point(plan).await;
        }
        if let Some(reason) = parse_wrong_plan(&text) {
            return Ok(PlanRequest::WrongPlan { reason });
        }
        let retry = self.orch_turn(JSON_RETRY_MSG).await?;
        if let Some(plan) = runner::parse_report::<Plan>(&retry) {
            self.pending_research = extract_research(&retry);
            return self.standards_fixed_point(plan).await;
        }
        if let Some(reason) = parse_wrong_plan(&retry) {
            return Ok(PlanRequest::WrongPlan { reason });
        }
        // Prefer the retry's text (the model's latest word); fall back to
        // the first turn's when the retry came back empty. Both are
        // already scrubbed by pump_turn.
        Ok(PlanRequest::NotReady(if retry.trim().is_empty() {
            text
        } else {
            retry
        }))
    }

    fn review_policy_preview(&self, mut plan: Plan) -> Result<PlanRequest> {
        let policy = if self.state.mission.status == crate::types::MissionStatus::Planning {
            crate::reviewer_independence::configured_policy(&self.state.config)
        } else {
            self.state.mission.reviewer_independence
        };
        crate::reviewer_independence::pin_plan(&mut plan, policy)?;
        Ok(PlanRequest::Ready(plan))
    }

    /// The Flight Rules planning projection (KRZ-345, design D-D/D-G):
    /// planning-stage rules resolved from the TRUSTED source — against the
    /// seed hints (ticket repo-refs + any explicit touch hints) when
    /// `touch_override` is `None`, or against the plan's own touch set for
    /// the fixed-point revision loop. `Ok(None)` — no standards-configured
    /// pack — leaves every planning surface byte-identical.
    pub(crate) fn planning_standards_projection(
        &self,
        touch_override: Option<&[String]>,
    ) -> Result<Option<crate::pack::projection::PlanningProjection>> {
        let task_class = crate::ticket::parse_task_class_from_goal(&self.state.mission.goal);
        let mut hints = match touch_override {
            Some(touch) => touch.to_vec(),
            None => self.planning_touch_hints(),
        };
        if let Some(contract) = crate::review_artifact::parse_from_goal(&self.state.mission.goal)? {
            hints.push(contract.input_path);
            hints.sort();
            hints.dedup();
        }
        crate::pack::projection::planning_projection(
            &self.repo,
            &self.state.config,
            &self.state.mission.base_branch,
            task_class.as_deref(),
            &hints,
        )
        .map_err(EngineError::Config)
    }

    /// The seed-time selection hints (D-D's "ticket repo refs and explicit
    /// touch hints"): the mission's explicit touch hints (empty during
    /// initial planning) plus the linked ticket's repo-refs. The ticket read
    /// is best-effort — hints shape a conservative candidate set, never
    /// policy; the pack load is the fail-closed part.
    fn planning_touch_hints(&self) -> Vec<String> {
        let mut hints = self.state.mission.touch_set.clone();
        if let Some(slug) =
            crate::ticket::Ticket::slug_for_mission(&self.paths.repo_root, &self.state.mission.id)
        {
            if let Ok(ticket) = crate::ticket::Ticket::load(&crate::ticket::Ticket::md_path(
                &self.paths.repo_root,
                &slug,
            )) {
                hints.extend(ticket.repo_refs);
            }
        }
        hints
    }

    /// The Flight Rules fixed-point revision loop (KRZ-345, design D-D): the
    /// planner received the planning-stage candidate set with its seed; when
    /// the RETURNED plan's touch set activates additional planning-stage
    /// rules the planner never saw, the exact delta goes back in one bounded
    /// revision turn and resolution repeats against the revised plan, until
    /// the plan/rule set reaches a fixed point (the plan activates nothing
    /// the planner did not receive) or the turn budget runs out and planning
    /// parks. The plan is never offered for approval carrying a rule the
    /// planner did not receive; approval re-resolves and pins only the fixed
    /// point (KRZ-342's approval re-resolution stays the authority). No
    /// standards ⇒ the plan passes through untouched, byte-identical.
    async fn standards_fixed_point(&mut self, plan: Plan) -> Result<PlanRequest> {
        let Some(seed_projection) = self.planning_standards_projection(None)? else {
            return self.review_policy_preview(plan);
        };
        let mut delivered: std::collections::BTreeSet<(String, u64)> =
            seed_projection.delivered().into_iter().collect();
        let mut plan = plan;
        let mut revisions = 0;
        loop {
            let Some(current) = self.planning_standards_projection(Some(&plan.touch_set))? else {
                // Standards stopped governing between the seed and now (the
                // configured pack changed mid-planning): nothing the planner
                // saw can be missing — approval re-resolves the truth.
                return self.review_policy_preview(plan);
            };
            let delta: Vec<crate::pack::projection::ProjectedRule> = current
                .rules
                .iter()
                .filter(|rule| !delivered.contains(&rule.identity()))
                .cloned()
                .collect();
            if delta.is_empty() {
                return self.review_policy_preview(plan);
            }
            if revisions == MAX_STANDARDS_REVISION_TURNS {
                // The touch set kept activating unseen policy past the
                // revision budget: park honestly, naming the rules still
                // unaccounted for (D-D: "planning parks").
                return Ok(PlanRequest::NotReady(format!(
                    "Planning parked: after {MAX_STANDARDS_REVISION_TURNS} bounded revision \
                     turns the plan's touch set still activates Flight Rules rules the \
                     planner has not accounted for ({}). Narrow the touch set or address the \
                     standards delta explicitly, then re-run the draft.",
                    delta
                        .iter()
                        .map(|rule| format!("{} r{}", rule.id, rule.revision))
                        .collect::<Vec<_>>()
                        .join(", ")
                )));
            }
            revisions += 1;
            delivered.extend(delta.iter().map(|rule| rule.identity()));
            let message = format!(
                "The touch set of the plan you just emitted activates Flight Rules policy you \
                 have not seen. These additional planning-stage rule(s) apply — the plan must \
                 account for them before it can be offered for approval:\n\n{}\n\
                 Revise the plan to account for every rule above (adjust milestones, features, \
                 criteria, or the touch set itself), then output ONLY the revised plan JSON \
                 conforming exactly to this JSON Schema — no prose before or after:\n{}",
                current.render_delta(&delta),
                plan_schema()
            );
            let reply = self.orch_turn(&message).await?;
            let mut revised = runner::parse_report::<Plan>(&reply);
            let mut prose = reply;
            if revised.is_none() {
                let retry = self.orch_turn(JSON_RETRY_MSG).await?;
                revised = runner::parse_report::<Plan>(&retry);
                if !retry.trim().is_empty() {
                    prose = retry;
                }
            }
            match revised {
                Some(revised) => {
                    // Research evidence rides the text that carried the
                    // ACCEPTED plan, exactly like the initial turn's capture.
                    self.pending_research = extract_research(&prose);
                    plan = revised;
                }
                // A prose answer parks planning exactly like the initial
                // turn's NotReady — the operator sees the planner's words.
                None => return Ok(PlanRequest::NotReady(prose)),
            }
        }
    }

    /// Propose a REVISED plan for the not-yet-complete work of a running or
    /// blocked mission (roadmap M2). An orchestrator turn — digest + the
    /// current milestone/feature status + a revise-the-remainder instruction —
    /// that returns a full [`Plan`] (completed milestones unchanged and first,
    /// then the revised remainder). Reuses the streaming orchestrator, the
    /// lenient JSON parse, and the [`PlanRequest`] `Ready`/`NotReady` enum
    /// exactly like [`Self::request_plan`]; prose (the orchestrator wants to
    /// discuss first) comes back as `NotReady`, never an error. The draft-stage
    /// wrong-plan escalation is NOT offered on this prompt: a `wrongPlan` reply
    /// here just fails plan parsing and degrades to `NotReady`.
    ///
    /// This only PROPOSES; [`Self::approve_revised_plan`] validates and applies
    /// the subset the event vocabulary can express (see the contract note
    /// above).
    pub async fn request_revised_plan(&mut self) -> Result<PlanRequest> {
        self.request_revised_plan_with_instructions("").await
    }

    pub(crate) async fn request_revised_plan_with_instructions(
        &mut self,
        instructions: &str,
    ) -> Result<PlanRequest> {
        let instructions = instructions.trim();
        let instructions_block = if instructions.is_empty() {
            "No extra operator instructions were supplied.".to_string()
        } else {
            format!("Operator revision request:\n{instructions}")
        };
        let mut message = format!(
            "The mission is already underway. Propose a REVISED plan for the work that is \
             NOT yet complete. Rules: keep every already-COMPLETE milestone exactly as it is \
             and list those completed milestones FIRST and unchanged (same title, same \
             features, same order); then revise the remaining milestones' features as the \
             current situation warrants (drop features no longer needed, add features now \
             required). Output ONLY a JSON object conforming exactly to this JSON Schema — \
             no prose before or after:\n{}\n\n{}\n\n{}\n\n{}",
            plan_schema(),
            considered_alternatives_prompt_policy(&self.state.config),
            research_prompt_policy(&self.state.config),
            instructions_block
        );
        // Revised-planning is in scope for knowledge injection (D-C); lessons
        // stay on the initial planning-seed path only.
        if let Some(block) = self.render_knowledge_for_planning() {
            message.push_str("\n\n");
            message.push_str(&block);
        }
        let text = self.orch_turn(&message).await?;
        if let Some(plan) = runner::parse_report::<Plan>(&text) {
            self.pending_research = extract_research(&text);
            return self.review_policy_preview(plan);
        }
        let retry = self.orch_turn(JSON_RETRY_MSG).await?;
        match runner::parse_report::<Plan>(&retry) {
            Some(plan) => {
                self.pending_research = extract_research(&retry);
                self.review_policy_preview(plan)
            }
            None => Ok(PlanRequest::NotReady(if retry.trim().is_empty() {
                text
            } else {
                retry
            })),
        }
    }
}

/// The third planner voice offered on the plan-request turn's prompt, one
/// sentence: beside plan JSON and prose questions, the planner may escalate
/// "I can produce a plan, but it is likely WRONG". Always planner-initiated
/// via this exact JSON shape — never inferred from prose.
const WRONG_PLAN_PROMPT_CHANNEL: &str = "If you can produce a plan but believe it is likely \
     WRONG — the goal is misframed, the premise is broken, the spec is confidently off — \
     respond with ONLY {\"wrongPlan\": \"<one-paragraph reason>\"}.";

/// The bounded revision turns the Flight Rules fixed-point loop may take
/// before planning parks (KRZ-345, design D-D): each turn delivers the exact
/// rule delta the plan's touch set newly activates, so a planner that keeps
/// widening its touch set cannot loop planning forever.
const MAX_STANDARDS_REVISION_TURNS: usize = 3;

/// Wire shape of the planner-initiated wrong-plan escalation reply.
#[derive(serde::Deserialize)]
struct WrongPlanReply {
    #[serde(rename = "wrongPlan")]
    wrong_plan: String,
}

/// The wrong-plan escalation, iff `text` parses (leniently, exactly like a
/// plan reply) as JSON carrying a non-empty `wrongPlan` string. Prose that
/// merely TALKS about the plan being wrong is never an escalation: no JSON
/// `wrongPlan` key, no variant.
fn parse_wrong_plan(text: &str) -> Option<String> {
    let reply = runner::parse_report::<WrongPlanReply>(text)?;
    let reason = reply.wrong_plan.trim();
    if reason.is_empty() {
        None
    } else {
        Some(reason.to_string())
    }
}

/// Upsert one mission's line in the missions catalog (`missions/index.md`):
/// `- <date> · [<id>](<id>/plan.md) — <goal>`. Newest last; a re-approval
/// replaces the mission's existing line instead of appending a duplicate.
pub fn upsert_mission_index(
    existing: &str,
    mission_id: &str,
    goal: &str,
    date: chrono::NaiveDate,
) -> String {
    const HEADER: &str = "# Kranz missions\n\nApproved plans, newest last.\n";
    let goal = crate::scrub::truncate_chars(goal.trim(), 120).replace('\n', " ");
    let line = format!("- {date} · [{mission_id}]({mission_id}/plan.md) — {goal}");
    let marker = format!("[{mission_id}](");

    let mut out = String::new();
    let mut replaced = false;
    let body = if existing.trim().is_empty() {
        HEADER
    } else {
        existing
    };
    for l in body.lines() {
        if l.contains(&marker) {
            out.push_str(&line);
            replaced = true;
        } else {
            out.push_str(l);
        }
        out.push('\n');
    }
    if !replaced {
        out.push_str(&line);
        out.push('\n');
    }
    out
}

/// Prompt policy asking the orchestrator to document its research for
/// broad/expensive plans (mirrors [`considered_alternatives_prompt_policy`]'s
/// triggers). The evidence lands in `research.md` beside `plan.md`.
fn research_prompt_policy(cfg: &MissionConfig) -> String {
    let mut triggers = Vec::new();
    if cfg.considered_alternatives_feature_threshold > 0 {
        triggers.push(format!(
            "{}+ features",
            cfg.considered_alternatives_feature_threshold
        ));
    }
    if cfg.considered_alternatives_touch_set_threshold > 0 {
        triggers.push(format!(
            "{}+ touchSet patterns",
            cfg.considered_alternatives_touch_set_threshold
        ));
    }
    if cfg.considered_alternatives_high_usd_threshold > 0.0 {
        triggers.push(format!(
            "likely high estimate at or above ${:.2}",
            cfg.considered_alternatives_high_usd_threshold
        ));
    }
    if triggers.is_empty() {
        return "The optional research object may be omitted.".to_string();
    }
    format!(
        "Policy: if this plan crosses any large-scope trigger ({}) include a research object \
         documenting filesRead, sources, facts (each with concise evidence: a path, command, or \
         URL), ambiguities/stale docs found, and candidateKnowledgeUpdates (proposed docs/knowledge/ \
         notes). Small plans may omit it.",
        triggers.join(", ")
    )
}

fn considered_alternatives_prompt_policy(cfg: &MissionConfig) -> String {
    let feature_threshold = cfg.considered_alternatives_feature_threshold;
    let touch_threshold = cfg.considered_alternatives_touch_set_threshold;
    let cost_threshold = cfg.considered_alternatives_high_usd_threshold;
    let mut triggers = Vec::new();
    if feature_threshold > 0 {
        triggers.push(format!("{feature_threshold}+ features"));
    }
    if touch_threshold > 0 {
        triggers.push(format!("{touch_threshold}+ touchSet patterns"));
    }
    if cost_threshold > 0.0 {
        triggers.push(format!(
            "likely high estimate at or above ${cost_threshold:.2}"
        ));
    }
    if triggers.is_empty() {
        return "The optional consideredAlternatives field may be omitted.".to_string();
    }
    format!(
        "Policy: if this plan crosses any large-scope trigger ({}) include \
         consideredAlternatives with a non-empty chosen approach and at least two rejected \
         approaches, each with a one-line tradeOff. Small plans may omit it.",
        triggers.join(", ")
    )
}

pub(crate) fn validate_considered_alternatives(
    plan: &Plan,
    estimate: &cost::CostEstimate,
    cfg: &MissionConfig,
) -> Result<()> {
    let required = considered_alternatives_requirement(plan, estimate, cfg);
    match (&plan.considered_alternatives, required) {
        (None, Some(reason)) => Err(EngineError::InvalidState(format!(
            "considered alternatives required: {reason}. Add consideredAlternatives with a \
             chosen approach and at least two rejected approaches with tradeOff."
        ))),
        (Some(alternatives), _) => validate_considered_alternatives_body(alternatives),
        (None, None) => Ok(()),
    }
}

pub(crate) fn considered_alternatives_requirement(
    plan: &Plan,
    estimate: &cost::CostEstimate,
    cfg: &MissionConfig,
) -> Option<String> {
    let features = plan_feature_count(plan);
    if cfg.considered_alternatives_feature_threshold > 0
        && features >= cfg.considered_alternatives_feature_threshold
    {
        return Some(format!(
            "{features} feature(s) >= feature threshold {}",
            cfg.considered_alternatives_feature_threshold
        ));
    }
    let touch_set = plan.touch_set.len();
    if cfg.considered_alternatives_touch_set_threshold > 0
        && touch_set >= cfg.considered_alternatives_touch_set_threshold
    {
        return Some(format!(
            "{touch_set} touchSet pattern(s) >= touchSet threshold {}",
            cfg.considered_alternatives_touch_set_threshold
        ));
    }
    if cfg.considered_alternatives_high_usd_threshold > 0.0
        && estimate.high_usd >= cfg.considered_alternatives_high_usd_threshold
    {
        return Some(format!(
            "estimated high cost ${:.2} >= cost threshold ${:.2}",
            estimate.high_usd, cfg.considered_alternatives_high_usd_threshold
        ));
    }
    None
}

fn validate_considered_alternatives_body(alternatives: &ConsideredAlternatives) -> Result<()> {
    if alternatives.chosen.trim().is_empty() {
        return Err(EngineError::InvalidState(
            "consideredAlternatives.chosen must not be empty".to_string(),
        ));
    }
    let valid_rejected = alternatives
        .rejected
        .iter()
        .filter(|r| !r.approach.trim().is_empty() && !r.trade_off.trim().is_empty())
        .count();
    if valid_rejected < 2 {
        return Err(EngineError::InvalidState(
            "consideredAlternatives.rejected must include at least two entries with approach \
             and tradeOff"
                .to_string(),
        ));
    }
    Ok(())
}

fn plan_feature_count(plan: &Plan) -> usize {
    plan.milestones.iter().map(|m| m.features.len()).sum()
}

pub(crate) fn validate_revised_plan_for_gate(mission: &Mission, plan: &Plan) -> Result<()> {
    if plan.reviewer_independence != mission.reviewer_independence {
        return Err(EngineError::Config(
            "revised plan cannot change the approved reviewerIndependence policy".into(),
        ));
    }
    if plan.milestones.is_empty() {
        return Err(EngineError::InvalidState(
            "revised plan has no milestones".to_string(),
        ));
    }
    if let Some(empty) = plan.milestones.iter().find(|m| m.features.is_empty()) {
        return Err(EngineError::InvalidState(format!(
            "revised plan milestone '{}' has no features",
            empty.title
        )));
    }
    crate::contract_controls::validate(&plan.validation_contract)?;
    validate_contract_extends(&mission.validation_contract, &plan.validation_contract)?;
    validate_vec_extends(
        "commandGrants",
        &mission.command_grants,
        &plan.command_grants,
    )?;
    validate_vec_extends("touchSet", &mission.touch_set, &plan.touch_set)?;

    let completed: Vec<&Milestone> = mission
        .milestones
        .iter()
        .filter(|m| m.status == MilestoneStatus::Complete)
        .collect();
    for (i, done) in completed.iter().enumerate() {
        let revised = plan.milestones.get(i).ok_or_else(|| {
            EngineError::InvalidState(format!(
                "revised plan drops completed milestone '{}' (must appear first, unchanged)",
                done.title
            ))
        })?;
        if revised.title.trim() != done.title.trim() {
            return Err(EngineError::InvalidState(format!(
                "revised plan milestone {} is '{}' but completed milestone '{}' must appear \
                 there unchanged",
                i + 1,
                revised.title,
                done.title
            )));
        }
        if !completed_features_unchanged(done, revised) {
            return Err(EngineError::InvalidState(format!(
                "revised plan alters the features of completed milestone '{}'",
                done.title
            )));
        }
    }
    Ok(())
}

fn validate_contract_extends(existing: &[Assertion], revised: &[Assertion]) -> Result<()> {
    for old in existing {
        let Some(new) = revised.iter().find(|a| a.id == old.id) else {
            return Err(EngineError::InvalidState(format!(
                "revised plan removes validation assertion '{}'",
                old.id
            )));
        };
        if old.statement != new.statement
            || old.check != new.check
            || old.command != new.command
            || old.negative_control != new.negative_control
        {
            return Err(EngineError::InvalidState(format!(
                "revised plan changes validation assertion '{}'",
                old.id
            )));
        }
    }
    Ok(())
}

fn validate_vec_extends(label: &str, existing: &[String], revised: &[String]) -> Result<()> {
    for old in existing {
        if !revised.iter().any(|new| new == old) {
            return Err(EngineError::InvalidState(format!(
                "revised plan removes {label} entry '{old}'"
            )));
        }
    }
    Ok(())
}

/// Whether a completed milestone's feature set is reproduced UNCHANGED in the
/// revised plan milestone (roadmap M2 re-planning guard). Delegates to the
/// reducer's canonical [`reducer::completed_features_match`] so this pre-emit
/// gate and the reducer's fold can never disagree: if they did, the gate could
/// accept a revision the reducer rejects, and `emit` (which appends before it
/// folds) would leave an unfoldable event in the append-only log.
pub(crate) fn completed_features_unchanged(done: &Milestone, revised: &PlanMilestone) -> bool {
    reducer::completed_features_match(&done.features, &revised.features)
}

/// Normalize a feature title for matching across a re-plan (trim + lowercase):
/// trivial editorial differences must not spuriously drop or re-add a feature.
pub(crate) fn norm_title(title: &str) -> String {
    title.trim().to_lowercase()
}

/// Assign `a-1..` ids to contract assertions with missing ids and
/// de-duplicate colliding ones (unique-ish, plan §4.5).
pub(crate) fn assign_assertion_ids(contract: &mut [Assertion]) {
    let mut seen = std::collections::HashSet::new();
    let mut counter = 0usize;
    for assertion in contract.iter_mut() {
        let id = assertion.id.trim().to_string();
        let id = if id.is_empty() || seen.contains(&id) {
            loop {
                counter += 1;
                let candidate = format!("a-{counter}");
                if !seen.contains(&candidate) {
                    break candidate;
                }
            }
        } else {
            id
        };
        seen.insert(id.clone());
        assertion.id = id;
    }
}

/// JSON Schema for [`Plan`] (camelCase), embedded in the request_plan turn.
fn plan_schema() -> serde_json::Value {
    let control_files = serde_json::json!({
        "type": "array",
        "minItems": 1,
        "items": {
            "type": "object",
            "additionalProperties": false,
            "required": ["path", "content"],
            "properties": {
                "path": { "type": "string" },
                "content": { "type": "string" }
            }
        }
    });
    let pair_expectation = serde_json::json!({"oneOf": [
        {"type": "object", "additionalProperties": false, "required": ["outcome"],
         "properties": {"outcome": {"const": "passed"}}},
        {"type": "object", "additionalProperties": false, "required": ["outcome", "failureId"],
         "properties": {"outcome": {"const": "failed"}, "failureId": {"type": "string", "minLength": 1, "maxLength": 128}}},
        {"type": "object", "additionalProperties": false, "required": ["outcome", "failureId", "diagnostic"],
         "properties": {"outcome": {"const": "diagnostic"}, "failureId": {"type": "string", "minLength": 1, "maxLength": 128},
            "diagnostic": {"type": "string", "minLength": 1, "maxLength": 1024}}}
    ]});
    let negative_control = serde_json::json!({
        "type": "object",
        "additionalProperties": false,
        "required": ["checkerFiles", "validFiles", "defectiveFiles", "expectedFailure"],
        "properties": {
            "checkerFiles": control_files.clone(),
            "validFiles": control_files.clone(),
            "defectiveFiles": control_files,
            "expectedFailure": { "type": "string" },
            "timeoutSeconds": { "type": "integer", "minimum": 1, "maximum": 180, "default": 60 },
            "baselinePair": {
                "type": "object", "additionalProperties": false,
                "required": ["baselineRevision", "expectedBaseline", "expectedCandidate", "environmentLabel", "overlayCheckerOnBaseline"],
                "properties": {
                    "baselineRevision": {"type": "string", "pattern": "^([0-9a-f]{40}|[0-9a-f]{64})$"},
                    "expectedBaseline": pair_expectation.clone(), "expectedCandidate": pair_expectation,
                    "environmentLabel": {"type": "string", "minLength": 1, "maxLength": 256},
                    "overlayCheckerOnBaseline": {"type": "boolean"}
                }
            }
        }
    });
    let validation_contract = serde_json::json!({
        "type": "array",
        "items": {
            "type": "object",
            "additionalProperties": false,
            "required": ["id", "statement", "check"],
            "properties": {
                "id": { "type": "string" },
                "statement": { "type": "string" },
                "check": { "type": "string", "enum": ["command", "agent-judgement", "pty-script"] },
                "command": { "type": "string" },
                "negativeControl": negative_control,
                "ptyScript": {
                    "type": "object",
                    "additionalProperties": false,
                    "required": ["command", "steps"],
                    "properties": {
                        "command": { "type": "string" },
                        "timeoutSecs": { "type": "integer" },
                        "steps": {
                            "type": "array",
                            "items": {
                                "type": "object",
                                "additionalProperties": false,
                                "required": ["op"],
                                "properties": {
                                    "op": { "type": "string", "enum": ["send", "expect"] },
                                    "text": { "type": "string" },
                                    "pattern": { "type": "string" },
                                    "regex": { "type": "boolean" },
                                    "timeoutMs": { "type": "integer" }
                                }
                            }
                        }
                    }
                }
            }
        }
    });
    serde_json::json!({
        "type": "object",
        "additionalProperties": false,
        "required": ["goal", "validationContract", "milestones"],
        "properties": {
            "goal": { "type": "string" },
            "consideredAlternatives": {
                "type": "object",
                "additionalProperties": false,
                "required": ["chosen", "rejected"],
                "properties": {
                    "chosen": { "type": "string" },
                    "rejected": {
                        "type": "array",
                        "minItems": 2,
                        "items": {
                            "type": "object",
                            "additionalProperties": false,
                            "required": ["approach", "tradeOff"],
                            "properties": {
                                "approach": { "type": "string" },
                                "tradeOff": { "type": "string" }
                            }
                        }
                    }
                }
            },
            "research": {
                "type": "object",
                "additionalProperties": false,
                "properties": {
                    "filesRead": { "type": "array", "items": { "type": "string" } },
                    "sources": { "type": "array", "items": { "type": "string" } },
                    "facts": {
                        "type": "array",
                        "items": {
                            "type": "object",
                            "additionalProperties": false,
                            "properties": {
                                "fact": { "type": "string" },
                                "evidence": { "type": "string" }
                            }
                        }
                    },
                    "ambiguities": { "type": "array", "items": { "type": "string" } },
                    "candidateKnowledgeUpdates": { "type": "array", "items": { "type": "string" } }
                }
            },
            "validationContract": validation_contract,
            "milestones": {
                "type": "array",
                "minItems": 1,
                "items": {
                    "type": "object",
                    "additionalProperties": false,
                    "required": ["title", "features"],
                    "properties": {
                        "title": { "type": "string" },
                        "features": {
                            "type": "array",
                            "minItems": 1,
                            "items": {
                                "type": "object",
                                "additionalProperties": false,
                                "required": ["title", "spec", "validationCriteria"],
                                "properties": {
                                    "title": { "type": "string" },
                                    "spec": { "type": "string" },
                                    "validationCriteria": {
                                        "type": "array",
                                        "items": { "type": "string" }
                                    }
                                }
                            }
                        }
                    }
                }
            },
            "commandGrants": {
                "type": "array",
                "items": { "type": "string" }
            },
            "touchSet": {
                "type": "array",
                "items": { "type": "string" }
            }
        }
    })
}

// ---------------------------------------------------------------------------
// Unit tests for the tricky pure helpers
// ---------------------------------------------------------------------------

#[cfg(test)]
mod tests {
    use super::*;

    #[test]
    fn reviewed_plan_identity_binds_work_permissions_and_reviewer_policy() {
        let value = serde_json::json!({
            "goal": "ship it", "validationContract": [], "milestones": []
        });
        let plan: Plan = serde_json::from_value(value.clone()).unwrap();
        let identity = plan_identity(&plan);
        assert_eq!(identity.len(), 64);
        assert_eq!(identity, plan_identity(&plan.clone()));
        for (field, changed) in [
            ("goal", serde_json::json!("ship another thing")),
            ("commandGrants", serde_json::json!(["cargo test"])),
            ("touchSet", serde_json::json!(["crates/"])),
            (
                "reviewerIndependence",
                serde_json::json!({"scrutiny": true, "functional": false}),
            ),
            (
                "validationContract",
                serde_json::json!([{
                    "id": "a-1", "statement": "new requirement", "check": "agent-judgement"
                }]),
            ),
        ] {
            let mut changed_plan = value.clone();
            changed_plan[field] = changed;
            let changed_plan: Plan = serde_json::from_value(changed_plan).unwrap();
            assert_ne!(
                identity,
                plan_identity(&changed_plan),
                "identity must bind {field}"
            );
        }
    }

    fn assertion(id: &str) -> Assertion {
        Assertion {
            id: id.to_string(),
            statement: "s".to_string(),
            check: AssertionCheck::AgentJudgement,
            command: None,
            pty_script: None,
            negative_control: None,
        }
    }

    fn controlled_assertion() -> Assertion {
        serde_json::from_value(serde_json::json!({
            "id": "a-1", "statement": "reject the defect", "check": "command", "command": "sh check.sh",
            "negativeControl": {
                "checkerFiles": [{"path": "check.sh", "content": "check"}],
                "validFiles": [{"path": "src/value.txt", "content": "valid"}],
                "defectiveFiles": [{"path": "src/value.txt", "content": "defect"}],
                "expectedFailure": "wrong-value"
            }
        }))
        .unwrap()
    }

    #[test]
    fn negative_control_schema_is_optional_and_carries_reviewable_fixtures() {
        let schema = plan_schema();
        let item = &schema["properties"]["validationContract"]["items"];
        assert!(!item["required"]
            .as_array()
            .unwrap()
            .contains(&serde_json::json!("negativeControl")));
        let spec = &item["properties"]["negativeControl"];
        for group in ["checkerFiles", "validFiles", "defectiveFiles"] {
            assert!(spec["required"]
                .as_array()
                .unwrap()
                .contains(&serde_json::json!(group)));
            assert_eq!(
                spec["properties"][group]["items"]["required"],
                serde_json::json!(["path", "content"])
            );
        }
        assert_eq!(spec["properties"]["timeoutSeconds"]["default"], 60);
        assert_eq!(spec["properties"]["timeoutSeconds"]["maximum"], 180);
        let controlled = controlled_assertion();
        assert_eq!(
            controlled
                .negative_control
                .as_ref()
                .unwrap()
                .timeout_seconds,
            60
        );
        crate::contract_controls::validate(&[controlled]).unwrap();
        assert!(serde_json::to_value(assertion("old"))
            .unwrap()
            .get("negativeControl")
            .is_none());
    }

    #[test]
    fn negative_control_revision_pins_every_approved_control_field() {
        let old = controlled_assertion();
        validate_contract_extends(std::slice::from_ref(&old), std::slice::from_ref(&old)).unwrap();
        let mutations = [
            (
                "checkerFiles",
                serde_json::json!([{"path": "check.sh", "content": "changed checker"}]),
            ),
            (
                "validFiles",
                serde_json::json!([{"path": "src/value.txt", "content": "different valid"}]),
            ),
            (
                "defectiveFiles",
                serde_json::json!([{"path": "src/value.txt", "content": "other defect"}]),
            ),
            ("expectedFailure", serde_json::json!("another-defect")),
            ("timeoutSeconds", serde_json::json!(90)),
        ];
        for (field, value) in mutations {
            let mut changed = serde_json::to_value(&old).unwrap();
            changed["negativeControl"][field] = value;
            let changed: Assertion = serde_json::from_value(changed).unwrap();
            assert!(
                validate_contract_extends(std::slice::from_ref(&old), &[changed]).is_err(),
                "changed {field}"
            );
        }
        let mut removed = old.clone();
        removed.negative_control = None;
        assert!(validate_contract_extends(
            std::slice::from_ref(&old),
            std::slice::from_ref(&removed)
        )
        .is_err());
        assert!(
            validate_contract_extends(&[removed], &[old]).is_err(),
            "adding a control to an existing assertion changes its approved identity"
        );
    }

    #[test]
    fn assign_assertion_ids_fills_missing_and_dedupes() {
        let mut contract = vec![
            assertion(""),
            assertion("x"),
            assertion("x"),
            assertion("a-2"),
        ];
        assign_assertion_ids(&mut contract);
        let ids: Vec<&str> = contract.iter().map(|a| a.id.as_str()).collect();
        assert_eq!(ids[0], "a-1", "missing id gets a-1");
        assert_eq!(ids[1], "x", "explicit unique id is kept");
        assert_ne!(ids[2], "x", "duplicate must be renamed");
        let unique: std::collections::HashSet<&&str> = ids.iter().collect();
        assert_eq!(unique.len(), 4, "all ids unique: {ids:?}");
    }

    #[test]
    fn plan_schema_matches_plan_shape() {
        // A Plan serialized to JSON uses exactly the keys the schema names.
        let plan = Plan {
            goal: "g".into(),
            validation_contract: vec![Assertion {
                id: "a-1".into(),
                statement: "s".into(),
                check: AssertionCheck::Command,
                command: Some("true".into()),
                pty_script: None,
                negative_control: None,
            }],
            milestones: vec![PlanMilestone {
                title: "m".into(),
                features: vec![PlanFeature {
                    title: "f".into(),
                    spec: "s".into(),
                    validation_criteria: vec!["c".into()],
                }],
            }],
            considered_alternatives: Some(ConsideredAlternatives {
                chosen: "single safe slice".into(),
                rejected: vec![
                    RejectedAlternative {
                        approach: "big bang".into(),
                        trade_off: "too broad".into(),
                    },
                    RejectedAlternative {
                        approach: "docs only".into(),
                        trade_off: "does not deliver behavior".into(),
                    },
                ],
            }),
            command_grants: vec!["gc lint".into()],
            touch_set: vec!["src/**".into()],
            // The planner-facing schema deliberately has no standardsManifest
            // key: the pin is engine-authored at approval (KRZ-342 D-E), and
            // `None` keeps the serialized shape (and this test) unchanged.
            standards_manifest: None,
            reviewer_independence: None,
        };
        let value = serde_json::to_value(&plan).unwrap();
        let schema = plan_schema();
        let props = schema["properties"].as_object().unwrap();
        for key in value.as_object().unwrap().keys() {
            assert!(
                props.contains_key(key),
                "schema missing top-level key {key}"
            );
        }
    }
}