kore_fileformat 1.3.3

KORE — Killer Optimized Record Exchange: standalone Rust crate (zero deps)
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
/// DuckDB Connector - Integration layer for DuckDB
/// 
/// Enables DuckDB to read/write Kore files natively.
/// Usage: SELECT * FROM 'file.kore' in DuckDB

use std::path::{Path, PathBuf};
use crate::arrow_converter::{ArrowSchema, ArrowRecordBatch, ArrowConverter, ArrowDataType, ArrowField, ArrowColumn};
use crate::kore_reader::KoreReader;
use crate::kore_writer::KoreWriter;
use std::io::{Read, Write};
use std::fs::File;

/// DuckDB connector for Kore files
pub struct KoreDuckDBConnector {
    file_path: PathBuf,
    schema: Option<ArrowSchema>,
    mode: ConnectorMode,
}

/// Connector operating mode
#[derive(Debug, Clone, Copy, PartialEq)]
pub enum ConnectorMode {
    /// Read-only mode (SELECT queries)
    Read,
    /// Write-only mode (INSERT queries)
    Write,
    /// Append mode (INSERT + SELECT)
    ReadWrite,
}

impl KoreDuckDBConnector {
    /// Create a new connector pointing to a Kore file
    /// 
    /// # Arguments
    /// * `file_path` - Path to the .kore file
    /// 
    /// # Examples
    /// ```
    /// use kore_fileformat::duckdb_connector::KoreDuckDBConnector;
    /// # fn main() -> Result<(), Box<dyn std::error::Error>> {
    /// let connector = KoreDuckDBConnector::new("data.kore")?;
    /// # Ok(())
    /// # }
    pub fn new(file_path: &str) -> Result<Self, String> {
        let path = PathBuf::from(file_path);
        
        // Validate path
        if file_path.is_empty() {
            return Err("File path cannot be empty".to_string());
        }

        Ok(Self {
            file_path: path,
            schema: None,
            mode: ConnectorMode::ReadWrite,
        })
    }

    /// Create connector in read-only mode
    pub fn read(file_path: &str) -> Result<Self, String> {
        let mut connector = Self::new(file_path)?;
        connector.mode = ConnectorMode::Read;
        Ok(connector)
    }

    /// Create connector in write-only mode
    pub fn write(file_path: &str) -> Result<Self, String> {
        let mut connector = Self::new(file_path)?;
        connector.mode = ConnectorMode::Write;
        Ok(connector)
    }

    /// Get the file path
    pub fn file_path(&self) -> &Path {
        &self.file_path
    }

    /// Get the operating mode
    pub fn mode(&self) -> ConnectorMode {
        self.mode
    }

    /// Get the schema (if loaded)
    pub fn schema(&self) -> Option<&ArrowSchema> {
        self.schema.as_ref()
    }

    /// Set the schema
    pub fn set_schema(&mut self, schema: ArrowSchema) {
        self.schema = Some(schema);
    }

    /// Read Kore file as Arrow RecordBatch
    /// 
    /// This method loads the entire file into memory as Arrow format.
    /// For large files, consider using `read_batches()` for streaming.
    /// 
    /// # Returns
    /// * `Ok(ArrowRecordBatch)` - The data in Arrow format
    /// * `Err(String)` - If file cannot be read or is invalid
    pub fn read_as_arrow(&mut self) -> Result<ArrowRecordBatch, String> {
        // Check if in read/write mode
        match self.mode {
            ConnectorMode::Write => {
                return Err(
                    "Cannot read in write-only mode".to_string()
                );
            }
            _ => {}
        }

        // Read file into memory
        let mut file = File::open(&self.file_path)
            .map_err(|e| format!("Failed to open file: {}", e))?;
        
        let mut file_bytes = Vec::new();
        file.read_to_end(&mut file_bytes)
            .map_err(|e| format!("Failed to read file: {}", e))?;

        // Parse Kore file
        let mut reader = KoreReader::new(file_bytes)
            .map_err(|e| format!("Invalid Kore file: {}", e))?;

        // Clone header info before mutating reader
        let col_count = reader.header().column_count as usize;
        let row_count = reader.header().row_count as usize;
        let col_metadata: Vec<_> = reader.header().columns.clone();
        
        // Build Arrow schema from Kore metadata
        let mut fields = Vec::new();
        for col_meta in &col_metadata {
            let arrow_type = Self::kore_data_type_to_arrow(col_meta.data_type)?;
            fields.push(ArrowField {
                name: col_meta.name.clone(),
                data_type: arrow_type,
                nullable: true,
            });
        }
        let schema = ArrowSchema::new(fields);

        // Read all columns
        let mut columns = Vec::new();
        for col_idx in 0..col_count {
            let col_data = reader.read_column(col_idx)
                .map_err(|e| format!("Failed to read column {}: {}", col_idx, e))?;
            
            let col_meta = &col_metadata[col_idx];
            let arrow_col = Self::decode_kore_column(col_meta.data_type, &col_data)?;
            columns.push(arrow_col);
        }

        // Store schema and return batch
        let batch = ArrowRecordBatch::new(schema, columns, row_count);
        self.set_schema(batch.schema.clone());

        Ok(batch)
    }

    /// Convert Kore data type byte to Arrow type
    fn kore_data_type_to_arrow(kore_type: u8) -> Result<ArrowDataType, String> {
        match kore_type {
            0 => Ok(ArrowDataType::Int64),
            1 => Ok(ArrowDataType::Float64),
            2 => Ok(ArrowDataType::Utf8),
            3 => Ok(ArrowDataType::Boolean),
            4 => Ok(ArrowDataType::Binary),
            _ => Err(format!("Unknown Kore data type: {}", kore_type)),
        }
    }

    /// Decode Kore binary column data into Arrow column
    /// Convert Arrow column to raw Kore bytes
    /// 
    /// Reverses the decode_kore_column process by converting Arrow columns back to binary format
    fn arrow_column_to_kore_bytes(column: &ArrowColumn) -> Result<Vec<u8>, String> {
        let mut bytes = Vec::new();

        match column {
            ArrowColumn::Null(nulls) => {
                for &n in nulls {
                    bytes.push(if n { 1 } else { 0 });
                }
            }
            ArrowColumn::Boolean(data) => {
                for &b in data {
                    bytes.push(if b { 1 } else { 0 });
                }
            }
            ArrowColumn::Int8(data) => {
                for &v in data {
                    bytes.push(v as u8);
                }
            }
            ArrowColumn::Int16(data) => {
                for &v in data {
                    bytes.extend_from_slice(&v.to_le_bytes());
                }
            }
            ArrowColumn::Int32(data) => {
                for &v in data {
                    bytes.extend_from_slice(&v.to_le_bytes());
                }
            }
            ArrowColumn::Int64(data) => {
                for &v in data {
                    bytes.extend_from_slice(&v.to_le_bytes());
                }
            }
            ArrowColumn::UInt8(data) => {
                bytes.extend_from_slice(data);
            }
            ArrowColumn::UInt16(data) => {
                for &v in data {
                    bytes.extend_from_slice(&v.to_le_bytes());
                }
            }
            ArrowColumn::UInt32(data) => {
                for &v in data {
                    bytes.extend_from_slice(&v.to_le_bytes());
                }
            }
            ArrowColumn::UInt64(data) => {
                for &v in data {
                    bytes.extend_from_slice(&v.to_le_bytes());
                }
            }
            ArrowColumn::Float32(data) => {
                for &v in data {
                    bytes.extend_from_slice(&v.to_le_bytes());
                }
            }
            ArrowColumn::Float64(data) => {
                for &v in data {
                    bytes.extend_from_slice(&v.to_le_bytes());
                }
            }
            ArrowColumn::Binary(data) => {
                for vec in data {
                    bytes.extend_from_slice(&(vec.len() as u32).to_le_bytes());
                    bytes.extend_from_slice(vec);
                }
            }
            ArrowColumn::Utf8(data) => {
                for s in data {
                    let s_bytes = s.as_bytes();
                    bytes.extend_from_slice(&(s_bytes.len() as u32).to_le_bytes());
                    bytes.extend_from_slice(s_bytes);
                }
            }
            ArrowColumn::List(data) => {
                for vec in data {
                    bytes.extend_from_slice(&(vec.len() as u32).to_le_bytes());
                    bytes.extend_from_slice(vec);
                }
            }
        }

        Ok(bytes)
    }

    /// Convert Arrow data type to Kore data type code
    /// 
    /// Maps Arrow types to Kore's simplified type system:
    /// 0 = Int64 (i64), 1 = Float64 (f64), 2 = String (UTF-8)
    /// 3 = Boolean (bool), 4 = Binary (bytes)
    fn arrow_type_to_kore_type(arrow_type: &ArrowDataType) -> Result<u8, String> {
        match arrow_type {
            ArrowDataType::Int64 => Ok(0),
            ArrowDataType::Float64 => Ok(1),
            ArrowDataType::Utf8 => Ok(2),
            ArrowDataType::Boolean => Ok(3),
            ArrowDataType::Binary => Ok(4),
            // For other types, map to closest Kore type
            ArrowDataType::Int8 | ArrowDataType::Int16 | ArrowDataType::Int32 => Ok(0),
            ArrowDataType::UInt8 | ArrowDataType::UInt16 | ArrowDataType::UInt32 | ArrowDataType::UInt64 => Ok(0),
            ArrowDataType::Float32 => Ok(1),
            ArrowDataType::Null => Ok(3), // Map Null to boolean for compatibility
            _ => Err(format!("Unsupported Arrow type for Kore: {:?}", arrow_type)),
        }
    }

    fn decode_kore_column(data_type: u8, data: &[u8]) -> Result<ArrowColumn, String> {
        match data_type {
            0 => {
                // Int64: 8 bytes per value
                let count = data.len() / 8;
                let mut values = Vec::with_capacity(count);
                for i in 0..count {
                    let bytes = [
                        data[i*8], data[i*8+1], data[i*8+2], data[i*8+3],
                        data[i*8+4], data[i*8+5], data[i*8+6], data[i*8+7],
                    ];
                    values.push(i64::from_le_bytes(bytes));
                }
                Ok(ArrowColumn::Int64(values))
            }
            1 => {
                // Float64: 8 bytes per value
                let count = data.len() / 8;
                let mut values = Vec::with_capacity(count);
                for i in 0..count {
                    let bytes = [
                        data[i*8], data[i*8+1], data[i*8+2], data[i*8+3],
                        data[i*8+4], data[i*8+5], data[i*8+6], data[i*8+7],
                    ];
                    values.push(f64::from_le_bytes(bytes));
                }
                Ok(ArrowColumn::Float64(values))
            }
            2 => {
                // String: length-prefixed (matches arrow_column_to_kore_bytes encoding)
                let mut values = Vec::new();
                let mut pos = 0;
                while pos < data.len() {
                    if pos + 4 > data.len() {
                        break; // Not enough data for length prefix
                    }
                    let len = u32::from_le_bytes([data[pos], data[pos+1], data[pos+2], data[pos+3]]) as usize;
                    pos += 4;
                    if pos + len > data.len() {
                        break; // Not enough data for string content
                    }
                    let s = String::from_utf8(data[pos..pos+len].to_vec())
                        .map_err(|e| format!("Invalid UTF-8 in string column: {}", e))?;
                    values.push(s);
                    pos += len;
                }
                Ok(ArrowColumn::Utf8(values))
            }
            3 => {
                // Boolean: 1 byte per value
                let values = data.iter().map(|&b| b != 0).collect();
                Ok(ArrowColumn::Boolean(values))
            }
            4 => {
                // Binary: variable length
                // Parse as length-prefixed chunks
                let mut values = Vec::new();
                let mut pos = 0;
                while pos < data.len() {
                    if pos + 4 > data.len() {
                        break;
                    }
                    let len = u32::from_le_bytes([data[pos], data[pos+1], data[pos+2], data[pos+3]]) as usize;
                    pos += 4;
                    if pos + len > data.len() {
                        break;
                    }
                    values.push(data[pos..pos+len].to_vec());
                    pos += len;
                }
                Ok(ArrowColumn::Binary(values))
            }
            _ => Err(format!("Unknown data type: {}", data_type)),
        }
    }

    /// Read Kore file in streaming batches
    /// 
    /// Useful for large files to avoid memory overflow.
    /// 
    /// # Arguments
    /// * `batch_size` - Number of rows per batch
    /// 
    /// # Returns
    /// * Iterator of RecordBatches
    pub fn read_batches(&mut self, batch_size: usize) -> Result<Vec<ArrowRecordBatch>, String> {
        if batch_size == 0 {
            return Err("Batch size must be > 0".to_string());
        }

        // Read entire file first
        let full_batch = self.read_as_arrow()?;

        if full_batch.row_count == 0 {
            return Ok(vec![]);
        }

        // Split into batches
        let mut batches = Vec::new();
        let mut row_pos = 0;

        while row_pos < full_batch.row_count {
            let end_row = std::cmp::min(row_pos + batch_size, full_batch.row_count);
            let batch_rows = end_row - row_pos;

            // Create sliced columns for this batch
            let mut batch_columns = Vec::new();
            for col in &full_batch.columns {
                let sliced_col = Self::slice_column(col, row_pos, batch_rows)?;
                batch_columns.push(sliced_col);
            }

            let batch = ArrowRecordBatch::new(
                full_batch.schema.clone(),
                batch_columns,
                batch_rows,
            );
            batches.push(batch);

            row_pos = end_row;
        }

        Ok(batches)
    }

    /// Slice a column to extract a range of rows
    fn slice_column(col: &ArrowColumn, start_row: usize, num_rows: usize) -> Result<ArrowColumn, String> {
        match col {
            ArrowColumn::Null(data) => {
                let sliced = data[start_row..start_row+num_rows].to_vec();
                Ok(ArrowColumn::Null(sliced))
            }
            ArrowColumn::Boolean(data) => {
                let sliced = data[start_row..start_row+num_rows].to_vec();
                Ok(ArrowColumn::Boolean(sliced))
            }
            ArrowColumn::Int8(data) => {
                let sliced = data[start_row..start_row+num_rows].to_vec();
                Ok(ArrowColumn::Int8(sliced))
            }
            ArrowColumn::Int16(data) => {
                let sliced = data[start_row..start_row+num_rows].to_vec();
                Ok(ArrowColumn::Int16(sliced))
            }
            ArrowColumn::Int32(data) => {
                let sliced = data[start_row..start_row+num_rows].to_vec();
                Ok(ArrowColumn::Int32(sliced))
            }
            ArrowColumn::Int64(data) => {
                let sliced = data[start_row..start_row+num_rows].to_vec();
                Ok(ArrowColumn::Int64(sliced))
            }
            ArrowColumn::UInt8(data) => {
                let sliced = data[start_row..start_row+num_rows].to_vec();
                Ok(ArrowColumn::UInt8(sliced))
            }
            ArrowColumn::UInt16(data) => {
                let sliced = data[start_row..start_row+num_rows].to_vec();
                Ok(ArrowColumn::UInt16(sliced))
            }
            ArrowColumn::UInt32(data) => {
                let sliced = data[start_row..start_row+num_rows].to_vec();
                Ok(ArrowColumn::UInt32(sliced))
            }
            ArrowColumn::UInt64(data) => {
                let sliced = data[start_row..start_row+num_rows].to_vec();
                Ok(ArrowColumn::UInt64(sliced))
            }
            ArrowColumn::Float32(data) => {
                let sliced = data[start_row..start_row+num_rows].to_vec();
                Ok(ArrowColumn::Float32(sliced))
            }
            ArrowColumn::Float64(data) => {
                let sliced = data[start_row..start_row+num_rows].to_vec();
                Ok(ArrowColumn::Float64(sliced))
            }
            ArrowColumn::Binary(data) => {
                let sliced = data[start_row..start_row+num_rows].to_vec();
                Ok(ArrowColumn::Binary(sliced))
            }
            ArrowColumn::Utf8(data) => {
                let sliced = data[start_row..start_row+num_rows].to_vec();
                Ok(ArrowColumn::Utf8(sliced))
            }
            ArrowColumn::List(data) => {
                let sliced = data[start_row..start_row+num_rows].to_vec();
                Ok(ArrowColumn::List(sliced))
            }
        }
    }

    /// Write Arrow RecordBatch to Kore file
    /// 
    /// # Arguments
    /// * `batch` - Arrow data to write
    /// 
    /// # Returns
    /// * `Ok(u64)` - Number of rows written
    /// * `Err(String)` - If write fails
    pub fn append_from_arrow(&mut self, batch: ArrowRecordBatch) -> Result<u64, String> {
        // Check if in read/write mode
        match self.mode {
            ConnectorMode::Read => {
                return Err(
                    "Cannot write in read-only mode".to_string()
                );
            }
            _ => {}
        }

        // Validate batch
        if batch.row_count == 0 {
            return Ok(0);
        }

        // Store schema from first batch
        if self.schema.is_none() {
            self.set_schema(batch.schema.clone());
        }

        // Create KoreWriter for this batch
        let mut writer = KoreWriter::new(batch.row_count as u64);

        // Convert each Arrow column to Kore format
        for (field_idx, field) in batch.schema.fields.iter().enumerate() {
            let arrow_col = &batch.columns[field_idx];
            let kore_bytes = Self::arrow_column_to_kore_bytes(arrow_col)?;
            let data_type = Self::arrow_type_to_kore_type(&field.data_type)?;
            writer.add_column(field.name.clone(), data_type, kore_bytes);
        }

        // Write to Kore binary format with compression
        let (kore_bytes, _stats) = writer.write()
            .map_err(|e| format!("Failed to write Kore format: {}", e))?;

        // Write to file
        let mut file = File::create(&self.file_path)
            .map_err(|e| format!("Failed to create file: {}", e))?;
        
        file.write_all(&kore_bytes)
            .map_err(|e| format!("Failed to write to file: {}", e))?;

        Ok(batch.row_count as u64)
    }

    /// Get Arrow schema for this file
    pub fn arrow_schema(&mut self) -> Result<ArrowSchema, String> {
        // If already loaded, return it
        if let Some(schema) = self.schema.clone() {
            return Ok(schema);
        }

        // Otherwise, load schema from file
        // TODO: Implement schema reading from Kore metadata
        Err("Schema inference not yet implemented".to_string())
    }

    /// Get file size in bytes
    pub fn file_size(&self) -> Result<u64, String> {
        use std::fs;
        
        fs::metadata(&self.file_path)
            .map(|m| m.len())
            .map_err(|e| format!("Cannot read file metadata: {}", e))
    }

    /// Validate that the file is a valid Kore file
    pub fn validate(&self) -> Result<(), String> {
        // Check file exists
        if !self.file_path.exists() {
            // In write mode, file doesn't need to exist yet
            if self.mode == ConnectorMode::Read {
                return Err(
                    format!("File not found: {}", self.file_path.display())
                );
            }
            return Ok(());
        }

        // Check file is readable
        if !std::fs::metadata(&self.file_path)
            .map(|m| m.is_file())
            .unwrap_or(false)
        {
            return Err(
                format!("Not a file: {}", self.file_path.display())
            );
        }

        // TODO: Check Kore magic bytes
        Ok(())
    }

    /// Get row count (if known)
    pub fn row_count(&self) -> Result<Option<u64>, String> {
        // TODO: Read from Kore metadata
        Ok(None)
    }

    /// Get column count
    pub fn column_count(&self) -> Result<usize, String> {
        match &self.schema {
            Some(schema) => Ok(schema.field_count()),
            None => Err("Schema not loaded".to_string()),
        }
    }
}

/// Builder pattern for creating connectors
pub struct KoreDuckDBConnectorBuilder {
    file_path: Option<PathBuf>,
    mode: ConnectorMode,
}

impl Default for KoreDuckDBConnectorBuilder {
    fn default() -> Self {
        Self::new()
    }
}

impl KoreDuckDBConnectorBuilder {
    pub fn new() -> Self {
        Self {
            file_path: None,
            mode: ConnectorMode::ReadWrite,
        }
    }

    pub fn path(mut self, path: &str) -> Self {
        self.file_path = Some(PathBuf::from(path));
        self
    }

    pub fn read_only(mut self) -> Self {
        self.mode = ConnectorMode::Read;
        self
    }

    pub fn write_only(mut self) -> Self {
        self.mode = ConnectorMode::Write;
        self
    }

    pub fn build(self) -> Result<KoreDuckDBConnector, String> {
        let path = self.file_path
            .ok_or("File path not specified")?;
        
        let connector = KoreDuckDBConnector {
            file_path: path,
            schema: None,
            mode: self.mode,
        };

        // Validation happens at read/write time, not at construction
        Ok(connector)
    }
}

#[cfg(test)]
mod tests {
    use super::*;

    #[test]
    fn test_create_connector() {
        let conn = KoreDuckDBConnector::new("test.kore");
        assert!(conn.is_ok());
    }

    #[test]
    fn test_empty_path() {
        let conn = KoreDuckDBConnector::new("");
        assert!(conn.is_err());
    }

    #[test]
    fn test_connector_modes() {
        let read_conn = KoreDuckDBConnector::read("test.kore").unwrap();
        assert_eq!(read_conn.mode(), ConnectorMode::Read);

        let write_conn = KoreDuckDBConnector::write("test.kore").unwrap();
        assert_eq!(write_conn.mode(), ConnectorMode::Write);
    }

    #[test]
    fn test_builder_pattern() {
        let conn = KoreDuckDBConnectorBuilder::new()
            .path("data.kore")
            .read_only()
            .build();
        
        assert!(conn.is_ok());
        assert_eq!(conn.unwrap().mode(), ConnectorMode::Read);
    }

    #[test]
    fn test_builder_missing_path() {
        let result = KoreDuckDBConnectorBuilder::new()
            .read_only()
            .build();
        
        assert!(result.is_err());
    }

    #[test]
    fn test_write_without_schema() {
        let mut conn = KoreDuckDBConnector::new("test.kore").unwrap();
        assert!(conn.schema().is_none());
    }

    #[test]
    fn test_mode_restrictions() {
        let mut read_conn = KoreDuckDBConnector::read("test.kore").unwrap();
        
        // Should fail to write in read-only mode
        let batch = ArrowRecordBatch::new(
            ArrowSchema::new(vec![]),
            vec![],
            0,
        );
        
        let result = read_conn.append_from_arrow(batch);
        assert!(result.is_err());
    }

    #[test]
    fn test_file_path_storage() {
        let path = "my_data/file.kore";
        let conn = KoreDuckDBConnector::new(path).unwrap();
        assert_eq!(conn.file_path(), Path::new(path));
    }

    #[test]
    fn test_column_count_no_schema() {
        let conn = KoreDuckDBConnector::new("test.kore").unwrap();
        assert!(conn.column_count().is_err());
    }
}