kora-doc 0.2.0

JSON document database with secondary indexes and WHERE queries for Kōra
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
//! Compact binary packed document format.
//!
//! A [`PackedDoc`] is a flat byte buffer that stores an arbitrary number of
//! typed fields in a layout optimised for single-field random access without
//! deserialising the entire document.
//!
//! ## Binary Layout
//!
//! ```text
//! [version:2][field_count:2][updated_at:4]  ← 8-byte header
//! [field_id:2, data_offset:2] × N           ← offset table (4 bytes per field)
//! [type_tag:1] × N                          ← type table (1 byte per field)
//! [field data bytes...]                      ← data region
//! ```
//!
//! - **Header (8 bytes):** format version (`u16`), field count (`u16`),
//!   and last-update timestamp as Unix seconds (`u32`).
//! - **Offset table:** one `(FieldId, u16)` pair per field, sorted by
//!   `FieldId` in ascending order. `data_offset` is relative to the start
//!   of the data region.
//! - **Type table:** one tag byte per field indicating its [`FieldValue`]
//!   variant.
//! - **Data region:** variable-length payloads concatenated in field-ID order.
//!
//! ## Field Access
//!
//! [`PackedDoc::read_field`] performs a binary search over the offset table
//! to locate a field by its `FieldId` in O(log F) time, then decodes the
//! payload using the corresponding type tag. This avoids scanning the entire
//! document for point reads and projections.
//!
//! ## Building
//!
//! [`PackedDocBuilder`] collects field entries in any order, sorts them by
//! field ID at build time, validates for duplicates and size limits, and
//! emits a validated [`PackedDoc`].

use thiserror::Error;

use crate::registry::FieldId;

const HEADER_LEN: usize = 8;
const OFFSET_ENTRY_LEN: usize = 4;

const TYPE_NULL: u8 = 0x00;
const TYPE_BOOL_FALSE: u8 = 0x01;
const TYPE_BOOL_TRUE: u8 = 0x02;
const TYPE_I64: u8 = 0x03;
const TYPE_F64: u8 = 0x04;
const TYPE_STR_INLINE: u8 = 0x05;
const TYPE_STR_DICTREF: u8 = 0x06;
const TYPE_ARRAY: u8 = 0x07;

#[derive(Debug, Clone, Copy)]
struct Layout {
    field_count: usize,
    type_table_start: usize,
    data_region_start: usize,
}

#[derive(Debug, Clone, Copy)]
struct OffsetEntry {
    field_id: FieldId,
    data_offset: u16,
}

/// Packed field value representation.
#[derive(Debug, Clone, PartialEq)]
pub enum FieldValue {
    /// Null value.
    Null,
    /// Boolean value.
    Bool(bool),
    /// Signed integer value.
    I64(i64),
    /// Floating-point value.
    F64(f64),
    /// Inline bytes value.
    InlineBytes(Vec<u8>),
    /// Dictionary reference value.
    DictRef(u32),
    /// Structured JSON payload encoded as bytes (arrays and empty objects).
    ArrayBytes(Vec<u8>),
}

/// Packed document encoding/decoding errors.
#[derive(Debug, Error, PartialEq, Eq)]
pub enum PackedDocError {
    /// The packed buffer is malformed.
    #[error("malformed packed document: {0}")]
    Malformed(&'static str),
    /// Builder encountered too many fields for `u16` field count.
    #[error("too many fields in packed document: {0}")]
    TooManyFields(usize),
    /// Duplicate field ID in builder input.
    #[error("duplicate field id in packed document: {0}")]
    DuplicateFieldId(FieldId),
    /// A field payload is too large for the packed format.
    #[error("field {field_id} payload too large: {len} bytes")]
    FieldDataTooLarge {
        /// Field ID that exceeded size bounds.
        field_id: FieldId,
        /// Payload length in bytes.
        len: usize,
    },
    /// Total packed data region exceeds `u16` offsets.
    #[error("data region too large: {0} bytes")]
    DataRegionTooLarge(usize),
    /// Unknown type tag in a packed document.
    #[error("unknown field type tag: 0x{0:02x}")]
    UnknownTypeTag(u8),
    /// Field payload bytes do not match type expectations.
    #[error("invalid data for field {field_id}: {reason}")]
    InvalidFieldData {
        /// Field ID with invalid payload.
        field_id: FieldId,
        /// Validation error description.
        reason: &'static str,
    },
}

/// Packed document container.
#[derive(Debug, Clone, PartialEq)]
pub struct PackedDoc {
    data: Vec<u8>,
}

impl PackedDoc {
    /// Construct a packed document from bytes and validate structural integrity.
    pub fn from_bytes(data: Vec<u8>) -> Result<Self, PackedDocError> {
        let doc = Self { data };
        doc.validate()?;
        Ok(doc)
    }

    /// Return a borrowed view of the underlying bytes.
    #[must_use]
    pub fn as_bytes(&self) -> &[u8] {
        &self.data
    }

    /// Consume the packed document and return owned bytes.
    #[must_use]
    pub fn into_bytes(self) -> Vec<u8> {
        self.data
    }

    /// Return total byte size.
    #[must_use]
    pub fn byte_size(&self) -> usize {
        self.data.len()
    }

    /// Return packed format version.
    pub fn version(&self) -> Result<u16, PackedDocError> {
        let _layout = self.layout()?;
        Ok(u16::from_le_bytes([self.data[0], self.data[1]]))
    }

    /// Return number of fields in this packed document.
    pub fn field_count(&self) -> Result<usize, PackedDocError> {
        Ok(self.layout()?.field_count)
    }

    /// Return document update timestamp.
    pub fn updated_at(&self) -> Result<u32, PackedDocError> {
        let _layout = self.layout()?;
        Ok(u32::from_le_bytes([
            self.data[4],
            self.data[5],
            self.data[6],
            self.data[7],
        ]))
    }

    /// Read a field by field ID.
    pub fn read_field(&self, field_id: FieldId) -> Result<Option<FieldValue>, PackedDocError> {
        let layout = self.layout()?;

        let mut lo = 0usize;
        let mut hi = layout.field_count;
        while lo < hi {
            let mid = lo + (hi - lo) / 2;
            let entry = self.offset_entry(mid, &layout)?;
            if entry.field_id == field_id {
                let (_, value) = self.decode_at_index(mid, &layout)?;
                return Ok(Some(value));
            }
            if entry.field_id < field_id {
                lo = mid + 1;
            } else {
                hi = mid;
            }
        }

        Ok(None)
    }

    /// Read multiple fields in the order requested.
    pub fn read_fields(
        &self,
        field_ids: &[FieldId],
    ) -> Result<Vec<Option<FieldValue>>, PackedDocError> {
        field_ids.iter().map(|id| self.read_field(*id)).collect()
    }

    /// Iterate over all packed fields in sorted field-id order.
    pub fn iter_fields(&self) -> Result<PackedDocIter<'_>, PackedDocError> {
        let layout = self.layout()?;
        Ok(PackedDocIter {
            doc: self,
            layout,
            index: 0,
        })
    }

    fn validate(&self) -> Result<(), PackedDocError> {
        let layout = self.layout()?;
        let mut previous_field_id: Option<FieldId> = None;
        let mut previous_offset: Option<u16> = None;

        for index in 0..layout.field_count {
            let entry = self.offset_entry(index, &layout)?;

            if let Some(prev_id) = previous_field_id {
                if entry.field_id <= prev_id {
                    if entry.field_id == prev_id {
                        return Err(PackedDocError::DuplicateFieldId(entry.field_id));
                    }
                    return Err(PackedDocError::Malformed(
                        "field ids must be strictly ascending",
                    ));
                }
            }

            if let Some(prev_offset) = previous_offset {
                if entry.data_offset < prev_offset {
                    return Err(PackedDocError::Malformed(
                        "field offsets must be monotonically increasing",
                    ));
                }
            }

            let _ = self.decode_at_index(index, &layout)?;
            previous_field_id = Some(entry.field_id);
            previous_offset = Some(entry.data_offset);
        }

        Ok(())
    }

    fn layout(&self) -> Result<Layout, PackedDocError> {
        if self.data.len() < HEADER_LEN {
            return Err(PackedDocError::Malformed("buffer shorter than header"));
        }

        let field_count = u16::from_le_bytes([self.data[2], self.data[3]]) as usize;

        let offset_table_bytes = field_count
            .checked_mul(OFFSET_ENTRY_LEN)
            .ok_or(PackedDocError::Malformed("offset table length overflow"))?;
        let type_table_start = HEADER_LEN
            .checked_add(offset_table_bytes)
            .ok_or(PackedDocError::Malformed("type table start overflow"))?;
        let data_region_start = type_table_start
            .checked_add(field_count)
            .ok_or(PackedDocError::Malformed("data region start overflow"))?;

        if self.data.len() < data_region_start {
            return Err(PackedDocError::Malformed(
                "buffer shorter than table region",
            ));
        }

        Ok(Layout {
            field_count,
            type_table_start,
            data_region_start,
        })
    }

    fn offset_entry(&self, index: usize, layout: &Layout) -> Result<OffsetEntry, PackedDocError> {
        if index >= layout.field_count {
            return Err(PackedDocError::Malformed(
                "offset entry index out of bounds",
            ));
        }

        let start = HEADER_LEN
            .checked_add(
                index
                    .checked_mul(OFFSET_ENTRY_LEN)
                    .ok_or(PackedDocError::Malformed("offset entry start overflow"))?,
            )
            .ok_or(PackedDocError::Malformed("offset entry start overflow"))?;
        let end = start
            .checked_add(OFFSET_ENTRY_LEN)
            .ok_or(PackedDocError::Malformed("offset entry end overflow"))?;

        let bytes = self
            .data
            .get(start..end)
            .ok_or(PackedDocError::Malformed("offset entry out of bounds"))?;

        Ok(OffsetEntry {
            field_id: u16::from_le_bytes([bytes[0], bytes[1]]),
            data_offset: u16::from_le_bytes([bytes[2], bytes[3]]),
        })
    }

    fn decode_at_index(
        &self,
        index: usize,
        layout: &Layout,
    ) -> Result<(FieldId, FieldValue), PackedDocError> {
        let entry = self.offset_entry(index, layout)?;
        let next_offset = if index + 1 < layout.field_count {
            self.offset_entry(index + 1, layout)?.data_offset as usize
        } else {
            self.data
                .len()
                .checked_sub(layout.data_region_start)
                .ok_or(PackedDocError::Malformed("data region underflow"))?
        };
        let current_offset = entry.data_offset as usize;

        if next_offset < current_offset {
            return Err(PackedDocError::Malformed("field offsets are not monotonic"));
        }

        let data_start = layout
            .data_region_start
            .checked_add(current_offset)
            .ok_or(PackedDocError::Malformed("field data start overflow"))?;
        let data_end = layout
            .data_region_start
            .checked_add(next_offset)
            .ok_or(PackedDocError::Malformed("field data end overflow"))?;

        let tag = *self
            .data
            .get(layout.type_table_start + index)
            .ok_or(PackedDocError::Malformed("type tag out of bounds"))?;
        let slice = self
            .data
            .get(data_start..data_end)
            .ok_or(PackedDocError::Malformed("field data out of bounds"))?;
        let value = decode_field_value(tag, slice, entry.field_id)?;

        Ok((entry.field_id, value))
    }
}

/// Iterator over packed fields.
pub struct PackedDocIter<'a> {
    doc: &'a PackedDoc,
    layout: Layout,
    index: usize,
}

impl<'a> Iterator for PackedDocIter<'a> {
    type Item = Result<(FieldId, FieldValue), PackedDocError>;

    fn next(&mut self) -> Option<Self::Item> {
        if self.index >= self.layout.field_count {
            return None;
        }

        let result = self.doc.decode_at_index(self.index, &self.layout);
        self.index += 1;
        Some(result)
    }
}

#[derive(Debug, Clone)]
struct BuilderField {
    field_id: FieldId,
    tag: u8,
    data: Vec<u8>,
}

/// Packed document builder.
#[derive(Debug, Default)]
pub struct PackedDocBuilder {
    version: u16,
    fields: Vec<BuilderField>,
}

impl PackedDocBuilder {
    /// Create a new builder for a specific packed format version.
    #[must_use]
    pub fn new(version: u16) -> Self {
        Self {
            version,
            fields: Vec::new(),
        }
    }

    /// Add a field entry to the builder.
    pub fn add_field(
        &mut self,
        field_id: FieldId,
        value: FieldValue,
    ) -> Result<(), PackedDocError> {
        let (tag, data) = encode_field_value(field_id, value)?;
        self.fields.push(BuilderField {
            field_id,
            tag,
            data,
        });
        Ok(())
    }

    /// Build a packed document using `updated_at` seconds.
    pub fn build(mut self, updated_at: u32) -> Result<PackedDoc, PackedDocError> {
        self.fields.sort_by_key(|f| f.field_id);

        for window in self.fields.windows(2) {
            if window[0].field_id == window[1].field_id {
                return Err(PackedDocError::DuplicateFieldId(window[0].field_id));
            }
        }

        let field_count = self.fields.len();
        let field_count_u16 =
            u16::try_from(field_count).map_err(|_| PackedDocError::TooManyFields(field_count))?;
        let data_size = self.fields.iter().try_fold(0usize, |acc, field| {
            acc.checked_add(field.data.len())
                .ok_or(PackedDocError::DataRegionTooLarge(usize::MAX))
        })?;

        if data_size > u16::MAX as usize {
            return Err(PackedDocError::DataRegionTooLarge(data_size));
        }

        let offset_table_size = field_count
            .checked_mul(OFFSET_ENTRY_LEN)
            .ok_or(PackedDocError::Malformed("offset table size overflow"))?;
        let type_table_size = field_count;
        let total_size = HEADER_LEN
            .checked_add(offset_table_size)
            .and_then(|n| n.checked_add(type_table_size))
            .and_then(|n| n.checked_add(data_size))
            .ok_or(PackedDocError::Malformed("packed document size overflow"))?;

        let mut data = Vec::with_capacity(total_size);

        data.extend_from_slice(&self.version.to_le_bytes());
        data.extend_from_slice(&field_count_u16.to_le_bytes());
        data.extend_from_slice(&updated_at.to_le_bytes());

        let mut data_offset = 0u16;
        for field in &self.fields {
            data.extend_from_slice(&field.field_id.to_le_bytes());
            data.extend_from_slice(&data_offset.to_le_bytes());
            data_offset = data_offset
                .checked_add(field.data.len() as u16)
                .ok_or(PackedDocError::DataRegionTooLarge(data_size))?;
        }

        for field in &self.fields {
            data.push(field.tag);
        }

        for field in &self.fields {
            data.extend_from_slice(&field.data);
        }

        PackedDoc::from_bytes(data)
    }
}

fn encode_field_value(
    field_id: FieldId,
    value: FieldValue,
) -> Result<(u8, Vec<u8>), PackedDocError> {
    match value {
        FieldValue::Null => Ok((TYPE_NULL, Vec::new())),
        FieldValue::Bool(false) => Ok((TYPE_BOOL_FALSE, Vec::new())),
        FieldValue::Bool(true) => Ok((TYPE_BOOL_TRUE, Vec::new())),
        FieldValue::I64(v) => Ok((TYPE_I64, v.to_le_bytes().to_vec())),
        FieldValue::F64(v) => Ok((TYPE_F64, v.to_le_bytes().to_vec())),
        FieldValue::InlineBytes(bytes) => {
            if bytes.len() > u16::MAX as usize {
                return Err(PackedDocError::FieldDataTooLarge {
                    field_id,
                    len: bytes.len(),
                });
            }
            let mut data = Vec::with_capacity(bytes.len() + 2);
            data.extend_from_slice(&(bytes.len() as u16).to_le_bytes());
            data.extend_from_slice(&bytes);
            Ok((TYPE_STR_INLINE, data))
        }
        FieldValue::DictRef(id) => Ok((TYPE_STR_DICTREF, id.to_le_bytes().to_vec())),
        FieldValue::ArrayBytes(bytes) => {
            if bytes.len() > u16::MAX as usize {
                return Err(PackedDocError::FieldDataTooLarge {
                    field_id,
                    len: bytes.len(),
                });
            }
            let mut data = Vec::with_capacity(bytes.len() + 2);
            data.extend_from_slice(&(bytes.len() as u16).to_le_bytes());
            data.extend_from_slice(&bytes);
            Ok((TYPE_ARRAY, data))
        }
    }
}

fn decode_field_value(
    tag: u8,
    data: &[u8],
    field_id: FieldId,
) -> Result<FieldValue, PackedDocError> {
    match tag {
        TYPE_NULL => {
            if !data.is_empty() {
                return Err(PackedDocError::InvalidFieldData {
                    field_id,
                    reason: "null field must not have payload bytes",
                });
            }
            Ok(FieldValue::Null)
        }
        TYPE_BOOL_FALSE => {
            if !data.is_empty() {
                return Err(PackedDocError::InvalidFieldData {
                    field_id,
                    reason: "bool field must not have payload bytes",
                });
            }
            Ok(FieldValue::Bool(false))
        }
        TYPE_BOOL_TRUE => {
            if !data.is_empty() {
                return Err(PackedDocError::InvalidFieldData {
                    field_id,
                    reason: "bool field must not have payload bytes",
                });
            }
            Ok(FieldValue::Bool(true))
        }
        TYPE_I64 => {
            if data.len() != 8 {
                return Err(PackedDocError::InvalidFieldData {
                    field_id,
                    reason: "i64 field payload must be exactly 8 bytes",
                });
            }
            let bytes: [u8; 8] = data
                .try_into()
                .map_err(|_| PackedDocError::InvalidFieldData {
                    field_id,
                    reason: "i64 conversion failed",
                })?;
            Ok(FieldValue::I64(i64::from_le_bytes(bytes)))
        }
        TYPE_F64 => {
            if data.len() != 8 {
                return Err(PackedDocError::InvalidFieldData {
                    field_id,
                    reason: "f64 field payload must be exactly 8 bytes",
                });
            }
            let bytes: [u8; 8] = data
                .try_into()
                .map_err(|_| PackedDocError::InvalidFieldData {
                    field_id,
                    reason: "f64 conversion failed",
                })?;
            Ok(FieldValue::F64(f64::from_le_bytes(bytes)))
        }
        TYPE_STR_INLINE => {
            if data.len() < 2 {
                return Err(PackedDocError::InvalidFieldData {
                    field_id,
                    reason: "inline value missing length prefix",
                });
            }
            let len = u16::from_le_bytes([data[0], data[1]]) as usize;
            if data.len() != len + 2 {
                return Err(PackedDocError::InvalidFieldData {
                    field_id,
                    reason: "inline value length prefix mismatch",
                });
            }
            Ok(FieldValue::InlineBytes(data[2..].to_vec()))
        }
        TYPE_STR_DICTREF => {
            if data.len() != 4 {
                return Err(PackedDocError::InvalidFieldData {
                    field_id,
                    reason: "dict ref payload must be 4 bytes",
                });
            }
            let bytes: [u8; 4] = data
                .try_into()
                .map_err(|_| PackedDocError::InvalidFieldData {
                    field_id,
                    reason: "dict ref conversion failed",
                })?;
            Ok(FieldValue::DictRef(u32::from_le_bytes(bytes)))
        }
        TYPE_ARRAY => {
            if data.len() < 2 {
                return Err(PackedDocError::InvalidFieldData {
                    field_id,
                    reason: "array value missing length prefix",
                });
            }
            let len = u16::from_le_bytes([data[0], data[1]]) as usize;
            if data.len() != len + 2 {
                return Err(PackedDocError::InvalidFieldData {
                    field_id,
                    reason: "array value length prefix mismatch",
                });
            }
            Ok(FieldValue::ArrayBytes(data[2..].to_vec()))
        }
        _ => Err(PackedDocError::UnknownTypeTag(tag)),
    }
}

#[cfg(test)]
mod tests {
    use super::*;

    #[test]
    fn build_and_read_round_trip() {
        let mut builder = PackedDocBuilder::new(1);
        builder
            .add_field(2, FieldValue::I64(42))
            .expect("field should be added");
        builder
            .add_field(1, FieldValue::InlineBytes(b"augustus".to_vec()))
            .expect("field should be added");
        builder
            .add_field(4, FieldValue::DictRef(7))
            .expect("field should be added");
        builder
            .add_field(3, FieldValue::Bool(true))
            .expect("field should be added");

        let doc = builder.build(123).expect("doc should build");

        assert_eq!(doc.version().expect("version"), 1);
        assert_eq!(doc.updated_at().expect("updated_at"), 123);
        assert_eq!(doc.field_count().expect("field_count"), 4);
        assert_eq!(
            doc.read_field(1).expect("read should succeed"),
            Some(FieldValue::InlineBytes(b"augustus".to_vec()))
        );
        assert_eq!(
            doc.read_field(2).expect("read should succeed"),
            Some(FieldValue::I64(42))
        );
        assert_eq!(
            doc.read_field(3).expect("read should succeed"),
            Some(FieldValue::Bool(true))
        );
        assert_eq!(
            doc.read_field(4).expect("read should succeed"),
            Some(FieldValue::DictRef(7))
        );
        assert_eq!(doc.read_field(9).expect("read should succeed"), None);
    }

    #[test]
    fn iterator_returns_sorted_fields() {
        let mut builder = PackedDocBuilder::new(1);
        builder
            .add_field(4, FieldValue::Null)
            .expect("field should be added");
        builder
            .add_field(2, FieldValue::Bool(false))
            .expect("field should be added");
        builder
            .add_field(3, FieldValue::F64(1.5))
            .expect("field should be added");

        let doc = builder.build(0).expect("doc should build");
        let fields: Vec<(FieldId, FieldValue)> = doc
            .iter_fields()
            .expect("iterator should be created")
            .collect::<Result<_, _>>()
            .expect("iteration should decode");
        let field_ids: Vec<FieldId> = fields.iter().map(|(id, _)| *id).collect();
        assert_eq!(field_ids, vec![2, 3, 4]);
    }

    #[test]
    fn duplicate_field_ids_are_rejected() {
        let mut builder = PackedDocBuilder::new(1);
        builder
            .add_field(1, FieldValue::Null)
            .expect("field should be added");
        builder
            .add_field(1, FieldValue::Bool(false))
            .expect("field should be added");

        let err = builder.build(0).expect_err("duplicate fields must fail");
        assert_eq!(err, PackedDocError::DuplicateFieldId(1));
    }

    #[test]
    fn oversized_field_payload_is_rejected() {
        let mut builder = PackedDocBuilder::new(1);
        let large = vec![0u8; 70_000];
        let err = builder
            .add_field(2, FieldValue::InlineBytes(large))
            .expect_err("oversized field must fail");
        assert_eq!(
            err,
            PackedDocError::FieldDataTooLarge {
                field_id: 2,
                len: 70_000
            }
        );
    }

    #[test]
    fn malformed_doc_is_rejected() {
        let err = PackedDoc::from_bytes(vec![1, 2, 3]).expect_err("malformed doc should fail");
        assert_eq!(err, PackedDocError::Malformed("buffer shorter than header"));
    }
}