kopi 0.1.4

Kopi is a JDK version management tool
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
// Copyright 2025 dentsusoken
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
//     http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

use crate::config::KopiConfig;
use crate::error::{KopiError, Result};
use crate::models::distribution::Distribution;
use crate::models::package::PackageType;
use crate::version::Version;
use std::str::FromStr;

#[derive(Debug, Clone, PartialEq)]
pub struct ParsedVersionRequest {
    pub version: Option<Version>,
    pub distribution: Option<Distribution>,
    pub package_type: Option<PackageType>,
    pub latest: bool,
    pub javafx_bundled: Option<bool>,
}

pub struct VersionParser<'a> {
    config: &'a KopiConfig,
}

impl<'a> VersionParser<'a> {
    pub fn new(config: &'a KopiConfig) -> Self {
        Self { config }
    }

    pub fn parse(&self, input: &str) -> Result<ParsedVersionRequest> {
        let trimmed = input.trim();
        if trimmed.is_empty() {
            return Err(KopiError::InvalidVersionFormat(
                "Version string cannot be empty".to_string(),
            ));
        }

        // Check for package type prefix (jre@ or jdk@)
        let (package_type, remaining) = if let Some(spec) = trimmed.strip_prefix("jre@") {
            (Some(PackageType::Jre), spec)
        } else if let Some(spec) = trimmed.strip_prefix("jdk@") {
            (Some(PackageType::Jdk), spec)
        } else {
            // Default to JDK for backward compatibility
            (Some(PackageType::Jdk), trimmed)
        };

        // Check for JavaFX suffix (+fx at the end)
        let (javafx_bundled, remaining) = if let Some(stripped) = remaining.strip_suffix("+fx") {
            (Some(true), stripped)
        } else {
            (None, remaining)
        };

        // Check for "latest" keyword
        if remaining.eq_ignore_ascii_case("latest") {
            return Ok(ParsedVersionRequest {
                version: None,
                distribution: None,
                package_type,
                latest: true,
                javafx_bundled,
            });
        }

        // Now parse the remaining part as before
        let (distribution, version_str) = if remaining.contains('@') {
            // Format: distribution@version
            let mut parts = remaining.splitn(2, '@');
            let dist_part = parts.next().unwrap();
            let version_part = parts.next().unwrap_or("");

            // For the @ format, we should only accept known distributions
            if !self.is_known_distribution(dist_part) {
                return Err(KopiError::InvalidVersionFormat(format!(
                    "Unknown distribution: {dist_part}"
                )));
            }

            // Normalize distribution name to lowercase for consistency with additional_distributions config
            let normalized_dist = if self.is_default_distribution(dist_part) {
                dist_part
            } else {
                &dist_part.to_lowercase()
            };

            let dist = Distribution::from_str(normalized_dist).map_err(|_| {
                KopiError::InvalidVersionFormat(format!("Unknown distribution: {dist_part}"))
            })?;

            if version_part.is_empty() {
                // Distribution without version (e.g., "corretto")
                return Ok(ParsedVersionRequest {
                    version: None,
                    distribution: Some(dist),
                    package_type,
                    latest: false,
                    javafx_bundled,
                });
            }

            // Check if version part is "latest"
            if version_part.eq_ignore_ascii_case("latest") {
                return Ok(ParsedVersionRequest {
                    version: None,
                    distribution: Some(dist),
                    package_type,
                    latest: true,
                    javafx_bundled,
                });
            }

            (Some(dist), version_part)
        } else {
            // No @ symbol - check if it's a known distribution name
            if self.is_known_distribution(remaining) {
                // It's a distribution name without version
                // Normalize distribution name to lowercase for consistency with additional_distributions config
                let normalized_dist = if self.is_default_distribution(remaining) {
                    remaining
                } else {
                    &remaining.to_lowercase()
                };

                let dist = Distribution::from_str(normalized_dist).map_err(|_| {
                    KopiError::InvalidVersionFormat(format!("Unknown distribution: {remaining}"))
                })?;
                return Ok(ParsedVersionRequest {
                    version: None,
                    distribution: Some(dist),
                    package_type,
                    latest: false,
                    javafx_bundled,
                });
            } else {
                // It's a version string
                (None, remaining)
            }
        };

        // Parse version
        let version = Self::parse_version_string(version_str)?;

        Ok(ParsedVersionRequest {
            version: Some(version),
            distribution,
            package_type,
            latest: false,
            javafx_bundled,
        })
    }

    fn parse_version_string(version_str: &str) -> Result<Version> {
        // Check for version ranges (not yet implemented)
        if version_str.contains(">=") || version_str.contains("<=") || version_str.contains("><") {
            return Err(KopiError::InvalidVersionFormat(format!(
                "Version ranges are not yet supported: {version_str}"
            )));
        }

        // Use the Version::from_str implementation which already handles build numbers and pre-release
        // The Version parser handles '+' and '-' correctly
        Version::from_str(version_str)
    }

    pub fn validate_version_semantics(version: &Version) -> Result<()> {
        // Validate reasonable version numbers
        if version.major() == 0 || version.major() > 99 {
            return Err(KopiError::InvalidVersionFormat(format!(
                "Invalid major version: {}. JDK versions typically range from 1 to 99.",
                version.major()
            )));
        }

        if let Some(minor) = version.minor()
            && minor > 99
        {
            return Err(KopiError::InvalidVersionFormat(format!(
                "Invalid minor version: {minor}. Minor versions typically range from 0 to 99."
            )));
        }

        if let Some(patch) = version.patch()
            && patch > 999
        {
            return Err(KopiError::InvalidVersionFormat(format!(
                "Invalid patch version: {patch}. Patch versions typically range from 0 to 999."
            )));
        }

        Ok(())
    }

    pub fn is_lts_version(major: u32) -> bool {
        // Known LTS versions
        matches!(major, 8 | 11 | 17 | 21)
    }

    fn is_default_distribution(&self, name: &str) -> bool {
        matches!(
            name.to_lowercase().as_str(),
            "temurin"
                | "corretto"
                | "zulu"
                | "openjdk"
                | "graalvm"
                | "dragonwell"
                | "sapmachine"
                | "liberica"
                | "mandrel"
                | "kona"
                | "semeru"
                | "trava"
                | "aoj"
                | "aoj_openj9"
                | "bisheng"
                | "gluon_graalvm"
                | "graalvm_ce8"
                | "graalvm_ce11"
                | "graalvm_ce16"
                | "graalvm_ce17"
                | "graalvm_ce19"
                | "graalvm_community"
                | "jetbrains"
                | "liberica_native"
                | "microsoft"
                | "ojdk_build"
                | "openlogic"
                | "oracle"
                | "oracle_open_jdk"
                | "sap_machine"
                | "semeru_certified"
                | "zulu_prime"
        )
    }

    fn is_known_distribution(&self, name: &str) -> bool {
        // First check if it looks like a version (starts with a digit)
        if name.chars().next().is_some_and(|c| c.is_ascii_digit()) {
            return false;
        }

        // Check against default known distributions
        let is_default = self.is_default_distribution(name);

        // If it's in the default list, return true
        if is_default {
            return true;
        }

        // Check against additional distributions from config
        self.config
            .additional_distributions
            .iter()
            .any(|dist| dist.eq_ignore_ascii_case(name))
    }
}

#[cfg(test)]
mod tests {
    use super::*;
    use crate::config::KopiConfig;
    use serial_test::serial;

    fn create_test_config() -> KopiConfig {
        // Clear any leftover environment variables
        unsafe {
            std::env::remove_var("KOPI_AUTO_INSTALL");
            std::env::remove_var("KOPI_AUTO_INSTALL__ENABLED");
        }

        // Create a test config with a temporary directory
        let temp_dir = std::env::temp_dir();
        KopiConfig::new(temp_dir).unwrap()
    }

    #[test]
    fn test_parse_version_only() {
        let config = create_test_config();
        let parser = VersionParser::new(&config);
        let result = parser.parse("21").unwrap();
        assert_eq!(result.distribution, None);
        assert!(result.version.is_some());
        let version = result.version.unwrap();
        assert_eq!(version.major(), 21);
        assert_eq!(version.minor(), None);
        assert_eq!(version.patch(), None);
        assert!(!result.latest);
    }

    #[test]
    fn test_parse_version_with_minor() {
        let config = create_test_config();
        let parser = VersionParser::new(&config);
        let result = parser.parse("17.0.9").unwrap();
        assert_eq!(result.distribution, None);
        assert!(result.version.is_some());
        let version = result.version.unwrap();
        assert_eq!(version.major(), 17);
        assert_eq!(version.minor(), Some(0));
        assert_eq!(version.patch(), Some(9));
        assert!(!result.latest);
    }

    #[test]
    fn test_parse_distribution_with_version() {
        let config = create_test_config();
        let parser = VersionParser::new(&config);
        let result = parser.parse("corretto@21").unwrap();
        assert_eq!(result.distribution, Some(Distribution::Corretto));
        assert!(result.version.is_some());
        assert_eq!(result.version.unwrap().major(), 21);
        assert!(!result.latest);
    }

    #[test]
    fn test_parse_distribution_with_full_version() {
        let config = create_test_config();
        let parser = VersionParser::new(&config);
        let result = parser.parse("temurin@17.0.9").unwrap();
        assert_eq!(result.distribution, Some(Distribution::Temurin));
        assert!(result.version.is_some());
        let version = result.version.unwrap();
        assert_eq!(version.major(), 17);
        assert_eq!(version.minor(), Some(0));
        assert_eq!(version.patch(), Some(9));
        assert!(!result.latest);
    }

    #[test]
    fn test_parse_invalid_distribution() {
        let config = create_test_config();
        let parser = VersionParser::new(&config);
        let result = parser.parse("invalid@21");
        assert!(result.is_err());
        assert!(
            result
                .unwrap_err()
                .to_string()
                .contains("Unknown distribution")
        );
    }

    #[test]
    fn test_parse_distribution_without_version() {
        let config = create_test_config();
        let parser = VersionParser::new(&config);
        let result = parser.parse("temurin").unwrap();
        assert_eq!(result.distribution, Some(Distribution::Temurin));
        assert_eq!(result.version, None);
        assert!(!result.latest);
    }

    #[test]
    fn test_parse_empty_version() {
        let config = create_test_config();
        let parser = VersionParser::new(&config);
        let result = parser.parse("");
        assert!(result.is_err());
    }

    #[test]
    fn test_parse_invalid_version_format() {
        let config = create_test_config();
        let parser = VersionParser::new(&config);
        let result = parser.parse("abc");
        assert!(result.is_err());
        assert!(
            result
                .unwrap_err()
                .to_string()
                .contains("Invalid version format")
        );
    }

    #[test]
    fn test_validate_version_semantics() {
        assert!(VersionParser::validate_version_semantics(&Version::new(21, 0, 0)).is_ok());
        assert!(VersionParser::validate_version_semantics(&Version::new(0, 0, 0)).is_err());
        assert!(VersionParser::validate_version_semantics(&Version::new(100, 0, 0)).is_err());
    }

    #[test]
    fn test_parse_latest_keyword() {
        let config = create_test_config();
        let parser = VersionParser::new(&config);
        let result = parser.parse("latest").unwrap();
        assert_eq!(result.distribution, None);
        assert_eq!(result.version, None);
        assert!(result.latest);
    }

    #[test]
    fn test_parse_distribution_with_latest() {
        let config = create_test_config();
        let parser = VersionParser::new(&config);
        let result = parser.parse("corretto@latest").unwrap();
        assert_eq!(result.distribution, Some(Distribution::Corretto));
        assert_eq!(result.version, None);
        assert!(result.latest);
    }

    #[test]
    fn test_parse_distribution_only() {
        let config = create_test_config();
        let parser = VersionParser::new(&config);
        let result = parser.parse("zulu").unwrap();
        assert_eq!(result.distribution, Some(Distribution::Zulu));
        assert_eq!(result.version, None);
        assert!(!result.latest);
    }

    #[test]
    fn test_parse_jre_latest() {
        let config = create_test_config();
        let parser = VersionParser::new(&config);
        let result = parser.parse("jre@latest").unwrap();
        assert_eq!(result.distribution, None);
        assert_eq!(result.version, None);
        assert_eq!(result.package_type, Some(PackageType::Jre));
        assert!(result.latest);
    }

    #[test]
    fn test_parse_jre_distribution_latest() {
        let config = create_test_config();
        let parser = VersionParser::new(&config);
        let result = parser.parse("jre@corretto@latest").unwrap();
        assert_eq!(result.distribution, Some(Distribution::Corretto));
        assert_eq!(result.version, None);
        assert_eq!(result.package_type, Some(PackageType::Jre));
        assert!(result.latest);
    }

    #[test]
    fn test_parse_jdk_distribution_only() {
        let config = create_test_config();
        let parser = VersionParser::new(&config);
        let result = parser.parse("jdk@temurin").unwrap();
        assert_eq!(result.distribution, Some(Distribution::Temurin));
        assert_eq!(result.version, None);
        assert_eq!(result.package_type, Some(PackageType::Jdk));
        assert!(!result.latest);
    }

    #[test]
    fn test_is_lts_version() {
        assert!(VersionParser::is_lts_version(8));
        assert!(VersionParser::is_lts_version(11));
        assert!(VersionParser::is_lts_version(17));
        assert!(VersionParser::is_lts_version(21));
        assert!(!VersionParser::is_lts_version(9));
        assert!(!VersionParser::is_lts_version(18));
    }

    #[test]
    fn test_parse_with_package_type_prefix() {
        let config = create_test_config();
        let parser = VersionParser::new(&config);
        // Test JRE prefix
        let parsed = parser.parse("jre@21").unwrap();
        assert_eq!(
            parsed.version,
            Some(Version::from_components(21, None, None))
        );
        assert_eq!(parsed.distribution, None);
        assert_eq!(parsed.package_type, Some(PackageType::Jre));

        // Test JDK prefix (explicit)
        let parsed = parser.parse("jdk@21").unwrap();
        assert_eq!(
            parsed.version,
            Some(Version::from_components(21, None, None))
        );
        assert_eq!(parsed.distribution, None);
        assert_eq!(parsed.package_type, Some(PackageType::Jdk));

        // Test JRE with distribution
        let parsed = parser.parse("jre@temurin@21").unwrap();
        assert_eq!(
            parsed.version,
            Some(Version::from_components(21, None, None))
        );
        assert_eq!(parsed.distribution, Some(Distribution::Temurin));
        assert_eq!(parsed.package_type, Some(PackageType::Jre));

        // Test JDK with distribution (explicit)
        let parsed = parser.parse("jdk@temurin@21").unwrap();
        assert_eq!(
            parsed.version,
            Some(Version::from_components(21, None, None))
        );
        assert_eq!(parsed.distribution, Some(Distribution::Temurin));
        assert_eq!(parsed.package_type, Some(PackageType::Jdk));

        // Test no prefix (defaults to JDK)
        let parsed = parser.parse("21").unwrap();
        assert_eq!(
            parsed.version,
            Some(Version::from_components(21, None, None))
        );
        assert_eq!(parsed.distribution, None);
        assert_eq!(parsed.package_type, Some(PackageType::Jdk)); // Defaults to JDK

        // Test with full version
        let parsed = parser.parse("jre@21.0.1+12").unwrap();
        assert_eq!(
            parsed.version,
            Some(Version::new(21, 0, 1).with_build("12".to_string()))
        );
        assert_eq!(parsed.package_type, Some(PackageType::Jre));
    }

    #[test]
    fn test_version_ranges_not_supported() {
        let config = create_test_config();
        let parser = VersionParser::new(&config);
        let result = parser.parse(">=17");
        assert!(result.is_err());
        assert!(
            result
                .unwrap_err()
                .to_string()
                .contains("Version ranges are not yet supported")
        );
    }

    #[test]
    fn test_parse_version_with_build_number() {
        let config = create_test_config();
        let parser = VersionParser::new(&config);
        let result = parser.parse("17.0.9+7").unwrap();
        assert_eq!(result.distribution, None);
        assert!(result.version.is_some());
        let version = result.version.unwrap();
        assert_eq!(version.major(), 17);
        assert_eq!(version.minor(), Some(0));
        assert_eq!(version.patch(), Some(9));
        assert_eq!(version.build, Some(vec![7]));
    }

    #[test]
    fn test_parse_version_with_pre_release() {
        let config = create_test_config();
        let parser = VersionParser::new(&config);
        let result = parser.parse("21.0.1-ea").unwrap();
        assert_eq!(result.distribution, None);
        assert!(result.version.is_some());
        let version = result.version.unwrap();
        assert_eq!(version.major(), 21);
        assert_eq!(version.minor(), Some(0));
        assert_eq!(version.patch(), Some(1));
        assert_eq!(version.pre_release, Some("ea".to_string()));
    }

    #[test]
    fn test_parse_version_with_build_and_pre_release() {
        let config = create_test_config();
        let parser = VersionParser::new(&config);
        let result = parser.parse("17.0.2+8-LTS").unwrap();
        assert_eq!(result.distribution, None);
        assert!(result.version.is_some());
        let version = result.version.unwrap();
        assert_eq!(version.major(), 17);
        assert_eq!(version.minor(), Some(0));
        assert_eq!(version.patch(), Some(2));
        assert_eq!(version.pre_release, Some("8-LTS".to_string()));
    }

    #[test]
    fn test_parse_distribution_with_complex_version() {
        let config = create_test_config();
        let parser = VersionParser::new(&config);
        let result = parser.parse("corretto@21.0.1-amzn").unwrap();
        assert_eq!(result.distribution, Some(Distribution::Corretto));
        assert!(result.version.is_some());
        let version = result.version.unwrap();
        assert_eq!(version.major(), 21);
        assert_eq!(version.minor(), Some(0));
        assert_eq!(version.patch(), Some(1));
        assert_eq!(version.pre_release, Some("amzn".to_string()));
    }

    #[test]
    fn test_parse_version_with_complex_build() {
        let config = create_test_config();
        let parser = VersionParser::new(&config);
        let result = parser.parse("11.0.21+9-LTS-3299655").unwrap();
        assert_eq!(result.distribution, None);
        assert!(result.version.is_some());
        let version = result.version.unwrap();
        assert_eq!(version.major(), 11);
        assert_eq!(version.minor(), Some(0));
        assert_eq!(version.patch(), Some(21));
        assert_eq!(version.pre_release, Some("9-LTS-3299655".to_string()));
    }

    #[test]
    #[serial]
    fn test_additional_distributions() {
        use crate::config::new_kopi_config;
        use std::fs;
        use tempfile::TempDir;

        // Create a temporary config with additional distributions
        let temp_dir = TempDir::new().unwrap();
        unsafe {
            std::env::set_var("KOPI_HOME", temp_dir.path());
        }

        let config_content = r#"
default_distribution = "temurin"
additional_distributions = ["mycustom", "private-jdk", "company-build"]
"#;
        fs::write(temp_dir.path().join("config.toml"), config_content).unwrap();

        let config = new_kopi_config().unwrap();
        let parser = VersionParser::new(&config);

        // Test that custom distributions are recognized
        let result = parser.parse("mycustom@21").unwrap();
        assert_eq!(
            result.distribution,
            Some(Distribution::Other("mycustom".to_string()))
        );
        assert_eq!(result.version.unwrap().major(), 21);

        let result = parser.parse("private-jdk").unwrap();
        assert_eq!(
            result.distribution,
            Some(Distribution::Other("private-jdk".to_string()))
        );
        assert_eq!(result.version, None);

        // Test case insensitive matching
        let result = parser.parse("COMPANY-BUILD@17.0.1").unwrap();
        // The parser normalizes additional distributions to lowercase
        assert_eq!(
            result.distribution,
            Some(Distribution::Other("company-build".to_string()))
        );
        assert_eq!(result.version.unwrap().major(), 17);

        // Test that unknown distributions still fail
        let result = parser.parse("unknown-dist@21");
        assert!(result.is_err());
        assert!(
            result
                .unwrap_err()
                .to_string()
                .contains("Unknown distribution")
        );

        // Clean up
        unsafe {
            std::env::remove_var("KOPI_HOME");
        }
    }

    #[test]
    fn test_parse_with_javafx() {
        let config = create_test_config();
        let parser = VersionParser::new(&config);

        // Test version with JavaFX
        let result = parser.parse("21+fx").unwrap();
        assert_eq!(result.javafx_bundled, Some(true));
        assert_eq!(result.version.unwrap().to_string(), "21");

        // Test distribution@version with JavaFX
        let result = parser.parse("liberica@21+fx").unwrap();
        assert_eq!(result.javafx_bundled, Some(true));
        assert_eq!(result.distribution, Some(Distribution::Liberica));
        assert_eq!(result.version.unwrap().to_string(), "21");

        // Test full version with JavaFX
        let result = parser.parse("zulu@21.0.5+fx").unwrap();
        assert_eq!(result.javafx_bundled, Some(true));
        assert_eq!(result.distribution, Some(Distribution::Zulu));
        assert_eq!(result.version.unwrap().to_string(), "21.0.5");

        // Test version with build number and JavaFX
        let result = parser.parse("corretto@21.0.5+11+fx").unwrap();
        assert_eq!(result.javafx_bundled, Some(true));
        assert_eq!(result.distribution, Some(Distribution::Corretto));
        let version = result.version.unwrap();
        assert_eq!(version.components, vec![21, 0, 5]);
        assert_eq!(version.build, Some(vec![11]));

        // Test JRE with JavaFX
        let result = parser.parse("jre@liberica@21+fx").unwrap();
        assert_eq!(result.javafx_bundled, Some(true));
        assert_eq!(result.package_type, Some(PackageType::Jre));
        assert_eq!(result.distribution, Some(Distribution::Liberica));

        // Test latest with JavaFX
        let result = parser.parse("latest+fx").unwrap();
        assert_eq!(result.javafx_bundled, Some(true));
        assert!(result.latest);

        // Test distribution@latest with JavaFX
        let result = parser.parse("liberica@latest+fx").unwrap();
        assert_eq!(result.javafx_bundled, Some(true));
        assert_eq!(result.distribution, Some(Distribution::Liberica));
        assert!(result.latest);

        // Test without JavaFX (should be None)
        let result = parser.parse("21").unwrap();
        assert_eq!(result.javafx_bundled, None);
    }
}