koi-certmesh 0.5.0

Zero-config private CA, certificate enrollment, and mesh trust for the local network
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
//! Roster data model and persistence.
//!
//! The roster is the CA's source of truth - all enrolled members,
//! their certificates, and enrollment history.

use std::path::{Path, PathBuf};

use chrono::{DateTime, Utc};
use serde::{Deserialize, Serialize};

use koi_common::persist;

/// The complete roster - serialized to `~/.koi/certmesh/roster.json`.
#[derive(Debug, Clone, Serialize, Deserialize)]
pub struct Roster {
    pub metadata: RosterMetadata,
    pub members: Vec<RosterMember>,
    #[serde(default)]
    pub revocation_list: Vec<RevokedMember>,
}

/// Mesh-wide metadata set at creation time.
///
/// The mesh's security posture is two plain booleans:
/// - `enrollment_open` — whether the mesh is currently accepting new members.
/// - `requires_approval` — whether each join needs operator approval at the CA.
///
/// The named presets ("Just Me" / "My Team" / "My Organization") are UX labels
/// only; they are resolved to these booleans at create time and never persisted.
/// CA-held certificate lifecycle policy (ADR-017).
///
/// The CA owns the lifecycle: it applies `leaf_lifetime_days` when it signs, and
/// distributes the policy to members (via `/status` today; via the signed trust
/// bundle in a later phase) so they drive pull-renewal on the CA's schedule and
/// know how long past expiry they may still renew before they must re-enroll.
#[derive(Debug, Clone, Serialize, Deserialize, PartialEq, Eq, utoipa::ToSchema)]
pub struct CertPolicy {
    /// Issued-leaf validity, in days.
    pub leaf_lifetime_days: u32,
    /// Renew when fewer than this many days remain before expiry.
    pub renew_threshold_days: u32,
    /// Days past expiry a member may still pull-renew before re-enrollment.
    pub grace_days: u32,
}

impl Default for CertPolicy {
    /// Operator-ratified default: 90-day leaves, renew at 30 days remaining,
    /// 14-day post-expiry grace (ADR-017).
    fn default() -> Self {
        Self {
            leaf_lifetime_days: 90,
            renew_threshold_days: 30,
            grace_days: 14,
        }
    }
}

#[derive(Debug, Clone, Serialize, Deserialize)]
pub struct RosterMetadata {
    pub created_at: DateTime<Utc>,
    /// Whether the mesh is currently accepting new members.
    #[serde(default)]
    pub enrollment_open: bool,
    /// Whether enrollment requires operator approval.
    #[serde(default)]
    pub requires_approval: bool,
    /// Operator name recorded in the audit log (independent of any preset).
    #[serde(skip_serializing_if = "Option::is_none", default)]
    pub operator: Option<String>,
    /// CA-held certificate lifecycle policy (ADR-017). Defaults to 90/30/14 for
    /// rosters created before the policy existed.
    #[serde(default)]
    pub policy: CertPolicy,
    /// Monotonic sequence number, bumped on every **membership** mutation (enroll,
    /// revoke, renew, role change) — not on liveness touches. The signed trust
    /// bundle (ADR-017 P1) carries it for anti-rollback; members reject a bundle
    /// whose `seq` is not strictly greater than the last they accepted.
    #[serde(default)]
    pub seq: u64,
}

/// Whether the mesh is accepting new members.
///
/// This is the **wire** representation of [`RosterMetadata::enrollment_open`]
/// (see [`CertmeshStatus`](crate::protocol::CertmeshStatus)). The roster stores
/// a bool; this enum is derived from it for serialization.
#[derive(Debug, Clone, Serialize, Deserialize, PartialEq, utoipa::ToSchema)]
#[serde(rename_all = "snake_case")]
pub enum EnrollmentState {
    Open,
    Closed,
}

impl EnrollmentState {
    /// Map an `enrollment_open` bool to the wire enum.
    pub fn from_open(open: bool) -> Self {
        if open {
            Self::Open
        } else {
            Self::Closed
        }
    }
}

/// Role of a member in the mesh.
#[derive(Debug, Clone, Serialize, Deserialize, PartialEq)]
#[serde(rename_all = "snake_case")]
pub enum MemberRole {
    Primary,
    Standby,
    Member,
    /// A leaf/client node — holds a certificate but is neither the CA primary nor
    /// a promotion standby (e.g. a workstation that only consumes the mesh).
    Client,
}

/// Active/revoked status of a member.
#[derive(Debug, Clone, Serialize, Deserialize, PartialEq)]
#[serde(rename_all = "snake_case")]
pub enum MemberStatus {
    Active,
    Revoked,
}

/// Proxy configuration persisted per member (Phase 8).
#[derive(Debug, Clone, Serialize, Deserialize, PartialEq, Eq)]
pub struct ProxyConfigEntry {
    pub name: String,
    pub listen_port: u16,
    pub backend: String,
    #[serde(default)]
    pub allow_remote: bool,
}

/// A member enrolled in the mesh.
#[derive(Debug, Clone, Serialize, Deserialize)]
pub struct RosterMember {
    pub hostname: String,
    pub role: MemberRole,
    pub enrolled_at: DateTime<Utc>,
    #[serde(skip_serializing_if = "Option::is_none")]
    pub enrolled_by: Option<String>,
    pub cert_fingerprint: String,
    pub cert_expires: DateTime<Utc>,
    pub cert_sans: Vec<String>,
    /// Local cert directory for this member. **Not persisted** (`#[serde(skip)]`,
    /// ADR-017 F13): it is only ever set for the CA's own self-enroll entry and
    /// would leak the CA host's data-dir path into `roster.json`. It is always
    /// derivable as `certs_dir().join(hostname)`, so nothing needs it on disk.
    #[serde(default, skip)]
    pub cert_path: String,
    pub status: MemberStatus,
    /// Post-renewal reload hook command (Phase 3).
    #[serde(skip_serializing_if = "Option::is_none", default)]
    pub reload_hook: Option<String>,
    /// Last health heartbeat timestamp (Phase 3).
    #[serde(skip_serializing_if = "Option::is_none", default)]
    pub last_seen: Option<DateTime<Utc>>,
    /// Pinned CA certificate fingerprint for cert pinning (Phase 3).
    #[serde(skip_serializing_if = "Option::is_none", default)]
    pub pinned_ca_fingerprint: Option<String>,
    /// Proxy entries configured on this host (Phase 8).
    #[serde(default, skip_serializing_if = "Vec::is_empty")]
    pub proxy_entries: Vec<ProxyConfigEntry>,
}

/// A revoked member record.
#[derive(Debug, Clone, Serialize, Deserialize)]
pub struct RevokedMember {
    pub hostname: String,
    pub revoked_at: DateTime<Utc>,
    #[serde(skip_serializing_if = "Option::is_none")]
    pub revoked_by: Option<String>,
    #[serde(skip_serializing_if = "Option::is_none")]
    pub reason: Option<String>,
}

const ROSTER_FILENAME: &str = "roster.json";

impl Roster {
    /// Create a minimal empty roster (for uninitialized state).
    pub fn empty() -> Self {
        Self {
            metadata: RosterMetadata {
                created_at: Utc::now(),
                enrollment_open: false,
                requires_approval: false,
                operator: None,
                policy: CertPolicy::default(),
                seq: 0,
            },
            members: Vec::new(),
            revocation_list: Vec::new(),
        }
    }

    /// Create a new empty roster from the two posture booleans.
    pub fn new(enrollment_open: bool, requires_approval: bool, operator: Option<String>) -> Self {
        Self {
            metadata: RosterMetadata {
                created_at: Utc::now(),
                enrollment_open,
                requires_approval,
                operator,
                policy: CertPolicy::default(),
                seq: 0,
            },
            members: Vec::new(),
            revocation_list: Vec::new(),
        }
    }

    /// Whether enrollment requires operator approval.
    pub fn requires_approval(&self) -> bool {
        self.metadata.requires_approval
    }

    /// Check if enrollment is currently open.
    pub fn is_enrollment_open(&self) -> bool {
        self.metadata.enrollment_open
    }

    /// The wire representation of the current enrollment state.
    pub fn enrollment_state(&self) -> EnrollmentState {
        EnrollmentState::from_open(self.metadata.enrollment_open)
    }

    /// Open the enrollment window.
    pub fn open_enrollment(&mut self) {
        self.metadata.enrollment_open = true;
    }

    /// Close the enrollment window.
    pub fn close_enrollment(&mut self) {
        self.metadata.enrollment_open = false;
    }

    /// Find a member by hostname.
    pub fn find_member(&self, hostname: &str) -> Option<&RosterMember> {
        self.members.iter().find(|m| m.hostname == hostname)
    }

    /// Check if a hostname is already enrolled.
    pub fn is_enrolled(&self, hostname: &str) -> bool {
        self.members
            .iter()
            .any(|m| m.hostname == hostname && m.status == MemberStatus::Active)
    }

    /// Check if a hostname has been revoked.
    ///
    /// Comprehensive by design: a host counts as revoked if it is on the
    /// revocation list **or** its roster entry is `MemberStatus::Revoked`.
    /// `revoke_member` sets both, so the two are normally in lock-step; checking
    /// both makes every revocation guard (enroll, renew, health) fail closed even
    /// if a roster were ever left in a partially-revoked state.
    pub fn is_revoked(&self, hostname: &str) -> bool {
        self.revocation_list.iter().any(|r| r.hostname == hostname)
            || self
                .members
                .iter()
                .any(|m| m.hostname == hostname && m.status == MemberStatus::Revoked)
    }

    /// Revoke a member and record the revocation entry.
    pub fn revoke_member(
        &mut self,
        hostname: &str,
        operator: Option<String>,
        reason: Option<String>,
    ) -> Result<(), String> {
        let member = self
            .find_member_mut(hostname)
            .ok_or_else(|| format!("member not found: {hostname}"))?;

        if member.status == MemberStatus::Revoked {
            return Ok(());
        }

        member.status = MemberStatus::Revoked;
        self.revocation_list.push(RevokedMember {
            hostname: hostname.to_string(),
            revoked_at: Utc::now(),
            revoked_by: operator,
            reason,
        });
        Ok(())
    }

    /// Number of active members.
    pub fn active_count(&self) -> usize {
        self.members
            .iter()
            .filter(|m| m.status == MemberStatus::Active)
            .count()
    }

    /// Find the active primary member.
    pub fn primary(&self) -> Option<&RosterMember> {
        self.members
            .iter()
            .find(|m| m.role == MemberRole::Primary && m.status == MemberStatus::Active)
    }

    /// Find all active standby members.
    pub fn standbys(&self) -> Vec<&RosterMember> {
        self.members
            .iter()
            .filter(|m| m.role == MemberRole::Standby && m.status == MemberStatus::Active)
            .collect()
    }

    /// Find a mutable reference to a member by hostname.
    pub fn find_member_mut(&mut self, hostname: &str) -> Option<&mut RosterMember> {
        self.members.iter_mut().find(|m| m.hostname == hostname)
    }

    /// Update the last_seen timestamp for a member.
    pub fn touch_member(&mut self, hostname: &str) {
        if let Some(m) = self.find_member_mut(hostname) {
            m.last_seen = Some(Utc::now());
        }
    }
}

/// Path to the roster file within the certmesh directory.
pub fn roster_path(certmesh_dir: &Path) -> PathBuf {
    certmesh_dir.join(ROSTER_FILENAME)
}

/// Save the roster to disk as pretty-printed JSON.
pub fn save_roster(roster: &Roster, path: &Path) -> Result<(), std::io::Error> {
    persist::write_json_pretty(path, roster)?;
    tracing::debug!(path = %path.display(), "Roster saved");
    Ok(())
}

/// Persist the roster off the async executor.
///
/// This is the single mechanical home for the
/// `clone → spawn_blocking(save_roster) → await` pattern used throughout the
/// crate. It owns the roster clone, the `spawn_blocking` hop, and the error
/// mapping; it does **not** touch the roster lock (callers clone under the lock
/// and drop it before calling).
///
/// # Failure mode
///
/// Returns [`CertmeshError::Io`] whenever the save does not complete — whether
/// the blocking task panicked (`JoinError`) or the underlying write failed
/// (`std::io::Error`). Both are surfaced as `Io` so call sites have one error
/// variant to handle. Callers decide the *policy*: propagate with `?`, or
/// `if let Err(e) = persist_roster(..).await { tracing::warn!(..) }` to warn and
/// continue.
pub(crate) async fn persist_roster(
    roster: &Roster,
    path: &Path,
) -> Result<(), crate::error::CertmeshError> {
    let roster_clone = roster.clone();
    let path = path.to_path_buf();
    tokio::task::spawn_blocking(move || save_roster(&roster_clone, &path))
        .await
        .map_err(|e| std::io::Error::other(format!("roster save task: {e}")))
        .and_then(|r| r)
        .map_err(crate::error::CertmeshError::Io)
}

/// Load the roster from disk.
pub fn load_roster(path: &Path) -> Result<Roster, std::io::Error> {
    persist::read_json(path)
}

#[cfg(test)]
mod tests {
    use super::*;

    // Posture booleans for the three named presets (UX labels only).
    const JUST_ME: (bool, bool) = (true, false);
    const MY_TEAM: (bool, bool) = (true, true);
    const MY_ORG: (bool, bool) = (false, true);

    #[test]
    fn new_roster_just_me_is_open() {
        let r = Roster::new(JUST_ME.0, JUST_ME.1, None);
        assert!(r.metadata.enrollment_open);
        assert!(!r.metadata.requires_approval);
        assert_eq!(r.enrollment_state(), EnrollmentState::Open);
        assert!(r.metadata.operator.is_none());
        assert!(r.members.is_empty());
        assert!(r.revocation_list.is_empty());
    }

    #[test]
    fn new_roster_organization_closed() {
        let r = Roster::new(MY_ORG.0, MY_ORG.1, Some("Admin".to_string()));
        assert!(!r.metadata.enrollment_open);
        assert!(r.metadata.requires_approval);
        assert_eq!(r.enrollment_state(), EnrollmentState::Closed);
        assert_eq!(r.metadata.operator.as_deref(), Some("Admin"));
    }

    #[test]
    fn metadata_bools_round_trip_through_json() {
        // The two posture booleans must survive a serialize/deserialize cycle.
        let r = Roster::new(MY_TEAM.0, MY_TEAM.1, Some("Alice".to_string()));
        let json = serde_json::to_string(&r).unwrap();
        assert!(json.contains("\"enrollment_open\":true"));
        assert!(json.contains("\"requires_approval\":true"));
        let back: Roster = serde_json::from_str(&json).unwrap();
        assert!(back.metadata.enrollment_open);
        assert!(back.metadata.requires_approval);
        assert_eq!(back.metadata.operator.as_deref(), Some("Alice"));
    }

    #[test]
    fn roster_serde_round_trip() {
        let mut r = Roster::new(MY_TEAM.0, MY_TEAM.1, Some("Alice".to_string()));
        r.members.push(RosterMember {
            hostname: "node-01".to_string(),
            role: MemberRole::Primary,
            enrolled_at: Utc::now(),
            enrolled_by: Some("Alice".to_string()),
            cert_fingerprint: "abc123".to_string(),
            cert_expires: Utc::now(),
            cert_sans: vec!["node-01".to_string(), "node-01.local".to_string()],
            cert_path: "/home/koi/.koi/certs/node-01".to_string(),
            status: MemberStatus::Active,
            reload_hook: None,
            last_seen: Some(Utc::now()),
            pinned_ca_fingerprint: Some("cafp123".to_string()),
            proxy_entries: Vec::new(),
        });

        let json = serde_json::to_string(&r).unwrap();
        let deserialized: Roster = serde_json::from_str(&json).unwrap();

        assert_eq!(deserialized.members.len(), 1);
        assert_eq!(deserialized.members[0].hostname, "node-01");
        assert_eq!(deserialized.members[0].role, MemberRole::Primary);
    }

    #[test]
    fn save_and_load_roster() {
        let dir = std::env::temp_dir().join("koi-certmesh-test-roster");
        let _ = std::fs::remove_dir_all(&dir);
        std::fs::create_dir_all(&dir).unwrap();
        let path = dir.join("roster.json");

        let r = Roster::new(JUST_ME.0, JUST_ME.1, None);
        save_roster(&r, &path).unwrap();
        let loaded = load_roster(&path).unwrap();

        assert!(loaded.metadata.enrollment_open);
        assert!(!loaded.metadata.requires_approval);

        let _ = std::fs::remove_dir_all(&dir);
    }

    #[test]
    fn find_and_count_members() {
        let mut r = Roster::new(JUST_ME.0, JUST_ME.1, None);
        assert_eq!(r.active_count(), 0);
        assert!(!r.is_enrolled("node-01"));

        r.members.push(RosterMember {
            hostname: "node-01".to_string(),
            role: MemberRole::Primary,
            enrolled_at: Utc::now(),
            enrolled_by: None,
            cert_fingerprint: "abc".to_string(),
            cert_expires: Utc::now(),
            cert_sans: vec![],
            cert_path: String::new(),
            status: MemberStatus::Active,
            reload_hook: None,
            last_seen: None,
            pinned_ca_fingerprint: None,
            proxy_entries: Vec::new(),
        });

        assert_eq!(r.active_count(), 1);
        assert!(r.is_enrolled("node-01"));
        assert!(r.find_member("node-01").is_some());
        assert!(r.find_member("node-99").is_none());
    }

    #[test]
    fn backward_compat_deserialize_without_new_fields() {
        // Older roster JSON had no reload_hook, last_seen, or pinned_ca_fingerprint.
        // Verify it still deserializes cleanly via #[serde(default)]. The posture
        // booleans also default (false) when absent.
        let json = r#"{
            "metadata": {
                "created_at": "2026-02-01T00:00:00Z",
                "enrollment_open": true,
                "requires_approval": false
            },
            "members": [{
                "hostname": "old-host",
                "role": "primary",
                "enrolled_at": "2026-02-01T00:00:00Z",
                "cert_fingerprint": "abc",
                "cert_expires": "2026-03-01T00:00:00Z",
                "cert_sans": ["old-host"],
                "cert_path": "/certs/old-host",
                "status": "active"
            }]
        }"#;
        let r: Roster = serde_json::from_str(json).unwrap();
        assert_eq!(r.members.len(), 1);
        assert!(r.metadata.enrollment_open);
        assert!(!r.metadata.requires_approval);
        assert!(r.members[0].reload_hook.is_none());
        assert!(r.members[0].last_seen.is_none());
        assert!(r.members[0].pinned_ca_fingerprint.is_none());
    }

    #[test]
    fn standby_role_serde() {
        let json = r#""standby""#;
        let role: MemberRole = serde_json::from_str(json).unwrap();
        assert_eq!(role, MemberRole::Standby);

        let serialized = serde_json::to_string(&MemberRole::Standby).unwrap();
        assert_eq!(serialized, r#""standby""#);
    }

    #[test]
    fn primary_and_standbys_helpers() {
        let mut r = Roster::new(JUST_ME.0, JUST_ME.1, None);

        // No primary yet
        assert!(r.primary().is_none());
        assert!(r.standbys().is_empty());

        let make_member = |hostname: &str, role: MemberRole| RosterMember {
            hostname: hostname.to_string(),
            role,
            enrolled_at: Utc::now(),
            enrolled_by: None,
            cert_fingerprint: "fp".to_string(),
            cert_expires: Utc::now(),
            cert_sans: vec![],
            cert_path: String::new(),
            status: MemberStatus::Active,
            reload_hook: None,
            last_seen: None,
            pinned_ca_fingerprint: None,
            proxy_entries: Vec::new(),
        };

        r.members.push(make_member("node-01", MemberRole::Primary));
        r.members.push(make_member("node-02", MemberRole::Standby));
        r.members.push(make_member("node-03", MemberRole::Member));
        r.members.push(make_member("node-04", MemberRole::Standby));

        assert_eq!(r.primary().unwrap().hostname, "node-01");
        let standbys = r.standbys();
        assert_eq!(standbys.len(), 2);
        assert!(standbys.iter().any(|m| m.hostname == "node-02"));
        assert!(standbys.iter().any(|m| m.hostname == "node-04"));
    }

    #[test]
    fn find_member_mut_and_touch() {
        let mut r = Roster::new(JUST_ME.0, JUST_ME.1, None);
        r.members.push(RosterMember {
            hostname: "node-01".to_string(),
            role: MemberRole::Primary,
            enrolled_at: Utc::now(),
            enrolled_by: None,
            cert_fingerprint: "fp".to_string(),
            cert_expires: Utc::now(),
            cert_sans: vec![],
            cert_path: String::new(),
            status: MemberStatus::Active,
            reload_hook: None,
            last_seen: None,
            pinned_ca_fingerprint: None,
            proxy_entries: Vec::new(),
        });

        // last_seen is None initially
        assert!(r.members[0].last_seen.is_none());

        // touch_member updates last_seen
        r.touch_member("node-01");
        assert!(r.members[0].last_seen.is_some());

        // touch_member on unknown host is a no-op
        r.touch_member("nonexistent");

        // find_member_mut allows direct mutation
        let m = r.find_member_mut("node-01").unwrap();
        m.reload_hook = Some("systemctl restart nginx".to_string());
        assert_eq!(
            r.members[0].reload_hook.as_deref(),
            Some("systemctl restart nginx"),
        );
    }

    // ── Enrollment window tests ────────────────────────────────────

    #[test]
    fn open_and_close_enrollment() {
        let mut r = Roster::new(MY_ORG.0, MY_ORG.1, Some("Admin".into()));
        assert!(!r.is_enrollment_open());
        assert_eq!(r.enrollment_state(), EnrollmentState::Closed);

        r.open_enrollment();
        assert!(r.is_enrollment_open());
        assert_eq!(r.enrollment_state(), EnrollmentState::Open);

        r.close_enrollment();
        assert!(!r.is_enrollment_open());
        assert_eq!(r.enrollment_state(), EnrollmentState::Closed);
    }

    #[test]
    fn new_fields_skip_serialization_when_none() {
        let member = RosterMember {
            hostname: "node-01".to_string(),
            role: MemberRole::Primary,
            enrolled_at: Utc::now(),
            enrolled_by: None,
            cert_fingerprint: "fp".to_string(),
            cert_expires: Utc::now(),
            cert_sans: vec![],
            // A non-empty path proves F13's `#[serde(skip)]` (not merely empty-skip):
            // the CA host's local cert dir must never leak into roster.json.
            cert_path: "/var/lib/koi/certs/node-01".to_string(),
            status: MemberStatus::Active,
            reload_hook: None,
            last_seen: None,
            pinned_ca_fingerprint: None,
            proxy_entries: Vec::new(),
        };
        let json = serde_json::to_string(&member).unwrap();
        // None fields should not appear in JSON
        assert!(!json.contains("reload_hook"));
        assert!(!json.contains("last_seen"));
        assert!(!json.contains("pinned_ca_fingerprint"));
        // F13: cert_path is never serialized (skip), so the local path can't leak.
        assert!(!json.contains("cert_path"));
        assert!(!json.contains("/var/lib/koi/certs"));
    }
}