koda-cli 0.2.15

A high-performance AI coding agent for macOS and Linux
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
//! MCP server management handlers for `/mcp` slash commands.
//!
//! Extracted from [`crate::tui_commands`] to keep file sizes manageable.
//! All output flows through the [`crate::scroll_buffer::ScrollBuffer`].

use crate::scroll_buffer::ScrollBuffer;
use crate::tui_output;

use koda_core::agent::KodaAgent;
use koda_core::mcp::config::{self, McpServerConfig, McpTransport, validate_server_name};
use koda_core::session::KodaSession;
use std::collections::HashMap;
use std::sync::Arc;

/// Handle `/mcp list` — show all configured servers and their status.
pub async fn handle_mcp_list(
    buffer: &mut ScrollBuffer,
    session: &KodaSession,
    agent: &Arc<KodaAgent>,
) {
    // Show status from live McpManager (if attached).
    let live_statuses = get_live_statuses(agent).await;

    // Also load configs from DB for servers that may not be connected.
    let db_configs = match config::load_mcp_configs(&session.db).await {
        Ok(c) => c,
        Err(e) => {
            tui_output::err_msg(buffer, format!("Failed to load MCP configs: {e}"));
            return;
        }
    };

    if db_configs.is_empty() && live_statuses.is_empty() {
        tui_output::dim_msg(
            buffer,
            "No MCP servers configured.\n\
             \n\
             Usage:\n  \
             /mcp add <name> <command> [args...]\n  \
             /mcp add-http <name> <url> [--token <bearer>]\n  \
             /mcp remove <name>\n  \
             /mcp reconnect <name>\n  \
             /mcp list\n\
             \n\
             Examples:\n  \
             /mcp add playwright npx -y @anthropic/mcp-playwright\n  \
             /mcp add-http myapi http://localhost:8080/mcp --token secret123"
                .to_string(),
        );
        return;
    }

    let mut lines: Vec<String> = vec!["MCP Servers:".to_string(), String::new()];

    // Merge DB configs with live status.
    let all_names = {
        let mut names: Vec<String> = db_configs.keys().cloned().collect();
        for status in &live_statuses {
            if !names.contains(&status.name) {
                names.push(status.name.clone());
            }
        }
        names.sort();
        names
    };

    for name in &all_names {
        let status = live_statuses.iter().find(|s| &s.name == name);
        let config = db_configs.get(name);

        let status_icon = match status {
            Some(s) => match s.status {
                koda_core::mcp::client::McpClientStatus::Connected => "🟢",
                koda_core::mcp::client::McpClientStatus::Connecting => "🟡",
                koda_core::mcp::client::McpClientStatus::Failed => "🔴",
                koda_core::mcp::client::McpClientStatus::Disconnected => "",
            },
            None => "",
        };

        let tools_info = match status {
            Some(s) if s.tool_count > 0 => format!(" ({} tools)", s.tool_count),
            _ => String::new(),
        };

        let cmd_info = match config {
            Some(c) => match &c.transport {
                McpTransport::Stdio { command, args, .. } => {
                    let full = if args.is_empty() {
                        command.clone()
                    } else {
                        format!("{command} {}", args.join(" "))
                    };
                    format!("  cmd: {full}")
                }
                McpTransport::Http { url, .. } => {
                    format!("  url: {url}")
                }
            },
            None => String::new(),
        };

        let error_info = match status {
            Some(s) if s.error.is_some() => {
                format!("  error: {}", s.error.as_deref().unwrap_or(""))
            }
            _ => String::new(),
        };

        lines.push(format!("  {status_icon} {name}{tools_info}"));
        if !cmd_info.is_empty() {
            lines.push(cmd_info);
        }
        if !error_info.is_empty() {
            lines.push(error_info);
        }
    }

    tui_output::dim_msg(buffer, lines.join("\n"));
}

/// Handle `/mcp add <name> <command> [args...]`.
pub async fn handle_mcp_add(
    buffer: &mut ScrollBuffer,
    session: &KodaSession,
    agent: &Arc<KodaAgent>,
    name: String,
    command: String,
    args: Vec<String>,
) {
    let config = McpServerConfig {
        transport: McpTransport::Stdio {
            command: command.clone(),
            args: args.clone(),
            env: HashMap::new(),
            cwd: None,
        },
        startup_timeout_sec: 30,
        tool_timeout_sec: 120,
        enabled_tools: None,
        disabled_tools: None,
    };

    // Validate name, then config.
    if let Err(e) = validate_server_name(&name) {
        tui_output::err_msg(buffer, format!("Invalid server name: {e}"));
        return;
    }
    // Validate first.
    if let Err(e) = config.validate() {
        tui_output::err_msg(buffer, format!("Invalid config: {e}"));
        return;
    }

    // Save to DB.
    if let Err(e) = config::save_mcp_config(&session.db, &name, &config).await {
        tui_output::err_msg(buffer, format!("Failed to save config: {e}"));
        return;
    }

    // Hot-reload: connect immediately if we have a manager.
    let connect_result = try_add_to_live_manager(agent, name.clone(), config).await;

    match connect_result {
        Some(Ok((tool_count,))) => {
            let cmd_display = if args.is_empty() {
                command
            } else {
                format!("{command} {}", args.join(" "))
            };
            tui_output::ok_msg(
                buffer,
                format!(
                    "MCP server '{name}' added and connected ({tool_count} tools)\n  cmd: {cmd_display}"
                ),
            );
        }
        Some(Err(e)) => {
            tui_output::warn_msg(
                buffer,
                format!(
                    "MCP server '{name}' saved but failed to connect: {e}\n\
                     It will retry on next session start."
                ),
            );
        }
        None => {
            tui_output::ok_msg(
                buffer,
                format!("MCP server '{name}' saved. Will connect on next session start."),
            );
        }
    }
}

/// Handle `/mcp add-http <name> <url> [--token <bearer>]`.
pub async fn handle_mcp_add_http(
    buffer: &mut ScrollBuffer,
    session: &KodaSession,
    agent: &Arc<KodaAgent>,
    name: String,
    url: String,
    bearer_token: Option<String>,
) {
    let config = McpServerConfig {
        transport: McpTransport::Http {
            url: url.clone(),
            bearer_token: bearer_token.clone(),
            headers: HashMap::new(),
        },
        startup_timeout_sec: 30,
        tool_timeout_sec: 120,
        enabled_tools: None,
        disabled_tools: None,
    };

    // Validate name, then config.
    if let Err(e) = validate_server_name(&name) {
        tui_output::err_msg(buffer, format!("Invalid server name: {e}"));
        return;
    }
    if let Err(e) = config.validate() {
        tui_output::err_msg(buffer, format!("Invalid config: {e}"));
        return;
    }

    // Persist to DB.
    if let Err(e) = config::save_mcp_config(&session.db, &name, &config).await {
        tui_output::err_msg(buffer, format!("Failed to save MCP config: {e}"));
        return;
    }

    // Hot-reload: connect immediately if we have a manager.
    let connect_result = try_add_to_live_manager(agent, name.clone(), config).await;

    let token_hint = if bearer_token.is_some() {
        " (with auth)"
    } else {
        ""
    };

    match connect_result {
        Some(Ok((tool_count,))) => {
            tui_output::ok_msg(
                buffer,
                format!(
                    "MCP server '{name}' added via HTTP and connected ({tool_count} tools)\n  url: {url}{token_hint}"
                ),
            );
        }
        Some(Err(e)) => {
            tui_output::warn_msg(
                buffer,
                format!(
                    "MCP server '{name}' saved but failed to connect: {e}\n\
                     It will retry on next session start."
                ),
            );
        }
        None => {
            tui_output::ok_msg(
                buffer,
                format!("MCP server '{name}' saved. Will connect on next session start."),
            );
        }
    }
}

/// Handle `/mcp remove <name>`.
pub async fn handle_mcp_remove(
    buffer: &mut ScrollBuffer,
    session: &KodaSession,
    agent: &Arc<KodaAgent>,
    name: String,
) {
    // Check it exists in DB.
    let exists = match config::list_mcp_server_names(&session.db).await {
        Ok(names) => names.contains(&name),
        Err(e) => {
            tui_output::err_msg(buffer, format!("Failed to check MCP configs: {e}"));
            return;
        }
    };

    if !exists {
        tui_output::err_msg(buffer, format!("MCP server '{name}' not found."));
        return;
    }

    // Remove from DB.
    if let Err(e) = config::remove_mcp_config(&session.db, &name).await {
        tui_output::err_msg(buffer, format!("Failed to remove config: {e}"));
        return;
    }

    // Hot-reload: disconnect if live.
    let was_live = try_remove_from_live_manager(agent, &name).await;

    let extra = if was_live { " and disconnected" } else { "" };
    tui_output::ok_msg(buffer, format!("MCP server '{name}' removed{extra}."));
}

// ── Helpers ─────────────────────────────────────────────────────────────

/// Get live status summaries from the McpManager (if attached).
async fn get_live_statuses(
    agent: &Arc<KodaAgent>,
) -> Vec<koda_core::mcp::manager::McpServerStatus> {
    let Some(mgr) = agent.tools.mcp_manager() else {
        return vec![];
    };
    let Ok(mgr) = mgr.try_read() else {
        return vec![];
    };
    mgr.status_summary()
}

/// Try to add a server to the live McpManager. Returns None if no manager.
async fn try_add_to_live_manager(
    agent: &Arc<KodaAgent>,
    name: String,
    config: McpServerConfig,
) -> Option<Result<(usize,), anyhow::Error>> {
    let mgr = agent.tools.mcp_manager()?;
    let mut mgr = mgr.write().await;
    let result = mgr.add_server(name.clone(), config).await;
    match &result {
        Ok(()) => {
            let tool_count = mgr
                .status_summary()
                .iter()
                .find(|s| s.name == name)
                .map(|s| s.tool_count)
                .unwrap_or(0);
            Some(Ok((tool_count,)))
        }
        Err(e) => Some(Err(anyhow::anyhow!("{e}"))),
    }
}

/// Try to remove a server from the live McpManager. Returns whether it was live.
async fn try_remove_from_live_manager(agent: &Arc<KodaAgent>, name: &str) -> bool {
    let Some(mgr) = agent.tools.mcp_manager() else {
        return false;
    };
    let mut mgr = mgr.write().await;
    mgr.remove_server(name).await
}

/// Handle `/mcp reconnect <name>`.
pub async fn handle_mcp_reconnect(buffer: &mut ScrollBuffer, agent: &Arc<KodaAgent>, name: String) {
    let Some(mgr) = agent.tools.mcp_manager() else {
        tui_output::err_msg(buffer, "No MCP manager available.".into());
        return;
    };

    tui_output::dim_msg(buffer, format!("Reconnecting MCP server '{name}'..."));

    let result = {
        let mut mgr = mgr.write().await;
        mgr.reconnect_server(&name).await
    };

    match result {
        Ok(tool_count) => {
            tui_output::ok_msg(
                buffer,
                format!("MCP server '{name}' reconnected ({tool_count} tools)"),
            );
        }
        Err(e) => {
            tui_output::err_msg(buffer, format!("Failed to reconnect '{name}': {e}"));
        }
    }
}

// ── Tests ──────────────────────────────────────────────────────────────────────────

#[cfg(test)]
mod tests {
    use super::*;
    use crate::scroll_buffer::ScrollBuffer;
    use koda_core::config::{KodaConfig, ProviderType};
    use koda_core::db::Database;
    use koda_core::session::KodaSession;
    use koda_core::trust::TrustMode;
    use tempfile::TempDir;

    // ── Helpers ───────────────────────────────────────────────────

    fn make_buffer() -> ScrollBuffer {
        ScrollBuffer::new(100)
    }

    /// Flatten all span content in the buffer into a single string for assertions.
    fn buffer_text(buf: &ScrollBuffer) -> String {
        buf.all_lines()
            .flat_map(|l| l.spans.iter())
            .map(|s| s.content.as_ref())
            .collect::<String>()
    }

    /// Build a minimal test agent + session (no API key needed — mock provider).
    async fn make_agent_and_session(tmp: &TempDir) -> (Arc<KodaAgent>, KodaSession) {
        let mut config = KodaConfig::load(tmp.path(), "default").unwrap();
        // Swap to mock so KodaSession::new() doesn’t warn about missing API key.
        config.provider_type = ProviderType::Mock;

        let agent = Arc::new(
            KodaAgent::new(&config, tmp.path().to_owned(), &[])
                .await
                .unwrap(),
        );
        let db = Database::open(&tmp.path().join("koda.db")).await.unwrap();
        let session = KodaSession::new(
            "test-session".into(),
            Arc::clone(&agent),
            db,
            &config,
            TrustMode::Safe,
        )
        .await;
        (agent, session)
    }

    // ── handle_mcp_reconnect: no manager ──────────────────────────────

    #[tokio::test]
    async fn reconnect_with_no_manager_shows_error() {
        let tmp = TempDir::new().unwrap();
        let (agent, _session) = make_agent_and_session(&tmp).await;
        let mut buf = make_buffer();

        // Fresh session with empty DB → no MCP servers → no manager attached.
        handle_mcp_reconnect(&mut buf, &agent, "myserver".into()).await;

        let text = buffer_text(&buf);
        assert!(
            text.contains("No MCP manager"),
            "expected 'No MCP manager' in: {text}"
        );
    }

    // ── handle_mcp_list: empty DB ───────────────────────────────────

    #[tokio::test]
    async fn list_empty_db_shows_usage_hint() {
        let tmp = TempDir::new().unwrap();
        let (agent, session) = make_agent_and_session(&tmp).await;
        let mut buf = make_buffer();

        handle_mcp_list(&mut buf, &session, &agent).await;

        let text = buffer_text(&buf);
        assert!(
            text.contains("/mcp add"),
            "expected usage hint with '/mcp add' in: {text}"
        );
        assert!(
            text.contains("No MCP servers configured"),
            "expected 'No MCP servers configured' in: {text}"
        );
    }

    // ── handle_mcp_add: validation errors ────────────────────────────

    #[tokio::test]
    async fn add_with_invalid_name_shows_validation_error() {
        let tmp = TempDir::new().unwrap();
        let (agent, session) = make_agent_and_session(&tmp).await;
        let mut buf = make_buffer();

        // Names with spaces are invalid.
        handle_mcp_add(
            &mut buf,
            &session,
            &agent,
            "bad name".into(),
            "npx".into(),
            vec![],
        )
        .await;

        let text = buffer_text(&buf);
        assert!(
            text.contains("Invalid server name"),
            "expected validation error in: {text}"
        );
    }

    #[tokio::test]
    async fn add_with_empty_command_shows_config_error() {
        let tmp = TempDir::new().unwrap();
        let (agent, session) = make_agent_and_session(&tmp).await;
        let mut buf = make_buffer();

        // Empty command string → config validate() should reject it.
        handle_mcp_add(
            &mut buf,
            &session,
            &agent,
            "valid-name".into(),
            String::new(),
            vec![],
        )
        .await;

        let text = buffer_text(&buf);
        assert!(
            text.contains("Invalid config") || text.contains("empty"),
            "expected config validation error in: {text}"
        );
    }

    // ── handle_mcp_add_http: token hint ───────────────────────────────

    #[tokio::test]
    async fn add_http_with_invalid_name_shows_validation_error() {
        let tmp = TempDir::new().unwrap();
        let (agent, session) = make_agent_and_session(&tmp).await;
        let mut buf = make_buffer();

        handle_mcp_add_http(
            &mut buf,
            &session,
            &agent,
            "bad name!".into(),
            "http://localhost:8080/mcp".into(),
            None,
        )
        .await;

        let text = buffer_text(&buf);
        assert!(
            text.contains("Invalid server name"),
            "expected name validation error in: {text}"
        );
    }

    // ── handle_mcp_remove: nonexistent server ─────────────────────────

    #[tokio::test]
    async fn remove_nonexistent_server_shows_error() {
        let tmp = TempDir::new().unwrap();
        let (agent, session) = make_agent_and_session(&tmp).await;
        let mut buf = make_buffer();

        handle_mcp_remove(&mut buf, &session, &agent, "ghost-server".into()).await;

        let text = buffer_text(&buf);
        assert!(
            text.contains("ghost-server"),
            "error should mention the server name in: {text}"
        );
        // Should show an error (not found / remove failed).
        assert!(
            text.contains("not found") || text.contains("Failed") || text.contains("no server"),
            "expected not-found or error message in: {text}"
        );
    }
}