knowledge-base-extension-framework 0.1.0

Static extension contracts for the file-based knowledge base
Documentation 
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207

use knowledge_base_extension_framework::bindings::ResolvedBindings;
use knowledge_base_extension_framework::contracts::{
    BindingDeclaration, BindingKey, BindingKind, ContractVersion, ExtensionDependency, ExtensionId, ExtensionMetadata, KnowledgeBaseExtension, OntologyRequirements,
};
use knowledge_base_extension_framework::error::FrameworkError;
use knowledge_base_extension_framework::manifest::{ExtensionManifest, ManifestDiagnostic, ManifestError};
use knowledge_base_extension_framework::registry::ExtensionRegistry;
use knowledge_base_validation::KnowledgeBaseValidator;
use std::fs;
use std::path::Path;
use std::sync::Arc;
use tempfile::TempDir;

struct TestExtension(ExtensionMetadata);

impl KnowledgeBaseExtension for TestExtension {
    fn metadata(&self) -> &ExtensionMetadata {
        &self.0
    }

    fn validators(&self, _: &ResolvedBindings) -> Result<Vec<Arc<dyn KnowledgeBaseValidator>>, FrameworkError> {
        Ok(Vec::new())
    }
}

fn id(value: &str) -> ExtensionId {
    value.parse().unwrap()
}

fn key(value: &str) -> BindingKey {
    value.parse().unwrap()
}

fn extension(name: &str, dependencies: &[&str], bindings: &[(&str, BindingKind)]) -> Arc<dyn KnowledgeBaseExtension> {
    Arc::new(TestExtension(ExtensionMetadata {
        id: id(name),
        contract: ContractVersion::new(1),
        dependencies: dependencies
            .iter()
            .map(|dependency| ExtensionDependency {
                id: id(dependency),
                contract: ContractVersion::new(1),
            })
            .collect(),
        bindings: bindings.iter().map(|(name, kind)| BindingDeclaration { key: key(name), kind: *kind }).collect(),
        ontology_requirements: OntologyRequirements::default(),
    }))
}

fn registry() -> ExtensionRegistry {
    ExtensionRegistry::new([
        extension("wikidata", &[], &[("item_id_property", BindingKind::Property)]),
        extension(
            "public-transport",
            &["wikidata"],
            &[("stop_place_type", BindingKind::EntityType), ("route_line_property", BindingKind::Property)],
        ),
    ])
    .unwrap()
}

fn write_manifest(root: &Path, source: &str) {
    fs::write(root.join("extensions.yaml"), source).unwrap();
}

fn repository() -> TempDir {
    let root = tempfile::tempdir().unwrap();
    for directory in ["entities", "entity_types", "properties", "references"] {
        fs::create_dir(root.path().join(directory)).unwrap();
    }
    fs::write(
        root.path().join("id_allocation.yaml"),
        "version: 1\nnext:\n  entity: 1\n  property: 2\n  reference: 1\n  entity_type: 2\n",
    )
    .unwrap();
    fs::write(root.path().join("entity_types/T1.yaml"), "id: T1\nlabels: {}\n").unwrap();
    fs::write(
        root.path().join("properties/P1.yaml"),
        "id: P1\nlabels: {}\nsubject_types: []\nvalue_type: string\nusage: statement\n",
    )
    .unwrap();
    root
}

#[test]
fn parses_base_only_and_composed_manifests_in_stable_order() {
    let base: ExtensionManifest = serde_yaml::from_str("version: 1\nextensions: {}\n").unwrap();
    assert!(base.extensions.is_empty());

    let composed: ExtensionManifest = serde_yaml::from_str(
        "version: 1\nextensions:\n  public-transport:\n    contract: 1\n    properties:\n      route_line_property: P1\n    entity_types:\n      stop_place_type: T1\n  wikidata:\n    contract: 1\n    properties:\n      item_id_property: P1\n",
    )
    .unwrap();
    assert_eq!(composed.extensions.keys().map(ToString::to_string).collect::<Vec<_>>(), ["public-transport", "wikidata"]);
    let serialized = serde_yaml::to_string(&composed).unwrap();
    assert!(serialized.find("public-transport:").unwrap() < serialized.find("wikidata:").unwrap());
    assert!(serialized.find("entity_types:").unwrap() < serialized.find("properties:").unwrap());
}

#[test]
fn rejects_missing_and_malformed_manifests() {
    let root = tempfile::tempdir().unwrap();
    assert!(matches!(ExtensionManifest::load(root.path()), Err(ManifestError::Read { .. })));

    for source in [
        "version: 1\nunknown: true\nextensions: {}\n",
        "version: 1\nextensions:\n  PublicTransport:\n    contract: 1\n",
        "version: 1\nextensions:\n  wikidata:\n    contract: 1\n    properties:\n      item_id_property: T1\n",
        "version: 1\nextensions:\n  public-transport:\n    contract: 1\n    entity_types:\n      stop_place_type: P1\n",
    ] {
        write_manifest(root.path(), source);
        assert!(matches!(ExtensionManifest::load(root.path()), Err(ManifestError::Parse { .. })), "{source}");
    }

    write_manifest(root.path(), "version: 2\nextensions: {}\n");
    assert!(
        matches!(ExtensionManifest::load_and_activate(root.path(), &registry()), Err(ManifestError::Diagnostics { diagnostics, .. }) if diagnostics == vec![ManifestDiagnostic::UnsupportedVersion { version: 2 }])
    );
}

#[test]
fn reports_ordered_activation_problems() {
    let root = tempfile::tempdir().unwrap();
    write_manifest(
        root.path(),
        "version: 1\nextensions:\n  aaa:\n    contract: 1\n  public-transport:\n    contract: 2\n    entity_types:\n      route_line_property: T1\n      unknown_type: T1\n    properties:\n      stop_place_type: P1\n  wikidata:\n    contract: 1\n    properties: {}\n",
    );
    let error = ExtensionManifest::load_and_activate(root.path(), &registry()).unwrap_err();
    let ManifestError::Diagnostics { diagnostics, .. } = error else {
        panic!("expected aggregate diagnostics");
    };
    assert_eq!(
        diagnostics,
        vec![
            ManifestDiagnostic::UnavailableExtension { extension: id("aaa") },
            ManifestDiagnostic::UnsupportedContract {
                extension: id("public-transport"),
                declared: ContractVersion::new(2),
                available: ContractVersion::new(1),
            },
            ManifestDiagnostic::BindingKindMismatch {
                binding: "public-transport:route_line_property".parse().unwrap(),
                expected: BindingKind::Property,
                actual: BindingKind::EntityType,
            },
            ManifestDiagnostic::UndeclaredBinding {
                binding: "public-transport:unknown_type".parse().unwrap()
            },
            ManifestDiagnostic::BindingKindMismatch {
                binding: "public-transport:stop_place_type".parse().unwrap(),
                expected: BindingKind::EntityType,
                actual: BindingKind::Property,
            },
            ManifestDiagnostic::MissingBinding {
                binding: "public-transport:route_line_property".parse().unwrap()
            },
            ManifestDiagnostic::MissingBinding {
                binding: "public-transport:stop_place_type".parse().unwrap()
            },
            ManifestDiagnostic::MissingBinding {
                binding: "wikidata:item_id_property".parse().unwrap()
            },
        ]
    );
}

#[test]
fn requires_declared_dependencies_and_resolves_existing_ontology_records() {
    let root = repository();
    write_manifest(
        root.path(),
        "version: 1\nextensions:\n  public-transport:\n    contract: 1\n    entity_types:\n      stop_place_type: T1\n    properties:\n      route_line_property: P1\n",
    );
    let error = ExtensionManifest::load_and_activate(root.path(), &registry()).unwrap_err();
    assert!(
        matches!(error, ManifestError::Diagnostics { diagnostics, .. } if diagnostics == vec![ManifestDiagnostic::MissingDependency { extension: id("public-transport"), dependency: id("wikidata") }])
    );

    write_manifest(
        root.path(),
        "version: 1\nextensions:\n  public-transport:\n    contract: 1\n    entity_types:\n      stop_place_type: T1\n    properties:\n      route_line_property: P1\n  wikidata:\n    contract: 1\n    properties:\n      item_id_property: P1\n",
    );
    let activation = ExtensionManifest::load_and_activate(root.path(), &registry()).unwrap();
    assert_eq!(
        activation
            .active()
            .extensions()
            .iter()
            .map(|extension| extension.metadata().id.to_string())
            .collect::<Vec<_>>(),
        ["wikidata", "public-transport"]
    );

    write_manifest(
        root.path(),
        "version: 1\nextensions:\n  wikidata:\n    contract: 1\n    properties:\n      item_id_property: P99\n",
    );
    let error = ExtensionManifest::load_and_activate(root.path(), &registry()).unwrap_err();
    let ManifestError::Diagnostics { diagnostics, .. } = error else {
        panic!("expected missing ontology binding diagnostic");
    };
    assert!(matches!(
        diagnostics.as_slice(),
        [ManifestDiagnostic::MissingProperty { binding, id }]
            if binding.to_string() == "wikidata:item_id_property" && id.to_string() == "P99"
    ));
}