knotra 0.34.0

knotra: multi-project VCS dashboard and bulk-operation tool.
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
//! The workspace domain: `handle_workspace` and `persist_workspace`, its only
//! caller's helper (RFC-040 Stage 4).
//!
//! Depends on `shared`, the intended layering (D7). RFC-066 D3 moved focus
//! entry/return into one post-update step (`focus_ops::settle_layer_focus`,
//! called from `app.rs`), so this module no longer calls `focus_ops` itself.
//! Depended on by `misc.rs` (`handle_dashboard`'s error-retry path) - a
//! one-directional edge; this module must not depend on `misc.rs`.

use iced::Task;
use knotra_vcs::model::{
    project::Project,
    workspace::{Workspace, WorkspaceId},
};

use super::shared;
use crate::{
    config::{AppPaths, save_config},
    message::{Message, WorkspaceMessage},
    persistence::{delete_workspace_file, save_workspace},
    state::{
        AddProjectDialog, AppState, ConfirmRemoveDialog, LoadPhase,
        workspace_mgr::{
            CreateWorkspaceDialog, DeleteWorkspaceDialog, RenameWorkspaceDialog,
            next_active_index_after_delete, validate_workspace_name,
        },
    },
};

fn persist_workspace(paths: &AppPaths, ws: &Workspace) {
    if let Err(e) = save_workspace(ws, paths) {
        tracing::warn!("failed to save workspace: {e}");
    }
}

fn persist_config(state: &AppState) {
    if let Err(e) = save_config(&state.config, &state.paths) {
        tracing::warn!("failed to save config: {e}");
    }
}

/// RFC-073 D4: shared by `RenameWorkspaceDialogOpened` (always the active
/// workspace, from the header switcher or the palette) and
/// `RenameWorkspaceDialogOpenedFor` (any workspace, from Settings'
/// "Workspaces" section) — the dialog itself is unchanged either way.
fn open_rename_dialog(state: &mut AppState, workspace_id: WorkspaceId) {
    state.workspace_mgr.switcher_open = false;
    let current_name = state
        .all_workspaces
        .iter()
        .find(|ws| ws.id == workspace_id)
        .map(|ws| ws.name.clone())
        .unwrap_or_default();
    state.workspace_mgr.rename_dialog = Some(RenameWorkspaceDialog {
        workspace_id,
        new_name: current_name,
        error: None,
    });
}

/// RFC-073 D4: the delete-confirmation counterpart of
/// [`open_rename_dialog`] — same dialog, any workspace.
fn open_delete_dialog(state: &mut AppState, workspace_id: WorkspaceId) {
    state.workspace_mgr.switcher_open = false;
    let Some(ws) = state.all_workspaces.iter().find(|ws| ws.id == workspace_id) else {
        return;
    };
    let workspace_name = ws.name.clone();
    let project_count = ws.projects.len();
    let error = if state.all_workspaces.len() <= 1 {
        Some(state.t("workspace.delete.disabled_last").to_owned())
    } else {
        None
    };
    state.workspace_mgr.confirm_delete = Some(DeleteWorkspaceDialog {
        workspace_id,
        workspace_name,
        project_count,
        error,
    });
}

/// Task 102: the folder "Browse…" should start in — `None` if nothing is
/// remembered, or if what is remembered no longer exists as a directory.
/// Pure, so the three cases (none, gone, present) are each unit-tested
/// without touching disk from the decision itself; the existence check
/// happens at the call site, off the UI thread.
fn initial_browse_dir(
    remembered: Option<&std::path::Path>,
    exists: bool,
) -> Option<&std::path::Path> {
    match remembered {
        Some(p) if exists => Some(p),
        _ => None,
    }
}

pub(super) fn handle_workspace(state: &mut AppState, msg: WorkspaceMessage) -> Task<Message> {
    match msg {
        WorkspaceMessage::RefreshRequested => {
            if !state.is_refreshing {
                state.is_refreshing = true;
                state.load_phase = LoadPhase::Refreshing;
                state.status_bar = Some(state.t("status.refreshing").to_owned());
                shared::refresh_workspace_task(state)
            } else {
                Task::none()
            }
        }

        WorkspaceMessage::AddProjectDialogOpened => {
            state.add_project_dialog = Some(AddProjectDialog::default());
            Task::none()
        }
        WorkspaceMessage::AddProjectNameChanged(s) => {
            if let Some(d) = &mut state.add_project_dialog {
                d.name = s;
                d.error = None;
            }
            Task::none()
        }
        WorkspaceMessage::AddProjectPathChanged(s) => {
            if let Some(d) = &mut state.add_project_dialog {
                d.path = s;
                d.error = None;
            }
            Task::none()
        }
        WorkspaceMessage::AddProjectNextStep => {
            let err_msg = state.t("plain.add_project.error_no_folder").to_owned();
            if let Some(d) = &mut state.add_project_dialog {
                if d.path.trim().is_empty() {
                    d.error = Some(err_msg);
                } else {
                    d.error = None;
                    d.step = crate::state::AddProjectStep::NameProject;
                }
            }
            Task::none()
        }
        WorkspaceMessage::AddProjectConfirmed => {
            let dialog = match state.add_project_dialog.take() {
                Some(d) => d,
                None => return Task::none(),
            };
            let name = dialog.name.trim().to_owned();
            let path = dialog.path.trim().to_owned();
            if name.is_empty() || path.is_empty() {
                state.add_project_dialog = Some(AddProjectDialog {
                    name: dialog.name,
                    path: dialog.path,
                    error: Some(state.t("dialog.add_project.error_empty").to_owned()),
                    ..Default::default()
                });
                return Task::none();
            }
            // Clear any pending undo when a new project is added.
            state.recent_removal = None;
            // Task 102: the parent of the folder just added, remembered only
            // on success — `path` is consumed by `Project::new` below, so
            // its parent is captured here, before that move.
            let parent = std::path::Path::new(&path)
                .parent()
                .map(|p| p.to_path_buf());
            let project = Project::new(name, path);
            let paths = state.paths.clone();
            if let Some(ws) = &mut state.workspace {
                ws.add_project(project);
                persist_workspace(&paths, ws);
                state.config.last_project_parent = parent;
                persist_config(state);
            }
            state.reconcile_selection_with_display();
            state.is_refreshing = true;
            state.load_phase = LoadPhase::Refreshing;
            Task::batch([
                shared::refresh_workspace_task(state),
                shared::scan_topology_task(state),
            ])
        }
        WorkspaceMessage::AddProjectCancelled => {
            state.add_project_dialog = None;
            Task::none()
        }
        WorkspaceMessage::AddProjectBack => {
            if let Some(d) = &mut state.add_project_dialog {
                d.step = crate::state::AddProjectStep::ChooseFolder;
                d.error = None;
            }
            Task::none()
        }
        WorkspaceMessage::BrowsePathRequested => {
            let remembered = state.config.last_project_parent.clone();
            let title = state.t("plain.add_project.picker_title").to_owned();
            Task::future(async move {
                // Task 102: the existence check runs here, off the UI
                // thread — the decision itself (`initial_browse_dir`) stays
                // pure and is what's unit-tested.
                let exists = remembered
                    .as_deref()
                    .is_some_and(|p| std::fs::metadata(p).is_ok_and(|m| m.is_dir()));
                let start_dir = initial_browse_dir(remembered.as_deref(), exists);

                let mut dialog = rfd::AsyncFileDialog::new().set_title(title);
                if let Some(dir) = start_dir {
                    dialog = dialog.set_directory(dir);
                }
                let folder = dialog.pick_folder().await;
                let path = folder.map(|f| f.path().to_string_lossy().into_owned());
                Message::Workspace(crate::message::WorkspaceMessage::BrowsePathSelected(path))
            })
        }
        WorkspaceMessage::BrowsePathSelected(path_opt) => {
            if let Some(path) = path_opt
                && let Some(d) = &mut state.add_project_dialog
            {
                // Auto-fill name from folder name if not already set.
                if d.name.is_empty()
                    && let Some(name) = std::path::Path::new(&path)
                        .file_name()
                        .and_then(|n| n.to_str())
                {
                    d.name = name.to_owned();
                }
                d.path = path;
                d.error = None;
                // Auto-advance to step 2 once a folder is chosen.
                d.step = crate::state::AddProjectStep::NameProject;
            }
            Task::none()
        }
        WorkspaceMessage::RemoveProjectRequested(id) => {
            let name = state
                .workspace
                .as_ref()
                .and_then(|ws| ws.projects.iter().find(|p| p.id == id))
                .map(|p| p.name.clone())
                .unwrap_or_default();
            state.confirm_remove_dialog = Some(ConfirmRemoveDialog {
                project_id: id,
                project_name: name,
            });
            Task::none()
        }
        WorkspaceMessage::RemoveProjectConfirmed(id) => {
            state.confirm_remove_dialog = None;
            // Capture snapshots before removing so undo can restore exactly.
            let removed_project = state
                .workspace
                .as_ref()
                .and_then(|ws| ws.projects.iter().find(|p| p.id == id).cloned());
            let removed_status = state
                .workspace_status
                .as_ref()
                .and_then(|ws| ws.projects.iter().find(|s| s.project_id == id).cloned());

            let paths = state.paths.clone();
            if let Some(ws) = &mut state.workspace {
                ws.remove_project(&id);
                persist_workspace(&paths, ws);
            }
            if let Some(ws_status) = &mut state.workspace_status {
                ws_status.projects.retain(|s| s.project_id != id);
            }
            state.fetching_projects.remove(&id);
            state.reconcile_selection_with_display();
            if state.selection.selected_ids.is_empty() {
                state.selection_mode = false;
            }

            // Store undo opportunity. Cleared by next user action or explicit dismiss.
            if let Some(project) = removed_project {
                state.recent_removal = Some(crate::state::UndoableRemoval {
                    project,
                    status_snapshot: removed_status,
                });
            }
            shared::scan_topology_task(state)
        }
        WorkspaceMessage::RemoveProjectCancelled => {
            state.confirm_remove_dialog = None;
            Task::none()
        }
        WorkspaceMessage::UndoRemoval => {
            if let Some(removal) = state.recent_removal.take() {
                let paths = state.paths.clone();
                if let Some(ws) = &mut state.workspace {
                    ws.projects.push(removal.project);
                    persist_workspace(&paths, ws);
                }
                if let Some(ws_status) = &mut state.workspace_status
                    && let Some(snap) = removal.status_snapshot
                {
                    ws_status.projects.push(snap);
                }
                state.reconcile_selection_with_display();
                return shared::scan_topology_task(state);
            }
            Task::none()
        }
        WorkspaceMessage::DismissUndoSnackbar => {
            state.recent_removal = None;
            Task::none()
        }

        // --- Multi-workspace management ---
        WorkspaceMessage::CreateWorkspaceDialogOpened => {
            state.workspace_mgr.switcher_open = false;
            state.workspace_mgr.create_dialog = Some(CreateWorkspaceDialog::default());
            Task::none()
        }
        WorkspaceMessage::CreateWorkspaceNameChanged(s) => {
            if let Some(d) = &mut state.workspace_mgr.create_dialog {
                d.name = s;
                d.error = None;
            }
            Task::none()
        }
        WorkspaceMessage::CreateWorkspaceConfirmed => {
            let raw_name = state
                .workspace_mgr
                .create_dialog
                .as_ref()
                .map(|d| d.name.clone())
                .unwrap_or_default();

            let name = match validate_workspace_name(&raw_name, &state.all_workspaces, None) {
                Ok(name) => name,
                Err(err) => {
                    let msg = state.t(err.i18n_key()).to_owned();
                    if let Some(d) = &mut state.workspace_mgr.create_dialog {
                        d.error = Some(msg);
                    }
                    return Task::none();
                }
            };

            let ws = knotra_vcs::Workspace::new(name);
            if let Err(e) = save_workspace(&ws, &state.paths) {
                let msg = format!("{} {e}", state.t("workspace.error.save_failed"));
                if let Some(d) = &mut state.workspace_mgr.create_dialog {
                    d.error = Some(msg);
                }
                return Task::none();
            }

            state.all_workspaces.push(ws);
            state.active_workspace_idx = state.all_workspaces.len().saturating_sub(1);
            state.workspace = state.all_workspaces.last().cloned();
            state.clear_selection_mode();
            state.workspace_status = None;
            state.load_phase = LoadPhase::Refreshing;
            state.is_refreshing = true;
            state.workspace_mgr.create_dialog = None;
            Task::batch([
                shared::refresh_workspace_task(state),
                shared::scan_topology_task(state),
            ])
        }
        WorkspaceMessage::CreateWorkspaceCancelled => {
            state.workspace_mgr.create_dialog = None;
            Task::none()
        }

        WorkspaceMessage::RenameWorkspaceDialogOpened => {
            state.workspace_mgr.switcher_open = false;
            if let Some(id) = state.workspace.as_ref().map(|ws| ws.id.clone()) {
                open_rename_dialog(state, id);
            }
            Task::none()
        }
        // RFC-073 D4: Settings' "Workspaces" section opens the same
        // dialog for any listed workspace, not only the active one.
        WorkspaceMessage::RenameWorkspaceDialogOpenedFor(id) => {
            open_rename_dialog(state, id);
            Task::none()
        }
        WorkspaceMessage::RenameWorkspaceNameChanged(s) => {
            if let Some(d) = &mut state.workspace_mgr.rename_dialog {
                d.new_name = s;
                d.error = None;
            }
            Task::none()
        }
        WorkspaceMessage::RenameWorkspaceConfirmed => {
            let Some(dialog) = state.workspace_mgr.rename_dialog.clone() else {
                return Task::none();
            };

            let name = match validate_workspace_name(
                &dialog.new_name,
                &state.all_workspaces,
                Some(&dialog.workspace_id),
            ) {
                Ok(name) => name,
                Err(err) => {
                    let msg = state.t(err.i18n_key()).to_owned();
                    if let Some(d) = &mut state.workspace_mgr.rename_dialog {
                        d.error = Some(msg);
                    }
                    return Task::none();
                }
            };

            let Some(idx) = state
                .all_workspaces
                .iter()
                .position(|ws| ws.id == dialog.workspace_id)
            else {
                return Task::none();
            };
            let mut renamed = state.all_workspaces[idx].clone();
            renamed.name = name;
            if let Err(e) = save_workspace(&renamed, &state.paths) {
                let msg = format!("{} {e}", state.t("workspace.error.save_failed"));
                if let Some(d) = &mut state.workspace_mgr.rename_dialog {
                    d.error = Some(msg);
                }
                return Task::none();
            }

            if state.workspace.as_ref().map(|ws| &ws.id) == Some(&renamed.id) {
                state.workspace = Some(renamed.clone());
            }
            state.all_workspaces[idx] = renamed;
            state.workspace_mgr.rename_dialog = None;
            Task::none()
        }
        WorkspaceMessage::RenameWorkspaceCancelled => {
            state.workspace_mgr.rename_dialog = None;
            Task::none()
        }

        WorkspaceMessage::DeleteWorkspaceRequested => {
            if let Some(id) = state.workspace.as_ref().map(|ws| ws.id.clone()) {
                open_delete_dialog(state, id);
            }
            Task::none()
        }
        // RFC-073 D4: Settings' "Workspaces" section opens the same
        // confirmation for any listed workspace, not only the active one.
        WorkspaceMessage::DeleteWorkspaceRequestedFor(id) => {
            open_delete_dialog(state, id);
            Task::none()
        }
        WorkspaceMessage::DeleteWorkspaceConfirmed => {
            if state.all_workspaces.len() <= 1 {
                let msg = state.t("workspace.delete.disabled_last").to_owned();
                if let Some(d) = &mut state.workspace_mgr.confirm_delete {
                    d.error = Some(msg);
                }
                return Task::none();
            }

            let delete_id = state
                .workspace_mgr
                .confirm_delete
                .as_ref()
                .map(|d| d.workspace_id.clone());
            let deleted_idx = delete_id
                .as_ref()
                .and_then(|id| state.all_workspaces.iter().position(|ws| &ws.id == id))
                .unwrap_or(state.active_workspace_idx);
            let Some(deleted_ws) = state.all_workspaces.get(deleted_idx).cloned() else {
                return Task::none();
            };

            if let Err(e) = delete_workspace_file(&deleted_ws, &state.paths) {
                let msg = format!("{} {e}", state.t("workspace.error.delete_failed"));
                if let Some(d) = &mut state.workspace_mgr.confirm_delete {
                    d.error = Some(msg);
                }
                return Task::none();
            }

            state.all_workspaces.remove(deleted_idx);
            state.active_workspace_idx =
                next_active_index_after_delete(deleted_idx, state.all_workspaces.len() + 1);
            state.workspace = state
                .all_workspaces
                .get(state.active_workspace_idx)
                .cloned();
            state.clear_selection_mode();
            state.workspace_status = None;
            let active_ids: Vec<knotra_vcs::ProjectId> = state
                .workspace
                .as_ref()
                .map(|ws| ws.projects.iter().map(|p| p.id.clone()).collect())
                .unwrap_or_default();
            state.fs_poller.prune(&active_ids);
            state.load_phase = LoadPhase::Refreshing;
            state.is_refreshing = true;
            state.workspace_mgr.confirm_delete = None;
            Task::batch([
                shared::refresh_workspace_task(state),
                shared::scan_topology_task(state),
            ])
        }
        WorkspaceMessage::DeleteWorkspaceCancelled => {
            state.workspace_mgr.confirm_delete = None;
            Task::none()
        }

        WorkspaceMessage::SwitcherToggled => {
            state.workspace_mgr.switcher_open = !state.workspace_mgr.switcher_open;
            Task::none()
        }
        WorkspaceMessage::WorkspaceSwitched(id) => {
            state.workspace_mgr.switcher_open = false;
            if let Some(idx) = state.all_workspaces.iter().position(|ws| ws.id == id) {
                shared::clear_sync_retry_context(state);
                state.active_workspace_idx = idx;
                state.workspace = state.all_workspaces.get(idx).cloned();
                state.clear_selection_mode();
                // Prune stale FsPoller snapshots from the previous workspace.
                let active_ids: Vec<knotra_vcs::ProjectId> = state
                    .workspace
                    .as_ref()
                    .map(|ws| ws.projects.iter().map(|p| p.id.clone()).collect())
                    .unwrap_or_default();
                state.fs_poller.prune(&active_ids);
                state.workspace_status = None;
                state.load_phase = LoadPhase::Refreshing;
                state.is_refreshing = true;
                return Task::batch([
                    shared::refresh_workspace_task(state),
                    shared::scan_topology_task(state),
                ]);
            }
            Task::none()
        }
    }
}

#[cfg(test)]
mod tests {
    use super::initial_browse_dir;
    use std::path::Path;

    #[test]
    fn none_remembered_starts_nowhere() {
        assert_eq!(initial_browse_dir(None, false), None);
    }

    #[test]
    fn remembered_but_gone_starts_nowhere() {
        let p = Path::new("/tmp/knotra-demo-102/repos");
        assert_eq!(initial_browse_dir(Some(p), false), None);
    }

    #[test]
    fn remembered_and_present_starts_there() {
        let p = Path::new("/tmp/knotra-demo-102/repos");
        assert_eq!(initial_browse_dir(Some(p), true), Some(p));
    }
}