knave 0.14.22

A Lisp programming language for humans and agents that infers types and ownership and compiles to readable Rust
Documentation 
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131

use rustc_hash::FxHashMap;

use super::problems::OwnershipProblems;
use crate::core::{BindingId, ReferenceKind};
use crate::diagnostic::{Diagnostic, Diagnostics};
use crate::types::{
    FieldPlace, Type, TypedArgument, TypedExpr, TypedExprKind, TypedLeaf, TypedProgram,
};

struct ChangedArgument<'e> {
    argument: &'e TypedExpr,
    place: &'e TypedExpr,
}

pub struct AliasedChanges<'a> {
    program: &'a TypedProgram,
    function_params: &'a FxHashMap<BindingId, Vec<Type>>,
}

impl<'a> AliasedChanges<'a> {
    pub fn new(
        program: &'a TypedProgram,
        function_params: &'a FxHashMap<BindingId, Vec<Type>>,
    ) -> Self {
        Self {
            program,
            function_params,
        }
    }

    pub fn check(&self) -> Diagnostics {
        let mut diagnostics = Diagnostics::default();
        for definition in self
            .program
            .modules
            .iter()
            .flat_map(|module| &module.definitions)
        {
            self.visit(&definition.value, &mut diagnostics);
        }
        diagnostics
    }

    fn visit(&self, expr: &TypedExpr, diagnostics: &mut Diagnostics) {
        if let TypedExprKind::Call(callee, arguments) = &expr.kind {
            self.call(callee, arguments, diagnostics);
        }
        for child in expr.children() {
            self.visit(child, diagnostics);
        }
    }

    fn call(&self, callee: &TypedExpr, arguments: &[TypedArgument], diagnostics: &mut Diagnostics) {
        let params = self.callee_params(callee);
        let changed: Vec<ChangedArgument> = arguments
            .iter()
            .enumerate()
            .filter_map(|(position, argument)| {
                Self::changed_place(argument, params.get(position)).map(|place| ChangedArgument {
                    argument: &argument.value,
                    place,
                })
            })
            .collect();
        for (later, second) in changed.iter().enumerate() {
            if let Some(first) = changed[..later]
                .iter()
                .find(|first| Self::overlap(first.place, second.place))
            {
                diagnostics.push(self.aliased_change(first, second));
            }
        }
    }

    fn aliased_change(&self, first: &ChangedArgument, second: &ChangedArgument) -> Diagnostic {
        let places = [first, second].map(|changed| {
            changed
                .place
                .field_place()
                .expect("a changed argument is a place")
        });
        let outer = places
            .iter()
            .min_by_key(|place| place.path.len())
            .expect("two places");
        OwnershipProblems::aliased_change(
            &outer.written(&self.program.bindings),
            first.argument.span,
            second.argument.span,
        )
    }

    fn callee_params(&self, callee: &TypedExpr) -> Vec<Type> {
        let declared = match callee.kind {
            TypedExprKind::Leaf(TypedLeaf::Global(function)) => self.function_params.get(&function),
            _ => None,
        };
        match (declared, &callee.ty) {
            (Some(params), _) => params.clone(),
            (None, Type::Function(_, params, _)) => params.clone(),
            _ => Vec::new(),
        }
    }

    fn changed_place<'e>(
        argument: &'e TypedArgument,
        param: Option<&Type>,
    ) -> Option<&'e TypedExpr> {
        let place: &TypedExpr = match (&argument.value.kind, param) {
            (TypedExprKind::Borrow(ReferenceKind::Mutable, place), _) => place,
            (_, Some(Type::Mut(..))) => &argument.value,
            _ => return None,
        };
        place.is_place().then_some(place)
    }

    fn overlap(first: &TypedExpr, second: &TypedExpr) -> bool {
        let (Some(first), Some(second)) = (first.field_place(), second.field_place()) else {
            return false;
        };
        first.root == second.root && Self::nested(&first, &second)
    }

    fn nested(first: &FieldPlace, second: &FieldPlace) -> bool {
        first
            .path
            .iter()
            .zip(&second.path)
            .all(|(left, right)| left.name == right.name)
    }
}