kingfisher-rules 1.0.0

Rule definitions and database for Kingfisher secret scanner
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
//! Betterleaks- and Veles-derived default rules embedded in the kingfisher-rules crate.

use std::{io::Read, path::PathBuf, sync::OnceLock};

use anyhow::{Context, Result, anyhow, bail};
use flate2::read::GzDecoder;

use crate::rule::Confidence;
use crate::rules::Rules;

/// Source revisions, input hashes, and rule provenance for the embedded catalog.
pub const BUILTIN_RULE_PROVENANCE: &str = include_str!("../generated/provenance.json");

const BUNDLE_MAGIC: &[u8] = b"KFRULES\x01";
const DEFAULT_RULE_BUNDLE: &[u8] = include_bytes!("../generated/builtin-rules.gz");
type BuiltinRuleFiles = Vec<(PathBuf, Vec<u8>)>;
type CachedBuiltinRuleFiles = Result<BuiltinRuleFiles, String>;

static BUILTIN_RULE_FILES: OnceLock<CachedBuiltinRuleFiles> = OnceLock::new();

/// Return the generated snapshot entries containing the embedded built-in rules.
///
/// The returned paths are relative to the bundled rules directory.
pub fn get_builtin_rule_files() -> Result<Vec<(PathBuf, Vec<u8>)>> {
    Ok(builtin_rule_files()?.to_vec())
}

fn builtin_rule_files() -> Result<&'static [(PathBuf, Vec<u8>)]> {
    BUILTIN_RULE_FILES
        .get_or_init(|| load_rule_files(DEFAULT_RULE_BUNDLE).map_err(|err| format!("{err:#}")))
        .as_deref()
        .map_err(|err| anyhow!("failed to load embedded builtin rules: {err}"))
}

/// Compatibility alias for [`get_builtin_rule_files`].
pub fn get_betterleaks_rule_files() -> Result<Vec<(PathBuf, Vec<u8>)>> {
    get_builtin_rule_files()
}

fn load_rule_files(bundle: &[u8]) -> Result<BuiltinRuleFiles> {
    let mut decoded = Vec::new();
    GzDecoder::new(bundle)
        .read_to_end(&mut decoded)
        .context("failed to decompress embedded rule bundle")?;

    let mut cursor = BundleCursor::new(&decoded);
    if cursor.take(BUNDLE_MAGIC.len())? != BUNDLE_MAGIC {
        bail!("embedded rule bundle has an invalid header");
    }

    let mut files = Vec::new();
    loop {
        let path_len = usize::try_from(cursor.u32()?)
            .map_err(|_| anyhow!("embedded rule path length exceeds platform limits"))?;
        if path_len == 0 {
            break;
        }
        let contents_len = usize::try_from(cursor.u64()?)
            .map_err(|_| anyhow!("embedded rule contents length exceeds platform limits"))?;
        let path = std::str::from_utf8(cursor.take(path_len)?)
            .context("embedded rule bundle contains a non-UTF-8 path")?;
        files.push((PathBuf::from(path), cursor.take(contents_len)?.to_vec()));
    }
    if !cursor.is_empty() {
        bail!("embedded rule bundle has trailing data");
    }
    Ok(files)
}

/// Load Kingfisher's built-in Betterleaks and Veles rules.
///
/// This loads all rules that meet or exceed the given confidence level.
/// If no confidence is specified, defaults to `Confidence::Medium`.
pub fn get_builtin_rules(confidence: Option<Confidence>) -> Result<Rules> {
    let confidence = confidence.unwrap_or(Confidence::Medium);
    let files = builtin_rule_files()?;
    Rules::from_paths_and_contents(
        files.iter().map(|(path, contents)| (path.as_path(), contents.as_slice())),
        confidence,
    )
}

/// Compatibility alias for [`get_builtin_rules`].
pub fn get_betterleaks_rules(confidence: Option<Confidence>) -> Result<Rules> {
    get_builtin_rules(confidence)
}

struct BundleCursor<'a> {
    remaining: &'a [u8],
}

impl<'a> BundleCursor<'a> {
    fn new(contents: &'a [u8]) -> Self {
        Self { remaining: contents }
    }

    fn is_empty(&self) -> bool {
        self.remaining.is_empty()
    }

    fn take(&mut self, length: usize) -> Result<&'a [u8]> {
        if self.remaining.len() < length {
            bail!("embedded rule bundle is truncated");
        }
        let (result, remaining) = self.remaining.split_at(length);
        self.remaining = remaining;
        Ok(result)
    }

    fn u32(&mut self) -> Result<u32> {
        let bytes: [u8; 4] = self.take(4)?.try_into().expect("slice length is checked");
        Ok(u32::from_le_bytes(bytes))
    }

    fn u64(&mut self) -> Result<u64> {
        let bytes: [u8; 8] = self.take(8)?.try_into().expect("slice length is checked");
        Ok(u64::from_le_bytes(bytes))
    }
}

#[cfg(test)]
mod test {
    use super::*;
    use crate::{
        BetterleaksAccessMapHandler, EthereumValidation, Revocation, TlsMode, Validation,
        betterleaks_filter::{BetterleaksFilterContext, evaluate_filter},
    };

    fn filter_discards(
        rule: &crate::RuleSyntax,
        path: &str,
        secret: &str,
        full_match: &str,
        captures: &[(&str, &str)],
    ) -> bool {
        evaluate_filter(
            rule.betterleaks_filter.as_ref().expect("rule should have a filter"),
            &BetterleaksFilterContext {
                path,
                secret,
                full_match,
                line: full_match,
                fragment_raw: full_match,
                match_start_idx: 0,
                match_end_idx: full_match.len(),
                match_line_start_idx: 0,
                match_line_end_idx: full_match.len(),
                rule_id: &rule.id,
                description: &rule.name,
                captures: captures
                    .iter()
                    .map(|(name, value)| ((*name).to_string(), (*value).to_string()))
                    .collect(),
            },
        )
        .unwrap()
        .discard
    }

    #[test]
    fn placeholder_private_keys_and_mongodb_passwords_are_filtered() {
        let rules = get_builtin_rules(Some(Confidence::Low)).unwrap();
        let key_rule = &rules.rules["betterleaks.private-key"];
        for body in [
            "",
            "\nPRIVATE_KEY\n",
            r#"\n"
              + "PRIVATE_KEY\n"
              + ""#,
            "\nYWJjZA==\n",
        ] {
            let pem = format!("-----BEGIN PRIVATE KEY-----{body}-----END PRIVATE KEY-----");
            assert!(filter_discards(key_rule, "fixture.java", &pem, &pem, &[]), "{pem}");
        }
        // A compact, synthetic Ed25519 PKCS#8 key must survive the length gate.
        let body = "MC4CAQAwBQYDK2VwBCIEIAECAwQFBgcICQoLDA0ODxAREhMUFRYXGBkaGxwdHh8g";
        for body in [
            body.to_string(),
            body.as_bytes()
                .chunks(16)
                .map(|chunk| std::str::from_utf8(chunk).unwrap())
                .collect::<Vec<_>>()
                .join("\n"),
        ] {
            let pem = format!("-----BEGIN PRIVATE KEY-----\n{body}\n-----END PRIVATE KEY-----");
            assert!(!filter_discards(key_rule, "fixture.pem", &pem, &pem, &[]), "{pem}");
        }
        let mongo = &rules.rules["betterleaks.mongodb-connection-string"];
        for password in [
            "$(AWS_SECRET_ACCESS_KEY)",
            "$(MONGODB_PASSWORD)",
            "${MONGODB_PASSWORD}",
            "$MONGODB_PASSWORD",
            "{{ MONGODB_PASSWORD }}",
        ] {
            let uri = format!("mongodb+srv://$(MONGODB_USERNAME):{password}@cluster.invalid/db");
            assert!(filter_discards(mongo, "fixture.yml", &uri, &uri, &[]), "{uri}");
        }
        for uri in [
            "mongodb://$(MONGODB_USERNAME):r4nd0mLiteralSecret@cluster.invalid/db",
            "mongodb://alice:r4nd0mLiteralSecret@$(MONGODB_HOST)/db",
            "mongodb://alice:literal$(suffix)@cluster.invalid/db",
            "mongodb://alice:dollar%24literal@cluster.invalid/db",
        ] {
            assert!(!filter_discards(mongo, "fixture.yml", uri, uri, &[]), "{uri}");
        }
        // Compile both overlay regexes with the production Vectorscan filter engine.
        let mut selected = Rules::new();
        for rule in [key_rule, mongo] {
            selected.rules.insert(rule.id.clone(), rule.clone());
        }
        crate::RulesDatabase::from_rule_collection(selected).unwrap();
    }

    #[test]
    fn bare_provider_rules_detect_extracted_tokens_and_compile() {
        let rules = get_builtin_rules(Some(Confidence::Low)).unwrap();
        let cases = [
            ("deepseek-api-key", format!("sk-{}", "0123456789abcdef".repeat(2))),
            ("kimi-api-key", format!("sk-{}", "AbcD0123_-xy".repeat(4))),
            ("zai-api-key", format!("{}.AbcD0123efGH4567", "0123456789abcdef".repeat(2))),
            ("voyageai-api-key", format!("pa-{}QrstUv9", "AbcD0123_-xy".repeat(3))),
        ];
        let mut selected = Rules::new();
        for (id, token) in &cases {
            let rule = &rules.rules[&format!("betterleaks.{id}")];
            let regex =
                regex::bytes::RegexBuilder::new(&rule.pattern).unicode(false).build().unwrap();
            for input in
                [token.clone(), format!("VAR_0000 = \"{token}\""), format!("{token} # provider")]
            {
                let captures =
                    regex.captures(input.as_bytes()).unwrap_or_else(|| panic!("{id}: {input}"));
                assert_eq!(captures.get(1).unwrap().as_bytes(), token.as_bytes());
            }
            for input in [
                format!("x{token}"),
                format!("_{token}"),
                format!("-{token}"),
                format!("{token}x"),
                format!("{token}_"),
            ] {
                assert!(!regex.is_match(input.as_bytes()), "{id}: {input}");
            }
            assert!(matches!(rule.validation, Some(Validation::Betterleaks(_))));
            assert!(!filter_discards(rule, "fixture.txt", token, token, &[]), "{id}");
            selected.rules.insert(rule.id.clone(), rule.clone());
        }
        let db = crate::RulesDatabase::from_rule_collection(selected).unwrap();
        let mut scanner = kingfisher_vectorscan::BlockScanner::new(db.vectorscan_db()).unwrap();
        for (id, token) in cases {
            let input = format!("{token}\n{token}");
            let mut hits = 0;
            scanner
                .scan(input.as_bytes(), |index, from, to, _flags| {
                    if db.get_rule(index as usize).unwrap().id() == format!("betterleaks.{id}") {
                        let candidate = &input.as_bytes()[from as usize..to as usize];
                        let captures =
                            db.anchored_regexes()[index as usize].captures(candidate).unwrap();
                        assert_eq!(captures.get(1).unwrap().as_bytes(), token.as_bytes());
                        hits += 1;
                    }
                    kingfisher_vectorscan::Scan::Continue
                })
                .unwrap();
            assert!(hits >= 2, "{id}: missing adjacent bare tokens");
        }
    }

    #[test]
    fn test_get_default_rules() {
        assert!(get_builtin_rules(None).unwrap().num_rules() >= 400);
    }

    #[test]
    fn bundled_rule_files_are_sorted_and_complete() {
        let files = get_builtin_rule_files().unwrap();
        assert_eq!(files.len(), 2);
        assert!(files.windows(2).all(|pair| pair[0].0 <= pair[1].0));
    }

    #[test]
    fn readable_files_load_identically_to_embedded_catalog() {
        let manifest: serde_json::Value = serde_json::from_str(BUILTIN_RULE_PROVENANCE).unwrap();
        let root = std::path::Path::new(env!("CARGO_MANIFEST_DIR")).join("generated");
        let paths: std::collections::BTreeSet<_> = manifest["rules"]
            .as_object()
            .unwrap()
            .values()
            .map(|record| root.join(record["generated_file"].as_str().unwrap()))
            .collect();
        assert_eq!(
            paths,
            [root.join("rules/betterleaks.yml"), root.join("rules/veles.yml")]
                .into_iter()
                .collect()
        );
        let exported = Rules::from_yaml_files(paths, Confidence::Low).unwrap();
        let embedded = get_builtin_rules(Some(Confidence::Low)).unwrap();
        assert_eq!(
            serde_json::to_value(&exported.rules).unwrap(),
            serde_json::to_value(&embedded.rules).unwrap()
        );
        assert_eq!(
            serde_json::to_value(&exported.betterleaks_prefilter).unwrap(),
            serde_json::to_value(&embedded.betterleaks_prefilter).unwrap()
        );
    }

    #[test]
    fn builtin_rule_files_are_cached() {
        assert!(std::ptr::eq(builtin_rule_files().unwrap(), builtin_rule_files().unwrap()));
    }

    #[test]
    fn default_rules_are_namespaced_upstream_rules() {
        let rules = get_builtin_rules(Some(Confidence::Low)).unwrap();

        assert!(rules.num_rules() >= 400);
        // `kingfisher.` is permitted because the 1.x catalog is still loadable via
        // `--rules-path`, and callers may merge it with the built-ins. The built-in
        // bundle itself only ships `betterleaks.`/`veles.` rules today.
        assert!(rules.rules.keys().all(|id| {
            id.starts_with("betterleaks.")
                || id.starts_with("veles.")
                || id.starts_with("kingfisher.")
        }));
        for rule in rules.rules.values() {
            for dependency in rule.depends_on_rule.iter().flatten() {
                assert!(
                    rules.rules.contains_key(&dependency.rule_id),
                    "{} depends on missing Betterleaks rule {}",
                    rule.id,
                    dependency.rule_id
                );
            }
        }

        let app_config = rules
            .rules
            .get("betterleaks.azure-app-configuration-connection-string")
            .expect("generated Betterleaks rule should exist");
        let regex = app_config.as_regex().unwrap();
        let captures = regex
            .captures(
                b"Endpoint=https://demo.azconfig.io;Id=abcde;Secret=ABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789",
            )
            .expect("generated Betterleaks rule should match");
        assert_eq!(
            captures.get(app_config.betterleaks_secret_group.unwrap()).unwrap().as_bytes(),
            b"ABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789"
        );

        assert!(rules.betterleaks_prefilter.is_some());
        assert!(
            rules.rules["betterleaks.browserstack-access-key.1"]
                .depends_on_rule
                .iter()
                .flatten()
                .any(|dep| dep.variable == "BROWSERSTACK_USERNAME_1" && dep.verify_candidates)
        );
        assert!(
            rules.rules["betterleaks.clickhouse-cloud-api-secret-key"]
                .depends_on_rule
                .iter()
                .flatten()
                .any(|dep| dep.variable == "CLICKHOUSE_CLOUD_KEY_ID" && dep.verify_candidates)
        );
        assert!(
            rules.rules["betterleaks.mongodb-atlas-service-account-secret"]
                .depends_on_rule
                .iter()
                .flatten()
                .any(|dep| dep.variable == "MONGODB_ATLAS_SERVICE_ACCOUNT_ID"
                    && dep.verify_candidates)
        );
        assert!(
            rules.rules["betterleaks.planetscale-api-token"]
                .depends_on_rule
                .iter()
                .flatten()
                .any(|dep| dep.variable == "PLANETSCALE_ID" && dep.verify_candidates)
        );
        assert!(
            rules.rules["betterleaks.razorpay-key-secret.1"]
                .depends_on_rule
                .iter()
                .flatten()
                .any(|dep| dep.variable == "RAZORPAY_KEY_ID_1" && dep.verify_candidates)
        );
        assert!(
            rules.rules["betterleaks.wiz-client-secret.1"]
                .depends_on_rule
                .iter()
                .flatten()
                .any(|dep| dep.variable == "WIZ_CLIENT_ID_1" && dep.verify_candidates)
        );

        let aws = rules.rules.get("betterleaks.aws-access-token").unwrap();
        assert!(
            aws.depends_on_rule
                .iter()
                .flatten()
                .any(|dep| dep.variable == "AWS_SECRET_ACCESS_KEY" && dep.verify_candidates)
        );
        assert!(matches!(aws.revocation, Some(Revocation::AWS)));
        let Some(Validation::Betterleaks(aws_validation)) = &aws.validation else {
            panic!("AWS should use Betterleaks validation");
        };
        assert_eq!(
            aws_validation.capabilities.access_map.as_ref().unwrap().handler,
            BetterleaksAccessMapHandler::Aws
        );
        let bindings = aws_validation.capabilities.revocation_bindings.as_ref().unwrap();
        assert_eq!(bindings.secret, "components.aws-secret-access-key");
        assert_eq!(bindings.variables["AKID"], "finding.secret");

        let session = rules
            .rules
            .get("betterleaks.aws-session-token")
            .expect("AWS session-token compatibility rule should exist");
        assert_eq!(session.name, "AWS Session Token");
        assert!(session.depends_on_rule.iter().flatten().all(|dep| dep.verify_candidates));
        assert!(matches!(session.validation, Some(Validation::AWS)));
        let session_regex = session.as_regex().unwrap();
        let session_captures = session_regex
            .captures(br#""AWS_SESSION_TOKEN": "Ab9xQ7mN2kLp4RsT""#)
            .expect("AWS session-token rule should match a quoted structured key");
        assert_eq!(session_captures.get(1).unwrap().as_bytes(), b"Ab9xQ7mN2kLp4RsT");
        assert_eq!(
            session
                .depends_on_rule
                .iter()
                .flatten()
                .map(|dependency| (dependency.rule_id.as_str(), dependency.variable.as_str()))
                .collect::<Vec<_>>(),
            vec![
                ("betterleaks.aws-access-token", "AKID"),
                ("betterleaks.aws-secret-access-key", "AWS_SECRET_ACCESS_KEY"),
            ]
        );

        for (id, handler) in [
            ("betterleaks.auth0-client-secret.1", BetterleaksAccessMapHandler::Auth0),
            ("betterleaks.monday-api-token.1", BetterleaksAccessMapHandler::Monday),
            ("betterleaks.paypal-client-secret.1", BetterleaksAccessMapHandler::Paypal),
        ] {
            let rule = rules.rules.get(id).expect("generated Betterleaks rule should exist");
            let Some(Validation::Betterleaks(validation)) = &rule.validation else {
                panic!("{id} should use Betterleaks validation");
            };
            let mapping = validation
                .capabilities
                .access_map
                .as_ref()
                .unwrap_or_else(|| panic!("{id} should have access-map capabilities"));
            assert_eq!(mapping.handler, handler);
        }

        let auth0 = rules.rules["betterleaks.auth0-client-secret.1"]
            .validation
            .as_ref()
            .and_then(|validation| match validation {
                Validation::Betterleaks(validation) => validation.capabilities.access_map.as_ref(),
                _ => None,
            })
            .expect("Auth0 access-map capabilities should exist");
        assert_eq!(auth0.inputs["client_id"], "components.auth0-client-id.1");
        assert_eq!(auth0.inputs["domain"], "components.auth0-domain.1");

        let paypal = rules.rules["betterleaks.paypal-client-secret.1"]
            .validation
            .as_ref()
            .and_then(|validation| match validation {
                Validation::Betterleaks(validation) => validation.capabilities.access_map.as_ref(),
                _ => None,
            })
            .expect("PayPal access-map capabilities should exist");
        assert_eq!(paypal.inputs["client_id"], "components.paypal-client-id.1");

        let google_api_key = rules.rules.get("betterleaks.gcp-api-key").unwrap();
        let Some(Validation::Betterleaks(google_api_key_validation)) = &google_api_key.validation
        else {
            panic!("Google API key should use Betterleaks validation");
        };
        assert_eq!(
            google_api_key_validation.capabilities.access_map.as_ref().unwrap().handler,
            BetterleaksAccessMapHandler::GcpApiKey
        );

        let gcp = rules.rules.get("betterleaks.gcp-service-account").unwrap();
        assert!(matches!(gcp.revocation, Some(Revocation::GCP)));

        for id in ["generic-api-key", "generic-password", "generic-username"] {
            assert!(!rules.rules.contains_key(&format!("betterleaks.{id}")), "unexpected {id}");
        }

        let mongodb = rules.rules.get("betterleaks.mongodb-connection-string").unwrap();
        assert!(matches!(mongodb.validation, Some(Validation::MongoDB)));
        // Self-managed / RDS-style clusters commonly present private-CA certs.
        // Only honored when the operator also passes `--tls-mode lax`.
        assert_eq!(mongodb.tls_mode, Some(TlsMode::Lax));

        let jwt = rules.rules.get("betterleaks.jwt").unwrap();
        assert!(matches!(jwt.validation, Some(Validation::JWT)));
        // Self-hosted IdPs commonly serve JWKS from a private CA.
        assert_eq!(jwt.tls_mode, Some(TlsMode::Lax));

        let private_key = rules.rules.get("betterleaks.private-key").unwrap();
        assert!(matches!(private_key.validation, Some(Validation::Assumed)));

        let polymarket = rules.rules.get("betterleaks.polymarket-private-key").unwrap();
        assert!(matches!(
            polymarket.validation,
            Some(Validation::Ethereum(EthereumValidation::PrivateKey))
        ));

        for id in [
            "generic-credential-uri",
            "gitlab-incoming-mail-address-token",
            "circleci-project-token",
            "cloudflare-api-key",
            "digitalocean-pat",
            "heroku-api-key-v2",
            "npm-access-token",
            "openrouter-api-key",
            "postman-api-token",
            "pypi-upload-token",
            "sendgrid-api-token",
            "slack-app-token",
            "slack-config-access-token",
            "slack-config-refresh-token",
            "xai-api-key",
        ] {
            assert!(rules.rules.contains_key(&format!("betterleaks.{id}")), "missing {id}");
        }
        assert!(rules.rules.contains_key("betterleaks.voyageai-api-key"));

        let hcp = rules.rules.get("veles.secrets/hcpclientcredentials").unwrap();
        assert!(matches!(hcp.validation, Some(Validation::Http(_))));

        for id in [
            "betterleaks.doppler-api-token",
            "betterleaks.heroku-api-key",
            "betterleaks.heroku-api-key-v2",
            "betterleaks.slack-legacy-token",
            "betterleaks.slack-user-token",
            "betterleaks.twitch-api-token",
            "betterleaks.vercel-app-access-token",
            "betterleaks.vercel-app-refresh-token",
        ] {
            assert!(rules.rules[id].revocation.is_some(), "{id} should support revocation");
        }

        for id in [
            "veles.secrets/bitbucketcredentials",
            "veles.secrets/circleciproject",
            "veles.secrets/cloudflareapitoken",
            "veles.secrets/codecatalystcredentials",
            "veles.secrets/codecommitcredentials",
            "veles.secrets/digitaloceanapikey",
            "veles.secrets/grokxaiapikey",
            "veles.secrets/herokuplatformkey",
            "veles.secrets/npmjsaccesstoken",
            "veles.secrets/openrouter",
            "veles.secrets/postmanapikey",
            "veles.secrets/postmancollectiontoken",
            "veles.secrets/sendgrid",
            "veles.secrets/slackappconfigaccesstoken",
            "veles.secrets/slackappconfigrefreshtoken",
            "veles.secrets/slackappleveltoken",
        ] {
            let rule = &rules.rules[id];
            assert!(rule.visible, "{id} should be the visible detector for its format");
            assert!(matches!(rule.validation, Some(Validation::Http(_))));
        }

        for id in [
            "veles.secrets/cloudflareapitoken",
            "veles.secrets/digitaloceanapikey",
            "veles.secrets/herokuplatformkey",
            "veles.secrets/npmjsaccesstoken",
            "veles.secrets/slackappleveltoken",
        ] {
            assert!(rules.rules[id].revocation.is_some(), "{id} should support revocation");
        }

        for id in [
            "betterleaks.cloudflare-api-key",
            "betterleaks.digitalocean-pat",
            "betterleaks.generic-credential-uri",
            "betterleaks.heroku-api-key-v2",
            "betterleaks.npm-access-token",
            "betterleaks.openrouter-api-key",
            "betterleaks.postman-api-token",
            "betterleaks.sendgrid-api-token",
            "betterleaks.slack-app-token",
            "betterleaks.slack-config-access-token",
            "betterleaks.slack-config-refresh-token",
            "betterleaks.xai-api-key",
        ] {
            assert!(
                rules.rules[id].betterleaks_filter.is_some(),
                "{id} should retain a Veles source-precedence filter"
            );
        }

        assert!(matches!(
            rules.rules["betterleaks.circleci-project-token"].validation,
            Some(Validation::Betterleaks(_))
        ));

        let npm = &rules.rules["betterleaks.npm-access-token"];
        assert!(filter_discards(
            npm,
            "config.env",
            "npm_ABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789",
            "npm_ABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789",
            &[],
        ));

        let cloudflare = &rules.rules["betterleaks.cloudflare-api-key"];
        let token = ["aB3dE5fG", "7hJ9kL2m", "N4pQ6rS8", "tU0vW1xY", "-z_C9dEf"].concat();
        assert!(filter_discards(
            cloudflare,
            "cloudflare.env",
            &token,
            &format!("CF_API_TOKEN={token}"),
            &[],
        ));
        assert!(filter_discards(
            cloudflare,
            "application.env",
            &token,
            &format!("CLOUDFLARE_API_TOKEN={token}"),
            &[],
        ));

        let uri = &rules.rules["betterleaks.generic-credential-uri"];
        assert!(matches!(uri.validation, Some(Validation::CredentialUri)));
        assert_eq!(uri.tls_mode, Some(TlsMode::Lax));
        let git_uri = "https://user:password@bitbucket.org/team/repo.git";
        let uri_captures = [("uri", git_uri), ("host", "bitbucket.org"), ("password", "password")];
        assert!(filter_discards(uri, "project/.git/config", "password", git_uri, &uri_captures,));
        assert!(!filter_discards(uri, "README.md", "password", git_uri, &uri_captures));
    }

    /// Coverage drift guard.
    ///
    /// `assert!(num_rules() >= 400)` only catches a wholesale collapse of the
    /// catalog. This asserts that every provider Kingfisher 1.x covered and that
    /// we claim to still cover is *actually* still present, so an upstream
    /// release that drops a provider fails the build instead of silently
    /// reducing detection coverage.
    ///
    /// If this fails, either the alias target needs updating for an upstream
    /// rename, or coverage genuinely regressed and the alias entry should be
    /// removed in the same change (and noted in the changelog).
    #[test]
    fn legacy_aliases_all_resolve_against_the_builtin_catalog() {
        let rules = get_builtin_rules(Some(Confidence::Low)).unwrap();
        let ids: Vec<&str> = rules.rules.keys().map(String::as_str).collect();

        let mut unresolved = Vec::new();
        for (family, selectors) in crate::legacy_aliases::legacy_aliases() {
            for selector in selectors {
                let matched = ids.iter().any(|id| {
                    *id == selector
                        || (id.starts_with(selector.as_str())
                            && matches!(id.as_bytes().get(selector.len()), Some(b'.' | b'-')))
                });
                if !matched {
                    unresolved.push(format!("{family} -> {selector}"));
                }
            }
        }

        assert!(
            unresolved.is_empty(),
            "legacy rule aliases no longer resolve against the built-in catalog \
             (upstream rename, or coverage regression):\n  {}",
            unresolved.join("\n  ")
        );
    }
}