kimun-notes 0.7.0

A terminal-based notes application
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
// tui/tests/cli_phase2_integration_test.rs
//
// Comprehensive integration tests for CLI Phase 2 functionality.
// Tests multi-workspace workflows, JSON output validation, and Phase 1 migration.

use kimun_core::nfs::VaultPath;
use kimun_core::NoteVault;
use kimun_notes::cli::{run_cli, CliCommand};
use kimun_notes::cli::commands::workspace::WorkspaceSubcommand;
use kimun_notes::cli::output::OutputFormat;
use kimun_notes::settings::AppSettings;
use tempfile::TempDir;

/// Create a temporary workspace with test notes and return both the vault and its directory.
async fn setup_test_workspace(name: &str, dir: &TempDir) -> NoteVault {
    let vault = NoteVault::new(dir.path()).await.expect("failed to create vault");
    vault.validate_and_init().await.expect("failed to init vault");

    // Create test notes specific to this workspace
    vault
        .create_note(
            &VaultPath::note_path_from(&format!("{}-project", name)),
            &format!("# {} Project\n\n#programming #{}\n\nThis is the {} project note.", name, name, name),
        )
        .await
        .expect("failed to create project note");

    vault
        .create_note(
            &VaultPath::note_path_from(&format!("journal/{}-daily", name)),
            &format!("# {} Daily Journal\n\n## Today\n\nDaily activities for {}.", name, name),
        )
        .await
        .expect("failed to create journal note");

    vault
        .create_note(
            &VaultPath::note_path_from(&format!("notes/{}-research", name)),
            &format!("# {} Research\n\n[[{}-project]]\n\nResearch notes for {}.", name, name, name),
        )
        .await
        .expect("failed to create research note");

    vault.recreate_index().await.expect("failed to recreate index");
    vault
}


/// Write a Phase 1 legacy config file (for migration testing).
fn write_phase1_config(config_path: &std::path::Path, workspace: &std::path::Path) {
    let toml = format!(
        "workspace_dir = {:?}\n",
        workspace.to_string_lossy().as_ref()
    );
    std::fs::write(config_path, toml).expect("failed to write config file");
}

// ---------------------------------------------------------------------------
// test_multi_workspace_init_and_switch
// ---------------------------------------------------------------------------

#[tokio::test]
async fn test_multi_workspace_init_and_switch() {
    let config_dir = TempDir::new().unwrap();
    let config_path = config_dir.path().join("config.toml");

    let workspace1_dir = TempDir::new().unwrap();
    let workspace2_dir = TempDir::new().unwrap();

    // Initialize first workspace
    let result = run_cli(
        CliCommand::Workspace {
            subcommand: WorkspaceSubcommand::Init {
                name: Some("work".to_string()),
                path: workspace1_dir.path().to_path_buf(),
            },
        },
        Some(config_path.clone()),
    )
    .await;
    assert!(result.is_ok(), "workspace init should succeed: {:?}", result);

    // Initialize second workspace
    let result = run_cli(
        CliCommand::Workspace {
            subcommand: WorkspaceSubcommand::Init {
                name: Some("personal".to_string()),
                path: workspace2_dir.path().to_path_buf(),
            },
        },
        Some(config_path.clone()),
    )
    .await;
    assert!(result.is_ok(), "second workspace init should succeed: {:?}", result);

    // Verify config file has both workspaces
    let settings = AppSettings::load_from_file(config_path.clone()).expect("should load settings");
    let ws_config = settings.workspace_config.as_ref().expect("should have workspace config");

    assert_eq!(ws_config.workspaces.len(), 2, "should have 2 workspaces");
    assert!(ws_config.workspaces.contains_key("work"), "should have work workspace");
    assert!(ws_config.workspaces.contains_key("personal"), "should have personal workspace");

    // Switch to personal workspace
    let result = run_cli(
        CliCommand::Workspace {
            subcommand: WorkspaceSubcommand::Use {
                name: "personal".to_string(),
            },
        },
        Some(config_path.clone()),
    )
    .await;
    assert!(result.is_ok(), "workspace switch should succeed: {:?}", result);

    // Verify current workspace changed
    let settings = AppSettings::load_from_file(config_path.clone()).expect("should load settings");
    let ws_config = settings.workspace_config.as_ref().expect("should have workspace config");
    assert_eq!(ws_config.global.current_workspace, "personal", "should switch to personal workspace");
}

// ---------------------------------------------------------------------------
// test_workspace_isolation
// ---------------------------------------------------------------------------

#[tokio::test]
async fn test_workspace_isolation() {
    let config_dir = TempDir::new().unwrap();
    let config_path = config_dir.path().join("config.toml");

    let work_dir = TempDir::new().unwrap();
    let personal_dir = TempDir::new().unwrap();

    // Setup workspaces with different content
    setup_test_workspace("work", &work_dir).await;
    setup_test_workspace("personal", &personal_dir).await;

    // Initialize workspaces through CLI (more reliable than manual config)
    let result = run_cli(
        CliCommand::Workspace {
            subcommand: WorkspaceSubcommand::Init {
                name: Some("work".to_string()),
                path: work_dir.path().to_path_buf(),
            },
        },
        Some(config_path.clone()),
    )
    .await;
    assert!(result.is_ok(), "work workspace init should succeed: {:?}", result);

    let result = run_cli(
        CliCommand::Workspace {
            subcommand: WorkspaceSubcommand::Init {
                name: Some("personal".to_string()),
                path: personal_dir.path().to_path_buf(),
            },
        },
        Some(config_path.clone()),
    )
    .await;
    assert!(result.is_ok(), "personal workspace init should succeed: {:?}", result);

    // Search in work workspace (default)
    let result = run_cli(
        CliCommand::Search {
            query: "work".to_string(),
            format: OutputFormat::Text,
        },
        Some(config_path.clone()),
    )
    .await;
    assert!(result.is_ok(), "search in work workspace should succeed: {:?}", result);

    // Switch to personal workspace
    let result = run_cli(
        CliCommand::Workspace {
            subcommand: WorkspaceSubcommand::Use {
                name: "personal".to_string(),
            },
        },
        Some(config_path.clone()),
    )
    .await;
    assert!(result.is_ok(), "workspace switch should succeed: {:?}", result);

    // Search in personal workspace should find different content
    let result = run_cli(
        CliCommand::Search {
            query: "personal".to_string(),
            format: OutputFormat::Text,
        },
        Some(config_path.clone()),
    )
    .await;
    assert!(result.is_ok(), "search in personal workspace should succeed: {:?}", result);

    // Search for work content in personal workspace should find nothing
    let result = run_cli(
        CliCommand::Search {
            query: "work-project".to_string(),
            format: OutputFormat::Text,
        },
        Some(config_path.clone()),
    )
    .await;
    assert!(result.is_ok(), "search for work content in personal should succeed (but find nothing): {:?}", result);
}

// ---------------------------------------------------------------------------
// test_json_output_multi_workspace
// ---------------------------------------------------------------------------

#[tokio::test]
async fn test_json_output_multi_workspace() {
    let config_dir = TempDir::new().unwrap();
    let config_path = config_dir.path().join("config.toml");

    let workspace_dir = TempDir::new().unwrap();
    setup_test_workspace("test", &workspace_dir).await;

    // Initialize workspace through CLI
    let result = run_cli(
        CliCommand::Workspace {
            subcommand: WorkspaceSubcommand::Init {
                name: Some("test-workspace".to_string()),
                path: workspace_dir.path().to_path_buf(),
            },
        },
        Some(config_path.clone()),
    )
    .await;
    assert!(result.is_ok(), "test workspace init should succeed: {:?}", result);

    // Test JSON output for search
    let result = run_cli(
        CliCommand::Search {
            query: "test".to_string(),
            format: OutputFormat::Json,
        },
        Some(config_path.clone()),
    )
    .await;
    assert!(result.is_ok(), "search with JSON format should succeed: {:?}", result);

    // Test JSON output for notes listing
    let result = run_cli(
        CliCommand::Notes {
            path: None,
            format: OutputFormat::Json,
        },
        Some(config_path.clone()),
    )
    .await;
    assert!(result.is_ok(), "notes with JSON format should succeed: {:?}", result);

    // Verify JSON structure by directly calling the vault (since CLI output goes to stdout)
    let vault = NoteVault::new(workspace_dir.path()).await.unwrap();
    vault.validate_and_init().await.unwrap();

    let results = vault.search_notes("test").await.unwrap();

    let json_str = kimun_notes::cli::json_output::format_notes_as_json(
        &vault,
        &results,
        "test-workspace",
        Some("test"),
        false, // is_listing
    ).await
    .expect("format_notes_as_json should succeed");

    let json: serde_json::Value = serde_json::from_str(&json_str)
        .expect("output should be valid JSON");

    // Verify workspace metadata is included
    assert_eq!(json["metadata"]["workspace"], "test-workspace");
    assert_eq!(json["metadata"]["workspace_path"], workspace_dir.path().to_string_lossy().to_string());
    assert_eq!(json["metadata"]["query"], "test");
    assert!(!json["metadata"]["is_listing"].as_bool().unwrap());

    // Verify note structure includes metadata
    let notes = json["notes"].as_array().expect("should have notes array");
    assert!(!notes.is_empty(), "should find test notes");

    for note in notes {
        assert!(note["metadata"].is_object(), "note should have metadata object");
        assert!(note["metadata"]["tags"].is_array(), "metadata should have tags array");
        assert!(note["metadata"]["links"].is_array(), "metadata should have links array");
        assert!(note["metadata"]["headers"].is_array(), "metadata should have headers array");
    }
}

// ---------------------------------------------------------------------------
// test_phase1_to_phase2_migration
// ---------------------------------------------------------------------------

#[tokio::test]
async fn test_phase1_to_phase2_migration() {
    let config_dir = TempDir::new().unwrap();
    let config_path = config_dir.path().join("config.toml");

    let workspace_dir = TempDir::new().unwrap();
    setup_test_workspace("legacy", &workspace_dir).await;

    // Write Phase 1 config
    write_phase1_config(&config_path, workspace_dir.path());

    // Verify Phase 1 config loads and migrates correctly
    let settings = AppSettings::load_from_file(config_path.clone()).expect("should load Phase 1 config");
    assert!(settings.workspace_dir.is_none(), "workspace_dir should be None after migration");
    assert!(settings.workspace_config.is_some(), "should have migrated workspace_config");

    let ws_config = settings.workspace_config.as_ref().unwrap();
    assert_eq!(ws_config.global.current_workspace, "default", "should migrate to default workspace");
    assert_eq!(ws_config.workspaces.len(), 1, "should have one workspace after migration");
    let default_workspace = ws_config.workspaces.get("default").expect("should have default workspace");
    assert_eq!(default_workspace.path, workspace_dir.path(), "migrated workspace should have correct path");

    // Test that CLI commands work with migrated config
    let result = run_cli(
        CliCommand::Search {
            query: "legacy".to_string(),
            format: OutputFormat::Text,
        },
        Some(config_path.clone()),
    )
    .await;
    assert!(result.is_ok(), "search should work with migrated config: {:?}", result);

    let result = run_cli(
        CliCommand::Notes {
            path: None,
            format: OutputFormat::Text,
        },
        Some(config_path.clone()),
    )
    .await;
    assert!(result.is_ok(), "notes should work with migrated config: {:?}", result);
}

// ---------------------------------------------------------------------------
// test_workspace_management_commands
// ---------------------------------------------------------------------------

#[tokio::test]
async fn test_workspace_management_commands() {
    let config_dir = TempDir::new().unwrap();
    let config_path = config_dir.path().join("config.toml");

    let workspace1_dir = TempDir::new().unwrap();
    let workspace2_dir = TempDir::new().unwrap();
    let workspace3_dir = TempDir::new().unwrap();

    // Initialize workspaces
    let result = run_cli(
        CliCommand::Workspace {
            subcommand: WorkspaceSubcommand::Init {
                name: Some("alpha".to_string()),
                path: workspace1_dir.path().to_path_buf(),
            },
        },
        Some(config_path.clone()),
    )
    .await;
    assert!(result.is_ok(), "alpha workspace init should succeed: {:?}", result);

    let result = run_cli(
        CliCommand::Workspace {
            subcommand: WorkspaceSubcommand::Init {
                name: Some("beta".to_string()),
                path: workspace2_dir.path().to_path_buf(),
            },
        },
        Some(config_path.clone()),
    )
    .await;
    assert!(result.is_ok(), "beta workspace init should succeed: {:?}", result);

    // List workspaces
    let result = run_cli(
        CliCommand::Workspace {
            subcommand: WorkspaceSubcommand::List,
        },
        Some(config_path.clone()),
    )
    .await;
    assert!(result.is_ok(), "workspace list should succeed: {:?}", result);

    // Rename workspace
    let result = run_cli(
        CliCommand::Workspace {
            subcommand: WorkspaceSubcommand::Rename {
                old_name: "beta".to_string(),
                new_name: "gamma".to_string(),
            },
        },
        Some(config_path.clone()),
    )
    .await;
    assert!(result.is_ok(), "workspace rename should succeed: {:?}", result);

    // Verify rename worked
    let settings = AppSettings::load_from_file(config_path.clone()).expect("should load settings");
    let ws_config = settings.workspace_config.as_ref().expect("should have workspace config");
    assert!(ws_config.workspaces.contains_key("gamma"), "should have gamma workspace");
    assert!(!ws_config.workspaces.contains_key("beta"), "should not have beta workspace");

    // Add another workspace and remove it
    let result = run_cli(
        CliCommand::Workspace {
            subcommand: WorkspaceSubcommand::Init {
                name: Some("temp".to_string()),
                path: workspace3_dir.path().to_path_buf(),
            },
        },
        Some(config_path.clone()),
    )
    .await;
    assert!(result.is_ok(), "temp workspace init should succeed: {:?}", result);

    let result = run_cli(
        CliCommand::Workspace {
            subcommand: WorkspaceSubcommand::Remove {
                name: "temp".to_string(),
            },
        },
        Some(config_path.clone()),
    )
    .await;
    assert!(result.is_ok(), "workspace remove should succeed: {:?}", result);

    // Verify removal worked
    let settings = AppSettings::load_from_file(config_path.clone()).expect("should load settings");
    let ws_config = settings.workspace_config.as_ref().expect("should have workspace config");
    assert!(!ws_config.workspaces.contains_key("temp"), "should not have temp workspace");
    assert_eq!(ws_config.workspaces.len(), 2, "should have 2 workspaces remaining");
}

// ---------------------------------------------------------------------------
// test_workspace_reindex
// ---------------------------------------------------------------------------

#[tokio::test]
async fn test_workspace_reindex() {
    let config_dir = TempDir::new().unwrap();
    let config_path = config_dir.path().join("config.toml");

    let workspace_dir = TempDir::new().unwrap();

    // Initialize workspace
    let result = run_cli(
        CliCommand::Workspace {
            subcommand: WorkspaceSubcommand::Init {
                name: Some("reindex-test".to_string()),
                path: workspace_dir.path().to_path_buf(),
            },
        },
        Some(config_path.clone()),
    )
    .await;
    assert!(result.is_ok(), "workspace init should succeed: {:?}", result);

    // Create some notes in the workspace
    setup_test_workspace("reindex", &workspace_dir).await;

    // Run reindex command
    let result = run_cli(
        CliCommand::Workspace {
            subcommand: WorkspaceSubcommand::Reindex {
                name: Some("reindex-test".to_string()),
            },
        },
        Some(config_path.clone()),
    )
    .await;
    assert!(result.is_ok(), "workspace reindex should succeed: {:?}", result);

    // Verify notes are searchable after reindex
    let result = run_cli(
        CliCommand::Search {
            query: "reindex".to_string(),
            format: OutputFormat::Text,
        },
        Some(config_path.clone()),
    )
    .await;
    assert!(result.is_ok(), "search after reindex should succeed: {:?}", result);
}

// ---------------------------------------------------------------------------
// test_error_handling
// ---------------------------------------------------------------------------

#[tokio::test]
async fn test_error_handling() {
    let config_dir = TempDir::new().unwrap();
    let config_path = config_dir.path().join("config.toml");

    // Test switching to non-existent workspace
    // First create a valid config with one workspace
    let workspace_dir = TempDir::new().unwrap();
    let result = run_cli(
        CliCommand::Workspace {
            subcommand: WorkspaceSubcommand::Init {
                name: Some("existing".to_string()),
                path: workspace_dir.path().to_path_buf(),
            },
        },
        Some(config_path.clone()),
    )
    .await;
    assert!(result.is_ok(), "workspace init should succeed: {:?}", result);

    // Try to switch to non-existent workspace
    let result = run_cli(
        CliCommand::Workspace {
            subcommand: WorkspaceSubcommand::Use {
                name: "non-existent".to_string(),
            },
        },
        Some(config_path.clone()),
    )
    .await;
    assert!(result.is_err(), "switching to non-existent workspace should fail");

    // Try to remove non-existent workspace
    let result = run_cli(
        CliCommand::Workspace {
            subcommand: WorkspaceSubcommand::Remove {
                name: "non-existent".to_string(),
            },
        },
        Some(config_path.clone()),
    )
    .await;
    assert!(result.is_err(), "removing non-existent workspace should fail");

    // Try to rename non-existent workspace
    let result = run_cli(
        CliCommand::Workspace {
            subcommand: WorkspaceSubcommand::Rename {
                old_name: "non-existent".to_string(),
                new_name: "new-name".to_string(),
            },
        },
        Some(config_path.clone()),
    )
    .await;
    assert!(result.is_err(), "renaming non-existent workspace should fail");
}

// ---------------------------------------------------------------------------
// test_complex_multi_workspace_workflow
// ---------------------------------------------------------------------------

#[tokio::test]
async fn test_complex_multi_workspace_workflow() {
    let config_dir = TempDir::new().unwrap();
    let config_path = config_dir.path().join("config.toml");

    let work_dir = TempDir::new().unwrap();
    let personal_dir = TempDir::new().unwrap();
    let project_dir = TempDir::new().unwrap();

    // Setup comprehensive workflow
    setup_test_workspace("work", &work_dir).await;
    setup_test_workspace("personal", &personal_dir).await;
    setup_test_workspace("project", &project_dir).await;

    // Initialize all workspaces through CLI
    for (name, dir) in [("work", &work_dir), ("personal", &personal_dir), ("project", &project_dir)] {
        let result = run_cli(
            CliCommand::Workspace {
                subcommand: WorkspaceSubcommand::Init {
                    name: Some(name.to_string()),
                    path: dir.path().to_path_buf(),
                },
            },
            Some(config_path.clone()),
        )
        .await;
        assert!(result.is_ok(), "{} workspace init should succeed: {:?}", name, result);
    }

    // Test switching between workspaces and running different operations
    for workspace_name in ["work", "personal", "project"] {
        // Switch workspace
        let result = run_cli(
            CliCommand::Workspace {
                subcommand: WorkspaceSubcommand::Use {
                    name: workspace_name.to_string(),
                },
            },
            Some(config_path.clone()),
        )
        .await;
        assert!(result.is_ok(), "switch to {} should succeed: {:?}", workspace_name, result);

        // Test search in current workspace
        let result = run_cli(
            CliCommand::Search {
                query: workspace_name.to_string(),
                format: OutputFormat::Text,
            },
            Some(config_path.clone()),
        )
        .await;
        assert!(result.is_ok(), "search in {} should succeed: {:?}", workspace_name, result);

        // Test notes listing in current workspace
        let result = run_cli(
            CliCommand::Notes {
                path: None,
                format: OutputFormat::Text,
            },
            Some(config_path.clone()),
        )
        .await;
        assert!(result.is_ok(), "notes in {} should succeed: {:?}", workspace_name, result);

        // Test JSON output in current workspace
        let result = run_cli(
            CliCommand::Search {
                query: workspace_name.to_string(),
                format: OutputFormat::Json,
            },
            Some(config_path.clone()),
        )
        .await;
        assert!(result.is_ok(), "JSON search in {} should succeed: {:?}", workspace_name, result);
    }

    // List all workspaces to verify they all exist
    let result = run_cli(
        CliCommand::Workspace {
            subcommand: WorkspaceSubcommand::List,
        },
        Some(config_path.clone()),
    )
    .await;
    assert!(result.is_ok(), "workspace list should succeed: {:?}", result);

    // Verify final config state
    let settings = AppSettings::load_from_file(config_path.clone()).expect("should load settings");
    let ws_config = settings.workspace_config.as_ref().expect("should have workspace config");
    assert_eq!(ws_config.workspaces.len(), 3, "should have 3 workspaces");
    assert_eq!(ws_config.global.current_workspace, "project", "should be on project workspace");
}