kimun-notes 0.23.2

use crate::keys::action_shortcuts::{ActionShortcuts, TextAction};
use crate::keys::key_strike::KeyStrike;
use crate::settings::themes::Theme;
use crate::settings::workspace_config::WorkspaceConfig;
use std::io::Read;
use std::path::PathBuf;
use std::sync::{Arc, RwLock};

use std::fs::{self, File};

/// Errors from loading and saving settings and themes. Typed at this seam so
/// callers can match on the failure; the binary's eyre top level (CLI, main)
/// wraps it automatically via `?`.
#[derive(Debug, thiserror::Error)]
pub enum SettingsError {
    #[error(transparent)]
    Io(#[from] std::io::Error),
    #[error("cannot serialize settings: {0}")]
    Serialize(#[from] toml::ser::Error),
    #[error("corrupt theme file: {0}")]
    CorruptTheme(toml::de::Error),
    #[error("config migration failed: {0}")]
    Migration(String),
    #[error(transparent)]
    System(#[from] kimun_core::system::SystemError),
}

/// Shared settings handle — all screens and components reference the same instance.
pub type SharedSettings = Arc<RwLock<AppSettings>>;
use kimun_core::IndexFile;

use self::history::HistoryFile;
use kimun_core::nfs::VaultPath;
use kimun_core::system::{self, SystemPath};

use crate::keys::KeyBindings;
pub mod config_migration;
pub mod history;
pub mod icons;
pub mod themes;
pub mod workspace_config;

// ---------------------------------------------------------------------------
// Sort settings types (shared between AppSettings and sorting UI)
// ---------------------------------------------------------------------------

#[derive(Clone, Copy, Debug, PartialEq, serde::Serialize, serde::Deserialize)]
#[serde(rename_all = "lowercase")]
pub enum SortFieldSetting {
    Name,
    Title,
}

#[derive(Clone, Copy, Debug, PartialEq, serde::Serialize, serde::Deserialize)]
#[serde(rename_all = "lowercase")]
pub enum SortOrderSetting {
    Ascending,
    Descending,
}

#[derive(Clone, Copy, Debug, Default, PartialEq, serde::Serialize, serde::Deserialize)]
#[serde(rename_all = "lowercase")]
pub enum EditorBackendSetting {
    /// The built-in engine, keys applied directly.
    ///
    /// `alias` rather than a migration entry: `ConfigMigration::run` happens
    /// *after* deserialisation, so a config still saying `textarea` would fail to
    /// load before any migration could rewrite it. The alias upgrades on the next
    /// save, when the setting is written back as `plain`.
    #[default]
    #[serde(alias = "textarea")]
    Plain,
    Nvim,
    Vim,
}

// pub mod theme;

/// Path to kimün's directory on this machine, creating it if needed — used by
/// the update module for the install marker and update-state file. The layout
/// (and the debug/release name) belongs to [`kimun_core::system`].
pub fn config_dir() -> Result<PathBuf, system::SystemError> {
    system::ensure_app_dir().map(SystemPath::into_path_buf)
}

const BASE_CONFIG_FILE: &str = "config.toml";
const THEMES_DIR: &str = "themes";

const CONFIG_HEADER: &str = "\
# ─── Kimün configuration ────────────────────────────────────────────────────
#
# KEY BINDINGS
# ────────────
# Supported combinations:
#   - ctrl and/or alt (with optional shift) + a letter (a-z)
#   - bare F-key (F1–F12, no modifier required)
# Any combo that does not follow these rules is silently ignored when loaded.
#
# Format per action:
#   ActionName = [\"<modifiers> & <letter>\", ...]
#
# Available modifiers (combine with +):  ctrl   alt   shift
#
# Examples:
#   Quit         = [\"ctrl&Q\"]            # Ctrl+Q
#   SearchNotes  = [\"ctrl&K\"]            # Ctrl+K
#   OpenNote     = [\"ctrl&O\"]            # Ctrl+O  (fuzzy file finder)
#   OpenSettings = [\"F4\", \"ctrl&,\"]     # F4 (Ctrl+, alias)
#   NewJournal   = [\"ctrl&J\"]            # Ctrl+J
#   FileOperations = [\"F2\"]              # F2  (open file-ops menu: delete/rename/move)
#   Leader       = [\"ctrl&G\"]            # Ctrl+G  (leader gateway: Ctrl+G f f, ...)
#   OpenCommandPalette = [\"ctrl&P\"]      # Ctrl+P  (every leader command, fuzzy)
#
# OTHER SETTINGS
# ──────────────
#   theme             = \"Gruvbox Dark\"   # or any built-in / custom theme name
#   leader_timeout_ms = 400               # hesitation before the which-key menu
#
# LEADER TREE OVERRIDES
# ─────────────────────
#   Remap, add, or remove leader sequences ([leader.bind]) and rename group
#   captions ([leader.labels]). Keys are the sequence AFTER the gateway;
#   bind values are action ids (see the cheatsheet) or \"none\" to unbind.
#   [leader.bind]
#   \"o f\" = \"find.files\"     # remap: leader o f now opens the file picker
#   \"x\"   = \"note.daily\"     # add:   leader x opens today's journal
#   \"g p\" = \"none\"           # remove the git-sync stub binding
#   [leader.labels]
#   \"f\"   = \"+search\"        # rename the +find group caption
#
# ─────────────────────────────────────────────────────────────────────────────
";

#[derive(Clone, Debug, serde::Serialize, serde::Deserialize, PartialEq)]
pub struct AppSettings {
    // Workspace layout
    #[serde(default)]
    pub config_version: u32,
    #[serde(flatten, skip_serializing_if = "Option::is_none")]
    pub workspace_config: Option<WorkspaceConfig>,

    // Preserved fields
    #[serde(default)]
    pub theme: String,
    /// As written in the config file — may be relative, may start with `~`.
    #[serde(default = "default_cache_dir")]
    pub cache_dir: PathBuf,
    /// [`Self::cache_dir`] made absolute. Never optional: an unresolved cache
    /// dir means the index lands relative to the process's working directory,
    /// so the type does not let that state exist. `resolve_paths` overwrites
    /// it once the config file's directory is known; until then it is resolved
    /// against the default config directory.
    #[serde(skip, default = "default_cache_dir_resolved")]
    cache_dir_resolved: SystemPath,

    /// As written in the config file — see [`Self::cache_dir`].
    #[serde(default = "default_history_dir")]
    pub history_dir: PathBuf,
    /// [`Self::history_dir`] made absolute — see [`Self::cache_dir_resolved`].
    #[serde(skip, default = "default_history_dir_resolved")]
    history_dir_resolved: SystemPath,
    #[serde(skip, default = "yes")]
    needs_indexing: bool,
    #[serde(default = "default_keybindings")]
    pub key_bindings: KeyBindings,
    #[serde(default = "default_autosave_interval")]
    pub autosave_interval_secs: u64,
    /// Hesitation timeout (ms) before the which-key overlay reveals itself
    /// during a pending leader sequence. Sequences typed faster never wait.
    #[serde(default = "default_leader_timeout_ms")]
    pub leader_timeout_ms: u64,
    /// Leader-tree customization: `[leader.bind]` sequence→action-id
    /// overrides and `[leader.labels]` group captions. Applied over the
    /// built-in tree.
    #[serde(default)]
    pub leader: LeaderConfig,
    #[serde(default = "default_use_nerd_fonts")]
    pub use_nerd_fonts: bool,
    #[serde(default)]
    pub editor_backend: EditorBackendSetting,
    #[serde(skip_serializing_if = "Option::is_none")]
    pub nvim_path: Option<std::path::PathBuf>,
    #[serde(default = "default_sort_field")]
    pub default_sort_field: SortFieldSetting,
    #[serde(default = "default_sort_order")]
    pub default_sort_order: SortOrderSetting,
    #[serde(default = "default_journal_sort_field")]
    pub journal_sort_field: SortFieldSetting,
    #[serde(default = "default_journal_sort_order")]
    pub journal_sort_order: SortOrderSetting,
    #[serde(default)]
    pub group_directories: bool,
    /// Custom config file path. `None` means use the default location.
    /// Not serialized — it's a runtime-only override.
    #[serde(skip)]
    pub config_file: Option<PathBuf>,
}

fn default_keybindings() -> KeyBindings {
    let mut kb = KeyBindings::empty();
    kb.batch_add()
        .with_ctrl()
        .add(KeyStrike::KeyK, ActionShortcuts::SearchNotes)
        .add(KeyStrike::KeyO, ActionShortcuts::OpenNote)
        .add(KeyStrike::KeyB, ActionShortcuts::Text(TextAction::Bold))
        .add(KeyStrike::KeyI, ActionShortcuts::Text(TextAction::Italic))
        .add(
            KeyStrike::KeyU,
            ActionShortcuts::Text(TextAction::Underline),
        )
        .add(
            KeyStrike::KeyS,
            ActionShortcuts::Text(TextAction::Strikethrough),
        )
        .add(KeyStrike::KeyL, ActionShortcuts::Text(TextAction::Link))
        .add(
            KeyStrike::KeyT,
            ActionShortcuts::Text(TextAction::ToggleHeader),
        )
        // =============================
        // We add shift to the modifiers
        // =============================
        .with_shift()
        .add(KeyStrike::KeyL, ActionShortcuts::Text(TextAction::Image));

    // TUI navigation shortcuts (always Ctrl — terminal apps don't use Cmd/Meta).
    // NOTE: the `Quit` entry must match `crate::keys::default_quit_combo()`,
    // which the deserialize safety net uses to recover an unreachable app.
    kb.batch_add()
        .with_ctrl()
        // Ctrl-P is the command palette (decision 2026-06-05); settings
        // live on Ctrl+Shift+P.
        .add(KeyStrike::KeyP, ActionShortcuts::OpenCommandPalette)
        .add(KeyStrike::KeyQ, ActionShortcuts::Quit)
        .add(KeyStrike::KeyJ, ActionShortcuts::NewJournal)
        // Drawer toggle. Deliberate spec deviation: the spec's Tier-0 puts
        // this on Ctrl-B, but Ctrl-B stays Bold (decision 2026-06-05) — the
        // drawer toggle lives on Ctrl-T.
        .add(KeyStrike::KeyT, ActionShortcuts::ToggleSidebar)
        .add(KeyStrike::KeyR, ActionShortcuts::OpenSortDialog)
        // Leader gateway. Spec deviation: spec says Ctrl-K, which stays the
        // note browser; the gateway lives on Ctrl-G (decision 2026-06-05).
        .add(KeyStrike::KeyG, ActionShortcuts::Leader)
        // FollowLink's always-works binding; Ctrl+Enter also follows on
        // kitty-protocol terminals (hardcoded in the editor screen).
        .add(KeyStrike::KeyN, ActionShortcuts::FollowLink)
        .add(KeyStrike::KeyH, ActionShortcuts::FocusSidebar)
        .add(KeyStrike::KeyL, ActionShortcuts::FocusEditor)
        .add(KeyStrike::KeyW, ActionShortcuts::QuickNote)
        // Ctrl-E opens (or switches the drawer to) the file browser; the
        // pure drawer toggle is Ctrl-T above. ToggleQueryPanel has no
        // default binding — FIND stays reachable via the rail and leader.
        .add(KeyStrike::KeyE, ActionShortcuts::OpenFileBrowser)
        .add(KeyStrike::KeyF, ActionShortcuts::FindInBuffer)
        // Copy the selected list row. Shares Ctrl-Y with the editor's redo,
        // resolved by focus: the shortcut tier only claims it away from the
        // editor. Sourced from `default_yank_combo` so SearchList,
        // which claims the same chord internally, cannot drift from it.
        .add(
            crate::keys::default_yank_combo().key,
            ActionShortcuts::YankRow,
        );

    // Settings — F4 (no modifier, reliable in all terminals) plus the classic
    // Ctrl+, kept as an alias. Ctrl+, doesn't transmit a distinct code on many
    // terminals outside the kitty protocol, so F4 is the dependable default.
    // (Ctrl+Shift+P collides with kitty's default hints-kitten chord prefix,
    // which holds the screen mid-chord, so it isn't used.)
    kb.batch_add()
        .add(KeyStrike::F4, ActionShortcuts::OpenPreferences);
    kb.batch_add()
        .with_ctrl()
        .add(KeyStrike::Comma, ActionShortcuts::OpenPreferences);

    // File operations menu (F2 — no modifier, reliable in all terminals).
    kb.batch_add()
        .add(KeyStrike::F2, ActionShortcuts::FileOperations);

    kb.batch_add()
        .add(KeyStrike::F3, ActionShortcuts::OpenSavedSearches);

    // Ask workspace (F6 — free key; the feature is inert without a server).
    kb.batch_add().add(KeyStrike::F6, ActionShortcuts::OpenAsk);

    // Workspace switcher — F5 (moved off F4, which is now Settings).
    kb.batch_add()
        .add(KeyStrike::F5, ActionShortcuts::SwitchWorkspace);

    // Ctrl+D — save the current query to saved searches. Ctrl-only by design:
    // Ctrl+Shift is unreliable on some terminals, Ctrl+S is taken by
    // Strikethrough, and Ctrl+{A,C,X,Z} are claimed by the editor. Ctrl+D is
    // the only free, terminal-safe Ctrl combo.
    kb.batch_add()
        .with_ctrl()
        .add(KeyStrike::KeyD, ActionShortcuts::SaveCurrentQuery);

    kb
}

/// Deletes a removed workspace's artifacts, returning the ones that would not
/// go, each with the reason.
///
/// A free function rather than a method so the caller can pull the artifacts
/// out with [`AppSettings::workspace_artifacts`], release the settings lock,
/// and delete outside it: `system::remove_file` waits out a handle another
/// process holds, and parking every settings reader for that wait is what the
/// "filesystem work before the lock" rule exists to avoid.
///
/// Best-effort by design. Whoever calls this has already decided the workspace
/// is going, so a stuck file is a leftover to report rather than a reason to
/// fail — and it is *returned*, because `tracing::warn!` in a CLI with no
/// subscriber attached goes nowhere.
pub fn delete_artifacts(index: &IndexFile, history: &HistoryFile) -> Vec<String> {
    let mut leftovers = Vec::new();
    // Every file the index is made of, not just the first that failed: a held
    // handle is normally on a sidecar, and naming only that one would send the
    // user to delete one file out of three.
    let stuck = index.remove();
    if stuck.is_empty() {
        tracing::info!("removed index {}", index);
    }
    for (path, e) in stuck {
        tracing::warn!("failed to remove {}: {}", path, e);
        leftovers.push(format!("  {path}\n    {e}"));
    }
    if let Err(e) = history.remove() {
        tracing::warn!("failed to remove history {}: {}", history, e);
        leftovers.push(format!("  {history}\n    {e}"));
    } else {
        tracing::info!("removed history {}", history);
    }
    leftovers
}

fn yes() -> bool {
    true
}

fn default_autosave_interval() -> u64 {
    5
}

fn default_leader_timeout_ms() -> u64 {
    400
}

/// The `[leader]` config section: binding overrides + group captions.
#[derive(Clone, Debug, Default, PartialEq, serde::Serialize, serde::Deserialize)]
pub struct LeaderConfig {
    /// `[leader.bind]`: sequence (after the gateway, e.g. `"o f"` / `"x"`) →
    /// action id (see the cheatsheet) or `"none"` to unbind.
    #[serde(default, skip_serializing_if = "std::collections::BTreeMap::is_empty")]
    pub bind: std::collections::BTreeMap<String, String>,
    /// `[leader.labels]`: group sequence (e.g. `"f"`) → caption shown in the
    /// which-key overlay and cheatsheet.
    #[serde(default, skip_serializing_if = "std::collections::BTreeMap::is_empty")]
    pub labels: std::collections::BTreeMap<String, String>,
}

impl AppSettings {
    /// Suggested directory for a first workspace (`~/kimun-notes`). `None`
    /// when the home directory cannot be determined.
    pub fn default_workspace_suggestion() -> Option<PathBuf> {
        system::home()
            .ok()
            .map(|h| h.join("kimun-notes").into_path_buf())
    }

    /// The leader tree with this config's `[leader]` overrides applied — the
    /// ONE constructor every surface (engine, which-key, cheatsheet, palette)
    /// must use, so they can never disagree.
    pub fn leader_tree(&self) -> crate::keys::leader::LeaderNode {
        let tree = crate::keys::leader::apply_overrides(
            crate::keys::leader::leader_tree(),
            self.leader
                .bind
                .iter()
                .map(|(k, v)| (k.as_str(), v.as_str())),
        );
        crate::keys::leader::apply_labels(
            tree,
            self.leader
                .labels
                .iter()
                .map(|(k, v)| (k.as_str(), v.as_str())),
        )
    }
}

fn default_cache_dir() -> PathBuf {
    PathBuf::from(".")
}

fn default_history_dir() -> PathBuf {
    PathBuf::from("history")
}

/// What relative `cache_dir` / `history_dir` values resolve against when no
/// config file anchors them: the default config directory, read *without*
/// creating it (settings that were never loaded from a file must not
/// materialise directories as a side effect of `Default`).
///
/// Anything absolute beats the alternative. The one thing these paths must
/// never fall back to is the raw relative form, which anchors on the process's
/// working directory: every kimün started from the same directory would then
/// share one index, and a first run would drop its index wherever the binary
/// happened to be launched. Hence the temp-dir fallback when even the home
/// directory is unknown.
fn default_settings_base_dir() -> SystemPath {
    system::app_dir().unwrap_or_else(|_| {
        let fallback = std::env::temp_dir().join("kimun");
        SystemPath::try_absolute(&fallback).unwrap_or_else(|_| system::log_dir())
    })
}

/// Resolved form of [`default_cache_dir`] for settings with no config file.
/// Also the `serde` default, so deserializing a config never yields an
/// unresolved path even before `resolve_paths` runs.
fn default_cache_dir_resolved() -> SystemPath {
    SystemPath::resolve(default_cache_dir(), &default_settings_base_dir())
}

/// Resolved form of [`default_history_dir`] — see [`default_cache_dir_resolved`].
fn default_history_dir_resolved() -> SystemPath {
    SystemPath::resolve(default_history_dir(), &default_settings_base_dir())
}

fn default_use_nerd_fonts() -> bool {
    false
}

fn default_sort_field() -> SortFieldSetting {
    SortFieldSetting::Name
}

fn default_sort_order() -> SortOrderSetting {
    SortOrderSetting::Ascending
}

fn default_journal_sort_field() -> SortFieldSetting {
    SortFieldSetting::Name
}

fn default_journal_sort_order() -> SortOrderSetting {
    SortOrderSetting::Descending
}

impl Default for AppSettings {
    fn default() -> Self {
        Self {
            config_version: 0,
            workspace_config: None,
            theme: Default::default(),
            cache_dir: default_cache_dir(),
            cache_dir_resolved: default_cache_dir_resolved(),
            history_dir: default_history_dir(),
            history_dir_resolved: default_history_dir_resolved(),
            needs_indexing: true,
            key_bindings: default_keybindings(),
            autosave_interval_secs: default_autosave_interval(),
            leader_timeout_ms: default_leader_timeout_ms(),
            leader: LeaderConfig::default(),
            use_nerd_fonts: false,
            editor_backend: EditorBackendSetting::Plain,
            nvim_path: None,
            default_sort_field: default_sort_field(),
            default_sort_order: default_sort_order(),
            journal_sort_field: default_journal_sort_field(),
            journal_sort_order: default_journal_sort_order(),
            group_directories: false,
            config_file: None,
        }
    }
}

impl AppSettings {
    pub fn theme_list(&self) -> Vec<Theme> {
        let mut list = Theme::builtins();
        list.append(&mut Self::load_custom_themes());
        // Merge the user's default.toml override if present.
        if let Ok(custom_default) = Self::load_default_theme() {
            list.push(custom_default);
        }
        list.sort_by(|a, b| a.name.cmp(&b.name));
        list
    }

    fn default_config_file_path() -> Result<PathBuf, SettingsError> {
        Ok(system::ensure_app_dir()?
            .join(BASE_CONFIG_FILE)
            .into_path_buf())
    }

    fn get_config_file_path(&self) -> Result<PathBuf, SettingsError> {
        if let Some(ref path) = self.config_file {
            Ok(path.clone())
        } else {
            Self::default_config_file_path()
        }
    }

    fn get_themes_path() -> Result<PathBuf, SettingsError> {
        Ok(system::ensure_app_dir()?.join(THEMES_DIR).into_path_buf())
    }

    fn load_theme_from_path(path: &std::path::Path) -> Result<Theme, SettingsError> {
        let theme_string = fs::read_to_string(path)?;
        match toml::from_str::<Theme>(&theme_string) {
            Ok(theme) => Ok(theme),
            Err(e) => {
                // Never delete a user-authored file over a typo — warn and
                // skip, exactly like load_custom_themes does.
                tracing::warn!("Skipping unparsable theme file {:?}: {}", path, e);
                Err(SettingsError::CorruptTheme(e))
            }
        }
    }

    fn load_default_theme() -> Result<Theme, SettingsError> {
        let theme_path = AppSettings::get_themes_path()?.join("default.toml");
        Self::load_theme_from_path(&theme_path)
    }

    fn load_custom_themes() -> Vec<Theme> {
        let mut themes = Vec::new();

        // Get themes directory, return empty vec if it fails
        let themes_path = match Self::get_themes_path() {
            Ok(path) => path,
            Err(_) => return themes,
        };

        // Read directory entries, return empty vec if it fails
        let entries =
            match SystemPath::try_absolute(&themes_path).and_then(|dir| system::read_dir(&dir)) {
                Ok(entries) => entries,
                Err(_) => return themes,
            };

        // Iterate through all entries in the themes directory
        for entry in entries {
            let path = entry.into_path_buf();

            // Skip if not a file
            if !path.is_file() {
                continue;
            }

            // Skip if not a .toml file
            if path.extension().and_then(|s| s.to_str()) != Some("toml") {
                continue;
            }

            // Skip default.toml
            if path.file_name().and_then(|s| s.to_str()) == Some("default.toml") {
                continue;
            }

            // Try to read and deserialize the theme file
            match fs::read_to_string(&path)
                .and_then(|s| toml::from_str::<Theme>(&s).map_err(std::io::Error::other))
            {
                Ok(theme) => themes.push(theme),
                Err(e) => tracing::warn!("Skipping theme file {:?}: {}", path, e),
            }
        }

        themes
    }

    /// Whether the startup update check is enabled. Lives in `GlobalConfig`;
    /// defaults to on when no workspace config exists yet. Single source for
    /// the four read sites (startup, preferences, onboarding).
    pub fn update_check(&self) -> bool {
        self.workspace_config
            .as_ref()
            .map(|wc| wc.global.update_check)
            .unwrap_or(true)
    }

    /// Whether kimün captures the mouse for in-app use; defaults on when no
    /// workspace config exists yet. Read at startup (main.rs) and in preferences.
    pub fn mouse(&self) -> bool {
        self.workspace_config
            .as_ref()
            .map(|wc| wc.global.mouse)
            .unwrap_or(true)
    }

    pub fn save_to_disk(&self) -> Result<(), SettingsError> {
        tracing::debug!("Saving settings to disk");
        let settings_file_path = self.get_config_file_path()?;
        // Atomic: the config is rewritten on every preference change and on
        // every migration, and a truncated one is what the corrupt-config
        // branch below exists to clean up after.
        let body = format!("{CONFIG_HEADER}{}", toml::to_string(&self)?);
        system::replace_atomically(&settings_file_path, body.as_bytes())?;
        Ok(())
    }

    pub fn load_from_disk() -> Result<Self, SettingsError> {
        let settings_file_path = Self::default_config_file_path()?;

        if !settings_file_path.exists() {
            let default_settings = Self::defaults_for_config_file(settings_file_path);
            default_settings.save_to_disk()?;
            Ok(default_settings)
        } else {
            let mut settings_file = File::open(&settings_file_path)?;

            let mut toml = String::new();
            settings_file.read_to_string(&mut toml)?;

            match toml::from_str::<AppSettings>(toml.as_ref()) {
                Ok(mut setting) => {
                    setting.config_file = Some(settings_file_path.clone());
                    // Resolve ~ and relative paths against the config file's
                    // directory (see `config_base_dir` for why it is canonicalized).
                    setting.resolve_paths(&Self::config_base_dir(&settings_file_path));
                    if config_migration::ConfigMigration::run(&mut setting)? {
                        setting.save_to_disk()?;
                    }
                    setting.merge_missing_default_bindings();
                    Ok(setting)
                }
                Err(e) => {
                    tracing::warn!(
                        "Config file at {:?} could not be parsed ({}). \
                         Renaming to .corrupt and starting with defaults.",
                        settings_file_path,
                        e
                    );
                    let corrupt_path = settings_file_path.with_extension("toml.corrupt");
                    let _ = system::move_file(&settings_file_path, &corrupt_path);
                    let defaults = Self::defaults_for_config_file(settings_file_path);
                    defaults.save_to_disk()?;
                    Ok(defaults)
                }
            }
        }
    }

    pub fn load_from_file(path: PathBuf) -> Result<Self, SettingsError> {
        // A bare filename (`--config kimun.toml`) has an *empty* parent, not
        // no parent. Creating it is a no-op the OS accepts, but canonicalizing
        // "" fails, so the empty case has to be filtered out here — otherwise
        // every such invocation aborts before the config is even read.
        if let Some(parent) = path.parent()
            && !parent.as_os_str().is_empty()
        {
            system::create_dir(parent)?;
        }
        if !path.exists() {
            let default_settings = Self::defaults_for_config_file(path);
            default_settings.save_to_disk()?;
            return Ok(default_settings);
        }
        let mut toml_str = String::new();
        File::open(&path)?.read_to_string(&mut toml_str)?;
        match toml::from_str::<AppSettings>(&toml_str) {
            Ok(mut setting) => {
                setting.config_file = Some(path.clone());

                // Resolve ~ and relative paths against the config file's
                // directory (see `config_base_dir` for why it is canonicalized).
                setting.resolve_paths(&Self::config_base_dir(&path));

                // Run config migrations (keybinding moves, v3 onwards).
                if config_migration::ConfigMigration::run(&mut setting)? {
                    setting.save_to_disk()?;
                }

                setting.merge_missing_default_bindings();
                Ok(setting)
            }
            Err(e) => {
                tracing::warn!(
                    "Config file at {:?} could not be parsed ({}). \
                     Renaming to .corrupt and starting with defaults.",
                    path,
                    e
                );
                let corrupt_path = path.with_extension("toml.corrupt");
                let _ = system::move_file(&path, &corrupt_path);
                let defaults = Self::defaults_for_config_file(path);
                defaults.save_to_disk()?;
                Ok(defaults)
            }
        }
    }

    /// Fills in defaults from `default_keybindings()` that are absent in the
    /// loaded config: actions with no binding at all, plus default combos
    /// added in newer versions (e.g. Ctrl-B for the drawer toggle) — as long
    /// as the combo is not already bound to *any* action. Existing
    /// user-customised bindings are never overwritten.
    fn merge_missing_default_bindings(&mut self) {
        let defaults = default_keybindings().to_hashmap();
        let mut current = self.key_bindings.to_hashmap();
        let mut bound: std::collections::HashSet<_> = current.values().flatten().cloned().collect();
        for (action, combos) in defaults {
            match current.entry(action) {
                std::collections::hash_map::Entry::Vacant(e) => {
                    // Never steal a combo the user has bound to something
                    // else — insert only the free ones, and claim them so a
                    // later default in this pass cannot double-bind.
                    let free: Vec<_> = combos.into_iter().filter(|c| !bound.contains(c)).collect();
                    if !free.is_empty() {
                        bound.extend(free.iter().copied());
                        e.insert(free);
                    }
                }
                std::collections::hash_map::Entry::Occupied(mut e) => {
                    for combo in combos {
                        if !bound.contains(&combo) && !e.get().contains(&combo) {
                            bound.insert(combo);
                            e.get_mut().push(combo);
                        }
                    }
                }
            }
        }
        self.key_bindings = KeyBindings::from_hashmap(current);
    }

    /// Points the *selected* workspace entry at `workspace_path`, flagging a
    /// reindex when that actually changes where its notes are.
    ///
    /// `name` is the entry to repoint; a name with no entry is a no-op.
    pub fn set_workspace_path(&mut self, name: &str, workspace_path: PathBuf) {
        let Some(entry) = self
            .workspace_config
            .as_mut()
            .and_then(|wc| wc.workspaces.get_mut(name))
        else {
            return;
        };
        if *entry.effective_path() != workspace_path {
            self.needs_indexing = true;
        }
        entry.path = workspace_path;
        entry.resolved_path = None;
    }

    /// Removes the active workspace entry so the user is prompted to choose a
    /// new one.
    ///
    /// Only the currently active entry is removed; other workspace entries are
    /// preserved. After this call, `workspace_config` remains `Some` but
    /// `get_current_workspace()` returns `None`.
    ///
    /// Deliberately leaves the index and history on disk: the caller for this
    /// is a vault the app could not open (a case conflict it wants fixed), and
    /// the user is expected to re-add the same workspace once they have. See
    /// [`crate::settings::delete_artifacts`] for the deletion that goes with an
    /// intentional "remove this workspace".
    pub fn clear_workspace(&mut self) {
        if let Some(wc) = &mut self.workspace_config {
            let key = wc.global.current_workspace.clone();
            if !key.is_empty() {
                wc.workspaces.remove(&key);
            }
            wc.global.current_workspace = String::new();
        }
    }

    /// Resolve the active workspace's path. Returns `None` if no workspace is
    /// configured.
    pub fn resolve_workspace_path(&self) -> Option<SystemPath> {
        let raw = self
            .workspace_config
            .as_ref()
            .and_then(|wc| wc.get_current_workspace())
            .map(|entry| entry.effective_path().clone())?;
        // Config paths are made absolute by `resolve_paths` on load. One that
        // still is not cannot name a vault on this machine, so it is reported
        // as "no workspace" rather than opened relative to wherever the
        // process happens to be running.
        match SystemPath::try_absolute(&raw) {
            Ok(path) => Some(path),
            Err(e) => {
                tracing::warn!("ignoring unusable workspace path {raw:?}: {e}");
                None
            }
        }
    }

    /// Resolve `~` and relative paths in workspace entries.
    /// Relative paths are resolved against `base` (typically the config file's
    /// parent directory). Called once after deserialization.
    fn resolve_paths(&mut self, base: &SystemPath) {
        // Workspace entries — populate resolved_path, keep original path intact.
        if let Some(ref mut wc) = self.workspace_config {
            for entry in wc.workspaces.values_mut() {
                let resolved = SystemPath::resolve(&entry.path, base).into_path_buf();
                if resolved != entry.path {
                    entry.resolved_path = Some(resolved);
                }
            }
        }
        self.cache_dir_resolved = SystemPath::resolve(&self.cache_dir, base);
        self.history_dir_resolved = SystemPath::resolve(&self.history_dir, base);
    }

    /// Freshly defaulted settings for a config file that could not be loaded —
    /// one that does not exist yet, or one too corrupt to parse — with
    /// `config_file` pointing at it and its relative paths resolved against
    /// its directory.
    ///
    /// The resolve is the whole point: `cache_dir` / `history_dir` default to
    /// `.` and `history`, and [`Self::default`] can only anchor them on the
    /// *default* config directory. A config file elsewhere (`--config`) must
    /// re-anchor them on its own directory, or its workspaces' indexes land
    /// next to somebody else's.
    fn defaults_for_config_file(path: PathBuf) -> Self {
        let base = Self::config_base_dir(&path);
        let mut settings = Self {
            config_file: Some(path),
            ..Self::default()
        };
        settings.resolve_paths(&base);
        settings
    }

    /// The directory a config file's relative paths resolve against, in the
    /// canonical form [`Self::resolve_paths`] expects as its `base`.
    ///
    /// Canonicalized up front (the directory exists — we only ever ask this of
    /// a config file we just read): `expand_path` canonicalizes a relative
    /// path's *result* only when that exact target already exists on disk (e.g.
    /// `cache_dir = "."`), so an as-yet-uncreated one (e.g. `history_dir`
    /// before its first write) would otherwise resolve against this
    /// directory's raw form and silently disagree with the paths resolved once
    /// the target does exist (`/var/...` vs macOS's real `/private/var/...`).
    ///
    /// [`Path::parent`] yields `Some("")` — not `None` — for a bare filename
    /// (`--config kimun.toml`), so the empty parent falls back to `.` next to
    /// the no-parent case; without that, `base` would be empty and relative
    /// settings paths would never become absolute.
    ///
    /// [`Path::parent`]: std::path::Path::parent
    fn config_base_dir(config_file: &std::path::Path) -> SystemPath {
        let dir = config_file
            .parent()
            .filter(|p| !p.as_os_str().is_empty())
            .unwrap_or(std::path::Path::new("."));
        // `.` (a bare `--config kimun.toml`) is the one place resolving
        // against the working directory is what the user meant: they named
        // the file from there moments ago.
        SystemPath::canonical(dir)
            .or_else(|_| {
                let cwd = std::env::current_dir().unwrap_or_default();
                SystemPath::try_absolute(cwd.join(dir))
            })
            .unwrap_or_else(|_| default_settings_base_dir())
    }

    pub fn set_theme(&mut self, theme: String) {
        self.theme = theme;
    }

    pub fn report_indexed(&mut self) {
        self.needs_indexing = false;
    }

    pub fn needs_indexing(&self) -> bool {
        self.needs_indexing
    }

    pub fn add_path_history(&mut self, note_path: &VaultPath) {
        if !note_path.is_note() {
            return;
        }
        let Some(workspace_name) = self.current_workspace_name() else {
            return;
        };
        let history = self.history_for(&workspace_name);
        if let Err(e) = history.push(note_path) {
            tracing::warn!("failed to write history {history}: {e}");
        }
    }

    pub fn current_workspace_name(&self) -> Option<String> {
        self.workspace_config
            .as_ref()
            .map(|wc| wc.global.current_workspace.clone())
            .filter(|s| !s.is_empty())
    }

    /// The directory workspace cache files live in.
    pub fn cache_dir_resolved(&self) -> &SystemPath {
        &self.cache_dir_resolved
    }

    /// The directory workspace history files live in.
    pub fn history_dir_resolved(&self) -> &SystemPath {
        &self.history_dir_resolved
    }

    /// What the named workspace's files are called on disk.
    ///
    /// Its name, until the workspace is renamed — from then on the name it had
    /// when its files were created (see [`WorkspaceEntry::file_key`]). Falling
    /// back to the name when there is no entry is what lets `workspace init`
    /// name the index before the entry exists.
    ///
    /// [`WorkspaceEntry::file_key`]: workspace_config::WorkspaceEntry::file_key
    fn file_key_for(&self, workspace_name: &str) -> String {
        self.workspace_config
            .as_ref()
            .and_then(|wc| wc.get_workspace(workspace_name))
            .map(|entry| entry.file_key_or(workspace_name))
            .unwrap_or_else(|| workspace_name.to_string())
    }

    /// The named workspace's index file.
    ///
    /// Returns the artifact, not a path: what the file is called, and that it
    /// carries `-wal`/`-shm` siblings, is [`IndexFile`]'s business. Caller
    /// must have already validated `workspace_name` via
    /// `kimun_core::nfs::filename::validate_filename`.
    pub fn index_for(&self, workspace_name: &str) -> IndexFile {
        IndexFile::in_dir(&self.cache_dir_resolved, &self.file_key_for(workspace_name))
    }

    /// The named workspace's history file — the artifact, not a path, for the
    /// same reason as [`Self::index_for`]. Caller must have already validated
    /// `workspace_name`.
    pub fn history_for(&self, workspace_name: &str) -> HistoryFile {
        HistoryFile::in_dir(
            &self.history_dir_resolved,
            &self.file_key_for(workspace_name),
        )
    }

    /// Everything on disk that belongs to the named workspace.
    ///
    /// Must be read *before* the entry is dropped from `workspace_config`:
    /// both file names come from its [`file_key`], so removing the entry first
    /// strands them under a name nothing can map back to a workspace. Pure and
    /// cheap, so the caller can take these, release the settings lock, and do
    /// the deleting outside it — see [`delete_artifacts`].
    ///
    /// [`file_key`]: workspace_config::WorkspaceEntry::file_key
    pub fn workspace_artifacts(&self, workspace_name: &str) -> (IndexFile, HistoryFile) {
        (
            self.index_for(workspace_name),
            self.history_for(workspace_name),
        )
    }

    /// Returns the last-visited paths for the current workspace.
    pub fn current_last_paths(&self) -> Vec<VaultPath> {
        let Some(name) = self.current_workspace_name() else {
            return Vec::new();
        };
        self.history_for(&name).load()
    }

    /// Build the icon set for the current `use_nerd_fonts` setting.
    pub fn icons(&self) -> icons::Icons {
        icons::Icons::new(self.use_nerd_fonts)
    }

    /// The chords bound to [`ActionShortcuts::YankRow`], for handing to a
    /// [`SearchList`](crate::components::search_list::SearchList) so a rebinding
    /// reaches the list surfaces. Empty when the user unbound it.
    pub fn yank_combos(&self) -> Vec<crate::keys::key_combo::KeyCombo> {
        self.key_bindings.combos_for(&ActionShortcuts::YankRow)
    }

    /// Name of the theme the app is effectively using: the configured name,
    /// or the default theme's name when none is configured. Single owner of
    /// the empty-name fallback rule — use this instead of re-deriving it.
    pub fn effective_theme_name(&self) -> String {
        if self.theme.is_empty() {
            Theme::default().name
        } else {
            self.theme.clone()
        }
    }

    /// Resolve the active theme by name, falling back to the default.
    ///
    /// The resolved theme is adapted to the terminal's color depth (truecolor
    /// themes are quantized on 256-color terminals and mapped to role-semantic
    /// ANSI slots on 16-color terminals).
    pub fn get_theme(&self) -> Theme {
        let theme = if self.theme.is_empty() {
            Theme::default()
        } else {
            self.theme_list()
                .into_iter()
                .find(|t| t.name == self.theme)
                .unwrap_or_default()
        };
        theme.adapt_to_terminal()
    }
}

/// Path helpers shared by this file's test modules.
#[cfg(test)]
mod test_paths {
    use std::path::PathBuf;

    /// Builds a genuinely absolute path for the host from `/`-separated
    /// components.
    ///
    /// A literal like `"/config/dir"` is absolute on Unix but merely *rooted*
    /// on Windows, where [`Path::is_absolute`] also wants a prefix (`C:\`).
    /// Passing the literal straight in doesn't just weaken these tests there,
    /// it inverts them: `expand_path` sees a relative path, rebases it onto
    /// `base`, and the `is_absolute` assertion then fails on behavior that is
    /// in fact correct.
    ///
    /// [`Path::is_absolute`]: std::path::Path::is_absolute
    pub(super) fn absolute(unix_style: &str) -> PathBuf {
        let trimmed = unix_style.trim_start_matches('/');
        if cfg!(windows) {
            PathBuf::from(format!("C:\\{}", trimmed.replace('/', "\\")))
        } else {
            PathBuf::from(format!("/{trimmed}"))
        }
    }

    /// The same path as a TOML string literal's contents — Windows separators
    /// have to survive TOML's own escaping.
    pub(super) fn absolute_toml(unix_style: &str) -> String {
        absolute(unix_style).to_string_lossy().replace('\\', "\\\\")
    }
}

#[cfg(test)]
#[allow(clippy::field_reassign_with_default)]
mod tests {
    use super::test_paths::absolute;
    use super::*;

    #[test]
    fn default_workspace_suggestion_is_under_home() {
        let suggestion = AppSettings::default_workspace_suggestion();
        if let Some(p) = suggestion {
            assert!(p.ends_with("kimun-notes"));
            assert!(p.is_absolute());
        }
        // None is acceptable only when the platform has no home dir.
    }

    #[test]
    fn load_theme_from_nonexistent_path_returns_err_without_creating_file() {
        // RED: fails to compile because load_theme_from_path doesn't exist.
        // GREEN: method exists, returns Err, and does NOT create the file.
        let path = std::env::temp_dir().join("kimun_tdd_test_theme_absent.toml");
        let _ = std::fs::remove_file(&path); // ensure clean state

        let result = AppSettings::load_theme_from_path(&path);

        assert!(result.is_err(), "should return Err when file is absent");
        assert!(!path.exists(), "must not create the file as a side effect");
    }

    #[test]
    fn load_theme_from_corrupt_path_returns_err_without_recreating_file() {
        // After a corrupt file is removed, no replacement must be written.
        let path = std::env::temp_dir().join("kimun_tdd_test_theme_corrupt.toml");
        std::fs::write(&path, b"not valid toml {{{{").unwrap();

        let result = AppSettings::load_theme_from_path(&path);

        assert!(result.is_err(), "should return Err for corrupt TOML");
        // The user's file must SURVIVE a parse error (a typo must never
        // delete a hand-authored theme).
        assert!(path.exists(), "corrupt theme file must not be deleted");
        std::fs::remove_file(&path).ok();
    }

    #[test]
    fn default_keybindings_quit_matches_canonical_combo() {
        let kb = default_keybindings();
        let combo = crate::keys::default_quit_combo();
        assert_eq!(
            kb.get_action(&combo),
            Some(ActionShortcuts::Quit),
            "default_keybindings() must bind default_quit_combo() to Quit so the \
             deserialize safety net can recover an unreachable app"
        );
    }

    #[test]
    fn autosave_interval_defaults_to_five() {
        let settings = AppSettings::default();
        assert_eq!(settings.autosave_interval_secs, 5);
    }

    #[test]
    fn autosave_interval_deserializes_from_toml() {
        let toml = "autosave_interval_secs = 30\n";
        let settings: AppSettings = toml::from_str(toml).unwrap();
        assert_eq!(settings.autosave_interval_secs, 30);
    }

    #[test]
    fn autosave_interval_defaults_when_missing_from_toml() {
        let toml = ""; // no autosave_interval_secs key
        let settings: AppSettings = toml::from_str(toml).unwrap();
        assert_eq!(settings.autosave_interval_secs, 5);
    }

    /// Verify the full load path: TOML with FileOperations = ["F2"] → keybinding lookup.
    #[test]
    fn f2_file_operations_survives_toml_deserialize() {
        use crate::keys::key_combo::{KeyCombo, KeyModifiers};
        use crate::keys::key_strike::KeyStrike;

        let toml = r#"
[key_bindings]
FileOperations = ["F2"]
"#;
        let settings: AppSettings = toml::from_str(toml).unwrap();
        let f2 = KeyCombo::new(KeyModifiers::default(), KeyStrike::F2);
        let action = settings.key_bindings.get_action(&f2);
        assert_eq!(
            action,
            Some(ActionShortcuts::FileOperations),
            "F2 should survive deserialization and map to FileOperations"
        );
    }

    /// Verify merge_missing_default_bindings adds F2 when absent from config.
    #[test]
    fn merge_adds_f2_when_absent() {
        use crate::keys::key_combo::{KeyCombo, KeyModifiers};
        use crate::keys::key_strike::KeyStrike;

        // Settings with no FileOperations binding
        let toml = r#"
[key_bindings]
Quit = ["ctrl&Q"]
"#;
        let mut settings: AppSettings = toml::from_str(toml).unwrap();
        settings.merge_missing_default_bindings();

        let f2 = KeyCombo::new(KeyModifiers::default(), KeyStrike::F2);
        let action = settings.key_bindings.get_action(&f2);
        assert_eq!(
            action,
            Some(ActionShortcuts::FileOperations),
            "merge_missing_default_bindings should add F2 → FileOperations"
        );
    }

    #[test]
    fn clear_workspace_removes_the_current_workspace_entry() {
        let mut settings = AppSettings::default();
        let mut wc = WorkspaceConfig::new_empty();
        wc.add_workspace("vault1".to_string(), absolute("/tmp/vault1"))
            .unwrap();
        settings.workspace_config = Some(wc);
        // Assert precondition: add_workspace auto-selects the first workspace
        assert_eq!(
            settings
                .workspace_config
                .as_ref()
                .unwrap()
                .global
                .current_workspace,
            "vault1"
        );
        settings.clear_workspace();
        let wc = settings.workspace_config.as_ref().unwrap();
        assert!(
            wc.workspaces.is_empty(),
            "workspace entry should be removed"
        );
        assert!(
            wc.global.current_workspace.is_empty(),
            "current_workspace should be empty"
        );
    }

    #[test]
    fn clear_workspace_preserves_other_workspaces() {
        let mut settings = AppSettings::default();
        let mut wc = WorkspaceConfig::new_empty();
        wc.add_workspace("vault1".to_string(), absolute("/tmp/vault1"))
            .unwrap();
        wc.add_workspace("vault2".to_string(), PathBuf::from("/tmp/vault2"))
            .unwrap();
        wc.global.current_workspace = "vault1".to_string();
        settings.workspace_config = Some(wc);
        settings.clear_workspace();
        let wc = settings.workspace_config.as_ref().unwrap();
        assert!(
            !wc.workspaces.contains_key("vault1"),
            "active workspace should be removed"
        );
        assert!(
            wc.workspaces.contains_key("vault2"),
            "other workspaces should be preserved"
        );
        assert!(
            wc.global.current_workspace.is_empty(),
            "current_workspace should be empty"
        );
    }
}

#[cfg(test)]
mod backend_tests {
    use super::test_paths::{absolute, absolute_toml};
    use super::*;

    #[test]
    fn a_config_still_saying_textarea_loads() {
        // The value was renamed; a config written by an older version must keep
        // working. This has to be an alias rather than a migration entry, because
        // migrations run after deserialisation — an unknown variant fails first.
        #[derive(serde::Deserialize)]
        struct Holder {
            editor_backend: EditorBackendSetting,
        }
        let old: Holder = toml::from_str("editor_backend = \"textarea\"").expect("still loads");
        assert_eq!(old.editor_backend, EditorBackendSetting::Plain);
    }

    #[test]
    fn the_backend_is_written_back_as_plain() {
        let written = toml::to_string(&AppSettings::default()).expect("serialises");
        assert!(
            written.contains("editor_backend = \"plain\""),
            "a saved config should name the value as it is now: {written}"
        );
    }

    #[test]
    fn default_backend_is_plain() {
        let settings = AppSettings::default();
        assert!(matches!(
            settings.editor_backend,
            EditorBackendSetting::Plain
        ));
    }

    #[test]
    fn nvim_backend_round_trips_toml() {
        let toml = "editor_backend = \"nvim\"\n";
        let parsed: AppSettings = toml::from_str(toml).unwrap();
        assert!(matches!(parsed.editor_backend, EditorBackendSetting::Nvim));
    }

    #[test]
    fn editor_backend_vim_roundtrips_through_toml() {
        #[derive(serde::Serialize, serde::Deserialize)]
        struct W {
            editor_backend: EditorBackendSetting,
        }
        let w = W {
            editor_backend: EditorBackendSetting::Vim,
        };
        let s = toml::to_string(&w).unwrap();
        assert!(s.contains("editor_backend = \"vim\""), "serialized: {s}");
        let back: W = toml::from_str(&s).unwrap();
        assert_eq!(back.editor_backend, EditorBackendSetting::Vim);
    }

    /// Workspace cache/history paths are absolute however the settings were
    /// built — including the two constructions that never run `resolve_paths`:
    /// a bare `default()` and a plain deserialize. A relative one anchors the
    /// index on the process's working directory, so every kimün started from
    /// the same place would share one index.
    #[test]
    fn workspace_paths_are_absolute_without_resolve_paths() {
        for settings in [
            AppSettings::default(),
            toml::from_str::<AppSettings>("theme = \"gruvbox_dark\"\n").unwrap(),
        ] {
            let cache = settings.index_for("w");
            let history = settings.history_for("w");
            assert!(
                cache.path().as_path().is_absolute(),
                "cache path not absolute: {cache}"
            );
            assert!(
                history.path().as_path().is_absolute(),
                "history path not absolute: {history}"
            );
        }
    }

    // `expand_path` and its tests moved to `kimun_core::system`, where the
    // path rules now live; what stays here is how *settings* anchor them.

    #[test]
    fn resolve_paths_populates_resolved_path() {
        let base = tempfile::TempDir::new().unwrap();
        let notes = base.path().join("notes");
        std::fs::create_dir_all(&notes).unwrap();

        let toml = r#"
config_version = 2
[global]
current_workspace = "test"
[workspaces.test]
path = "notes"
last_paths = []
created = "2026-01-01T00:00:00Z"
"#
        .to_string();
        let mut settings: AppSettings = toml::from_str(&toml).unwrap();
        settings.resolve_paths(&SystemPath::try_absolute(base.path()).unwrap());

        let wc = settings.workspace_config.as_ref().unwrap();
        let entry = wc.workspaces.get("test").unwrap();
        // Original path preserved
        assert_eq!(entry.path, PathBuf::from("notes"));
        // Resolved path is absolute
        assert!(entry.resolved_path.is_some());
        assert!(entry.effective_path().is_absolute());
    }

    /// A config file that does not exist yet still has to yield paths anchored
    /// to its own directory. `index_for`/`history_for` fall back to
    /// the *raw* `cache_dir`/`history_dir` when nothing resolved them, and
    /// those default to `.` and `history` — relative, so unresolved defaults
    /// put the workspace index wherever the process happens to be running.
    /// Every process sharing a working directory then shares one index file:
    /// in CI that is several test binaries racing to create the same schema
    /// ("table appData already exists"), and for a user it is a first-run
    /// index dropped in whatever directory they launched from.
    #[test]
    fn load_from_file_resolves_paths_for_a_config_that_does_not_exist_yet() {
        let dir = tempfile::TempDir::new().unwrap();
        let config_dir = dir.path().canonicalize().unwrap();
        let settings = AppSettings::load_from_file(config_dir.join("config.toml")).unwrap();

        let cache = settings.index_for("work");
        let history = settings.history_for("work");
        assert!(
            cache.path().as_path().starts_with(&config_dir),
            "cache path must sit next to the config file, got {cache}"
        );
        assert!(
            history.path().as_path().starts_with(&config_dir),
            "history path must sit next to the config file, got {history}"
        );
    }

    /// Same requirement on the other branch that hands back bare defaults: an
    /// unparseable config is renamed aside and replaced, and those
    /// replacements need resolving just as much.
    #[test]
    fn load_from_file_resolves_paths_when_the_config_is_corrupt() {
        let dir = tempfile::TempDir::new().unwrap();
        let config_dir = dir.path().canonicalize().unwrap();
        let config_path = config_dir.join("config.toml");
        std::fs::write(&config_path, "not = valid toml [[[").unwrap();

        let settings = AppSettings::load_from_file(config_path).unwrap();

        let cache = settings.index_for("work");
        assert!(
            cache.path().as_path().starts_with(&config_dir),
            "cache path must sit next to the config file, got {cache}"
        );
    }

    #[test]
    fn resolve_paths_absolute_no_resolved_path() {
        // Host-absolute, not just `/`-rooted: on Windows `/absolute/notes` is
        // a *relative* path, so it would pick up a resolved_path and invert
        // both assertions below.
        let toml = format!(
            r#"
config_version = 2
[global]
current_workspace = "test"
[workspaces.test]
path = "{}"
last_paths = []
created = "2026-01-01T00:00:00Z"
"#,
            absolute_toml("/absolute/notes")
        );
        let mut settings: AppSettings = toml::from_str(&toml).unwrap();
        settings.resolve_paths(&SystemPath::try_absolute(absolute("/config")).unwrap());

        let wc = settings.workspace_config.as_ref().unwrap();
        let entry = wc.workspaces.get("test").unwrap();
        // No resolved_path needed for already-absolute paths
        assert!(entry.resolved_path.is_none());
        assert_eq!(*entry.effective_path(), absolute("/absolute/notes"));
    }
}

#[cfg(test)]
mod sort_settings_tests {
    use super::*;

    #[test]
    fn group_directories_defaults_off() {
        let s = AppSettings::default();
        assert!(!s.group_directories);
    }

    #[test]
    fn open_sort_dialog_is_bound_by_default() {
        let s = AppSettings::default();
        let map = s.key_bindings.to_hashmap();
        assert!(
            map.contains_key(&ActionShortcuts::OpenSortDialog),
            "OpenSortDialog must have a default binding"
        );
    }
}