khive-pack-knowledge 0.9.0

Knowledge verb pack — lore corpus (atoms/domains), TF-IDF retrieval, concept registration
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
//! `KnowledgePack` struct, factory, and `PackRuntime` impl.

use std::collections::HashMap;
use std::sync::Mutex;

use async_trait::async_trait;
use serde_json::Value;
use uuid::Uuid;

use khive_brain_core::SectionPosteriorState;
use khive_runtime::pack::{PackByIdResolver, PackRuntime};
use khive_runtime::{
    KhiveRuntime, Namespace, NamespaceToken, PackSchemaPlan, Resolved, RuntimeError, SchemaPlan,
    VerbRegistry,
};
use khive_storage::types::{SqlStatement, SqlValue};
use khive_storage::{PhaseCancelledPayload, PhaseCompletedPayload, PhaseStartedPayload};
use khive_types::{EventKind, HandlerDef, Pack};

use crate::knowledge::util::{atom_from_row, atom_to_json, domain_from_row, domain_to_json};
use crate::knowledge::vamana;
use crate::knowledge::KnowledgeHandlers;
use crate::vocab::{KNOWLEDGE_HANDLERS, KNOWLEDGE_SCHEMA_PLAN_STMTS};

/// Knowledge corpus pack — atoms, domains, TF-IDF search, fold, import, and KG concept verbs.
pub struct KnowledgePack {
    pub(crate) runtime: KhiveRuntime,
    pub(crate) ann: vamana::SharedAnn,
    /// Pack-local Tier-3 feedback state, isolated by exact namespace.
    ///
    /// This fallback is used only when no configured or bound brain profile
    /// resolves. Keying it by namespace keeps explicit measurement arms from
    /// inheriting live/default feedback while preserving existing local behavior.
    pub(crate) section_posteriors: Mutex<HashMap<String, SectionPosteriorState>>,
    /// Explicit brain profile ID from config (ADR-035 §Brain profile configuration).
    ///
    /// Tier-1 of the 3-tier feedback resolution: when set, `knowledge.feedback` directs
    /// section feedback through the trusted in-process brain hook. When absent, tier-2
    /// (namespace-bound profile) and tier-3 (namespace-local prior) are tried in order.
    pub(crate) brain_profile: Option<String>,
}

impl Pack for KnowledgePack {
    const NAME: &'static str = "knowledge";
    const NOTE_KINDS: &'static [&'static str] = &[];
    const ENTITY_KINDS: &'static [&'static str] = &[];
    const BRAIN_CONSUMER_KINDS: &'static [&'static str] =
        &[khive_brain_core::ConsumerKind::KnowledgeCompose.as_str()];
    const HANDLERS: &'static [HandlerDef] = &KNOWLEDGE_HANDLERS;
    const REQUIRES: &'static [&'static str] = &["kg"];
    const SCHEMA_PLAN: Option<PackSchemaPlan> = Some(PackSchemaPlan {
        pack: "knowledge",
        statements: &KNOWLEDGE_SCHEMA_PLAN_STMTS,
    });
}

impl KnowledgePack {
    /// Create a new pack bound to the given runtime, initializing a shared ANN index.
    pub fn new(runtime: KhiveRuntime) -> Self {
        Self::new_with_index_role(runtime, true)
    }

    /// As [`Self::new`], but states whether this process may build the atom
    /// index from the full corpus. See `MemoryPack::new_with_index_role` for the
    /// reasoning; the two packs share one index root per model family and the
    /// same cost.
    pub fn new_with_index_role(runtime: KhiveRuntime, builds_corpus_indexes: bool) -> Self {
        let brain_profile = runtime.config().brain_profile.clone();
        Self {
            runtime,
            ann: vamana::new_shared_for_role(builds_corpus_indexes),
            section_posteriors: Mutex::new(HashMap::new()),
            brain_profile,
        }
    }
}

struct KnowledgePackFactory;

impl khive_runtime::PackFactory for KnowledgePackFactory {
    fn name(&self) -> &'static str {
        "knowledge"
    }

    fn requires(&self) -> &'static [&'static str] {
        &["kg"]
    }

    fn create(&self, runtime: KhiveRuntime) -> Box<dyn khive_runtime::PackRuntime> {
        Box::new(KnowledgePack::new_with_index_role(
            runtime,
            khive_runtime::daemon::is_warm_index_host(),
        ))
    }

    fn create_resolver(
        &self,
        runtime: KhiveRuntime,
    ) -> Option<Box<dyn khive_runtime::PackByIdResolver>> {
        Some(Box::new(KnowledgePack::new(runtime)))
    }
}

inventory::submit! { khive_runtime::PackRegistration(&KnowledgePackFactory) }

#[async_trait]
impl PackRuntime for KnowledgePack {
    fn name(&self) -> &str {
        <KnowledgePack as Pack>::NAME
    }

    fn note_kinds(&self) -> &'static [&'static str] {
        <KnowledgePack as Pack>::NOTE_KINDS
    }

    fn entity_kinds(&self) -> &'static [&'static str] {
        <KnowledgePack as Pack>::ENTITY_KINDS
    }

    fn brain_consumer_kinds(&self) -> &'static [&'static str] {
        <KnowledgePack as Pack>::BRAIN_CONSUMER_KINDS
    }

    fn handlers(&self) -> &'static [HandlerDef] {
        &KNOWLEDGE_HANDLERS
    }

    fn requires(&self) -> &'static [&'static str] {
        <KnowledgePack as Pack>::REQUIRES
    }

    fn schema_plan(&self) -> SchemaPlan {
        SchemaPlan {
            pack: "knowledge",
            statements: &KNOWLEDGE_SCHEMA_PLAN_STMTS,
        }
    }

    async fn warm(&self) {
        // Vamana warm may register a missing ANN consumer or publish a rebuilt
        // checkpoint. A snapshot runtime keeps only the pure embedder warm
        // below; it must not enter a writer-bearing ANN lifecycle.
        if !self.runtime.is_read_only() {
            crate::knowledge::vamana::warm_known_snapshots(&self.runtime, &self.ann).await;
            crate::knowledge::vamana::start_rotation_watcher(&self.runtime, &self.ann);
        }
        if !self.runtime.default_embedder_name().is_empty() {
            let runtime = self.runtime.clone();
            // ADR-103 Amendment 1 Part 2: the phase span brackets ONLY this
            // configured-embedder branch's spawned embed call, not the
            // unconditional `warm_known_snapshots` above -- an unconditional
            // span would record a phase for an embedder warmup that never
            // ran whenever no embedder is configured. Minted here (before
            // spawn) rather than inside the task: `authorize` is cheap and
            // synchronous, and minting outside keeps the same shape as
            // KgPack::warm's unconditional case.
            let token = match runtime.authorize(khive_runtime::Namespace::local()) {
                Ok(token) => Some(token),
                Err(e) => {
                    tracing::warn!(
                        error = %e,
                        "knowledge_embedder_warm: failed to mint ADR-103 phase-span \
                         attribution token; warmup proceeds without telemetry"
                    );
                    None
                }
            };
            tokio::spawn(async move {
                if let Some(token) = &token {
                    khive_runtime::emit_phase_event(
                        &runtime,
                        token,
                        "knowledge.embedder_warm",
                        EventKind::PhaseStarted,
                        PhaseStartedPayload {
                            work_class: "warm".into(),
                            phase: "knowledge_embedder_warm".into(),
                            corpus_size: None,
                        },
                    )
                    .await;
                }
                let phase_start = std::time::Instant::now();
                let cpu_start = khive_runtime::process_resource_usage();
                let result = runtime.embed("__khive_knowledge_warm__").await;
                if let Some(token) = &token {
                    let wall_us = phase_start.elapsed().as_micros() as i64;
                    let cpu_us = khive_runtime::cpu_delta_us(
                        cpu_start,
                        khive_runtime::process_resource_usage(),
                    );
                    match &result {
                        Err(e) if khive_runtime::is_benign_shutdown_cancellation(e) => {
                            khive_runtime::emit_phase_event(
                                &runtime,
                                token,
                                "knowledge.embedder_warm",
                                EventKind::PhaseCancelled,
                                PhaseCancelledPayload {
                                    work_class: "warm".into(),
                                    phase: "knowledge_embedder_warm".into(),
                                    wall_us,
                                    cpu_us,
                                },
                            )
                            .await;
                        }
                        _ => {
                            khive_runtime::emit_phase_event(
                                &runtime,
                                token,
                                "knowledge.embedder_warm",
                                EventKind::PhaseCompleted,
                                PhaseCompletedPayload {
                                    work_class: "warm".into(),
                                    phase: "knowledge_embedder_warm".into(),
                                    wall_us,
                                    cpu_us,
                                },
                            )
                            .await;
                        }
                    }
                }
                let _ = result;
            });
        }
    }

    async fn dispatch(
        &self,
        verb: &str,
        params: Value,
        registry: &VerbRegistry,
        token: &NamespaceToken,
    ) -> Result<Value, RuntimeError> {
        match verb {
            "knowledge.upsert_atoms" => {
                KnowledgeHandlers::upsert_atoms(&self.runtime, token, params).await
            }
            "knowledge.upsert_domains" => {
                KnowledgeHandlers::upsert_domains(&self.runtime, token, params).await
            }
            "knowledge.get" => KnowledgeHandlers::get(&self.runtime, token, params).await,
            "knowledge.list" => KnowledgeHandlers::list(&self.runtime, token, params).await,
            "knowledge.delete_atoms" => {
                KnowledgeHandlers::delete_atoms(&self.runtime, token, params).await
            }
            "knowledge.stats" => KnowledgeHandlers::stats(&self.runtime, token, params).await,
            "knowledge.eval_retrieval" => {
                KnowledgeHandlers::eval_retrieval(&self.runtime, token, params, &self.ann).await
            }
            "knowledge.index" => {
                KnowledgeHandlers::index(&self.runtime, token, params, &self.ann, None).await
            }
            "knowledge.fold" => KnowledgeHandlers::fold(&self.runtime, token, params).await,
            "knowledge.search" => {
                KnowledgeHandlers::search(&self.runtime, token, params, &self.ann).await
            }
            "knowledge.suggest" => {
                KnowledgeHandlers::suggest(&self.runtime, token, params, &self.ann).await
            }
            "knowledge.compose" => {
                // Public registry dispatch pre-applies an explicit namespace,
                // while PackRuntime can also be called directly by embedders.
                // A direct caller must supply a token already authorized for
                // the requested namespace; handlers may not mint a stronger
                // capability from an untrusted business parameter.
                let effective_token = match params.get("namespace") {
                    None => token.clone(),
                    Some(Value::String(ns_str)) => {
                        let ns = Namespace::parse(ns_str).map_err(|e| {
                            RuntimeError::InvalidInput(format!("invalid namespace {ns_str:?}: {e}"))
                        })?;
                        if &ns != token.namespace() {
                            return Err(RuntimeError::InvalidInput(
                                "knowledge.compose namespace does not match authorized token namespace"
                                    .to_string(),
                            ));
                        }
                        // Equality proves this is capability narrowing, not
                        // elevation. Replace any broader visible set so every
                        // compose leg observes exactly the requested arm.
                        token.with_namespace(ns)
                    }
                    Some(_) => {
                        return Err(RuntimeError::InvalidInput(
                            "invalid namespace: expected a string".to_string(),
                        ));
                    }
                };
                let type_weights = self
                    .resolve_compose_type_weights(registry, &effective_token)
                    .await;
                KnowledgeHandlers::compose(
                    &self.runtime,
                    &effective_token,
                    params,
                    &self.ann,
                    type_weights,
                )
                .await
            }
            "knowledge.edit" => {
                KnowledgeHandlers::edit(&self.runtime, token, params, &self.ann).await
            }
            "knowledge.import" => {
                KnowledgeHandlers::import(&self.runtime, token, params, &self.ann).await
            }
            "knowledge.challenge" => {
                KnowledgeHandlers::challenge(&self.runtime, token, params).await
            }
            "knowledge.adjudicate" => {
                KnowledgeHandlers::adjudicate(&self.runtime, token, params).await
            }
            "knowledge.learn" => self.handle_learn(token, params).await,
            "knowledge.cite" => self.handle_cite(token, params).await,
            "knowledge.topic" => self.handle_topic(token, params).await,
            "knowledge.feedback" => self.handle_feedback(token, params, registry).await,
            _ => Err(RuntimeError::InvalidInput(format!(
                "knowledge pack does not handle verb {verb:?}"
            ))),
        }
    }
}

#[async_trait]
impl PackByIdResolver for KnowledgePack {
    /// Resolve a live knowledge record by UUID.
    ///
    /// Queries `knowledge_domains` first (canonical record), then
    /// `knowledge_atoms`. The domain mirror atom shares the domain's UUID
    /// (crud.rs:279/300) so domains must win over the mirror.
    async fn resolve_by_id(&self, id: Uuid) -> Result<Option<Resolved>, RuntimeError> {
        let sql = self.runtime.sql();
        let id_str = id.to_string();

        let mut reader = sql
            .reader()
            .await
            .map_err(|e| RuntimeError::Internal(format!("knowledge resolve_by_id reader: {e}")))?;

        // 1. Check knowledge_domains first (canonical over the mirror atom).
        let domain_row = reader
            .query_row(SqlStatement {
                sql: "SELECT id, namespace, slug, name, description, tags, members, \
                      created_at, updated_at, deleted_at \
                      FROM knowledge_domains WHERE id = ?1 AND deleted_at IS NULL LIMIT 1"
                    .into(),
                params: vec![SqlValue::Text(id_str.clone())],
                label: Some("knowledge.resolve_by_id.domain".into()),
            })
            .await
            .map_err(|e| {
                RuntimeError::Internal(format!("knowledge resolve_by_id domain query: {e}"))
            })?;

        if let Some(row) = domain_row {
            if let Some(domain) = domain_from_row(&row) {
                return Ok(Some(Resolved::PackRecord {
                    pack: "knowledge".into(),
                    kind: "domain".into(),
                    data: domain_to_json(&domain),
                }));
            }
        }

        // 2. Check knowledge_atoms.
        let atom_row = reader
            .query_row(SqlStatement {
                sql: "SELECT id, namespace, slug, name, content, tags, properties, \
                      status, finalized, source_uri, source_type, created_at, updated_at, deleted_at \
                      FROM knowledge_atoms WHERE id = ?1 AND deleted_at IS NULL LIMIT 1"
                    .into(),
                params: vec![SqlValue::Text(id_str)],
                label: Some("knowledge.resolve_by_id.atom".into()),
            })
            .await
            .map_err(|e| {
                RuntimeError::Internal(format!("knowledge resolve_by_id atom query: {e}"))
            })?;

        if let Some(row) = atom_row {
            if let Some(atom) = atom_from_row(&row) {
                return Ok(Some(Resolved::PackRecord {
                    pack: "knowledge".into(),
                    kind: "atom".into(),
                    data: atom_to_json(&atom),
                }));
            }
        }

        Ok(None)
    }

    /// Resolve a knowledge record including already-soft-deleted records.
    ///
    /// Used by the hard-delete path to locate tombstoned records.
    async fn resolve_by_id_including_deleted(
        &self,
        id: Uuid,
    ) -> Result<Option<Resolved>, RuntimeError> {
        let sql = self.runtime.sql();
        let id_str = id.to_string();

        let mut reader = sql.reader().await.map_err(|e| {
            RuntimeError::Internal(format!(
                "knowledge resolve_by_id_including_deleted reader: {e}"
            ))
        })?;

        let domain_row = reader
            .query_row(SqlStatement {
                sql: "SELECT id, namespace, slug, name, description, tags, members, \
                      created_at, updated_at, deleted_at \
                      FROM knowledge_domains WHERE id = ?1 LIMIT 1"
                    .into(),
                params: vec![SqlValue::Text(id_str.clone())],
                label: Some("knowledge.resolve_by_id_incl_deleted.domain".into()),
            })
            .await
            .map_err(|e| {
                RuntimeError::Internal(format!(
                    "knowledge resolve_by_id_including_deleted domain query: {e}"
                ))
            })?;

        if let Some(row) = domain_row {
            if let Some(domain) = domain_from_row(&row) {
                return Ok(Some(Resolved::PackRecord {
                    pack: "knowledge".into(),
                    kind: "domain".into(),
                    data: domain_to_json(&domain),
                }));
            }
        }

        let atom_row = reader
            .query_row(SqlStatement {
                sql: "SELECT id, namespace, slug, name, content, tags, properties, \
                      status, finalized, source_uri, source_type, created_at, updated_at, deleted_at \
                      FROM knowledge_atoms WHERE id = ?1 LIMIT 1"
                    .into(),
                params: vec![SqlValue::Text(id_str)],
                label: Some("knowledge.resolve_by_id_incl_deleted.atom".into()),
            })
            .await
            .map_err(|e| {
                RuntimeError::Internal(format!(
                    "knowledge resolve_by_id_including_deleted atom query: {e}"
                ))
            })?;

        if let Some(row) = atom_row {
            if let Some(atom) = atom_from_row(&row) {
                return Ok(Some(Resolved::PackRecord {
                    pack: "knowledge".into(),
                    kind: "atom".into(),
                    data: atom_to_json(&atom),
                }));
            }
        }

        Ok(None)
    }

    fn private_record_verbs(&self) -> &'static [&'static str] {
        &[
            "knowledge.upsert_atoms",
            "knowledge.upsert_domains",
            "knowledge.edit",
        ]
    }

    /// Delete a knowledge domain or atom by UUID.
    ///
    /// Soft-delete by default (`hard=false`): sets `deleted_at = now()`.
    /// For domains, also tombstones the mirror atom in `knowledge_atoms`.
    /// Hard-delete (`hard=true`): permanently removes rows from the table(s).
    async fn delete_by_id(&self, id: Uuid, hard: bool) -> Result<serde_json::Value, RuntimeError> {
        let sql = self.runtime.sql();
        let id_str = id.to_string();

        // First determine the kind (including deleted rows so hard-delete can find tombstones).
        let kind = match self.resolve_by_id_including_deleted(id).await? {
            Some(Resolved::PackRecord { kind, .. }) => kind,
            _ => {
                return Err(RuntimeError::NotFound(format!(
                    "knowledge record not found: {id}"
                )));
            }
        };

        let now_us = std::time::SystemTime::now()
            .duration_since(std::time::UNIX_EPOCH)
            .unwrap_or_default()
            .as_micros() as i64;

        let mut writer = sql
            .writer()
            .await
            .map_err(|e| RuntimeError::Internal(format!("knowledge delete_by_id writer: {e}")))?;

        match kind.as_str() {
            "domain" => {
                if hard {
                    // Hard-delete: sections → mirror atom → domain (all in one transaction).
                    // knowledge_sections has a FK to knowledge_atoms(id) without ON DELETE
                    // CASCADE, so sections must go before the atom row.
                    writer
                        .execute_batch(vec![
                            SqlStatement {
                                sql: "DELETE FROM knowledge_sections WHERE atom_id = ?1".into(),
                                params: vec![SqlValue::Text(id_str.clone())],
                                label: Some(
                                    "knowledge.delete_by_id.domain_mirror_sections.hard".into(),
                                ),
                            },
                            SqlStatement {
                                sql: "DELETE FROM knowledge_atoms WHERE id = ?1".into(),
                                params: vec![SqlValue::Text(id_str.clone())],
                                label: Some("knowledge.delete_by_id.domain_mirror.hard".into()),
                            },
                            SqlStatement {
                                sql: "DELETE FROM knowledge_domains WHERE id = ?1".into(),
                                params: vec![SqlValue::Text(id_str.clone())],
                                label: Some("knowledge.delete_by_id.domain.hard".into()),
                            },
                        ])
                        .await
                        .map_err(|e| {
                            RuntimeError::Internal(format!(
                                "knowledge delete_by_id domain hard: {e}"
                            ))
                        })?;
                } else {
                    writer
                        .execute(SqlStatement {
                            sql: "UPDATE knowledge_domains SET deleted_at = ?1 \
                                  WHERE id = ?2 AND deleted_at IS NULL"
                                .into(),
                            params: vec![SqlValue::Integer(now_us), SqlValue::Text(id_str.clone())],
                            label: Some("knowledge.delete_by_id.domain.soft".into()),
                        })
                        .await
                        .map_err(|e| {
                            RuntimeError::Internal(format!(
                                "knowledge delete_by_id domain soft: {e}"
                            ))
                        })?;
                    // Tombstone the mirror atom so FTS no longer surfaces it.
                    writer
                        .execute(SqlStatement {
                            sql: "UPDATE knowledge_atoms SET deleted_at = ?1 \
                                  WHERE id = ?2 AND deleted_at IS NULL"
                                .into(),
                            params: vec![SqlValue::Integer(now_us), SqlValue::Text(id_str.clone())],
                            label: Some("knowledge.delete_by_id.domain_mirror.soft".into()),
                        })
                        .await
                        .map_err(|e| {
                            RuntimeError::Internal(format!(
                                "knowledge delete_by_id domain mirror soft: {e}"
                            ))
                        })?;
                }
            }
            "atom" => {
                if hard {
                    // Hard-delete: sections first (FK constraint), then the atom row.
                    writer
                        .execute_batch(vec![
                            SqlStatement {
                                sql: "DELETE FROM knowledge_sections WHERE atom_id = ?1".into(),
                                params: vec![SqlValue::Text(id_str.clone())],
                                label: Some("knowledge.delete_by_id.atom_sections.hard".into()),
                            },
                            SqlStatement {
                                sql: "DELETE FROM knowledge_atoms WHERE id = ?1".into(),
                                params: vec![SqlValue::Text(id_str.clone())],
                                label: Some("knowledge.delete_by_id.atom.hard".into()),
                            },
                        ])
                        .await
                        .map_err(|e| {
                            RuntimeError::Internal(format!("knowledge delete_by_id atom hard: {e}"))
                        })?;
                } else {
                    writer
                        .execute(SqlStatement {
                            sql: "UPDATE knowledge_atoms SET deleted_at = ?1 \
                                  WHERE id = ?2 AND deleted_at IS NULL"
                                .into(),
                            params: vec![SqlValue::Integer(now_us), SqlValue::Text(id_str.clone())],
                            label: Some("knowledge.delete_by_id.atom.soft".into()),
                        })
                        .await
                        .map_err(|e| {
                            RuntimeError::Internal(format!("knowledge delete_by_id atom soft: {e}"))
                        })?;
                }
            }
            other => {
                return Err(RuntimeError::Internal(format!(
                    "knowledge delete_by_id: unexpected kind {other:?}"
                )));
            }
        }

        Ok(serde_json::json!({
            "deleted": true,
            "id": id_str,
            "kind": kind,
            "hard": hard,
        }))
    }
}

#[cfg(test)]
mod tests {
    use khive_runtime::pack::PackRuntime;
    use khive_runtime::{KhiveRuntime, Namespace, RuntimeConfig};
    use lattice_embed::EmbeddingModel;

    use super::KnowledgePack;

    // ADR-103 Amendment 1 Part 2: knowledge_embedder_warm phase-span events.
    //
    // `KhiveRuntime::memory()` builds on `RuntimeConfig::no_embeddings()`
    // (runtime.rs), so `default_embedder_name()` is empty and the
    // configured-embedder branch in `KnowledgePack::warm()` never runs. This
    // pins that gating: the unconditional `vamana::warm_known_snapshots` call
    // above the branch must never itself emit a phase event, and the
    // configured-only branch must not fire when unconfigured.
    #[tokio::test]
    async fn knowledge_warm_emits_no_phase_events_when_no_embedder_configured() {
        let rt = KhiveRuntime::memory().expect("in-memory runtime");
        let token = rt.authorize(Namespace::local()).expect("authorize local");
        let event_store = rt.events(&token).expect("event store must be available");

        let pack = KnowledgePack::new(rt.clone());
        pack.warm().await;

        let page = event_store
            .query_events(
                khive_storage::EventFilter::default(),
                khive_storage::PageRequest {
                    limit: 10,
                    offset: 0,
                },
            )
            .await
            .expect("query events");

        assert!(
            page.items.is_empty(),
            "no embedder configured -> KnowledgePack::warm() must emit zero phase events \
             (configured-only branch must not fire, and warm_known_snapshots must not \
             independently emit): {:?}",
            page.items
        );
    }

    #[tokio::test]
    async fn read_only_knowledge_cache_miss_does_not_start_ann_writer_lifecycle() {
        let dir = tempfile::tempdir().expect("tempdir");
        let config = RuntimeConfig {
            db_path: Some(dir.path().join("read-only-knowledge-ann.db")),
            embedding_model: Some(EmbeddingModel::AllMiniLmL6V2),
            additional_embedding_models: vec![],
            ..RuntimeConfig::no_embeddings()
        };
        drop(KhiveRuntime::new(config.clone()).expect("migrate snapshot source"));

        #[cfg(unix)]
        {
            let db_path = config.db_path.as_ref().expect("db path");
            khive_storage::test_support::freeze_snapshot_sidecars(db_path);
        }

        let read_only = KhiveRuntime::new_readonly(config).expect("open snapshot read-only");
        let token = read_only
            .authorize(Namespace::local())
            .expect("authorize local");
        let pack = KnowledgePack::new(read_only.clone());
        let key = crate::knowledge::vamana::AnnKey::new(
            token.namespace().as_str(),
            read_only.default_embedder_name(),
        );
        let before = read_only.backend().pool().writer_acquisition_snapshot();

        crate::knowledge::vamana::ensure_ann_background(&read_only, &token, &pack.ann);

        assert!(
            !crate::knowledge::vamana::is_warming_not_loaded(&pack.ann, &key),
            "a read-only search cache miss must not claim or spawn an ANN warm slot"
        );
        assert_eq!(
            read_only.backend().pool().writer_acquisition_snapshot(),
            before,
            "read-only ANN admission must not acquire a writer"
        );
    }

    /// Pack-level lifecycle coverage for `start_rotation_watcher`'s
    /// production wiring (issue #2340): the rotation tests elsewhere in this
    /// crate call the private `refresh_rotated_segments_once` test helper
    /// directly, so nothing previously asserted that a writable `warm()`
    /// actually starts the tracked watcher, that a repeated `warm()` is
    /// idempotent, or that the watcher exits once its `AnnState` is dropped.
    /// Time is paused so the watcher's 5-second tick can be crossed
    /// deterministically instead of by a real sleep.
    #[tokio::test(start_paused = true)]
    #[serial_test::serial(background_tasks)]
    async fn writable_warm_starts_one_tracked_watcher_idempotently_and_it_exits_on_drop() {
        let dir = tempfile::tempdir().expect("tempdir");
        let config = RuntimeConfig {
            db_path: Some(dir.path().join("rotation-watcher-lifecycle.db")),
            embedding_model: Some(EmbeddingModel::AllMiniLmL6V2),
            additional_embedding_models: vec![],
            ..RuntimeConfig::no_embeddings()
        };
        let rt = KhiveRuntime::new(config).expect("writable runtime");
        let pack = KnowledgePack::new(rt);

        let before = khive_runtime::background_task_count();
        pack.warm().await;
        assert!(
            crate::knowledge::vamana::rotation_watch_started_for_test(&pack.ann),
            "a writable warm must start the rotation watcher"
        );
        assert_eq!(
            khive_runtime::background_task_count(),
            before + 1,
            "warm must track exactly one rotation watcher task"
        );

        // A repeated warm must not start a second tracked watcher.
        pack.warm().await;
        assert_eq!(
            khive_runtime::background_task_count(),
            before + 1,
            "a repeated warm must be idempotent and not start a second watcher"
        );

        // The watcher retains only a Weak<AnnState>; dropping every strong
        // reference lets its next tick observe the failed upgrade and exit.
        let ann_weak = std::sync::Arc::downgrade(&pack.ann);
        drop(pack);
        assert!(
            ann_weak.upgrade().is_none(),
            "dropping the pack must drop its last strong ANN reference"
        );

        // The watcher builds its interval on its first poll, which can land
        // after this advance; under paused time `sleep` auto-advances the
        // clock once every task is idle, so the tick is reached by virtual
        // time rather than by a fixed yield budget.
        tokio::time::advance(std::time::Duration::from_secs(6)).await;
        let deadline = tokio::time::Instant::now() + std::time::Duration::from_secs(60);
        while khive_runtime::background_task_count() != before {
            assert!(
                tokio::time::Instant::now() < deadline,
                "the watcher must exit once its ANN state is dropped"
            );
            tokio::time::sleep(std::time::Duration::from_millis(50)).await;
        }
        assert_eq!(
            khive_runtime::background_task_count(),
            before,
            "the watcher must exit once its ANN state is dropped"
        );
    }
}