khive-pack-knowledge 0.21.0

Knowledge verb pack — lore corpus (atoms/domains), TF-IDF retrieval, concept registration
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
use std::cell::RefCell;
use std::future::Future;
use std::pin::Pin;
use std::sync::{Arc, Mutex};

use super::index_handler::{read_catalogue_page, IndexCursor};
use crate::KnowledgePack;
use async_trait::async_trait;
use khive_pack_kg::KgPack;
use khive_runtime::{
    AllowAllGate, BackendId, EmbedderProvider, KhiveRuntime, RuntimeConfig, VerbRegistry,
    VerbRegistryBuilder,
};
use khive_types::Namespace;
use lattice_embed::{EmbedError, EmbeddingModel, EmbeddingService};
use serde_json::json;

const MODEL_KEY: &str = "all-minilm-l6-v2";
const DIM: usize = 384;
type EmbedCalls = Arc<Mutex<Vec<Vec<String>>>>;

struct FixedEmbedService {
    calls: EmbedCalls,
}

#[async_trait]
impl EmbeddingService for FixedEmbedService {
    async fn embed(
        &self,
        texts: &[String],
        _model: EmbeddingModel,
    ) -> std::result::Result<Vec<Vec<f32>>, EmbedError> {
        self.calls
            .lock()
            .expect("embedding calls")
            .push(texts.to_vec());
        Ok(texts
            .iter()
            .map(|_| {
                let mut vector = vec![0.0; DIM];
                vector[0] = 1.0;
                vector
            })
            .collect())
    }

    async fn embed_query(
        &self,
        texts: &[String],
        model: EmbeddingModel,
    ) -> std::result::Result<Vec<Vec<f32>>, EmbedError> {
        self.embed(texts, model).await
    }

    fn supports_model(&self, _model: EmbeddingModel) -> bool {
        true
    }

    fn name(&self) -> &'static str {
        "fixed-embed-service"
    }
}

struct FixedEmbedProvider {
    calls: EmbedCalls,
}

#[async_trait]
impl EmbedderProvider for FixedEmbedProvider {
    fn name(&self) -> &str {
        MODEL_KEY
    }

    fn dimensions(&self) -> usize {
        DIM
    }

    async fn build(
        &self,
    ) -> std::result::Result<Arc<dyn EmbeddingService>, khive_runtime::RuntimeError> {
        Ok(Arc::new(FixedEmbedService {
            calls: self.calls.clone(),
        }))
    }
}

fn runtime() -> (KhiveRuntime, Arc<VerbRegistry>, EmbedCalls) {
    let calls = Arc::new(Mutex::new(Vec::new()));
    let rt = KhiveRuntime::new(RuntimeConfig {
        wal_ceiling_bytes: 0,
        wal_ceiling_configured_bytes: 0,
        wal_ceiling_source: Default::default(),
        wal_ceiling_env_raw: None,
        web: Default::default(),
        telemetry: Default::default(),
        mounts: Vec::new(),
        brain: Default::default(),
        git_write: Default::default(),
        display_timezone: khive_runtime::config::resolve_default_display_timezone(),
        events_split: None,
        db_path: None,
        blob_hydration_bytes: khive_runtime::DEFAULT_BLOB_HYDRATION_BYTES,
        default_namespace: Namespace::local(),
        embedding_model: Some(EmbeddingModel::AllMiniLmL6V2),
        additional_embedding_models: vec![],
        gate: Arc::new(AllowAllGate),
        packs: vec!["kg".to_string(), "knowledge".to_string()],
        backend_id: BackendId::main(),
        brain_profile: None,
        visible_namespaces: vec![],
        allowed_outbound_namespaces: vec![],
        actor_id: None,
        exec: Default::default(),
        ..khive_runtime::RuntimeConfig::no_embeddings()
    })
    .expect("runtime");
    rt.register_embedder(FixedEmbedProvider {
        calls: calls.clone(),
    });
    let mut builder = VerbRegistryBuilder::new();
    builder.register(KgPack::new(rt.clone()));
    builder.register(KnowledgePack::new(rt.clone()));
    let registry = builder.build().expect("registry builds");
    registry.apply_schema_plans(rt.backend());
    rt.install_edge_rules(registry.all_edge_rules());
    (rt, Arc::new(registry), calls)
}

type AfterCapture = Pin<Box<dyn Future<Output = ()> + Send>>;

tokio::task_local! {
    static AFTER_CAPTURE: RefCell<Option<AfterCapture>>;
}

pub(super) async fn after_capture() {
    let action = AFTER_CAPTURE
        .try_with(|slot| slot.borrow_mut().take())
        .ok()
        .flatten();
    if let Some(action) = action {
        action.await;
    }
}

fn content(marker: &str) -> String {
    format!(
        "{marker} this private indexing fixture contains enough ordinary words to exercise \
         the accepted public atom write contract without external data or network access"
    )
}

fn atom(slug: &str, name: &str, marker: &str) -> serde_json::Value {
    json!({"slug": slug, "name": name, "content": content(marker)})
}

async fn seed_atom(registry: &VerbRegistry, slug: &str, name: &str, marker: &str) {
    let result = registry
        .dispatch(
            "knowledge.upsert_atoms",
            json!({"atoms": [atom(slug, name, marker)]}),
        )
        .await
        .expect("seed catalogue atom");
    assert_eq!(
        result["created"].as_u64(),
        Some(1),
        "valid new atom fixture"
    );
    let got = registry
        .dispatch("knowledge.get", json!({"id": slug}))
        .await
        .expect("read seeded atom");
    assert!(got["id"].as_str().is_some(), "seeded atom has an ID");
}

fn assert_counts(result: &serde_json::Value, total: u64, indexed: u64, skipped: u64) {
    assert_eq!(
        result["total"].as_u64(),
        Some(total),
        "captured catalogue total"
    );
    assert_eq!(
        result["indexed"].as_u64(),
        Some(indexed),
        "persisted catalogue vectors"
    );
    assert_eq!(
        result["skipped"].as_u64(),
        Some(skipped),
        "skipped captured atoms"
    );
    assert_eq!(result["failed"].as_u64(), Some(0));
}

#[tokio::test]
async fn catalogue_total_preserves_domain_mirror_population() {
    let (_runtime, registry, calls) = runtime();
    seed_atom(
        &registry,
        "catalogue-alpha",
        "Catalogue alpha",
        "cataloguebaselinealpha",
    )
    .await;
    seed_atom(
        &registry,
        "catalogue-beta",
        "Catalogue beta",
        "cataloguebaselinebeta",
    )
    .await;
    registry
        .dispatch(
            "knowledge.upsert_domains",
            json!({"domains": [{
                "slug": "catalogue-domain", "name": "Catalogue domain",
                "description": content("cataloguebaselinedomain"),
            }]}),
        )
        .await
        .expect("seed domain mirror");
    let domain = registry
        .dispatch("knowledge.get", json!({"id": "catalogue-domain"}))
        .await
        .expect("read domain mirror");
    assert!(domain["id"].as_str().is_some(), "domain mirror has an ID");
    calls.lock().expect("embedding calls").clear();

    let result = registry
        .dispatch("knowledge.index", json!({"batch_size": 2}))
        .await
        .expect("index unchanged catalogue");
    assert_counts(&result, 3, 3, 0);
    let calls = calls.lock().expect("embedding calls");
    assert_eq!(calls.iter().map(Vec::len).collect::<Vec<_>>(), vec![2, 1]);
    for marker in [
        "cataloguebaselinealpha",
        "cataloguebaselinebeta",
        "cataloguebaselinedomain",
    ] {
        assert_eq!(
            calls
                .iter()
                .flatten()
                .filter(|text| text.contains(marker))
                .count(),
            1,
            "each selected atom, including the domain mirror, is embedded once: {marker}"
        );
    }
}

#[tokio::test]
async fn catalogue_deleted_between_passes_is_skipped() {
    let (_runtime, registry, calls) = runtime();
    seed_atom(
        &registry,
        "catalogue-gone",
        "Catalogue gone",
        "cataloguedeletedmarker",
    )
    .await;
    seed_atom(
        &registry,
        "catalogue-kept",
        "Catalogue kept",
        "cataloguekeptmarker",
    )
    .await;
    calls.lock().expect("embedding calls").clear();
    let edit_registry = registry.clone();
    let edit_calls = calls.clone();
    let action: AfterCapture = Box::pin(async move {
        let deleted = edit_registry
            .dispatch("knowledge.delete_atoms", json!({"ids": ["catalogue-gone"]}))
            .await
            .expect("delete captured atom");
        assert_eq!(
            deleted["deleted"].as_u64(),
            Some(1),
            "valid between-pass delete"
        );
        edit_calls.lock().expect("embedding calls").clear();
    });
    let result = AFTER_CAPTURE
        .scope(
            RefCell::new(Some(action)),
            registry.dispatch("knowledge.index", json!({"batch_size": 1})),
        )
        .await
        .expect("index after captured atom deletion");
    assert_counts(&result, 2, 1, 1);
    let calls = calls.lock().expect("embedding calls");
    let texts: Vec<_> = calls.iter().flatten().collect();
    assert_eq!(texts.len(), 1);
    assert!(texts[0].contains("cataloguekeptmarker"));
    assert!(!texts[0].contains("cataloguedeletedmarker"));
}

#[tokio::test]
async fn catalogue_reload_uses_edits_and_excludes_new_ids() {
    let (_runtime, registry, calls) = runtime();
    seed_atom(
        &registry,
        "catalogue-edited",
        "Catalogue before",
        "cataloguebeforemarker",
    )
    .await;
    calls.lock().expect("embedding calls").clear();
    let edit_registry = registry.clone();
    let edit_calls = calls.clone();
    let action: AfterCapture = Box::pin(async move {
        let updated = edit_registry
            .dispatch(
                "knowledge.upsert_atoms",
                json!({"atoms": [atom("catalogue-edited", "Catalogue after", "catalogueaftermarker")]}),
            )
            .await
            .expect("edit captured atom");
        assert_eq!(updated["created"].as_u64(), Some(0));
        assert_eq!(
            updated["updated"].as_u64(),
            Some(1),
            "valid between-pass edit"
        );
        let got = edit_registry
            .dispatch("knowledge.get", json!({"id": "catalogue-edited"}))
            .await
            .expect("read edited atom");
        assert_eq!(got["name"], "Catalogue after");
        seed_atom(
            &edit_registry,
            "catalogue-new",
            "Catalogue new",
            "cataloguenewmarker",
        )
        .await;
        edit_calls.lock().expect("embedding calls").clear();
    });
    let result = AFTER_CAPTURE
        .scope(
            RefCell::new(Some(action)),
            registry.dispatch("knowledge.index", json!({"batch_size": 1})),
        )
        .await
        .expect("index late payload");
    assert_counts(&result, 1, 1, 0);
    {
        let calls = calls.lock().expect("embedding calls");
        let texts: Vec<_> = calls.iter().flatten().collect();
        assert_eq!(texts.len(), 1);
        assert!(
            texts[0].contains("catalogueaftermarker"),
            "embed edited payload"
        );
        assert!(!texts[0].contains("cataloguebeforemarker"));
        assert!(
            !texts[0].contains("cataloguenewmarker"),
            "new ID excluded from captured set"
        );
    }
    calls.lock().expect("embedding calls").clear();
    let next = registry
        .dispatch("knowledge.index", json!({"batch_size": 1}))
        .await
        .expect("next run includes newly created ID");
    assert_counts(&next, 2, 2, 0);
    let calls = calls.lock().expect("embedding calls");
    let texts: Vec<_> = calls.iter().flatten().collect();
    assert_eq!(texts.len(), 2);
    assert_eq!(
        texts
            .iter()
            .filter(|text| text.contains("catalogueaftermarker"))
            .count(),
        1
    );
    assert_eq!(
        texts
            .iter()
            .filter(|text| text.contains("cataloguenewmarker"))
            .count(),
        1
    );
}

#[tokio::test]
async fn catalogue_progress_reaches_total_when_all_captured_atoms_vanish() {
    let (runtime, registry, calls) = runtime();
    seed_atom(
        &registry,
        "catalogue-gone-a",
        "Catalogue gone A",
        "cataloguegoneamarker",
    )
    .await;
    seed_atom(
        &registry,
        "catalogue-gone-b",
        "Catalogue gone B",
        "cataloguegonebmarker",
    )
    .await;
    calls.lock().expect("embedding calls").clear();
    let edit_registry = registry.clone();
    let action: AfterCapture = Box::pin(async move {
        let deleted = edit_registry
            .dispatch(
                "knowledge.delete_atoms",
                json!({"ids": ["catalogue-gone-a", "catalogue-gone-b"]}),
            )
            .await
            .expect("delete every captured atom");
        assert_eq!(
            deleted["deleted"].as_u64(),
            Some(2),
            "valid all-skipped fixture"
        );
    });
    let token = runtime
        .authorize(Namespace::local())
        .expect("authorize local");
    let ann = super::vamana::new_shared();
    let progress = Mutex::new(Vec::new());
    let callback = |processed, total| {
        progress
            .lock()
            .expect("progress observations")
            .push((processed, total));
    };
    let result = AFTER_CAPTURE
        .scope(
            RefCell::new(Some(action)),
            super::KnowledgeHandlers::index(
                &runtime,
                &token,
                json!({"batch_size": 1}),
                &ann,
                Some(&callback),
            ),
        )
        .await
        .expect("index all-skipped catalogue with progress");
    assert_counts(&result, 2, 0, 2);
    assert!(calls.lock().expect("embedding calls").is_empty());
    let progress = progress.lock().expect("progress observations");
    assert_eq!(
        *progress,
        vec![(0, 2), (1, 2), (2, 2)],
        "processed skipped IDs reach total"
    );
    assert!(progress
        .iter()
        .all(|&(processed, total)| total == 2 && processed <= total));
    assert!(progress.windows(2).all(|pair| pair[0].0 <= pair[1].0));
}

#[tokio::test]
async fn catalogue_mixed_progress_counts_written_and_skipped_ids() {
    let (runtime, registry, calls) = runtime();
    seed_atom(
        &registry,
        "catalogue-mixed-gone",
        "Catalogue mixed gone",
        "cataloguemixedgonemarker",
    )
    .await;
    seed_atom(
        &registry,
        "catalogue-mixed-kept",
        "Catalogue mixed kept",
        "cataloguemixedkeptmarker",
    )
    .await;
    calls.lock().expect("embedding calls").clear();
    let edit_registry = registry.clone();
    let edit_calls = calls.clone();
    let action: AfterCapture = Box::pin(async move {
        let deleted = edit_registry
            .dispatch(
                "knowledge.delete_atoms",
                json!({"ids": ["catalogue-mixed-gone"]}),
            )
            .await
            .expect("delete one captured atom");
        assert_eq!(
            deleted["deleted"].as_u64(),
            Some(1),
            "valid mixed progress fixture"
        );
        edit_calls.lock().expect("embedding calls").clear();
    });
    let token = runtime
        .authorize(Namespace::local())
        .expect("authorize local");
    let ann = super::vamana::new_shared();
    let progress = Mutex::new(Vec::new());
    let callback = |processed, total| {
        progress
            .lock()
            .expect("progress observations")
            .push((processed, total));
    };
    let result = AFTER_CAPTURE
        .scope(
            RefCell::new(Some(action)),
            super::KnowledgeHandlers::index(
                &runtime,
                &token,
                json!({"batch_size": 2}),
                &ann,
                Some(&callback),
            ),
        )
        .await
        .expect("index mixed written and skipped catalogue");
    assert_counts(&result, 2, 1, 1);
    let calls = calls.lock().expect("embedding calls");
    let texts: Vec<_> = calls.iter().flatten().collect();
    assert_eq!(texts.len(), 1);
    assert!(texts[0].contains("cataloguemixedkeptmarker"));
    assert!(!texts[0].contains("cataloguemixedgonemarker"));
    let progress = progress.lock().expect("progress observations");
    assert_eq!(
        *progress,
        vec![(0, 2), (2, 2)],
        "written and skipped IDs both advance progress"
    );
    assert!(progress
        .iter()
        .all(|&(processed, total)| total == 2 && processed <= total));
    assert!(progress.windows(2).all(|pair| pair[0].0 <= pair[1].0));
}

#[tokio::test]
async fn catalogue_replacement_between_passes_does_not_enter_captured_set() {
    let (_runtime, registry, calls) = runtime();
    seed_atom(
        &registry,
        "catalogue-original",
        "Catalogue original",
        "catalogueoriginalmarker",
    )
    .await;
    let original = registry
        .dispatch("knowledge.get", json!({"id": "catalogue-original"}))
        .await
        .expect("read original captured ID");
    let original_id = original["id"]
        .as_str()
        .expect("original ID string")
        .to_owned();
    calls.lock().expect("embedding calls").clear();
    let edit_registry = registry.clone();
    let edit_calls = calls.clone();
    let action: AfterCapture = Box::pin(async move {
        let deleted = edit_registry
            .dispatch(
                "knowledge.delete_atoms",
                json!({"ids": ["catalogue-original"]}),
            )
            .await
            .expect("delete original captured atom");
        assert_eq!(
            deleted["deleted"].as_u64(),
            Some(1),
            "valid replacement deletion"
        );
        seed_atom(
            &edit_registry,
            "catalogue-replacement",
            "Catalogue replacement",
            "cataloguereplacementmarker",
        )
        .await;
        let replacement = edit_registry
            .dispatch("knowledge.get", json!({"id": "catalogue-replacement"}))
            .await
            .expect("read replacement ID");
        let replacement_id = replacement["id"].as_str().expect("replacement ID string");
        assert_ne!(
            replacement_id,
            original_id.as_str(),
            "replacement has a different ID"
        );
        edit_calls.lock().expect("embedding calls").clear();
    });
    let result = AFTER_CAPTURE
        .scope(
            RefCell::new(Some(action)),
            registry.dispatch("knowledge.index", json!({"batch_size": 1})),
        )
        .await
        .expect("index frozen ID set after replacement");
    assert_counts(&result, 1, 0, 1);
    assert!(
        calls.lock().expect("embedding calls").is_empty(),
        "replacement is not embedded in the captured run"
    );

    let next = registry
        .dispatch("knowledge.index", json!({"batch_size": 1}))
        .await
        .expect("fresh run captures replacement ID");
    assert_counts(&next, 1, 1, 0);
    let calls = calls.lock().expect("embedding calls");
    let texts: Vec<_> = calls.iter().flatten().collect();
    assert_eq!(texts.len(), 1);
    assert!(texts[0].contains("cataloguereplacementmarker"));
    assert!(!texts[0].contains("catalogueoriginalmarker"));
}

#[tokio::test]
async fn catalogue_batch_reload_probes_atoms_by_primary_key() {
    let (rt, _registry, _calls) = runtime();
    let reload = khive_runtime::sql!("knowledge_index_atom_batch");
    let plan = rt
        .backend()
        .pool_arc()
        .writer()
        .expect("writer")
        .autocommit(|connection| {
            let mut explain = connection
                .prepare(&format!("EXPLAIN QUERY PLAN {reload}"))
                .expect("plan prepares");
            let plan = explain
                .query_map(rusqlite::params!["local", "[\"a\",\"b\"]"], |row| {
                    row.get::<_, String>(3)
                })
                .expect("plan runs")
                .collect::<rusqlite::Result<Vec<String>>>()
                .expect("plan rows");
            Ok(plan)
        })
        .expect("plan");
    // The selected IDs drive the loop and each atom is one primary-key probe, so a
    // batch costs the same whatever the namespace holds.
    let selected = plan
        .iter()
        .position(|detail| detail.contains("selected"))
        .unwrap_or_else(|| panic!("selected IDs are scanned: {plan:?}"));
    let atom = plan
        .iter()
        .position(|detail| detail.starts_with("SEARCH atom") && detail.contains("(id=?)"))
        .unwrap_or_else(|| panic!("atoms are probed by primary key: {plan:?}"));
    assert!(selected < atom, "selected IDs drive the join: {plan:?}");
}

async fn seed_cursor_atom(registry: &VerbRegistry, slug: &str) -> String {
    seed_atom(registry, slug, slug, slug).await;
    registry
        .dispatch("knowledge.get", json!({"id": slug}))
        .await
        .expect("read cursor fixture atom")["id"]
        .as_str()
        .expect("cursor fixture ID")
        .to_owned()
}

fn set_cursor_created_at(runtime: &KhiveRuntime, id: &str, created_at: i64) {
    let updated = runtime
        .backend()
        .pool_arc()
        .writer()
        .expect("cursor fixture writer")
        .autocommit(|connection| {
            Ok(connection
                .execute(
                    "UPDATE knowledge_atoms SET created_at=?1 WHERE namespace='local' AND id=?2",
                    rusqlite::params![created_at, id],
                )
                .expect("set cursor fixture timestamp"))
        })
        .expect("cursor timestamp update");
    assert_eq!(updated, 1, "one public atom receives a fixture timestamp");
}

fn set_cursor_id(runtime: &KhiveRuntime, id: &str, replacement: &str) {
    let updated = runtime
        .backend()
        .pool_arc()
        .writer()
        .expect("raw cursor fixture writer")
        .autocommit(|connection| {
            Ok(connection
                .execute(
                    "UPDATE knowledge_atoms SET id=?1 WHERE namespace='local' AND id=?2",
                    rusqlite::params![replacement, id],
                )
                .expect("make raw ID undecodable"))
        })
        .expect("raw cursor fixture update");
    assert_eq!(updated, 1, "one raw row receives a fixture ID");
}

#[tokio::test]
async fn catalogue_cursor_visits_tied_timestamps_in_id_order_exactly_once() {
    let (runtime, registry, _calls) = runtime();
    let mut expected = Vec::new();
    for index in 0..5 {
        let id = seed_cursor_atom(&registry, &format!("cursor-tied-{index}")).await;
        set_cursor_created_at(&runtime, &id, 100);
        expected.push(id);
    }
    expected.sort();
    let first = read_catalogue_page(&runtime, "local", 2, None)
        .await
        .expect("first tied cursor page");
    assert_eq!(
        first.ids,
        expected[..2].to_vec(),
        "catalogue_cursor_first_page_orders_tied_ids"
    );
    let mut seen = first.ids;
    let mut cursor = first.cursor;
    for _ in 0..3 {
        let page = read_catalogue_page(&runtime, "local", 2, cursor.as_ref())
            .await
            .expect("next tied cursor page");
        let done = page.raw_len < 2;
        seen.extend(page.ids);
        cursor = page.cursor;
        if done {
            break;
        }
    }
    assert_eq!(
        seen, expected,
        "catalogue_cursor_ties_visit_every_live_id_once"
    );
}

#[tokio::test]
async fn catalogue_cursor_advances_from_last_raw_row_when_uuid_decode_skips_it() {
    let (runtime, registry, _calls) = runtime();
    let mut ids = Vec::new();
    for index in 0..3 {
        let id = seed_cursor_atom(&registry, &format!("cursor-raw-{index}")).await;
        set_cursor_created_at(&runtime, &id, index + 1);
        ids.push(id);
    }
    let bad_id = "cursor-middle-not-a-uuid";
    set_cursor_id(&runtime, &ids[1], bad_id);
    let first = read_catalogue_page(&runtime, "local", 2, None)
        .await
        .expect("raw cursor first page");
    assert_eq!(
        first.ids,
        vec![ids[0].clone()],
        "only valid UUIDs are captured"
    );
    assert_eq!(first.raw_len, 2, "raw page includes the undecodable row");
    assert_eq!(
        first.cursor,
        Some(IndexCursor {
            created_at: 2,
            id: bad_id.to_string(),
        }),
        "catalogue_cursor_uses_last_raw_row"
    );
    let next = read_catalogue_page(&runtime, "local", 2, first.cursor.as_ref())
        .await
        .expect("page after undecodable raw cursor");
    assert_eq!(next.ids, vec![ids[2].clone()], "later valid row is reached");
    assert_eq!(next.raw_len, 1);
}

#[tokio::test]
async fn catalogue_cursor_deleting_visited_prefix_does_not_skip_survivors() {
    let (runtime, registry, _calls) = runtime();
    let mut ids = Vec::new();
    for index in 0..4 {
        let id = seed_cursor_atom(&registry, &format!("cursor-delete-{index}")).await;
        set_cursor_created_at(&runtime, &id, index + 1);
        ids.push(id);
    }
    let first = read_catalogue_page(&runtime, "local", 2, None)
        .await
        .expect("cursor page before prefix deletion");
    assert_eq!(first.ids, ids[..2].to_vec(), "visited prefix is ordered");
    let deleted = registry
        .dispatch(
            "knowledge.delete_atoms",
            json!({"ids": ["cursor-delete-0"]}),
        )
        .await
        .expect("delete already visited cursor prefix");
    assert_eq!(deleted["deleted"].as_u64(), Some(1));
    let mut cursor = first.cursor;
    let mut later = Vec::new();
    for _ in 0..3 {
        let page = read_catalogue_page(&runtime, "local", 2, cursor.as_ref())
            .await
            .expect("cursor page after prefix deletion");
        let done = page.raw_len < 2;
        later.extend(page.ids);
        cursor = page.cursor;
        if done {
            break;
        }
    }
    assert_eq!(
        later,
        ids[2..].to_vec(),
        "catalogue_cursor_prefix_delete_keeps_later_live_rows_once"
    );
}

#[tokio::test]
async fn catalogue_cursor_empty_raw_and_all_invalid_pages_have_distinct_progress() {
    let (runtime, registry, _calls) = runtime();
    let empty = read_catalogue_page(&runtime, "local", 2, None)
        .await
        .expect("empty catalogue page");
    assert!(
        empty.ids.is_empty() && empty.raw_len == 0 && empty.cursor.is_none(),
        "catalogue_cursor_empty_catalogue_is_exhausted"
    );
    let mut ids = Vec::new();
    for index in 0..3 {
        let id = seed_cursor_atom(&registry, &format!("cursor-empty-{index}")).await;
        set_cursor_created_at(&runtime, &id, index + 1);
        ids.push(id);
    }
    set_cursor_id(&runtime, &ids[0], "cursor-invalid-first");
    set_cursor_id(&runtime, &ids[1], "cursor-invalid-second");
    let first = read_catalogue_page(&runtime, "local", 2, None)
        .await
        .expect("all-invalid decoded page");
    assert!(first.ids.is_empty());
    assert_eq!(first.raw_len, 2);
    assert_eq!(
        first.cursor,
        Some(IndexCursor {
            created_at: 2,
            id: "cursor-invalid-second".to_string(),
        }),
        "catalogue_cursor_all_invalid_page_keeps_raw_progress"
    );
    let next = read_catalogue_page(&runtime, "local", 2, first.cursor.as_ref())
        .await
        .expect("valid row after all-invalid decoded page");
    assert_eq!(next.ids, vec![ids[2].clone()]);
    assert_eq!(next.raw_len, 1);
}

#[tokio::test]
async fn catalogue_cursor_page_plans_use_cursor_index_and_range_bound() {
    let (runtime, _registry, _calls) = runtime();
    let first_sql = khive_runtime::sql!("knowledge_index_atom_page");
    let after_sql = khive_runtime::sql!("knowledge_index_atom_after");
    let (first, after) = runtime
        .backend()
        .pool_arc()
        .writer()
        .expect("cursor plan writer")
        .autocommit(|connection| {
            let mut statement = connection
                .prepare(&format!("EXPLAIN QUERY PLAN {first_sql}"))
                .expect("first cursor plan prepares");
            let first = statement
                .query_map(rusqlite::params!["local", 2], |row| row.get::<_, String>(3))
                .expect("first cursor plan runs")
                .collect::<rusqlite::Result<Vec<String>>>()
                .expect("first cursor plan rows");
            let mut statement = connection
                .prepare(&format!("EXPLAIN QUERY PLAN {after_sql}"))
                .expect("continuation cursor plan prepares");
            let after = statement
                .query_map(
                    rusqlite::params!["local", 2, 100, "00000000-0000-0000-0000-000000000001"],
                    |row| row.get::<_, String>(3),
                )
                .expect("continuation cursor plan runs")
                .collect::<rusqlite::Result<Vec<String>>>()
                .expect("continuation cursor plan rows");
            Ok((first, after))
        })
        .expect("cursor plans");
    for (shape, plan) in [("first", &first), ("after", &after)] {
        assert!(
            plan.iter()
                .any(|detail| detail.contains("idx_knowledge_atoms_cursor")),
            "catalogue_cursor_page_uses_cursor_index: {shape}: {plan:?}"
        );
        assert!(
            plan.iter()
                .all(|detail| !detail.to_ascii_uppercase().contains("TEMP B-TREE")),
            "catalogue_cursor_page_avoids_temporary_sort: {shape}: {plan:?}"
        );
    }
    assert!(
        after.iter().any(|detail| {
            let compact: String = detail.chars().filter(|ch| !ch.is_whitespace()).collect();
            compact.starts_with("SEARCH")
                && compact.contains("idx_knowledge_atoms_cursor")
                && (compact.contains("(created_at,id)>(?,?)") || compact.contains("created_at>?"))
        }),
        "catalogue_cursor_continuation_is_range_bounded: {after:?}"
    );
}