khive-pack-knowledge 0.16.0

Knowledge verb pack — lore corpus (atoms/domains), TF-IDF retrieval, concept registration
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
// Gate wiring tests: confirm that the secret check integrated into
// upsert_atoms fires on credential-shaped atom content and passes on
// allowlisted content (sha256 hex, UUIDs).  Tests call
// `khive_runtime::secret_gate::check` directly with the same inputs
// that the handler would pass — this proves the gate is reachable without
// requiring a live DB connection.

use khive_runtime::secret_gate::check;
use khive_runtime::{KhiveRuntime, VerbRegistryBuilder};
use khive_storage::SqlValue;

#[test]
fn key_only_list_projection_does_not_select_atom_content() {
    let fields = vec!["id".to_string(), "slug".to_string()];
    let columns = super::list_select_columns(Some(&fields));
    assert_eq!(columns, "id, slug, created_at");
    assert!(!columns.contains("content"));
}

#[tokio::test]
async fn get_prefix_query_plan_uses_primary_key_range_seeks() {
    let runtime = KhiveRuntime::memory().expect("memory runtime");
    let mut builder = VerbRegistryBuilder::new();
    builder.register(khive_pack_kg::KgPack::new(runtime.clone()));
    builder.register(crate::KnowledgePack::new(runtime.clone()));
    let registry = builder.build().expect("registry builds");
    registry.apply_schema_plans(runtime.backend());

    let mut reader = runtime.sql().reader().await.expect("prefix plan reader");
    let rows = reader
        .explain(
            super::knowledge_get_prefix_statement("0b6cf134").expect("valid compact UUID prefix"),
        )
        .await
        .expect("explain knowledge prefix query");
    let details: Vec<String> = rows
        .iter()
        .filter_map(|row| match row.get("detail") {
            Some(SqlValue::Text(detail)) => Some(detail.clone()),
            _ => None,
        })
        .collect();

    assert!(
        ["knowledge_domains", "knowledge_atoms"]
            .iter()
            .all(|table| {
                details.iter().any(|detail| {
                    detail.contains(&format!("SEARCH {table}"))
                        && detail.contains("id>?")
                        && detail.contains("id<?")
                }) && !details
                    .iter()
                    .any(|detail| detail.contains(&format!("SCAN {table}")))
            }),
        "knowledge.get short-id tables must use primary-key range seeks: {details:?}"
    );
}

/// `delete_atoms` matches ids and slugs with one statement per column. A
/// single `id IN (..) OR slug IN (..)` predicate makes the no-statistics
/// planner scan the namespace, so a full chunk must still seek an index.
#[tokio::test]
async fn delete_atoms_key_statements_seek_an_index_at_a_full_chunk() {
    let runtime = KhiveRuntime::memory().expect("memory runtime");
    let keys: Vec<String> = (0..super::HYDRATION_ID_CHUNK)
        .map(|i| format!("key-{i}"))
        .collect();
    let mut reader = runtime.sql().reader().await.expect("plan reader");

    for table in ["knowledge_atoms", "knowledge_domains"] {
        let head = format!("SELECT id, slug FROM {table}");
        let lead = vec![SqlValue::Text("local".into())];
        let [by_id, by_slug] = super::key_match_statements(&head, lead, &keys);
        assert_eq!(by_id.params.len(), super::HYDRATION_ID_CHUNK + 1);
        assert_eq!(by_slug.params.len(), super::HYDRATION_ID_CHUNK + 1);

        for (statement, index) in [
            (by_id, format!("sqlite_autoindex_{table}_1")),
            (by_slug, format!("idx_{table}_ns_slug")),
        ] {
            let rows = reader.explain(statement).await.expect("explain statement");
            let details: Vec<String> = rows
                .iter()
                .filter_map(|row| match row.get("detail") {
                    Some(SqlValue::Text(detail)) => Some(detail.clone()),
                    _ => None,
                })
                .collect();
            assert!(
                details
                    .iter()
                    .any(|detail| detail.contains(&format!("USING INDEX {index}"))),
                "{table} key match must seek {index}: {details:?}"
            );
            assert!(
                !details.iter().any(|detail| detail.contains("SCAN")),
                "{table} key match must not scan: {details:?}"
            );
        }
    }
}

#[test]
fn atom_body_with_fake_aws_key_is_blocked() {
    // Fake AWS access key ID in an atom body — must be blocked.
    let body = "provider: aws\naccess_key_id: AKIAFAKE000000000000\nregion: us-east-1";
    assert!(
        check(body).is_err(),
        "atom body containing fake AWS key must be blocked"
    );
}

#[test]
fn atom_body_with_sha256_hash_passes() {
    // A manifest-style line containing a sha256 digest — must pass the allowlist.
    let body = "checksum = \"e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855\"";
    assert!(
        check(body).is_ok(),
        "atom body with sha256 manifest hash must pass; fired: {:?}",
        check(body).err()
    );
}

#[test]
fn atom_name_with_fake_openai_key_is_blocked() {
    // A credential accidentally used as an atom name — must be blocked.
    let name = format!("sk-proj-{}", "A".repeat(80));
    assert!(
        check(&name).is_err(),
        "atom name containing fake OpenAI key must be blocked"
    );
}

#[test]
fn normal_atom_name_passes() {
    let name = "FlashAttention-2: efficient transformer self-attention";
    assert!(
        check(name).is_ok(),
        "normal atom name must pass; fired: {:?}",
        check(name).err()
    );
}

// Ignored-param warning coverage: verify that chunk_size and cascade are still
// accepted by the param structs (no deserialization error) and that the fields
// are Some when supplied, confirming the warning branch precondition is satisfiable.

#[test]
fn upsert_atoms_chunk_size_accepted_and_detectable() {
    use crate::knowledge::schema::UpsertAtomsParams;
    let p: UpsertAtomsParams = serde_json::from_value(serde_json::json!({
        "atoms": [{"slug": "s", "name": "n", "content": "placeholder content for test"}],
        "chunk_size": 100,
    }))
    .expect("upsert_atoms params with chunk_size must deserialize without error");
    assert!(
        p.chunk_size.is_some(),
        "chunk_size must be Some when supplied so the warning branch precondition is satisfiable"
    );
}

#[test]
fn delete_atoms_cascade_accepted_and_detectable() {
    use crate::knowledge::schema::DeleteAtomsParams;
    let p: DeleteAtomsParams = serde_json::from_value(serde_json::json!({
        "ids": ["some-atom-id"],
        "cascade": true,
    }))
    .expect("delete_atoms params with cascade must deserialize without error");
    assert!(
        p.cascade.is_some(),
        "cascade must be Some when supplied so the warning branch precondition is satisfiable"
    );
}

// The real implementation receives its normal SQL provider in production. These
// fixtures replace only that capability, never token minting or handler logic.
#[derive(Clone, Copy)]
enum AtomicFault {
    Healthy,
    TargetRead,
    NotStarted,
    RolledBackContract,
    CommitThenUnknown,
}

struct AtomicSql {
    inner: std::sync::Arc<dyn khive_storage::SqlAccess>,
    fault: AtomicFault,
    batches: std::sync::Arc<std::sync::atomic::AtomicUsize>,
}
struct AtomicReader {
    inner: Box<dyn khive_storage::SqlReader>,
    fault: AtomicFault,
}
struct AtomicWriter {
    inner: Box<dyn khive_storage::SqlWriter>,
    fault: AtomicFault,
    batches: std::sync::Arc<std::sync::atomic::AtomicUsize>,
}

#[async_trait::async_trait]
impl khive_storage::SqlReader for AtomicReader {
    async fn query_row(
        &mut self,
        statement: khive_storage::SqlStatement,
    ) -> khive_storage::StorageResult<Option<khive_storage::types::SqlRow>> {
        if matches!(self.fault, AtomicFault::TargetRead)
            && statement.sql == khive_runtime::sql!("knowledge_target_domain_probe")
        {
            return Err(khive_storage::StorageError::Internal(
                "fixture-target-reader-interrupted".into(),
            ));
        }
        self.inner.query_row(statement).await
    }
    async fn query_all(
        &mut self,
        statement: khive_storage::SqlStatement,
    ) -> khive_storage::StorageResult<Vec<khive_storage::types::SqlRow>> {
        self.inner.query_all(statement).await
    }
    async fn query_scalar(
        &mut self,
        statement: khive_storage::SqlStatement,
    ) -> khive_storage::StorageResult<Option<SqlValue>> {
        self.inner.query_scalar(statement).await
    }
    async fn explain(
        &mut self,
        statement: khive_storage::SqlStatement,
    ) -> khive_storage::StorageResult<Vec<khive_storage::types::SqlRow>> {
        self.inner.explain(statement).await
    }
}
#[async_trait::async_trait]
impl khive_storage::SqlReader for AtomicWriter {
    async fn query_row(
        &mut self,
        statement: khive_storage::SqlStatement,
    ) -> khive_storage::StorageResult<Option<khive_storage::types::SqlRow>> {
        self.inner.query_row(statement).await
    }
    async fn query_all(
        &mut self,
        statement: khive_storage::SqlStatement,
    ) -> khive_storage::StorageResult<Vec<khive_storage::types::SqlRow>> {
        self.inner.query_all(statement).await
    }
    async fn query_scalar(
        &mut self,
        statement: khive_storage::SqlStatement,
    ) -> khive_storage::StorageResult<Option<SqlValue>> {
        self.inner.query_scalar(statement).await
    }
    async fn explain(
        &mut self,
        statement: khive_storage::SqlStatement,
    ) -> khive_storage::StorageResult<Vec<khive_storage::types::SqlRow>> {
        self.inner.explain(statement).await
    }
}
#[async_trait::async_trait]
impl khive_storage::SqlWriter for AtomicWriter {
    async fn execute(
        &mut self,
        statement: khive_storage::SqlStatement,
    ) -> khive_storage::StorageResult<u64> {
        self.inner.execute(statement).await
    }
    async fn execute_batch(
        &mut self,
        statements: Vec<khive_storage::SqlStatement>,
    ) -> khive_storage::StorageResult<u64> {
        use khive_storage::{StorageError, WriterTaskRequestState};
        self.batches
            .fetch_add(1, std::sync::atomic::Ordering::SeqCst);
        match self.fault {
            AtomicFault::NotStarted => Err(StorageError::writer_task_terminated(
                WriterTaskRequestState::NotStarted,
            )),
            AtomicFault::RolledBackContract => Err(StorageError::WriterTaskRequestFailed {
                request_state: WriterTaskRequestState::TransactionRolledBack,
                source: Box::new(StorageError::Internal("fixture-rollback-contract".into())),
            }),
            AtomicFault::CommitThenUnknown => {
                self.inner.execute_batch(statements).await?;
                Err(StorageError::writer_task_terminated(
                    WriterTaskRequestState::SideEffectsUnknown,
                ))
            }
            _ => self.inner.execute_batch(statements).await,
        }
    }
    async fn execute_script(&mut self, script: String) -> khive_storage::StorageResult<()> {
        self.inner.execute_script(script).await
    }
}
#[async_trait::async_trait]
impl khive_storage::SqlAccess for AtomicSql {
    fn database_path(&self) -> Option<std::path::PathBuf> {
        self.inner.database_path()
    }
    async fn reader(&self) -> khive_storage::StorageResult<Box<dyn khive_storage::SqlReader>> {
        Ok(Box::new(AtomicReader {
            inner: self.inner.reader().await?,
            fault: self.fault,
        }))
    }
    async fn writer(&self) -> khive_storage::StorageResult<Box<dyn khive_storage::SqlWriter>> {
        Ok(Box::new(AtomicWriter {
            inner: self.inner.writer().await?,
            fault: self.fault,
            batches: self.batches.clone(),
        }))
    }
    async fn atomic_unit(
        &self,
        op: khive_storage::AtomicUnitOp,
    ) -> khive_storage::StorageResult<Box<dyn std::any::Any + Send>> {
        self.inner.atomic_unit(op).await
    }
}

const ATOMIC_CONTENT: &str = "dense sparse retrieval corpus benchmark search latency gradient descent transformer attention vector index nearest neighbor ranking fusion pipeline embedding rerank cosine similarity";
fn atomic_runtime() -> (KhiveRuntime, khive_runtime::NamespaceToken) {
    let runtime = KhiveRuntime::new(khive_runtime::RuntimeConfig {
        db_path: None,
        actor_id: Some("atomic-write-fixture".into()),
        packs: vec!["kg".into(), "knowledge".into()],
        ..khive_runtime::RuntimeConfig::no_embeddings()
    })
    .unwrap();
    let mut builder = VerbRegistryBuilder::new();
    builder.register(khive_pack_kg::KgPack::new(runtime.clone()));
    builder.register(crate::KnowledgePack::new(runtime.clone()));
    let registry = builder.build().unwrap();
    registry.apply_schema_plans(runtime.backend());
    runtime.install_edge_rules(registry.all_edge_rules());
    let token = runtime
        .authorize(khive_types::Namespace::local())
        .expect("real Gate-approved fixture token");
    (runtime, token)
}
fn atomic_params() -> serde_json::Value {
    serde_json::json!({"atoms":[
        {"slug":"atomic-first","name":"First","content":ATOMIC_CONTENT},
        {"slug":"atomic-second","name":"Second","content":ATOMIC_CONTENT}
    ]})
}
async fn atomic_rows(runtime: &KhiveRuntime) -> serde_json::Value {
    let mut reader = runtime.sql().reader().await.unwrap();
    serde_json::to_value(
        reader
            .query_all(khive_storage::SqlStatement {
                sql: "SELECT * FROM knowledge_atoms ORDER BY id".into(),
                params: vec![],
                label: None,
            })
            .await
            .unwrap(),
    )
    .unwrap()
}
fn atomic_sql(
    runtime: &KhiveRuntime,
    fault: AtomicFault,
) -> (
    std::sync::Arc<dyn khive_storage::SqlAccess>,
    std::sync::Arc<std::sync::atomic::AtomicUsize>,
) {
    let batches = std::sync::Arc::new(std::sync::atomic::AtomicUsize::new(0));
    (
        std::sync::Arc::new(AtomicSql {
            inner: runtime.sql(),
            fault,
            batches: batches.clone(),
        }),
        batches,
    )
}

#[tokio::test]
async fn atomic_admission_interruption_reports_exact_unchecked_indices() {
    let (runtime, token) = atomic_runtime();
    let before = atomic_rows(&runtime).await;
    let (sql, batches) = atomic_sql(&runtime, AtomicFault::TargetRead);
    let params = serde_json::json!({"atoms":[
        {"slug":"bad-before","name":"Bad","content":"short"},
        {"slug":"good-before","name":"Good","content":ATOMIC_CONTENT},
        {"id":"6ab81527-ccdf-4c99-a898-4cb032829d89","properties":{}},
        {"slug":"bad-after","name":"Bad","content":"short"},
        {"slug":"unchecked-after","name":"Good","content":ATOMIC_CONTENT}
    ]});
    let error =
        super::KnowledgeHandlers::upsert_atoms_with_sql(&runtime, &token, params, false, sql)
            .await
            .unwrap_err();
    assert!(
        matches!(error.refusal_source(), khive_runtime::RuntimeError::Storage(khive_storage::StorageError::Internal(message)) if message == "fixture-target-reader-interrupted")
    );
    let value =
        khive_runtime::runtime_error_value(error, khive_runtime::DomainDisposition::Unknown);
    assert_eq!(value["domain_disposition"], "not_committed");
    assert_eq!(value["validation_complete"], false);
    assert_eq!(value["unchecked_indices"], serde_json::json!([2, 4]));
    assert_eq!(
        value["refused"],
        serde_json::json!([
            {"index":0,"field":"content","reason":"invalid_input"},
            {"index":3,"field":"content","reason":"invalid_input"}
        ])
    );
    assert_eq!(batches.load(std::sync::atomic::Ordering::SeqCst), 0);
    assert_eq!(atomic_rows(&runtime).await, before);
}

#[tokio::test]
async fn atomic_write_settlement_preserves_typed_states_and_real_unknown_commit() {
    use khive_storage::WriterTaskRequestState;
    for (fault, expected_state, disposition, committed) in [
        (
            AtomicFault::NotStarted,
            WriterTaskRequestState::NotStarted,
            "not_committed",
            false,
        ),
        (
            AtomicFault::RolledBackContract,
            WriterTaskRequestState::TransactionRolledBack,
            "not_committed",
            false,
        ),
        (
            AtomicFault::CommitThenUnknown,
            WriterTaskRequestState::SideEffectsUnknown,
            "unknown",
            true,
        ),
    ] {
        let (runtime, token) = atomic_runtime();
        let before = atomic_rows(&runtime).await;
        let (sql, batches) = atomic_sql(&runtime, fault);
        let error = super::KnowledgeHandlers::upsert_atoms_with_sql(
            &runtime,
            &token,
            atomic_params(),
            false,
            sql,
        )
        .await
        .unwrap_err();
        assert!(
            matches!(
                error.refusal_source(),
                khive_runtime::RuntimeError::Storage(_)
            ),
            "typed original storage error survives"
        );
        assert_eq!(
            error.writer_task_failure_context().unwrap().request_state,
            expected_state
        );
        assert_eq!(batches.load(std::sync::atomic::Ordering::SeqCst), 1);
        let after = atomic_rows(&runtime).await;
        if committed {
            assert_eq!(
                after.as_array().unwrap().len(),
                2,
                "lost acknowledgement follows a REAL committed batch"
            );
        } else {
            assert_eq!(after, before);
        }
        let value =
            khive_runtime::runtime_error_value(error, khive_runtime::DomainDisposition::Unknown);
        assert_eq!(value["domain_disposition"], disposition);
        assert_eq!(value["request_state"], expected_state.to_string());
        if matches!(fault, AtomicFault::RolledBackContract) {
            assert!(value["message"]
                .as_str()
                .unwrap()
                .contains("fixture-rollback-contract"));
        }
    }
    let (runtime, token) = atomic_runtime();
    let (sql, batches) = atomic_sql(&runtime, AtomicFault::Healthy);
    let value = super::KnowledgeHandlers::upsert_atoms_with_sql(
        &runtime,
        &token,
        atomic_params(),
        false,
        sql,
    )
    .await
    .unwrap();
    assert_eq!(
        value,
        serde_json::json!({"created":2,"updated":0,"total":2})
    );
    assert_eq!(batches.load(std::sync::atomic::Ordering::SeqCst), 1);
    assert_eq!(atomic_rows(&runtime).await.as_array().unwrap().len(), 2);
}

#[tokio::test]
async fn atomic_real_batch_failure_rolls_back_requested_rows() {
    let (runtime, token) = atomic_runtime();
    let before = atomic_rows(&runtime).await;
    {
        let mut writer = runtime.sql().writer().await.unwrap();
        writer.execute(khive_storage::SqlStatement { sql: "CREATE TRIGGER reject_atomic_second BEFORE INSERT ON knowledge_atoms WHEN NEW.slug = 'atomic-second' BEGIN SELECT RAISE(ABORT, 'ATOMIC-REAL-ROLLBACK'); END".into(), params: vec![], label: None }).await.unwrap();
    }
    let error = super::KnowledgeHandlers::upsert_atoms_with_sql(
        &runtime,
        &token,
        atomic_params(),
        false,
        runtime.sql(),
    )
    .await
    .unwrap_err();
    assert!(matches!(
        error.refusal_source(),
        khive_runtime::RuntimeError::Storage(_)
    ));
    assert_eq!(
        atomic_rows(&runtime).await,
        before,
        "actual earlier statement rolls back with the later fault"
    );
    assert!(error.to_string().contains("ATOMIC-REAL-ROLLBACK"));
    assert_eq!(
        error
            .writer_task_failure_context()
            .map(|context| context.request_state),
        Some(khive_storage::WriterTaskRequestState::TransactionRolledBack)
    );
    let value =
        khive_runtime::runtime_error_value(error, khive_runtime::DomainDisposition::Unknown);
    assert_eq!(value["domain_disposition"], "not_committed");
    {
        let mut writer = runtime.sql().writer().await.unwrap();
        writer
            .execute(khive_storage::SqlStatement {
                sql: "DROP TRIGGER reject_atomic_second".into(),
                params: vec![],
                label: None,
            })
            .await
            .unwrap();
    }
    super::KnowledgeHandlers::upsert_atoms_with_sql(
        &runtime,
        &token,
        atomic_params(),
        false,
        runtime.sql(),
    )
    .await
    .unwrap();
    assert_eq!(atomic_rows(&runtime).await.as_array().unwrap().len(), 2);
}