kftray-http-logs 0.27.16

HTTP logging library for KFtray
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
use std::sync::Arc;

use anyhow::Result;
use bytes::Bytes;
use tokio::sync::Mutex;
use tokio::time::{
    Duration,
    Instant,
};
use tracing::{
    debug,
    error,
    trace,
};

fn find_headers_end(data: &[u8]) -> Option<usize> {
    data.windows(4).position(|w| w == b"\r\n\r\n")
}

use crate::HttpLogger;
use crate::http_response_analyzer::{
    HttpResponseAnalyzer,
    ResponseAnalyzerConfig,
};

pub const DEFAULT_MIN_LOG_SYNC_MS: u64 = 50;

pub struct ResponseLoggingState {
    pub complete_response: Vec<u8>,
    pub already_logged: bool,
    pub logging_enabled: bool,
    pub is_chunked: bool,
}

impl Default for ResponseLoggingState {
    fn default() -> Self {
        Self::new()
    }
}

impl ResponseLoggingState {
    pub fn new() -> Self {
        Self {
            complete_response: Vec::new(),
            already_logged: false,
            logging_enabled: false,
            is_chunked: false,
        }
    }
}

pub struct ResponseChunkContext {
    pub complete_response: Vec<u8>,
    pub is_chunked: bool,
    pub found_end_marker: bool,
    pub total_chunks_received: usize,
    pub response_logged: Arc<Mutex<bool>>,
    pub request_id: Arc<Mutex<Option<String>>>,
}

impl ResponseChunkContext {
    pub fn new(response_logged: Arc<Mutex<bool>>, request_id: Arc<Mutex<Option<String>>>) -> Self {
        Self {
            complete_response: Vec::new(),
            is_chunked: false,
            found_end_marker: false,
            total_chunks_received: 0,
            response_logged,
            request_id,
        }
    }
}

pub struct ResponseLoggingContext {
    pub complete_response: Vec<u8>,
    pub is_chunked: bool,
    pub found_end_marker: bool,
    pub response_logged: Arc<Mutex<bool>>,
    pub request_id: Arc<Mutex<Option<String>>>,
    pub first_chunk_time: Option<Instant>,
}

#[derive(Debug, Clone)]
pub struct ResponseHandlerConfig {
    pub analyzer_config: ResponseAnalyzerConfig,
    pub min_log_sync_ms: u64,
}

impl Default for ResponseHandlerConfig {
    fn default() -> Self {
        Self {
            analyzer_config: ResponseAnalyzerConfig::default(),
            min_log_sync_ms: DEFAULT_MIN_LOG_SYNC_MS,
        }
    }
}

#[derive(Debug, Clone)]
pub struct HttpResponseHandler {
    config_id: i64,
    analyzer: HttpResponseAnalyzer,
    config: ResponseHandlerConfig,
}

impl HttpResponseHandler {
    pub fn new(config_id: i64) -> Self {
        Self::with_config(config_id, ResponseHandlerConfig::default())
    }

    pub fn with_config(config_id: i64, config: ResponseHandlerConfig) -> Self {
        Self {
            config_id,
            analyzer: HttpResponseAnalyzer::new(config.analyzer_config.clone()),
            config,
        }
    }

    pub fn config(&self) -> &ResponseHandlerConfig {
        &self.config
    }

    pub async fn check_response_logging_status(
        &self, buffer: &[u8], n: usize, state: &mut ResponseLoggingState,
    ) -> Result<()> {
        let is_enabled =
            match kftray_commons::utils::http_logs_config::get_http_logs_config(self.config_id)
                .await
            {
                Ok(config) => config.enabled,
                Err(_) => false,
            };

        if is_enabled {
            state.logging_enabled = true;
            state.already_logged = true;

            if n > 0 {
                state.complete_response.extend_from_slice(&buffer[..n]);

                if let Some(headers_end) = find_headers_end(&state.complete_response) {
                    let headers_data = &state.complete_response[..headers_end];
                    state.is_chunked = Self::is_chunked_transfer(headers_data);
                }
            }
        } else {
            state.already_logged = true;
        }

        Ok(())
    }

    pub async fn process_response_chunk(
        &self, buffer: &[u8], n: usize, context: &mut ResponseChunkContext,
        logger: &Option<HttpLogger>,
    ) -> Result<()> {
        context.complete_response.extend_from_slice(&buffer[..n]);
        context.total_chunks_received += 1;

        let response_size = context.complete_response.len();
        trace!(
            "Processing response chunk #{}: {}B, total: {}B",
            context.total_chunks_received, n, response_size
        );

        if !context.is_chunked
            && let Some(headers_end) = find_headers_end(&context.complete_response)
        {
            let headers_data = &context.complete_response[..headers_end];
            context.is_chunked = Self::is_chunked_transfer(headers_data);
        }

        if context.is_chunked && !context.found_end_marker {
            context.found_end_marker =
                HttpResponseAnalyzer::has_chunked_end_marker(&context.complete_response);
            if context.found_end_marker {
                debug!(
                    "Found end marker in chunked response after {} chunks, {}B",
                    context.total_chunks_received, response_size
                );

                let mut logging_context = ResponseLoggingContext {
                    complete_response: std::mem::take(&mut context.complete_response),
                    is_chunked: context.is_chunked,
                    found_end_marker: context.found_end_marker,
                    response_logged: context.response_logged.clone(),
                    request_id: context.request_id.clone(),
                    first_chunk_time: None,
                };

                let result = self
                    .check_and_log_complete_response(&mut logging_context, logger)
                    .await;

                // Restore the complete_response
                context.complete_response = logging_context.complete_response;

                result?;
            }
        }

        Ok(())
    }

    pub async fn check_and_log_complete_response(
        &self, context: &mut ResponseLoggingContext, logger: &Option<HttpLogger>,
    ) -> Result<()> {
        let mut response_logged_guard = context.response_logged.lock().await;

        if !context.complete_response.is_empty() && !*response_logged_guard {
            let should_log = if context.is_chunked {
                context.found_end_marker
                    || self.analyzer.is_ready_for_logging_with_config(
                        &context.complete_response,
                        context.is_chunked,
                        context.found_end_marker,
                    )
            } else if let Some(start_time) = context.first_chunk_time {
                self.check_time_based_logging(&context.complete_response, start_time)
            } else {
                self.analyzer.appears_complete(
                    &context.complete_response,
                    context.is_chunked,
                    context.found_end_marker,
                )
            };

            if should_log {
                debug!(
                    "Logging complete response: {}B, chunked: {}, end marker: {}",
                    context.complete_response.len(),
                    context.is_chunked,
                    context.found_end_marker
                );

                self.log_response(
                    &mut context.complete_response,
                    &context.response_logged,
                    &context.request_id,
                    logger,
                )
                .await?;

                *response_logged_guard = true;
            }
        }

        Ok(())
    }

    fn check_time_based_logging(&self, response_data: &[u8], start_time: Instant) -> bool {
        if let Some(headers_end) = find_headers_end(response_data) {
            let headers = &response_data[..headers_end];

            if response_data.len() > headers_end + 4
                && let Ok(headers_str) = std::str::from_utf8(headers)
            {
                let h_lower = headers_str.to_lowercase();
                if h_lower.contains("upgrade: websocket") && h_lower.contains("connection: upgrade")
                {
                    if h_lower.contains("sec-websocket-accept:") {
                        debug!(
                            "Logging WebSocket upgrade response immediately - complete with all required headers"
                        );
                        return true;
                    } else {
                        debug!(
                            "Potential WebSocket upgrade response detected but missing accept header"
                        );
                    }
                }
            }

            if let Ok(headers_str) = std::str::from_utf8(headers) {
                let first_line = headers_str.lines().next().unwrap_or("");
                let parts: Vec<&str> = first_line.split_whitespace().collect();
                if parts.len() >= 2
                    && let Ok(status) = parts[1].parse::<u16>()
                    && ((100..200).contains(&status) || status == 204 || status == 304)
                {
                    debug!("Logging status {} response which never has a body", status);
                    return true;
                }
            }

            if std::str::from_utf8(headers)
                .map(|h| h.to_lowercase().contains("connection: close"))
                .unwrap_or(false)
            {
                debug!("Connection: close header found, logging response at connection end");
                return true;
            }

            if let Ok(headers_str) = std::str::from_utf8(headers)
                && headers_str.starts_with("HTTP/1.0")
                && !headers_str.to_lowercase().contains("content-length:")
                && !headers_str
                    .to_lowercase()
                    .contains("transfer-encoding: chunked")
            {
                debug!("HTTP/1.0 response without length indicators - logging at connection end");
                return true;
            }

            let elapsed = start_time.elapsed();
            if elapsed.as_secs() >= 10 && response_data.len() > 5000 {
                debug!(
                    "Long-lived connection detected ({}s, {}B) - logging accumulated data to prevent being stuck",
                    elapsed.as_secs(),
                    response_data.len()
                );
                return true;
            }

            if response_data.len() > 1_000_000 {
                debug!(
                    "Large response detected ({}B) - logging to prevent memory issues",
                    response_data.len()
                );
                return true;
            }

            if response_data.len() > 100_000 && elapsed.as_secs() > 30 {
                debug!(
                    "Long-running HTTP stream detected ({}s, {}B) - forcing log",
                    elapsed.as_secs(),
                    response_data.len()
                );
                return true;
            }
        }

        false
    }

    async fn format_response_for_logging(&self, response_data: &[u8]) -> Result<String> {
        debug!(
            "Formatting response for logging, size: {} bytes",
            response_data.len()
        );

        if let Some(headers_end) = find_headers_end(response_data) {
            debug!("Found headers end at position: {}", headers_end);

            let headers_bytes = &response_data[..headers_end];
            let body_start = headers_end + 4;
            let body = &response_data[body_start..];

            debug!(
                "Headers size: {} bytes, Body size: {} bytes",
                headers_bytes.len(),
                body.len()
            );

            let (status, headers) = match crate::parser::ResponseParser::parse(headers_bytes) {
                Ok((status, headers)) => {
                    debug!(
                        "Successfully parsed headers, status: {:?}, headers count: {}",
                        status,
                        headers.len()
                    );
                    (status, headers)
                }
                Err(e) => {
                    error!("Failed to parse headers: {:?}", e);
                    return Err(e);
                }
            };

            let mut formatted = String::new();
            if let Some(_status_code) = status {
                let status_line = match std::str::from_utf8(
                    &headers_bytes[..headers_bytes
                        .windows(2)
                        .position(|w| w == b"\r\n")
                        .unwrap_or(headers_bytes.len())],
                ) {
                    Ok(line) => {
                        debug!("Status line: {}", line);
                        line
                    }
                    Err(e) => {
                        error!("Failed to convert status line to UTF-8: {:?}", e);
                        "HTTP/1.1 200 OK"
                    }
                };
                formatted.push_str(status_line);
                formatted.push('\n');
            } else {
                debug!("No status line found, adding default");
                formatted.push_str("HTTP/1.1 200 OK\n");
            }

            for header in &headers {
                if let (Ok(name), Ok(value)) = (
                    std::str::from_utf8(header.name.as_bytes()),
                    std::str::from_utf8(header.value),
                ) {
                    formatted.push_str(&format!("{name}: {value}\n"));
                }
            }
            formatted.push('\n');

            if !body.is_empty() {
                debug!("Processing response body with size: {} bytes", body.len());

                let is_chunked = crate::parser::RequestParser::is_chunked_transfer(&headers);
                let is_gzipped = crate::parser::RequestParser::is_gzip_encoded(&headers);
                let is_brotli = crate::parser::RequestParser::is_brotli_encoded(&headers);

                if is_chunked {
                    debug!("Response is chunked encoded");
                }
                if is_gzipped {
                    debug!("Response is gzip compressed");
                }
                if is_brotli {
                    debug!("Response is brotli compressed");
                }

                let processed_body =
                    match crate::parser::BodyParser::process_response_body(body, &headers).await {
                        Ok(processed) => {
                            debug!(
                                "Successfully processed response body: {} bytes -> {} bytes",
                                body.len(),
                                processed.len()
                            );
                            processed
                        }
                        Err(e) => {
                            debug!(
                                "Error processing response body: {:?}, using original body",
                                e
                            );
                            body.to_vec()
                        }
                    };

                let content_type = crate::parser::BodyParser::get_content_type(&headers);
                debug!("Content type for body formatting: {:?}", content_type);

                let body_formatted = match crate::parser::BodyParser::format_body(
                    &processed_body,
                    content_type,
                ) {
                    Ok(formatted) => {
                        debug!(
                            "Successfully formatted response body: {} bytes",
                            formatted.len()
                        );
                        formatted
                    }
                    Err(e) => {
                        debug!(
                            "Error formatting response body: {:?}, trying direct string conversion",
                            e
                        );

                        if let Ok(text) = std::str::from_utf8(&processed_body) {
                            debug!("Direct string conversion succeeded");
                            text.to_string()
                        } else {
                            debug!("Direct string conversion failed, using lossy conversion");
                            String::from_utf8_lossy(&processed_body).to_string()
                        }
                    }
                };

                formatted.push_str(&body_formatted);
            } else {
                formatted.push_str("#<empty body>");
            }

            debug!("Formatted response size: {} bytes", formatted.len());
            Ok(formatted)
        } else {
            debug!("Could not find headers end, returning raw data as string");
            Ok(String::from_utf8_lossy(response_data).to_string())
        }
    }

    pub async fn log_response(
        &self, complete_response: &mut [u8], _response_logged: &Arc<Mutex<bool>>,
        request_id: &Arc<Mutex<Option<String>>>, logger: &Option<HttpLogger>,
    ) -> Result<()> {
        if let Some(logger) = logger {
            let req_id_guard = request_id.lock().await;
            if let Some(req_id) = &*req_id_guard {
                debug!(
                    "Logging response for request ID: {}, response size: {} bytes",
                    req_id,
                    complete_response.len()
                );

                let formatted_response =
                    match self.format_response_for_logging(complete_response).await {
                        Ok(formatted) => {
                            debug!(
                                "Successfully formatted response for logging, size: {} bytes",
                                formatted.len()
                            );

                            if formatted.starts_with("HTTP/") {
                                formatted
                            } else {
                                debug!("Response doesn't start with HTTP/, adding basic header");
                                let mut enhanced = String::from("HTTP/1.1 200 OK\n\n");
                                enhanced.push_str(&formatted);
                                enhanced
                            }
                        }
                        Err(e) => {
                            error!("Failed to format response: {:?}", e);
                            let mut basic_response = String::from("HTTP/1.1 200 OK\n");
                            basic_response.push_str(&format!("X-Formatting-Error: {e}\n\n"));
                            basic_response.push_str("# Failed to format response properly\n");
                            basic_response.push_str(&format!("# Error: {e}\n"));
                            basic_response.push_str("# Raw content follows (first 1000 bytes):\n");

                            let preview_size = std::cmp::min(complete_response.len(), 1000);
                            basic_response.push_str(&String::from_utf8_lossy(
                                &complete_response[..preview_size],
                            ));
                            basic_response
                        }
                    };

                let bytes = Bytes::from(formatted_response.into_bytes());
                debug!("Sending response to logger, size: {} bytes", bytes.len());

                logger.log_response(bytes, req_id.clone()).await;
                debug!("Response successfully logged for request ID: {}", req_id);
            } else {
                error!("No request ID available for logging response");
            }
            drop(req_id_guard);
        } else {
            debug!("No logger available for logging response");
        }

        Ok(())
    }

    pub async fn handle_remaining_response_data(
        &self, complete_response: &[u8], logging_enabled: bool, response_logged: &Arc<Mutex<bool>>,
        request_id: &Arc<Mutex<Option<String>>>, logger: &Option<HttpLogger>,
    ) -> Result<()> {
        if complete_response.is_empty() {
            debug!("No response data to log at connection end");
            return Ok(());
        }

        let mut response_logged_guard = response_logged.lock().await;
        let already_logged = *response_logged_guard;

        if logging_enabled && !already_logged {
            *response_logged_guard = true;
            debug!(
                "Marking response as logged (size: {}B)",
                complete_response.len()
            );
            drop(response_logged_guard);

            let req_id_guard = request_id.lock().await;
            if let Some(req_id) = &*req_id_guard {
                debug!(
                    "Connection closing with response data (size: {} bytes) for request ID: {}",
                    complete_response.len(),
                    req_id
                );

                if let Some(log_instance) = logger.as_ref() {
                    let req_clone = req_id.clone();
                    let response_data = Bytes::copy_from_slice(complete_response);
                    let response_size = response_data.len();

                    drop(req_id_guard);

                    debug!(
                        "Logging HTTP response at connection close - this ensures all data is captured"
                    );

                    let timeout_duration = Duration::from_secs(5);
                    match tokio::time::timeout(
                        timeout_duration,
                        log_instance.log_response(response_data, req_clone),
                    )
                    .await
                    {
                        Ok(_) => {
                            debug!(
                                "Final response ({}B) successfully logged (connection end)",
                                response_size
                            );
                        }
                        Err(_) => {
                            error!("Response logging timed out after 5 seconds");
                        }
                    }
                } else {
                    drop(req_id_guard);
                    error!("No logger instance available for logging response");
                }

                let wait_time = Duration::from_millis(self.config.min_log_sync_ms * 2);
                tokio::time::sleep(wait_time).await;
                debug!("Completed final response logging before connection close");
            } else {
                drop(req_id_guard);
                debug!("No request ID found for response at connection end");
            }
        } else {
            drop(response_logged_guard);

            if logging_enabled && already_logged {
                debug!("Response already logged earlier - connection closing");
            } else if !logging_enabled {
                debug!("HTTP logging disabled for this connection");
            }
        }

        Ok(())
    }

    fn is_chunked_transfer(headers_data: &[u8]) -> bool {
        if let Ok(headers_str) = std::str::from_utf8(headers_data) {
            let h_lower = headers_str.to_lowercase();
            if h_lower.contains("transfer-encoding: chunked") {
                trace!("Detected chunked transfer encoding in response - will wait for all chunks");
                return true;
            }

            if h_lower.contains("upgrade: websocket") && h_lower.contains("connection: upgrade") {
                debug!("Initial detection of WebSocket upgrade response");
                return false;
            }
        }
        false
    }
}

pub use DEFAULT_MIN_LOG_SYNC_MS as MIN_LOG_SYNC_MS;

#[cfg(test)]
mod tests {
    use super::*;

    #[tokio::test]
    async fn test_check_response_logging_status() {
        let handler = HttpResponseHandler::new(123);

        let buffer = b"HTTP/1.1 200 OK\r\nTransfer-Encoding: chunked\r\n\r\ndata";
        let mut state = ResponseLoggingState::new();

        handler
            .check_response_logging_status(buffer, buffer.len(), &mut state)
            .await
            .unwrap();

        assert!(state.already_logged);
        // logging_enabled will be false since config doesn't exist in database
        assert!(!state.logging_enabled);
    }

    #[tokio::test]
    async fn test_custom_config() {
        let config = ResponseHandlerConfig {
            min_log_sync_ms: 25,
            ..Default::default()
        };

        let handler = HttpResponseHandler::with_config(123, config);

        assert_eq!(handler.config().min_log_sync_ms, 25);

        let response_data = b"HTTP/1.1 101 Switching Protocols\r\nUpgrade: websocket\r\nConnection: Upgrade\r\n\r\nSome data";

        assert!(handler.check_time_based_logging(response_data, Instant::now()));

        let default_handler = HttpResponseHandler::new(123);

        let regular_response = b"HTTP/1.1 200 OK\r\nContent-Length: 9\r\n\r\nSome data";

        assert!(!default_handler.check_time_based_logging(regular_response, Instant::now()));
    }

    #[test]
    fn test_find_headers_end() {
        let response_with_headers =
            b"HTTP/1.1 200 OK\r\nContent-Type: text/plain\r\n\r\nBody content";
        let response_without_end = b"HTTP/1.1 200 OK\r\nContent-Type: text/plain\r\n";

        let header_end_position = response_with_headers
            .windows(4)
            .position(|w| w == b"\r\n\r\n")
            .unwrap();

        assert_eq!(
            find_headers_end(response_with_headers),
            Some(header_end_position)
        );
        assert_eq!(find_headers_end(response_without_end), None);
    }

    #[test]
    fn test_response_logging_state_new() {
        let state = ResponseLoggingState::new();

        assert!(state.complete_response.is_empty());
        assert!(!state.already_logged);
        assert!(!state.logging_enabled);
        assert!(!state.is_chunked);
    }

    #[tokio::test]
    async fn test_creating_response_chunk_context() {
        let response_logged = Arc::new(Mutex::new(false));
        let request_id = Arc::new(Mutex::new(Some("test-id".to_string())));

        let mut context = ResponseChunkContext::new(response_logged, request_id);

        let first_chunk = b"HTTP/1.1 200 OK\r\nTransfer-Encoding: chunked\r\n\r\n";
        context.complete_response.extend_from_slice(first_chunk);
        context.total_chunks_received += 1;

        assert_eq!(context.total_chunks_received, 1);
        assert_eq!(context.complete_response, first_chunk);
        assert!(!context.is_chunked);
        assert!(!context.found_end_marker);
    }

    #[test]
    fn test_handler_with_config() {
        let default_handler = HttpResponseHandler::new(456);
        assert_eq!(default_handler.config_id, 456);
        assert_eq!(
            default_handler.config.min_log_sync_ms,
            DEFAULT_MIN_LOG_SYNC_MS
        );

        let custom_config = ResponseHandlerConfig {
            min_log_sync_ms: 100,
            analyzer_config: ResponseAnalyzerConfig {
                min_headers_size: 32,
            },
        };

        let custom_handler = HttpResponseHandler::with_config(789, custom_config);
        assert_eq!(custom_handler.config_id, 789);
        assert_eq!(custom_handler.config.min_log_sync_ms, 100);
        assert_eq!(custom_handler.config.analyzer_config.min_headers_size, 32);
    }

    #[tokio::test]
    async fn test_creating_logging_context() {
        let _handler = HttpResponseHandler::new(123);

        let response_logged = Arc::new(Mutex::new(false));
        let request_id = Arc::new(Mutex::new(Some("test-id".to_string())));

        let buffer = b"HTTP/1.1 200 OK\r\nContent-Length: 11\r\n\r\nHello World";

        let context = ResponseLoggingContext {
            complete_response: buffer.to_vec(),
            is_chunked: false,
            found_end_marker: false,
            response_logged,
            request_id,
            first_chunk_time: Some(Instant::now()),
        };

        assert_eq!(context.complete_response, buffer);
        assert!(!context.is_chunked);
        assert!(!context.found_end_marker);
    }

    #[test]
    fn test_response_handler_config_default() {
        let config = ResponseHandlerConfig::default();

        assert_eq!(config.min_log_sync_ms, DEFAULT_MIN_LOG_SYNC_MS);
        assert_eq!(
            config.analyzer_config.min_headers_size,
            crate::http_response_analyzer::DEFAULT_MIN_VALID_HEADERS_SIZE
        );
    }

    #[tokio::test]
    async fn test_check_time_based_logging_websocket() {
        let handler = HttpResponseHandler::new(123);

        let websocket_response = b"HTTP/1.1 101 Switching Protocols\r\nUpgrade: websocket\r\nConnection: Upgrade\r\n\r\n";
        assert!(handler.check_time_based_logging(websocket_response, Instant::now()));
    }

    #[tokio::test]
    async fn test_check_time_based_logging_regular_response_no_time_passed() {
        let handler = HttpResponseHandler::new(123);

        let regular_response = b"HTTP/1.1 200 OK\r\nContent-Type: text/plain\r\n\r\nContent";
        let now = Instant::now();

        assert!(!handler.check_time_based_logging(regular_response, now));
    }

    #[tokio::test]
    async fn test_check_time_based_logging_regular_response_time_passed() {
        let handler = HttpResponseHandler::new(123);

        let very_old_time = Instant::now() - Duration::from_secs(15);

        let mut large_response =
            Vec::from(&b"HTTP/1.1 200 OK\r\nContent-Type: text/plain\r\n\r\n"[..]);
        large_response.extend(vec![b'A'; 6000]);

        assert!(
            handler.check_time_based_logging(&large_response, very_old_time),
            "Time-based logging should be triggered for large response with sufficient time elapsed"
        );
    }

    #[tokio::test]
    async fn test_check_time_based_logging_unfinished_response() {
        let handler = HttpResponseHandler::new(123);

        let unfinished_response = b"HTTP/1.1 200 OK\r\nContent-Type: text/plain";

        let past_time = Instant::now() - Duration::from_millis(DEFAULT_MIN_LOG_SYNC_MS + 10);

        assert!(!handler.check_time_based_logging(unfinished_response, past_time));
    }

    #[derive(Clone)]
    struct MockLogger {
        logs: Arc<Mutex<Vec<String>>>,
    }

    impl MockLogger {
        fn new() -> Self {
            Self {
                logs: Arc::new(Mutex::new(Vec::new())),
            }
        }

        async fn log_count(&self) -> usize {
            self.logs.lock().await.len()
        }

        async fn last_log(&self) -> Option<String> {
            let logs = self.logs.lock().await;
            logs.last().cloned()
        }
    }

    #[tokio::test]
    async fn test_chunked_transfer_detection() {
        let chunked_headers = b"HTTP/1.1 200 OK\r\nTransfer-Encoding: chunked\r\n\r\ndata";
        assert!(HttpResponseHandler::is_chunked_transfer(chunked_headers));

        let regular_headers = b"HTTP/1.1 200 OK\r\nContent-Type: text/plain\r\n\r\nContent";
        assert!(!HttpResponseHandler::is_chunked_transfer(regular_headers));

        let non_chunked_transfer = b"HTTP/1.1 200 OK\r\nTransfer-Encoding: gzip\r\n\r\ndata";
        assert!(!HttpResponseHandler::is_chunked_transfer(
            non_chunked_transfer
        ));
    }

    #[tokio::test]
    async fn test_websocket_upgrade_detection() {
        use crate::HttpResponseAnalyzer;

        let websocket_data = b"HTTP/1.1 101 Switching Protocols\r\nUpgrade: websocket\r\nConnection: Upgrade\r\nSec-WebSocket-Accept: s3pPLMBiTxaQ9kYGzzhZRbK+xOo=\r\n\r\n";

        println!("Testing websocket detection with complete headers");
        let result = HttpResponseAnalyzer::is_websocket_upgrade(websocket_data);
        println!("Result: {result}");

        assert!(result, "Should detect complete websocket upgrade response");

        let regular_data = b"HTTP/1.1 200 OK\r\nContent-Type: text/plain\r\n\r\nHello";
        assert!(
            !HttpResponseAnalyzer::is_websocket_upgrade(regular_data),
            "Should not detect regular HTTP response as websocket"
        );

        let partial_upgrade = b"HTTP/1.1 101 Switching Protocols\r\nConnection: Upgrade\r\nUpgrade: websocket\r\n\r\n";
        let partial_result = HttpResponseAnalyzer::is_websocket_upgrade(partial_upgrade);
        println!("Partial result: {partial_result}");

        assert!(
            !partial_result,
            "Should NOT detect WebSocket upgrade without Sec-WebSocket-Accept header"
        );
    }

    #[tokio::test]
    async fn test_format_response_for_logging() {
        let handler = HttpResponseHandler::new(123);
        let response_data =
            b"HTTP/1.1 200 OK\r\nContent-Type: text/plain\r\nServer: test\r\n\r\nHello World";

        let result = handler.format_response_for_logging(response_data).await;

        assert!(result.is_ok(), "format_response_for_logging should succeed");
        let formatted = result.unwrap();

        println!("Formatted response:\n{formatted}");
        println!(
            "Original response: {:?}",
            std::str::from_utf8(response_data).unwrap()
        );

        assert!(
            formatted.contains("HTTP/1.1 200 OK"),
            "Should contain status line"
        );
        assert!(
            formatted.contains("Hello World"),
            "Should contain body content"
        );
    }

    #[tokio::test]
    async fn test_mock_logging() {
        let logger = Arc::new(MockLogger::new());

        {
            let mut logs = logger.logs.lock().await;
            logs.push("Test log entry 1".to_string());
            logs.push("Test log entry 2".to_string());
        }

        assert_eq!(logger.log_count().await, 2);

        assert_eq!(logger.last_log().await.unwrap(), "Test log entry 2");
    }

    #[tokio::test]
    async fn test_format_response_for_logging_full() {
        let handler = HttpResponseHandler::new(123);

        let response_data =
            b"HTTP/1.1 200 OK\r\nContent-Type: text/plain\r\nContent-Length: 9\r\n\r\nTest body";

        let result = handler.format_response_for_logging(response_data).await;

        assert!(result.is_ok());
        let formatted = result.unwrap();

        println!("Formatted response: {formatted}");

        assert!(formatted.contains("HTTP/1.1 200 OK"));

        assert!(formatted.contains("Test body"));
    }

    #[tokio::test]
    async fn test_format_response_with_empty_body() {
        let handler = HttpResponseHandler::new(123);

        let response_data = b"HTTP/1.1 204 No Content\r\nServer: Test\r\n\r\n";

        let result = handler.format_response_for_logging(response_data).await;

        assert!(result.is_ok());
        let formatted = result.unwrap();

        println!("Formatted empty body response: {formatted}");

        assert!(!formatted.is_empty());

        assert!(formatted.contains("empty") || formatted.contains("#") || !formatted.is_empty());
    }
}