keyhog 0.5.73

GPU-accelerated secret scanner for code, Git history, cloud, containers, browser assets, and live credential verification
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
//! Regression e2e, the `scan` BASELINE surfaces (`--create-baseline`,
//! `--baseline`, `--update-baseline`), driven over the SHIPPED `keyhog` binary
//! and pinned to EXACT values, plus SARIF `partialFingerprints` stability across
//! runs and its cross-surface agreement with the baseline credential hash.
//!
//! This file is DISTINCT from `regression_cli_diff_baseline_depth.rs`, which
//! drives the standalone `keyhog diff <before> <after>` subcommand over two
//! prebuilt baseline JSON docs. Here we drive the SCAN-time baseline pipeline:
//!   * `--create-baseline PATH` snapshots current findings to a v1 JSON file and
//!     exits 0 without emitting a findings report (orchestrator/run.rs returns
//!     early);
//!   * `--baseline PATH` suppresses any finding whose `(detector_id,
//!     credential_hash)` pair is already acknowledged, an all-suppressed scan
//!     exits 0 with an empty `[]` report, while a NEW pair surfaces and exits 1;
//!   * `--update-baseline PATH` merges new findings into (or creates) the file,
//!     growing the entry set and deduping by the identity pair;
//!   * a malformed / wrong-version baseline fed to `--baseline` fails CLOSED
//!     (exit 2), never silently scanning without suppression.
//!
//! HOST-INDEPENDENCE: every scan pins `--backend cpu` (the always-available,
//! feature-independent engine) and clears `KEYHOG_BACKEND`, and every planted
//! secret is an AC-literal-anchored detector (`github-classic-pat` via `ghp_`,
//! `aws-access-key` via `AKIA`) that fires on the scalar/CPU path, no
//! accelerator is ever assumed. No assertion uses `is_empty()` / `is_ok()` /
//! `len() > 0` as its only check (Law 6).

use std::path::{Path, PathBuf};
use std::process::Command;
use tempfile::TempDir;

fn binary() -> PathBuf {
    PathBuf::from(env!("CARGO_BIN_EXE_keyhog"))
}

/// A GitHub classic PAT with a VALID CRC32 tail, fires `github-classic-pat` at
/// confidence 0.9 with a passing checksum, so it survives the confidence floor
/// on the CPU backend. Split-literal so this file is not itself a planted secret
/// for keyhog's own self-scan.
const PAT: &str = concat!("ghp_", "1234567890123456789012345678902PDSiF");
const PAT_DETECTOR: &str = "github-classic-pat";

/// An AWS access-key id (AC-literal `AKIA` detector) that fires on the CPU path.
const AWS: &str = concat!("AKIA", "QYLPMN5HFIQR7XYA");
const AWS_DETECTOR: &str = "aws-access-key";

/// The exact SARIF `partialFingerprints` key the reporter emits (versioned).
const FP_KEY: &str = "keyhog/credentialHash/v1";

/// Run `keyhog scan --daemon=off --backend cpu <extra…> <path>` hermetically and
/// return (exit-code, stdout, stderr). Clears `KEYHOG_BACKEND` so the flag is
/// the only routing input; `NO_COLOR` keeps stderr progress plain.
fn scan(path: &Path, extra: &[&str]) -> (Option<i32>, String, String) {
    let mut cmd = Command::new(binary());
    cmd.args(["scan", "--daemon=off", "--backend", "cpu"]);
    cmd.args(extra);
    cmd.arg(path);
    cmd.env_remove("KEYHOG_BACKEND");
    cmd.env("NO_COLOR", "1");
    let out = cmd.output().expect("spawn keyhog scan");
    (
        out.status.code(),
        String::from_utf8_lossy(&out.stdout).into_owned(),
        String::from_utf8_lossy(&out.stderr).into_owned(),
    )
}

/// A tempdir holding one file `name` with `body`. Returns (dir-guard, file-path).
fn file_with(name: &str, body: &str) -> (TempDir, PathBuf) {
    let dir = TempDir::new().expect("tempdir");
    let path = dir.path().join(name);
    std::fs::write(&path, body).expect("write fixture");
    (dir, path)
}

/// Write a one-detector corpus whose explicit script verifier deterministically
/// classifies the planted PAT without network access.
#[cfg(feature = "verify")]
fn write_script_verifier_detector(detectors: &Path, status: &str) {
    std::fs::create_dir(detectors).expect("create detector corpus");
    let detector = format!(
        r#"
[detector]
id = "baseline-script-verifier"
name = "Baseline script verifier"
service = "baseline-script-verifier"
severity = "critical"
ml = {{ match_mode = "lift", entropy_mode = "disabled", weight = 1.0, context_radius_lines = 0 }}
match_confidence = {{ literal_prefix_weight = 0.35, context_anchor_weight = 0.20, entropy_weight = 0.20, high_entropy_partial_weight = 0.12, moderate_entropy_threshold = 3.0, moderate_entropy_weight = 0.05, low_entropy_penalty_floor = 2.0, low_entropy_min_match_length = 10, low_entropy_penalty_multiplier = 0.60, keyword_nearby_weight = 0.10, sensitive_file_weight = 0.10, companion_weight = 0.05, very_high_entropy_margin = 1.2999999999999998, named_anchor_floor = 0.55, assignment_context_multiplier = 1.0, string_literal_context_multiplier = 0.9, unknown_context_multiplier = 0.8, documentation_context_multiplier = 0.3, comment_context_multiplier = 0.4, test_context_multiplier = 0.3, encrypted_context_multiplier = 0.05, soft_context_suppression_threshold = 0.5, encrypted_context_suppression_threshold = 0.8, post_match = {{ placeholder_multiplier = 0.05, minimum_byte_diversity = 0.1, low_diversity_multiplier = 0.1, maximum_repeat_ratio = 0.8, degenerate_run_min_length = 10, degenerate_repeat_multiplier = 0.1, fixture_path_multiplier = 0.5, ml_context_reapply_below = 0.95 }} }}
validators = [{{ type = "crc32-base62", prefixes = ["ghp_"], entropy_len = 30, checksum_len = 6, reject_overlong = true, confidence_floor = 0.9 }}]
keywords = ["ghp_"]
simdsieve_prefixes = ["ghp_"]

[[detector.patterns]]
regex = 'ghp_[A-Za-z0-9]{{36}}\b'

[detector.verify]
method = "GET"
url = "https://example.com/unused"
allowed_domains = ["example.com"]

[detector.verify.auth]
type = "script"
engine = "python3"
code = "print('STATUS: {status}')"

[detector.verify.success]
status = 200
"#
    );
    std::fs::write(detectors.join("script-verifier.toml"), detector)
        .expect("write script verifier detector");
}

/// Parse a JSON report / baseline document, panicking with raw bytes on failure.
fn json_of(s: &str) -> serde_json::Value {
    serde_json::from_str(s).unwrap_or_else(|e| panic!("not JSON ({e}):\n{s}"))
}

/// Load and parse a written baseline file at `path`.
fn read_baseline(path: &Path) -> serde_json::Value {
    let raw = std::fs::read_to_string(path).expect("read baseline file");
    json_of(&raw)
}

/// The `credential_hash` strings of the baseline's entries, sorted.
fn baseline_hashes(v: &serde_json::Value) -> Vec<String> {
    v["entries"]
        .as_array()
        .expect("entries array")
        .iter()
        .map(|e| e["credential_hash"].as_str().expect("hash str").to_string())
        .collect()
}

/// The `detector_id` strings of the baseline's entries, in file order.
fn baseline_detectors(v: &serde_json::Value) -> Vec<String> {
    v["entries"]
        .as_array()
        .expect("entries array")
        .iter()
        .map(|e| e["detector_id"].as_str().expect("id str").to_string())
        .collect()
}

// ---------------------------------------------------------------------------
// --create-baseline, writes a v1 file, exits 0, records the identity pair
// ---------------------------------------------------------------------------

/// Scanning a single planted PAT with `--create-baseline` writes a version-1
/// document with exactly one entry carrying the detector id, and exits 0 (the
/// create path returns before the findings report / findings exit code).
#[test]
fn create_baseline_writes_v1_one_entry_and_exits_zero() {
    let (_d, f) = file_with("secrets.env", &format!("{PAT}\n"));
    let base = _d.path().join("baseline.json");
    let (code, _out, err) = scan(&f, &["--create-baseline", base.to_str().unwrap()]);
    assert_eq!(
        code,
        Some(0),
        "--create-baseline returns early with exit 0 even with findings; stderr={err}"
    );

    let v = read_baseline(&base);
    assert_eq!(
        v["version"].as_u64(),
        Some(1),
        "a created baseline must be version 1; got {v}"
    );
    let entries = v["entries"].as_array().expect("entries array");
    assert_eq!(entries.len(), 1, "exactly one PAT → one entry; got {v}");
    assert_eq!(
        entries[0]["detector_id"].as_str(),
        Some(PAT_DETECTOR),
        "the entry must carry the github-classic-pat id; got {v}"
    );
}

/// Combining `--create-baseline --verify` must still write the exact snapshot,
/// but a deterministically confirmed live credential must preserve exit 10.
/// This prevents baseline creation from turning a live-secret CI failure green.
#[test]
#[cfg(feature = "verify")]
fn create_baseline_with_live_verification_writes_snapshot_and_exits_ten() {
    let (dir, source) = file_with("live.env", &format!("TOKEN={PAT}\n"));
    let detectors = dir.path().join("detectors");
    let baseline = dir.path().join("baseline.json");
    write_script_verifier_detector(&detectors, "LIVE");

    let (code, stdout, stderr) = scan(
        &source,
        &[
            "--detectors",
            detectors.to_str().unwrap(),
            "--verify",
            "--allow-script-verify",
            "--create-baseline",
            baseline.to_str().unwrap(),
        ],
    );

    assert_eq!(
        code,
        Some(10),
        "verified-live baseline creation must preserve exit 10; stdout={stdout}; stderr={stderr}"
    );
    assert_eq!(
        stdout, "",
        "baseline creation returns before reporting findings; got {stdout:?}"
    );
    let value = read_baseline(&baseline);
    assert_eq!(value["version"].as_u64(), Some(1), "baseline={value}");
    assert_eq!(
        baseline_detectors(&value),
        vec!["baseline-script-verifier".to_string()],
        "the live finding must still be persisted before exit 10; baseline={value}"
    );
}

/// The same combined path with a deterministically dead credential writes the
/// snapshot and exits zero. This negative twin pins that exit 10 depends on a
/// `Live` result, not merely on requesting verification.
#[test]
#[cfg(feature = "verify")]
fn create_baseline_with_dead_verification_writes_snapshot_and_exits_zero() {
    let (dir, source) = file_with("dead.env", &format!("TOKEN={PAT}\n"));
    let detectors = dir.path().join("detectors");
    let baseline = dir.path().join("baseline.json");
    write_script_verifier_detector(&detectors, "DEAD");

    let (code, stdout, stderr) = scan(
        &source,
        &[
            "--detectors",
            detectors.to_str().unwrap(),
            "--verify",
            "--allow-script-verify",
            "--create-baseline",
            baseline.to_str().unwrap(),
        ],
    );

    assert_eq!(
        code,
        Some(0),
        "verified-dead baseline creation must stay green; stdout={stdout}; stderr={stderr}"
    );
    assert_eq!(
        baseline_detectors(&read_baseline(&baseline)),
        vec!["baseline-script-verifier".to_string()]
    );
}

/// The baseline `credential_hash` is the `sha256:`-prefixed, 64-hex-char form
/// (the baseline-specific spelling documented in baseline.rs::baseline_hash_key).
#[test]
fn create_baseline_hash_is_sha256_prefixed_64_hex() {
    let (_d, f) = file_with("secrets.env", &format!("{PAT}\n"));
    let base = _d.path().join("baseline.json");
    let (code, _o, _e) = scan(&f, &["--create-baseline", base.to_str().unwrap()]);
    assert_eq!(code, Some(0));

    let v = read_baseline(&base);
    let hashes = baseline_hashes(&v);
    assert_eq!(hashes.len(), 1, "one hash; got {v}");
    let h = &hashes[0];
    let hex = h
        .strip_prefix("sha256:")
        .unwrap_or_else(|| panic!("hash must be sha256:-prefixed; got {h}"));
    assert_eq!(
        hex.len(),
        64,
        "sha256 hex body must be 64 chars; got {hex:?}"
    );
    assert!(
        hex.chars()
            .all(|c| c.is_ascii_hexdigit() && !c.is_ascii_uppercase()),
        "hash body must be lowercase hex; got {hex:?}"
    );
}

/// The baseline entry records the finding's file path and 1-indexed line for
/// reference: the token planted on line 2 (comment on line 1) yields `line: 2`
/// and a `file_path` naming the fixture.
#[test]
fn create_baseline_records_file_path_and_line_two() {
    let body = format!("# leading comment line\n{PAT}\n");
    let (_d, f) = file_with("app.env", &body);
    let base = _d.path().join("baseline.json");
    let (code, _o, _e) = scan(&f, &["--create-baseline", base.to_str().unwrap()]);
    assert_eq!(code, Some(0));

    let v = read_baseline(&base);
    let e = &v["entries"][0];
    assert_eq!(
        e["line"].as_u64(),
        Some(2),
        "the token is on line 2 (1-indexed); got {v}"
    );
    let fp = e["file_path"].as_str().expect("file_path present");
    assert!(
        fp.ends_with("app.env"),
        "file_path must name the fixture app.env; got {fp}"
    );
}

/// A file carrying TWO distinct secrets yields a 2-entry baseline, sorted by
/// `detector_id` (from_findings sorts): `aws-access-key` precedes
/// `github-classic-pat`.
#[test]
fn create_baseline_multi_entry_sorted_by_detector_id() {
    let body = format!("{AWS}\n{PAT}\n");
    let (_d, f) = file_with("multi.env", &body);
    let base = _d.path().join("baseline.json");
    let (code, _o, err) = scan(&f, &["--create-baseline", base.to_str().unwrap()]);
    assert_eq!(code, Some(0), "stderr={err}");

    let v = read_baseline(&base);
    let ids = baseline_detectors(&v);
    assert_eq!(
        ids,
        vec![AWS_DETECTOR.to_string(), PAT_DETECTOR.to_string()],
        "two entries sorted by detector id (aws before github); got {v}"
    );
}

// ---------------------------------------------------------------------------
// --baseline, suppresses the acknowledged pair, surfaces new pairs
// ---------------------------------------------------------------------------

/// Re-scanning the SAME file whose finding is already in the baseline suppresses
/// it entirely: the JSON report is exactly `[]` and the scan exits 0 (no new
/// entries → no findings exit code).
#[test]
fn baseline_suppresses_known_finding_exit_zero_empty_report() {
    let (_d, f) = file_with("secrets.env", &format!("{PAT}\n"));
    let base = _d.path().join("baseline.json");
    let (c0, _o, _e) = scan(&f, &["--create-baseline", base.to_str().unwrap()]);
    assert_eq!(c0, Some(0));

    let (code, out, err) = scan(
        &f,
        &["--baseline", base.to_str().unwrap(), "--format", "json"],
    );
    assert_eq!(
        code,
        Some(0),
        "an all-baselined scan has no new findings → exit 0; stderr={err}"
    );
    assert_eq!(
        out.trim(),
        "[]",
        "the suppressed report must be exactly the empty array; got {out}"
    );
}

/// An EMPTY baseline (created from a clean file with no secrets) acknowledges
/// nothing, so a subsequent scan of the PAT file surfaces the finding and exits
/// 1 with the PAT present in the report.
#[test]
fn empty_baseline_surfaces_finding_exit_one() {
    let (clean_d, clean) = file_with("clean.txt", "nothing to see here\n");
    let base = clean_d.path().join("empty-baseline.json");
    let (c0, _o, _e) = scan(&clean, &["--create-baseline", base.to_str().unwrap()]);
    assert_eq!(c0, Some(0));
    // The clean baseline must genuinely be empty.
    let v0 = read_baseline(&base);
    assert_eq!(
        v0["entries"].as_array().expect("entries").len(),
        0,
        "a clean scan produces a zero-entry baseline; got {v0}"
    );

    let (_pd, pf) = file_with("secrets.env", &format!("{PAT}\n"));
    let (code, out, err) = scan(
        &pf,
        &["--baseline", base.to_str().unwrap(), "--format", "json"],
    );
    assert_eq!(
        code,
        Some(1),
        "an unacknowledged finding surfaces → exit 1 (EXIT_FINDINGS); stderr={err}"
    );
    let report = json_of(&out);
    let arr = report.as_array().expect("json report array");
    assert_eq!(arr.len(), 1, "exactly the one un-baselined PAT; got {out}");
    assert_eq!(
        arr[0]["detector_id"].as_str(),
        Some(PAT_DETECTOR),
        "the surfaced finding is the PAT; got {out}"
    );
}

/// A baseline built from a PAT-only tree suppresses the PAT but NOT a newly
/// introduced AWS key in the same tree: the report holds exactly the AWS finding
/// (github filtered out) and the scan exits 1.
#[test]
fn baseline_suppresses_pat_but_surfaces_new_aws_exit_one() {
    let dir = TempDir::new().expect("tempdir");
    let pat_file = dir.path().join("a.env");
    std::fs::write(&pat_file, format!("{PAT}\n")).expect("write pat");
    let base = dir.path().join("baseline.json");

    // Baseline snapshots the tree while it holds ONLY the PAT.
    let (c0, _o, _e) = scan(dir.path(), &["--create-baseline", base.to_str().unwrap()]);
    assert_eq!(c0, Some(0));
    assert_eq!(
        read_baseline(&base)["entries"]
            .as_array()
            .expect("entries")
            .len(),
        1,
        "baseline snapshots only the PAT at create time"
    );

    // Now introduce a NEW AWS key and re-scan the whole tree against the baseline.
    let aws_file = dir.path().join("b.env");
    std::fs::write(&aws_file, format!("{AWS}\n")).expect("write aws");

    let (code, out, err) = scan(
        dir.path(),
        &["--baseline", base.to_str().unwrap(), "--format", "json"],
    );
    assert_eq!(
        code,
        Some(1),
        "the new AWS pair is unacknowledged → exit 1; stderr={err}"
    );
    let report = json_of(&out);
    let ids: Vec<&str> = report
        .as_array()
        .expect("json array")
        .iter()
        .filter_map(|f| f["detector_id"].as_str())
        .collect();
    assert!(
        ids.contains(&AWS_DETECTOR),
        "the new AWS finding must surface; got {out}"
    );
    assert!(
        !ids.contains(&PAT_DETECTOR),
        "the baselined PAT must stay suppressed; got {out}"
    );
}

/// Suppression matches on the `(detector_id, credential_hash)` PAIR, NOT the file
/// path or line, the baseline docs say secrets may move. A PAT baselined from
/// file A stays suppressed when the same secret reappears in a DIFFERENT file at
/// a DIFFERENT line: exit 0, empty report.
#[test]
fn baseline_suppression_is_path_independent() {
    let (_ad, a) = file_with("a.env", &format!("{PAT}\n"));
    let base = _ad.path().join("baseline.json");
    let (c0, _o, _e) = scan(&a, &["--create-baseline", base.to_str().unwrap()]);
    assert_eq!(c0, Some(0));

    // Same secret, different file name AND different line (shifted down by 3).
    let (_bd, b) = file_with("elsewhere.txt", &format!("l1\nl2\nl3\n{PAT}\n"));
    let (code, out, err) = scan(
        &b,
        &["--baseline", base.to_str().unwrap(), "--format", "json"],
    );
    assert_eq!(
        code,
        Some(0),
        "same (detector,hash) pair stays suppressed across path/line moves; stderr={err}"
    );
    assert_eq!(
        out.trim(),
        "[]",
        "the moved-but-baselined secret must not surface; got {out}"
    );
}

// ---------------------------------------------------------------------------
// --update-baseline, creates-if-absent, merges, dedups
// ---------------------------------------------------------------------------

/// `--update-baseline` against a non-existent path creates it: the first run
/// records the PAT as a NEW entry (exit 1), and an immediate re-run finds it
/// already acknowledged (exit 0) with the entry count unchanged (dedup).
#[test]
fn update_baseline_creates_then_dedups_on_rerun() {
    let (_d, f) = file_with("secrets.env", &format!("{PAT}\n"));
    let base = _d.path().join("evolving-baseline.json");
    assert!(!base.exists(), "baseline must not pre-exist");

    let (c1, _o1, e1) = scan(&f, &["--update-baseline", base.to_str().unwrap()]);
    assert_eq!(
        c1,
        Some(1),
        "first update records a NEW entry → exit 1; stderr={e1}"
    );
    let v1 = read_baseline(&base);
    assert_eq!(
        v1["entries"].as_array().expect("entries").len(),
        1,
        "first update writes exactly one entry; got {v1}"
    );

    let (c2, _o2, e2) = scan(&f, &["--update-baseline", base.to_str().unwrap()]);
    assert_eq!(
        c2,
        Some(0),
        "the PAT is now acknowledged → no new entries → exit 0; stderr={e2}"
    );
    let v2 = read_baseline(&base);
    assert_eq!(
        v2["entries"].as_array().expect("entries").len(),
        1,
        "re-running must not duplicate the entry (dedup by pair); got {v2}"
    );
}

/// A second `--update-baseline` after a NEW secret appears GROWS the file from 1
/// to 2 entries and exits 1 (the AWS key is new), while the original PAT entry is
/// preserved.
#[test]
fn update_baseline_grows_and_preserves_existing() {
    let dir = TempDir::new().expect("tempdir");
    let pat_file = dir.path().join("a.env");
    std::fs::write(&pat_file, format!("{PAT}\n")).expect("write pat");
    let base = dir.path().join("baseline.json");

    let (c1, _o1, _e1) = scan(dir.path(), &["--update-baseline", base.to_str().unwrap()]);
    assert_eq!(c1, Some(1), "first update: PAT is new → exit 1");
    assert_eq!(
        read_baseline(&base)["entries"]
            .as_array()
            .expect("entries")
            .len(),
        1
    );

    let aws_file = dir.path().join("b.env");
    std::fs::write(&aws_file, format!("{AWS}\n")).expect("write aws");

    let (c2, _o2, e2) = scan(dir.path(), &["--update-baseline", base.to_str().unwrap()]);
    assert_eq!(
        c2,
        Some(1),
        "second update: AWS is new → exit 1; stderr={e2}"
    );
    let v = read_baseline(&base);
    let ids = baseline_detectors(&v);
    assert_eq!(ids.len(), 2, "the file grew to two entries; got {v}");
    assert!(
        ids.contains(&AWS_DETECTOR.to_string()) && ids.contains(&PAT_DETECTOR.to_string()),
        "both the preserved PAT and the new AWS entry must be present; got {v}"
    );
}

// ---------------------------------------------------------------------------
// fail-closed, malformed / wrong-version baseline handed to --baseline
// ---------------------------------------------------------------------------

/// Feeding a `scan --format json` FINDINGS report (a top-level JSON array) to
/// `--baseline` fails CLOSED: exit 2 (EXIT_USER_ERROR) with the actionable
/// `--create-baseline` hint (it must NOT silently scan without suppression).
#[test]
fn baseline_findings_report_fails_closed_exit_two() {
    let (_d, f) = file_with("secrets.env", &format!("{PAT}\n"));
    let bad = _d.path().join("findings-report.json");
    std::fs::write(
        &bad,
        r#"[{"detector_id":"github-classic-pat","credential_redacted":"ghp_...DSiF"}]"#,
    )
    .expect("write findings report");

    let (code, _out, err) = scan(&f, &["--baseline", bad.to_str().unwrap()]);
    assert_eq!(
        code,
        Some(2),
        "a findings report is not a baseline → user error → exit 2; stderr={err}"
    );
    assert!(
        err.contains("--create-baseline"),
        "the error must point at --create-baseline to fix it; got {err}"
    );
}

/// A syntactically valid baseline carrying an UNSUPPORTED version handed to
/// `--baseline` fails CLOSED at load: exit 2 and the error names the seen and
/// expected version numbers.
#[test]
fn baseline_unsupported_version_fails_closed_exit_two() {
    let (_d, f) = file_with("secrets.env", &format!("{PAT}\n"));
    let bad = _d.path().join("v999-baseline.json");
    std::fs::write(&bad, r#"{"version": 999, "created": "t", "entries": []}"#).expect("write v999");

    let (code, _out, err) = scan(&f, &["--baseline", bad.to_str().unwrap()]);
    assert_eq!(
        code,
        Some(2),
        "an unsupported baseline version is a user error → exit 2; stderr={err}"
    );
    assert!(
        err.contains("unsupported baseline version 999") && err.contains("expected 1"),
        "the error must state seen version 999 and expected 1; got {err}"
    );
}

/// The three baseline modes are mutually exclusive (clap `conflicts_with_all`):
/// `--baseline X --create-baseline Y` is a usage error → clap exit 2.
#[test]
fn baseline_and_create_baseline_conflict_exit_two() {
    let (_d, f) = file_with("secrets.env", &format!("{PAT}\n"));
    let (code, _out, err) = scan(&f, &["--baseline", "b.json", "--create-baseline", "c.json"]);
    assert_eq!(
        code,
        Some(2),
        "conflicting baseline flags are a clap usage error → exit 2; stderr={err}"
    );
    assert!(
        err.contains("cannot be used with"),
        "clap must report the flag conflict; got {err}"
    );
}

// ---------------------------------------------------------------------------
// SARIF partialFingerprints, stability across runs + baseline agreement
// ---------------------------------------------------------------------------

/// The SARIF `partialFingerprints["keyhog/credentialHash/v1"]` is STABLE: two
/// independent scans of the same secret produce byte-identical fingerprints (the
/// value GitHub code-scanning dedups alerts on across runs).
#[test]
fn sarif_fingerprint_stable_across_two_runs() {
    let (_d, f) = file_with("secrets.env", &format!("{PAT}\n"));

    let fp_of = |path: &Path| -> String {
        let (_c, out, _e) = scan(path, &["--format", "sarif"]);
        let v = json_of(&out);
        v.pointer("/runs/0/results/0/partialFingerprints")
            .and_then(|p| p.get(FP_KEY))
            .and_then(|h| h.as_str())
            .unwrap_or_else(|| panic!("missing partialFingerprints[{FP_KEY}] in:\n{out}"))
            .to_string()
    };

    let first = fp_of(&f);
    let second = fp_of(&f);
    assert_eq!(
        first.len(),
        64,
        "the credential fingerprint is a 64-hex sha256; got {first:?}"
    );
    assert_eq!(
        first, second,
        "the same secret must yield a byte-identical fingerprint across runs"
    );
}

/// Cross-surface truth: the SARIF fingerprint (bare hex) equals the baseline
/// `credential_hash` with its `sha256:` prefix stripped, the two identity
/// surfaces describe the exact same credential hash and must never drift.
#[test]
fn sarif_fingerprint_equals_baseline_hash_body() {
    let (_d, f) = file_with("secrets.env", &format!("{PAT}\n"));

    // Baseline surface: sha256:-prefixed hex.
    let base = _d.path().join("baseline.json");
    let (c0, _o, _e) = scan(&f, &["--create-baseline", base.to_str().unwrap()]);
    assert_eq!(c0, Some(0));
    let baseline_hash = baseline_hashes(&read_baseline(&base))
        .into_iter()
        .next()
        .expect("one baseline hash");
    let baseline_body = baseline_hash
        .strip_prefix("sha256:")
        .expect("sha256: prefix")
        .to_string();

    // SARIF surface: bare hex.
    let (_c, out, _e2) = scan(&f, &["--format", "sarif"]);
    let v = json_of(&out);
    let sarif_fp = v
        .pointer("/runs/0/results/0/partialFingerprints")
        .and_then(|p| p.get(FP_KEY))
        .and_then(|h| h.as_str())
        .unwrap_or_else(|| panic!("missing partialFingerprints in:\n{out}"))
        .to_string();

    assert_eq!(
        sarif_fp, baseline_body,
        "SARIF fingerprint and baseline hash body must be the same 64-hex sha256"
    );
}