keyhog-scanner 0.5.50

keyhog-scanner: high-performance SIMD-accelerated secret detection engine
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
use crate::decode::base64::{Base64Decoder, Z85Decoder};
use crate::decode::caesar::CaesarDecoder;
use crate::decode::hex::HexDecoder;
#[cfg(feature = "decode")]
use crate::decode::javascript_static::JavaScriptStaticDecoder;
use crate::decode::json::JsonDecoder;
use crate::decode::reverse::ReverseDecoder;
use crate::decode::url::{
    HtmlNamedEntityDecoder, HtmlNumericEntityDecoder, MimeEncodedWordDecoder, OctalEscapeDecoder,
    QuotedPrintableDecoder, UnicodeEscapeDecoder, UrlDecoder,
};
#[cfg(feature = "decode")]
use crate::decode::DecodeAdmission;
#[cfg(any(feature = "decode", test))]
use crate::decode::DecodeAdmissionSketch;
use crate::decode::Decoder;
use aho_corasick::AhoCorasick;
use parking_lot::RwLock;
#[cfg(test)]
use std::cell::RefCell;
use std::sync::Arc;

// The active decoder set is stored behind one shared `Arc<Vec<..>>`. Scanner
// construction captures this Arc in its immutable execution plan. Standalone
// compatibility helpers clone one Arc per call. Registration is copy-on-write,
// so existing scanners and in-flight compatibility calls keep their snapshot.
static DECODERS: std::sync::OnceLock<RwLock<DecoderRegistryState>> = std::sync::OnceLock::new();

struct DecoderRegistryState {
    decoders: Arc<Vec<RegisteredDecoder>>,
    compatibility_failure: Option<DecoderRegistrationError>,
}

#[derive(Clone)]
pub(crate) enum RegisteredDecoder {
    Shared(Arc<dyn Decoder>),
    Reverse,
    Caesar,
}

impl RegisteredDecoder {
    pub(crate) fn name(&self) -> &'static str {
        match self {
            Self::Shared(decoder) => decoder.name(),
            Self::Reverse => "reverse",
            Self::Caesar => "caesar",
        }
    }

    fn version(&self) -> &'static str {
        match self {
            Self::Shared(decoder) => decoder.version(),
            Self::Reverse | Self::Caesar => "detector-policy-1",
        }
    }

    #[cfg(any(feature = "decode", test))]
    fn admission(
        &self,
        chunk: &keyhog_core::Chunk,
        policy: &super::super::policy::CompiledDecodeTransformPolicy,
    ) -> DecodeAdmission {
        match self {
            Self::Shared(decoder) => decoder.admission(chunk),
            Self::Reverse => ReverseDecoder
                .admission_sketch_with_policy(chunk, policy)
                .admission(),
            Self::Caesar => CaesarDecoder
                .admission_sketch_with_policy(chunk, policy)
                .admission(),
        }
    }

    #[cfg(any(feature = "decode", test))]
    fn admission_sketch(
        &self,
        chunk: &keyhog_core::Chunk,
        policy: &super::super::policy::CompiledDecodeTransformPolicy,
    ) -> DecodeAdmissionSketch {
        match self {
            Self::Shared(decoder) => decoder.admission_sketch(chunk),
            Self::Reverse => ReverseDecoder.admission_sketch_with_policy(chunk, policy),
            Self::Caesar => CaesarDecoder.admission_sketch_with_policy(chunk, policy),
        }
    }

    pub(super) fn decode_chunk_into(
        &self,
        chunk: &keyhog_core::Chunk,
        policy: &super::super::policy::CompiledDecodeTransformPolicy,
        sink: &mut dyn crate::decode::DecodeOutputSink,
    ) {
        match self {
            Self::Shared(decoder) => decoder.decode_chunk_into(chunk, sink),
            Self::Reverse => ReverseDecoder.decode_chunk_with_policy_into(chunk, policy, sink),
            Self::Caesar => CaesarDecoder.decode_chunk_with_policy_into(chunk, policy, sink),
        }
    }
}

#[derive(Clone, Debug, Eq, PartialEq, thiserror::Error)]
pub enum DecoderRegistrationError {
    #[error("decoder name must be non-empty ASCII without whitespace")]
    InvalidName,
    #[error("decoder {name:?} version must be non-empty ASCII without whitespace")]
    InvalidVersion { name: &'static str },
    #[error("decoder name {0:?} is already registered")]
    DuplicateName(&'static str),
    #[error("could not compile the all-decoder trigger automaton: {0}")]
    TriggerBuild(String),
}

#[derive(Clone)]
pub(crate) struct CompiledDecoderPlan {
    decoders: Arc<Vec<RegisteredDecoder>>,
    all_decoder_trigger: Option<AhoCorasick>,
    identity: u64,
}

impl std::fmt::Debug for CompiledDecoderPlan {
    fn fmt(&self, formatter: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
        formatter
            .debug_struct("CompiledDecoderPlan")
            .field("decoder_count", &self.decoders.len())
            .field(
                "has_all_decoder_trigger",
                &self.all_decoder_trigger.is_some(),
            )
            .field("identity", &self.identity)
            .finish()
    }
}

impl CompiledDecoderPlan {
    pub(crate) fn snapshot() -> Result<Self, DecoderRegistrationError> {
        let decoders = snapshot_decoders()?;
        let mut names = std::collections::HashSet::with_capacity(decoders.len());
        let mut hasher = blake3::Hasher::new();
        hasher.update(b"keyhog-compiled-decoder-plan-v1\0");
        for decoder in decoders.iter() {
            let name = decoder.name();
            let version = decoder.version();
            validate_descriptor(name, version)?;
            if !names.insert(name) {
                return Err(DecoderRegistrationError::DuplicateName(name));
            }
            hash_descriptor(&mut hasher, name, version);
        }
        let mut bytes = [0u8; 8];
        bytes.copy_from_slice(&hasher.finalize().as_bytes()[..8]);
        let all_decoder_trigger = compile_all_decoder_trigger(&decoders)?;
        Ok(Self {
            decoders,
            all_decoder_trigger,
            identity: u64::from_le_bytes(bytes),
        })
    }

    pub(crate) fn identity(&self) -> u64 {
        self.identity
    }

    #[cfg(any(feature = "decode", test))]
    pub(crate) fn decoders(&self) -> &[RegisteredDecoder] {
        &self.decoders
    }

    pub(crate) fn all_decoder_may_match(&self, data: &str) -> bool {
        self.all_decoder_trigger
            .as_ref()
            .is_none_or(|trigger| trigger.is_match(data.as_bytes()))
    }
}

fn validate_descriptor(
    name: &'static str,
    version: &'static str,
) -> Result<(), DecoderRegistrationError> {
    if name.is_empty() || !name.is_ascii() || name.bytes().any(|byte| byte.is_ascii_whitespace()) {
        return Err(DecoderRegistrationError::InvalidName);
    }
    if version.is_empty()
        || !version.is_ascii()
        || version.bytes().any(|byte| byte.is_ascii_whitespace())
    {
        return Err(DecoderRegistrationError::InvalidVersion { name });
    }
    Ok(())
}

fn hash_descriptor(hasher: &mut blake3::Hasher, name: &str, version: &str) {
    for value in [name.as_bytes(), version.as_bytes()] {
        hasher.update(&(value.len() as u64).to_le_bytes());
        hasher.update(value);
    }
}

fn is_default_decoder_name(name: &str) -> bool {
    matches!(
        name,
        "base64"
            | "hex"
            | "url"
            | "quoted-printable"
            | "html-named-entity"
            | "html-numeric-entity"
            | "octal-escape"
            | "mime-encoded-word"
            | "json"
            | "unicode-escape"
            | "z85"
            | "javascript-static"
            | "reverse"
            | "caesar"
    )
}

fn compile_all_decoder_trigger(
    decoders: &[RegisteredDecoder],
) -> Result<Option<AhoCorasick>, DecoderRegistrationError> {
    if decoders
        .iter()
        .any(|decoder| !is_default_decoder_name(decoder.name()))
    {
        return Ok(None);
    }
    let patterns = (b'!'..=b'~').map(|byte| [byte]);
    AhoCorasick::builder()
        .kind(Some(aho_corasick::AhoCorasickKind::ContiguousNFA))
        .build(patterns)
        .map(Some)
        .map_err(|error| DecoderRegistrationError::TriggerBuild(error.to_string()))
}

#[cfg(test)]
thread_local! {
    static THREAD_DECODERS: RefCell<Vec<Arc<dyn Decoder>>> = RefCell::new(Vec::new());
}

/// Per-decoder wall-time profiler (measurement only). Enabled by the single
/// scanner profiler switch (`keyhog scan --profile`) so profiling has one runtime
/// owner instead of one env knob per pass. Records which decoder dominates
/// decode generation. Zero-cost unset.
pub(super) fn profile_enabled() -> bool {
    crate::scan_profile::enabled()
}

/// Fixed number of per-decoder profiler slots. The `DECODER_NS` / `DECODER_PRODUCED`
/// accumulators and every index/clamp into them share this one capacity. There
/// are 14 default decoders today, so the cap carries headroom; a decoder past
/// slot `MAX_PROFILED_DECODERS` is simply not profiled (`record_decoder_run`
/// drops it), the `decoder_registry_within_profiler_capacity` gap test guards
/// the default set against silently outgrowing this.
const MAX_PROFILED_DECODERS: usize = 16;

static DECODER_NS: [std::sync::atomic::AtomicU64; MAX_PROFILED_DECODERS] = {
    const Z: std::sync::atomic::AtomicU64 = std::sync::atomic::AtomicU64::new(0);
    [Z; MAX_PROFILED_DECODERS]
};

/// Sub-chunks EMITTED per decoder (pre-dedup/screen). The sub-chunk COUNT - not
/// gen time - is what drives the dominant decode-rescan + per-sub-chunk fixed
/// phase-1 cost, so this isolates which decoders to gate with a sound prune.
static DECODER_PRODUCED: [std::sync::atomic::AtomicU64; MAX_PROFILED_DECODERS] = {
    const Z: std::sync::atomic::AtomicU64 = std::sync::atomic::AtomicU64::new(0);
    [Z; MAX_PROFILED_DECODERS]
};

pub(super) fn record_decoder_run(
    decoder_index: usize,
    elapsed: std::time::Duration,
    produced: usize,
) {
    if decoder_index >= MAX_PROFILED_DECODERS {
        return;
    }
    use std::sync::atomic::Ordering::Relaxed;
    DECODER_NS[decoder_index].fetch_add(elapsed.as_nanos() as u64, Relaxed);
    DECODER_PRODUCED[decoder_index].fetch_add(produced as u64, Relaxed);
}

/// Print and reset the accumulated per-decoder times (paired with registry
/// names). Folded into the unified scanner profile dump.
pub(crate) fn decoder_profile_dump() {
    use std::sync::atomic::Ordering::Relaxed;
    let decoders = active_decoders();
    let names: Vec<&str> = decoders.iter().map(|d| d.name()).collect();
    let mut rows: Vec<(String, f64)> = (0..names.len().min(MAX_PROFILED_DECODERS))
        .map(|i| {
            (
                names[i].to_string(),
                DECODER_NS[i].swap(0, Relaxed) as f64 / 1e6,
            )
        })
        .collect();
    rows.sort_by(|a, b| b.1.total_cmp(&a.1));
    let total: f64 = rows.iter().map(|r| r.1).sum();
    let mut prod: Vec<(String, u64)> = (0..names.len().min(MAX_PROFILED_DECODERS))
        .map(|i| (names[i].to_string(), DECODER_PRODUCED[i].swap(0, Relaxed)))
        .collect();
    prod.sort_by(|a, b| b.1.cmp(&a.1));
    let prod_total: u64 = prod.iter().map(|r| r.1).sum();
    if total == 0.0 && prod_total == 0 {
        return;
    }
    eprintln!("=== per-decoder decode_chunk time ===");
    for (name, ms) in &rows {
        let pct = if total > 0.0 { 100.0 * ms / total } else { 0.0 };
        eprintln!("  {name:<18}: {ms:>8.1} ms ({pct:>5.1}%)");
    }
    eprintln!("  {:<18}: {total:>8.1} ms", "TOTAL");
    eprintln!("=== per-decoder sub-chunks EMITTED (pre-dedup/screen) ===");
    for (name, n) in &prod {
        let pct = if prod_total > 0 {
            100.0 * *n as f64 / prod_total as f64
        } else {
            0.0
        };
        eprintln!("  {name:<18}: {n:>8} ({pct:>5.1}%)");
    }
    eprintln!("  {:<18}: {prod_total:>8}", "TOTAL");
}

pub(crate) fn decoder_profile_reset() {
    use std::sync::atomic::Ordering::Relaxed;
    for slot in &DECODER_NS {
        slot.store(0, Relaxed);
    }
    for slot in &DECODER_PRODUCED {
        slot.store(0, Relaxed);
    }
}

fn default_decoders() -> Vec<RegisteredDecoder> {
    vec![
        RegisteredDecoder::Shared(Arc::new(Base64Decoder)),
        RegisteredDecoder::Shared(Arc::new(HexDecoder)),
        RegisteredDecoder::Shared(Arc::new(UrlDecoder)),
        RegisteredDecoder::Shared(Arc::new(QuotedPrintableDecoder)),
        RegisteredDecoder::Shared(Arc::new(HtmlNamedEntityDecoder)),
        RegisteredDecoder::Shared(Arc::new(HtmlNumericEntityDecoder)),
        RegisteredDecoder::Shared(Arc::new(OctalEscapeDecoder)),
        RegisteredDecoder::Shared(Arc::new(MimeEncodedWordDecoder)),
        // JSON unescape - strips `\"` / `\\` / `\n` style escapes inside JSON
        // string values so credentials stored as JSON-encoded fields survive
        // into the scanner.
        RegisteredDecoder::Shared(Arc::new(JsonDecoder)),
        RegisteredDecoder::Shared(Arc::new(UnicodeEscapeDecoder)),
        RegisteredDecoder::Shared(Arc::new(Z85Decoder)),
        // Bounded, side-effect-free JavaScript constant recovery. Keep it after
        // representation decoders and before the asymmetric evasion decoders.
        #[cfg(feature = "decode")]
        RegisteredDecoder::Shared(Arc::new(JavaScriptStaticDecoder)),
        RegisteredDecoder::Reverse,
        RegisteredDecoder::Caesar,
    ]
}

/// The `name()` of each default decoder, in registration order. This is the
/// canonical decode-pipeline composition, the order is load-bearing (the
/// `reverse` and `caesar` decoders deliberately run last, after the structural
/// decoders), and is pinned by `decoder_registry_default_order` so a reorder
/// or addition can't silently shift the pipeline.
#[cfg(feature = "decode")]
pub(crate) fn default_decoder_names() -> Vec<&'static str> {
    default_decoders().iter().map(|d| d.name()).collect()
}

/// Aggregate decoder-owned admission proofs for one root chunk.
///
/// Candidate extraction is primed once so built-in predicates that use the
/// shared extractor do not each allocate and rescan independently. Any custom
/// decoder that keeps the trait default returns `Unknown`, which is preserved
/// unless another decoder already proves the chunk is `Possible`.
#[cfg(feature = "decode")]
pub(crate) fn decoder_admission(
    chunk: &keyhog_core::Chunk,
    policy: &super::super::policy::CompiledDecodeTransformPolicy,
    plan: &CompiledDecoderPlan,
) -> DecodeAdmission {
    super::extractor::clear_shared_candidates();
    super::extractor::prime_shared_candidates(&chunk.data);

    let mut aggregate = DecodeAdmission::Impossible;
    for decoder in plan.decoders() {
        match decoder.admission(chunk, policy) {
            DecodeAdmission::Possible => {
                aggregate = DecodeAdmission::Possible;
                break;
            }
            DecodeAdmission::Unknown => aggregate = DecodeAdmission::Unknown,
            DecodeAdmission::Impossible => {}
        }
    }

    super::extractor::clear_shared_candidates();
    aggregate
}

#[cfg(any(feature = "decode", test))]
pub(crate) fn decoder_admission_sketch(
    chunk: &keyhog_core::Chunk,
    policy: &super::super::policy::CompiledDecodeTransformPolicy,
    plan: &CompiledDecoderPlan,
) -> DecodeAdmissionSketch {
    decoder_admission_sketch_with_decoders(chunk, policy, plan.decoders())
}

#[cfg(any(feature = "decode", test))]
pub(crate) fn active_decoder_admission_sketch(
    chunk: &keyhog_core::Chunk,
    policy: &super::super::policy::CompiledDecodeTransformPolicy,
) -> DecodeAdmissionSketch {
    let decoders = active_decoders();
    decoder_admission_sketch_with_decoders(chunk, policy, &decoders)
}

#[cfg(any(feature = "decode", test))]
fn decoder_admission_sketch_with_decoders(
    chunk: &keyhog_core::Chunk,
    policy: &super::super::policy::CompiledDecodeTransformPolicy,
    decoders: &[RegisteredDecoder],
) -> DecodeAdmissionSketch {
    super::extractor::clear_shared_candidates();
    super::extractor::prime_shared_candidates(&chunk.data);

    let mut aggregate = DecodeAdmissionSketch::NONE;
    for decoder in decoders {
        aggregate.merge(decoder.admission_sketch(chunk, policy));
    }

    super::extractor::clear_shared_candidates();
    aggregate
}

fn decoder_registry() -> &'static RwLock<DecoderRegistryState> {
    DECODERS.get_or_init(|| {
        RwLock::new(DecoderRegistryState {
            decoders: Arc::new(default_decoders()),
            compatibility_failure: None,
        })
    })
}

#[cfg(not(test))]
pub(super) fn active_decoders() -> Arc<Vec<RegisteredDecoder>> {
    // One `Arc` clone (a single atomic increment) instead of deep-cloning the
    // decoder Vec on every `decode_chunk`. Callers only iterate, so the shared
    // snapshot suffices.
    Arc::clone(&decoder_registry().read().decoders)
}

#[cfg(test)]
pub(super) fn active_decoders() -> Arc<Vec<RegisteredDecoder>> {
    let base = Arc::clone(&decoder_registry().read().decoders);
    THREAD_DECODERS.with(|thread_decoders| {
        let thread = thread_decoders.borrow();
        if thread.is_empty() {
            // Common case: no per-test decoder registered, hand back the shared
            // snapshot with no allocation, matching the non-test fast path.
            base
        } else {
            let mut combined = (*base).clone();
            combined.extend(thread.iter().cloned().map(RegisteredDecoder::Shared));
            Arc::new(combined)
        }
    })
}

#[cfg(not(test))]
fn snapshot_decoders() -> Result<Arc<Vec<RegisteredDecoder>>, DecoderRegistrationError> {
    let registry = decoder_registry().read();
    if let Some(error) = registry.compatibility_failure.clone() {
        Err(error)
    } else {
        Ok(Arc::clone(&registry.decoders))
    }
}

#[cfg(test)]
fn snapshot_decoders() -> Result<Arc<Vec<RegisteredDecoder>>, DecoderRegistrationError> {
    let base = {
        let registry = decoder_registry().read();
        if let Some(error) = registry.compatibility_failure.clone() {
            return Err(error);
        }
        Arc::clone(&registry.decoders)
    };
    THREAD_DECODERS.with(|thread_decoders| {
        let thread = thread_decoders.borrow();
        if thread.is_empty() {
            Ok(base)
        } else {
            let mut combined = (*base).clone();
            combined.extend(thread.iter().cloned().map(RegisteredDecoder::Shared));
            Ok(Arc::new(combined))
        }
    })
}

/// Register a custom decoder for scanners compiled afterward.
///
/// Use [`try_register_decoder`] when the caller can handle a registration
/// error. This compatibility entry point records any error, and later scanner
/// compilation returns it. Existing compiled scanners retain their immutable
/// decoder plan.
pub fn register_decoder(decoder: Box<dyn Decoder>) {
    if let Err(error) = register_decoder_inner(decoder, true) {
        tracing::error!(%error, "decoder registration failed; later scanner compilation will fail");
    }
}

/// Register a custom decoder and return descriptor or collision errors.
///
/// The name and version must be non-empty ASCII without whitespace. A name can
/// be registered only once. Existing compiled scanners retain their immutable
/// decoder plan.
pub fn try_register_decoder(decoder: Box<dyn Decoder>) -> Result<(), DecoderRegistrationError> {
    register_decoder_inner(decoder, false)
}

fn register_decoder_inner(
    decoder: Box<dyn Decoder>,
    record_failure: bool,
) -> Result<(), DecoderRegistrationError> {
    let decoder_name = decoder.name();
    let mut guard = decoder_registry().write();
    if let Some(error) = guard.compatibility_failure.clone() {
        return Err(error);
    }
    let result = validate_descriptor(decoder_name, decoder.version()).and_then(|()| {
        if guard
            .decoders
            .iter()
            .any(|existing| existing.name() == decoder_name)
        {
            Err(DecoderRegistrationError::DuplicateName(decoder_name))
        } else {
            Ok(())
        }
    });
    if let Err(error) = result {
        if record_failure && guard.compatibility_failure.is_none() {
            guard.compatibility_failure = Some(error.clone());
        }
        return Err(error);
    }
    // Copy-on-write: publish a fresh snapshot so any `active_decoders()` Arc
    // already handed out keeps its consistent view. Registration happens at
    // startup / test setup, never on the decode hot path, so this one-time Vec
    // clone is not a concern.
    let mut next = (*guard.decoders).clone();
    next.push(RegisteredDecoder::Shared(Arc::from(decoder)));
    guard.decoders = Arc::new(next);
    Ok(())
}

#[cfg(test)]
pub(crate) struct ScopedDecoderRegistration {
    name: &'static str,
    active: bool,
}

#[cfg(test)]
impl Drop for ScopedDecoderRegistration {
    fn drop(&mut self) {
        if !self.active {
            return;
        }
        THREAD_DECODERS.with(|thread_decoders| {
            let mut decoders = thread_decoders.borrow_mut();
            if let Some(index) = decoders
                .iter()
                .rposition(|decoder| decoder.name() == self.name)
            {
                decoders.remove(index);
            }
        });
    }
}

#[cfg(test)]
pub(crate) fn register_thread_decoder(decoder: Box<dyn Decoder>) -> ScopedDecoderRegistration {
    let decoder_name = decoder.name();
    let has_global_duplicate = decoder_registry()
        .read()
        .decoders
        .iter()
        .any(|existing| existing.name() == decoder_name);
    if has_global_duplicate {
        tracing::warn!(
            decoder = decoder_name,
            "register_thread_decoder called with a duplicate global decoder name; decoder ignored"
        );
        return ScopedDecoderRegistration {
            name: decoder_name,
            active: false,
        };
    }

    let mut inserted = false;
    let decoder = Arc::from(decoder);
    THREAD_DECODERS.with(|thread_decoders| {
        let mut decoders = thread_decoders.borrow_mut();
        if decoders.iter().any(|existing| existing.name() == decoder_name) {
            tracing::warn!(
                decoder = decoder_name,
                "register_thread_decoder called with a duplicate thread decoder name; decoder ignored"
            );
            return;
        }
        decoders.push(decoder);
        inserted = true;
    });
    ScopedDecoderRegistration {
        name: decoder_name,
        active: inserted,
    }
}

#[cfg(test)]
#[path = "../../../tests/unit/decode_admission_soundness.rs"]
mod admission_soundness_tests;