keeper-secrets-manager-core 17.3.0

Rust SDK for Keeper Secrets Manager
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
// -*- coding: utf-8 -*-
//  _  __
// | |/ /___ ___ _ __  ___ _ _ (R)
// | ' </ -_) -_) '_ \/ -_) '_|
// |_|\_\___\___| .__/\___|_|
//              |_|
//
// Keeper Secrets Manager
// Copyright 2024 Keeper Security Inc.
// Contact: sm@keepersecurity.com
//

#[cfg(test)]
mod integration_tests {
    use keeper_secrets_manager_core::config_keys::ConfigKeys;
    use keeper_secrets_manager_core::core::{ClientOptions, SecretsManager};
    use keeper_secrets_manager_core::crypto::CryptoUtils;
    use keeper_secrets_manager_core::custom_error::KSMRError;
    use keeper_secrets_manager_core::dto::payload::UpdateTransactionType;
    use keeper_secrets_manager_core::dto::{EncryptedPayload, KsmHttpResponse, TransmissionKey};
    use keeper_secrets_manager_core::enums::{KvStoreType, StandardFieldTypeEnum};
    use keeper_secrets_manager_core::storage::{InMemoryKeyValueStorage, KeyValueStorage};
    use serde_json::{json, Value};
    use std::cell::RefCell;
    use std::sync::atomic::{AtomicUsize, Ordering};

    /// Helper function to create a mock storage with initialized config
    fn create_mock_storage() -> Result<KvStoreType, KSMRError> {
        let storage = InMemoryKeyValueStorage::new(None)?;
        let mut kv_store = KvStoreType::InMemory(storage);

        // Generate a real private key using the SDK's crypto utilities
        let private_key = CryptoUtils::generate_private_key_ecc()?;
        let private_key_der = CryptoUtils::generate_private_key_der()?; // Generate new DER-encoded private key
        let private_key_base64 =
            keeper_secrets_manager_core::utils::bytes_to_base64(&private_key_der);

        // Generate corresponding public key
        let public_key_bytes = CryptoUtils::public_key_ecc(&private_key); // Returns Vec<u8>
        let public_key_base64 =
            keeper_secrets_manager_core::utils::bytes_to_base64(&public_key_bytes);

        // Set up minimal config for testing
        kv_store.set(ConfigKeys::KeyClientId, "TEST_CLIENT_ID".to_string())?;
        kv_store.set(
            ConfigKeys::KeyAppKey,
            "dGVzdF9hcHBfa2V5X2Jhc2U2NF9lbmNvZGVkX3ZhbHVlAAAAAAAAAAAA".to_string(), // base64 encoded 32-byte key
        )?;
        kv_store.set(ConfigKeys::KeyServerPublicKeyId, "10".to_string())?;
        kv_store.set(
            ConfigKeys::KeyHostname,
            "fake.keepersecurity.com".to_string(),
        )?;
        kv_store.set(ConfigKeys::KeyPrivateKey, private_key_base64)?;
        kv_store.set(ConfigKeys::KeyOwnerPublicKey, public_key_base64)?;

        Ok(kv_store)
    }

    /// Mock response generator for successful update operations
    fn mock_update_success_response(
        _url: String,
        transmission_key: TransmissionKey,
        _encrypted_payload: EncryptedPayload,
    ) -> Result<KsmHttpResponse, KSMRError> {
        // Simulate successful update response (empty encrypted response)
        let response_data = json!({
            "status": "success"
        });
        let response_bytes = response_data.to_string().into_bytes();
        let encrypted_response =
            CryptoUtils::encrypt_aes_gcm(&response_bytes, &transmission_key.key, None)?;

        Ok(KsmHttpResponse {
            status_code: 200,
            data: encrypted_response,
            http_response: None,
        })
    }

    /// Mock response generator for successful transaction completion
    fn mock_transaction_success_response(
        _url: String,
        transmission_key: TransmissionKey,
        _encrypted_payload: EncryptedPayload,
    ) -> Result<KsmHttpResponse, KSMRError> {
        // Simulate successful transaction completion (empty response)
        let encrypted_response = CryptoUtils::encrypt_aes_gcm(&[], &transmission_key.key, None)?;

        Ok(KsmHttpResponse {
            status_code: 200,
            data: encrypted_response,
            http_response: None,
        })
    }

    /// Mock response generator that simulates errors
    fn mock_error_response(
        _url: String,
        transmission_key: TransmissionKey,
        _encrypted_payload: EncryptedPayload,
    ) -> Result<KsmHttpResponse, KSMRError> {
        let error_data = json!({
            "error": "access_denied",
            "message": "Invalid record UID"
        });
        let error_bytes = error_data.to_string().into_bytes();
        let error_string = String::from_utf8(error_bytes.clone()).unwrap();
        let encrypted_error =
            CryptoUtils::encrypt_aes_gcm(&error_bytes, &transmission_key.key, None)?;

        Ok(KsmHttpResponse {
            status_code: 403,
            data: encrypted_error,
            http_response: Some(error_string),
        })
    }

    #[test]
    fn test_update_secret_integration_success() {
        // Integration test for update_secret with mocked HTTP
        let storage = create_mock_storage().expect("Failed to create storage");
        let mut client_options = ClientOptions::new_client_options(storage);
        client_options.set_custom_post_function(mock_update_success_response);

        let mut secrets_manager =
            SecretsManager::new(client_options).expect("Failed to create SecretsManager");

        // Create a test record to update
        let mut record_dict = std::collections::HashMap::new();
        record_dict.insert("title".to_string(), json!("Test Record"));
        record_dict.insert("type".to_string(), json!("login"));
        record_dict.insert(
            "fields".to_string(),
            json!([
                {
                    "type": "password",
                    "value": ["OldPassword123"]
                }
            ]),
        );

        let mut record = keeper_secrets_manager_core::dto::Record {
            uid: "test-uid-123".to_string(),
            title: "Test Record".to_string(),
            record_type: "login".to_string(),
            files: vec![],
            raw_json: serde_json::to_string(&record_dict).unwrap(),
            record_dict,
            password: Some("OldPassword123".to_string()),
            revision: Some(1),
            is_editable: true,
            folder_uid: "folder-uid".to_string(),
            inner_folder_uid: None,
            record_key_bytes: vec![
                1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23,
                24, 25, 26, 27, 28, 29, 30, 31, 32,
            ], // 32-byte key
            folder_key_bytes: None,
            links: vec![],
        };

        // Modify the password
        record
            .set_standard_field_value_mut(
                StandardFieldTypeEnum::PASSWORD.get_type(),
                Value::String("NewPassword456!".to_string()),
            )
            .expect("Failed to set password");

        // Update the record - this should succeed with our mock
        let result = secrets_manager.update_secret(record);

        assert!(
            result.is_ok(),
            "update_secret should succeed with mock: {:?}",
            result
        );
    }

    #[test]
    fn test_update_secret_with_transaction_type() {
        // Integration test for update_secret_with_transaction
        let storage = create_mock_storage().expect("Failed to create storage");
        let mut client_options = ClientOptions::new_client_options(storage);
        client_options.set_custom_post_function(mock_update_success_response);

        let mut secrets_manager =
            SecretsManager::new(client_options).expect("Failed to create SecretsManager");

        // Create a test record
        let mut record_dict = std::collections::HashMap::new();
        record_dict.insert("title".to_string(), json!("Test Record"));
        record_dict.insert("type".to_string(), json!("login"));
        record_dict.insert(
            "fields".to_string(),
            json!([{"type": "password", "value": ["OldPassword"]}]),
        );

        let mut record = keeper_secrets_manager_core::dto::Record {
            uid: "test-uid-456".to_string(),
            title: "Test Record".to_string(),
            record_type: "login".to_string(),
            files: vec![],
            raw_json: serde_json::to_string(&record_dict).unwrap(),
            record_dict,
            password: Some("OldPassword".to_string()),
            revision: Some(2),
            is_editable: true,
            folder_uid: "folder-uid".to_string(),
            inner_folder_uid: None,
            record_key_bytes: vec![0; 32],
            folder_key_bytes: None,
            links: vec![],
        };

        // Modify password
        record
            .set_standard_field_value_mut("password", Value::String("NewRotatedPass!".to_string()))
            .expect("Failed to set password");

        // Update with rotation transaction type
        let result =
            secrets_manager.update_secret_with_transaction(record, UpdateTransactionType::Rotation);

        assert!(
            result.is_ok(),
            "update_secret_with_transaction should succeed: {:?}",
            result
        );
    }

    #[test]
    fn test_complete_transaction_commit() {
        // Integration test for complete_transaction (commit)
        let storage = create_mock_storage().expect("Failed to create storage");
        let mut client_options = ClientOptions::new_client_options(storage);
        client_options.set_custom_post_function(mock_transaction_success_response);

        let mut secrets_manager =
            SecretsManager::new(client_options).expect("Failed to create SecretsManager");

        // Complete a transaction (commit)
        let result = secrets_manager.complete_transaction("test-record-uid".to_string(), false);

        assert!(
            result.is_ok(),
            "complete_transaction (commit) should succeed: {:?}",
            result
        );
    }

    #[test]
    fn test_complete_transaction_rollback() {
        // Integration test for complete_transaction (rollback)
        let storage = create_mock_storage().expect("Failed to create storage");
        let mut client_options = ClientOptions::new_client_options(storage);
        client_options.set_custom_post_function(mock_transaction_success_response);

        let mut secrets_manager =
            SecretsManager::new(client_options).expect("Failed to create SecretsManager");

        // Complete a transaction (rollback)
        let result = secrets_manager.complete_transaction("test-record-uid".to_string(), true);

        assert!(
            result.is_ok(),
            "complete_transaction (rollback) should succeed: {:?}",
            result
        );
    }

    #[test]
    fn test_update_secret_integration_error_handling() {
        // Integration test for update_secret error handling
        let storage = create_mock_storage().expect("Failed to create storage");
        let mut client_options = ClientOptions::new_client_options(storage);
        client_options.set_custom_post_function(mock_error_response);

        let mut secrets_manager =
            SecretsManager::new(client_options).expect("Failed to create SecretsManager");

        // Create a test record
        let mut record_dict = std::collections::HashMap::new();
        record_dict.insert("title".to_string(), json!("Test Record"));
        record_dict.insert("type".to_string(), json!("login"));
        record_dict.insert("fields".to_string(), json!([]));

        let record = keeper_secrets_manager_core::dto::Record {
            uid: "invalid-uid".to_string(),
            title: "Test Record".to_string(),
            record_type: "login".to_string(),
            files: vec![],
            raw_json: serde_json::to_string(&record_dict).unwrap(),
            record_dict,
            password: None,
            revision: Some(1),
            is_editable: true,
            folder_uid: "folder-uid".to_string(),
            inner_folder_uid: None,
            record_key_bytes: vec![0; 32],
            folder_key_bytes: None,
            links: vec![],
        };

        // Update should fail with 403 error
        let result = secrets_manager.update_secret(record);

        assert!(
            result.is_err(),
            "update_secret should fail with error response"
        );
    }

    #[test]
    fn test_password_rotation_workflow() {
        // End-to-end test for password rotation workflow
        let storage = create_mock_storage().expect("Failed to create storage");
        let mut client_options = ClientOptions::new_client_options(storage);

        // Use a counter to track which endpoint is being called
        thread_local! {
            static CALL_COUNT: RefCell<usize> = RefCell::new(0);
        }

        // Custom post function that handles both update and transaction endpoints
        fn rotation_workflow_mock(
            _url: String,
            transmission_key: TransmissionKey,
            _encrypted_payload: EncryptedPayload,
        ) -> Result<KsmHttpResponse, KSMRError> {
            thread_local! {
                static CALL_NUMBER: AtomicUsize = AtomicUsize::new(0);
            }

            let call_num = CALL_NUMBER.with(|c| c.fetch_add(1, Ordering::SeqCst));

            // First call: update_secret (rotation)
            // Second call: finalize_secret_update
            let response_data = if call_num == 0 {
                // Update response
                json!({"status": "pending"})
            } else {
                // Complete transaction response
                json!({"status": "success"})
            };

            let response_bytes = response_data.to_string().into_bytes();
            let encrypted_response =
                CryptoUtils::encrypt_aes_gcm(&response_bytes, &transmission_key.key, None)?;

            Ok(KsmHttpResponse {
                status_code: 200,
                data: encrypted_response,
                http_response: None,
            })
        }

        client_options.set_custom_post_function(rotation_workflow_mock);

        let mut secrets_manager =
            SecretsManager::new(client_options).expect("Failed to create SecretsManager");

        // Create a test record
        let mut record_dict = std::collections::HashMap::new();
        record_dict.insert("title".to_string(), json!("Password Rotation Test"));
        record_dict.insert("type".to_string(), json!("login"));
        record_dict.insert(
            "fields".to_string(),
            json!([{"type": "password", "value": ["OldPassword123"]}]),
        );

        let mut record = keeper_secrets_manager_core::dto::Record {
            uid: "rotation-test-uid".to_string(),
            title: "Password Rotation Test".to_string(),
            record_type: "login".to_string(),
            files: vec![],
            raw_json: serde_json::to_string(&record_dict).unwrap(),
            record_dict,
            password: Some("OldPassword123".to_string()),
            revision: Some(5),
            is_editable: true,
            folder_uid: "folder-uid".to_string(),
            inner_folder_uid: None,
            record_key_bytes: vec![0; 32],
            folder_key_bytes: None,
            links: vec![],
        };

        let record_uid = record.uid.clone();

        // Step 1: Update password with rotation transaction
        record
            .set_standard_field_value_mut(
                "password",
                Value::String("NewRotatedPassword!".to_string()),
            )
            .expect("Failed to set password");

        let update_result =
            secrets_manager.update_secret_with_transaction(record, UpdateTransactionType::Rotation);

        assert!(
            update_result.is_ok(),
            "Rotation update should succeed: {:?}",
            update_result
        );

        // Step 2: Finalize the transaction
        let finalize_result = secrets_manager.complete_transaction(record_uid, false);

        assert!(
            finalize_result.is_ok(),
            "Transaction finalization should succeed: {:?}",
            finalize_result
        );
    }

    #[test]
    fn test_password_rotation_with_rollback() {
        // Test password rotation with rollback scenario
        let storage = create_mock_storage().expect("Failed to create storage");
        let mut client_options = ClientOptions::new_client_options(storage);
        client_options.set_custom_post_function(mock_transaction_success_response);

        let mut secrets_manager =
            SecretsManager::new(client_options).expect("Failed to create SecretsManager");

        // Simulate rolling back a transaction (testing failed, revert to old password)
        let result = secrets_manager.complete_transaction("test-rollback-uid".to_string(), true);

        assert!(
            result.is_ok(),
            "Transaction rollback should succeed: {:?}",
            result
        );
    }

    #[test]
    fn test_update_with_general_transaction() {
        // Test update with General transaction type
        let storage = create_mock_storage().expect("Failed to create storage");
        let mut client_options = ClientOptions::new_client_options(storage);
        client_options.set_custom_post_function(mock_update_success_response);

        let mut secrets_manager =
            SecretsManager::new(client_options).expect("Failed to create SecretsManager");

        let mut record_dict = std::collections::HashMap::new();
        record_dict.insert("title".to_string(), json!("General Update Test"));
        record_dict.insert("type".to_string(), json!("login"));
        record_dict.insert("fields".to_string(), json!([]));

        let record = keeper_secrets_manager_core::dto::Record {
            uid: "general-update-uid".to_string(),
            title: "General Update Test".to_string(),
            record_type: "login".to_string(),
            files: vec![],
            raw_json: serde_json::to_string(&record_dict).unwrap(),
            record_dict,
            password: None,
            revision: Some(3),
            is_editable: true,
            folder_uid: "folder-uid".to_string(),
            inner_folder_uid: None,
            record_key_bytes: vec![0; 32],
            folder_key_bytes: None,
            links: vec![],
        };

        // Update with General transaction type
        let result =
            secrets_manager.update_secret_with_transaction(record, UpdateTransactionType::General);

        assert!(
            result.is_ok(),
            "General transaction update should succeed: {:?}",
            result
        );
    }

    #[test]
    fn test_update_secret_validates_encryption() {
        // Test that update_secret properly encrypts the record data
        let storage = create_mock_storage().expect("Failed to create storage");
        let mut client_options = ClientOptions::new_client_options(storage);

        // Custom validator that checks if payload is encrypted
        fn validate_encryption_mock(
            _url: String,
            transmission_key: TransmissionKey,
            encrypted_payload: EncryptedPayload,
        ) -> Result<KsmHttpResponse, KSMRError> {
            // Verify encrypted payload is not empty
            assert!(
                !encrypted_payload.encrypted_payload.is_empty(),
                "Encrypted payload should not be empty"
            );

            // Note: Signature is an ecdsa::Signature type and is always present
            // (the type system guarantees this)

            // Return success response
            let encrypted_response =
                CryptoUtils::encrypt_aes_gcm(&[], &transmission_key.key, None)?;
            Ok(KsmHttpResponse {
                status_code: 200,
                data: encrypted_response,
                http_response: None,
            })
        }

        client_options.set_custom_post_function(validate_encryption_mock);

        let mut secrets_manager =
            SecretsManager::new(client_options).expect("Failed to create SecretsManager");

        let mut record_dict = std::collections::HashMap::new();
        record_dict.insert("title".to_string(), json!("Encryption Test"));
        record_dict.insert("type".to_string(), json!("login"));
        record_dict.insert("fields".to_string(), json!([]));

        let record = keeper_secrets_manager_core::dto::Record {
            uid: "encryption-test-uid".to_string(),
            title: "Encryption Test".to_string(),
            record_type: "login".to_string(),
            files: vec![],
            raw_json: serde_json::to_string(&record_dict).unwrap(),
            record_dict,
            password: None,
            revision: Some(1),
            is_editable: true,
            folder_uid: "folder-uid".to_string(),
            inner_folder_uid: None,
            record_key_bytes: vec![0; 32],
            folder_key_bytes: None,
            links: vec![],
        };

        // Update should trigger validation in our mock
        let result = secrets_manager.update_secret(record);

        assert!(
            result.is_ok(),
            "Update with encryption validation should succeed: {:?}",
            result
        );
    }

    #[test]
    fn test_multiple_sequential_updates() {
        // Test multiple updates to the same record
        let storage = create_mock_storage().expect("Failed to create storage");
        let mut client_options = ClientOptions::new_client_options(storage);

        // Counter for tracking multiple calls
        thread_local! {
            static UPDATE_COUNT: AtomicUsize = AtomicUsize::new(0);
        }

        fn multi_update_mock(
            _url: String,
            transmission_key: TransmissionKey,
            _encrypted_payload: EncryptedPayload,
        ) -> Result<KsmHttpResponse, KSMRError> {
            let count = UPDATE_COUNT.with(|c| c.fetch_add(1, Ordering::SeqCst));

            // Each update succeeds
            let response_data = json!({
                "status": "success",
                "update_number": count
            });
            let response_bytes = response_data.to_string().into_bytes();
            let encrypted_response =
                CryptoUtils::encrypt_aes_gcm(&response_bytes, &transmission_key.key, None)?;

            Ok(KsmHttpResponse {
                status_code: 200,
                data: encrypted_response,
                http_response: None,
            })
        }

        client_options.set_custom_post_function(multi_update_mock);

        let mut secrets_manager =
            SecretsManager::new(client_options).expect("Failed to create SecretsManager");

        // Perform multiple updates
        for i in 1..=3 {
            let mut record_dict = std::collections::HashMap::new();
            record_dict.insert("title".to_string(), json!(format!("Update {}", i)));
            record_dict.insert("type".to_string(), json!("login"));
            record_dict.insert("fields".to_string(), json!([]));

            let record = keeper_secrets_manager_core::dto::Record {
                uid: "multi-update-uid".to_string(),
                title: format!("Update {}", i),
                record_type: "login".to_string(),
                files: vec![],
                raw_json: serde_json::to_string(&record_dict).unwrap(),
                record_dict,
                password: None,
                revision: Some(i),
                is_editable: true,
                folder_uid: "folder-uid".to_string(),
                inner_folder_uid: None,
                record_key_bytes: vec![0; 32],
                folder_key_bytes: None,
                links: vec![],
            };

            let result = secrets_manager.update_secret(record);
            assert!(result.is_ok(), "Update {} should succeed: {:?}", i, result);
        }

        // Verify 3 updates were performed
        let final_count = UPDATE_COUNT.with(|c| c.load(Ordering::SeqCst));
        assert_eq!(final_count, 3, "Should have made 3 update calls");
    }

    #[test]
    fn test_custom_post_function_receives_correct_url() {
        // Test that custom post function receives the correct URL for each operation
        let storage = create_mock_storage().expect("Failed to create storage");
        let mut client_options = ClientOptions::new_client_options(storage);

        // Capture the URL to verify it's correct
        thread_local! {
            static CAPTURED_URL: RefCell<String> = RefCell::new(String::new());
        }

        fn url_capture_mock(
            url: String,
            transmission_key: TransmissionKey,
            _encrypted_payload: EncryptedPayload,
        ) -> Result<KsmHttpResponse, KSMRError> {
            // Store the URL for assertion
            CAPTURED_URL.with(|captured| {
                *captured.borrow_mut() = url.clone();
            });

            // Return success response
            let encrypted_response =
                CryptoUtils::encrypt_aes_gcm(&[], &transmission_key.key, None)?;
            Ok(KsmHttpResponse {
                status_code: 200,
                data: encrypted_response,
                http_response: None,
            })
        }

        client_options.set_custom_post_function(url_capture_mock);

        let mut secrets_manager =
            SecretsManager::new(client_options).expect("Failed to create SecretsManager");

        let mut record_dict = std::collections::HashMap::new();
        record_dict.insert("title".to_string(), json!("URL Test"));
        record_dict.insert("type".to_string(), json!("login"));
        record_dict.insert("fields".to_string(), json!([]));

        let record = keeper_secrets_manager_core::dto::Record {
            uid: "url-test-uid".to_string(),
            title: "URL Test".to_string(),
            record_type: "login".to_string(),
            files: vec![],
            raw_json: serde_json::to_string(&record_dict).unwrap(),
            record_dict,
            password: None,
            revision: Some(1),
            is_editable: true,
            folder_uid: "folder-uid".to_string(),
            inner_folder_uid: None,
            record_key_bytes: vec![0; 32],
            folder_key_bytes: None,
            links: vec![],
        };

        secrets_manager.update_secret(record).ok();

        // Verify the URL contains update_secret endpoint
        let url = CAPTURED_URL.with(|captured| captured.borrow().clone());
        assert!(
            url.contains("update_secret"),
            "URL should contain update_secret endpoint, got: {}",
            url
        );
        assert!(
            url.contains("fake.keepersecurity.com"),
            "URL should contain hostname, got: {}",
            url
        );
    }

    #[test]
    fn test_transaction_endpoints_correct() {
        // Test that complete_transaction uses correct endpoints for finalize/rollback
        let storage = create_mock_storage().expect("Failed to create storage");

        thread_local! {
            static CAPTURED_URLS: RefCell<Vec<String>> = RefCell::new(Vec::new());
        }

        fn endpoint_capture_mock(
            url: String,
            transmission_key: TransmissionKey,
            _encrypted_payload: EncryptedPayload,
        ) -> Result<KsmHttpResponse, KSMRError> {
            CAPTURED_URLS.with(|urls| {
                urls.borrow_mut().push(url.clone());
            });

            let encrypted_response =
                CryptoUtils::encrypt_aes_gcm(&[], &transmission_key.key, None)?;
            Ok(KsmHttpResponse {
                status_code: 200,
                data: encrypted_response,
                http_response: None,
            })
        }

        // Test finalize endpoint
        let mut client_options = ClientOptions::new_client_options(storage.clone());
        client_options.set_custom_post_function(endpoint_capture_mock);

        let mut secrets_manager =
            SecretsManager::new(client_options).expect("Failed to create SecretsManager");

        secrets_manager
            .complete_transaction("test-uid-1".to_string(), false)
            .ok();

        let finalize_url = CAPTURED_URLS.with(|urls| urls.borrow()[0].clone());
        assert!(
            finalize_url.contains("finalize_secret_update"),
            "Commit should use finalize_secret_update endpoint, got: {}",
            finalize_url
        );

        // Reset and test rollback endpoint
        CAPTURED_URLS.with(|urls| urls.borrow_mut().clear());

        let storage2 = create_mock_storage().expect("Failed to create storage");
        let mut client_options2 = ClientOptions::new_client_options(storage2);
        client_options2.set_custom_post_function(endpoint_capture_mock);

        let mut secrets_manager2 =
            SecretsManager::new(client_options2).expect("Failed to create SecretsManager");

        secrets_manager2
            .complete_transaction("test-uid-2".to_string(), true)
            .ok();

        let rollback_url = CAPTURED_URLS.with(|urls| urls.borrow()[0].clone());
        assert!(
            rollback_url.contains("rollback_secret_update"),
            "Rollback should use rollback_secret_update endpoint, got: {}",
            rollback_url
        );
    }
}