kcl-lib 0.2.186

KittyCAD Language implementation and tools
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
use std::collections::HashMap;
use std::sync::Arc;
use std::time::Duration;
use std::time::Instant;

use anyhow::anyhow;
use futures::SinkExt;
use futures::StreamExt;
use kcmc::ModelingCmd;
use kcmc::websocket::BatchResponse;
use kcmc::websocket::FailureWebSocketResponse;
use kcmc::websocket::ModelingCmdReq;
use kcmc::websocket::ModelingSessionData;
use kcmc::websocket::OkWebSocketResponseData;
use kcmc::websocket::SuccessWebSocketResponse;
use kcmc::websocket::WebSocketRequest;
use kcmc::websocket::WebSocketResponse;
use kittycad_modeling_cmds as kcmc;
use tokio::sync::RwLock;
use tokio::sync::mpsc;
use tokio::sync::oneshot;
use tokio_tungstenite::tungstenite::Message as WsMsg;
use uuid::Uuid;

use super::EngineTransport;
use super::ResponseInformation;
use super::SocketHealth;
use super::TransportCloseError;
use crate::SourceRange;
use crate::errors::KclError;
use crate::errors::KclErrorDetails;
use crate::log::logln;

pub struct TcpRead {
    stream: futures::stream::SplitStream<tokio_tungstenite::WebSocketStream<reqwest::Upgraded>>,
}

impl TcpRead {
    pub async fn read(&mut self) -> std::result::Result<WebSocketResponse, WebSocketReadError> {
        let Some(msg) = self.stream.next().await else {
            return Err(anyhow!("Failed to read from WebSocket").into());
        };
        let msg = match msg {
            Ok(msg) => msg,
            Err(e) if matches!(e, tokio_tungstenite::tungstenite::Error::Protocol(_)) => {
                return Err(WebSocketReadError::Read(e));
            }
            Err(e) => return Err(anyhow!("Error reading from engine's WebSocket: {e}").into()),
        };
        match msg {
            WsMsg::Text(text) => kcl_engine_codec::deserialize_response_json(&text)
                .map_err(anyhow::Error::from)
                .map_err(WebSocketReadError::from),
            WsMsg::Binary(bin) => kcl_engine_codec::deserialize_response_msgpack(&bin)
                .map_err(anyhow::Error::from)
                .map_err(WebSocketReadError::from),
            WsMsg::Close(close_frame) => {
                let err_msg = close_frame
                    .map(|frame| frame.reason.to_string())
                    .unwrap_or("WebSocket closed without specifying a reason.".to_string());
                Err(anyhow!(err_msg).into())
            }
            other => Err(anyhow!("Unexpected WebSocket message from engine API: {other}").into()),
        }
    }
}

type WebSocketTcpWrite = futures::stream::SplitSink<tokio_tungstenite::WebSocketStream<reqwest::Upgraded>, WsMsg>;
const CLOSE_HANDSHAKE_TIMEOUT: Duration = Duration::from_secs(1);

/// Sends requests to the engine over its Modeling API WebSocket.
/// Used on native platforms, does not work in browser WASM sandbox.
pub struct WebSocketTransport {
    tcp_read_handle: tokio::task::AbortHandle,
    tcp_write_handle: tokio::task::AbortHandle,
    engine_req_tx: mpsc::Sender<ToEngineReq>,
    shutdown_tx: mpsc::Sender<()>,
    responses: ResponseInformation,
    pending_errors: Arc<RwLock<Vec<String>>>,
    session_data: Arc<RwLock<Option<ModelingSessionData>>>,
    socket_health: Arc<RwLock<SocketHealth>>,
    upgrade_request_id: Option<String>,
}

impl Drop for WebSocketTransport {
    fn drop(&mut self) {
        self.tcp_read_handle.abort();
        self.tcp_write_handle.abort();
    }
}

/// Occurs when client couldn't read from the WebSocket to the engine.
#[allow(clippy::large_enum_variant)]
pub enum WebSocketReadError {
    /// Could not read a message due to WebSocket errors.
    Read(tokio_tungstenite::tungstenite::Error),
    /// WebSocket message didn't contain a valid message that the KCL Executor could parse.
    Deser(anyhow::Error),
}

impl From<anyhow::Error> for WebSocketReadError {
    fn from(e: anyhow::Error) -> Self {
        Self::Deser(e)
    }
}

/// Requests to send to the engine, and a way to await a response.
struct ToEngineReq {
    /// The request to send
    req: WebSocketRequest,
    /// If this resolves to Ok, the request was sent.
    /// If this resolves to Err, the request could not be sent.
    /// If this has not yet resolved, the request has not been sent yet.
    request_sent: oneshot::Sender<anyhow::Result<()>>,
}

impl WebSocketTransport {
    /// Start a long-lived actor that reads from
    pub async fn spawn(
        // Passed via EngineManager from elsewhere
        ws: reqwest::Upgraded,
        heartbeats: Option<u64>,

        // Created by EngineManager
        response_information: ResponseInformation,
        session_data: Arc<RwLock<Option<ModelingSessionData>>>,
        pending_errors: Arc<RwLock<Vec<String>>>,
        socket_health: Arc<RwLock<SocketHealth>>,
        upgrade_request_id: Option<String>,
    ) -> Self {
        let wsconfig = tokio_tungstenite::tungstenite::protocol::WebSocketConfig::default()
            // 4294967296 bytes, which is around 4.2 GB.
            .max_message_size(Some(usize::MAX))
            .max_frame_size(Some(usize::MAX));

        let ws_stream = tokio_tungstenite::WebSocketStream::from_raw_socket(
            ws,
            tokio_tungstenite::tungstenite::protocol::Role::Client,
            Some(wsconfig),
        )
        .await;

        let (tcp_write, tcp_read) = ws_stream.split();
        let (engine_req_tx, engine_req_rx) = mpsc::channel(10);
        let (shutdown_tx, shutdown_rx) = mpsc::channel(1);
        let tcp_write_handle = tokio::task::spawn(Self::start_write_actor(
            tcp_write,
            engine_req_rx,
            shutdown_rx,
            heartbeats,
        ));

        let mut tcp_read = TcpRead { stream: tcp_read };

        let response_information_for_read = response_information.clone();
        let session_data_for_read = session_data.clone();
        let pending_errors_for_read = pending_errors.clone();
        let socket_health_tcp_read = socket_health.clone();
        let tcp_read_handle: tokio::task::JoinHandle<Result<(), WebSocketReadError>> = tokio::spawn(async move {
            // Get Websocket messages from API server
            loop {
                match tcp_read.read().await {
                    Ok(ws_resp) => {
                        // If we got a batch response, add all the inner responses.
                        let id = ws_resp.request_id();
                        match &ws_resp {
                            WebSocketResponse::Success(SuccessWebSocketResponse {
                                resp: OkWebSocketResponseData::ModelingBatch { responses },
                                ..
                            }) => {
                                #[expect(
                                    clippy::iter_over_hash_type,
                                    reason = "modeling command uses a HashMap and keys are random, so we don't really have a choice"
                                )]
                                for (resp_id, batch_response) in responses {
                                    let id: uuid::Uuid = (*resp_id).into();
                                    match batch_response {
                                        BatchResponse::Success { response } => {
                                            // If the id is in our ids of async commands, remove
                                            // it.
                                            response_information_for_read
                                                .add(
                                                    id,
                                                    WebSocketResponse::Success(SuccessWebSocketResponse {
                                                        success: true,
                                                        request_id: Some(id),
                                                        resp: OkWebSocketResponseData::Modeling {
                                                            modeling_response: response.clone(),
                                                        },
                                                    }),
                                                )
                                                .await;
                                        }
                                        BatchResponse::Failure { errors } => {
                                            response_information_for_read
                                                .add(
                                                    id,
                                                    WebSocketResponse::Failure(FailureWebSocketResponse {
                                                        success: false,
                                                        request_id: Some(id),
                                                        errors: errors.clone(),
                                                    }),
                                                )
                                                .await;
                                        }
                                    }
                                }
                            }
                            WebSocketResponse::Success(SuccessWebSocketResponse {
                                resp: OkWebSocketResponseData::ModelingSessionData { session },
                                ..
                            }) => {
                                let mut sd = session_data_for_read.write().await;
                                sd.replace(session.clone());
                                logln!("API Call ID: {}", session.api_call_id);
                            }
                            WebSocketResponse::Failure(FailureWebSocketResponse {
                                success: _,
                                request_id,
                                errors,
                            }) => {
                                if let Some(id) = request_id {
                                    response_information_for_read
                                        .add(
                                            *id,
                                            WebSocketResponse::Failure(FailureWebSocketResponse {
                                                success: false,
                                                request_id: *request_id,
                                                errors: errors.clone(),
                                            }),
                                        )
                                        .await;
                                } else {
                                    // Add it to our pending errors.
                                    let mut pe = pending_errors_for_read.write().await;
                                    for error in errors {
                                        if !pe.contains(&error.message) {
                                            pe.push(error.message.clone());
                                        }
                                    }
                                    drop(pe);
                                }
                            }
                            WebSocketResponse::Success(SuccessWebSocketResponse {
                                resp: _debug @ OkWebSocketResponseData::Debug { .. },
                                ..
                            }) => {
                                // Deleted, I don't think this was ever used.
                            }
                            _ => {}
                        }

                        if let Some(id) = id {
                            response_information_for_read.add(id, ws_resp.clone()).await;
                        }
                    }
                    Err(e) => {
                        let msg = match &e {
                            WebSocketReadError::Read(e) => e.to_string(),
                            WebSocketReadError::Deser(e) => e.to_string(),
                        };
                        pending_errors_for_read.write().await.push(msg);
                        *socket_health_tcp_read.write().await = SocketHealth::Inactive;
                        return Err(e);
                    }
                }
            }
        });
        Self {
            shutdown_tx,
            responses: response_information,
            pending_errors,
            session_data,
            socket_health,
            upgrade_request_id,
            engine_req_tx,
            tcp_read_handle: tcp_read_handle.abort_handle(),
            tcp_write_handle: tcp_write_handle.abort_handle(),
        }
    }

    fn connection_id_message(&self, session: Option<&ModelingSessionData>) -> String {
        if let Some(session) = session {
            format!(" (API call ID: {})", session.api_call_id)
        } else if let Some(id) = &self.upgrade_request_id {
            format!(" (Engine upgrade request ID: {id})")
        } else {
            " (No API call ID: session data empty)".to_string()
        }
    }

    async fn inner_send_to_engine_binary(
        request: WebSocketRequest,
        tcp_write: &mut WebSocketTcpWrite,
    ) -> anyhow::Result<()> {
        let msg = kcl_engine_codec::serialize_request_msgpack(&request)
            .map_err(|e| anyhow!("could not serialize msgpack: {e}"))?;
        tcp_write
            .send(WsMsg::Binary(msg.into()))
            .await
            .map_err(|e| anyhow!("could not send MsgPack over websocket: {e}"))?;
        Ok(())
    }

    /// Send the given `request` to the engine via the WebSocket connection `tcp_write`.
    async fn inner_send_to_engine(request: WebSocketRequest, tcp_write: &mut WebSocketTcpWrite) -> anyhow::Result<()> {
        let msg =
            kcl_engine_codec::serialize_request_json(&request).map_err(|e| anyhow!("could not serialize json: {e}"))?;
        tcp_write
            .send(WsMsg::Text(msg.into()))
            .await
            .map_err(|e| anyhow!("could not send json over websocket: {e}"))?;
        Ok(())
    }

    async fn start_write_actor(
        mut tcp_write: WebSocketTcpWrite,
        mut engine_req_rx: mpsc::Receiver<ToEngineReq>,
        mut shutdown_rx: mpsc::Receiver<()>,
        heartbeats: Option<u64>,
    ) {
        let heartbeats = heartbeats.unwrap_or_default();
        let send_heartbeats = heartbeats != 0;
        let period_seconds = if heartbeats == 0 { 5 * 60 } else { heartbeats };
        let period = Duration::from_secs(period_seconds);
        let mut heartbeats_stream = tokio::time::interval(period);

        loop {
            tokio::select! {
                maybe_req = engine_req_rx.recv() => {
                    match maybe_req {
                        Some(ToEngineReq { req, request_sent }) => {
                            // Decide whether to send as binary or text,
                            // then send to the engine.
                            let res = if matches!(
                                &req,
                                WebSocketRequest::ModelingCmdReq(ModelingCmdReq {
                                    cmd: ModelingCmd::ImportFiles { .. },
                                    cmd_id: _,
                                })
                            ) {
                                Self::inner_send_to_engine_binary(req, &mut tcp_write).await
                            } else {
                                Self::inner_send_to_engine(req, &mut tcp_write).await
                            };

                            // Let the caller know we’ve sent the request (ok or error).
                            let _ = request_sent.send(res);
                        }
                        None => {
                            // The engine_req_rx channel has closed, so no more requests.
                            // We'll gracefully exit the loop and close the engine.
                            break;
                        }
                    }
                },

                // If we get a shutdown signal, close the engine immediately and return.
                _ = shutdown_rx.recv() => {
                    let _ = Self::inner_close_engine(&mut tcp_write).await;
                    return;
                }

                // Send heartbeats periodically.
                _ = heartbeats_stream.tick(), if send_heartbeats => {
                    // Send a heartbeat.
                    let res = Self::inner_send_to_engine(WebSocketRequest::Ping {}, &mut tcp_write).await;
                    // We don't really care if a heartbeat fails, we'll just try again soon.
                    let _ = res;
                }
            }
        }

        // If we exit the loop (e.g. engine_req_rx was closed),
        // still gracefully close the engine before returning.
        let _ = Self::inner_close_engine(&mut tcp_write).await;
    }

    /// Send the given `request` to the engine via the WebSocket connection `tcp_write`.
    async fn inner_close_engine(tcp_write: &mut WebSocketTcpWrite) -> anyhow::Result<()> {
        tcp_write
            .send(WsMsg::Close(None))
            .await
            .map_err(|e| anyhow!("could not send close over websocket: {e}"))?;
        Ok(())
    }

    async fn close_with_timeout(&self, timeout: Duration) {
        let _ = self.shutdown_tx.try_send(());
        let _ = tokio::time::timeout(timeout, async {
            loop {
                if *self.socket_health.read().await == SocketHealth::Inactive {
                    return;
                }
                tokio::task::yield_now().await;
            }
        })
        .await;
        // An inactive reader does not guarantee the writer has finished sending.
        // It could have encountered an error.
        // So, the graceful timeout request above may not have worked.
        // So, we should abort here, in case it's still trying to send.
        // Aborting a task that has already completed is a no-op.
        // Aborting a task that's stuck or in-progress and didn't gracefully shutdown will
        // accomplish our goal (stopping). So either way, we should abort.
        self.tcp_read_handle.abort();
        self.tcp_write_handle.abort();
        *self.socket_health.write().await = SocketHealth::Inactive;
    }
}

#[async_trait::async_trait]
impl EngineTransport for WebSocketTransport {
    async fn inner_fire_modeling_cmd(
        &self,
        _cmd_id: uuid::Uuid,
        source_range: SourceRange,
        cmd: WebSocketRequest,
        _id_to_source_range: HashMap<Uuid, SourceRange>,
    ) -> Result<(), KclError> {
        let (tx, rx) = oneshot::channel();

        let api_call_id_msg = self.connection_id_message(self.session_data.read().await.as_ref());

        // Send the request to the engine, via the actor.
        self.engine_req_tx
            .send(ToEngineReq {
                req: cmd.clone(),
                request_sent: tx,
            })
            .await
            .map_err(|e| {
                KclError::new_engine(KclErrorDetails::new(
                    format!("Failed to send modeling command: {e}{api_call_id_msg}"),
                    vec![source_range],
                ))
            })?;

        // Wait for the request to be sent.
        let send_result = rx.await.map_err(|e| {
            KclError::new_engine_hangup(
                KclErrorDetails::new(
                    format!("could not send request to the engine actor: {e}{api_call_id_msg}"),
                    vec![source_range],
                ),
                None,
            )
        })?;

        if let Err(send_error) = send_result {
            let pending_errors = self.pending_errors.read().await;
            if !pending_errors.is_empty() {
                return Err(KclError::new_engine(KclErrorDetails::new(
                    format!("{}{}", pending_errors.join(", "), api_call_id_msg),
                    vec![source_range],
                )));
            }

            return Err(KclError::new_engine_hangup(
                KclErrorDetails::new(
                    format!("could not send request to the engine: {send_error}{api_call_id_msg}"),
                    vec![source_range],
                ),
                None,
            ));
        }

        Ok(())
    }

    async fn inner_send_modeling_cmd(
        &self,
        cmd_id: uuid::Uuid,
        source_range: SourceRange,
        cmd: WebSocketRequest,
        id_to_source_range: HashMap<Uuid, SourceRange>,
    ) -> Result<WebSocketResponse, KclError> {
        self.inner_fire_modeling_cmd(cmd_id, source_range, cmd, id_to_source_range)
            .await?;

        let response_timeout = 600;
        let current_time = Instant::now();
        while current_time.elapsed().as_secs() < response_timeout {
            let guard = self.socket_health.read().await;
            if *guard == SocketHealth::Inactive {
                // Get the API call ID from session data if available
                let session_data = self.session_data.read().await;
                let api_call_id = session_data.as_ref().map(|session| session.api_call_id.to_string());
                let api_call_id_msg = self.connection_id_message(session_data.as_ref());

                // Check if we have any pending errors.
                let pe = self.pending_errors.read().await;
                if !pe.is_empty() {
                    return Err(KclError::new_engine(KclErrorDetails::new(
                        format!("{}{}", pe.join(", "), api_call_id_msg),
                        vec![source_range],
                    )));
                } else {
                    return Err(KclError::new_engine_hangup(
                        KclErrorDetails::new(
                            format!("Modeling command failed: websocket closed early{}", api_call_id_msg),
                            vec![source_range],
                        ),
                        api_call_id,
                    ));
                }
            }

            // We cannot pop here or it will break the artifact graph.
            if let Some(resp) = self.responses.responses.read().await.get(&cmd_id) {
                return Ok(resp.clone());
            }
        }

        // Get the API call ID from session data if available for timeout error
        let api_call_id_msg = self.connection_id_message(self.session_data.read().await.as_ref());

        Err(KclError::new_engine(KclErrorDetails::new(
            format!("Modeling command timed out `{cmd_id}`{}", api_call_id_msg),
            vec![source_range],
        )))
    }

    async fn close(&self) -> Result<(), TransportCloseError> {
        self.close_with_timeout(CLOSE_HANDSHAKE_TIMEOUT).await;
        Ok(())
    }
}

#[cfg(test)]
mod tests {
    use super::*;

    #[tokio::test]
    async fn close_aborts_writer_when_reader_stops_before_timeout() {
        let write = tokio::spawn(std::future::pending::<()>());
        let (engine_req_tx, _engine_req_rx) = mpsc::channel(1);
        let (shutdown_tx, mut shutdown_rx) = mpsc::channel(1);
        let socket_health = Arc::new(RwLock::new(SocketHealth::Active));
        let read_health = socket_health.clone();
        let read = tokio::spawn(async move {
            // Simulate the reader observing the peer's close after shutdown is requested.
            shutdown_rx.recv().await.expect("shutdown should be requested");
            *read_health.write().await = SocketHealth::Inactive;
        });
        let transport = WebSocketTransport {
            tcp_read_handle: read.abort_handle(),
            tcp_write_handle: write.abort_handle(),
            engine_req_tx,
            shutdown_tx,
            responses: ResponseInformation::new(Arc::new(RwLock::new(Default::default()))),
            pending_errors: Arc::new(RwLock::new(Vec::new())),
            session_data: Arc::new(RwLock::new(None)),
            socket_health: socket_health.clone(),
            upgrade_request_id: None,
        };

        tokio::time::timeout(Duration::from_secs(1), async {
            // The outer deadline ensures we exercise completion before the close timeout.
            transport.close_with_timeout(Duration::from_secs(10)).await;
            read.await.expect("reader should finish normally");
            assert!(write.await.unwrap_err().is_cancelled());
        })
        .await
        .expect("close should abort the writer even when the reader has stopped");

        assert_eq!(*socket_health.read().await, SocketHealth::Inactive);
    }

    #[tokio::test]
    async fn close_aborts_tasks_when_peer_does_not_close() {
        let read = tokio::spawn(std::future::pending::<()>());
        let write = tokio::spawn(std::future::pending::<()>());
        let (engine_req_tx, _engine_req_rx) = mpsc::channel(1);
        let (shutdown_tx, _shutdown_rx) = mpsc::channel(1);
        let socket_health = Arc::new(RwLock::new(SocketHealth::Active));
        let transport = WebSocketTransport {
            tcp_read_handle: read.abort_handle(),
            tcp_write_handle: write.abort_handle(),
            engine_req_tx,
            shutdown_tx,
            responses: ResponseInformation::new(Arc::new(RwLock::new(Default::default()))),
            pending_errors: Arc::new(RwLock::new(Vec::new())),
            session_data: Arc::new(RwLock::new(None)),
            socket_health: socket_health.clone(),
            upgrade_request_id: None,
        };

        tokio::time::timeout(
            Duration::from_secs(1),
            transport.close_with_timeout(Duration::from_millis(1)),
        )
        .await
        .expect("close should be bounded");

        assert_eq!(*socket_health.read().await, SocketHealth::Inactive);
        assert!(read.await.unwrap_err().is_cancelled());
        assert!(write.await.unwrap_err().is_cancelled());
    }
}