kanade-shared 0.63.0

Shared wire types, NATS subject helpers, KV constants, YAML manifest schema, and teravars-backed config loader for the kanade endpoint-management system
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
1278
1279
1280
1281
1282
1283
1284
1285
1286
1287
1288
1289
1290
1291
1292
1293
1294
1295
1296
1297
1298
1299
1300
1301
1302
1303
1304
1305
1306
1307
1308
1309
1310
1311
1312
1313
1314
1315
1316
1317
1318
1319
1320
1321
1322
1323
1324
1325
1326
1327
1328
1329
1330
1331
1332
1333
1334
1335
1336
1337
1338
1339
1340
1341
1342
1343
1344
1345
1346
1347
1348
1349
1350
1351
1352
1353
1354
1355
1356
1357
1358
1359
1360
1361
1362
1363
1364
1365
1366
1367
1368
1369
1370
1371
1372
1373
1374
1375
1376
1377
1378
1379
1380
1381
1382
1383
1384
1385
1386
1387
1388
1389
1390
1391
1392
1393
1394
1395
1396
1397
1398
1399
1400
1401
1402
1403
1404
1405
1406
1407
1408
1409
1410
1411
1412
1413
1414
1415
1416
1417
1418
1419
1420
1421
1422
1423
1424
1425
1426
1427
1428
1429
1430
1431
1432
1433
1434
1435
1436
1437
1438
1439
1440
1441
1442
1443
1444
1445
1446
1447
1448
1449
1450
1451
1452
1453
1454
1455
1456
1457
1458
1459
1460
1461
1462
//! Shared NATS client constructor.
//!
//! Every binary names the [`NatsRole`] it connects as, and the token is
//! resolved per role (first match wins):
//!
//!   1. Windows registry — `HKLM\SOFTWARE\kanade\<role>\NatsToken`
//!      (`REG_SZ`). The role-specific credential. Hardened ACL (SYSTEM +
//!      Admin only) keeps the token out of low-privilege users' reach,
//!      which Machine-scope env vars cannot do.
//!   2. Windows registry — `HKLM\SOFTWARE\kanade\agent\NatsToken`. The
//!      **shared** credential every role used before roles existed. Kept as
//!      a fallback so an existing deployment keeps working untouched; see
//!      "Staged migration" below.
//!   3. `$KANADE_NATS_TOKEN` environment variable. Dev / fallback path. The
//!      agent service runs as LocalSystem so user-session env vars never
//!      reach it; this branch only fires for `cargo run` / interactive
//!      shells.
//!   4. No token — connect unauthenticated. Works against a broker started
//!      without `authorization { … }`.
//!
//! # Per-role users, with the token as fallback
//!
//! A role may also hold a NATS *user*: `NatsUser` and `NatsPassword`
//! (`REG_SZ`) under its **own** registry key, or `$KANADE_NATS_USER` /
//! `$KANADE_NATS_PASSWORD`. There is deliberately no shared user — the shared
//! credential is the token. A pair with only one half is a configuration
//! error that fails the connect, never a silent fallback.
//!
//! With no user provisioned nothing below applies: the connection presents
//! the token (or nothing) exactly as before and no probe is ever made.
//!
//! With a user provisioned the broker may be on either side of the
//! token → `users` switch, and the switch is atomic on the broker, so the
//! credential is chosen per connection attempt (initial and every reconnect)
//! from an auth callback. Whether a rejected attempt is retried is up to the
//! async-nats version (0.50 keeps retrying, and re-runs the callback, while
//! another version may end the connection task for good, leaving a `Client`
//! that never talks again), so "present the user, and on rejection retry with
//! the token" is not left to its retry loop. Instead each attempt first opens
//! a short-lived *probe* connection with the user, which does not retry:
//!
//!   * accepted → present the user;
//!   * rejected (authorization violation) → present the token, or fail
//!     naming the missing token if there is none;
//!   * anything else (unreachable, timeout) → reuse whichever credential
//!     last worked, defaulting to the user.
//!
//! A wrong guess is thus survivable and the process keeps one `Client`.
//! A client whose connection task has terminated for any reason (a panic in
//! it, a drain, a version that treats a violation as terminal) is detected by
//! [`wait_until_dead`] so its process can exit for a supervised restart. The
//! same call also reports a broker that refuses the credential on every
//! attempt for a sustained period, since async-nats would otherwise retry it
//! forever and leave a process that looks alive but can never talk.
//!
//! # Why roles exist here (#1155)
//!
//! The broker authorises a *connection*, and a connection is only as
//! specific as the credential that opened it. While every binary presented
//! the same token, the broker could not tell an agent from the backend from
//! the CLI, so no `permissions` block could say "only the backend may
//! subscribe `remote.frame.>`" — there was nothing to hang the rule on.
//! That is why a shared token means a token holder can execute code on any
//! endpoint and silently watch any remote-assistance session (#1140).
//!
//! Distinct credentials do not fix that by themselves; the broker config has
//! to grow the matching `authorization { users: [...] }` entries. This
//! module is the half that makes those entries *expressible*.
//!
//! # Staged migration
//!
//! Step 2 above is the whole migration strategy. A fleet running today has
//! one token, provisioned at `…\kanade\agent\NatsToken` on every host
//! regardless of role. After this change it keeps working: no role key
//! exists, so every role falls through to the shared one and presents
//! exactly what it presented before.
//!
//! Rolling out per-role credentials is then per-host and reversible — write
//! `…\kanade\backend\NatsToken` on the backend host and it starts using it;
//! delete it and it falls back. The broker only needs to start
//! *distinguishing* the roles once every host has its own, so the config
//! change lands last, when it can no longer lock anyone out.
//!
//! No deploy script writes a role key yet: `deploy-backend.ps1` still
//! provisions the shared path, so today the role key is a manual registry
//! write. That is deliberate — the scripted path should start writing role
//! keys in the same change that teaches the broker to tell the roles apart,
//! because until then a role key changes nothing and a script that writes
//! only the role key (dropping the shared one) would strand the CLI on a
//! backend-only host.
//!
//! The order matters and is deliberate: role key first, shared key second.
//! The reverse would make the shared token permanent — a host that still has
//! it (all of them, today) would never notice its role key.
//!
//! # What the broker will and will not accept (measured, #1270)
//!
//! Two nats-server behaviours constrain every plan built on this module, so
//! they are recorded here rather than rediscovered:
//!
//! * A config may not carry **both** a `token` and a `users` array —
//!   nats-server refuses to start: *"Can not have a token and a users
//!   array"*. And once `users` are defined, a client presenting a token is
//!   rejected with an Authorization Violation, even when the token equals a
//!   user's password. So the shared token and a per-role `users` split
//!   cannot coexist for a transition window: the flip is atomic, and every
//!   host must already hold a credential of the new shape before it happens.
//!   Resolving a *token* per role, which is all this module does today, is
//!   therefore not sufficient for that split — the client has to learn to
//!   present a user as well.
//! * `/connz?auth=1` reports `authorized_user` per connection. Under
//!   `users` that is the username — the per-host answer #1270 wants. Under
//!   `token`, nats-server 2.14.3 reports the literal `[REDACTED]`: it hides
//!   the credential, so token mode can say *that* a host is on the shared
//!   token but never anything finer. Whether the value is hidden is the
//!   broker build's choice, not ours, so a consumer must assume it may be
//!   handling a secret; see [`CredentialProbe`] for the one question it can
//!   safely ask about one.
//!
//! # Limits worth naming
//!
//! A per-role token still cannot express per-*agent* identity. A role
//! credential permitted to subscribe `commands.pc.*` lets any agent holding
//! it read another agent's inbox. This narrows a fleet-wide compromise to a
//! fleet-wide **agent-role** compromise, which is better, not solved. The
//! end state is per-agent identity (NKeys / NATS-JWT), for which the plan is
//! to grow `ConnectOptions` here so every binary picks up the upgrade for
//! free. Same for mTLS.

use std::collections::HashMap;
use std::sync::{Arc, Mutex, OnceLock};
use std::time::Duration;

use anyhow::{Context, Result, bail};
use tracing::{debug, info, warn};

use crate::secrets;

const ENV_TOKEN: &str = "KANADE_NATS_TOKEN";
const REG_VALUE: &str = "NatsToken";
const ENV_USER: &str = "KANADE_NATS_USER";
const ENV_PASSWORD: &str = "KANADE_NATS_PASSWORD";
const REG_USER: &str = "NatsUser";
const REG_PASSWORD: &str = "NatsPassword";

/// How long the credential probe may take. Short on purpose: it runs inside
/// the reconnect path, so a black-holed broker must not stall every attempt.
const PROBE_TIMEOUT: Duration = Duration::from_secs(3);

/// Name of the probe connection. Deliberately *not* a `kanade-` name: the
/// backend attributes `kanade-<role>` connections to hosts, and a transient
/// probe must not show up there as an unknown role.
const PROBE_NAME: &str = "auth-probe";

/// How often [`wait_until_dead`] checks the connection task is still there.
const DEAD_CHECK_INTERVAL: Duration = Duration::from_secs(15);

/// A connection that has been refused this many times in a row, over at
/// least [`AUTH_REJECTION_WINDOW`], with no successful connect in between, is
/// treated as failed. async-nats retries a refused credential forever, which
/// leaves a process that can never talk but looks alive; the window keeps a
/// broker that is merely mid-reload (a few quick refusals) from counting.
const AUTH_REJECTION_LIMIT: usize = 5;
const AUTH_REJECTION_WINDOW: Duration = Duration::from_secs(10);

/// Prefix every kanade connection announces in its `name`.
const NAME_PREFIX: &str = "kanade-";

/// Separator between the role and the host identity in a connection name.
/// `/` is safe as a delimiter because the identity is a Windows computer
/// name, which cannot contain one.
const NAME_SEP: char = '/';

/// Registry subkey holding the pre-#1155 shared credential. Also the agent's
/// role key, which is not a coincidence — the shared token was provisioned
/// under the agent's path because agents were the first thing to need it.
const REG_SHARED_SUBKEY: &str = r"SOFTWARE\kanade\agent";

/// Which kanade binary is opening the connection.
///
/// Named on every call rather than inferred, because the broker's view of a
/// connection comes entirely from the credential it presents: a caller that
/// picks the wrong role does not get a warning, it gets someone else's
/// permissions.
#[derive(Debug, Clone, Copy, PartialEq, Eq)]
pub enum NatsRole {
    /// The endpoint agent. The most numerous and least trusted role — one
    /// compromised endpoint holds this credential.
    Agent,
    /// The backend. The only role that needs to see the whole fleet.
    Backend,
    /// The operator CLI, including the backend-down recovery path that
    /// drives agents over NATS directly.
    Cli,
}

impl NatsRole {
    pub fn as_str(self) -> &'static str {
        match self {
            NatsRole::Agent => "agent",
            NatsRole::Backend => "backend",
            NatsRole::Cli => "cli",
        }
    }

    /// Registry subkey holding this role's credential.
    fn reg_subkey(self) -> String {
        format!(r"SOFTWARE\kanade\{}", self.as_str())
    }
}

/// Resolve a role's token, given a registry reader and the environment
/// fallback.
///
/// Split from [`resolve_token`] so the *ordering* — the part that decides
/// whether a migration is reversible — is testable without a Windows
/// registry to write to.
fn resolve_token_with(
    role: NatsRole,
    read_reg: impl Fn(&str, &str) -> Option<String>,
    env: Option<String>,
) -> Option<String> {
    if let Some(t) = read_reg(&role.reg_subkey(), REG_VALUE) {
        return Some(t);
    }
    if let Some(t) = read_reg(REG_SHARED_SUBKEY, REG_VALUE) {
        return Some(t);
    }
    env.filter(|t| !t.is_empty())
}

fn resolve_token(role: NatsRole) -> Option<String> {
    resolve_token_with(
        role,
        secrets::read_hklm_value,
        std::env::var(ENV_TOKEN).ok(),
    )
}

/// A named NATS user. The password is never shown by `Debug`.
#[derive(Clone, PartialEq, Eq)]
struct UserCredential {
    name: String,
    password: String,
}

impl std::fmt::Debug for UserCredential {
    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
        f.debug_struct("UserCredential")
            .field("name", &self.name)
            .field("password", &"<redacted>")
            .finish()
    }
}

/// Turn the two halves of a user pair into a credential, or a configuration
/// error naming what is missing and where (never a value).
fn pair(
    name: Option<String>,
    password: Option<String>,
    source: &str,
) -> Result<Option<UserCredential>> {
    match (name, password) {
        (Some(name), Some(password)) => Ok(Some(UserCredential { name, password })),
        (None, None) => Ok(None),
        (Some(_), None) => bail!("NATS user is set but its password is missing ({source})"),
        (None, Some(_)) => bail!("NATS password is set but its user name is missing ({source})"),
    }
}

/// Resolve a role's user pair: its own registry key first, then the
/// environment. Unlike the token there is no shared-key step.
///
/// The registry is judged as a whole before the environment is consulted: a
/// half pair there is an error even when the environment is complete,
/// because quietly mixing sources would hide a half-provisioned host.
fn resolve_user_with(
    role: NatsRole,
    read_reg: impl Fn(&str, &str) -> Option<String>,
    env_user: Option<String>,
    env_password: Option<String>,
) -> Result<Option<UserCredential>> {
    let subkey = role.reg_subkey();
    let reg_user = read_reg(&subkey, REG_USER);
    let reg_password = read_reg(&subkey, REG_PASSWORD);
    if reg_user.is_some() || reg_password.is_some() {
        let source = format!(r"HKLM\{subkey}: {REG_USER} / {REG_PASSWORD}");
        return pair(reg_user, reg_password, &source);
    }
    let source = format!("${ENV_USER} / ${ENV_PASSWORD}");
    pair(
        env_user.filter(|v| !v.is_empty()),
        env_password.filter(|v| !v.is_empty()),
        &source,
    )
}

fn resolve_user(role: NatsRole) -> Result<Option<UserCredential>> {
    resolve_user_with(
        role,
        secrets::read_hklm_value,
        std::env::var(ENV_USER).ok(),
        std::env::var(ENV_PASSWORD).ok(),
    )
}

/// The credentials a connection is built from.
///
/// [`connect`] resolves them from the registry / environment; this type
/// exists so a caller (tests, chiefly) can supply them directly without
/// touching process-global state. `Debug` never prints a secret.
#[derive(Clone, Default)]
pub struct NatsCredentials {
    token: Option<String>,
    user: Option<UserCredential>,
}

impl NatsCredentials {
    pub fn new(token: Option<String>, user: Option<(String, String)>) -> Self {
        Self {
            token,
            user: user.map(|(name, password)| UserCredential { name, password }),
        }
    }

    fn resolve(role: NatsRole) -> Result<Self> {
        Ok(Self {
            token: resolve_token(role),
            user: resolve_user(role)?,
        })
    }
}

impl std::fmt::Debug for NatsCredentials {
    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
        f.debug_struct("NatsCredentials")
            .field("token", &self.token.as_ref().map(|_| "<redacted>"))
            .field("user", &self.user)
            .finish()
    }
}

/// Which credential a connection attempt presents.
#[derive(Debug, Clone, Copy, PartialEq, Eq)]
enum Choice {
    User,
    Token,
}

impl Choice {
    fn label(self) -> &'static str {
        match self {
            Choice::User => "user",
            Choice::Token => "token",
        }
    }
}

/// What the probe connection learned about the broker.
#[derive(Debug, Clone, Copy, PartialEq, Eq)]
enum ProbeOutcome {
    Accepted,
    Rejected,
    Unreachable,
}

impl ProbeOutcome {
    fn label(self) -> &'static str {
        match self {
            ProbeOutcome::Accepted => "accepted",
            ProbeOutcome::Rejected => "rejected",
            ProbeOutcome::Unreachable => "unreachable",
        }
    }
}

/// The credential the broker last *proved* it accepts or rejects for a role,
/// shared between the connection (which writes it on every attempt) and the
/// [`CredentialProbe`] (which reads it). Only a probe answer is recorded — a
/// guess made while the broker was unreachable is not evidence.
#[derive(Default)]
struct Live {
    decision: Mutex<Option<Choice>>,
    /// Consecutive authentication refusals: when the first one happened and
    /// how many there have been. Cleared by a successful connect.
    refusals: Mutex<Option<(std::time::Instant, usize)>>,
}

impl Live {
    /// Track the connection's events for [`Live::auth_failed`].
    fn observe(&self, ev: &async_nats::Event) {
        let mut refusals = self.refusals.lock().unwrap_or_else(|e| e.into_inner());
        match ev {
            // A successful connect, a drop, or any other kind of failed
            // attempt (broker unreachable, timeout) ends a run of refusals:
            // only an unbroken run is evidence the credential itself is bad,
            // and an offline broker is something to wait out.
            async_nats::Event::Connected | async_nats::Event::Disconnected => *refusals = None,
            async_nats::Event::ClientError(async_nats::ClientError::Other(kind))
                if *kind == async_nats::ConnectErrorKind::AuthorizationViolation.to_string()
                    || *kind == async_nats::ConnectErrorKind::Authentication.to_string() =>
            {
                let (first, n) = refusals.unwrap_or((std::time::Instant::now(), 0));
                *refusals = Some((first, n + 1));
            }
            async_nats::Event::ClientError(_) => *refusals = None,
            _ => {}
        }
    }

    /// Whether the broker has refused every attempt for long enough that
    /// waiting longer is not going to help.
    fn auth_failed(&self) -> bool {
        match *self.refusals.lock().unwrap_or_else(|e| e.into_inner()) {
            Some((first, n)) => {
                n >= AUTH_REJECTION_LIMIT && first.elapsed() >= AUTH_REJECTION_WINDOW
            }
            None => false,
        }
    }

    fn get(&self) -> Option<Choice> {
        *self.decision.lock().unwrap_or_else(|e| e.into_inner())
    }

    fn set(&self, c: Choice) {
        *self.decision.lock().unwrap_or_else(|e| e.into_inner()) = Some(c);
    }
}

/// Process-wide per-role state, so [`CredentialProbe::for_role`] sees the
/// decision the already-open connection made without the callers having to
/// thread anything through.
fn live_for(role: NatsRole) -> Arc<Live> {
    static LIVE: OnceLock<Mutex<HashMap<&'static str, Arc<Live>>>> = OnceLock::new();
    let mut map = LIVE
        .get_or_init(Default::default)
        .lock()
        .unwrap_or_else(|e| e.into_inner());
    map.entry(role.as_str()).or_default().clone()
}

/// Pick the credential for one attempt from the probe's answer.
///
/// Pure so the whole decision table is testable without a broker. `Err`
/// carries the credential that is missing.
fn select(
    outcome: ProbeOutcome,
    last_worked: Option<Choice>,
    have_token: bool,
) -> std::result::Result<Choice, &'static str> {
    match outcome {
        ProbeOutcome::Accepted => Ok(Choice::User),
        ProbeOutcome::Rejected if have_token => Ok(Choice::Token),
        ProbeOutcome::Rejected => {
            Err("the broker rejected the NATS user and no NatsToken is provisioned")
        }
        ProbeOutcome::Unreachable => Ok(last_worked.unwrap_or(Choice::User)),
    }
}

/// Try the user on a connection of its own, which does not retry, so a
/// rejection costs this throwaway connection and nothing else.
///
/// Runs on a spawned task because the auth callback's future must be `Sync`
/// and async-nats' connect future is not; a join handle is.
async fn probe_user(url: &str, user: &UserCredential) -> ProbeOutcome {
    let (url, name, password) = (url.to_string(), user.name.clone(), user.password.clone());
    let probe = tokio::spawn(async move {
        let attempt = async_nats::ConnectOptions::new()
            .name(PROBE_NAME)
            .connection_timeout(PROBE_TIMEOUT)
            .user_and_password(name, password)
            .connect(url);
        match tokio::time::timeout(PROBE_TIMEOUT + Duration::from_secs(1), attempt).await {
            Ok(Ok(_client)) => ProbeOutcome::Accepted,
            Ok(Err(e)) if e.kind() == async_nats::ConnectErrorKind::AuthorizationViolation => {
                ProbeOutcome::Rejected
            }
            Ok(Err(_)) | Err(_) => ProbeOutcome::Unreachable,
        }
    });
    probe.await.unwrap_or(ProbeOutcome::Unreachable)
}

/// Probe, decide, record. `probe` is injected so the unit tests can drive
/// every outcome.
async fn choose<P, Fut>(
    role: NatsRole,
    have_token: bool,
    live: &Live,
    probe: P,
) -> std::result::Result<Choice, &'static str>
where
    P: FnOnce() -> Fut,
    Fut: std::future::Future<Output = ProbeOutcome>,
{
    let outcome = probe().await;
    let previous = live.get();
    let choice = select(outcome, previous, have_token)?;
    if outcome != ProbeOutcome::Unreachable {
        live.set(choice);
    }
    // Log what was selected and the outcome class, never a value; quiet when
    // nothing changed so a flapping broker does not fill the log.
    if previous == Some(choice) {
        debug!(
            role = role.as_str(),
            credential = choice.label(),
            probe = outcome.label(),
            "NATS credential selected"
        );
    } else {
        info!(
            role = role.as_str(),
            credential = choice.label(),
            probe = outcome.label(),
            "NATS credential selected"
        );
    }
    Ok(choice)
}

/// Whether a connection needs per-attempt selection at all.
enum AuthPlan {
    /// No user: present the token (or nothing), exactly as before roles had
    /// users. No callback, no probe.
    Static(Option<String>),
    /// A user is provisioned: select per attempt.
    Select {
        token: Option<String>,
        user: UserCredential,
    },
}

fn auth_plan(creds: NatsCredentials) -> AuthPlan {
    match creds.user {
        None => AuthPlan::Static(creds.token),
        Some(user) => AuthPlan::Select {
            token: creds.token,
            user,
        },
    }
}

/// The `name` a kanade process announces on its NATS connection.
///
/// Without an identity this is `kanade-<role>`; with one it is
/// `kanade-<role>/<identity>`. The broker echoes it back verbatim in
/// `/connz`, which is what lets the backend attribute a connection — and
/// therefore the credential the broker authenticated it with — to a pc_id
/// (#1270). Nothing else on a connection carries the pc_id: the CID is
/// assigned by the server and the IP is not a stable identifier on a fleet
/// of laptops.
///
/// The name is client-supplied and therefore claimed, not proved. What
/// `/connz` makes unforgeable is the *credential* half of the pair; a host
/// can still lie about which pc_id it is. Under one fleet-wide token that
/// changes nothing (every host can already impersonate every other), and
/// closing it for good is per-agent identity, not a naming convention.
pub fn client_name(role: NatsRole, identity: Option<&str>) -> String {
    match identity.map(str::trim).filter(|s| !s.is_empty()) {
        Some(id) => format!("{NAME_PREFIX}{}{NAME_SEP}{id}", role.as_str()),
        None => format!("{NAME_PREFIX}{}", role.as_str()),
    }
}

/// A connection name split back into its parts — see [`client_name`].
#[derive(Debug, Clone, Copy, PartialEq, Eq)]
pub struct ClientName<'a> {
    /// The role segment as announced. A `&str` rather than a [`NatsRole`]
    /// on purpose: a connection from a future (or foreign) build may name a
    /// role this binary does not know, and dropping it on the floor would
    /// hide exactly the host worth looking at.
    pub role: &'a str,
    /// The host identity, when the connection carried one. `None` for the
    /// backend / CLI (which are not per-host) and for agents predating
    /// #1270 — those simply cannot be attributed.
    pub identity: Option<&'a str>,
}

/// Parse a connection name produced by [`client_name`]. `None` for any name
/// that is not a kanade connection at all (a `nats` CLI session, a
/// monitoring tool), which the caller should ignore rather than guess about.
pub fn parse_client_name(name: &str) -> Option<ClientName<'_>> {
    let rest = name.strip_prefix(NAME_PREFIX)?;
    Some(match rest.split_once(NAME_SEP) {
        // An empty identity (`kanade-agent/`) is not an identity.
        Some((role, id)) if !role.is_empty() && !id.is_empty() => ClientName {
            role,
            identity: Some(id),
        },
        Some((role, _)) if !role.is_empty() => ClientName {
            role,
            identity: None,
        },
        Some(_) => return None,
        None if !rest.is_empty() => ClientName {
            role: rest,
            identity: None,
        },
        None => return None,
    })
}

/// Answers "is this credential the one *we* present?" without handing the
/// credential itself to the caller.
///
/// #1270: the NATS monitoring endpoint reports `authorized_user` per
/// connection. A current nats-server hides that field for
/// token-authenticated connections, but that is the broker build's
/// behaviour, not a guarantee this side can lean on — a consumer of
/// `/connz` has to treat the value as possibly being the fleet-wide secret.
/// The one question it may safely answer about it is whether it equals the
/// credential this process already holds, and that answer is enough to
/// label a connection ("still on the shared token") without ever storing or
/// serving the value.
///
/// Constructed once and reused: [`resolve_token`] hits the Windows registry,
/// and the caller compares against every connection on the broker.
pub struct CredentialProbe {
    token: Option<String>,
    user: Option<String>,
    /// The connection's own decision, when this probe belongs to one. `None`
    /// for the explicit constructors, which describe a fixed credential.
    live: Option<Arc<Live>>,
}

/// Which shape of credential a [`CredentialProbe`] holds.
#[derive(Debug, Clone, Copy, PartialEq, Eq)]
pub enum CredentialKind {
    None,
    Token,
    /// A named user — and, when the connection presenting it is **live**,
    /// positive proof that the broker is running `users` rather than a
    /// token: nats-server refuses to load a config carrying both a `token`
    /// and a `users` array ("Can not have a token and a users array") and
    /// rejects token authentication outright once `users` are defined.
    ///
    /// That proof is the only thing that makes a reported `authorized_user`
    /// safe to record verbatim. Note what is *not* proof: holding no
    /// credential locally. A process that never authenticated at all can
    /// still read a monitoring endpoint, and inferring the broker's mode
    /// from a local absence would let a misconfigured host store the very
    /// secret the rest of this type exists to protect.
    User,
}

/// Hand-written so a stray `{:?}` in a log line cannot print the credential.
/// A username is not a secret and is shown; a token never is.
impl std::fmt::Debug for CredentialProbe {
    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
        let mut held = Vec::new();
        if self.token.is_some() {
            held.push("<redacted token>".to_string());
        }
        if let Some(name) = &self.user {
            held.push(format!("user {name}"));
        }
        let rendered = if held.is_empty() {
            "<none>".to_string()
        } else {
            held.join(" + ")
        };
        f.debug_struct("CredentialProbe")
            .field("presented", &rendered)
            .field("kind", &self.kind())
            .finish()
    }
}

impl CredentialProbe {
    /// Resolve the credential `role` would present, exactly as [`connect`]
    /// does, and follow the decision that role's open connection makes.
    ///
    /// A half-provisioned user pair is ignored here — [`connect`] is where
    /// it fails loudly.
    pub fn for_role(role: NatsRole) -> Self {
        Self {
            token: resolve_token(role),
            user: resolve_user(role).ok().flatten().map(|u| u.name),
            live: Some(live_for(role)),
        }
    }

    /// Build a probe around an explicitly-supplied token.
    ///
    /// The production path is [`Self::for_role`]; this exists so callers can
    /// be tested against a known credential without a Windows registry to
    /// write to — and, on a developer's machine, without accidentally
    /// probing the real fleet token that `for_role` would find there.
    pub fn from_token(token: Option<String>) -> Self {
        Self {
            token,
            user: None,
            live: None,
        }
    }

    /// Build a probe for a process that authenticates as a named user.
    ///
    /// Describes a fixed user credential, for testing the consumers of
    /// [`CredentialKind::User`] without a connection.
    pub fn from_user(name: impl Into<String>) -> Self {
        Self {
            token: None,
            user: Some(name.into()),
            live: None,
        }
    }

    /// Which shape of credential this process is presenting **right now**.
    ///
    /// A role that holds a user but is on the token fallback reports
    /// [`CredentialKind::Token`]; the user shape is reported only once the
    /// broker has accepted it. Before any decision a role holding a token
    /// reports the token, and one holding only a user reports `None`: the
    /// user shape is proof of the broker's mode and is not claimed on a
    /// guess.
    pub fn kind(&self) -> CredentialKind {
        let decided = self.live.as_ref().and_then(|l| l.get());
        match decided {
            Some(Choice::User) if self.user.is_some() => return CredentialKind::User,
            Some(Choice::Token) if self.token.is_some() => return CredentialKind::Token,
            _ => {}
        }
        if self.live.is_none() && self.user.is_some() {
            CredentialKind::User
        } else if self.token.is_some() {
            CredentialKind::Token
        } else {
            CredentialKind::None
        }
    }

    /// Whether `candidate` is the **secret** this process presents.
    ///
    /// Only ever true for a token. A user's secret is its password, which
    /// `authorized_user` never carries — matching a username here would
    /// mean "this connection is on the same account", a different and much
    /// weaker statement than the one callers use this for.
    ///
    /// A plain comparison: `candidate` comes from the broker's own report of
    /// connections it already authenticated, not from an attacker-chosen
    /// input, so there is no oracle to time.
    pub fn is_ours(&self, candidate: &str) -> bool {
        self.token.as_deref() == Some(candidate)
    }
}

/// Connect to NATS at `url` as `role`. Resolves the credential from the
/// registry (Windows) or the environment: a user pair when one is
/// provisioned (with the token as fallback, see the module docs), otherwise
/// the bearer token; connects unauthenticated when neither is set.
///
/// The connection is announced as `kanade-<role>` with no host identity —
/// right for the backend and the CLI, which are not per-host. A role that
/// has to be attributable to a specific machine (the agent) must use
/// [`connect_with_event_callback`] and pass one; see [`client_name`].
pub async fn connect(role: NatsRole, url: &str) -> Result<async_nats::Client> {
    connect_inner(
        role,
        url,
        None,
        None::<fn(async_nats::Event) -> std::future::Ready<()>>,
        NatsCredentials::resolve(role)?,
        live_for(role),
    )
    .await
}

/// Same as [`connect`] but also wires an `event_callback` that fires
/// whenever async-nats publishes a `ConnectEvent` (Connected,
/// Disconnected, ServerError, etc.). The callback's `Future` runs on
/// the async-nats internal task — keep it cheap and non-blocking
/// (set a flag, send on a channel, that kind of thing) so the
/// connection state machine isn't held up.
///
/// Used by the agent's v0.26 Layer 2 staleness tracker: the callback
/// stamps a shared `Mutex<Option<Instant>>` on every Connected event,
/// so `decide()` at fire time can answer "how long ago were we last
/// definitely-talking-to-the-broker" without a polling loop.
///
/// `identity` names the host this connection belongs to (the agent's
/// pc_id). It becomes part of the connection name the broker echoes in
/// `/connz`, which is the only thing tying a connection — and the
/// credential that opened it — back to a machine (#1270).
pub async fn connect_with_event_callback<F, Fut>(
    role: NatsRole,
    url: &str,
    identity: Option<&str>,
    cb: F,
) -> Result<async_nats::Client>
where
    F: Fn(async_nats::Event) -> Fut + Send + Sync + 'static,
    Fut: std::future::Future<Output = ()> + Send + Sync + 'static,
{
    connect_inner(
        role,
        url,
        identity,
        Some(cb),
        NatsCredentials::resolve(role)?,
        live_for(role),
    )
    .await
}

/// Connect with explicitly supplied credentials instead of resolving them
/// from the registry / environment, and with decision state private to this
/// connection. For tests, which must not depend on process-global state
/// (the per-role decision and refusal state is still shared, so concurrent
/// tests should use different roles).
pub async fn connect_with_credentials(
    role: NatsRole,
    url: &str,
    creds: NatsCredentials,
) -> Result<async_nats::Client> {
    connect_inner(
        role,
        url,
        None,
        None::<fn(async_nats::Event) -> std::future::Ready<()>>,
        creds,
        live_for(role),
    )
    .await
}

/// [`connect_with_credentials`] with an event callback, so a test can observe
/// what the connection reports while it cannot authenticate.
pub async fn connect_with_credentials_and_event_callback<F, Fut>(
    role: NatsRole,
    url: &str,
    creds: NatsCredentials,
    cb: F,
) -> Result<async_nats::Client>
where
    F: Fn(async_nats::Event) -> Fut + Send + Sync + 'static,
    Fut: std::future::Future<Output = ()> + Send + Sync + 'static,
{
    connect_inner(role, url, None, Some(cb), creds, live_for(role)).await
}

async fn connect_inner<F, Fut>(
    role: NatsRole,
    url: &str,
    identity: Option<&str>,
    cb: Option<F>,
    creds: NatsCredentials,
    live: Arc<Live>,
) -> Result<async_nats::Client>
where
    F: Fn(async_nats::Event) -> Fut + Send + Sync + 'static,
    Fut: std::future::Future<Output = ()> + Send + Sync + 'static,
{
    // #1187: a workspace build unifies rustls features, so any binary built
    // alongside a reqwest user (the CLI, the backend) links BOTH aws-lc-rs and
    // ring. rustls 0.23 then cannot auto-pick a process-level provider, and the
    // first TLS handshake — a `wss://`/`tls://` broker — panics inside
    // async-nats' connection task. That panic does not surface here: the
    // client just goes dead. Every production connect funnels through this
    // function, so installing ring here covers every binary. `install_default`
    // returns Err when a provider is already installed — ignore it.
    let _ = rustls::crypto::ring::default_provider().install_default();

    let tracker = live.clone();
    // Only a provisioned user changes how the credential is presented; every
    // other host takes the token path untouched.
    let opts = match auth_plan(creds) {
        AuthPlan::Static(token) => {
            let opts = async_nats::ConnectOptions::new();
            match token {
                Some(token) => opts.token(token),
                None => opts,
            }
        }
        AuthPlan::Select { token, user } => {
            let url = url.to_string();
            async_nats::ConnectOptions::with_auth_callback(move |_nonce| {
                let (url, token, user, live) =
                    (url.clone(), token.clone(), user.clone(), live.clone());
                async move {
                    let choice = choose(role, token.is_some(), &live, || probe_user(&url, &user))
                        .await
                        .map_err(async_nats::AuthError::new)?;
                    let mut auth = async_nats::Auth::new();
                    match choice {
                        Choice::User => {
                            auth.username = Some(user.name);
                            auth.password = Some(user.password);
                        }
                        Choice::Token => auth.token = token,
                    }
                    Ok(auth)
                }
            })
        }
    };

    // v0.38 / #137: offline-tolerant boot. Without
    // `retry_on_initial_connect`, `opts.connect(url).await` blocks-then-
    // errors when the broker is unreachable at startup — the agent
    // process dies, SCM ticks its restart counter, and the offline-
    // tolerant subsystems (local_scheduler, outbox drain) never spawn.
    // With this flag, connect() returns `Ok(Client)` immediately and
    // async-nats does the reconnect in the background; subscribe()
    // calls queue the SUB frame until the link is up.
    let opts = opts
        .retry_on_initial_connect()
        // Names the connection in `nats server report connections`, in the
        // broker's own logs, and in `/connz`. Free observability while the
        // fleet is mid-migration: it shows which roles are connecting even
        // before their credentials differ, which is exactly the window in
        // which a wrongly-provisioned host is otherwise invisible. With an
        // identity it also carries the pc_id, so #1270 can join the broker's
        // per-connection `authorized_user` back onto the agents row.
        .name(client_name(role, identity));
    // Always installed, even without a caller callback: it is how a refused
    // credential is noticed, since async-nats only retries it.
    let opts = opts.event_callback(move |ev| {
        tracker.observe(&ev);
        let forwarded = cb.as_ref().map(|cb| cb(ev));
        async move {
            if let Some(forwarded) = forwarded {
                forwarded.await;
            }
        }
    });
    opts.connect(url)
        .await
        .with_context(|| format!("connect to NATS at {url}"))
}

/// Whether the client's connection task has terminated.
///
/// When that task ends (a panic inside it, a drain, exhausted reconnects) the
/// `Client` stays alive and never talks again — a silent zombie. The
/// observable difference from an ordinary disconnect is the command channel:
/// a task that is alive but reconnecting simply does not answer a flush, so
/// the flush waits and the timeout elapses; a task that is gone has dropped
/// the receiving end, so queueing the flush fails with a send error. The
/// check publishes to no subject, so no role needs any publish right for it.
///
/// This tells whether the task still accepts commands, not whether the broker
/// is reachable. A flush that fails after it was queued (its observer was
/// dropped) is not treated as death: a task that really is gone fails the
/// next check at the send step, and mistaking a plain disconnect for death
/// would make a process exit needlessly.
pub async fn is_dead(client: &async_nats::Client) -> bool {
    match tokio::time::timeout(Duration::from_secs(5), client.flush()).await {
        Ok(Err(e)) => match e.kind() {
            async_nats::client::FlushErrorKind::SendError => true,
            async_nats::client::FlushErrorKind::FlushError => false,
        },
        Ok(Ok(())) | Err(_) => false,
    }
}

/// Resolve once `client` can no longer be expected to work: its connection
/// task has terminated (see [`is_dead`]), or the broker has refused its
/// credential on every attempt for [`AUTH_REJECTION_WINDOW`]. Checked every
/// `interval`. A process that depends on the client should treat this as
/// fatal and exit non-zero so its service manager restarts it.
///
/// `role` names the connection the client was opened with.
pub async fn wait_until_dead_every(
    role: NatsRole,
    client: &async_nats::Client,
    interval: Duration,
) {
    let live = live_for(role);
    let mut tick = tokio::time::interval(interval);
    tick.set_missed_tick_behavior(tokio::time::MissedTickBehavior::Delay);
    loop {
        tick.tick().await;
        if live.auth_failed() {
            warn!(
                role = role.as_str(),
                "the NATS broker keeps refusing this role's credential; the client cannot connect"
            );
            return;
        }
        if is_dead(client).await {
            warn!(
                role = role.as_str(),
                "NATS connection task has terminated; the client can no longer talk to the broker"
            );
            return;
        }
    }
}

/// [`wait_until_dead_every`] at the production cadence.
pub async fn wait_until_dead(role: NatsRole, client: &async_nats::Client) {
    wait_until_dead_every(role, client, DEAD_CHECK_INTERVAL).await
}

#[cfg(test)]
mod tests {
    use super::*;
    use std::collections::HashMap;

    /// A stand-in registry. Keys are `subkey\value`.
    fn reg(entries: &[(&str, &str)]) -> impl Fn(&str, &str) -> Option<String> {
        let map: HashMap<String, String> = entries
            .iter()
            .map(|(k, v)| ((*k).to_string(), (*v).to_string()))
            .collect();
        move |subkey: &str, value: &str| map.get(&format!(r"{subkey}\{value}")).cloned()
    }

    #[test]
    fn role_subkeys_are_distinct_and_agent_matches_the_shared_path() {
        assert_eq!(NatsRole::Backend.reg_subkey(), r"SOFTWARE\kanade\backend");
        assert_eq!(NatsRole::Cli.reg_subkey(), r"SOFTWARE\kanade\cli");
        // The agent's role key IS the historical shared key, so an agent
        // never sees a migration at all.
        assert_eq!(NatsRole::Agent.reg_subkey(), REG_SHARED_SUBKEY);
    }

    #[test]
    fn an_unmigrated_fleet_keeps_presenting_the_shared_token() {
        // The state of every host today: one token, under the agent path.
        let registry = reg(&[(r"SOFTWARE\kanade\agent\NatsToken", "shared")]);
        for role in [NatsRole::Agent, NatsRole::Backend, NatsRole::Cli] {
            assert_eq!(
                resolve_token_with(role, &registry, None).as_deref(),
                Some("shared"),
                "{role:?} must keep working before its own key is provisioned"
            );
        }
    }

    #[test]
    fn a_role_key_wins_over_the_shared_one() {
        let registry = reg(&[
            (r"SOFTWARE\kanade\agent\NatsToken", "shared"),
            (r"SOFTWARE\kanade\backend\NatsToken", "backend-only"),
        ]);
        // The migrated role uses its own credential...
        assert_eq!(
            resolve_token_with(NatsRole::Backend, &registry, None).as_deref(),
            Some("backend-only")
        );
        // ...while a role that has not been migrated yet is unaffected.
        assert_eq!(
            resolve_token_with(NatsRole::Cli, &registry, None).as_deref(),
            Some("shared")
        );
    }

    #[test]
    fn removing_a_role_key_falls_back_rather_than_failing() {
        // Rollback of a per-host migration step: the role key is gone, and
        // the host must return to the shared credential instead of
        // connecting unauthenticated (which a broker with `authorization`
        // would refuse — turning a rollback into an outage).
        let registry = reg(&[(r"SOFTWARE\kanade\agent\NatsToken", "shared")]);
        assert_eq!(
            resolve_token_with(NatsRole::Backend, &registry, None).as_deref(),
            Some("shared")
        );
    }

    #[test]
    fn the_registry_outranks_the_environment() {
        // Unchanged from before roles existed: a dev shell's env var must
        // not quietly override a provisioned production credential.
        let registry = reg(&[(r"SOFTWARE\kanade\agent\NatsToken", "shared")]);
        assert_eq!(
            resolve_token_with(NatsRole::Agent, &registry, Some("from-env".into())).as_deref(),
            Some("shared")
        );
    }

    #[test]
    fn the_environment_serves_hosts_with_no_registry_at_all() {
        let empty = reg(&[]);
        assert_eq!(
            resolve_token_with(NatsRole::Cli, &empty, Some("from-env".into())).as_deref(),
            Some("from-env")
        );
        // An empty env var is not a credential — it must fall through to
        // "no token" so a dev broker without `authorization` still works,
        // rather than presenting the empty string and being rejected.
        assert_eq!(
            resolve_token_with(NatsRole::Cli, &empty, Some(String::new())),
            None
        );
        assert_eq!(resolve_token_with(NatsRole::Cli, &empty, None), None);
    }

    // ── #1270: connection naming ─────────────────────────────────────

    #[test]
    fn an_identity_round_trips_through_the_connection_name() {
        // The pc_id is the join key between `/connz` and the agents table,
        // so the name has to survive the trip unchanged — including the
        // casing, which is NOT uniform across the fleet and which NATS
        // subjects treat as significant.
        for pc in ["PC001", "minipc", "Web%01", "ws-9"] {
            let name = client_name(NatsRole::Agent, Some(pc));
            let parsed = parse_client_name(&name).expect("our own name must parse");
            assert_eq!(parsed.role, "agent");
            assert_eq!(parsed.identity, Some(pc));
        }
    }

    #[test]
    fn a_role_without_an_identity_keeps_the_pre_1270_name() {
        // The backend and the CLI are not per-host, and an agent that
        // predates #1270 announces this shape too. Both must parse as "a
        // kanade connection we cannot attribute" rather than as an error or
        // as an empty pc_id.
        assert_eq!(client_name(NatsRole::Backend, None), "kanade-backend");
        let parsed = parse_client_name("kanade-agent").unwrap();
        assert_eq!(parsed.role, "agent");
        assert_eq!(parsed.identity, None);
        // Whitespace-only is not an identity either — it would otherwise
        // produce a name that parses back into a pc_id no row can match.
        assert_eq!(client_name(NatsRole::Agent, Some("  ")), "kanade-agent");
    }

    #[test]
    fn foreign_connections_do_not_parse_as_kanade_ones() {
        // A `nats` CLI session or a monitoring tool shares the broker. The
        // projector must skip those rather than attribute them to a host.
        assert!(parse_client_name("NATS CLI Version 0.1.5").is_none());
        assert!(parse_client_name("").is_none());
        assert!(parse_client_name("kanade-").is_none());
        assert!(parse_client_name("kanade-/PC001").is_none());
        // A trailing separator with no identity is a role, not a pc_id.
        assert_eq!(parse_client_name("kanade-agent/").unwrap().identity, None);
    }

    #[test]
    fn an_unknown_role_is_preserved_rather_than_dropped() {
        // A future build (or something impersonating one) naming a role this
        // binary has never heard of is precisely the connection an operator
        // wants to see.
        let parsed = parse_client_name("kanade-relay/PC001").unwrap();
        assert_eq!(parsed.role, "relay");
        assert_eq!(parsed.identity, Some("PC001"));
    }

    // ── #1270: credential probe ──────────────────────────────────────

    #[test]
    fn the_probe_recognises_only_the_credential_we_present() {
        let probe = CredentialProbe::from_token(Some("shared".into()));
        assert_eq!(probe.kind(), CredentialKind::Token);
        assert!(probe.is_ours("shared"));
        assert!(!probe.is_ours("something-else"));
        // The empty string is what the broker reports for a connection it
        // did not authenticate at all. It must never read as "ours".
        assert!(!probe.is_ours(""));
    }

    #[test]
    fn a_probe_with_no_credential_matches_nothing() {
        // Dev broker with no `authorization` block. We hold nothing, so we
        // can prove nothing about anyone else's credential — including that
        // it is safe to store.
        let probe = CredentialProbe::from_token(None);
        assert_eq!(probe.kind(), CredentialKind::None);
        assert!(!probe.is_ours(""));
        assert!(!probe.is_ours("anything"));
    }

    #[test]
    fn a_username_is_not_a_secret_we_can_recognise() {
        // `is_ours` answers "is this MY secret", and a user's secret is its
        // password. Matching on the username instead would answer a much
        // weaker question while reading like the strong one.
        let probe = CredentialProbe::from_user("kanade-backend");
        assert_eq!(probe.kind(), CredentialKind::User);
        assert!(!probe.is_ours("kanade-backend"));
    }

    #[test]
    fn the_probe_never_prints_the_credential() {
        // `/connz` handling logs liberally; one `{:?}` on the probe must not
        // be the thing that puts the fleet's token in a log file.
        let probe = CredentialProbe::from_token(Some("super-secret-token".into()));
        let rendered = format!("{probe:?}");
        assert!(!rendered.contains("super-secret-token"), "{rendered}");
        assert!(rendered.contains("redacted"), "{rendered}");
        assert!(
            format!("{:?}", CredentialProbe::from_token(None)).contains("none"),
            "the no-credential case should be visible, just not the value"
        );
        // A username is not a secret — hiding it would cost diagnosability
        // for nothing.
        assert!(
            format!("{:?}", CredentialProbe::from_user("kanade-backend"))
                .contains("kanade-backend"),
        );
    }

    // ── per-role users ───────────────────────────────────────────────

    fn user(r: Result<Option<UserCredential>>) -> Option<(String, String)> {
        r.unwrap().map(|u| (u.name, u.password))
    }

    #[test]
    fn a_users_registry_pair_comes_from_the_roles_own_key() {
        let registry = reg(&[
            (r"SOFTWARE\kanade\backend\NatsUser", "kanade-backend"),
            (r"SOFTWARE\kanade\backend\NatsPassword", "pw"),
        ]);
        assert_eq!(
            user(resolve_user_with(NatsRole::Backend, &registry, None, None)),
            Some(("kanade-backend".into(), "pw".into()))
        );
        // No shared user: another role does not inherit it, not even the
        // agent's key (which is where the shared *token* lives).
        for role in [NatsRole::Agent, NatsRole::Cli] {
            assert_eq!(user(resolve_user_with(role, &registry, None, None)), None);
        }
        let agent = reg(&[
            (r"SOFTWARE\kanade\agent\NatsUser", "a"),
            (r"SOFTWARE\kanade\agent\NatsPassword", "b"),
        ]);
        assert_eq!(
            user(resolve_user_with(NatsRole::Cli, &agent, None, None)),
            None
        );
    }

    #[test]
    fn the_registry_pair_outranks_the_environment_pair() {
        let registry = reg(&[
            (r"SOFTWARE\kanade\cli\NatsUser", "reg-user"),
            (r"SOFTWARE\kanade\cli\NatsPassword", "reg-pw"),
        ]);
        assert_eq!(
            user(resolve_user_with(
                NatsRole::Cli,
                &registry,
                Some("env-user".into()),
                Some("env-pw".into())
            )),
            Some(("reg-user".into(), "reg-pw".into()))
        );
    }

    #[test]
    fn the_environment_serves_a_user_pair_when_the_registry_has_none() {
        assert_eq!(
            user(resolve_user_with(
                NatsRole::Cli,
                reg(&[]),
                Some("u".into()),
                Some("p".into())
            )),
            Some(("u".into(), "p".into()))
        );
        // Empty values are not a credential.
        assert_eq!(
            user(resolve_user_with(
                NatsRole::Cli,
                reg(&[]),
                Some(String::new()),
                Some(String::new())
            )),
            None
        );
        assert_eq!(
            user(resolve_user_with(NatsRole::Cli, reg(&[]), None, None)),
            None
        );
    }

    #[test]
    fn half_a_pair_is_an_error_not_a_fallback() {
        let err = |r: Result<Option<UserCredential>>| format!("{:#}", r.unwrap_err());
        // Registry halves.
        let only_user = reg(&[(r"SOFTWARE\kanade\cli\NatsUser", "u")]);
        assert!(
            err(resolve_user_with(NatsRole::Cli, &only_user, None, None))
                .contains("password is missing")
        );
        let only_pw = reg(&[(r"SOFTWARE\kanade\cli\NatsPassword", "secret-pw")]);
        let e = err(resolve_user_with(NatsRole::Cli, &only_pw, None, None));
        assert!(e.contains("user name is missing"), "{e}");
        assert!(!e.contains("secret-pw"), "{e}");
        // A half registry pair is not rescued by a complete environment pair.
        assert!(
            resolve_user_with(
                NatsRole::Cli,
                &only_user,
                Some("u".into()),
                Some("p".into())
            )
            .is_err()
        );
        // Environment halves.
        assert!(resolve_user_with(NatsRole::Cli, reg(&[]), Some("u".into()), None).is_err());
        assert!(resolve_user_with(NatsRole::Cli, reg(&[]), None, Some("p".into())).is_err());
    }

    #[test]
    fn credentials_never_print_a_secret() {
        let creds = NatsCredentials::new(
            Some("tok-secret".into()),
            Some(("kanade-agent".into(), "pw-secret".into())),
        );
        let rendered = format!("{creds:?}");
        assert!(!rendered.contains("tok-secret"), "{rendered}");
        assert!(!rendered.contains("pw-secret"), "{rendered}");
        assert!(rendered.contains("kanade-agent"), "{rendered}");
    }

    #[test]
    fn no_user_means_the_static_token_path_with_no_selection() {
        match auth_plan(NatsCredentials::new(Some("t".into()), None)) {
            AuthPlan::Static(Some(t)) => assert_eq!(t, "t"),
            _ => panic!("a token-only host must take the static path"),
        }
        assert!(matches!(
            auth_plan(NatsCredentials::new(None, None)),
            AuthPlan::Static(None)
        ));
        assert!(matches!(
            auth_plan(NatsCredentials::new(
                Some("t".into()),
                Some(("u".into(), "p".into()))
            )),
            AuthPlan::Select { .. }
        ));
    }

    #[test]
    fn selection_follows_the_probe() {
        use Choice::{Token, User};
        use ProbeOutcome::*;
        assert_eq!(select(Accepted, None, true), Ok(User));
        assert_eq!(select(Accepted, Some(Token), false), Ok(User));
        assert_eq!(select(Rejected, Some(User), true), Ok(Token));
        let missing = select(Rejected, None, false).unwrap_err();
        assert!(missing.contains("NatsToken"), "{missing}");
        // Unreachable keeps what last worked, defaulting to the user.
        assert_eq!(select(Unreachable, None, true), Ok(User));
        assert_eq!(select(Unreachable, Some(Token), true), Ok(Token));
        assert_eq!(select(Unreachable, Some(User), true), Ok(User));
    }

    #[tokio::test]
    async fn only_a_probe_answer_is_remembered() {
        let live = Live::default();
        let role = NatsRole::Cli;
        let run = |o| choose(role, true, &live, move || async move { o });
        // An unreachable broker is a guess, not evidence.
        assert_eq!(run(ProbeOutcome::Unreachable).await, Ok(Choice::User));
        assert_eq!(live.get(), None);
        assert_eq!(run(ProbeOutcome::Rejected).await, Ok(Choice::Token));
        assert_eq!(live.get(), Some(Choice::Token));
        // The broker goes away: the token that last worked is reused.
        assert_eq!(run(ProbeOutcome::Unreachable).await, Ok(Choice::Token));
        // ...and the flip back is followed.
        assert_eq!(run(ProbeOutcome::Accepted).await, Ok(Choice::User));
        assert_eq!(live.get(), Some(Choice::User));
        // A rejection with no token fails and leaves the cache alone.
        let err = choose(role, false, &live, || async { ProbeOutcome::Rejected })
            .await
            .unwrap_err();
        assert!(err.contains("NatsToken"));
        assert_eq!(live.get(), Some(Choice::User));
    }

    #[test]
    fn the_probe_reports_the_shape_in_use_right_now() {
        let live = Arc::new(Live::default());
        let probe = CredentialProbe {
            token: Some("tok".into()),
            user: Some("kanade-agent".into()),
            live: Some(live.clone()),
        };
        // Nothing proven yet: not the user shape.
        assert_eq!(probe.kind(), CredentialKind::Token);
        live.set(Choice::User);
        assert_eq!(probe.kind(), CredentialKind::User);
        // Holding a user while on the token fallback is the token shape.
        live.set(Choice::Token);
        assert_eq!(probe.kind(), CredentialKind::Token);
        assert!(probe.is_ours("tok"));

        let user_only = CredentialProbe {
            token: None,
            user: Some("u".into()),
            live: Some(Arc::new(Live::default())),
        };
        assert_eq!(user_only.kind(), CredentialKind::None);
        user_only.live.as_ref().unwrap().set(Choice::User);
        assert_eq!(user_only.kind(), CredentialKind::User);
    }

    #[test]
    fn a_probe_holding_both_credentials_prints_neither_secret() {
        let probe = CredentialProbe {
            token: Some("tok-secret".into()),
            user: Some("kanade-agent".into()),
            live: None,
        };
        let rendered = format!("{probe:?}");
        assert!(!rendered.contains("tok-secret"), "{rendered}");
        assert!(rendered.contains("kanade-agent"), "{rendered}");
    }

    #[test]
    fn sustained_refusals_fail_the_client_and_a_connect_clears_them() {
        let refused = || {
            async_nats::Event::ClientError(async_nats::ClientError::Other(
                async_nats::ConnectErrorKind::AuthorizationViolation.to_string(),
            ))
        };
        let live = Live::default();
        for _ in 0..AUTH_REJECTION_LIMIT {
            live.observe(&refused());
        }
        // Enough refusals, but not over a long enough window: a broker
        // mid-reload must not count.
        assert!(!live.auth_failed());
        // Age the first refusal past the window.
        let aged = std::time::Instant::now() - AUTH_REJECTION_WINDOW - Duration::from_secs(1);
        *live.refusals.lock().unwrap() = Some((aged, AUTH_REJECTION_LIMIT));
        assert!(live.auth_failed());
        live.observe(&async_nats::Event::Connected);
        assert!(!live.auth_failed());
        // A different kind of failure (broker gone) ends the run, so refusals
        // from before an outage cannot add up to a failure after it.
        *live.refusals.lock().unwrap() = Some((aged, AUTH_REJECTION_LIMIT));
        live.observe(&async_nats::Event::ClientError(
            async_nats::ClientError::Other("io".into()),
        ));
        assert!(!live.auth_failed());
        live.observe(&refused());
        assert!(!live.auth_failed());
    }

    #[test]
    fn connect_leaves_a_process_crypto_provider_installed() {
        // #1187: a binary that links both aws-lc-rs and ring (any workspace
        // build) panics on its first wss handshake unless a process-level
        // provider was installed first. That panic happens inside async-nats'
        // background task, so the only thing a caller ever sees is a client
        // that silently never works — pin the precondition here instead.
        // `retry_on_initial_connect` makes connect return without a broker.
        let rt = tokio::runtime::Builder::new_current_thread()
            .enable_all()
            .build()
            .unwrap();
        rt.block_on(async {
            connect(NatsRole::Agent, "nats://127.0.0.1:1")
                .await
                .unwrap();
        });
        assert!(rustls::crypto::CryptoProvider::get_default().is_some());
    }
}