juncture 0.1.0

Typed state machine framework for LLM agents - Rust implementation of LangGraph
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
//! Middleware system for LLM invocation interception.
//!
//! Provides a flexible middleware pattern that wraps [`ChatModel::invoke()`]
//! calls with pre/post processing hooks. Middleware can be used for logging,
//! metrics collection, request modification, error recovery, and more.
//!
//! # Architecture
//!
//! Middleware is executed in a pipeline:
//!
//! 1. **Pre-invoke** (forward order): All middleware `pre_invoke()` methods run
//!    in the order they were added. Each can modify messages and options or abort
//!    the call by returning an error.
//!
//! 2. **LLM call**: The inner model's `invoke()` method executes.
//!
//! 3. **Post-invoke** (reverse order): All middleware `post_invoke()` methods run
//!    in **reverse order** (last added runs first). Each can modify the result or
//!    convert errors into successes.
//!
//! # Example
//!
//! ```ignore
//! use juncture::llm::{ChatModel, MockChatModel, MiddlewareModel};
//! use juncture::llm::middleware::{LoggingMiddleware, MetricsMiddleware};
//! use juncture::Message;
//!
//! # #[tokio::main]
//! # async fn main() -> Result<(), Box<dyn std::error::Error>> {
//! let base_model = MockChatModel::new("gpt-4").with_response("Hello!");
//!
//! // Add logging and metrics middleware
//! let model = MiddlewareModel::new(base_model)
//!     .with_middleware(LoggingMiddleware::new())
//!     .with_middleware(MetricsMiddleware::new());
//!
//! let messages = vec![Message::human("Hi")];
//! let response = model.invoke(&messages, None).await?;
//! # Ok(())
//! # }
//! ```

use std::cell::Cell;
use std::fmt;
use std::pin::Pin;
use std::sync::Arc;
use std::sync::atomic::{AtomicU64, Ordering};
use std::time::Instant;

use async_trait::async_trait;
use futures::Stream;
use tracing::{Level, event};

use crate::llm::{CallOptions, ChatModel, LlmError, Message, MessageChunk, ToolDefinition};

// Thread-local storage for middleware timing data.
// Each middleware that needs timing data can use this to store a start time
// in `pre_invoke()` and retrieve it in `post_invoke()`. This works because
// both methods are called sequentially in the same async task context.
thread_local! {
    /// Start time for middleware execution tracking.
    static MIDDLEWARE_START_TIME: Cell<Option<Instant>> = const { Cell::new(None) };
}

/// Middleware for intercepting LLM invocations.
///
/// Implementations can modify requests and responses, collect metrics,
/// add logging, or implement custom retry/error handling logic.
///
/// # Lifecycle
///
/// For each [`ChatModel::invoke()`] call:
///
/// 1. [`Self::pre_invoke()`] is called in the order middleware were added
/// 2. The inner LLM call executes
/// 3. [`Self::post_invoke()`] is called in **reverse order**
///
/// # Example
///
/// ```
/// use juncture::llm::middleware::LlmMiddleware;
/// use juncture::llm::{CallOptions, LlmError, Message};
/// use async_trait::async_trait;
///
/// struct UppercaseMiddleware;
///
/// #[async_trait]
/// impl LlmMiddleware for UppercaseMiddleware {
///     async fn pre_invoke(
///         &self,
///         _messages: &mut Vec<Message>,
///         _options: &mut CallOptions,
///     ) -> Result<(), LlmError> {
///         // Implementation here
///         Ok(())
///     }
/// }
/// ```
#[cfg_attr(target_family = "wasm", async_trait(?Send))]
#[cfg_attr(not(target_family = "wasm"), async_trait)]
pub trait LlmMiddleware: Send + Sync + 'static {
    /// Called before the LLM invocation.
    ///
    /// This method runs in the order middleware were added (first added runs first).
    /// It can modify the `messages` and `options` parameters, or abort the call
    /// by returning an error.
    ///
    /// # Parameters
    ///
    /// * `messages` - The messages to send to the LLM (mutable for modification)
    /// * `options` - The call options (mutable for modification)
    ///
    /// # Errors
    ///
    /// Returns an error to abort the LLM call. The error is propagated back
    /// to the caller without invoking the LLM.
    ///
    /// # Default Implementation
    ///
    /// The default implementation does nothing and always returns `Ok(())`.
    async fn pre_invoke(
        &self,
        _messages: &mut Vec<Message>,
        _options: &mut CallOptions,
    ) -> Result<(), LlmError> {
        Ok(())
    }

    /// Called after the LLM invocation completes.
    ///
    /// This method runs in **reverse order** (last added middleware runs first).
    /// It can inspect and modify the result, or convert errors into successes.
    ///
    /// # Parameters
    ///
    /// * `result` - The result from the LLM call (mutable for modification)
    ///
    /// # Errors
    ///
    /// Returns an error to replace the original result. This can be used to
    /// implement error recovery or transformation.
    ///
    /// # Default Implementation
    ///
    /// The default implementation does nothing and always returns `Ok(())`.
    async fn post_invoke(&self, _result: &mut Result<Message, LlmError>) -> Result<(), LlmError> {
        Ok(())
    }
}

/// Wrapper that applies middleware to a [`ChatModel`].
///
/// Executes middleware in a pipeline around the inner model's `invoke()` calls.
/// Middleware can modify requests/responses, collect metrics, add logging, etc.
///
/// # Type Parameters
///
/// * `M` - The inner [`ChatModel`] type to wrap
///
/// # Example
///
/// ```ignore
/// use juncture::llm::{ChatModel, MockChatModel, MiddlewareModel};
/// use juncture::llm::middleware::LoggingMiddleware;
/// use juncture::Message;
///
/// # #[tokio::main]
/// # async fn main() -> Result<(), Box<dyn std::error::Error>> {
/// let base_model = MockChatModel::new("gpt-4").with_response("Hello!");
/// let model = MiddlewareModel::new(base_model)
///     .with_middleware(LoggingMiddleware::new().with_model_name("gpt-4"));
///
/// let messages = vec![Message::human("Hi")];
/// let response = model.invoke(&messages, None).await?;
/// # Ok(())
/// # }
/// ```
#[derive(Clone)]
pub struct MiddlewareModel<M: ChatModel> {
    /// Inner model to wrap.
    inner: M,

    /// Middleware to apply (in execution order).
    middleware: Vec<Arc<dyn LlmMiddleware>>,
}

// Manual Debug implementation since dyn LlmMiddleware doesn't implement Debug
impl<M: ChatModel> fmt::Debug for MiddlewareModel<M> {
    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
        f.debug_struct("MiddlewareModel")
            .field("inner", &self.inner.model_name())
            .field("middleware_count", &self.middleware.len())
            .finish()
    }
}

impl<M: ChatModel> MiddlewareModel<M> {
    /// Create a new middleware wrapper with no middleware.
    ///
    /// # Arguments
    ///
    /// * `inner` - The underlying model to wrap
    ///
    /// # Example
    ///
    /// ```rust
    /// use juncture::llm::{ChatModel, MockChatModel, MiddlewareModel};
    ///
    /// let base_model = MockChatModel::new("gpt-4");
    /// let model = MiddlewareModel::new(base_model);
    /// ```
    #[must_use]
    pub fn new(inner: M) -> Self {
        Self {
            inner,
            middleware: Vec::new(),
        }
    }

    /// Add a middleware to the pipeline.
    ///
    /// Middleware are executed in the order they are added. The `pre_invoke()`
    /// method runs in forward order, while `post_invoke()` runs in reverse order.
    ///
    /// # Arguments
    ///
    /// * `middleware` - The middleware to add
    ///
    /// # Example
    ///
    /// ```rust
    /// use juncture::llm::{MockChatModel, MiddlewareModel};
    /// use juncture::llm::middleware::LoggingMiddleware;
    /// use std::sync::Arc;
    ///
    /// let base_model = MockChatModel::new("gpt-4");
    /// let model = MiddlewareModel::new(base_model)
    ///     .with_middleware(LoggingMiddleware::new());
    /// ```
    #[must_use]
    pub fn with_middleware(mut self, middleware: impl LlmMiddleware) -> Self {
        self.middleware.push(Arc::new(middleware));
        self
    }

    /// Add multiple middleware to the pipeline.
    ///
    /// Middleware are executed in the order they appear in the slice.
    ///
    /// # Arguments
    ///
    /// * `middleware` - Slice of middleware to add
    ///
    /// # Example
    ///
    /// ```rust
    /// use juncture::llm::{MockChatModel, MiddlewareModel};
    /// use juncture::llm::middleware::{LoggingMiddleware, MetricsMiddleware};
    /// use std::sync::Arc;
    ///
    /// let base_model = MockChatModel::new("gpt-4");
    /// let model = MiddlewareModel::new(base_model)
    ///     .with_middlewares(&[
    ///         LoggingMiddleware::new(),
    ///         MetricsMiddleware::new(),
    ///     ]);
    /// ```
    #[must_use]
    pub fn with_middlewares(mut self, middleware: &[Arc<dyn LlmMiddleware>]) -> Self {
        self.middleware.extend_from_slice(middleware);
        self
    }
}

impl<M: ChatModel + Default> Default for MiddlewareModel<M> {
    fn default() -> Self {
        Self::new(M::default())
    }
}

#[cfg_attr(target_family = "wasm", async_trait(?Send))]
#[cfg_attr(not(target_family = "wasm"), async_trait)]
impl<M: ChatModel> ChatModel for MiddlewareModel<M> {
    async fn invoke(
        &self,
        messages: &[Message],
        options: Option<&CallOptions>,
    ) -> Result<Message, LlmError> {
        // Clone messages and options for modification
        let mut messages = messages.to_vec();
        let mut options = options.cloned().unwrap_or_default();

        // Run pre_invoke in forward order
        for mw in &self.middleware {
            mw.pre_invoke(&mut messages, &mut options).await?;
        }

        // Execute the inner LLM call
        let mut result = self.inner.invoke(&messages, Some(&options)).await;

        // Run post_invoke in reverse order
        for mw in self.middleware.iter().rev() {
            mw.post_invoke(&mut result).await?;
        }

        result
    }

    fn stream(
        &self,
        messages: &[Message],
        options: Option<&CallOptions>,
    ) -> Pin<Box<dyn Stream<Item = Result<MessageChunk, LlmError>> + Send + '_>> {
        // For streaming, we pass through to the inner model
        // Running async pre_invoke in the non-async stream() method is not feasible
        // For production use, consider a different design for streaming middleware
        self.inner.stream(messages, options)
    }

    fn bind_tools(&self, tools: Vec<ToolDefinition>) -> Self {
        let inner_with_tools = self.inner.bind_tools(tools);
        Self {
            inner: inner_with_tools,
            middleware: self.middleware.clone(),
        }
    }

    fn model_name(&self) -> &str {
        self.inner.model_name()
    }
}

/// Middleware that logs LLM invocation using structured logging.
///
/// Emits OpenTelemetry-compatible events for request starts and completions,
/// making it easy to trace LLM calls in distributed systems.
///
/// # Example
///
/// ```ignore
/// use juncture::llm::{ChatModel, MockChatModel, MiddlewareModel};
/// use juncture::llm::middleware::LoggingMiddleware;
/// use juncture::Message;
///
/// # #[tokio::main]
/// # async fn main() -> Result<(), Box<dyn std::error::Error>> {
/// let base_model = MockChatModel::new("gpt-4").with_response("Hello!");
/// let model = MiddlewareModel::new(base_model)
///     .with_middleware(LoggingMiddleware::new().with_model_name("gpt-4"));
///
/// let messages = vec![Message::human("Hi")];
/// let response = model.invoke(&messages, None).await?;
/// # Ok(())
/// # }
/// ```
#[derive(Clone, Debug)]
pub struct LoggingMiddleware {
    /// Model name to include in logs (optional).
    model_name: String,
}

impl LoggingMiddleware {
    /// Create a new logging middleware with no model name.
    ///
    /// # Example
    ///
    /// ```rust
    /// use juncture::llm::middleware::LoggingMiddleware;
    ///
    /// let middleware = LoggingMiddleware::new();
    /// ```
    #[must_use]
    pub const fn new() -> Self {
        Self {
            model_name: String::new(),
        }
    }

    /// Set the model name for logging purposes.
    ///
    /// # Arguments
    ///
    /// * `model_name` - The model name to include in log events
    ///
    /// # Example
    ///
    /// ```rust
    /// use juncture::llm::middleware::LoggingMiddleware;
    ///
    /// let middleware = LoggingMiddleware::new().with_model_name("gpt-4");
    /// ```
    #[must_use]
    pub fn with_model_name(mut self, model_name: impl Into<String>) -> Self {
        self.model_name = model_name.into();
        self
    }
}

impl Default for LoggingMiddleware {
    fn default() -> Self {
        Self::new()
    }
}

#[cfg_attr(target_family = "wasm", async_trait(?Send))]
#[cfg_attr(not(target_family = "wasm"), async_trait)]
impl LlmMiddleware for LoggingMiddleware {
    async fn pre_invoke(
        &self,
        messages: &mut Vec<Message>,
        _options: &mut CallOptions,
    ) -> Result<(), LlmError> {
        event!(
            name: "llm.invoke.started",
            Level::INFO,
            model_name = %self.model_name,
            message_count = messages.len(),
            "LLM invoke started",
        );
        Ok(())
    }

    async fn post_invoke(&self, result: &mut Result<Message, LlmError>) -> Result<(), LlmError> {
        let status = if result.is_ok() { "ok" } else { "error" };

        event!(
            name: "llm.invoke.completed",
            Level::INFO,
            model_name = %self.model_name,
            status,
            "LLM invoke completed",
        );
        Ok(())
    }
}

/// Metrics collected by [`MetricsMiddleware`].
///
/// Contains aggregated statistics about LLM invocations.
#[derive(Debug, Clone, Copy)]
pub struct LlmMetrics {
    /// Total number of successful invocations.
    pub invoke_count: u64,

    /// Total number of failed invocations.
    pub error_count: u64,

    /// Average duration of successful invocations (in milliseconds).
    pub avg_duration_ms: u64,

    /// Total duration of all successful invocations (in milliseconds).
    pub total_duration_ms: u64,
}

/// Middleware that tracks LLM invocation metrics.
///
/// Records invocation counts, error counts, and timing statistics using
/// lock-free atomic operations for thread-safe performance.
///
/// # Thread Safety
///
/// This middleware uses [`AtomicU64`] for all counters, making it safe
/// to share across threads without locking.
///
/// # Example
///
/// ```ignore
/// use juncture::llm::{ChatModel, MockChatModel, MiddlewareModel};
/// use juncture::llm::middleware::MetricsMiddleware;
/// use juncture::Message;
///
/// # #[tokio::main]
/// # async fn main() -> Result<(), Box<dyn std::error::Error>> {
/// let base_model = MockChatModel::new("gpt-4").with_response("Hello!");
/// let middleware = MetricsMiddleware::new();
///
/// let model = MiddlewareModel::new(base_model)
///     .with_middleware(middleware.clone());
///
/// let messages = vec![Message::human("Hi")];
/// let response = model.invoke(&messages, None).await?;
///
/// let metrics = middleware.metrics();
/// assert!(metrics.invoke_count > 0);
/// # Ok(())
/// # }
/// ```
#[derive(Clone, Debug)]
pub struct MetricsMiddleware {
    /// Total number of successful invocations.
    invoke_count: Arc<AtomicU64>,

    /// Total number of failed invocations.
    error_count: Arc<AtomicU64>,

    /// Total duration of all successful invocations (in milliseconds).
    total_duration_ms: Arc<AtomicU64>,
}

impl MetricsMiddleware {
    /// Create a new metrics middleware with zeroed counters.
    ///
    /// # Example
    ///
    /// ```rust
    /// use juncture::llm::middleware::MetricsMiddleware;
    ///
    /// let middleware = MetricsMiddleware::new();
    /// ```
    #[must_use]
    pub fn new() -> Self {
        Self {
            invoke_count: Arc::new(AtomicU64::new(0)),
            error_count: Arc::new(AtomicU64::new(0)),
            total_duration_ms: Arc::new(AtomicU64::new(0)),
        }
    }

    /// Get the current metrics.
    ///
    /// Returns a snapshot of the collected metrics at this moment in time.
    ///
    /// # Example
    ///
    /// ```rust
    /// use juncture::llm::middleware::MetricsMiddleware;
    ///
    /// let middleware = MetricsMiddleware::new();
    /// let metrics = middleware.metrics();
    /// assert_eq!(metrics.invoke_count, 0);
    /// ```
    #[must_use]
    pub fn metrics(&self) -> LlmMetrics {
        let invoke_count = self.invoke_count.load(Ordering::Relaxed);
        let error_count = self.error_count.load(Ordering::Relaxed);
        let total_duration_ms = self.total_duration_ms.load(Ordering::Relaxed);

        let avg_duration_ms = if invoke_count > 0 {
            total_duration_ms / invoke_count
        } else {
            0
        };

        LlmMetrics {
            invoke_count,
            error_count,
            avg_duration_ms,
            total_duration_ms,
        }
    }

    /// Reset all metrics to zero.
    ///
    /// # Example
    ///
    /// ```rust
    /// use juncture::llm::middleware::MetricsMiddleware;
    ///
    /// let middleware = MetricsMiddleware::new();
    /// middleware.reset();
    /// assert_eq!(middleware.metrics().invoke_count, 0);
    /// ```
    pub fn reset(&self) {
        self.invoke_count.store(0, Ordering::Relaxed);
        self.error_count.store(0, Ordering::Relaxed);
        self.total_duration_ms.store(0, Ordering::Relaxed);
    }
}

impl Default for MetricsMiddleware {
    fn default() -> Self {
        Self::new()
    }
}

#[cfg_attr(target_family = "wasm", async_trait(?Send))]
#[cfg_attr(not(target_family = "wasm"), async_trait)]
impl LlmMiddleware for MetricsMiddleware {
    async fn pre_invoke(
        &self,
        _messages: &mut Vec<Message>,
        _options: &mut CallOptions,
    ) -> Result<(), LlmError> {
        // Store the start time in thread-local storage
        #[cfg(not(target_family = "wasm"))]
        MIDDLEWARE_START_TIME.set(Some(Instant::now()));
        Ok(())
    }

    async fn post_invoke(&self, result: &mut Result<Message, LlmError>) -> Result<(), LlmError> {
        // Calculate duration from stored start time
        let duration_ms = MIDDLEWARE_START_TIME.with(|start| {
            start.take().map_or(0, |s| {
                s.elapsed().as_millis().try_into().unwrap_or(u64::MAX)
            })
        });

        // Update counters based on result
        match result {
            Ok(_) => {
                self.invoke_count.fetch_add(1, Ordering::Relaxed);
                self.total_duration_ms
                    .fetch_add(duration_ms, Ordering::Relaxed);
            }
            Err(_) => {
                self.error_count.fetch_add(1, Ordering::Relaxed);
            }
        }

        Ok(())
    }
}

#[cfg(test)]
mod tests {
    use super::*;
    use crate::llm::mock::MockChatModel;

    #[test]
    fn test_middleware_model_new() {
        let base_model = MockChatModel::new("gpt-4");
        let model = MiddlewareModel::new(base_model);

        assert!(model.middleware.is_empty());
        assert_eq!(model.model_name(), "gpt-4");
    }

    #[test]
    fn test_middleware_model_builder() {
        let base_model = MockChatModel::new("gpt-4");
        let log_mw = LoggingMiddleware::new();
        let metrics_mw = MetricsMiddleware::new();

        let model = MiddlewareModel::new(base_model)
            .with_middleware(log_mw)
            .with_middleware(metrics_mw);

        assert_eq!(model.middleware.len(), 2);
    }

    #[test]
    fn test_logging_middleware() {
        let middleware = LoggingMiddleware::new();
        assert_eq!(middleware.model_name, "");

        let with_name = LoggingMiddleware::new().with_model_name("gpt-4");
        assert_eq!(with_name.model_name, "gpt-4");
    }

    #[test]
    fn test_metrics_middleware_new() {
        let middleware = MetricsMiddleware::new();
        let metrics = middleware.metrics();

        assert_eq!(metrics.invoke_count, 0);
        assert_eq!(metrics.error_count, 0);
        assert_eq!(metrics.total_duration_ms, 0);
        assert_eq!(metrics.avg_duration_ms, 0);
    }

    #[test]
    fn test_metrics_middleware_reset() {
        let middleware = MetricsMiddleware::new();

        // Simulate some metrics
        middleware.invoke_count.fetch_add(5, Ordering::Relaxed);
        middleware.error_count.fetch_add(2, Ordering::Relaxed);
        middleware
            .total_duration_ms
            .fetch_add(100, Ordering::Relaxed);

        let metrics = middleware.metrics();
        assert_eq!(metrics.invoke_count, 5);
        assert_eq!(metrics.error_count, 2);

        // Reset
        middleware.reset();
        let metrics_after = middleware.metrics();
        assert_eq!(metrics_after.invoke_count, 0);
        assert_eq!(metrics_after.error_count, 0);
        assert_eq!(metrics_after.total_duration_ms, 0);
    }

    /// Test middleware that aborts in `pre_invoke`
    struct AbortMiddleware;

    #[cfg_attr(target_family = "wasm", async_trait(?Send))]
    #[cfg_attr(not(target_family = "wasm"), async_trait)]
    impl LlmMiddleware for AbortMiddleware {
        async fn pre_invoke(
            &self,
            _messages: &mut Vec<Message>,
            _options: &mut CallOptions,
        ) -> Result<(), LlmError> {
            Err(LlmError::Other(Box::new(std::io::Error::other(
                "aborted by middleware",
            ))))
        }
    }

    #[tokio::test]
    async fn test_pre_invoke_abort() {
        let base_model = MockChatModel::new("gpt-4").with_response("Hello!");
        let model = MiddlewareModel::new(base_model).with_middleware(AbortMiddleware);

        let messages = vec![Message::human("Hi")];
        let result = model.invoke(&messages, None).await;

        assert!(result.is_err());
        assert!(
            result
                .unwrap_err()
                .to_string()
                .contains("aborted by middleware")
        );
    }

    /// Test middleware that modifies the result in `post_invoke`
    struct ResultModifierMiddleware;

    #[cfg_attr(target_family = "wasm", async_trait(?Send))]
    #[cfg_attr(not(target_family = "wasm"), async_trait)]
    impl LlmMiddleware for ResultModifierMiddleware {
        async fn post_invoke(
            &self,
            result: &mut Result<Message, LlmError>,
        ) -> Result<(), LlmError> {
            // Convert errors to successes with a fallback message
            if result.is_err() {
                *result = Ok(Message::ai("Fallback response"));
            }
            Ok(())
        }
    }

    #[tokio::test]
    async fn test_post_invoke_modifies_result() {
        let base_model = MockChatModel::new("gpt-4").with_error();
        let model = MiddlewareModel::new(base_model).with_middleware(ResultModifierMiddleware);

        let messages = vec![Message::human("Hi")];
        let result = model.invoke(&messages, None).await;

        assert!(result.is_ok());
        let response = result.unwrap();
        assert!(matches!(response.role, crate::llm::Role::Ai));
    }

    /// Test middleware that records execution order
    struct OrderRecorder {
        order: Arc<std::sync::Mutex<Vec<String>>>,
        name: String,
    }

    #[cfg_attr(target_family = "wasm", async_trait(?Send))]
    #[cfg_attr(not(target_family = "wasm"), async_trait)]
    impl LlmMiddleware for OrderRecorder {
        async fn pre_invoke(
            &self,
            _messages: &mut Vec<Message>,
            _options: &mut CallOptions,
        ) -> Result<(), LlmError> {
            self.order
                .lock()
                .unwrap_or_else(std::sync::PoisonError::into_inner)
                .push(format!("{}_pre", self.name));
            Ok(())
        }

        async fn post_invoke(
            &self,
            _result: &mut Result<Message, LlmError>,
        ) -> Result<(), LlmError> {
            self.order
                .lock()
                .unwrap_or_else(std::sync::PoisonError::into_inner)
                .push(format!("{}_post", self.name));
            Ok(())
        }
    }

    #[tokio::test]
    async fn test_post_invoke_order() {
        let order = Arc::new(std::sync::Mutex::new(Vec::new()));

        let mw1 = OrderRecorder {
            order: Arc::clone(&order),
            name: "first".to_string(),
        };
        let mw2 = OrderRecorder {
            order: Arc::clone(&order),
            name: "second".to_string(),
        };

        let base_model = MockChatModel::new("gpt-4").with_response("Hello!");
        let model = MiddlewareModel::new(base_model)
            .with_middleware(mw1)
            .with_middleware(mw2);

        let messages = vec![Message::human("Hi")];
        let _ = model.invoke(&messages, None).await;

        let order_data = {
            let order_guard = order
                .lock()
                .unwrap_or_else(std::sync::PoisonError::into_inner);
            order_guard.clone()
        };
        assert_eq!(
            order_data,
            vec![
                "first_pre".to_string(),
                "second_pre".to_string(),
                "second_post".to_string(),
                "first_post".to_string(),
            ]
        );
    }

    #[test]
    fn test_bind_tools_preserves_middleware() {
        let base_model = MockChatModel::new("gpt-4");
        let _log_mw = LoggingMiddleware::new();
        let _metrics_mw = MetricsMiddleware::new();

        let model = MiddlewareModel::new(base_model)
            .with_middleware(LoggingMiddleware::new())
            .with_middleware(MetricsMiddleware::new());

        let model_with_tools = model.bind_tools(vec![]);

        assert_eq!(model_with_tools.middleware.len(), 2);
    }

    #[tokio::test]
    async fn test_metrics_middleware_tracks_invocations() {
        let base_model = MockChatModel::new("gpt-4").with_response("Hello!");
        let middleware = MetricsMiddleware::new();

        let model = MiddlewareModel::new(base_model).with_middleware(middleware.clone());

        let messages = vec![Message::human("Hi")];
        let _ = model.invoke(&messages, None).await;

        let metrics = middleware.metrics();
        assert_eq!(metrics.invoke_count, 1);
        assert_eq!(metrics.error_count, 0);
        // Duration should be recorded, but may be 0 for very fast operations
        let _ = metrics.total_duration_ms;
        let _ = metrics.avg_duration_ms;
    }

    #[tokio::test]
    async fn test_metrics_middleware_tracks_errors() {
        let base_model = MockChatModel::new("gpt-4").with_error();
        let middleware = MetricsMiddleware::new();

        let model = MiddlewareModel::new(base_model).with_middleware(middleware.clone());

        let messages = vec![Message::human("Hi")];
        let _ = model.invoke(&messages, None).await;

        let metrics = middleware.metrics();
        assert_eq!(metrics.invoke_count, 0);
        assert_eq!(metrics.error_count, 1);
        assert_eq!(metrics.total_duration_ms, 0);
        assert_eq!(metrics.avg_duration_ms, 0);
    }
}

// Rust guideline compliant 2026-05-26