#![allow(
clippy::expect_used,
reason = "a broken test setup should fail the test loudly"
)]
use std::fs;
use std::path::{Path, PathBuf};
use std::process::Command;
use std::sync::atomic::{AtomicUsize, Ordering};
fn workdir(files: &[(&str, &str)]) -> PathBuf {
static NEXT: AtomicUsize = AtomicUsize::new(0);
let dir = Path::new(env!("CARGO_TARGET_TMPDIR")).join(format!(
"cli-{}-{}",
std::process::id(),
NEXT.fetch_add(1, Ordering::Relaxed)
));
let _ = fs::remove_dir_all(&dir);
for (name, text) in files {
let path = dir.join(name);
fs::create_dir_all(path.parent().expect("a parent")).expect("create dirs");
fs::write(path, text).expect("write file");
}
fs::create_dir_all(dir.join(".git")).expect("mark the repository root");
dir
}
fn jsonvet(dir: &Path, args: &[&str]) -> (i32, String) {
let out = Command::new(env!("CARGO_BIN_EXE_jsonvet"))
.args(args)
.current_dir(dir)
.env_remove("GITHUB_ACTIONS")
.output()
.expect("run jsonvet");
(
out.status.code().expect("an exit code"),
String::from_utf8(out.stdout).expect("UTF-8 output"),
)
}
#[test]
fn reports_and_exit_codes() {
let dir = workdir(&[
("ok.json", "{\"a\": 1, // c\n}"),
("dup.json", "{\n \"a\": 1,\n \"a\": 2\n}"),
("bom.json", "\u{FEFF}{}"),
]);
assert_eq!(jsonvet(&dir, &["ok.json"]), (0, String::new()));
assert_eq!(
jsonvet(&dir, &["ok.json", "dup.json", "gone.json"]),
(
1,
"dup.json:3:3: error[duplicate-key] duplicate key $.a (first at 2:3)\ngone.json: error: no such file\n"
.to_owned()
)
);
let (code, out) = jsonvet(&dir, &["--strict", "*.json", "bom.json"]);
assert_eq!(
(code, out.as_str()),
(
0,
"bom.json:1:1: warning[byte-order-mark] byte order mark at the start of the file\n"
)
);
assert_eq!(
jsonvet(
&dir,
&["--strict", "*.json", "--max-warnings", "0", "bom.json"]
)
.0,
1
);
assert_eq!(
jsonvet(
&dir,
&[
"--strict",
"*.json",
"--ignore",
"byte-order-mark",
"bom.json"
]
),
(0, String::new())
);
}
#[test]
fn strict_globs_keep_their_1x_meaning() {
let dir = workdir(&[
("package.json", "{// c\n}"),
("a/package.json", "{// c\n}"),
("tsconfig.json", "{// c\n}"),
(".vscode/s.json", "{// c\n}"),
]);
let (code, out) = jsonvet(
&dir,
&[
"--strict",
"*.json",
"--strict",
"!tsconfig*.json",
"--strict",
"!.vscode/*",
"package.json",
"a/package.json",
"tsconfig.json",
".vscode/s.json",
],
);
assert_eq!(
(code, out.as_str()),
(
1,
"package.json:1:2: error[syntax] comments are not allowed in json\na/package.json:1:2: error[syntax] comments are not allowed in json\n"
)
);
}
#[test]
fn help_and_version_letters_in_a_file_name_are_a_file() {
let dir = workdir(&[("bad.json", "[1,"), ("-h.json", "{}"), ("-V.json", "{}")]);
let (code, out) = jsonvet(&dir, &["bad.json", "-h.json", "-V.json"]);
assert_eq!(
(code, out.as_str()),
(
1,
"bad.json:1:4: error[syntax] expected a value, found the end of the file\n"
)
);
}
#[cfg(target_os = "linux")]
#[test]
fn a_file_name_that_is_not_utf8_is_opened_as_given() {
use std::ffi::OsStr;
use std::os::unix::ffi::OsStrExt;
let dir = workdir(&[]);
let name = OsStr::from_bytes(b"caf\xe9.json");
fs::write(dir.join(name), "[1,]").expect("write file");
let out = Command::new(env!("CARGO_BIN_EXE_jsonvet"))
.args(["--strict", "*"])
.arg(name)
.current_dir(&dir)
.env_remove("GITHUB_ACTIONS")
.output()
.expect("run jsonvet");
assert_eq!(
String::from_utf8_lossy(&out.stdout),
"caf\u{FFFD}.json:1:4: error[syntax] trailing comma before `]` is not allowed in json\n"
);
}
#[test]
fn config_file_and_its_search() {
let dir = workdir(&[
(
"jsonvet.toml",
"rules = { duplicate-key = \"warning\" }\ndialects = [{ files = \"*.data\", dialect = \"jsonl\" }]\n",
),
("sub/x.data", "{\"a\": 1, \"a\": 2}\n\n"),
]);
let (code, out) = jsonvet(&dir.join("sub"), &["x.data"]);
assert_eq!(code, 1);
assert_eq!(
out,
"x.data:1:10: warning[duplicate-key] duplicate key $.a (first at 1:2)\nx.data:2:1: error[syntax] blank line; JSON Lines needs a value on every line\n"
);
assert_eq!(
jsonvet(
&dir.join("sub"),
&["--error", "duplicate-key", "--dialect", "json5", "x.data"]
)
.1
.lines()
.next(),
Some("x.data:1:10: error[duplicate-key] duplicate key $.a (first at 1:2)")
);
assert_eq!(jsonvet(&dir.join("sub"), &["--no-config", "x.data"]).0, 1);
}
#[test]
fn config_search_stops_at_the_repository_root() {
let outer = workdir(&[("jsonvet.toml", "rules = { duplicate-key = \"ignore\" }\n")]);
let repo = outer.join("repo");
fs::create_dir_all(repo.join(".git")).expect("inner repository");
fs::write(repo.join("d.json"), "{\"a\": 1, \"a\": 2}").expect("write");
assert_eq!(
jsonvet(&repo, &["d.json"]).0,
1,
"the outer jsonvet.toml must not apply"
);
}
#[test]
fn pyproject_tool_table_and_bad_configs() {
let dir = workdir(&[
(
"pyproject.toml",
"[project]\nname = \"x\"\n\n[tool.jsonvet]\nrules = { duplicate-key = \"ignore\" }\n",
),
("d.json", "{\"a\": 1, \"a\": 2}"),
("bad.toml", "rules = { nope = \"error\" }\n"),
(
"bad-entry.toml",
"dialects = [{ files = \"*\", dialect = \"json\", dialekt = \"json5\" }]\n",
),
]);
assert_eq!(jsonvet(&dir, &["d.json"]), (0, String::new()));
assert_eq!(jsonvet(&dir, &["--config", "bad.toml", "d.json"]).0, 2);
assert_eq!(
jsonvet(&dir, &["--config", "bad-entry.toml", "d.json"]).0,
2
);
let typo = workdir(&[
(
"pyproject.toml",
"[tool.jsonvet]\nrule = { duplicate-key = \"ignore\" }\n",
),
("d.json", "{}"),
]);
assert_eq!(jsonvet(&typo, &["d.json"]).0, 2);
}