jpegli-rs 0.12.0

Pure Rust JPEG encoder/decoder - port of Google's jpegli with perceptual optimizations
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
//! Comprehensive codec coverage tests for both encode and decode paths.
//!
//! This test file ensures coverage of:
//! - All encoder configuration options
//! - All decoder configuration options
//! - Edge cases and error handling
//! - Various image formats and sizes
//! - All subsampling modes
//! - Progressive and baseline modes
//! - XYB and YCbCr color spaces

#[path = "../src/test_utils.rs"]
mod test_utils;

use jpegli::{
    decoder::{Decoder, DecoderConfig, PixelFormat},
    encoder::{ChromaSubsampling, EncoderConfig, PixelLayout, Quality, XybSubsampling},
};
use test_utils::{
    generate_checkerboard, generate_color_bars, generate_gradient_d, generate_gradient_h,
    generate_gradient_v, generate_noise, generate_solid, generate_solid_rgb, TestImage,
};

// ============================================================================
// HELPER FUNCTIONS
// ============================================================================

fn encode_rgb(
    width: u32,
    height: u32,
    data: &[u8],
    config: &EncoderConfig,
) -> jpegli::encoder::Result<Vec<u8>> {
    let mut enc = config.encode_from_bytes(width, height, PixelLayout::Rgb8Srgb)?;
    enc.push_packed(data, enough::Unstoppable)?;
    enc.finish()
}

fn encode_gray(
    width: u32,
    height: u32,
    data: &[u8],
    config: &EncoderConfig,
) -> jpegli::encoder::Result<Vec<u8>> {
    let mut enc = config.encode_from_bytes(width, height, PixelLayout::Gray8Srgb)?;
    enc.push_packed(data, enough::Unstoppable)?;
    enc.finish()
}

fn encode_rgba(
    width: u32,
    height: u32,
    data: &[u8],
    config: &EncoderConfig,
) -> jpegli::encoder::Result<Vec<u8>> {
    let mut enc = config.encode_from_bytes(width, height, PixelLayout::Rgbx8Srgb)?;
    enc.push_packed(data, enough::Unstoppable)?;
    enc.finish()
}

#[allow(dead_code)]
fn encode_bgr(
    width: u32,
    height: u32,
    data: &[u8],
    config: &EncoderConfig,
) -> jpegli::encoder::Result<Vec<u8>> {
    let mut enc = config.encode_from_bytes(width, height, PixelLayout::Bgr8Srgb)?;
    enc.push_packed(data, enough::Unstoppable)?;
    enc.finish()
}

#[allow(dead_code)]
fn encode_bgra(
    width: u32,
    height: u32,
    data: &[u8],
    config: &EncoderConfig,
) -> jpegli::encoder::Result<Vec<u8>> {
    let mut enc = config.encode_from_bytes(width, height, PixelLayout::Bgrx8Srgb)?;
    enc.push_packed(data, enough::Unstoppable)?;
    enc.finish()
}

// ============================================================================
// ENCODER PATH COVERAGE
// ============================================================================

mod encode_coverage {
    use super::*;

    // --- Basic Encoding ---

    #[test]
    fn encode_rgb_basic() {
        let img = generate_gradient_d(64, 64, 3);
        let config = EncoderConfig::ycbcr(90.0, ChromaSubsampling::Quarter);
        let jpeg = encode_rgb(64, 64, &img.pixels, &config).expect("encode failed");
        assert!(jpeg.len() > 100);
        verify_jpeg_structure(&jpeg);
    }

    #[test]
    fn encode_grayscale() {
        let img = generate_gradient_h(64, 64, 1);
        let config = EncoderConfig::grayscale(90.0);
        let jpeg = encode_gray(64, 64, &img.pixels, &config).expect("encode failed");
        verify_jpeg_structure(&jpeg);
    }

    #[test]
    fn encode_rgba_format() {
        let mut img = TestImage::new(32, 32, 4);
        for y in 0..32 {
            for x in 0..32 {
                img.set_pixel(x, y, 0, (x * 8) as u8);
                img.set_pixel(x, y, 1, (y * 8) as u8);
                img.set_pixel(x, y, 2, 128);
                img.set_pixel(x, y, 3, 255); // Alpha
            }
        }
        let config = EncoderConfig::ycbcr(90.0, ChromaSubsampling::Quarter);
        let jpeg = super::encode_rgba(32, 32, &img.pixels, &config).expect("encode failed");
        verify_jpeg_structure(&jpeg);
    }

    // --- Quality Levels ---

    #[test]
    fn encode_quality_range() {
        let img = generate_gradient_d(64, 64, 3);
        // Test quality boundaries and key points
        for q in [1.0, 10.0, 30.0, 50.0, 70.0, 85.0, 90.0, 95.0, 99.0, 100.0] {
            let config = EncoderConfig::ycbcr(q, ChromaSubsampling::Quarter);
            let jpeg = encode_rgb(64, 64, &img.pixels, &config)
                .unwrap_or_else(|_| panic!("Q{} failed", q));
            assert!(jpeg.len() > 50, "Q{} too small", q);
        }
    }

    #[test]
    fn encode_distance_quality() {
        let img = generate_gradient_d(64, 64, 3);
        // Test distance-based quality (butteraugli distance)
        for d in [0.1, 0.5, 1.0, 2.0, 4.0, 8.0] {
            let config =
                EncoderConfig::ycbcr(Quality::ApproxButteraugli(d), ChromaSubsampling::Quarter);
            let jpeg = encode_rgb(64, 64, &img.pixels, &config)
                .unwrap_or_else(|_| panic!("dist {} failed", d));
            assert!(jpeg.len() > 50);
        }
    }

    // --- Subsampling Modes ---

    #[test]
    fn encode_subsampling_444() {
        let img = generate_gradient_d(128, 128, 3);
        let config = EncoderConfig::ycbcr(90.0, ChromaSubsampling::None);
        let jpeg = encode_rgb(128, 128, &img.pixels, &config).expect("444 failed");
        verify_jpeg_structure(&jpeg);
    }

    #[test]
    fn encode_subsampling_422() {
        let img = generate_gradient_d(128, 128, 3);
        let config = EncoderConfig::ycbcr(90.0, ChromaSubsampling::HalfHorizontal);
        let jpeg = encode_rgb(128, 128, &img.pixels, &config).expect("422 failed");
        verify_jpeg_structure(&jpeg);
    }

    #[test]
    fn encode_subsampling_420() {
        let img = generate_gradient_d(128, 128, 3);
        let config = EncoderConfig::ycbcr(90.0, ChromaSubsampling::Quarter);
        let jpeg = encode_rgb(128, 128, &img.pixels, &config).expect("420 failed");
        verify_jpeg_structure(&jpeg);
    }

    #[test]
    fn encode_subsampling_440() {
        let img = generate_gradient_d(128, 128, 3);
        let config = EncoderConfig::ycbcr(90.0, ChromaSubsampling::HalfVertical);
        let jpeg = encode_rgb(128, 128, &img.pixels, &config).expect("440 failed");
        verify_jpeg_structure(&jpeg);
    }

    // --- JPEG Modes ---

    #[test]
    fn encode_baseline_mode() {
        let img = generate_gradient_d(128, 128, 3);
        let config = EncoderConfig::ycbcr(90.0, ChromaSubsampling::Quarter).progressive(false);
        let jpeg = encode_rgb(128, 128, &img.pixels, &config).expect("baseline failed");

        // Verify SOF0 marker (baseline)
        assert!(
            jpeg.windows(2).any(|w| w == [0xFF, 0xC0]),
            "Missing SOF0 for baseline"
        );
    }

    #[test]
    fn encode_progressive_mode() {
        let img = generate_gradient_d(128, 128, 3);
        let config = EncoderConfig::ycbcr(90.0, ChromaSubsampling::Quarter).progressive(true);
        let jpeg = encode_rgb(128, 128, &img.pixels, &config).expect("progressive failed");

        // Verify SOF2 marker (progressive)
        assert!(
            jpeg.windows(2).any(|w| w == [0xFF, 0xC2]),
            "Missing SOF2 for progressive"
        );
    }

    // --- Huffman Options ---

    #[test]
    fn encode_optimized_huffman() {
        let img = generate_gradient_d(256, 256, 3);
        let config_opt = EncoderConfig::ycbcr(90.0, ChromaSubsampling::Quarter);
        let jpeg_opt = encode_rgb(256, 256, &img.pixels, &config_opt).expect("optimized failed");

        let config_fixed = EncoderConfig::ycbcr(90.0, ChromaSubsampling::Quarter);
        let jpeg_fixed = encode_rgb(256, 256, &img.pixels, &config_fixed).expect("fixed failed");

        // Optimized should generally be smaller or similar
        assert!(jpeg_opt.len() <= jpeg_fixed.len() + 500);
    }

    // --- XYB Mode ---

    #[test]
    fn encode_xyb_mode() {
        let img = generate_gradient_d(64, 64, 3);
        let config = EncoderConfig::xyb(90.0, XybSubsampling::BQuarter);
        let jpeg = encode_rgb(64, 64, &img.pixels, &config).expect("XYB failed");
        verify_jpeg_structure(&jpeg);

        // XYB should have APP14 Adobe marker
        assert!(
            jpeg.windows(2).any(|w| w == [0xFF, 0xEE]),
            "Missing APP14 for XYB"
        );
    }

    #[test]
    fn encode_ycbcr_mode() {
        let img = generate_gradient_d(64, 64, 3);
        let config = EncoderConfig::ycbcr(90.0, ChromaSubsampling::None);
        let jpeg = encode_rgb(64, 64, &img.pixels, &config).expect("YCbCr failed");
        verify_jpeg_structure(&jpeg);
    }

    // --- Image Sizes ---

    #[test]
    fn encode_minimum_size() {
        let img = TestImage::from_pixels(1, 1, 3, vec![128, 64, 192]);
        let config = EncoderConfig::ycbcr(90.0, ChromaSubsampling::Quarter);
        let jpeg = encode_rgb(1, 1, &img.pixels, &config).expect("1x1 failed");
        verify_jpeg_structure(&jpeg);
    }

    #[test]
    fn encode_non_block_aligned() {
        // Sizes that don't align to 8x8 MCU boundaries
        for (w, h) in [(7, 7), (9, 9), (15, 17), (33, 31), (100, 101)] {
            let img = generate_gradient_d(w, h, 3);
            let config = EncoderConfig::ycbcr(90.0, ChromaSubsampling::Quarter);
            let jpeg = encode_rgb(w, h, &img.pixels, &config)
                .unwrap_or_else(|_| panic!("{}x{} failed", w, h));
            verify_jpeg_structure(&jpeg);
        }
    }

    #[test]
    fn encode_non_square() {
        // Wide
        let wide = generate_gradient_h(256, 64, 3);
        let config = EncoderConfig::ycbcr(90.0, ChromaSubsampling::Quarter);
        let jpeg = encode_rgb(256, 64, &wide.pixels, &config).expect("wide failed");
        verify_jpeg_structure(&jpeg);

        // Tall
        let tall = generate_gradient_v(64, 256, 3);
        let jpeg = encode_rgb(64, 256, &tall.pixels, &config).expect("tall failed");
        verify_jpeg_structure(&jpeg);
    }

    #[test]
    fn encode_large_image() {
        let img = generate_gradient_d(1024, 768, 3);
        let config = EncoderConfig::ycbcr(85.0, ChromaSubsampling::Quarter);
        let jpeg = encode_rgb(1024, 768, &img.pixels, &config).expect("large failed");
        // Gradients compress very well - 7KB is reasonable for Q85
        assert!(
            jpeg.len() > 5000,
            "Large image too small: {} bytes",
            jpeg.len()
        );
    }

    // --- Content Types ---

    #[test]
    fn encode_solid_colors() {
        let colors = [
            (0, 0, 0),
            (255, 255, 255),
            (255, 0, 0),
            (0, 255, 0),
            (0, 0, 255),
            (128, 128, 128),
        ];
        let config = EncoderConfig::ycbcr(90.0, ChromaSubsampling::Quarter);
        for (r, g, b) in colors {
            let img = generate_solid_rgb(64, 64, r, g, b);
            let jpeg = encode_rgb(64, 64, &img.pixels, &config).expect("solid failed");
            verify_jpeg_structure(&jpeg);
        }
    }

    #[test]
    fn encode_checkerboard() {
        let img = generate_checkerboard(128, 128, 8, 3);
        let config = EncoderConfig::ycbcr(90.0, ChromaSubsampling::Quarter);
        let jpeg = encode_rgb(128, 128, &img.pixels, &config).expect("checkerboard failed");
        verify_jpeg_structure(&jpeg);
    }

    #[test]
    fn encode_color_bars() {
        let img = generate_color_bars(128, 64);
        let config = EncoderConfig::ycbcr(90.0, ChromaSubsampling::Quarter);
        let jpeg = encode_rgb(128, 64, &img.pixels, &config).expect("color bars failed");
        verify_jpeg_structure(&jpeg);
    }

    #[test]
    fn encode_noise() {
        let img = generate_noise(128, 128, 12345, 3);
        let config = EncoderConfig::ycbcr(90.0, ChromaSubsampling::Quarter);
        let jpeg = encode_rgb(128, 128, &img.pixels, &config).expect("noise failed");
        verify_jpeg_structure(&jpeg);
    }

    // --- EncoderConfig Builder ---

    #[test]
    fn encode_full_config() {
        let img = generate_gradient_d(128, 128, 3);
        let config = EncoderConfig::ycbcr(90.0, ChromaSubsampling::None).progressive(false);
        let jpeg = encode_rgb(128, 128, &img.pixels, &config).expect("full config failed");
        verify_jpeg_structure(&jpeg);
    }

    // --- Error Handling ---

    #[test]
    fn encode_wrong_buffer_size() {
        // Buffer too small
        let config = EncoderConfig::ycbcr(90.0, ChromaSubsampling::Quarter);
        let mut enc = config
            .encode_from_bytes(64, 64, PixelLayout::Rgb8Srgb)
            .unwrap();
        let result = enc.push_packed(&[0u8; 100], enough::Unstoppable);
        assert!(result.is_err());
    }

    #[test]
    fn encode_zero_dimensions() {
        let config = EncoderConfig::ycbcr(90.0, ChromaSubsampling::Quarter);
        let result = config.encode_from_bytes(0, 64, PixelLayout::Rgb8Srgb);
        assert!(result.is_err());

        let result = config.encode_from_bytes(64, 0, PixelLayout::Rgb8Srgb);
        assert!(result.is_err());
    }

    fn verify_jpeg_structure(jpeg: &[u8]) {
        assert!(jpeg.len() >= 4, "JPEG too small");
        assert_eq!(&jpeg[0..2], &[0xFF, 0xD8], "Missing SOI");
        assert_eq!(&jpeg[jpeg.len() - 2..], &[0xFF, 0xD9], "Missing EOI");
    }
}

// ============================================================================
// DECODER PATH COVERAGE
// ============================================================================

mod decode_coverage {
    use super::*;

    fn create_test_jpeg(width: u32, height: u32, quality: f32) -> Vec<u8> {
        let img = generate_gradient_d(width, height, 3);
        let config = EncoderConfig::ycbcr(quality, ChromaSubsampling::Quarter);
        encode_rgb(width, height, &img.pixels, &config).expect("encode failed")
    }

    fn create_grayscale_jpeg(width: u32, height: u32) -> Vec<u8> {
        let img = generate_gradient_h(width, height, 1);
        let config = EncoderConfig::grayscale(90.0);
        encode_gray(width, height, &img.pixels, &config).expect("encode failed")
    }

    fn create_progressive_jpeg(width: u32, height: u32) -> Vec<u8> {
        let img = generate_gradient_d(width, height, 3);
        let config = EncoderConfig::ycbcr(90.0, ChromaSubsampling::Quarter).progressive(true);
        encode_rgb(width, height, &img.pixels, &config).expect("encode failed")
    }

    fn create_subsampled_jpeg(width: u32, height: u32, subsampling: ChromaSubsampling) -> Vec<u8> {
        let img = generate_gradient_d(width, height, 3);
        let config = EncoderConfig::ycbcr(90.0, subsampling);
        encode_rgb(width, height, &img.pixels, &config).expect("encode failed")
    }

    // --- Basic Decoding ---

    #[test]
    fn decode_basic() {
        let jpeg = create_test_jpeg(128, 128, 90.0);
        let decoder = Decoder::new();
        let decoded = decoder.decode(&jpeg).expect("decode failed");

        assert_eq!(decoded.width, 128);
        assert_eq!(decoded.height, 128);
        assert_eq!(decoded.format, PixelFormat::Rgb);
        assert_eq!(decoded.data.len(), 128 * 128 * 3);
    }

    #[test]
    fn decode_grayscale() {
        let jpeg = create_grayscale_jpeg(64, 64);
        let decoder = Decoder::new();
        let decoded = decoder.decode(&jpeg).expect("decode failed");

        assert_eq!(decoded.width, 64);
        assert_eq!(decoded.height, 64);
    }

    // --- Various Quality Levels ---

    #[test]
    fn decode_quality_levels() {
        for q in [10.0, 30.0, 50.0, 70.0, 90.0, 100.0] {
            let jpeg = create_test_jpeg(64, 64, q);
            let decoder = Decoder::new();
            let decoded = decoder
                .decode(&jpeg)
                .unwrap_or_else(|_| panic!("Q{} decode failed", q));
            assert_eq!(decoded.width, 64);
        }
    }

    // --- Various Sizes ---

    #[test]
    fn decode_various_sizes() {
        let sizes = [(8, 8), (16, 16), (17, 17), (64, 64), (100, 100), (256, 256)];
        for (w, h) in sizes {
            let jpeg = create_test_jpeg(w, h, 90.0);
            let decoder = Decoder::new();
            let decoded = decoder
                .decode(&jpeg)
                .unwrap_or_else(|_| panic!("{}x{} failed", w, h));
            assert_eq!(decoded.width, w);
            assert_eq!(decoded.height, h);
        }
    }

    #[test]
    fn decode_non_square() {
        // Wide
        let jpeg = create_test_jpeg(256, 64, 90.0);
        let decoder = Decoder::new();
        let decoded = decoder.decode(&jpeg).expect("wide decode failed");
        assert_eq!(decoded.width, 256);
        assert_eq!(decoded.height, 64);

        // Tall
        let jpeg = create_test_jpeg(64, 256, 90.0);
        let decoded = decoder.decode(&jpeg).expect("tall decode failed");
        assert_eq!(decoded.width, 64);
        assert_eq!(decoded.height, 256);
    }

    // --- Progressive Decoding ---

    #[test]
    fn decode_progressive() {
        let jpeg = create_progressive_jpeg(128, 128);
        let decoder = Decoder::new();
        let decoded = decoder.decode(&jpeg).expect("progressive decode failed");
        assert_eq!(decoded.width, 128);
        assert_eq!(decoded.height, 128);
    }

    // --- Subsampling Variants ---

    #[test]
    fn decode_subsampling_444() {
        let jpeg = create_subsampled_jpeg(128, 128, ChromaSubsampling::None);
        let decoder = Decoder::new();
        let decoded = decoder.decode(&jpeg).expect("444 decode failed");
        assert_eq!(decoded.width, 128);
    }

    #[test]
    fn decode_subsampling_422() {
        let jpeg = create_subsampled_jpeg(128, 128, ChromaSubsampling::HalfHorizontal);
        let decoder = Decoder::new();
        let decoded = decoder.decode(&jpeg).expect("422 decode failed");
        assert_eq!(decoded.width, 128);
    }

    #[test]
    fn decode_subsampling_420() {
        let jpeg = create_subsampled_jpeg(128, 128, ChromaSubsampling::Quarter);
        let decoder = Decoder::new();
        let decoded = decoder.decode(&jpeg).expect("420 decode failed");
        assert_eq!(decoded.width, 128);
    }

    #[test]
    fn decode_subsampling_440() {
        let jpeg = create_subsampled_jpeg(128, 128, ChromaSubsampling::HalfVertical);
        let decoder = Decoder::new();
        let decoded = decoder.decode(&jpeg).expect("440 decode failed");
        assert_eq!(decoded.width, 128);
    }

    // --- XYB Mode ---

    #[test]
    fn decode_xyb() {
        let img = generate_gradient_d(64, 64, 3);
        let config = EncoderConfig::xyb(90.0, XybSubsampling::BQuarter);
        let jpeg = encode_rgb(64, 64, &img.pixels, &config).expect("XYB encode failed");

        let decoder = Decoder::new();
        let decoded = decoder.decode(&jpeg).expect("XYB decode failed");
        assert_eq!(decoded.width, 64);
        assert_eq!(decoded.height, 64);
    }

    // --- DecoderConfig Options ---

    #[test]
    fn decode_with_config() {
        let jpeg = create_test_jpeg(128, 128, 90.0);

        let config = DecoderConfig {
            output_format: Some(PixelFormat::Rgb),
            fancy_upsampling: true,
            block_smoothing: true,
            apply_icc: false,
            max_pixels: 1000000,
            max_memory: 100 * 1024 * 1024,
            ..Default::default()
        };

        let decoder = Decoder::from_config(config);
        let decoded = decoder.decode(&jpeg).expect("config decode failed");
        assert_eq!(decoded.width, 128);
    }

    // --- Decoder Reuse ---

    #[test]
    fn decode_reuse() {
        let decoder = Decoder::new();
        for i in 0..5 {
            let size = 64 + i * 16;
            let jpeg = create_test_jpeg(size, size, 85.0);
            let decoded = decoder
                .decode(&jpeg)
                .unwrap_or_else(|_| panic!("reuse {} failed", i));
            assert_eq!(decoded.width, size);
        }
    }

    // --- Deterministic Decoding ---

    #[test]
    fn decode_deterministic() {
        let jpeg = create_test_jpeg(128, 128, 90.0);
        let decoder = Decoder::new();

        let decoded1 = decoder.decode(&jpeg).expect("decode 1 failed");
        let decoded2 = decoder.decode(&jpeg).expect("decode 2 failed");

        assert_eq!(decoded1.data, decoded2.data);
    }

    // --- Edge Cases ---

    #[test]
    fn decode_1x1() {
        let img = TestImage::from_pixels(1, 1, 3, vec![100, 150, 200]);
        let config = EncoderConfig::ycbcr(90.0, ChromaSubsampling::Quarter);
        let jpeg = encode_rgb(1, 1, &img.pixels, &config).expect("1x1 encode failed");

        let decoder = Decoder::new();
        let decoded = decoder.decode(&jpeg).expect("1x1 decode failed");
        assert_eq!(decoded.width, 1);
        assert_eq!(decoded.height, 1);
    }

    #[test]
    fn decode_8x8_mcu() {
        let jpeg = create_test_jpeg(8, 8, 90.0);
        let decoder = Decoder::new();
        let decoded = decoder.decode(&jpeg).expect("8x8 decode failed");
        assert_eq!(decoded.width, 8);
        assert_eq!(decoded.height, 8);
    }

    #[test]
    fn decode_large_image() {
        let jpeg = create_test_jpeg(1024, 768, 85.0);
        let decoder = Decoder::new();
        let decoded = decoder.decode(&jpeg).expect("large decode failed");
        assert_eq!(decoded.width, 1024);
        assert_eq!(decoded.height, 768);
    }

    // --- Error Handling ---

    #[test]
    fn decode_empty_input() {
        let decoder = Decoder::new();
        assert!(decoder.decode(&[]).is_err());
    }

    #[test]
    fn decode_too_small() {
        let decoder = Decoder::new();
        assert!(decoder.decode(&[0xFF]).is_err());
        assert!(decoder.decode(&[0xFF, 0xD8]).is_err());
    }

    #[test]
    fn decode_missing_soi() {
        let decoder = Decoder::new();
        let bad = vec![0xFF, 0xE0, 0x00, 0x10];
        assert!(decoder.decode(&bad).is_err());
    }

    #[test]
    fn decode_garbage() {
        let decoder = Decoder::new();
        let garbage: Vec<u8> = (0..1000).map(|i| (i * 7) as u8).collect();
        assert!(decoder.decode(&garbage).is_err());
    }

    #[test]
    fn decode_truncated() {
        let jpeg = create_test_jpeg(64, 64, 90.0);
        let truncated: Vec<u8> = jpeg[..jpeg.len() / 2].to_vec();

        let decoder = Decoder::new();
        // May succeed or fail depending on truncation point
        let _ = decoder.decode(&truncated);
    }

    // --- Pixel Value Validation ---

    #[test]
    fn decode_pixel_range() {
        let mut img = TestImage::new(64, 64, 3);
        for y in 0..64 {
            for x in 0..64 {
                img.set_pixel(x, y, 0, (x * 4) as u8);
                img.set_pixel(x, y, 1, (y * 4) as u8);
                img.set_pixel(x, y, 2, ((x + y) * 2) as u8);
            }
        }

        let config = EncoderConfig::ycbcr(100.0, ChromaSubsampling::Quarter);
        let jpeg = encode_rgb(64, 64, &img.pixels, &config).expect("encode failed");

        let decoder = Decoder::new();
        let decoded = decoder.decode(&jpeg).expect("decode failed");

        // Ensure we got actual pixel data
        assert!(!decoded.data.is_empty(), "Decoded data should not be empty");
    }
}

// ============================================================================
// ROUNDTRIP COVERAGE
// ============================================================================

mod roundtrip_coverage {
    use super::*;

    fn roundtrip_test(width: u32, height: u32, quality: f32) -> (Vec<u8>, Vec<u8>) {
        let img = generate_gradient_d(width, height, 3);
        let config = EncoderConfig::ycbcr(quality, ChromaSubsampling::Quarter);
        let jpeg = encode_rgb(width, height, &img.pixels, &config).expect("encode failed");

        let decoded = Decoder::new().decode(&jpeg).expect("decode failed");
        (img.pixels, decoded.data)
    }

    #[test]
    fn roundtrip_q100() {
        let (original, decoded) = roundtrip_test(64, 64, 100.0);
        // Q100 should be nearly lossless
        let max_diff = original
            .iter()
            .zip(decoded.iter())
            .map(|(a, b)| (*a as i32 - *b as i32).abs())
            .max()
            .unwrap_or(0);
        assert!(max_diff < 5, "Q100 max diff {} too high", max_diff);
    }

    #[test]
    fn roundtrip_all_subsampling() {
        for subsampling in [
            ChromaSubsampling::None,
            ChromaSubsampling::HalfHorizontal,
            ChromaSubsampling::Quarter,
            ChromaSubsampling::HalfVertical,
        ] {
            let img = generate_gradient_d(128, 128, 3);
            let config = EncoderConfig::ycbcr(90.0, subsampling);
            let jpeg = encode_rgb(128, 128, &img.pixels, &config).expect("encode failed");

            let decoded = Decoder::new().decode(&jpeg).expect("decode failed");
            assert_eq!(decoded.width, 128);
            assert_eq!(decoded.height, 128);
        }
    }

    #[test]
    fn roundtrip_progressive() {
        let img = generate_gradient_d(128, 128, 3);
        let config = EncoderConfig::ycbcr(90.0, ChromaSubsampling::Quarter).progressive(true);
        let jpeg = encode_rgb(128, 128, &img.pixels, &config).expect("progressive encode failed");

        let decoded = Decoder::new()
            .decode(&jpeg)
            .expect("progressive decode failed");
        assert_eq!(decoded.width, 128);
        assert_eq!(decoded.height, 128);
    }

    #[test]
    fn roundtrip_xyb() {
        let img = generate_gradient_d(64, 64, 3);
        let config = EncoderConfig::xyb(90.0, XybSubsampling::BQuarter);
        let jpeg = encode_rgb(64, 64, &img.pixels, &config).expect("XYB encode failed");

        let decoded = Decoder::new().decode(&jpeg).expect("XYB decode failed");
        assert_eq!(decoded.width, 64);
        assert_eq!(decoded.height, 64);
    }

    #[test]
    fn roundtrip_grayscale() {
        let img = generate_gradient_h(64, 64, 1);
        let config = EncoderConfig::grayscale(90.0);
        let jpeg = encode_gray(64, 64, &img.pixels, &config).expect("gray encode failed");

        let decoded = Decoder::new().decode(&jpeg).expect("gray decode failed");
        assert_eq!(decoded.width, 64);
        assert_eq!(decoded.height, 64);
    }

    #[test]
    fn roundtrip_content_types() {
        let config = EncoderConfig::ycbcr(90.0, ChromaSubsampling::Quarter);
        let patterns = [
            ("solid", generate_solid(64, 64, 128, 3)),
            ("checkerboard", generate_checkerboard(64, 64, 8, 3)),
            ("noise", generate_noise(64, 64, 42, 3)),
            ("gradient_h", generate_gradient_h(64, 64, 3)),
            ("gradient_v", generate_gradient_v(64, 64, 3)),
            ("gradient_d", generate_gradient_d(64, 64, 3)),
        ];

        for (name, img) in patterns {
            let jpeg = encode_rgb(64, 64, &img.pixels, &config)
                .unwrap_or_else(|_| panic!("{} encode failed", name));

            let decoded = Decoder::new()
                .decode(&jpeg)
                .unwrap_or_else(|_| panic!("{} decode failed", name));

            assert_eq!(decoded.width, 64, "{} width mismatch", name);
            assert_eq!(decoded.height, 64, "{} height mismatch", name);
        }
    }
}

// ============================================================================
// QUALITY API COVERAGE
// ============================================================================

mod quality_coverage {
    use super::*;

    #[test]
    fn quality_from_quality() {
        for q in [0.0, 25.0, 50.0, 75.0, 100.0] {
            let quality = Quality::ApproxJpegli(q);
            // Just verify it doesn't panic
            let _ = quality;
        }
    }

    #[test]
    fn quality_from_distance() {
        for d in [0.0, 0.5, 1.0, 2.0, 5.0, 10.0] {
            let quality = Quality::ApproxButteraugli(d);
            let _ = quality;
        }
    }

    #[test]
    fn quality_to_distance() {
        let q = Quality::ApproxJpegli(90.0);
        let d = q.to_distance();
        assert!(d > 0.0, "Distance should be positive");
    }

    #[test]
    fn quality_roundtrip() {
        // Higher quality -> lower distance
        let q90 = Quality::ApproxJpegli(90.0);
        let q50 = Quality::ApproxJpegli(50.0);
        assert!(
            q90.to_distance() < q50.to_distance(),
            "Q90 should have lower distance than Q50"
        );
    }
}

// ============================================================================
// ERROR TYPE COVERAGE
// ============================================================================

mod encoder_error_coverage {
    use jpegli::encoder::Error;

    #[test]
    fn encoder_error_display() {
        let errors: Vec<Error> = vec![
            Error::invalid_dimensions(0, 100, "width cannot be zero"),
            Error::invalid_quality(-1.0, "0-100"),
            Error::invalid_color_format("unsupported format"),
            Error::invalid_buffer_size(1000, 100),
            Error::unsupported_feature("arithmetic coding"),
            Error::internal("unexpected state"),
            Error::io_error("disk full".to_string()),
            Error::icc_error("invalid profile".to_string()),
            Error::invalid_scan_script("overlapping scans".to_string()),
            Error::allocation_failed(1_000_000_000, "allocating DCT blocks"),
            Error::size_overflow("computing buffer size"),
            Error::image_too_large(200_000_000, 100_000_000),
            Error::too_many_rows(100, 200),
        ];

        for err in errors {
            let display = format!("{}", err);
            assert!(!display.is_empty(), "Display should not be empty");
            let debug = format!("{:?}", err);
            assert!(!debug.is_empty(), "Debug should not be empty");
        }
    }

    #[test]
    fn encoder_error_equality() {
        let err1 = Error::invalid_dimensions(0, 0, "zero dimensions");
        let err2 = Error::invalid_dimensions(0, 0, "zero dimensions");
        assert_eq!(err1, err2);
    }

    #[test]
    fn encoder_error_clone() {
        let err = Error::internal("test error");
        let cloned = err.clone();
        assert_eq!(err, cloned);
    }
}

mod decoder_error_coverage {
    use jpegli::decoder::Error;

    #[test]
    fn decoder_error_display() {
        let errors: Vec<Error> = vec![
            Error::invalid_jpeg_data("not a valid JPEG"),
            Error::truncated_data("reading header"),
            Error::invalid_marker(0xFF, "parsing markers"),
            Error::invalid_huffman_table(0, "invalid code lengths"),
            Error::invalid_quant_table(0, "zero values"),
            Error::unsupported_feature("arithmetic coding"),
            Error::internal("unexpected state"),
            Error::io_error("disk full".to_string()),
            Error::icc_error("invalid profile".to_string()),
            Error::decode_error("truncated data".to_string()),
            Error::allocation_failed(1_000_000_000, "allocating DCT blocks"),
            Error::size_overflow("computing buffer size"),
            Error::image_too_large(200_000_000, 100_000_000),
            Error::too_many_scans(200, 100),
        ];

        for err in errors {
            let display = format!("{}", err);
            assert!(!display.is_empty(), "Display should not be empty");
            let debug = format!("{:?}", err);
            assert!(!debug.is_empty(), "Debug should not be empty");
        }
    }

    #[test]
    fn decoder_error_equality() {
        let err1 = Error::invalid_jpeg_data("truncated");
        let err2 = Error::invalid_jpeg_data("truncated");
        assert_eq!(err1, err2);
    }

    #[test]
    fn decoder_error_clone() {
        let err = Error::invalid_jpeg_data("test error");
        let cloned = err.clone();
        assert_eq!(err, cloned);
    }
}