1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
//! Project context for source file ownership.
//!
//! Determines whether a DWARF file path belongs to the user's crate or workspace
//! by checking if it falls under one of the project's source directories.
//! All DWARF paths are made absolute (via `comp_dir` prepending) at creation time,
//! so matching is done by absolute path prefix.
use std::fs;
use std::path::Path;
/// Absolute source directory prefixes for a project.
///
/// A file is "ours" if and only if its absolute path starts with a known
/// source directory prefix derived from the project's `Cargo.toml`.
#[derive(Debug, Default)]
pub struct ProjectContext {
/// Absolute path prefixes for source directories (e.g., "/Users/me/project/src/")
source_prefixes: Vec<String>,
/// Absolute path to the project root directory
project_root: String,
}
impl ProjectContext {
/// Build source directory prefixes from the project root.
///
/// Uses `cargo_toml::Manifest::complete_from_path_and_workspace` to discover
/// target source paths (bin, lib), then extracts their
/// parent directories as source prefixes. This handles custom layouts like
/// `[[bin]] path = "crates/core/main.rs"` automatically.
pub fn from_project_root(project_root: &Path) -> Result<Self, String> {
let mut source_prefixes = Vec::new();
// Canonicalize to get an absolute path for reliable matching
let project_root = fs::canonicalize(project_root).unwrap_or(project_root.to_path_buf());
let project_root = project_root.as_path();
let cargo_toml = project_root.join("Cargo.toml");
let content = fs::read_to_string(&cargo_toml)
.map_err(|e| format!("Cannot read {}: {}", cargo_toml.display(), e))?;
let manifest = cargo_toml::Manifest::from_slice(content.as_bytes())
.map_err(|e| format!("Cannot parse {}: {}", cargo_toml.display(), e))?;
// Process workspace members
if let Some(workspace) = &manifest.workspace {
for member_pattern in &workspace.members {
let member_paths =
crate::cargo::expand_workspace_members(project_root, member_pattern);
for member_path in member_paths {
Self::collect_source_dirs_from_manifest(&member_path, &mut source_prefixes);
}
}
}
// Process the root package (single crate or workspace root with its own package)
if manifest.package.is_some() {
Self::collect_source_dirs_from_manifest(project_root, &mut source_prefixes);
}
if source_prefixes.is_empty() {
return Err(format!(
"No source targets found in {}",
cargo_toml.display()
));
}
// Deduplicate prefixes
source_prefixes.sort();
source_prefixes.dedup();
Ok(Self {
source_prefixes,
project_root: project_root
.to_str()
.ok_or("Project root path contains invalid UTF-8")?
.to_string(),
})
}
/// Collect source directories from a crate's Cargo.toml bin and lib targets.
///
/// Uses `complete_from_path_and_workspace` to resolve default target paths
/// (e.g., `src/main.rs`, `src/lib.rs`), then extracts parent directories.
/// Silently skips unreadable/unparseable manifests (workspace members may
/// not all be present).
fn collect_source_dirs_from_manifest(crate_root: &Path, prefixes: &mut Vec<String>) {
let cargo_toml = crate_root.join("Cargo.toml");
let Ok(content) = fs::read_to_string(&cargo_toml) else {
return;
};
let Ok(mut manifest) = cargo_toml::Manifest::from_slice(content.as_bytes()) else {
return;
};
// complete_from_path_and_workspace populates default paths for targets
// (e.g., bin[].path = "src/main.rs" if src/main.rs exists)
let _ = manifest.complete_from_path_and_workspace::<toml::Value>(
&cargo_toml,
None::<(&cargo_toml::Manifest<toml::Value>, &Path)>,
);
// Collect source directories from lib and bin target paths
prefixes.extend(
manifest
.lib
.iter()
.chain(manifest.bin.iter())
.filter_map(|t| t.path.as_deref())
.filter_map(|p| Path::new(p).parent())
.filter_map(|parent| {
let prefix = crate_root
.join(parent)
.to_str()?
.trim_end_matches('/')
.to_string();
Some(format!("{}/", prefix))
}),
);
}
/// Check if a DWARF file path belongs to this project's source code.
///
/// Handles both absolute and relative paths:
/// - Absolute paths: check if they start with a known source prefix
/// - Relative paths: check if any source prefix contains matching path components
/// (handles cases where DWARF comp_dir is missing or invalid)
pub fn is_crate_source(&self, file_path: &str) -> bool {
if file_path.starts_with('/') {
// Absolute path - standard prefix check
self.source_prefixes
.iter()
.any(|prefix| file_path.starts_with(prefix.as_str()))
} else {
// Relative path - check if it matches components in any source prefix
// E.g., "examples/staticlib/src/lib.rs" should match ".../examples/staticlib/src/"
self.source_prefixes.iter().any(|prefix| {
// Check if the full relative path is contained in the prefix
prefix.contains(file_path)
// Or check if the prefix ends with the parent directory of the file
|| {
if let Some((parent_dir, _)) = file_path.rsplit_once('/') {
prefix.trim_end_matches('/').ends_with(parent_dir)
} else {
false
}
}
})
}
}
/// Get the absolute path to the project root.
pub fn project_root(&self) -> &str {
&self.project_root
}
/// Get the source prefixes (for debugging).
pub fn source_prefixes(&self) -> &[String] {
&self.source_prefixes
}
}
#[cfg(test)]
mod tests {
use super::*;
#[test]
fn test_absolute_path_matching() {
let ctx = ProjectContext {
source_prefixes: vec!["/Users/me/project/src/".to_string()],
project_root: "/Users/me/project".to_string(),
};
assert!(ctx.is_crate_source("/Users/me/project/src/main.rs"));
assert!(ctx.is_crate_source("/Users/me/project/src/module/mod.rs"));
assert!(!ctx.is_crate_source(
"/Users/me/.cargo/registry/src/index.crates.io-abc/metal-0.32.0/src/device.rs"
));
assert!(!ctx.is_crate_source(
"/Users/me/.cargo/registry/src/index.crates.io-abc/wgpu-hal-27.0.4/src/metal/device.rs"
));
assert!(!ctx.is_crate_source("/Users/me/other_project/src/main.rs"));
}
#[test]
fn test_workspace() {
let ctx = ProjectContext {
source_prefixes: vec![
"/Users/me/workspace/crate_a/src/".to_string(),
"/Users/me/workspace/crate_b/src/".to_string(),
],
project_root: "/Users/me/workspace".to_string(),
};
assert!(ctx.is_crate_source("/Users/me/workspace/crate_a/src/lib.rs"));
assert!(ctx.is_crate_source("/Users/me/workspace/crate_b/src/main.rs"));
assert!(!ctx.is_crate_source("/Users/me/workspace/crate_c/src/lib.rs"));
}
#[test]
fn test_dependency_with_same_relative_path() {
let ctx = ProjectContext {
source_prefixes: vec!["/Users/me/meshchat/src/".to_string()],
project_root: "/Users/me/meshchat".to_string(),
};
assert!(ctx.is_crate_source("/Users/me/meshchat/src/device.rs"));
assert!(!ctx.is_crate_source(
"/Users/me/.cargo/registry/src/index.crates.io-abc/metal-0.32.0/src/device.rs"
));
}
#[test]
fn test_absolute_path_from_comp_dir() {
let ctx = ProjectContext {
source_prefixes: vec!["/Users/me/meshchat/src/".to_string()],
project_root: "/Users/me/meshchat".to_string(),
};
let metal_device_rs =
"/Users/me/.cargo/registry/src/index.crates.io-abc/metal-0.32.0/src/device.rs";
assert!(!ctx.is_crate_source(metal_device_rs));
assert!(ctx.is_crate_source("/Users/me/meshchat/src/device.rs"));
}
// Additional test for NEW logic in simplify_heuristics branch
#[test]
fn test_from_project_root_with_jonesy_project() {
// Test using the actual jonesy project root
let project_root = Path::new(env!("CARGO_MANIFEST_DIR"));
let ctx = ProjectContext::from_project_root(project_root)
.expect("Should create context for jonesy project");
// Should have at least one source prefix
assert!(!ctx.source_prefixes.is_empty());
// Should correctly identify jonesy's own source files
// Build the absolute path to a known file
let src_lib = project_root.join("src/lib.rs");
if let Some(src_lib_str) = src_lib.to_str() {
assert!(
ctx.is_crate_source(src_lib_str),
"Expected {} to be recognized as crate source",
src_lib_str
);
}
// Should NOT recognize random absolute paths as the crate source
assert!(!ctx.is_crate_source("/tmp/random_file.rs"));
assert!(!ctx.is_crate_source(
"/Users/someone/.cargo/registry/src/index.crates.io-abc/serde-1.0.0/src/lib.rs"
));
}
}