jjpr 0.14.0

Manage stacked pull requests in Jujutsu repositories
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
use anyhow::{Context, Result};

use super::http::ForgeClient;
use super::types::{
    ChecksStatus, IssueComment, MergeMethod, PrMergeability, PrState, PullRequest,
    PullRequestRef, ReviewSummary,
};
use super::Forge;

/// GitLab implementation using direct HTTP via `ForgeClient`.
pub struct GitLabForge {
    client: ForgeClient,
}

impl GitLabForge {
    pub fn new(client: ForgeClient) -> Self {
        Self { client }
    }

    /// URL-encode the project path for GitLab API endpoints.
    /// GitLab uses `projects/{encoded_path}/...` where the path is `owner/repo`
    /// (or `group/subgroup/repo` for nested namespaces).
    fn encode_project(owner: &str, repo: &str) -> String {
        format!("{owner}/{repo}").replace('/', "%2F")
    }
}

/// Parse a single GitLab MR JSON value into our `PullRequest` type.
fn parse_mr(mr: &serde_json::Value) -> Result<PullRequest> {
    let iid = mr["iid"]
        .as_u64()
        .ok_or_else(|| anyhow::anyhow!("MR missing iid"))?;

    let source_project_id = mr["source_project_id"].as_u64().unwrap_or(0);
    let target_project_id = mr["target_project_id"].as_u64().unwrap_or(0);

    // Normalize fork detection into the head.label format build_pr_map expects.
    // Same-project MRs get an empty label (passes filter).
    // Cross-project MRs get "namespace:branch" to be filtered out.
    let head_label = if source_project_id != target_project_id && source_project_id != 0 {
        let source_ns = mr["source_namespace"]["path"]
            .as_str()
            .or_else(|| mr["source_namespace"]["full_path"].as_str())
            .unwrap_or("fork");
        let source_branch = mr["source_branch"].as_str().unwrap_or("");
        format!("{source_ns}:{source_branch}")
    } else {
        String::new()
    };

    Ok(PullRequest {
        number: iid,
        html_url: mr["web_url"].as_str().unwrap_or("").to_string(),
        title: mr["title"].as_str().unwrap_or("").to_string(),
        body: mr["description"].as_str().map(|s| s.to_string()),
        base: PullRequestRef {
            ref_name: mr["target_branch"].as_str().unwrap_or("").to_string(),
            label: String::new(),
            sha: mr["diff_refs"]["base_sha"].as_str().unwrap_or("").to_string(),
        },
        head: PullRequestRef {
            ref_name: mr["source_branch"].as_str().unwrap_or("").to_string(),
            label: head_label,
            sha: mr["sha"].as_str().unwrap_or("").to_string(),
        },
        draft: mr["draft"].as_bool().unwrap_or(false),
        node_id: String::new(),
        merged_at: mr["merged_at"].as_str().map(|s| s.to_string()),
        requested_reviewers: mr["reviewers"]
            .as_array()
            .map(|arr| {
                arr.iter()
                    .filter_map(|r| r["username"].as_str().map(|s| s.to_string()))
                    .collect()
            })
            .unwrap_or_default(),
    })
}

/// Parse a GitLab note JSON value into our `IssueComment` type.
fn parse_note(note: &serde_json::Value) -> Option<IssueComment> {
    // Skip system-generated notes (status change messages, etc.)
    if note["system"].as_bool().unwrap_or(false) {
        return None;
    }
    let id = note["id"].as_u64()?;
    let body = note["body"].as_str().map(|s| s.to_string());
    Some(IssueComment { id, body })
}

/// Map a GitLab pipeline status string to `ChecksStatus`.
fn parse_pipeline_status(pipeline: Option<&serde_json::Value>) -> ChecksStatus {
    let Some(latest) = pipeline else {
        return ChecksStatus::None;
    };
    match latest["status"].as_str().unwrap_or("unknown") {
        "success" => ChecksStatus::Pass,
        "failed" | "canceled" => ChecksStatus::Fail,
        "created" | "waiting_for_resource" | "preparing" | "pending" | "running"
        | "manual" | "scheduled" => ChecksStatus::Pending,
        _ => ChecksStatus::Pending,
    }
}

/// Parse a GitLab MR's `detailed_merge_status` into `PrMergeability`.
fn parse_mergeability(mr: &serde_json::Value) -> PrMergeability {
    let detailed_status = mr["detailed_merge_status"]
        .as_str()
        .unwrap_or("unknown");

    let mergeable = match detailed_status {
        "mergeable" => Some(true),
        "checking" | "unchecked" | "preparing" => None,
        _ => Some(false),
    };

    PrMergeability {
        mergeable,
        mergeable_state: detailed_status.to_string(),
    }
}

impl Forge for GitLabForge {
    fn list_open_prs(&self, owner: &str, repo: &str) -> Result<Vec<PullRequest>> {
        let project = Self::encode_project(owner, repo);
        let path = format!("projects/{project}/merge_requests?state=opened&per_page=100");
        let items = self.client.get_paginated(&path)?;
        items.iter().map(parse_mr).collect()
    }

    fn create_pr(
        &self,
        owner: &str,
        repo: &str,
        title: &str,
        body: &str,
        head: &str,
        base: &str,
        draft: bool,
    ) -> Result<PullRequest> {
        let project = Self::encode_project(owner, repo);
        let path = format!("projects/{project}/merge_requests");
        let mut json_body = serde_json::json!({
            "title": title,
            "source_branch": head,
            "target_branch": base,
            "description": body,
        });
        if draft {
            json_body["draft"] = serde_json::json!(true);
        }
        let output = self.client.post(&path, &json_body)?;
        parse_mr(&output)
    }

    fn update_pr_base(
        &self,
        owner: &str,
        repo: &str,
        number: u64,
        base: &str,
    ) -> Result<()> {
        let project = Self::encode_project(owner, repo);
        let path = format!("projects/{project}/merge_requests/{number}");
        self.client.put(&path, &serde_json::json!({ "target_branch": base }))?;
        Ok(())
    }

    fn request_reviewers(
        &self,
        owner: &str,
        repo: &str,
        number: u64,
        reviewers: &[String],
    ) -> Result<()> {
        if reviewers.is_empty() {
            return Ok(());
        }

        let project = Self::encode_project(owner, repo);

        // Batch lookup: fetch all project members in one paginated call
        // instead of N individual user lookups.
        let members_path = format!("projects/{project}/members/all?per_page=100");
        let members = self.client.get_paginated(&members_path)?;
        let member_map: std::collections::HashMap<&str, u64> = members
            .iter()
            .filter_map(|m| {
                let username = m["username"].as_str()?;
                let id = m["id"].as_u64()?;
                Some((username, id))
            })
            .collect();

        let mut reviewer_ids = Vec::new();
        for username in reviewers {
            if let Some(&id) = member_map.get(username.as_str()) {
                reviewer_ids.push(id);
            } else {
                // Fallback for non-member reviewers (e.g., invited external users)
                let encoded_user = super::http::url_encode(username);
                let output = self.client.get(&format!("users?username={encoded_user}"))?;
                let users: Vec<serde_json::Value> = serde_json::from_value(output)
                    .context("failed to parse user lookup response")?;
                let user_id = users
                    .first()
                    .and_then(|u| u["id"].as_u64())
                    .ok_or_else(|| anyhow::anyhow!("user '{username}' not found on GitLab"))?;
                reviewer_ids.push(user_id);
            }
        }

        let path = format!("projects/{project}/merge_requests/{number}");
        self.client.put(&path, &serde_json::json!({ "reviewer_ids": reviewer_ids }))?;
        Ok(())
    }

    fn list_comments(
        &self,
        owner: &str,
        repo: &str,
        number: u64,
    ) -> Result<Vec<IssueComment>> {
        let project = Self::encode_project(owner, repo);
        let path = format!("projects/{project}/merge_requests/{number}/notes?per_page=100");
        let items = self.client.get_paginated(&path)?;
        Ok(items.iter().filter_map(parse_note).collect())
    }

    fn create_comment(
        &self,
        owner: &str,
        repo: &str,
        number: u64,
        body: &str,
    ) -> Result<IssueComment> {
        let project = Self::encode_project(owner, repo);
        let path = format!("projects/{project}/merge_requests/{number}/notes");
        let output = self.client.post(&path, &serde_json::json!({ "body": body }))?;
        let id = output["id"]
            .as_u64()
            .ok_or_else(|| anyhow::anyhow!("created note missing id"))?;
        Ok(IssueComment {
            id,
            body: output["body"].as_str().map(|s| s.to_string()),
        })
    }

    fn update_comment(
        &self,
        owner: &str,
        repo: &str,
        comment_id: u64,
        body: &str,
    ) -> Result<()> {
        // GitLab's note update API requires the MR iid in the path:
        //   PUT /projects/:id/merge_requests/:iid/notes/:note_id
        // but the Forge trait only passes comment_id. We scan MRs (all states)
        // to find which one owns this note. In practice stacks are small (2-5 MRs).
        let project = Self::encode_project(owner, repo);
        let mrs_path = format!("projects/{project}/merge_requests?state=all&per_page=100");
        let mrs = self.client.get_paginated(&mrs_path)?;

        for mr in &mrs {
            let iid = mr["iid"].as_u64().unwrap_or(0);
            if iid == 0 {
                continue;
            }
            let note_path =
                format!("projects/{project}/merge_requests/{iid}/notes/{comment_id}");
            let result = self.client.put(
                &note_path,
                &serde_json::json!({ "body": body }),
            );
            if result.is_ok() {
                return Ok(());
            }
        }

        anyhow::bail!("could not find note {comment_id} on any MR in project")
    }

    fn update_pr_body(
        &self,
        owner: &str,
        repo: &str,
        number: u64,
        body: &str,
    ) -> Result<()> {
        let project = Self::encode_project(owner, repo);
        let path = format!("projects/{project}/merge_requests/{number}");
        self.client.put(&path, &serde_json::json!({ "description": body }))?;
        Ok(())
    }

    fn mark_pr_ready(
        &self,
        owner: &str,
        repo: &str,
        number: u64,
    ) -> Result<()> {
        let project = Self::encode_project(owner, repo);
        let path = format!("projects/{project}/merge_requests/{number}");
        self.client.put(&path, &serde_json::json!({ "draft": false }))?;
        Ok(())
    }

    fn get_authenticated_user(&self) -> Result<String> {
        let output = self.client.get("user")?;
        output["username"]
            .as_str()
            .map(|s| s.to_string())
            .ok_or_else(|| anyhow::anyhow!("user response missing username field"))
    }

    fn find_merged_pr(
        &self,
        owner: &str,
        repo: &str,
        head: &str,
    ) -> Result<Option<PullRequest>> {
        let project = Self::encode_project(owner, repo);
        let encoded_head = super::http::url_encode(head);
        let path =
            format!("projects/{project}/merge_requests?source_branch={encoded_head}&state=merged");
        let output = self.client.get(&path)?;
        let mrs: Vec<serde_json::Value> = serde_json::from_value(output)
            .context("failed to parse merged MR list response")?;
        mrs.first().map(parse_mr).transpose()
    }

    fn merge_pr(
        &self,
        owner: &str,
        repo: &str,
        number: u64,
        method: MergeMethod,
    ) -> Result<()> {
        let project = Self::encode_project(owner, repo);
        let merge_path = format!("projects/{project}/merge_requests/{number}/merge");
        match method {
            MergeMethod::Squash => {
                self.client.put(&merge_path, &serde_json::json!({ "squash": true }))?;
            }
            MergeMethod::Merge => {
                self.client.put(&merge_path, &serde_json::json!({ "squash": false }))?;
            }
            MergeMethod::Rebase => {
                // Rebase the MR onto the target branch first, then merge (fast-forward).
                let rebase_path = format!("projects/{project}/merge_requests/{number}/rebase");
                self.client.put(&rebase_path, &serde_json::json!({}))?;
                self.client.put(&merge_path, &serde_json::json!({ "squash": false }))?;
            }
        }
        Ok(())
    }

    fn get_pr_checks_status(
        &self,
        owner: &str,
        repo: &str,
        head_ref: &str,
    ) -> Result<ChecksStatus> {
        let project = Self::encode_project(owner, repo);
        let path = format!(
            "projects/{project}/pipelines?ref={head_ref}&per_page=1&order_by=id&sort=desc"
        );
        let output = self.client.get(&path)?;
        let pipelines: Vec<serde_json::Value> = serde_json::from_value(output)
            .context("failed to parse pipelines response")?;

        Ok(parse_pipeline_status(pipelines.first()))
    }

    fn get_pr_reviews(
        &self,
        owner: &str,
        repo: &str,
        number: u64,
    ) -> Result<ReviewSummary> {
        let project = Self::encode_project(owner, repo);

        // 1. Approval count from the approvals endpoint
        let approvals_path = format!("projects/{project}/merge_requests/{number}/approvals");
        let approvals = self.client.get(&approvals_path)?;
        let approved_count = approvals["approved_by"]
            .as_array()
            .map(|a| a.len() as u32)
            .unwrap_or(0);

        // 2. Check detailed_merge_status on the MR itself
        let mr_path = format!("projects/{project}/merge_requests/{number}");
        let mr = self.client.get(&mr_path)?;
        let merge_status_blocked = mr["detailed_merge_status"]
            .as_str()
            .is_some_and(|s| s == "requested_changes");

        // 3. Check individual reviewer states (GitLab 16.3+).
        //    Degrades gracefully on older instances that lack this endpoint.
        let reviewer_changes_requested = self
            .client
            .get(&format!(
                "projects/{project}/merge_requests/{number}/reviewers"
            ))
            .ok()
            .and_then(|v| v.as_array().cloned())
            .unwrap_or_default()
            .iter()
            .any(|r| {
                r["state"]
                    .as_str()
                    .is_some_and(|s| s == "requested_changes")
            });

        Ok(ReviewSummary {
            approved_count,
            changes_requested: merge_status_blocked || reviewer_changes_requested,
        })
    }

    fn get_pr_state(
        &self,
        owner: &str,
        repo: &str,
        number: u64,
    ) -> Result<PrState> {
        let project = Self::encode_project(owner, repo);
        let path = format!("projects/{project}/merge_requests/{number}");
        let mr = self.client.get(&path)?;
        Ok(PrState {
            merged: mr["state"].as_str() == Some("merged"),
            state: mr["state"].as_str().unwrap_or("unknown").to_string(),
        })
    }

    fn get_pr_mergeability(
        &self,
        owner: &str,
        repo: &str,
        number: u64,
    ) -> Result<PrMergeability> {
        let project = Self::encode_project(owner, repo);
        let path = format!("projects/{project}/merge_requests/{number}");
        let mr = self.client.get(&path)?;

        Ok(parse_mergeability(&mr))
    }
}

#[cfg(test)]
mod tests {
    use super::*;

    // --- JSON fixture tests: verify parsing without any HTTP ---

    const GITLAB_MR_RESPONSE: &str = r#"{
        "iid": 42,
        "web_url": "https://gitlab.com/mygroup/myproject/-/merge_requests/42",
        "title": "Add authentication",
        "description": "Implements basic auth flow",
        "target_branch": "main",
        "source_branch": "auth",
        "draft": false,
        "merged_at": null,
        "source_project_id": 123,
        "target_project_id": 123
    }"#;

    const GITLAB_DRAFT_MR: &str = r#"{
        "iid": 7,
        "web_url": "https://gitlab.com/o/r/-/merge_requests/7",
        "title": "WIP: Draft feature",
        "description": null,
        "target_branch": "develop",
        "source_branch": "draft-feature",
        "draft": true,
        "merged_at": null,
        "source_project_id": 10,
        "target_project_id": 10
    }"#;

    const GITLAB_MERGED_MR: &str = r#"{
        "iid": 99,
        "web_url": "https://gitlab.com/o/r/-/merge_requests/99",
        "title": "Already merged",
        "description": "This was merged",
        "target_branch": "main",
        "source_branch": "old-feature",
        "draft": false,
        "merged_at": "2024-06-15T10:30:00Z",
        "source_project_id": 5,
        "target_project_id": 5
    }"#;

    const GITLAB_FORK_MR: &str = r#"{
        "iid": 15,
        "web_url": "https://gitlab.com/o/r/-/merge_requests/15",
        "title": "Fork contribution",
        "description": "From a fork",
        "target_branch": "main",
        "source_branch": "feature",
        "draft": false,
        "merged_at": null,
        "source_project_id": 999,
        "target_project_id": 123,
        "source_namespace": {"path": "fork-owner"}
    }"#;

    #[test]
    fn test_parse_mr_basic_fields() {
        let mr: serde_json::Value = serde_json::from_str(GITLAB_MR_RESPONSE).unwrap();
        let pr = parse_mr(&mr).unwrap();

        assert_eq!(pr.number, 42);
        assert_eq!(
            pr.html_url,
            "https://gitlab.com/mygroup/myproject/-/merge_requests/42"
        );
        assert_eq!(pr.title, "Add authentication");
        assert_eq!(pr.body.as_deref(), Some("Implements basic auth flow"));
        assert_eq!(pr.base.ref_name, "main");
        assert_eq!(pr.head.ref_name, "auth");
        assert!(!pr.draft);
        assert!(pr.merged_at.is_none());
        assert!(pr.node_id.is_empty());
    }

    #[test]
    fn test_parse_mr_draft() {
        let mr: serde_json::Value = serde_json::from_str(GITLAB_DRAFT_MR).unwrap();
        let pr = parse_mr(&mr).unwrap();

        assert_eq!(pr.number, 7);
        assert!(pr.draft);
        assert!(pr.body.is_none());
        assert_eq!(pr.base.ref_name, "develop");
    }

    #[test]
    fn test_parse_mr_merged() {
        let mr: serde_json::Value = serde_json::from_str(GITLAB_MERGED_MR).unwrap();
        let pr = parse_mr(&mr).unwrap();

        assert_eq!(pr.number, 99);
        assert_eq!(pr.merged_at.as_deref(), Some("2024-06-15T10:30:00Z"));
    }

    #[test]
    fn test_parse_mr_same_project_empty_label() {
        let mr: serde_json::Value = serde_json::from_str(GITLAB_MR_RESPONSE).unwrap();
        let pr = parse_mr(&mr).unwrap();

        // Same-project MRs should have empty head.label (passes build_pr_map filter)
        assert!(pr.head.label.is_empty());
    }

    #[test]
    fn test_parse_mr_fork_gets_label() {
        let mr: serde_json::Value = serde_json::from_str(GITLAB_FORK_MR).unwrap();
        let pr = parse_mr(&mr).unwrap();

        // Fork MRs should get a label so build_pr_map filters them out
        assert_eq!(pr.head.label, "fork-owner:feature");
    }

    #[test]
    fn test_parse_note_user_comment() {
        let note: serde_json::Value = serde_json::from_str(
            r#"{
                "id": 301,
                "body": "Looks good to me!",
                "system": false,
                "author": {"username": "reviewer"}
            }"#,
        )
        .unwrap();
        let comment = parse_note(&note).unwrap();
        assert_eq!(comment.id, 301);
        assert_eq!(comment.body.as_deref(), Some("Looks good to me!"));
    }

    #[test]
    fn test_parse_note_system_note_filtered() {
        let note: serde_json::Value = serde_json::from_str(
            r#"{
                "id": 302,
                "body": "marked as draft",
                "system": true
            }"#,
        )
        .unwrap();
        assert!(parse_note(&note).is_none());
    }

    #[test]
    fn test_parse_note_stack_comment() {
        let note: serde_json::Value = serde_json::from_str(
            r#"{
                "id": 500,
                "body": "<!-- jjpr:stack-info -->\nStack comment content",
                "system": false
            }"#,
        )
        .unwrap();
        let comment = parse_note(&note).unwrap();
        assert_eq!(comment.id, 500);
        assert!(comment
            .body
            .as_deref()
            .unwrap()
            .contains("<!-- jjpr:stack-info -->"));
    }

    #[test]
    fn test_parse_mr_list() {
        let json = format!("[{GITLAB_MR_RESPONSE}, {GITLAB_DRAFT_MR}]");
        let mrs: Vec<serde_json::Value> = serde_json::from_str(&json).unwrap();
        let prs: Vec<PullRequest> = mrs.iter().map(|m| parse_mr(m).unwrap()).collect();

        assert_eq!(prs.len(), 2);
        assert_eq!(prs[0].number, 42);
        assert_eq!(prs[1].number, 7);
    }

    #[test]
    fn test_encode_project_simple() {
        assert_eq!(GitLabForge::encode_project("owner", "repo"), "owner%2Frepo");
    }

    #[test]
    fn test_encode_project_nested_groups() {
        assert_eq!(
            GitLabForge::encode_project("group/subgroup", "repo"),
            "group%2Fsubgroup%2Frepo"
        );
    }

    #[test]
    fn test_pipeline_status_mapping() {
        let cases = vec![
            ("success", ChecksStatus::Pass),
            ("failed", ChecksStatus::Fail),
            ("canceled", ChecksStatus::Fail),
            ("running", ChecksStatus::Pending),
            ("pending", ChecksStatus::Pending),
            ("created", ChecksStatus::Pending),
            ("manual", ChecksStatus::Pending),
        ];

        for (status, expected) in cases {
            let pipeline = serde_json::json!({"status": status});
            let result = parse_pipeline_status(Some(&pipeline));
            assert_eq!(result, expected, "status '{status}' should map correctly");
        }
    }

    #[test]
    fn test_pipeline_status_none_when_empty() {
        assert_eq!(parse_pipeline_status(None), ChecksStatus::None);
    }

    #[test]
    fn test_mergeability_status_mapping() {
        let cases: Vec<(&str, Option<bool>)> = vec![
            ("mergeable", Some(true)),
            ("checking", None),
            ("unchecked", None),
            ("preparing", None),
            ("conflict", Some(false)),
            ("ci_must_pass", Some(false)),
            ("not_approved", Some(false)),
            ("draft_status", Some(false)),
        ];

        for (status, expected) in cases {
            let mr = serde_json::json!({"detailed_merge_status": status});
            let result = parse_mergeability(&mr);
            assert_eq!(
                result.mergeable, expected,
                "detailed_merge_status '{status}' should map correctly"
            );
            assert_eq!(result.mergeable_state, status);
        }
    }

    #[test]
    fn test_mergeability_missing_field() {
        let mr = serde_json::json!({});
        let result = parse_mergeability(&mr);
        assert_eq!(result.mergeable, Some(false));
        assert_eq!(result.mergeable_state, "unknown");
    }

    #[test]
    fn test_approvals_parsing() {
        let approvals_json = r#"{
            "approved_by": [
                {"user": {"id": 1, "username": "alice"}},
                {"user": {"id": 2, "username": "bob"}}
            ]
        }"#;
        let approvals: serde_json::Value = serde_json::from_str(approvals_json).unwrap();
        let count = approvals["approved_by"]
            .as_array()
            .map(|a| a.len() as u32)
            .unwrap_or(0);
        assert_eq!(count, 2);
    }

    #[test]
    fn test_approvals_parsing_empty() {
        let approvals_json = r#"{"approved_by": []}"#;
        let approvals: serde_json::Value = serde_json::from_str(approvals_json).unwrap();
        let count = approvals["approved_by"]
            .as_array()
            .map(|a| a.len() as u32)
            .unwrap_or(0);
        assert_eq!(count, 0);
    }

    #[test]
    fn test_reviewer_state_requested_changes() {
        let reviewers = serde_json::json!([
            {"username": "alice", "state": "approved"},
            {"username": "bob", "state": "requested_changes"}
        ]);
        let has_changes = reviewers
            .as_array()
            .unwrap()
            .iter()
            .any(|r| r["state"].as_str().is_some_and(|s| s == "requested_changes"));
        assert!(has_changes);
    }

    #[test]
    fn test_reviewer_state_all_approved() {
        let reviewers = serde_json::json!([
            {"username": "alice", "state": "approved"},
            {"username": "bob", "state": "approved"}
        ]);
        let has_changes = reviewers
            .as_array()
            .unwrap()
            .iter()
            .any(|r| r["state"].as_str().is_some_and(|s| s == "requested_changes"));
        assert!(!has_changes);
    }

    #[test]
    fn test_parse_mr_extracts_reviewers() {
        let mr: serde_json::Value = serde_json::from_str(
            r#"{
                "iid": 42,
                "web_url": "https://gitlab.com/o/r/-/merge_requests/42",
                "title": "Auth",
                "description": null,
                "target_branch": "main",
                "source_branch": "auth",
                "draft": false,
                "merged_at": null,
                "source_project_id": 1,
                "target_project_id": 1,
                "reviewers": [
                    {"username": "alice", "id": 10},
                    {"username": "bob", "id": 20}
                ]
            }"#,
        )
        .unwrap();
        let pr = parse_mr(&mr).unwrap();
        assert_eq!(pr.requested_reviewers, vec!["alice", "bob"]);
    }

    #[test]
    fn test_parse_mr_no_reviewers() {
        let mr: serde_json::Value = serde_json::from_str(GITLAB_MR_RESPONSE).unwrap();
        let pr = parse_mr(&mr).unwrap();
        assert!(pr.requested_reviewers.is_empty());
    }

    #[test]
    fn test_reviewer_state_empty_degrades() {
        let reviewers: Vec<serde_json::Value> = vec![];
        let has_changes = reviewers
            .iter()
            .any(|r| r["state"].as_str().is_some_and(|s| s == "requested_changes"));
        assert!(!has_changes);
    }
}