jjj 0.4.1

Distributed project management and code review for Jujutsu
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
mod test_helpers;

use test_helpers::{jj_available, run_jjj, run_jjj_success, setup_test_repo};

#[test]
fn test_solution_new_creates_solution() {
    if !jj_available() {
        return;
    }
    let dir = setup_test_repo();

    run_jjj_success(&dir, &["problem", "new", "Test Problem"]);
    let stdout = run_jjj_success(
        &dir,
        &[
            "solution",
            "new",
            "Test Solution",
            "--problem",
            "Test Problem",
        ],
    );

    assert!(
        stdout.contains("Test Solution"),
        "Expected title in output: {}",
        stdout
    );
}

#[test]
fn test_solution_new_links_to_problem() {
    if !jj_available() {
        return;
    }
    let dir = setup_test_repo();

    run_jjj_success(&dir, &["problem", "new", "Linked Problem"]);
    run_jjj_success(
        &dir,
        &[
            "solution",
            "new",
            "Linked Solution",
            "--problem",
            "Linked Problem",
        ],
    );

    let stdout = run_jjj_success(&dir, &["solution", "show", "Linked Solution"]);
    // Output shows "Addresses:" field with the problem UUID
    assert!(
        stdout.contains("Linked Problem") || stdout.contains("Addresses:"),
        "Expected problem link in solution: {}",
        stdout
    );
}

#[test]
fn test_solution_new_auto_attaches_change() {
    if !jj_available() {
        return;
    }
    let dir = setup_test_repo();

    run_jjj_success(&dir, &["problem", "new", "Problem"]);
    run_jjj_success(
        &dir,
        &["solution", "new", "Solution", "--problem", "Problem"],
    );

    let stdout = run_jjj_success(&dir, &["solution", "show", "Solution"]);
    // Solution new auto-attaches but stays Proposed; solution review advances to Review
    assert!(
        stdout.contains("Changes") || stdout.contains("Review") || stdout.contains("review"),
        "Expected change attached: {}",
        stdout
    );
}

#[test]
fn test_solution_list_shows_all() {
    if !jj_available() {
        return;
    }
    let dir = setup_test_repo();

    run_jjj_success(&dir, &["problem", "new", "Problem 1"]);
    run_jjj_success(&dir, &["problem", "new", "Problem 2"]);
    run_jjj_success(
        &dir,
        &["solution", "new", "Solution 1", "--problem", "Problem 1"],
    );
    run_jjj_success(
        &dir,
        &["solution", "new", "Solution 2", "--problem", "Problem 2"],
    );

    let stdout = run_jjj_success(&dir, &["solution", "list"]);
    assert!(
        stdout.contains("Solution 1"),
        "Expected Solution 1: {}",
        stdout
    );
    assert!(
        stdout.contains("Solution 2"),
        "Expected Solution 2: {}",
        stdout
    );
}

#[test]
fn test_solution_list_filter_by_problem() {
    if !jj_available() {
        return;
    }
    let dir = setup_test_repo();

    run_jjj_success(&dir, &["problem", "new", "Problem 1"]);
    run_jjj_success(&dir, &["problem", "new", "Problem 2"]);
    run_jjj_success(
        &dir,
        &[
            "solution",
            "new",
            "Solution for P1",
            "--problem",
            "Problem 1",
        ],
    );
    run_jjj_success(
        &dir,
        &[
            "solution",
            "new",
            "Solution for P2",
            "--problem",
            "Problem 2",
        ],
    );

    let stdout = run_jjj_success(&dir, &["solution", "list", "--problem", "Problem 1"]);
    assert!(
        stdout.contains("Solution for P1"),
        "Expected P1 solution: {}",
        stdout
    );
    assert!(
        !stdout.contains("Solution for P2"),
        "Should not contain P2 solution: {}",
        stdout
    );
}

#[test]
fn test_solution_list_filter_by_status() {
    if !jj_available() {
        return;
    }
    let dir = setup_test_repo();

    run_jjj_success(&dir, &["problem", "new", "Problem"]);
    run_jjj_success(
        &dir,
        &[
            "solution",
            "new",
            "Testing Solution",
            "--problem",
            "Problem",
        ],
    );
    run_jjj_success(
        &dir,
        &[
            "solution",
            "new",
            "Accepted Solution",
            "--problem",
            "Problem",
        ],
    );
    run_jjj_success(&dir, &["solution", "submit", "Accepted Solution"]);
    run_jjj_success(&dir, &["solution", "approve", "Accepted Solution"]);

    let stdout = run_jjj_success(&dir, &["solution", "list", "--status", "approved"]);
    assert!(
        stdout.contains("Accepted Solution")
            || stdout.contains("Approved Solution")
            || stdout.contains("Accepted Solution"),
        "Expected accepted solution: {}",
        stdout
    );
    assert!(
        !stdout.contains("Testing Solution"),
        "Should not contain testing solution: {}",
        stdout
    );
}

#[test]
fn test_solution_list_json_output() {
    if !jj_available() {
        return;
    }
    let dir = setup_test_repo();

    run_jjj_success(&dir, &["problem", "new", "Problem"]);
    run_jjj_success(
        &dir,
        &["solution", "new", "JSON Solution", "--problem", "Problem"],
    );

    let stdout = run_jjj_success(&dir, &["solution", "list", "--json"]);
    let json: serde_json::Value = serde_json::from_str(&stdout).expect("Failed to parse JSON");
    assert!(json.is_array());
    let arr = json.as_array().unwrap();
    assert_eq!(arr.len(), 1);
    // ID should exist but we don't assert specific value
    assert!(arr[0]["id"].is_string(), "Expected id to be a string");
    assert_eq!(arr[0]["title"], "JSON Solution");
}

#[test]
fn test_solution_show_details() {
    if !jj_available() {
        return;
    }
    let dir = setup_test_repo();

    run_jjj_success(&dir, &["problem", "new", "Problem"]);
    run_jjj_success(
        &dir,
        &[
            "solution",
            "new",
            "Detailed Solution",
            "--problem",
            "Problem",
        ],
    );

    let stdout = run_jjj_success(&dir, &["solution", "show", "Detailed Solution"]);
    assert!(
        stdout.contains("Detailed Solution"),
        "Expected title: {}",
        stdout
    );
    // Output shows "Addresses:" field with the problem UUID
    assert!(
        stdout.contains("Addresses:") || stdout.contains("Problem"),
        "Expected problem reference: {}",
        stdout
    );
    assert!(
        stdout.contains("Status") || stdout.contains("testing") || stdout.contains("Testing"),
        "Expected status: {}",
        stdout
    );
}

#[test]
fn test_solution_show_json_output() {
    if !jj_available() {
        return;
    }
    let dir = setup_test_repo();

    run_jjj_success(&dir, &["problem", "new", "Problem"]);
    run_jjj_success(
        &dir,
        &["solution", "new", "JSON Show", "--problem", "Problem"],
    );

    let stdout = run_jjj_success(&dir, &["solution", "show", "JSON Show", "--json"]);
    let json: serde_json::Value = serde_json::from_str(&stdout).expect("Failed to parse JSON");
    // ID should exist but we don't assert specific value
    assert!(json["id"].is_string(), "Expected id to be a string");
    assert_eq!(json["title"], "JSON Show");
    assert!(
        json["problem_id"].is_string(),
        "Expected problem_id to be a string"
    );
}

#[test]
fn test_solution_submit() {
    if !jj_available() {
        return;
    }
    let dir = setup_test_repo();

    run_jjj_success(&dir, &["problem", "new", "Problem"]);
    run_jjj_success(
        &dir,
        &["solution", "new", "Submittable", "--problem", "Problem"],
    );
    run_jjj_success(&dir, &["solution", "submit", "Submittable"]);

    let stdout = run_jjj_success(&dir, &["solution", "approve", "Submittable"]);
    assert!(
        stdout.contains("approved"),
        "Expected accepted confirmation: {}",
        stdout
    );

    let show = run_jjj_success(&dir, &["solution", "show", "Submittable"]);
    assert!(
        show.contains("Approved") || show.contains("approved"),
        "Expected accepted status: {}",
        show
    );
}

#[test]
fn test_solution_submit_blocked_by_critiques() {
    if !jj_available() {
        return;
    }
    let dir = setup_test_repo();

    run_jjj_success(&dir, &["problem", "new", "Problem"]);
    run_jjj_success(
        &dir,
        &[
            "solution",
            "new",
            "Blocked Solution",
            "--problem",
            "Problem",
        ],
    );
    run_jjj_success(&dir, &["solution", "submit", "Blocked Solution"]);
    run_jjj_success(&dir, &["critique", "new", "Blocked Solution", "Major flaw"]);

    let output = run_jjj(&dir, &["solution", "approve", "Blocked Solution"]);
    assert!(
        !output.status.success(),
        "Submit should fail with open critiques"
    );
    let stderr = String::from_utf8_lossy(&output.stderr);
    assert!(
        stderr.contains("critique") || stderr.contains("open"),
        "Expected critique blocking message: {}",
        stderr
    );
}

#[test]
fn test_solution_submit_force() {
    if !jj_available() {
        return;
    }
    let dir = setup_test_repo();

    run_jjj_success(&dir, &["problem", "new", "Problem"]);
    run_jjj_success(
        &dir,
        &["solution", "new", "Force Submit", "--problem", "Problem"],
    );
    run_jjj_success(&dir, &["solution", "submit", "Force Submit"]);
    run_jjj_success(&dir, &["critique", "new", "Force Submit", "Minor issue"]);

    let stdout = run_jjj_success(&dir, &["solution", "approve", "Force Submit", "--force"]);
    assert!(
        stdout.contains("approved"),
        "Expected force-accepted confirmation: {}",
        stdout
    );
}

#[test]
fn test_solution_refute() {
    if !jj_available() {
        return;
    }
    let dir = setup_test_repo();

    run_jjj_success(&dir, &["problem", "new", "Problem"]);
    run_jjj_success(
        &dir,
        &["solution", "new", "Bad Solution", "--problem", "Problem"],
    );

    let stdout = run_jjj_success(&dir, &["solution", "withdraw", "Bad Solution"]);
    assert!(
        stdout.contains("withdrawn"),
        "Expected withdrawn confirmation: {}",
        stdout
    );

    let show = run_jjj_success(&dir, &["solution", "show", "Bad Solution"]);
    assert!(
        show.contains("Withdrawn") || show.contains("withdrawn"),
        "Expected withdrawn status: {}",
        show
    );
}

#[test]
fn test_solution_supersedes() {
    if !jj_available() {
        return;
    }
    let dir = setup_test_repo();

    run_jjj_success(&dir, &["problem", "new", "Problem"]);
    run_jjj_success(
        &dir,
        &[
            "solution",
            "new",
            "Original Solution",
            "--problem",
            "Problem",
        ],
    );
    run_jjj_success(&dir, &["solution", "withdraw", "Original Solution"]);
    run_jjj_success(
        &dir,
        &[
            "solution",
            "new",
            "Better Solution",
            "--problem",
            "Problem",
            "--supersedes",
            "Original Solution",
        ],
    );

    let stdout = run_jjj_success(&dir, &["solution", "show", "Better Solution"]);
    assert!(
        stdout.contains("Supersedes") || stdout.contains("Original Solution"),
        "Expected supersedes reference: {}",
        stdout
    );
}

#[test]
fn test_solution_test_status() {
    if !jj_available() {
        return;
    }
    let dir = setup_test_repo();

    run_jjj_success(&dir, &["problem", "new", "Problem"]);
    run_jjj_success(
        &dir,
        &["solution", "new", "Test Status", "--problem", "Problem"],
    );

    // solution new auto-attaches but stays in Proposed; explicit review advances to Review
    let show = run_jjj_success(&dir, &["solution", "show", "Test Status"]);
    assert!(
        show.contains("Proposed") || show.contains("proposed"),
        "Expected proposed status after creation: {}",
        show
    );

    run_jjj_success(&dir, &["solution", "submit", "Test Status"]);
    let show = run_jjj_success(&dir, &["solution", "show", "Test Status"]);
    assert!(
        show.contains("Submitted") || show.contains("submitted"),
        "Expected submitted status after solution submit: {}",
        show
    );
}

#[test]
fn test_solution_assign() {
    if !jj_available() {
        return;
    }
    let dir = setup_test_repo();

    run_jjj_success(&dir, &["problem", "new", "Problem"]);
    run_jjj_success(
        &dir,
        &["solution", "new", "Assigned", "--problem", "Problem"],
    );
    run_jjj_success(&dir, &["solution", "assign", "Assigned", "--to", "bob"]);

    let stdout = run_jjj_success(&dir, &["solution", "show", "Assigned"]);
    assert!(stdout.contains("bob"), "Expected assignee bob: {}", stdout);
}

#[test]
fn test_solution_edit() {
    if !jj_available() {
        return;
    }
    let dir = setup_test_repo();

    run_jjj_success(&dir, &["problem", "new", "Problem"]);
    run_jjj_success(
        &dir,
        &["solution", "new", "Original", "--problem", "Problem"],
    );
    run_jjj_success(
        &dir,
        &["solution", "edit", "Original", "--title", "Updated Title"],
    );

    let stdout = run_jjj_success(&dir, &["solution", "show", "Updated Title"]);
    assert!(
        stdout.contains("Updated Title"),
        "Expected updated title: {}",
        stdout
    );
}

#[test]
fn test_solution_with_reviewer() {
    if !jj_available() {
        return;
    }
    let dir = setup_test_repo();

    run_jjj_success(&dir, &["problem", "new", "Problem"]);
    run_jjj_success(
        &dir,
        &[
            "solution",
            "new",
            "Needs Review",
            "--problem",
            "Problem",
            "--reviewer",
            "alice",
        ],
    );

    // Should create an awaiting review critique
    let stdout = run_jjj_success(&dir, &["critique", "list", "--json"]);
    assert!(
        stdout.contains("Awaiting review from @alice"),
        "Expected awaiting review critique: {}",
        stdout
    );
}

#[test]
fn test_solution_show_nonexistent_fails() {
    if !jj_available() {
        return;
    }
    let dir = setup_test_repo();

    let output = run_jjj(&dir, &["solution", "show", "nonexistent-solution-xyz"]);
    assert!(
        !output.status.success(),
        "Expected failure for nonexistent solution"
    );
}

#[test]
fn test_solution_new_with_tags() {
    if !jj_available() {
        return;
    }
    let dir = setup_test_repo();

    run_jjj_success(&dir, &["problem", "new", "Problem"]);
    run_jjj_success(
        &dir,
        &[
            "solution",
            "new",
            "Tagged Solution",
            "--problem",
            "Problem",
            "--tags",
            "refactor,backend",
        ],
    );

    let stdout = run_jjj_success(&dir, &["solution", "show", "Tagged Solution"]);
    assert!(
        stdout.contains("Tags:") && stdout.contains("backend") && stdout.contains("refactor"),
        "Expected tags in show output: {}",
        stdout
    );
}

#[test]
fn test_solution_edit_add_remove_tag() {
    if !jj_available() {
        return;
    }
    let dir = setup_test_repo();

    run_jjj_success(&dir, &["problem", "new", "Problem"]);
    run_jjj_success(
        &dir,
        &["solution", "new", "Tag Edit Sol", "--problem", "Problem"],
    );
    run_jjj_success(
        &dir,
        &["solution", "edit", "Tag Edit Sol", "--add-tag", "refactor"],
    );

    let stdout = run_jjj_success(&dir, &["solution", "show", "Tag Edit Sol"]);
    assert!(
        stdout.contains("refactor"),
        "Expected tag refactor in output: {}",
        stdout
    );

    // Remove the tag
    run_jjj_success(
        &dir,
        &[
            "solution",
            "edit",
            "Tag Edit Sol",
            "--remove-tag",
            "refactor",
        ],
    );
    let stdout = run_jjj_success(&dir, &["solution", "show", "Tag Edit Sol"]);
    assert!(
        !stdout.contains("Tags:"),
        "Expected no tags after removal: {}",
        stdout
    );
}

#[test]
fn test_solution_edit_set_tags() {
    if !jj_available() {
        return;
    }
    let dir = setup_test_repo();

    run_jjj_success(&dir, &["problem", "new", "Problem"]);
    run_jjj_success(
        &dir,
        &[
            "solution",
            "new",
            "Set Tags Sol",
            "--problem",
            "Problem",
            "--tags",
            "old",
        ],
    );

    // Replace all tags atomically
    run_jjj_success(
        &dir,
        &[
            "solution",
            "edit",
            "Set Tags Sol",
            "--set-tags",
            "alpha,beta",
        ],
    );
    let stdout = run_jjj_success(&dir, &["solution", "show", "Set Tags Sol"]);
    assert!(
        stdout.contains("alpha") && stdout.contains("beta"),
        "Expected new tags: {}",
        stdout
    );
    assert!(
        !stdout.contains("old"),
        "Expected old tag removed: {}",
        stdout
    );

    // Clear all tags with empty --set-tags
    run_jjj_success(
        &dir,
        &["solution", "edit", "Set Tags Sol", "--set-tags", ""],
    );
    let stdout = run_jjj_success(&dir, &["solution", "show", "Set Tags Sol"]);
    assert!(
        !stdout.contains("Tags:"),
        "Expected no tags after clear: {}",
        stdout
    );
}