jj_ryu/submit/

execute.rs

//! Phase 3: Submission execution
//!
//! Executes the submission plan: push, create PRs, update bases, add comments.

use crate::error::{Error, Result};
use crate::platform::PlatformService;
use crate::repo::JjWorkspace;
use crate::submit::plan::{PrBaseUpdate, PrToCreate};
use crate::submit::{ExecutionStep, Phase, ProgressCallback, PushStatus, SubmissionPlan};
use crate::types::{Bookmark, Platform, PullRequest};
use base64::{Engine, engine::general_purpose::STANDARD as BASE64};
use serde::{Deserialize, Serialize};
use std::collections::HashMap;
use std::fmt::Write;

/// Result of submission execution
#[derive(Debug, Clone, Default)]
pub struct SubmissionResult {
    /// Whether execution succeeded
    pub success: bool,
    /// PRs that were created
    pub created_prs: Vec<PullRequest>,
    /// PRs that were updated (base changed)
    pub updated_prs: Vec<PullRequest>,
    /// Bookmarks that were pushed
    pub pushed_bookmarks: Vec<String>,
    /// Errors encountered (non-fatal)
    pub errors: Vec<String>,
}

impl SubmissionResult {
    /// Create a new successful result
    pub fn new() -> Self {
        Self {
            success: true,
            ..Default::default()
        }
    }

    /// Record a fatal error and mark as failed
    pub fn fail(&mut self, error: String) {
        self.errors.push(error);
        self.success = false;
    }

    /// Record a non-fatal error (soft fail)
    pub fn soft_fail(&mut self, error: String) {
        self.errors.push(error);
    }
}

/// Outcome of executing a single step
#[derive(Debug)]
pub enum StepOutcome {
    /// Step succeeded, optionally with a PR to track
    Success(Option<(String, PullRequest)>),
    /// Step failed fatally - stop execution
    FatalError(String),
    /// Step failed but execution should continue (soft fail)
    SoftError(String),
}

/// Stack comment data embedded in PR comments
#[derive(Debug, Clone, Serialize, Deserialize, PartialEq, Eq)]
pub struct StackCommentData {
    /// Schema version
    pub version: u8,
    /// PRs in the stack, ordered root to leaf
    pub stack: Vec<StackItem>,
    /// Base branch name (e.g., "main")
    pub base_branch: String,
}

/// A single item in the stack
#[derive(Debug, Clone, Serialize, Deserialize, PartialEq, Eq)]
pub struct StackItem {
    /// Bookmark name for this PR
    pub bookmark_name: String,
    /// URL to the PR
    pub pr_url: String,
    /// PR number
    pub pr_number: u64,
    /// PR title
    pub pr_title: String,
}

/// Prefix for stack comment data
pub const COMMENT_DATA_PREFIX: &str = "<!--- JJ-RYU_STACK: ";
const COMMENT_DATA_PREFIX_OLD: &str = "<!--- JJ-STACK_INFO: ";
/// Postfix for stack comment data
pub const COMMENT_DATA_POSTFIX: &str = " --->";
/// Marker for the current PR in stack comments
pub const STACK_COMMENT_THIS_PR: &str = "👈";

// =============================================================================
// Step Execution Functions (testable in isolation)
// =============================================================================

/// Execute a push step
pub fn execute_push(workspace: &mut JjWorkspace, bookmark: &Bookmark, remote: &str) -> StepOutcome {
    match workspace.git_push(&bookmark.name, remote) {
        Ok(()) => StepOutcome::Success(None),
        Err(e) => StepOutcome::FatalError(format!("Failed to push {}: {e}", bookmark.name)),
    }
}

/// Execute an update base step
pub async fn execute_update_base(
    platform: &dyn PlatformService,
    update: &PrBaseUpdate,
) -> StepOutcome {
    match platform
        .update_pr_base(update.pr.number, &update.expected_base)
        .await
    {
        Ok(updated_pr) => StepOutcome::Success(Some((update.bookmark.name.clone(), updated_pr))),
        Err(e) => StepOutcome::FatalError(format!(
            "Failed to update PR base for {}: {e}",
            update.bookmark.name
        )),
    }
}

/// Execute a create PR step
pub async fn execute_create_pr(platform: &dyn PlatformService, create: &PrToCreate) -> StepOutcome {
    match platform
        .create_pr_with_options(
            &create.bookmark.name,
            &create.base_branch,
            &create.title,
            create.draft,
        )
        .await
    {
        Ok(pr) => StepOutcome::Success(Some((create.bookmark.name.clone(), pr))),
        Err(e) => StepOutcome::FatalError(format!(
            "Failed to create PR for {}: {e}",
            create.bookmark.name
        )),
    }
}

/// Execute a publish PR step (soft fail on error)
pub async fn execute_publish_pr(platform: &dyn PlatformService, pr: &PullRequest) -> StepOutcome {
    match platform.publish_pr(pr.number).await {
        Ok(updated_pr) => StepOutcome::Success(Some((pr.head_ref.clone(), updated_pr))),
        Err(e) => StepOutcome::SoftError(format!("Failed to publish PR #{}: {e}", pr.number)),
    }
}

// =============================================================================
// Main Execution Orchestrator
// =============================================================================

/// Execute a submission plan
///
/// This performs the actual operations:
/// 1. Push bookmarks to remote
/// 2. Update PR bases
/// 3. Create new PRs
/// 4. Publish draft PRs
/// 5. Add/update stack comments
pub async fn execute_submission(
    plan: &SubmissionPlan,
    workspace: &mut JjWorkspace,
    platform: &dyn PlatformService,
    progress: &dyn ProgressCallback,
    dry_run: bool,
) -> Result<SubmissionResult> {
    let mut result = SubmissionResult::new();

    if dry_run {
        progress
            .on_message("Dry run - no changes will be made")
            .await;
        report_dry_run(plan, progress).await;
        return Ok(result);
    }

    // Track all PRs (existing + created) for comment generation
    let mut bookmark_to_pr: HashMap<String, PullRequest> = plan.existing_prs.clone();

    // Phase: Executing all steps
    progress.on_phase(Phase::Executing).await;

    for step in &plan.execution_steps {
        let outcome = execute_step(step, workspace, platform, &plan.remote, progress).await;

        match outcome {
            StepOutcome::Success(Some((bookmark, pr))) => {
                // Track the PR for comment generation
                match step {
                    ExecutionStep::CreatePr(_) => result.created_prs.push(pr.clone()),
                    ExecutionStep::UpdateBase(_) | ExecutionStep::PublishPr(_) => {
                        result.updated_prs.push(pr.clone());
                    }
                    ExecutionStep::Push(_) => {}
                }
                bookmark_to_pr.insert(bookmark, pr);
            }
            StepOutcome::Success(None) => {
                // Push succeeded - track it
                if let ExecutionStep::Push(bm) = step {
                    result.pushed_bookmarks.push(bm.name.clone());
                }
            }
            StepOutcome::FatalError(msg) => {
                progress.on_error(&Error::Platform(msg.clone())).await;
                result.fail(msg);
                return Ok(result);
            }
            StepOutcome::SoftError(msg) => {
                progress.on_error(&Error::Platform(msg.clone())).await;
                result.soft_fail(msg);
            }
        }
    }

    // Phase: Adding stack comments
    progress.on_phase(Phase::AddingComments).await;

    if !bookmark_to_pr.is_empty() {
        let stack_data = build_stack_comment_data(plan, &bookmark_to_pr);

        for (idx, item) in stack_data.stack.iter().enumerate() {
            if let Err(e) =
                create_or_update_stack_comment(platform, &stack_data, idx, item.pr_number).await
            {
                let msg = format!(
                    "Failed to update stack comment for {}: {e}",
                    item.bookmark_name
                );
                progress.on_error(&Error::Platform(msg.clone())).await;
                result.soft_fail(msg);
            }
        }
    }

    progress.on_phase(Phase::Complete).await;

    Ok(result)
}

/// Execute a single step with progress reporting
async fn execute_step(
    step: &ExecutionStep,
    workspace: &mut JjWorkspace,
    platform: &dyn PlatformService,
    remote: &str,
    progress: &dyn ProgressCallback,
) -> StepOutcome {
    match step {
        ExecutionStep::Push(bookmark) => {
            progress
                .on_bookmark_push(&bookmark.name, PushStatus::Started)
                .await;

            let outcome = execute_push(workspace, bookmark, remote);

            match &outcome {
                StepOutcome::Success(_) => {
                    progress
                        .on_bookmark_push(&bookmark.name, PushStatus::Success)
                        .await;
                }
                StepOutcome::FatalError(msg) | StepOutcome::SoftError(msg) => {
                    progress
                        .on_bookmark_push(&bookmark.name, PushStatus::Failed(msg.clone()))
                        .await;
                }
            }

            outcome
        }

        ExecutionStep::UpdateBase(update) => {
            progress
                .on_message(&format!(
                    "Updating {} base: {} → {}",
                    update.bookmark.name, update.current_base, update.expected_base
                ))
                .await;

            let outcome = execute_update_base(platform, update).await;

            if let StepOutcome::Success(Some((bookmark, pr))) = &outcome {
                progress.on_pr_updated(bookmark, pr).await;
            }

            outcome
        }

        ExecutionStep::CreatePr(create) => {
            let draft_str = if create.draft { " [draft]" } else { "" };
            progress
                .on_message(&format!(
                    "Creating PR for {} (base: {}){draft_str}",
                    create.bookmark.name, create.base_branch
                ))
                .await;

            let outcome = execute_create_pr(platform, create).await;

            if let StepOutcome::Success(Some((bookmark, pr))) = &outcome {
                progress.on_pr_created(bookmark, pr).await;
            }

            outcome
        }

        ExecutionStep::PublishPr(pr) => {
            progress
                .on_message(&format!("Publishing PR #{} ({})", pr.number, pr.head_ref))
                .await;

            execute_publish_pr(platform, pr).await
        }
    }
}

// =============================================================================
// Dry Run Reporting
// =============================================================================

/// Report what would be done in a dry run
async fn report_dry_run(plan: &SubmissionPlan, progress: &dyn ProgressCallback) {
    if plan.execution_steps.is_empty() {
        progress.on_message("Nothing to do - already in sync").await;
        return;
    }

    progress.on_message("Would execute:").await;
    for step in &plan.execution_steps {
        let msg = format_step_for_dry_run(step, &plan.remote);
        progress.on_message(&msg).await;
    }
}

/// Format a step for dry run output
pub fn format_step_for_dry_run(step: &ExecutionStep, remote: &str) -> String {
    match step {
        // Push needs special handling to include remote
        ExecutionStep::Push(bm) => format!("  → push {} to {}", bm.name, remote),
        // All other steps use Display impl
        _ => format!("  → {step}"),
    }
}

// =============================================================================
// Stack Comment Functions
// =============================================================================

/// Build stack comment data from the plan and PRs
#[allow(clippy::implicit_hasher)]
pub fn build_stack_comment_data(
    plan: &SubmissionPlan,
    bookmark_to_pr: &HashMap<String, PullRequest>,
) -> StackCommentData {
    let stack: Vec<StackItem> = plan
        .segments
        .iter()
        .filter_map(|seg| {
            bookmark_to_pr.get(&seg.bookmark.name).map(|pr| StackItem {
                bookmark_name: seg.bookmark.name.clone(),
                pr_url: pr.html_url.clone(),
                pr_number: pr.number,
                pr_title: pr.title.clone(),
            })
        })
        .collect();

    StackCommentData {
        version: 1,
        stack,
        base_branch: plan.default_branch.clone(),
    }
}

/// Format the stack comment body for a PR (defaults to GitHub format)
///
/// For platform-specific formatting, use internal `format_stack_comment_for_platform`.
pub fn format_stack_comment(data: &StackCommentData, current_idx: usize) -> Result<String> {
    format_stack_comment_for_platform(data, current_idx, Platform::GitHub)
}

/// Format the stack comment body for a PR with platform-specific formatting
///
/// - GitHub: Uses `#N` which auto-links to PRs
/// - GitLab: Uses `[title !N](url)` since `#N` links to issues, not MRs
fn format_stack_comment_for_platform(
    data: &StackCommentData,
    current_idx: usize,
    platform: Platform,
) -> Result<String> {
    let encoded_data = BASE64.encode(
        serde_json::to_string(data)
            .map_err(|e| Error::Internal(format!("Failed to serialize stack data: {e}")))?,
    );

    let mut body = format!("{COMMENT_DATA_PREFIX}{encoded_data}{COMMENT_DATA_POSTFIX}\n");

    // Reverse order: newest/leaf at top, oldest at bottom
    let reversed_idx = data.stack.len() - 1 - current_idx;
    for (i, item) in data.stack.iter().rev().enumerate() {
        let is_current = i == reversed_idx;
        match platform {
            Platform::GitHub => {
                // GitHub: "* #N" - GitHub auto-expands to show title with rich previews
                if is_current {
                    let _ = writeln!(body, "* **#{} {STACK_COMMENT_THIS_PR}**", item.pr_number);
                } else {
                    let _ = writeln!(body, "* #{}", item.pr_number);
                }
            }
            Platform::GitLab => {
                // GitLab: "* [PR title !N](url)" - !N is MR reference, full link for clickability
                if is_current {
                    let _ = writeln!(
                        body,
                        "* **[{} !{}]({}) {STACK_COMMENT_THIS_PR}**",
                        item.pr_title, item.pr_number, item.pr_url
                    );
                } else {
                    let _ = writeln!(
                        body,
                        "* [{} !{}]({})",
                        item.pr_title, item.pr_number, item.pr_url
                    );
                }
            }
        }
    }

    // Add base branch at bottom
    let _ = writeln!(body, "* `{}`", data.base_branch);

    let _ = write!(
        body,
        "\n---\nThis stack of pull requests is managed by [jj-ryu](https://github.com/dmmulroy/jj-ryu)."
    );

    Ok(body)
}

/// Create or update the stack comment on a PR
async fn create_or_update_stack_comment(
    platform: &dyn PlatformService,
    data: &StackCommentData,
    current_idx: usize,
    pr_number: u64,
) -> Result<()> {
    let body = format_stack_comment_for_platform(data, current_idx, platform.config().platform)?;

    // Find existing comment by looking for our data prefix (check both old and new)
    let comments = platform.list_pr_comments(pr_number).await?;
    let existing = comments
        .iter()
        .find(|c| c.body.contains(COMMENT_DATA_PREFIX) || c.body.contains(COMMENT_DATA_PREFIX_OLD));

    if let Some(comment) = existing {
        platform
            .update_pr_comment(pr_number, comment.id, &body)
            .await?;
    } else {
        platform.create_pr_comment(pr_number, &body).await?;
    }

    Ok(())
}

// =============================================================================
// Tests
// =============================================================================

#[cfg(test)]
mod tests {
    use super::*;
    use crate::types::NarrowedBookmarkSegment;

    fn make_pr(number: u64, bookmark: &str) -> PullRequest {
        PullRequest {
            number,
            html_url: format!("https://github.com/test/test/pull/{number}"),
            base_ref: "main".to_string(),
            head_ref: bookmark.to_string(),
            title: format!("PR for {bookmark}"),
            node_id: Some(format!("PR_node_{number}")),
            is_draft: false,
        }
    }

    fn make_bookmark(name: &str) -> Bookmark {
        Bookmark {
            name: name.to_string(),
            commit_id: format!("{name}_commit"),
            change_id: format!("{name}_change"),
            has_remote: false,
            is_synced: false,
        }
    }

    // === SubmissionResult tests ===

    #[test]
    fn test_submission_result_new() {
        let result = SubmissionResult::new();
        assert!(result.success);
        assert!(result.errors.is_empty());
    }

    #[test]
    fn test_submission_result_fail() {
        let mut result = SubmissionResult::new();
        result.fail("something went wrong".to_string());

        assert!(!result.success);
        assert_eq!(result.errors.len(), 1);
        assert_eq!(result.errors[0], "something went wrong");
    }

    #[test]
    fn test_submission_result_soft_fail() {
        let mut result = SubmissionResult::new();
        result.soft_fail("minor issue".to_string());

        // Soft fail records error but doesn't mark as failed
        assert!(result.success);
        assert_eq!(result.errors.len(), 1);
    }

    // === StepOutcome tests ===

    #[test]
    fn test_step_outcome_success_without_pr() {
        let outcome = StepOutcome::Success(None);
        assert!(matches!(outcome, StepOutcome::Success(None)));
    }

    #[test]
    fn test_step_outcome_success_with_pr() {
        let pr = make_pr(1, "feat-a");
        let outcome = StepOutcome::Success(Some(("feat-a".to_string(), pr)));
        assert!(matches!(outcome, StepOutcome::Success(Some(_))));
    }

    #[test]
    fn test_step_outcome_fatal_error() {
        let outcome = StepOutcome::FatalError("boom".to_string());
        assert!(matches!(outcome, StepOutcome::FatalError(_)));
    }

    #[test]
    fn test_step_outcome_soft_error() {
        let outcome = StepOutcome::SoftError("minor".to_string());
        assert!(matches!(outcome, StepOutcome::SoftError(_)));
    }

    // === Dry run formatting tests ===

    #[test]
    fn test_format_step_push() {
        let bm = make_bookmark("feat-a");
        let step = ExecutionStep::Push(bm);
        let output = format_step_for_dry_run(&step, "origin");
        assert_eq!(output, "  → push feat-a to origin");
    }

    #[test]
    fn test_format_step_create_pr() {
        let bm = make_bookmark("feat-a");
        let create = PrToCreate {
            bookmark: bm,
            base_branch: "main".to_string(),
            title: "Add feature".to_string(),
            draft: false,
        };
        let step = ExecutionStep::CreatePr(create);
        let output = format_step_for_dry_run(&step, "origin");
        assert_eq!(output, "  → create PR feat-a → main (Add feature)");
    }

    #[test]
    fn test_format_step_create_pr_draft() {
        let bm = make_bookmark("feat-a");
        let create = PrToCreate {
            bookmark: bm,
            base_branch: "main".to_string(),
            title: "Add feature".to_string(),
            draft: true,
        };
        let step = ExecutionStep::CreatePr(create);
        let output = format_step_for_dry_run(&step, "origin");
        assert!(output.contains("[draft]"));
    }

    #[test]
    fn test_format_step_update_base() {
        let bm = make_bookmark("feat-b");
        let update = PrBaseUpdate {
            bookmark: bm,
            current_base: "main".to_string(),
            expected_base: "feat-a".to_string(),
            pr: make_pr(42, "feat-b"),
        };
        let step = ExecutionStep::UpdateBase(update);
        let output = format_step_for_dry_run(&step, "origin");
        assert_eq!(output, "  → update feat-b (PR #42) main → feat-a");
    }

    #[test]
    fn test_format_step_publish() {
        let pr = make_pr(99, "feat-a");
        let step = ExecutionStep::PublishPr(pr);
        let output = format_step_for_dry_run(&step, "origin");
        assert_eq!(output, "  → publish PR #99 (feat-a)");
    }

    // === Stack comment tests ===

    #[test]
    fn test_build_stack_comment_data() {
        let plan = SubmissionPlan {
            segments: vec![
                NarrowedBookmarkSegment {
                    bookmark: make_bookmark("feat-a"),
                    changes: vec![],
                },
                NarrowedBookmarkSegment {
                    bookmark: make_bookmark("feat-b"),
                    changes: vec![],
                },
            ],
            constraints: vec![],
            execution_steps: vec![],
            existing_prs: HashMap::new(),
            remote: "origin".to_string(),
            default_branch: "main".to_string(),
        };

        let mut bookmark_to_pr = HashMap::new();
        bookmark_to_pr.insert("feat-a".to_string(), make_pr(1, "feat-a"));
        bookmark_to_pr.insert("feat-b".to_string(), make_pr(2, "feat-b"));

        let data = build_stack_comment_data(&plan, &bookmark_to_pr);

        assert_eq!(data.version, 1);
        assert_eq!(data.base_branch, "main");
        assert_eq!(data.stack.len(), 2);
        assert_eq!(data.stack[0].bookmark_name, "feat-a");
        assert_eq!(data.stack[0].pr_number, 1);
        assert_eq!(data.stack[0].pr_title, "PR for feat-a");
        assert_eq!(data.stack[1].bookmark_name, "feat-b");
        assert_eq!(data.stack[1].pr_number, 2);
    }

    #[test]
    fn test_build_stack_comment_data_filters_missing_prs() {
        let plan = SubmissionPlan {
            segments: vec![
                NarrowedBookmarkSegment {
                    bookmark: make_bookmark("feat-a"),
                    changes: vec![],
                },
                NarrowedBookmarkSegment {
                    bookmark: make_bookmark("feat-b"),
                    changes: vec![],
                },
            ],
            constraints: vec![],
            execution_steps: vec![],
            existing_prs: HashMap::new(),
            remote: "origin".to_string(),
            default_branch: "main".to_string(),
        };

        // Only feat-a has a PR
        let mut bookmark_to_pr = HashMap::new();
        bookmark_to_pr.insert("feat-a".to_string(), make_pr(1, "feat-a"));

        let data = build_stack_comment_data(&plan, &bookmark_to_pr);

        assert_eq!(data.stack.len(), 1);
        assert_eq!(data.stack[0].bookmark_name, "feat-a");
    }

    #[test]
    fn test_format_stack_comment_marks_current() {
        let data = StackCommentData {
            version: 1,
            stack: vec![
                StackItem {
                    bookmark_name: "feat-a".to_string(),
                    pr_url: "https://example.com/1".to_string(),
                    pr_number: 1,
                    pr_title: "feat: add auth".to_string(),
                },
                StackItem {
                    bookmark_name: "feat-b".to_string(),
                    pr_url: "https://example.com/2".to_string(),
                    pr_number: 2,
                    pr_title: "feat: add sessions".to_string(),
                },
            ],
            base_branch: "main".to_string(),
        };

        // Format for PR #2 (index 1)
        let body = format_stack_comment(&data, 1).unwrap();
        assert!(body.contains(&format!("#{} {STACK_COMMENT_THIS_PR}", 2)));
        assert!(!body.contains(&format!("#{} {STACK_COMMENT_THIS_PR}", 1)));
    }

    #[test]
    fn test_format_stack_comment_contains_prefix() {
        let data = StackCommentData {
            version: 1,
            stack: vec![StackItem {
                bookmark_name: "feat-a".to_string(),
                pr_url: "https://example.com/1".to_string(),
                pr_number: 1,
                pr_title: "feat: add auth".to_string(),
            }],
            base_branch: "main".to_string(),
        };

        let body = format_stack_comment(&data, 0).unwrap();
        assert!(body.contains(COMMENT_DATA_PREFIX));
        assert!(body.contains(COMMENT_DATA_POSTFIX));
    }

    #[test]
    fn test_format_stack_comment_gitlab_uses_exclamation_mark() {
        let data = StackCommentData {
            version: 1,
            stack: vec![
                StackItem {
                    bookmark_name: "feat-a".to_string(),
                    pr_url: "https://gitlab.com/test/test/-/merge_requests/1".to_string(),
                    pr_number: 1,
                    pr_title: "feat: add auth".to_string(),
                },
                StackItem {
                    bookmark_name: "feat-b".to_string(),
                    pr_url: "https://gitlab.com/test/test/-/merge_requests/2".to_string(),
                    pr_number: 2,
                    pr_title: "feat: add sessions".to_string(),
                },
            ],
            base_branch: "main".to_string(),
        };

        // GitLab format should use !N and full URLs
        let body = format_stack_comment_for_platform(&data, 1, Platform::GitLab).unwrap();

        // Should use !N (MR reference) not #N
        assert!(body.contains("!1"), "GitLab should use !N for MRs: {body}");
        assert!(body.contains("!2"), "GitLab should use !N for MRs: {body}");
        assert!(!body.contains("#1"), "GitLab should NOT use #N: {body}");
        assert!(!body.contains("#2"), "GitLab should NOT use #N: {body}");

        // Should have full URLs
        assert!(
            body.contains("https://gitlab.com/test/test/-/merge_requests/1"),
            "GitLab should include full URLs: {body}"
        );

        // Current PR should have marker
        assert!(
            body.contains(&format!(
                "!2]({}) {STACK_COMMENT_THIS_PR}",
                "https://gitlab.com/test/test/-/merge_requests/2"
            )),
            "Current PR should have marker: {body}"
        );
    }

    #[test]
    fn test_format_stack_comment_github_uses_hash() {
        let data = StackCommentData {
            version: 1,
            stack: vec![StackItem {
                bookmark_name: "feat-a".to_string(),
                pr_url: "https://github.com/test/test/pull/1".to_string(),
                pr_number: 1,
                pr_title: "feat: add auth".to_string(),
            }],
            base_branch: "main".to_string(),
        };

        // GitHub format should use #N without URLs in the visible text
        let body = format_stack_comment_for_platform(&data, 0, Platform::GitHub).unwrap();

        assert!(body.contains("#1"), "GitHub should use #N: {body}");
        assert!(!body.contains("!1"), "GitHub should NOT use !N: {body}");
        // GitHub format doesn't include PR URLs in visible text (relies on auto-linking)
        assert!(
            !body.contains("](https://github.com/test/test/pull"),
            "GitHub should NOT have markdown links to PRs: {body}"
        );
        // Title should NOT be in the output - GitHub will auto-expand it
        assert!(
            !body.contains("feat: add auth"),
            "GitHub auto-expands, so title should not be in source: {body}"
        );
    }

    // === Plan helper tests ===

    #[test]
    fn test_plan_is_empty() {
        let plan = SubmissionPlan {
            segments: vec![],
            constraints: vec![],
            execution_steps: vec![],
            existing_prs: HashMap::new(),
            remote: "origin".to_string(),
            default_branch: "main".to_string(),
        };

        assert!(plan.is_empty());
    }

    #[test]
    fn test_plan_counts() {
        let bm = make_bookmark("feat-a");
        let plan = SubmissionPlan {
            segments: vec![NarrowedBookmarkSegment {
                bookmark: bm.clone(),
                changes: vec![],
            }],
            constraints: vec![],
            execution_steps: vec![
                ExecutionStep::Push(bm.clone()),
                ExecutionStep::CreatePr(PrToCreate {
                    bookmark: bm,
                    base_branch: "main".to_string(),
                    title: "Add feat-a".to_string(),
                    draft: false,
                }),
            ],
            existing_prs: HashMap::new(),
            remote: "origin".to_string(),
            default_branch: "main".to_string(),
        };

        assert!(!plan.is_empty());
        assert_eq!(plan.count_pushes(), 1);
        assert_eq!(plan.count_creates(), 1);
        assert_eq!(plan.count_updates(), 0);
        assert_eq!(plan.count_publishes(), 0);
    }
}