1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
//! Lexer-aware brace tracking for jq queries.
//!
//! This module provides the `BraceTracker` component that tracks the nesting of
//! braces `{}`, brackets `[]`, and parentheses `()` in jq queries. It correctly
//! ignores braces inside string literals to enable accurate context detection
//! for autocomplete suggestions.
use super::scan_state::ScanState;
/// Types of braces tracked by the BraceTracker
#[derive(Debug, Clone, Copy, PartialEq, Eq)]
pub enum BraceType {
/// Curly braces `{ }`
Curly,
/// Square brackets `[ ]`
Square,
/// Parentheses `( )`
Paren,
}
/// Tracks brace nesting in jq queries with lexer-aware scanning.
///
/// The tracker maintains a stack of unclosed open braces and their positions,
/// correctly handling string literals and escape sequences to avoid counting
/// braces that appear inside strings.
#[derive(Debug, Clone)]
pub struct BraceTracker {
/// Stack of unclosed open braces: (byte_position, type)
/// Maintained in LIFO order for O(1) push/pop
open_braces: Vec<(usize, BraceType)>,
/// Query snapshot for staleness detection
query_snapshot: String,
}
impl Default for BraceTracker {
fn default() -> Self {
Self::new()
}
}
impl BraceTracker {
/// Create a new empty BraceTracker
pub fn new() -> Self {
Self {
open_braces: Vec::new(),
query_snapshot: String::new(),
}
}
/// Rebuild the brace tracking state from a query string.
///
/// This performs a lexer-aware scan of the query, tracking open braces
/// while correctly ignoring braces inside string literals.
///
/// # Arguments
/// * `query` - The jq query string to analyze
///
/// # Complexity
/// O(n) where n is the query length
pub fn rebuild(&mut self, query: &str) {
self.open_braces.clear();
self.query_snapshot = query.to_string();
let mut state = ScanState::default();
for (pos, ch) in query.char_indices() {
// Only process braces when not inside a string
if !state.is_in_string() {
match ch {
'{' => self.open_braces.push((pos, BraceType::Curly)),
'[' => self.open_braces.push((pos, BraceType::Square)),
'(' => self.open_braces.push((pos, BraceType::Paren)),
'}' => {
// Only pop if matching type (graceful handling of mismatched braces)
if let Some((_, BraceType::Curly)) = self.open_braces.last() {
self.open_braces.pop();
}
}
']' => {
if let Some((_, BraceType::Square)) = self.open_braces.last() {
self.open_braces.pop();
}
}
')' => {
if let Some((_, BraceType::Paren)) = self.open_braces.last() {
self.open_braces.pop();
}
}
_ => {}
}
}
state = state.advance(ch);
}
}
/// Get the innermost brace context at a given position.
///
/// Returns the type of the innermost unclosed brace that contains the
/// given position, or `None` if not inside any braces.
///
/// # Arguments
/// * `pos` - The byte position to query
///
/// # Returns
/// The `BraceType` of the innermost containing brace, or `None`
///
/// # Complexity
/// O(k) where k is the nesting depth
pub fn context_at(&self, pos: usize) -> Option<BraceType> {
// Find the innermost brace that opened before this position
// Since we track unclosed braces, we look for the last one that opened before pos
for (brace_pos, brace_type) in self.open_braces.iter().rev() {
if *brace_pos < pos {
return Some(*brace_type);
}
}
None
}
/// Check if the given position is inside an object literal `{}`.
///
/// # Arguments
/// * `pos` - The byte position to query
///
/// # Returns
/// `true` if the innermost unclosed brace at this position is a curly brace
pub fn is_in_object(&self, pos: usize) -> bool {
self.context_at(pos) == Some(BraceType::Curly)
}
/// Check if the tracker is stale (query has changed since last rebuild).
///
/// # Arguments
/// * `current_query` - The current query string to compare against
///
/// # Returns
/// `true` if the query has changed and rebuild is needed
#[allow(dead_code)] // Part of public API for potential future optimization
pub fn is_stale(&self, current_query: &str) -> bool {
self.query_snapshot != current_query
}
}
#[cfg(test)]
mod tests {
use super::*;
use proptest::prelude::*;
// ========== Unit Tests ==========
#[test]
fn test_empty_query() {
let mut tracker = BraceTracker::new();
tracker.rebuild("");
assert_eq!(tracker.context_at(0), None);
assert!(!tracker.is_in_object(0));
}
#[test]
fn test_simple_object() {
let mut tracker = BraceTracker::new();
tracker.rebuild("{name");
assert_eq!(tracker.context_at(1), Some(BraceType::Curly));
assert!(tracker.is_in_object(1));
assert!(tracker.is_in_object(5));
}
#[test]
fn test_simple_array() {
let mut tracker = BraceTracker::new();
tracker.rebuild("[1, 2");
assert_eq!(tracker.context_at(1), Some(BraceType::Square));
assert!(!tracker.is_in_object(1));
}
#[test]
fn test_simple_paren() {
let mut tracker = BraceTracker::new();
tracker.rebuild("map(");
assert_eq!(tracker.context_at(4), Some(BraceType::Paren));
assert!(!tracker.is_in_object(4));
}
#[test]
fn test_closed_braces() {
let mut tracker = BraceTracker::new();
tracker.rebuild("{name: .name}");
// After the closing brace, we're no longer in object context
assert_eq!(tracker.context_at(13), None);
}
#[test]
fn test_object_in_array() {
let mut tracker = BraceTracker::new();
tracker.rebuild("[{na");
// Position 2 is inside the object (after '{')
assert_eq!(tracker.context_at(2), Some(BraceType::Curly));
assert!(tracker.is_in_object(2));
}
#[test]
fn test_array_in_object() {
let mut tracker = BraceTracker::new();
tracker.rebuild("{items: [na");
// Position 9 is inside the array (after '[')
assert_eq!(tracker.context_at(9), Some(BraceType::Square));
assert!(!tracker.is_in_object(9));
}
#[test]
fn test_deep_nesting() {
let mut tracker = BraceTracker::new();
tracker.rebuild("{a: [{b: (c");
// Position 10 is inside the paren
assert_eq!(tracker.context_at(10), Some(BraceType::Paren));
assert!(!tracker.is_in_object(10));
}
#[test]
fn test_braces_in_string() {
let mut tracker = BraceTracker::new();
tracker.rebuild("\"{braces}\"");
// Braces inside string should be ignored
assert_eq!(tracker.context_at(5), None);
assert!(!tracker.is_in_object(5));
}
#[test]
fn test_escaped_quote_in_string() {
let mut tracker = BraceTracker::new();
tracker.rebuild("\"say \\\"hi\\\" {here\"");
// The { is inside the string, should be ignored
assert_eq!(tracker.context_at(12), None);
}
#[test]
fn test_escaped_backslash_in_string() {
let mut tracker = BraceTracker::new();
tracker.rebuild("\"path\\\\{dir\"");
// The { is inside the string after \\, should be ignored
assert_eq!(tracker.context_at(8), None);
}
#[test]
fn test_string_then_real_braces() {
let mut tracker = BraceTracker::new();
tracker.rebuild("\"{fake}\" | {real");
// Position 12 is inside the real object
assert_eq!(tracker.context_at(12), Some(BraceType::Curly));
assert!(tracker.is_in_object(12));
}
#[test]
fn test_object_key_after_comma() {
let mut tracker = BraceTracker::new();
tracker.rebuild("{name: .name, ag");
// Position 14 is still inside the object
assert!(tracker.is_in_object(14));
}
#[test]
fn test_real_jq_pattern_select() {
let mut tracker = BraceTracker::new();
tracker.rebuild("select(.active)");
// After the closing paren, no context
assert_eq!(tracker.context_at(15), None);
}
#[test]
fn test_real_jq_pattern_map() {
let mut tracker = BraceTracker::new();
// Test partial query (user is still typing)
tracker.rebuild("map({na");
// Position 5 is inside the object (after '{' at position 4)
assert!(tracker.is_in_object(5));
// Test complete query - all braces closed
tracker.rebuild("map({name: .name})");
// After everything closes, no context
assert_eq!(tracker.context_at(18), None);
// Even position 5 has no unclosed context after full query
assert_eq!(tracker.context_at(5), None);
}
#[test]
fn test_mismatched_braces() {
let mut tracker = BraceTracker::new();
// Mismatched: opening { but closing with ]
tracker.rebuild("{test]");
// The ] doesn't match {, so { stays open
assert!(tracker.is_in_object(5));
}
#[test]
fn test_unclosed_string() {
let mut tracker = BraceTracker::new();
// Unclosed string - everything after " is in string
tracker.rebuild("\"unclosed {");
// The { is inside the unclosed string
assert_eq!(tracker.context_at(10), None);
}
#[test]
fn test_is_stale() {
let mut tracker = BraceTracker::new();
tracker.rebuild("{test");
assert!(!tracker.is_stale("{test"));
assert!(tracker.is_stale("{test2"));
assert!(tracker.is_stale(""));
}
#[test]
fn test_context_at_position_zero() {
let mut tracker = BraceTracker::new();
tracker.rebuild("{test");
// Position 0 is before the opening brace
assert_eq!(tracker.context_at(0), None);
}
// ========== Property-Based Tests ==========
proptest! {
/// **Feature: object-key-autocomplete, Property 4: BraceTracker never panics**
/// **Validates: Requirements 5.2, 5.3**
///
/// For any arbitrary string input, calling rebuild() and context_at()
/// shall not panic.
#[test]
fn prop_rebuild_never_panics(query in ".*") {
let mut tracker = BraceTracker::new();
tracker.rebuild(&query);
// If we get here without panicking, the test passes
}
/// **Feature: object-key-autocomplete, Property 4: BraceTracker never panics**
/// **Validates: Requirements 5.2, 5.3**
///
/// For any position query on any string, context_at() shall not panic.
#[test]
fn prop_context_at_never_panics(query in ".*", pos in 0usize..1000) {
let mut tracker = BraceTracker::new();
tracker.rebuild(&query);
let _ = tracker.context_at(pos);
let _ = tracker.is_in_object(pos);
// If we get here without panicking, the test passes
}
/// **Feature: object-key-autocomplete, Property 3: Braces inside strings are ignored**
/// **Validates: Requirements 3.1, 3.2**
///
/// For any query containing a string literal with braces inside,
/// the BraceTracker shall report the same context as if those braces
/// were not present.
#[test]
fn prop_string_braces_ignored(
prefix in "[a-z .|]*",
string_content in "[a-z{}\\[\\]()]*",
suffix in "[a-z .|]*"
) {
// Build query with braces inside a string
let query_with_string_braces = format!("{}\"{}\"{}", prefix, string_content, suffix);
// Build query with empty string (no braces in string)
let query_with_empty_string = format!("{}\"\"{}", prefix, suffix);
let mut tracker1 = BraceTracker::new();
let mut tracker2 = BraceTracker::new();
tracker1.rebuild(&query_with_string_braces);
tracker2.rebuild(&query_with_empty_string);
// The context after the string should be the same
let pos_after_string1 = prefix.len() + string_content.len() + 2; // +2 for quotes
let pos_after_string2 = prefix.len() + 2; // +2 for quotes
prop_assert_eq!(
tracker1.context_at(pos_after_string1),
tracker2.context_at(pos_after_string2),
"Context after string should be same regardless of braces inside string"
);
}
/// **Feature: object-key-autocomplete, Property 4: BraceTracker never panics**
/// **Validates: Requirements 5.2, 5.3**
///
/// is_in_object should be consistent with context_at result.
#[test]
fn prop_is_in_object_consistent(query in ".*", pos in 0usize..500) {
let mut tracker = BraceTracker::new();
tracker.rebuild(&query);
let context = tracker.context_at(pos);
let is_object = tracker.is_in_object(pos);
prop_assert_eq!(
is_object,
context == Some(BraceType::Curly),
"is_in_object should match context_at == Curly"
);
}
}
}