ironflow-api 2.52.10

//! `PATCH /api/v1/users/{id}/role` -- Update a user's role (admin only).

use axum::Json;
use axum::extract::{Path, State};
use axum::response::IntoResponse;
use uuid::Uuid;

use ironflow_auth::extractor::Authenticated;
use ironflow_store::entities::ApiKeyScope;
use ironflow_store::error::StoreError;

use crate::authorization::AuthorizeExt;
use crate::entities::{UpdateRoleRequest, UserResponse};
use crate::error::ApiError;
use crate::response::ok;
use crate::state::AppState;

/// Update a user's admin role. Admin only.
///
/// # Errors
///
/// - 403 if the caller is not an admin
/// - 400 if trying to change own role
/// - 404 if the user does not exist
#[cfg_attr(
    feature = "openapi",
    utoipa::path(
        patch,
        path = "/api/v1/users/{id}/role",
        tags = ["users"],
        params(
            ("id" = Uuid, Path, description = "User ID")
        ),
        request_body(content = UpdateRoleRequest, description = "New role assignment"),
        responses(
            (status = 200, description = "User role updated successfully", body = UserResponse),
            (status = 400, description = "Cannot change own role"),
            (status = 401, description = "Unauthorized"),
            (status = 403, description = "Forbidden (not an admin)"),
            (status = 404, description = "User not found")
        ),
        security(("Bearer" = []))
    )
)]
pub async fn update_role(
    auth: Authenticated,
    State(state): State<AppState>,
    Path(id): Path<Uuid>,
    Json(req): Json<UpdateRoleRequest>,
) -> Result<impl IntoResponse, ApiError> {
    auth.require(ApiKeyScope::Admin, true)?;

    if auth.user_id == id {
        return Err(ApiError::BadRequest(
            "cannot change your own role".to_string(),
        ));
    }

    // The store bumps the target's token_version and drops its refresh tokens
    // in the same write, so a demoted admin loses admin access on the next
    // request instead of when the access token expires.
    let user = state
        .store
        .update_user_role(id, req.is_admin)
        .await
        .map_err(|e| match e {
            StoreError::UserNotFound(id) => ApiError::UserNotFound(id),
            other => ApiError::Store(other),
        })?;

    Ok(ok(UserResponse::from(user)))
}

#[cfg(test)]
mod tests {
    use axum::Router;
    use axum::body::Body;
    use axum::http::{Request, StatusCode};
    use axum::routing::{get, patch};
    use http_body_util::BodyExt;
    use ironflow_auth::extractor::{API_KEY_PREFIX, API_KEY_SUFFIX_LEN};
    use ironflow_auth::jwt::{AccessToken, JwtConfig};
    use ironflow_auth::password;
    use ironflow_core::providers::claude::ClaudeCodeProvider;
    use ironflow_engine::context::WorkflowContext;
    use ironflow_engine::engine::Engine;
    use ironflow_engine::handler::{HandlerFuture, WorkflowHandler};
    use ironflow_engine::notify::Event;
    use ironflow_store::entities::{NewApiKey, NewUser};
    use ironflow_store::memory::InMemoryStore;
    use ironflow_store::store::Store;
    use serde_json::{Value as JsonValue, json, to_string};
    use std::sync::Arc;
    use tokio::sync::broadcast;
    use tower::ServiceExt;
    use uuid::Uuid;

    use super::*;
    use crate::routes::test_helpers::create_user_auth_header;

    struct TestWorkflow;

    impl WorkflowHandler for TestWorkflow {
        fn name(&self) -> &str {
            "test-workflow"
        }

        fn execute<'a>(&'a self, _ctx: &'a mut WorkflowContext) -> HandlerFuture<'a> {
            Box::pin(async move { Ok(()) })
        }
    }

    fn test_jwt_config() -> Arc<JwtConfig> {
        Arc::new(JwtConfig {
            secret: "test-secret-for-user-tests".to_string(),
            access_token_ttl_secs: 900,
            refresh_token_ttl_secs: 604800,
            cookie_domain: None,
            cookie_secure: false,
        })
    }

    fn test_state() -> AppState {
        let store: Arc<dyn Store> = Arc::new(InMemoryStore::new());
        let provider = Arc::new(ClaudeCodeProvider::new());
        let mut engine = Engine::new(store.clone(), provider);
        engine
            .register(TestWorkflow)
            .expect("failed to register test workflow");
        let (event_sender, _) = broadcast::channel::<Event>(1);
        AppState::new(
            store,
            Arc::new(engine),
            test_jwt_config(),
            "test-worker-token".to_string(),
            event_sender,
        )
    }

    fn make_auth_header(user_id: Uuid, is_admin: bool, state: &AppState) -> String {
        let token =
            AccessToken::for_user(user_id, "testuser", is_admin, &state.jwt_config).unwrap();
        format!("Bearer {}", token.0)
    }

    #[tokio::test]
    async fn update_role_promote_member() {
        let state = test_state();
        let admin = state
            .store
            .create_user(NewUser {
                email: "admin@example.com".to_string(),
                username: "admin".to_string(),
                password_hash: "hash".to_string(),
                is_admin: None,
            })
            .await
            .unwrap();

        let member = state
            .store
            .create_user(NewUser {
                email: "member@example.com".to_string(),
                username: "member".to_string(),
                password_hash: "hash".to_string(),
                is_admin: None,
            })
            .await
            .unwrap();
        assert!(!member.is_admin);

        let auth_header = make_auth_header(admin.id, true, &state);
        let app = Router::new()
            .route("/{id}/role", patch(update_role))
            .with_state(state);

        let req = Request::builder()
            .uri(format!("/{}/role", member.id))
            .method("PATCH")
            .header("content-type", "application/json")
            .header("authorization", auth_header)
            .body(Body::from(to_string(&json!({"is_admin": true})).unwrap()))
            .unwrap();

        let resp = app.oneshot(req).await.unwrap();
        assert_eq!(resp.status(), StatusCode::OK);

        let body = resp.into_body().collect().await.unwrap().to_bytes();
        let json: JsonValue = serde_json::from_slice(&body).unwrap();
        assert_eq!(json["data"]["is_admin"], true);
    }

    #[tokio::test]
    async fn update_role_self_forbidden() {
        let state = test_state();
        let admin = state
            .store
            .create_user(NewUser {
                email: "admin@example.com".to_string(),
                username: "admin".to_string(),
                password_hash: "hash".to_string(),
                is_admin: None,
            })
            .await
            .unwrap();

        let auth_header = make_auth_header(admin.id, true, &state);
        let app = Router::new()
            .route("/{id}/role", patch(update_role))
            .with_state(state);

        let req = Request::builder()
            .uri(format!("/{}/role", admin.id))
            .method("PATCH")
            .header("content-type", "application/json")
            .header("authorization", auth_header)
            .body(Body::from(to_string(&json!({"is_admin": false})).unwrap()))
            .unwrap();

        let resp = app.oneshot(req).await.unwrap();
        assert_eq!(resp.status(), StatusCode::BAD_REQUEST);
    }

    #[tokio::test]
    async fn update_role_as_member_forbidden() {
        let state = test_state();
        let target_id = Uuid::now_v7();
        let auth_header = create_user_auth_header(&state, "member", false).await;
        let app = Router::new()
            .route("/{id}/role", patch(update_role))
            .with_state(state);

        let req = Request::builder()
            .uri(format!("/{target_id}/role"))
            .method("PATCH")
            .header("content-type", "application/json")
            .header("authorization", auth_header)
            .body(Body::from(to_string(&json!({"is_admin": true})).unwrap()))
            .unwrap();

        let resp = app.oneshot(req).await.unwrap();
        assert_eq!(resp.status(), StatusCode::FORBIDDEN);
    }

    #[tokio::test]
    async fn demoted_admin_token_is_rejected() {
        let state = test_state();
        let admin = state
            .store
            .create_user(NewUser {
                email: "admin@example.com".to_string(),
                username: "admin".to_string(),
                password_hash: "hash".to_string(),
                is_admin: Some(true),
            })
            .await
            .unwrap();
        let other_admin = state
            .store
            .create_user(NewUser {
                email: "other@example.com".to_string(),
                username: "other".to_string(),
                password_hash: "hash".to_string(),
                is_admin: Some(true),
            })
            .await
            .unwrap();

        let admin_header = make_auth_header(admin.id, true, &state);
        let other_header = make_auth_header(other_admin.id, true, &state);
        let app = Router::new()
            .route("/{id}/role", patch(update_role))
            .with_state(state);

        let demote = Request::builder()
            .uri(format!("/{}/role", other_admin.id))
            .method("PATCH")
            .header("content-type", "application/json")
            .header("authorization", admin_header)
            .body(Body::from(to_string(&json!({"is_admin": false})).unwrap()))
            .unwrap();
        let resp = app.clone().oneshot(demote).await.unwrap();
        assert_eq!(resp.status(), StatusCode::OK);

        // The demoted admin's token still claims is_admin = true and has not
        // expired, but it was issued before the role change.
        let retaliate = Request::builder()
            .uri(format!("/{}/role", admin.id))
            .method("PATCH")
            .header("content-type", "application/json")
            .header("authorization", other_header)
            .body(Body::from(to_string(&json!({"is_admin": false})).unwrap()))
            .unwrap();
        let resp = app.oneshot(retaliate).await.unwrap();
        assert_eq!(resp.status(), StatusCode::UNAUTHORIZED);
    }

    /// Store an API key owned by `user_id` with `scopes`, returning its ID and
    /// its `Bearer` header.
    async fn create_api_key(
        state: &AppState,
        user_id: Uuid,
        scopes: Vec<ApiKeyScope>,
    ) -> (Uuid, String) {
        let raw_key = format!(
            "irfl_{}rest-of-secret-key",
            &Uuid::now_v7().simple().to_string()[24..]
        );
        let prefix = &raw_key[..API_KEY_PREFIX.len() + API_KEY_SUFFIX_LEN];
        let key = state
            .store
            .create_api_key(NewApiKey {
                user_id,
                name: format!("key-{}", Uuid::now_v7()),
                key_hash: password::hash(&raw_key).unwrap(),
                key_prefix: prefix.to_string(),
                scopes,
                expires_at: None,
                rate_limit_override: None,
            })
            .await
            .unwrap();
        (key.id, format!("Bearer {raw_key}"))
    }

    #[tokio::test]
    async fn demoted_admin_api_key_loses_admin_scope_and_is_disabled() {
        let state = test_state();
        let admin = state
            .store
            .create_user(NewUser {
                email: "admin@example.com".to_string(),
                username: "admin".to_string(),
                password_hash: "hash".to_string(),
                is_admin: Some(true),
            })
            .await
            .unwrap();
        let demoted = state
            .store
            .create_user(NewUser {
                email: "demoted@example.com".to_string(),
                username: "demoted".to_string(),
                password_hash: "hash".to_string(),
                is_admin: Some(true),
            })
            .await
            .unwrap();
        let (admin_key_id, admin_key_header) =
            create_api_key(&state, demoted.id, vec![ApiKeyScope::Admin]).await;
        let (mixed_key_id, mixed_key_header) = create_api_key(
            &state,
            demoted.id,
            vec![ApiKeyScope::RunsRead, ApiKeyScope::SignalsSend],
        )
        .await;

        let admin_header = make_auth_header(admin.id, true, &state);
        let store = state.store.clone();
        let app = Router::new()
            .route("/{id}/role", patch(update_role))
            .route("/probe", get(|_auth: Authenticated| async { "ok" }))
            .with_state(state);

        let demote = Request::builder()
            .uri(format!("/{}/role", demoted.id))
            .method("PATCH")
            .header("content-type", "application/json")
            .header("authorization", admin_header)
            .body(Body::from(to_string(&json!({"is_admin": false})).unwrap()))
            .unwrap();
        let resp = app.clone().oneshot(demote).await.unwrap();
        assert_eq!(resp.status(), StatusCode::OK);

        let keys = store.list_api_keys_by_user(demoted.id).await.unwrap();
        assert_eq!(keys.len(), 2);
        for key in &keys {
            assert!(ApiKeyScope::all_allowed_for_member(&key.scopes));
            assert!(!key.scopes.contains(&ApiKeyScope::Admin));
            assert!(!key.scopes.contains(&ApiKeyScope::SignalsSend));
        }
        let admin_key = keys.iter().find(|k| k.id == admin_key_id).unwrap();
        assert!(admin_key.scopes.is_empty());
        assert!(!admin_key.is_active);
        let mixed_key = keys.iter().find(|k| k.id == mixed_key_id).unwrap();
        assert_eq!(mixed_key.scopes, vec![ApiKeyScope::RunsRead]);
        assert!(mixed_key.is_active);

        let probe = |header: String| {
            Request::builder()
                .uri("/probe")
                .header("authorization", header)
                .body(Body::empty())
                .unwrap()
        };
        let resp = app.clone().oneshot(probe(admin_key_header)).await.unwrap();
        assert_eq!(resp.status(), StatusCode::UNAUTHORIZED);
        let resp = app.oneshot(probe(mixed_key_header)).await.unwrap();
        assert_eq!(resp.status(), StatusCode::OK);
    }
}