irondrop 2.6.4

Drop files, not dependencies - a well tested fully featured & battle-ready server in a single Rust binary with support for indexing through 10M files.
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
// SPDX-License-Identifier: MIT

//! Configuration management for `IronDrop`
//! Supports INI files with CLI argument overrides

pub mod ini_parser;

use crate::cli::Cli;
use ini_parser::IniConfig;
use std::path::{Path, PathBuf};

#[derive(Debug, Clone)]
pub struct Config {
    // Server settings
    pub listen: String,
    pub port: u16,
    pub threads: usize,
    pub chunk_size: usize,
    pub directory: PathBuf,

    // Upload settings
    pub enable_upload: bool,
    pub max_upload_size: u64,

    // Security settings
    pub username: Option<String>,
    pub password: Option<String>,
    pub allowed_extensions: Vec<String>,

    // Logging settings
    pub verbose: bool,
    pub detailed_logging: bool,
    pub log_dir: Option<PathBuf>,
}

impl Config {
    /// Load configuration with precedence: CLI args > INI file > Defaults
    pub fn load(cli: &Cli) -> Result<Self, String> {
        log::debug!("Starting configuration loading process");
        log::trace!("CLI config_file parameter: {:?}", cli.config_file);

        // Try to load configuration file
        let config_file = Self::find_config_file(cli)?;
        log::debug!("Config file discovery result: {:?}", config_file);

        let ini = if let Some(path) = config_file {
            log::info!("Loading configuration from: {}", path.display());
            let ini_config = IniConfig::load_file(&path)?;
            log::debug!(
                "Successfully parsed INI configuration with {} sections",
                ini_config.sections().len()
            );
            ini_config
        } else {
            log::info!("No configuration file found, using defaults and CLI overrides");
            IniConfig::new()
        };

        // Build configuration with precedence
        log::debug!("Building final configuration with precedence rules");
        let config = Self {
            listen: Self::get_listen(&ini, cli),
            port: Self::get_port(&ini, cli),
            threads: Self::get_threads(&ini, cli),
            chunk_size: Self::get_chunk_size(&ini, cli),
            directory: Self::get_directory(&ini, cli)?,

            enable_upload: Self::get_enable_upload(&ini, cli),
            max_upload_size: Self::get_max_upload_size(&ini, cli),

            username: Self::get_username(&ini, cli),
            password: Self::get_password(&ini, cli),
            allowed_extensions: Self::get_allowed_extensions(&ini, cli),

            verbose: Self::get_verbose(&ini, cli),
            detailed_logging: Self::get_detailed_logging(&ini, cli),
            log_dir: Self::get_log_dir(&ini, cli),
        };

        log::debug!("Configuration loading completed successfully");
        log::trace!(
            "Final config - listen: {}, port: {}, threads: {}, upload_enabled: {}",
            config.listen,
            config.port,
            config.threads,
            config.enable_upload
        );

        Ok(config)
    }

    /// Find configuration file in order of preference
    fn find_config_file(cli: &Cli) -> Result<Option<PathBuf>, String> {
        // 1. Check if config file is explicitly specified via CLI
        if let Some(ref config_path) = cli.config_file {
            let path = PathBuf::from(config_path);
            if path.exists() {
                return Ok(Some(path));
            }
            return Err(format!(
                "Config file specified but not found: {config_path}"
            ));
        }

        // 2. Check current directory
        let current_config = PathBuf::from("irondrop.ini");
        if current_config.exists() {
            return Ok(Some(current_config));
        }

        // 3. Check current directory with .conf extension
        let current_config_alt = PathBuf::from("irondrop.conf");
        if current_config_alt.exists() {
            return Ok(Some(current_config_alt));
        }

        // 4. Check user config directory (~/.config/irondrop/config.ini)
        if let Some(home_dir) = std::env::var_os("HOME") {
            let user_config = Path::new(&home_dir)
                .join(".config")
                .join("irondrop")
                .join("config.ini");
            if user_config.exists() {
                return Ok(Some(user_config));
            }
        }

        // 6. Check system config (Unix-like systems)
        #[cfg(unix)]
        {
            let system_config = PathBuf::from("/etc/irondrop/config.ini");
            if system_config.exists() {
                return Ok(Some(system_config));
            }
        }

        Ok(None)
    }

    // Configuration value getters with precedence: CLI > ENV > INI > Default

    fn get_listen(ini: &IniConfig, cli: &Cli) -> String {
        // CLI argument takes precedence if explicitly provided
        if let Some(listen) = &cli.listen {
            return listen.clone();
        }

        // INI file
        if let Some(listen) = ini.get_string("server", "listen") {
            return listen;
        }

        // Default
        "127.0.0.1".to_string()
    }

    fn get_port(ini: &IniConfig, cli: &Cli) -> u16 {
        // CLI argument takes precedence if explicitly provided
        if let Some(port) = cli.port {
            return port;
        }

        // INI file
        if let Some(port) = ini.get_u16("server", "port") {
            return port;
        }

        // Default
        8080
    }

    fn get_threads(ini: &IniConfig, cli: &Cli) -> usize {
        // CLI argument takes precedence if explicitly provided
        if let Some(threads) = cli.threads {
            return threads;
        }

        // INI file
        if let Some(threads) = ini.get_usize("server", "threads") {
            return threads;
        }

        // Default
        8
    }

    fn get_chunk_size(ini: &IniConfig, cli: &Cli) -> usize {
        // CLI argument takes precedence if explicitly provided
        if let Some(chunk_size) = cli.chunk_size {
            return chunk_size;
        }

        // INI file
        if let Some(chunk_size) = ini.get_usize("server", "chunk_size") {
            return chunk_size;
        }

        // Default
        1024
    }

    fn get_directory(_ini: &IniConfig, cli: &Cli) -> Result<PathBuf, String> {
        // CLI argument (always available since it's required)
        Ok(cli.directory.clone())
    }

    fn get_enable_upload(ini: &IniConfig, cli: &Cli) -> bool {
        // CLI argument takes precedence if explicitly provided
        if let Some(enable_upload) = cli.enable_upload {
            return enable_upload;
        }

        // INI file
        if let Some(enabled) = ini.get_bool("upload", "enable_upload") {
            return enabled;
        }

        // Default
        false
    }

    fn get_max_upload_size(ini: &IniConfig, cli: &Cli) -> u64 {
        // CLI argument takes precedence if explicitly provided
        if let Some(max_upload_size) = cli.max_upload_size {
            return max_upload_size * 1024 * 1024; // Convert MB to bytes
        }

        // INI file (supports file size format like "10GB")
        // Try new field name first, then fall back to old field name for compatibility
        if let Some(size_bytes) = ini.get_file_size("upload", "max_upload_size") {
            return size_bytes;
        }
        if let Some(size_bytes) = ini.get_file_size("upload", "max_size") {
            return size_bytes;
        }

        // Default: Very large limit (effectively unlimited with direct streaming)
        u64::MAX
    }

    fn get_username(ini: &IniConfig, cli: &Cli) -> Option<String> {
        // CLI argument
        if let Some(ref username) = cli.username {
            return Some(username.clone());
        }

        // INI file
        ini.get_string("auth", "username")
    }

    fn get_password(ini: &IniConfig, cli: &Cli) -> Option<String> {
        // CLI argument
        if let Some(ref password) = cli.password {
            return Some(password.clone());
        }

        // INI file
        ini.get_string("auth", "password")
    }

    fn get_allowed_extensions(ini: &IniConfig, cli: &Cli) -> Vec<String> {
        // CLI argument takes precedence if explicitly provided
        if let Some(allowed_extensions) = &cli.allowed_extensions {
            return allowed_extensions
                .split(',')
                .map(|s| s.trim().to_string())
                .filter(|s| !s.is_empty())
                .collect();
        }

        // INI file
        let ini_extensions = ini.get_list("security", "allowed_extensions");
        if !ini_extensions.is_empty() {
            return ini_extensions;
        }

        // Default
        vec!["*.zip".to_string(), "*.txt".to_string()]
    }

    fn get_verbose(ini: &IniConfig, cli: &Cli) -> bool {
        // CLI argument takes precedence if explicitly provided
        if let Some(verbose) = cli.verbose {
            return verbose;
        }

        // INI file
        ini.get_bool_or("logging", "verbose", false)
    }

    fn get_detailed_logging(ini: &IniConfig, cli: &Cli) -> bool {
        // CLI argument takes precedence if explicitly provided
        if let Some(detailed_logging) = cli.detailed_logging {
            return detailed_logging;
        }

        // INI file
        ini.get_bool_or("logging", "detailed", false)
    }

    fn get_log_dir(ini: &IniConfig, cli: &Cli) -> Option<PathBuf> {
        // CLI argument takes precedence if explicitly provided
        if let Some(ref log_dir) = cli.log_dir {
            return Some(log_dir.clone());
        }

        // INI file
        ini.get_string("logging", "log_dir").map(PathBuf::from)
    }

    /// Print configuration summary
    pub fn print_summary(&self) {
        log::info!("Configuration Summary:");
        log::info!("  Server: {}:{}", self.listen, self.port);
        log::info!("  Directory: {}", self.directory.display());
        log::info!("  Threads: {}", self.threads);
        log::info!("  Chunk Size: {} bytes", self.chunk_size);
        log::info!("  Upload Enabled: {}", self.enable_upload);
        if self.enable_upload {
            log::info!(
                "  Max Upload Size: {} MB",
                self.max_upload_size / (1024 * 1024)
            );
        }
        log::info!(
            "  Authentication: {}",
            if self.username.is_some() {
                "Enabled"
            } else {
                "Disabled"
            }
        );
        log::info!("  Allowed Extensions: {:?}", self.allowed_extensions);
        log::info!("  Verbose Logging: {}", self.verbose);
        log::info!("  Detailed Logging: {}", self.detailed_logging);
    }
}

#[cfg(test)]
mod tests {
    use super::*;
    use std::fs;
    use tempfile::TempDir;

    fn create_test_cli(directory: PathBuf) -> Cli {
        Cli {
            directory,
            listen: None, // Use config file values when testing config loading
            port: None,   // Use config file values when testing config loading
            allowed_extensions: None,
            threads: None,
            chunk_size: None,
            verbose: None,
            detailed_logging: None,
            username: None,
            password: None,
            enable_upload: None,
            max_upload_size: None,
            config_file: None,
            log_dir: None,
        }
    }

    #[test]
    fn test_config_load_no_config_file() {
        let temp_dir = TempDir::new().unwrap();

        let cli = create_test_cli(temp_dir.path().to_path_buf());
        let config = Config::load(&cli).unwrap();

        // Should use CLI defaults when no config file exists
        assert_eq!(config.listen, "127.0.0.1");
        assert_eq!(config.port, 8080);
        assert_eq!(config.threads, 8);
        assert_eq!(config.chunk_size, 1024);
        assert_eq!(config.directory, temp_dir.path());
        assert!(!config.enable_upload);
        assert_eq!(config.max_upload_size, u64::MAX); // No limit with direct streaming
        assert_eq!(config.username, None);
        assert_eq!(config.password, None);
        assert_eq!(config.allowed_extensions, vec!["*.zip", "*.txt"]);
        assert!(!config.verbose);
        assert!(!config.detailed_logging);
    }

    #[test]
    fn test_config_load_with_ini_file() {
        let temp_dir = TempDir::new().unwrap();
        let config_file = temp_dir.path().join("test.ini");

        let ini_content = r"
[server]
listen = 0.0.0.0
port = 9000
threads = 16
chunk_size = 2048

[upload]
enable_upload = true
max_upload_size = 5GB

[auth]
username = testuser
password = testpass

[security]
allowed_extensions = *.pdf,*.doc

[logging]
verbose = true
detailed = false
";

        fs::write(&config_file, ini_content).unwrap();

        let mut cli = create_test_cli(temp_dir.path().to_path_buf());
        cli.config_file = Some(config_file.to_string_lossy().to_string());

        let config = Config::load(&cli).unwrap();

        // Should use INI file values
        assert_eq!(config.listen, "0.0.0.0");
        assert_eq!(config.port, 9000);
        assert_eq!(config.threads, 16);
        assert_eq!(config.chunk_size, 2048);
        assert!(config.enable_upload);
        assert_eq!(config.max_upload_size, 5 * 1024 * 1024 * 1024);
        assert_eq!(config.username, Some("testuser".to_string()));
        assert_eq!(config.password, Some("testpass".to_string()));
        assert_eq!(config.allowed_extensions, vec!["*.pdf", "*.doc"]);
        assert!(config.verbose);
        assert!(!config.detailed_logging);
    }

    #[test]
    fn test_config_load_cli_overrides_ini() {
        let temp_dir = TempDir::new().unwrap();
        let config_file = temp_dir.path().join("test.ini");

        let ini_content = r"
[server]
listen = 0.0.0.0
port = 9000
threads = 16
";

        fs::write(&config_file, ini_content).unwrap();

        let mut cli = create_test_cli(temp_dir.path().to_path_buf());
        cli.config_file = Some(config_file.to_string_lossy().to_string());
        cli.listen = Some("192.168.1.1".to_string());
        cli.port = Some(7777);
        cli.verbose = Some(true);

        let config = Config::load(&cli).unwrap();

        // CLI should override INI
        assert_eq!(config.listen, "192.168.1.1");
        assert_eq!(config.port, 7777);
        assert!(config.verbose);

        // INI should provide non-overridden values
        assert_eq!(config.threads, 16);
    }

    #[test]
    fn test_config_file_discovery_nonexistent() {
        let temp_dir = TempDir::new().unwrap();

        let mut cli = create_test_cli(temp_dir.path().to_path_buf());
        cli.config_file = Some("/nonexistent/path.ini".to_string());

        let result = Config::load(&cli);
        assert!(result.is_err());
        assert!(
            result
                .unwrap_err()
                .contains("Config file specified but not found")
        );
    }

    #[test]
    fn test_config_upload_settings() {
        let temp_dir = TempDir::new().unwrap();

        let config_file = temp_dir.path().join("test.ini");
        let ini_content = r"
[upload]
enable_upload = true
max_upload_size = 2GB
";

        fs::write(&config_file, ini_content).unwrap();

        let mut cli = create_test_cli(temp_dir.path().to_path_buf());
        cli.config_file = Some(config_file.to_string_lossy().to_string());

        let config = Config::load(&cli).unwrap();

        assert!(config.enable_upload);
        assert_eq!(config.max_upload_size, 2 * 1024 * 1024 * 1024);
    }

    #[test]
    fn test_config_max_upload_size_formats() {
        let temp_dir = TempDir::new().unwrap();
        let config_file = temp_dir.path().join("test.ini");

        // Temporarily move any irondrop.ini in current directory to avoid interference
        let current_config = PathBuf::from("irondrop.ini");
        let backup_config = PathBuf::from("irondrop.ini.backup");
        let config_existed = if current_config.exists() {
            std::fs::rename(&current_config, &backup_config).ok();
            true
        } else {
            false
        };

        let ini_content = r"
[upload]
max_upload_size = 1.5GB
";

        fs::write(&config_file, ini_content).unwrap();

        let mut cli = create_test_cli(temp_dir.path().to_path_buf());
        cli.config_file = Some(config_file.to_string_lossy().to_string());
        // Don't set CLI max_upload_size so INI takes precedence
        cli.max_upload_size = None;

        let config = Config::load(&cli).unwrap();

        // 1.5GB should be converted to bytes
        assert_eq!(
            config.max_upload_size,
            (1.5 * 1024.0 * 1024.0 * 1024.0) as u64
        );

        // Restore the config file if it existed
        if config_existed {
            std::fs::rename(&backup_config, &current_config).ok();
        }
    }

    #[test]
    fn test_config_print_summary() {
        let temp_dir = TempDir::new().unwrap();
        let cli = create_test_cli(temp_dir.path().to_path_buf());
        let config = Config::load(&cli).unwrap();

        // This should not panic
        config.print_summary();
    }

    #[test]
    fn test_config_directory_always_from_cli() {
        let temp_dir = TempDir::new().unwrap();
        let config_file = temp_dir.path().join("test.ini");

        // Even if INI has directory, CLI should always win (since it's required)
        let ini_content = r"
[server]
directory = /some/other/path
";
        fs::write(&config_file, ini_content).unwrap();

        let mut cli = create_test_cli(temp_dir.path().to_path_buf());
        cli.config_file = Some(config_file.to_string_lossy().to_string());

        let config = Config::load(&cli).unwrap();

        // Directory should always come from CLI
        assert_eq!(config.directory, temp_dir.path());
    }
}