iris-chat 0.1.57

Iris Chat command line client and shared encrypted chat core
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
struct ChatReadSyncPair {
    owner: Keys,
    a_device: Keys,
    b_device: Keys,
    a: AppCore,
    b: AppCore,
    a_dir: tempfile::TempDir,
    _b_dir: tempfile::TempDir,
}

#[test]
fn chat_read_exact_ids_preserve_older_unseen_and_late_messages() {
    let mut pair = chat_read_sync_pair("exact-read-gaps");
    let peer = Keys::generate();
    let chat = peer.public_key().to_hex();
    for core in [&mut pair.a, &mut pair.b] {
        chat_read_sync_incoming(core, &peer, "older-unseen", 100);
        chat_read_sync_incoming(core, &peer, "actually-seen", 200);
    }
    pair.a.mark_messages_seen(&chat, &["actually-seen".into()]);
    assert_chat_read_delivery(&pair.a, &chat, "older-unseen", false);
    sync_chat_reads(&pair.a, &mut pair.b, &pair.a_device, false);
    assert_chat_read_delivery(&pair.b, &chat, "older-unseen", false);
    for core in [&mut pair.a, &mut pair.b] {
        chat_read_sync_incoming(core, &peer, "late-older-unseen", 150);
        assert_chat_read_delivery(core, &chat, "late-older-unseen", false);
        assert_chat_read_delivery(core, &chat, "actually-seen", true);
        assert_eq!(core.threads[&chat].unread_count, 2);
    }
}

fn chat_read_sync_pair(label: &str) -> ChatReadSyncPair {
    let owner = Keys::generate();
    let a_device = Keys::generate();
    let b_device = Keys::generate();
    let (mut a, _, a_dir) =
        logged_in_test_core_with_updates(&format!("{label}-a"), &owner, &a_device);
    let (mut b, _, b_dir) =
        logged_in_test_core_with_updates(&format!("{label}-b"), &owner, &b_device);
    configure_test_device_sync_profile(&mut a, &owner, &a_device, &b_device, None);
    configure_test_device_sync_profile(&mut b, &owner, &b_device, &a_device, None);
    a.preferences.send_read_receipts = false;
    b.preferences.send_read_receipts = false;
    ChatReadSyncPair {
        owner,
        a_device,
        b_device,
        a,
        b,
        a_dir,
        _b_dir: b_dir,
    }
}

fn chat_read_sync_incoming(core: &mut AppCore, peer: &Keys, id: &str, created_at: u64) {
    core.apply_runtime_text_message(
        peer.public_key(),
        None,
        id.to_string(),
        created_at,
        None,
        Some(id.to_string()),
        None,
    );
}

fn deliver_chat_read_packets(receiver: &mut AppCore, sender: &Keys, packets: &[Vec<u8>]) {
    for packet in packets {
        receiver.handle_device_sync_packet(&sender.public_key().to_hex(), DEVICE_SYNC_PORT, packet);
    }
}

fn sync_chat_reads(sender: &AppCore, receiver: &mut AppCore, device: &Keys, history: bool) {
    deliver_chat_read_packets(
        receiver,
        device,
        &sender.build_device_sync_packets_for_test(100, history),
    );
}

fn assert_chat_read_delivery(core: &AppCore, chat_id: &str, id: &str, seen: bool) {
    let message = core.threads[chat_id]
        .messages
        .iter()
        .find(|message| message.id == id)
        .expect("expected message");
    assert_eq!(
        matches!(message.delivery, DeliveryState::Seen),
        seen,
        "message {id} delivery: {:?}",
        message.delivery
    );
}

#[test]
fn chat_read_sync_clears_sibling_unread_without_peer_receipts() {
    let mut pair = chat_read_sync_pair("read-sync-disabled-receipts");
    let peer = Keys::generate();
    let chat_id = peer.public_key().to_hex();
    chat_read_sync_incoming(&mut pair.a, &peer, "read-on-a", 200);
    sync_chat_reads(&pair.a, &mut pair.b, &pair.a_device, true);
    assert_eq!(pair.b.threads[&chat_id].unread_count, 1);
    assert_chat_read_delivery(&pair.b, &chat_id, "read-on-a", false);

    pair.a
        .mark_messages_seen(&chat_id, &["read-on-a".to_string()]);
    let packets = pair.a.build_device_sync_packets_for_test(100, true);
    deliver_chat_read_packets(&mut pair.b, &Keys::generate(), &packets);
    assert_eq!(pair.b.threads[&chat_id].unread_count, 1);
    assert!(!pair.b.chat_read_states.contains_key(&chat_id));
    deliver_chat_read_packets(&mut pair.b, &pair.a_device, &packets);

    assert_eq!(pair.b.threads[&chat_id].unread_count, 0);
    assert_chat_read_delivery(&pair.b, &chat_id, "read-on-a", true);
    assert_eq!(protocol_send_log_count(&pair.a, "receipt"), 0);
    assert_eq!(protocol_send_log_count(&pair.b, "receipt"), 0);
    assert!(pair.a.pending_outgoing_receipts.is_empty());
    assert!(pair.b.pending_outgoing_receipts.is_empty());
}

#[test]
fn chat_read_sync_clears_group_unread_without_peer_receipts() {
    let mut pair = chat_read_sync_pair("read-sync-group");
    let peer = Keys::generate();
    let peer_device = Keys::generate();
    let group_id = "read-sync-friends".to_string();
    let chat_id = group_chat_id(&group_id);
    let (body, id) = runtime_rumor_json(
        peer.public_key(),
        CHAT_MESSAGE_KIND,
        "read this group message",
        200,
        vec![vec!["l".to_string(), group_id.clone()]],
    );
    pair.a
        .apply_group_decrypted_event(GroupIncomingEvent::Message(
            nostr_double_ratchet::GroupReceivedMessage {
                group_id,
                sender_owner: ndr_owner_pubkey(peer.public_key()),
                sender_device: Some(ndr_device_pubkey(peer_device.public_key())),
                body: body.into_bytes(),
                revision: 1,
            },
        ));
    sync_chat_reads(&pair.a, &mut pair.b, &pair.a_device, true);
    assert_eq!(pair.b.threads[&chat_id].unread_count, 1);

    pair.a
        .mark_messages_seen(&chat_id, std::slice::from_ref(&id));
    sync_chat_reads(&pair.a, &mut pair.b, &pair.a_device, true);

    assert_eq!(pair.b.threads[&chat_id].unread_count, 0);
    assert_chat_read_delivery(&pair.b, &chat_id, &id, true);
    assert!(pair.a.pending_outgoing_receipts.is_empty());
    assert!(pair.b.pending_outgoing_receipts.is_empty());
}

#[test]
fn chat_read_sync_opening_an_already_seen_chat_clears_sibling_badge_after_upgrade() {
    let mut pair = chat_read_sync_pair("read-sync-open-upgrade");
    let peer = Keys::generate();
    let chat_id = peer.public_key().to_hex();
    chat_read_sync_incoming(&mut pair.a, &peer, "seen-before-upgrade", 200);
    sync_chat_reads(&pair.a, &mut pair.b, &pair.a_device, true);
    let thread = pair.a.threads.get_mut(&chat_id).unwrap();
    thread.messages[0].delivery = DeliveryState::Seen;
    thread.unread_count = 0;
    pair.a.persist_best_effort();
    assert!(!pair.a.chat_read_states.contains_key(&chat_id));
    assert_eq!(pair.b.threads[&chat_id].unread_count, 1);

    pair.a.handle_action(AppAction::OpenChat {
        chat_id: chat_id.clone(),
    });
    pair.a.open_chat_finalize(&chat_id);
    sync_chat_reads(&pair.a, &mut pair.b, &pair.a_device, true);

    assert!(pair.a.chat_read_states.contains_key(&chat_id));
    assert_eq!(pair.b.threads[&chat_id].unread_count, 0);
    assert_chat_read_delivery(&pair.b, &chat_id, "seen-before-upgrade", true);
}

#[test]
fn chat_read_sync_manual_mark_read_syncs_but_mark_unread_stays_local() {
    let mut pair = chat_read_sync_pair("read-sync-manual");
    let peer = Keys::generate();
    let chat_id = peer.public_key().to_hex();
    chat_read_sync_incoming(&mut pair.a, &peer, "manual-read", 200);
    sync_chat_reads(&pair.a, &mut pair.b, &pair.a_device, true);

    pair.a.handle_action(AppAction::SetChatUnread {
        chat_id: chat_id.clone(),
        unread: false,
    });
    sync_chat_reads(&pair.a, &mut pair.b, &pair.a_device, true);
    assert_eq!(pair.b.threads[&chat_id].unread_count, 0);
    assert_chat_read_delivery(&pair.b, &chat_id, "manual-read", true);

    let read_state = pair.a.chat_read_states[&chat_id].clone();
    pair.a.handle_action(AppAction::SetChatUnread {
        chat_id: chat_id.clone(),
        unread: true,
    });
    sync_chat_reads(&pair.a, &mut pair.b, &pair.a_device, true);
    assert_eq!(pair.a.threads[&chat_id].unread_count, 1);
    assert_eq!(pair.b.threads[&chat_id].unread_count, 0);
    assert_eq!(pair.a.chat_read_states[&chat_id], read_state);
    assert_chat_read_delivery(&pair.a, &chat_id, "manual-read", true);
}

#[test]
fn chat_read_sync_preserves_newer_and_unlisted_same_second_messages() {
    let mut pair = chat_read_sync_pair("read-sync-boundary");
    let peer = Keys::generate();
    let chat_id = peer.public_key().to_hex();
    chat_read_sync_incoming(&mut pair.a, &peer, "read-boundary", 200);
    sync_chat_reads(&pair.a, &mut pair.b, &pair.a_device, true);
    chat_read_sync_incoming(&mut pair.b, &peer, "unlisted-boundary", 200);
    chat_read_sync_incoming(&mut pair.b, &peer, "newer-unseen", 201);
    assert_eq!(pair.b.threads[&chat_id].unread_count, 3);

    pair.a
        .mark_messages_seen(&chat_id, &["read-boundary".to_string()]);
    sync_chat_reads(&pair.a, &mut pair.b, &pair.a_device, true);

    assert_eq!(pair.b.threads[&chat_id].unread_count, 2);
    assert_chat_read_delivery(&pair.b, &chat_id, "read-boundary", true);
    assert_chat_read_delivery(&pair.b, &chat_id, "unlisted-boundary", false);
    assert_chat_read_delivery(&pair.b, &chat_id, "newer-unseen", false);
}

#[test]
fn chat_read_sync_does_not_recount_old_history_or_clear_newer_unread() {
    let mut pair = chat_read_sync_pair("read-sync-legacy-count");
    let peer = Keys::generate();
    let chat_id = peer.public_key().to_hex();
    chat_read_sync_incoming(&mut pair.a, &peer, "legacy-first", 197);
    chat_read_sync_incoming(&mut pair.a, &peer, "legacy-boundary", 200);
    sync_chat_reads(&pair.a, &mut pair.b, &pair.a_device, true);
    chat_read_sync_incoming(&mut pair.b, &peer, "legacy-middle-a", 198);
    chat_read_sync_incoming(&mut pair.b, &peer, "legacy-middle-b", 199);
    // Older builds could clear a badge while stored deliveries remained
    // Received. Those messages must not be counted as newly unread again.
    pair.b.threads.get_mut(&chat_id).unwrap().unread_count = 0;
    chat_read_sync_incoming(&mut pair.b, &peer, "same-second-unread", 200);
    chat_read_sync_incoming(&mut pair.b, &peer, "newer-unread", 201);
    assert_eq!(pair.b.threads[&chat_id].unread_count, 2);

    pair.a
        .mark_messages_seen(&chat_id, &["legacy-first".to_string()]);
    sync_chat_reads(&pair.a, &mut pair.b, &pair.a_device, true);
    assert_eq!(pair.b.threads[&chat_id].unread_count, 2);
    assert_chat_read_delivery(&pair.b, &chat_id, "legacy-middle-a", false);

    pair.a
        .mark_messages_seen(&chat_id, &["legacy-boundary".to_string()]);
    sync_chat_reads(&pair.a, &mut pair.b, &pair.a_device, true);
    assert_eq!(pair.b.threads[&chat_id].unread_count, 2);
    assert_chat_read_delivery(&pair.b, &chat_id, "legacy-boundary", true);
    assert_chat_read_delivery(&pair.b, &chat_id, "same-second-unread", false);
    assert_chat_read_delivery(&pair.b, &chat_id, "newer-unread", false);
}

#[test]
fn chat_read_sync_stale_and_repeated_snapshots_preserve_later_local_unread() {
    let mut pair = chat_read_sync_pair("read-sync-stale");
    let peer = Keys::generate();
    let chat_id = peer.public_key().to_hex();
    chat_read_sync_incoming(&mut pair.a, &peer, "first-read", 200);
    pair.a
        .mark_messages_seen(&chat_id, &["first-read".to_string()]);
    let older = pair.a.build_device_sync_packets_for_test(100, true);
    deliver_chat_read_packets(&mut pair.b, &pair.a_device, &older);
    chat_read_sync_incoming(&mut pair.a, &peer, "second-read", 201);
    pair.a
        .mark_messages_seen(&chat_id, &["second-read".to_string()]);
    let latest = pair.a.build_device_sync_packets_for_test(100, true);
    deliver_chat_read_packets(&mut pair.b, &pair.a_device, &latest);
    assert_eq!(pair.b.threads[&chat_id].unread_count, 0);

    pair.b.handle_action(AppAction::SetChatUnread {
        chat_id: chat_id.clone(),
        unread: true,
    });
    for packets in [&older, &latest, &latest] {
        deliver_chat_read_packets(&mut pair.b, &pair.a_device, packets);
    }
    assert_eq!(pair.b.threads[&chat_id].unread_count, 1);
    assert_chat_read_delivery(&pair.b, &chat_id, "second-read", true);

    chat_read_sync_incoming(&mut pair.b, &peer, "later-unseen", 202);
    let unread_before_replay = pair.b.threads[&chat_id].unread_count;
    for packets in [&older, &latest] {
        deliver_chat_read_packets(&mut pair.b, &pair.a_device, packets);
    }
    assert_eq!(pair.b.threads[&chat_id].unread_count, unread_before_replay);
    assert_chat_read_delivery(&pair.b, &chat_id, "later-unseen", false);
}

#[test]
fn chat_read_sync_before_message_prevents_delayed_history_becoming_unread() {
    let mut pair = chat_read_sync_pair("read-sync-before-message");
    let peer = Keys::generate();
    let chat_id = peer.public_key().to_hex();
    chat_read_sync_incoming(&mut pair.a, &peer, "boundary-read", 200);
    pair.a
        .mark_messages_seen(&chat_id, &["boundary-read".to_string()]);
    sync_chat_reads(&pair.a, &mut pair.b, &pair.a_device, false);
    assert!(pair.b.threads[&chat_id].messages.is_empty());
    assert!(pair.b.chat_read_states.contains_key(&chat_id));

    chat_read_sync_incoming(&mut pair.b, &peer, "delayed-older", 199);
    chat_read_sync_incoming(&mut pair.b, &peer, "boundary-read", 200);
    assert_eq!(pair.b.threads[&chat_id].unread_count, 1);
    assert_chat_read_delivery(&pair.b, &chat_id, "delayed-older", false);
    assert_chat_read_delivery(&pair.b, &chat_id, "boundary-read", true);

    chat_read_sync_incoming(&mut pair.b, &peer, "unlisted-same-second", 200);
    assert_eq!(pair.b.threads[&chat_id].unread_count, 2);
    assert_chat_read_delivery(&pair.b, &chat_id, "unlisted-same-second", false);
}

#[test]
fn chat_read_sync_survives_restart_and_catches_up_an_offline_sibling() {
    let mut pair = chat_read_sync_pair("read-sync-restart");
    let peer = Keys::generate();
    let chat_id = peer.public_key().to_hex();
    chat_read_sync_incoming(&mut pair.a, &peer, "read-while-offline", 200);
    sync_chat_reads(&pair.a, &mut pair.b, &pair.a_device, true);
    pair.a
        .mark_messages_seen(&chat_id, &["read-while-offline".to_string()]);
    assert_eq!(pair.b.threads[&chat_id].unread_count, 1);
    let expected_state = pair.a.chat_read_states[&chat_id].clone();
    drop(pair.a);

    let mut restarted = logged_in_test_core_at_data_dir(
        &pair.owner,
        &pair.a_device,
        pair.a_dir.path().to_string_lossy().into_owned(),
    );
    let persisted = restarted.load_persisted().unwrap().unwrap();
    assert_eq!(restarted.chat_read_states[&chat_id], expected_state);
    let persisted_thread = persisted
        .threads
        .iter()
        .find(|thread| thread.chat_id == chat_id)
        .unwrap();
    assert_eq!(persisted_thread.unread_count, 0);
    assert!(persisted_thread.messages.iter().any(|message| {
        message.id == "read-while-offline"
            && matches!(message.delivery, PersistedDeliveryState::Seen)
    }));
    configure_test_device_sync_profile(
        &mut restarted,
        &pair.owner,
        &pair.a_device,
        &pair.b_device,
        None,
    );
    // The fixture does not restore the full session; supply the known chat's
    // metadata while history still comes from the persisted database.
    restarted.ensure_thread_record(&chat_id, 200);
    sync_chat_reads(&restarted, &mut pair.b, &pair.a_device, true);
    assert_eq!(pair.b.threads[&chat_id].unread_count, 0);
    assert_chat_read_delivery(&pair.b, &chat_id, "read-while-offline", true);

    let stored = pair
        .b
        .app_store
        .load_thread(&chat_id, 100)
        .unwrap()
        .unwrap();
    assert_eq!(stored.unread_count, 0);
    assert!(stored
        .messages
        .iter()
        .all(|message| matches!(message.delivery, PersistedDeliveryState::Seen)));
}

#[test]
fn chat_read_sync_clears_badge_behind_own_replies_after_receiver_restart() {
    for keep_unseen in [false, true] {
        let mut pair = chat_read_sync_pair("read-sync-own-preview");
        let peer = Keys::generate();
        let chat = peer.public_key().to_hex();
        if keep_unseen {
            chat_read_sync_incoming(&mut pair.a, &peer, "not-viewed", 199);
        }
        chat_read_sync_incoming(&mut pair.a, &peer, "viewed-on-sibling", 200);
        sync_chat_reads(&pair.a, &mut pair.b, &pair.a_device, true);
        let unread_before = 1 + u64::from(keep_unseen);
        assert_eq!(pair.b.threads[&chat].unread_count, unread_before);

        pair.a
            .mark_messages_seen(&chat, &["viewed-on-sibling".into()]);
        for (id, time) in [("first-own-reply", 201), ("latest-own-reply", 202)] {
            pair.a.push_outgoing_message_with_id(
                id.into(),
                &chat,
                "Reply from another device".into(),
                time,
                None,
                DeliveryState::Sent,
            );
        }
        // Replies can arrive while the read update is missed. Their preview
        // must neither add unread messages nor imply that older ones were read.
        for bytes in pair.a.build_device_sync_packets_for_test(100, true) {
            let mut packet: serde_json::Value = serde_json::from_slice(&bytes).unwrap();
            if packet["type"] == "snapshot" {
                for chat in packet["chats"].as_array_mut().into_iter().flatten() {
                    chat.as_object_mut().unwrap().remove("readState");
                }
            }
            deliver_chat_read_packets(
                &mut pair.b,
                &pair.a_device,
                &[serde_json::to_vec(&packet).unwrap()],
            );
        }
        assert_eq!(pair.b.threads[&chat].unread_count, unread_before);
        let latest = pair.b.threads[&chat].messages.last().unwrap();
        assert_eq!(latest.id, "latest-own-reply");
        assert!(latest.is_outgoing);
        pair.b.persist_best_effort_inner();
        drop(pair.b);

        let mut receiver = logged_in_test_core_at_data_dir(
            &pair.owner,
            &pair.b_device,
            pair._b_dir.path().to_string_lossy().into_owned(),
        );
        let persisted = receiver.load_persisted().unwrap().unwrap();
        let preview = persisted
            .threads
            .iter()
            .find(|t| t.chat_id == chat)
            .unwrap();
        assert_eq!(preview.messages.len(), 1);
        assert_eq!(preview.messages[0].id, "latest-own-reply");
        // Restore the inactive chat exactly as account restoration does: only
        // the outgoing preview is loaded; unread incoming rows remain on disk.
        receiver.threads.insert(
            chat.clone(),
            ThreadRecord {
                chat_id: chat.clone(),
                unread_count: preview.unread_count,
                updated_at_secs: preview.updated_at_secs,
                messages: preview
                    .messages
                    .iter()
                    .map(super::chats::chat_message_from_persisted)
                    .collect(),
                draft: preview.draft.clone(),
            },
        );
        configure_test_device_sync_profile(
            &mut receiver,
            &pair.owner,
            &pair.b_device,
            &pair.a_device,
            None,
        );
        sync_chat_reads(&pair.a, &mut receiver, &pair.a_device, false);
        let expected_unread = u64::from(keep_unseen);
        assert_eq!(receiver.threads[&chat].unread_count, expected_unread);
        assert_eq!(receiver.threads[&chat].messages.len(), 1);
        let stored = receiver.app_store.load_thread(&chat, 100).unwrap().unwrap();
        assert_eq!(stored.unread_count, expected_unread);
        for message in &stored.messages {
            assert_eq!(
                matches!(message.delivery, PersistedDeliveryState::Seen),
                message.id == "viewed-on-sibling",
                "own-device reads must not change recipient receipts or unseen incoming rows"
            );
        }
    }
}

#[test]
fn chat_read_sync_merges_device_alias_progress_without_reviving_old_chat() {
    let mut pair = chat_read_sync_pair("read-sync-alias");
    let peer = Keys::generate();
    let peer_device = Keys::generate();
    let owner_id = peer.public_key().to_hex();
    let alias_id = peer_device.public_key().to_hex();
    chat_read_sync_incoming(&mut pair.a, &peer_device, "alias-read", 200);
    pair.a
        .mark_messages_seen(&alias_id, &["alias-read".to_string()]);
    chat_read_sync_incoming(&mut pair.a, &peer, "owner-read", 201);
    pair.a
        .mark_messages_seen(&owner_id, &["owner-read".to_string()]);
    let mut expected = pair.a.chat_read_states[&owner_id].clone();
    expected
        .seen_messages
        .extend(pair.a.chat_read_states[&alias_id].exact_messages());
    let devices = AppKeys::new(vec![DeviceEntry::new(peer_device.public_key(), 1)]);
    pair.a
        .migrate_verified_device_owner_threads(peer.public_key(), &devices);
    assert!(!pair.a.threads.contains_key(&alias_id));
    assert!(!pair.a.chat_read_states.contains_key(&alias_id));
    assert!(!pair
        .a
        .app_store
        .load_chat_read_states()
        .unwrap()
        .contains_key(&alias_id));
    assert_eq!(pair.a.chat_read_states[&owner_id], expected);
    let packets = pair.a.build_device_sync_packets_for_test(100, false);
    deliver_chat_read_packets(&mut pair.b, &pair.a_device, &packets);
    assert!(!pair.b.threads.contains_key(&alias_id));
    assert_eq!(pair.b.chat_read_states[&owner_id], expected);
}

#[test]
fn chat_read_explicit_seen_updates_stored_message_without_changing_visible_history() {
    for batched in [false, true] {
        let mut pair = chat_read_sync_pair("passive-seen-stored");
        let peer = Keys::generate();
        let chat_id = peer.public_key().to_hex();
        chat_read_sync_incoming(&mut pair.a, &peer, "requested", 200);
        chat_read_sync_incoming(&mut pair.a, &peer, "same-second-unread", 200);
        chat_read_sync_incoming(&mut pair.a, &peer, "still-unread", 201);
        pair.a.persist_best_effort();
        assert_eq!(pair.a.threads[&chat_id].unread_count, 3);
        // An inactive conversation restores only its latest message into memory.
        pair.a
            .threads
            .get_mut(&chat_id)
            .unwrap()
            .messages
            .retain(|message| message.id == "still-unread");
        assert!(!pair.a.is_chat_visible(&chat_id));
        if batched {
            pair.a.enter_batch();
        }
        pair.a
            .mark_messages_seen(&chat_id, &["requested".to_string()]);
        if batched {
            pair.a.exit_batch();
        }
        let thread = &pair.a.threads[&chat_id];
        assert_eq!(thread.messages.len(), 1);
        assert_eq!(thread.messages[0].id, "still-unread");
        assert_chat_read_delivery(&pair.a, &chat_id, "still-unread", false);
        assert_eq!(thread.unread_count, 2);
        assert!(!pair.a.is_chat_visible(&chat_id));

        let assert_stored_read_state = |core: &AppCore| {
            let stored = core.app_store.load_thread(&chat_id, 10).unwrap().unwrap();
            assert_eq!(stored.unread_count, 2);
            assert_eq!(stored.messages.len(), 3);
            for (id, seen) in [
                ("requested", true),
                ("same-second-unread", false),
                ("still-unread", false),
            ] {
                let message = stored
                    .messages
                    .iter()
                    .find(|message| message.id == id)
                    .unwrap();
                assert_eq!(
                    matches!(message.delivery, PersistedDeliveryState::Seen),
                    seen,
                    "stored message {id}; batched={batched}"
                );
            }
        };
        assert_stored_read_state(&pair.a);
        let expected_read_state = pair.a.chat_read_states[&chat_id].clone();
        drop(pair.a);
        let mut restarted = logged_in_test_core_at_data_dir(
            &pair.owner,
            &pair.a_device,
            pair.a_dir.path().to_string_lossy().into_owned(),
        );
        restarted.load_persisted().unwrap().unwrap();
        assert_eq!(restarted.chat_read_states[&chat_id], expected_read_state);
        assert_stored_read_state(&restarted);
    }
}