iris-chat-protocol 0.3.13

Reusable Iris Chat double-ratchet protocol engine
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
fn legacy_group_ingress_fixture() -> (ProtocolEngine, String) {
    let (mut engine, request) = repair_retry_fixture();
    // Include actual session secrets as well as group chain keys, so an archive
    // regression cannot silently retain keys merely absent from the fixture.
    let pending = std::mem::take(&mut engine.pending_group_sender_key_messages);
    assert!(synthetic_pending_inbound(&mut engine, 0, 0, 100).is_empty());
    engine.pending_group_sender_key_messages = pending;
    engine
        .sender_key_repair_request_effects(request, NdrUnixSeconds(100))
        .unwrap();
    for (index, body) in ["user message", "metadata", "private wake", "distribution"]
        .into_iter()
        .enumerate()
    {
        engine
            .pending_group_fanouts
            .push(pending_local_group_fanout(
                "queued-group",
                Some(&format!("outgoing-{index}")),
                body.as_bytes(),
                100,
            ));
    }
    for (event_id, content) in [
        ("ordinary-direct-delivery", "retain ordinary DM journal"),
        (
            "group-delivery:legacy",
            "preserve unproven group journal bytes",
        ),
    ] {
        engine
            .pending_decrypted_deliveries
            .push(ProtocolPendingDecryptedDelivery {
                discarded: false,
                sender: engine.owner_pubkey,
                sender_device: Some(public_device(engine.local_device).unwrap()),
                conversation_owner: None,
                content: content.into(),
                event_id: Some(event_id.into()),
                created_at_secs: 100,
            });
    }
    engine.persist_now().unwrap();
    let current = engine
        .storage
        .get(PROTOCOL_ENGINE_STATE_KEY)
        .unwrap()
        .unwrap();
    let marker = ",\"group_ingress_provenance_version\":1";
    assert_eq!(current.matches(marker).count(), 1);
    let raw = current
        .replace(marker, "")
        .replace(
            "\"pending_group_sender_key_messages\":[",
            "\"pending_group_sender_key_messages\":[\n ",
        )
        .replace("group-delivery:legacy", "group\\u002ddelivery:legacy");
    engine
        .storage
        .put(PROTOCOL_ENGINE_STATE_KEY, raw.clone())
        .unwrap();
    (engine, raw)
}

fn reload_group_ingress(
    engine: &ProtocolEngine,
    storage: Arc<dyn StorageAdapter>,
) -> anyhow::Result<ProtocolEngine> {
    let device = Keys::new(nostr::SecretKey::from_slice(&engine.local_device_secret).unwrap());
    ProtocolEngine::load_or_create_for_local_device(storage, engine.owner_pubkey, &device)
}

fn assert_legacy_group_ingress_archive(storage: &dyn StorageAdapter, original: &str) -> String {
    assert_legacy_group_ingress_archive_at(storage, original, LEGACY_GROUP_INGRESS_QUARANTINE_KEY)
}

fn assert_legacy_group_ingress_archive_at(
    storage: &dyn StorageAdapter,
    original: &str,
    key: &str,
) -> String {
    use serde_json::value::RawValue;
    let archive = storage.get(key).unwrap().unwrap();
    let before: BTreeMap<String, Box<RawValue>> = serde_json::from_str(original).unwrap();
    let after: BTreeMap<String, Box<RawValue>> = serde_json::from_str(&archive).unwrap();
    assert_eq!(
        after.keys().map(String::as_str).collect::<Vec<_>>(),
        vec![
            "pending_decrypted_deliveries",
            "pending_group_sender_key_messages",
            "pending_group_sender_key_repairs",
        ]
    );
    for field in [
        "pending_group_sender_key_messages",
        "pending_group_sender_key_repairs",
    ] {
        assert_eq!(
            after[field].get(),
            before.get(field).map_or("[]", |value| value.get()),
            "removed queue encoding changed: {field}"
        );
    }
    let original_journal: Vec<Box<RawValue>> = serde_json::from_str(
        before
            .get("pending_decrypted_deliveries")
            .map_or("[]", |value| value.get()),
    )
    .unwrap();
    let removed = original_journal
        .iter()
        .filter(|entry| {
            let value: serde_json::Value = serde_json::from_str(entry.get()).unwrap();
            value["event_id"]
                .as_str()
                .is_some_and(|id| id.starts_with("group-delivery:"))
        })
        .map(|entry| entry.get())
        .collect::<Vec<_>>();
    let retained: Vec<Box<RawValue>> =
        serde_json::from_str(after["pending_decrypted_deliveries"].get()).unwrap();
    assert_eq!(
        retained.iter().map(|entry| entry.get()).collect::<Vec<_>>(),
        removed,
        "only synthetic journal items should be retained, in their original encoding"
    );
    archive
}

#[test]
fn legacy_group_ingress_is_quarantined_once_without_retiring_outgoing_work() {
    let (engine, raw) = legacy_group_ingress_fixture();
    let before: serde_json::Value = serde_json::from_str(&raw).unwrap();
    let mut restored = reload_group_ingress(&engine, engine.storage.clone()).unwrap();
    let archive = assert_legacy_group_ingress_archive(engine.storage.as_ref(), &raw);
    let sessions = engine.session_manager.snapshot();
    let session = sessions
        .users
        .iter()
        .flat_map(|user| &user.devices)
        .find_map(|device| device.active_session.as_ref())
        .expect("fixture contains a real ratchet session");
    for secret in [session.root_key, session.our_next_nostr_key.private_key]
        .into_iter()
        .chain(session.receiving_chain_key)
        .chain(session.sending_chain_key)
    {
        use std::fmt::Write;
        let mut encoded = String::with_capacity(secret.len() * 2);
        for byte in secret {
            write!(&mut encoded, "{byte:02x}").unwrap();
        }
        assert!(
            raw.contains(&encoded),
            "fixture must contain session secrets"
        );
        assert!(
            !archive.contains(&encoded),
            "quarantine retained a session secret"
        );
    }
    let group_chain_key = before["group_manager"]["sender_keys"][0]["states"][0]["chain_key"]
        .as_str()
        .expect("fixture contains a real group chain key");
    assert!(
        !archive.contains(group_chain_key),
        "quarantine retained a group key"
    );
    assert!(restored.pending_group_sender_key_messages.is_empty());
    assert!(restored.pending_group_sender_key_repairs.is_empty());
    assert_eq!(restored.pending_decrypted_deliveries.len(), 1);
    assert_eq!(
        restored.pending_decrypted_deliveries[0].content,
        "retain ordinary DM journal"
    );
    assert!(restored
        .pending_group_decrypted_delivery("group-delivery:legacy")
        .is_err());
    let after: serde_json::Value = serde_json::from_str(
        &restored
            .storage
            .get(PROTOCOL_ENGINE_STATE_KEY)
            .unwrap()
            .unwrap(),
    )
    .unwrap();
    for field in [
        "session_manager",
        "group_manager",
        "pending_group_fanouts",
        "ready_group_publications",
        "pending_remote_sends",
        "pending_local_sibling_sends",
        "pending_group_pairwise_payloads",
        "group_roster_fact_histories",
        "processed_group_sender_key_messages",
    ] {
        assert_eq!(after[field], before[field], "migration changed {field}");
    }
    assert_eq!(after["group_ingress_provenance_version"], 1);
    assert!(restored
        .retry_pending_group_sender_key_repairs(NdrUnixSeconds(u64::MAX))
        .unwrap()
        .is_empty());
    let again = reload_group_ingress(&restored, restored.storage.clone()).unwrap();
    assert_eq!(again.pending_group_fanouts, restored.pending_group_fanouts);
    assert_eq!(
        again.pending_decrypted_deliveries,
        restored.pending_decrypted_deliveries
    );
    assert_eq!(
        assert_legacy_group_ingress_archive(again.storage.as_ref(), &raw),
        archive
    );
}

struct GroupIngressFailStorage {
    inner: Arc<dyn StorageAdapter>,
    fail_key: String,
    write_before_failure: bool,
}

impl StorageAdapter for GroupIngressFailStorage {
    fn get(&self, key: &str) -> StorageResult<Option<String>> {
        self.inner.get(key)
    }
    fn put(&self, key: &str, value: String) -> StorageResult<()> {
        if key == self.fail_key {
            if self.write_before_failure {
                self.inner.put(key, value)?;
            }
            return Err(StorageError::new("injected ingress migration failure"));
        }
        self.inner.put(key, value)
    }
    fn del(&self, key: &str) -> StorageResult<()> {
        self.inner.del(key)
    }
    fn list(&self, prefix: &str) -> StorageResult<Vec<String>> {
        self.inner.list(prefix)
    }
}

#[test]
fn legacy_group_ingress_migration_write_failures_preserve_the_original_and_retry() {
    for (fail_key, write_before_failure) in [
        (LEGACY_GROUP_INGRESS_QUARANTINE_KEY, false),
        (PROTOCOL_ENGINE_STATE_KEY, false),
        (LEGACY_GROUP_INGRESS_QUARANTINE_KEY, true),
    ] {
        let (engine, raw) = legacy_group_ingress_fixture();
        let failed = Arc::new(GroupIngressFailStorage {
            inner: engine.storage.clone(),
            fail_key: fail_key.into(),
            write_before_failure,
        });
        assert!(reload_group_ingress(&engine, failed.clone()).is_err());
        if write_before_failure {
            // A sync failure leaves matching bytes behind. Reopening must
            // retry preservation and fail again, not advance the checkpoint.
            assert!(reload_group_ingress(&engine, failed).is_err());
        }
        assert_eq!(
            engine
                .storage
                .get(PROTOCOL_ENGINE_STATE_KEY)
                .unwrap()
                .as_deref(),
            Some(raw.as_str())
        );
        let quarantine = engine
            .storage
            .get(LEGACY_GROUP_INGRESS_QUARANTINE_KEY)
            .unwrap();
        if fail_key == LEGACY_GROUP_INGRESS_QUARANTINE_KEY && !write_before_failure {
            assert!(quarantine.is_none());
        } else {
            assert_legacy_group_ingress_archive(engine.storage.as_ref(), &raw);
        }
        let restored = reload_group_ingress(&engine, engine.storage.clone()).unwrap();
        assert!(restored.pending_group_sender_key_messages.is_empty());
        assert!(restored.pending_group_sender_key_repairs.is_empty());
        assert_eq!(restored.pending_group_fanouts, engine.pending_group_fanouts);
        assert_legacy_group_ingress_archive(restored.storage.as_ref(), &raw);
    }
}

fn downgraded_group_ingress_fixture() -> (ProtocolEngine, String, String, String) {
    use nostr::hashes::{sha256, Hash};
    let (engine, original) = legacy_group_ingress_fixture();
    reload_group_ingress(&engine, engine.storage.clone()).unwrap();
    let first_archive = assert_legacy_group_ingress_archive(engine.storage.as_ref(), &original);
    // Simulate an older app writing its markerless state after new legacy
    // ingress arrives. The already preserved archive must remain untouched.
    let raw = original.replace(
        "preserve unproven group journal bytes",
        "preserve changed group journal bytes after downgrade",
    );
    assert_ne!(raw, original);
    engine
        .storage
        .put(PROTOCOL_ENGINE_STATE_KEY, raw.clone())
        .unwrap();
    let state = serde_json::from_str(&raw).unwrap();
    let next_archive = legacy_group_ingress_quarantine(&raw, &state).unwrap();
    let key = format!(
        "{LEGACY_GROUP_INGRESS_QUARANTINE_KEY}/{}",
        sha256::Hash::hash(next_archive.as_bytes())
    );
    (engine, raw, first_archive, key)
}

#[test]
fn legacy_group_ingress_downgrade_reupgrade_preserves_both_archives_and_is_idempotent() {
    let (engine, raw, first_archive, key) = downgraded_group_ingress_fixture();
    for _ in 0..2 {
        // Repeat the old-version write too, not just a current-version restart.
        engine
            .storage
            .put(PROTOCOL_ENGINE_STATE_KEY, raw.clone())
            .unwrap();
        let mut restored = reload_group_ingress(&engine, engine.storage.clone()).unwrap();
        assert_eq!(
            engine
                .storage
                .get(LEGACY_GROUP_INGRESS_QUARANTINE_KEY)
                .unwrap(),
            Some(first_archive.clone())
        );
        assert_legacy_group_ingress_archive_at(engine.storage.as_ref(), &raw, &key);
        assert_eq!(
            engine
                .storage
                .list(LEGACY_GROUP_INGRESS_QUARANTINE_KEY)
                .unwrap()
                .len(),
            2
        );
        assert!(restored.pending_group_sender_key_messages.is_empty());
        assert!(restored.pending_group_sender_key_repairs.is_empty());
        assert_eq!(restored.pending_decrypted_deliveries.len(), 1);
        assert_eq!(
            restored.pending_decrypted_deliveries[0].content,
            "retain ordinary DM journal"
        );
        assert_eq!(restored.pending_group_fanouts, engine.pending_group_fanouts);
        assert!(restored
            .pending_group_decrypted_delivery("group-delivery:legacy")
            .is_err());
        assert!(restored
            .retry_pending_group_sender_key_repairs(NdrUnixSeconds(u64::MAX))
            .unwrap()
            .is_empty());
        let again = reload_group_ingress(&restored, restored.storage.clone()).unwrap();
        assert!(again.pending_group_sender_key_messages.is_empty());
        assert_eq!(
            again
                .storage
                .list(LEGACY_GROUP_INGRESS_QUARANTINE_KEY)
                .unwrap()
                .len(),
            2
        );
        assert_legacy_group_ingress_archive_at(again.storage.as_ref(), &raw, &key);
    }
}

#[test]
fn legacy_group_ingress_additional_archive_failures_keep_state_and_retry_durably() {
    for (fail_checkpoint, write_before_failure) in [(false, false), (false, true), (true, false)] {
        let (engine, raw, first_archive, key) = downgraded_group_ingress_fixture();
        let failed = Arc::new(GroupIngressFailStorage {
            inner: engine.storage.clone(),
            fail_key: if fail_checkpoint {
                PROTOCOL_ENGINE_STATE_KEY.into()
            } else {
                key.clone()
            },
            write_before_failure,
        });
        assert!(reload_group_ingress(&engine, failed.clone()).is_err());
        // Matching archived bytes after a failed synchronization must not let
        // a retry bypass put_preserved and commit the cleared checkpoint.
        assert!(reload_group_ingress(&engine, failed).is_err());
        assert_eq!(
            engine.storage.get(PROTOCOL_ENGINE_STATE_KEY).unwrap(),
            Some(raw.clone())
        );
        assert_eq!(
            engine
                .storage
                .get(LEGACY_GROUP_INGRESS_QUARANTINE_KEY)
                .unwrap(),
            Some(first_archive.clone())
        );
        if !fail_checkpoint && !write_before_failure {
            assert!(engine.storage.get(&key).unwrap().is_none());
        } else {
            assert_legacy_group_ingress_archive_at(engine.storage.as_ref(), &raw, &key);
        }
        let restored = reload_group_ingress(&engine, engine.storage.clone()).unwrap();
        assert!(restored.pending_group_sender_key_messages.is_empty());
        assert!(restored.pending_group_sender_key_repairs.is_empty());
        assert_eq!(restored.pending_group_fanouts, engine.pending_group_fanouts);
        assert_eq!(
            engine
                .storage
                .get(LEGACY_GROUP_INGRESS_QUARANTINE_KEY)
                .unwrap(),
            Some(first_archive)
        );
        assert_legacy_group_ingress_archive_at(engine.storage.as_ref(), &raw, &key);
        assert_eq!(
            engine
                .storage
                .list(LEGACY_GROUP_INGRESS_QUARANTINE_KEY)
                .unwrap()
                .len(),
            2
        );
    }
}

#[test]
fn legacy_group_ingress_content_address_conflict_preserves_every_input() {
    let (engine, raw, first_archive, key) = downgraded_group_ingress_fixture();
    engine
        .storage
        .put(&key, "different preserved bytes".into())
        .unwrap();
    assert!(reload_group_ingress(&engine, engine.storage.clone()).is_err());
    assert_eq!(
        engine.storage.get(PROTOCOL_ENGINE_STATE_KEY).unwrap(),
        Some(raw)
    );
    assert_eq!(
        engine
            .storage
            .get(LEGACY_GROUP_INGRESS_QUARANTINE_KEY)
            .unwrap(),
        Some(first_archive)
    );
    assert_eq!(
        engine.storage.get(&key).unwrap().as_deref(),
        Some("different preserved bytes")
    );
}

#[test]
fn legacy_group_ingress_additional_archive_precedes_debounced_checkpoint() {
    let (engine, raw, first_archive, key) = downgraded_group_ingress_fixture();
    let directory = tempfile::tempdir().unwrap();
    let files = FileStorageAdapter::new(directory.path().to_owned()).unwrap();
    files.put(PROTOCOL_ENGINE_STATE_KEY, raw.clone()).unwrap();
    files
        .put(LEGACY_GROUP_INGRESS_QUARANTINE_KEY, first_archive.clone())
        .unwrap();
    let buffered =
        Arc::new(DebouncedFileStorage::new(directory.path().to_owned(), 60_000).unwrap());
    let restored = reload_group_ingress(&engine, buffered.clone()).unwrap();
    // Before the delayed checkpoint, both inert archives are durable and the
    // markerless input is still present. A fresh startup can safely repeat it.
    assert_eq!(
        files.get(PROTOCOL_ENGINE_STATE_KEY).unwrap(),
        Some(raw.clone())
    );
    assert_eq!(
        files.get(LEGACY_GROUP_INGRESS_QUARANTINE_KEY).unwrap(),
        Some(first_archive.clone())
    );
    assert_legacy_group_ingress_archive_at(&files, &raw, &key);
    drop(restored);
    drop(buffered);
    let buffered =
        Arc::new(DebouncedFileStorage::new(directory.path().to_owned(), 60_000).unwrap());
    let restored = reload_group_ingress(&engine, buffered.clone()).unwrap();
    buffered.flush().unwrap();
    assert!(restored.pending_group_sender_key_messages.is_empty());
    assert_eq!(
        files.get(LEGACY_GROUP_INGRESS_QUARANTINE_KEY).unwrap(),
        Some(first_archive)
    );
    assert_legacy_group_ingress_archive_at(&files, &raw, &key);
    assert_eq!(
        files
            .list(LEGACY_GROUP_INGRESS_QUARANTINE_KEY)
            .unwrap()
            .len(),
        2
    );
}

#[test]
fn legacy_group_ingress_future_version_still_fails_closed() {
    let (engine, original) = legacy_group_ingress_fixture();
    let mut state: serde_json::Value = serde_json::from_str(&original).unwrap();
    state["group_ingress_provenance_version"] = serde_json::json!(2);
    let raw = state.to_string();
    engine
        .storage
        .put(PROTOCOL_ENGINE_STATE_KEY, raw.clone())
        .unwrap();
    assert!(reload_group_ingress(&engine, engine.storage.clone()).is_err());
    assert_eq!(
        engine.storage.get(PROTOCOL_ENGINE_STATE_KEY).unwrap(),
        Some(raw)
    );
    assert!(engine
        .storage
        .list(LEGACY_GROUP_INGRESS_QUARANTINE_KEY)
        .unwrap()
        .is_empty());
}

#[test]
fn legacy_group_ingress_segmented_storage_and_outer_rollback_preserve_exact_bytes() {
    for checkpoint in [false, true] {
        let (engine, raw) = legacy_group_ingress_fixture();
        let connection = Arc::new(Mutex::new(rusqlite::Connection::open_in_memory().unwrap()));
        connection.lock().unwrap().execute_batch(
            "CREATE TABLE ndr_kv(owner_pubkey_hex TEXT NOT NULL,device_pubkey_hex TEXT NOT NULL,key TEXT NOT NULL,value TEXT NOT NULL,PRIMARY KEY(owner_pubkey_hex,device_pubkey_hex,key));"
        ).unwrap();
        let storage = Arc::new(SqliteStorageAdapter::new(
            connection.clone(),
            engine.owner_pubkey.to_hex(),
            engine.local_device.to_hex(),
        ));
        let raw = format!("{raw}{}", " ".repeat(128 * 1024));
        if checkpoint {
            let mut saved = StorageCheckpoint::new();
            saved.push_inline("legacy", raw.clone(), 0);
            storage
                .put_checkpoint(PROTOCOL_ENGINE_STATE_KEY, &saved)
                .unwrap();
        } else {
            storage.put(PROTOCOL_ENGINE_STATE_KEY, raw.clone()).unwrap();
        }
        connection
            .lock()
            .unwrap()
            .execute_batch("BEGIN IMMEDIATE")
            .unwrap();
        let restored = reload_group_ingress(&engine, storage.clone()).unwrap();
        assert!(restored.pending_group_sender_key_messages.is_empty());
        assert_legacy_group_ingress_archive(storage.as_ref(), &raw);
        connection
            .lock()
            .unwrap()
            .execute_batch("ROLLBACK")
            .unwrap();
        assert!(storage
            .get(LEGACY_GROUP_INGRESS_QUARANTINE_KEY)
            .unwrap()
            .is_none());
        assert_eq!(
            storage.get(PROTOCOL_ENGINE_STATE_KEY).unwrap().as_deref(),
            Some(raw.as_str())
        );
        let reopened = reload_group_ingress(&engine, storage.clone()).unwrap();
        assert_eq!(reopened.pending_group_fanouts, engine.pending_group_fanouts);
        assert!(reopened.pending_group_sender_key_repairs.is_empty());
        assert_legacy_group_ingress_archive(storage.as_ref(), &raw);
    }
}

#[test]
fn legacy_group_ingress_archive_precedes_debounced_state_checkpoint() {
    let (engine, raw) = legacy_group_ingress_fixture();
    let directory = tempfile::tempdir().unwrap();
    let files = FileStorageAdapter::new(directory.path().to_owned()).unwrap();
    files.put(PROTOCOL_ENGINE_STATE_KEY, raw.clone()).unwrap();
    let buffered =
        Arc::new(DebouncedFileStorage::new(directory.path().to_owned(), 60_000).unwrap());
    let restored = reload_group_ingress(&engine, buffered.clone()).unwrap();
    assert!(restored.pending_group_sender_key_messages.is_empty());
    // Simulate stopping before the buffered checkpoint: the old state and its
    // exact quarantine are already on disk, and the next startup can repeat.
    assert_eq!(
        files.get(PROTOCOL_ENGINE_STATE_KEY).unwrap().as_deref(),
        Some(raw.as_str())
    );
    assert_legacy_group_ingress_archive(&files, &raw);
    drop(restored);
    drop(buffered);
    let buffered =
        Arc::new(DebouncedFileStorage::new(directory.path().to_owned(), 60_000).unwrap());
    let restored = reload_group_ingress(&engine, buffered.clone()).unwrap();
    buffered.flush().unwrap();
    assert_legacy_group_ingress_archive(&files, &raw);
    let reopened = reload_group_ingress(&restored, Arc::new(files)).unwrap();
    assert!(reopened.pending_group_sender_key_messages.is_empty());
    assert_eq!(reopened.pending_group_fanouts, engine.pending_group_fanouts);
}

#[test]
fn authenticated_local_group_queue_and_delivery_journal_survive_restart() {
    let (mut engine, _, _) = queued_group_history(1);
    let author = Keys::generate();
    let mut group = engine.group_manager.snapshot();
    group.sender_keys[0].sender_event_pubkey = ndr_device(author.public_key());
    engine.group_manager = GroupEventManager::from_snapshot(group).unwrap();
    let current = engine.pending_group_sender_key_messages.remove(0);
    let nested =
        group_sender_key_message_event(&nostr_double_ratchet::GroupSenderKeyMessageEnvelope {
            group_id: "queued-group".into(),
            sender_event_pubkey: ndr_device(author.public_key()),
            signer_secret_key: author.secret_key().to_secret_bytes(),
            key_id: current.key_id,
            message_number: current.message_number,
            encrypted_header: current.encrypted_header,
            created_at: current.created_at,
            ciphertext: current.ciphertext,
        })
        .unwrap();
    // The trusted local API receives the nested ciphertext after pairwise
    // authentication. Force its normal budget yield to exercise persisted work.
    engine
        .group_sender_key_retry
        .borrow_mut()
        .key_trials_remaining = 0;
    assert!(engine.process_group_outer_event(&nested).unwrap().pending);
    assert_eq!(engine.pending_group_sender_key_messages.len(), 1);
    let mut restored = reload_group_ingress(&engine, engine.storage.clone()).unwrap();
    assert_eq!(restored.pending_group_sender_key_messages.len(), 1);
    assert!(restored
        .storage
        .get(LEGACY_GROUP_INGRESS_QUARANTINE_KEY)
        .unwrap()
        .is_none());
    let result = restored.retry_pending_protocol(NdrUnixSeconds(30)).unwrap();
    assert_eq!(result.group_result.events.len(), 1);
    assert!(restored.pending_group_sender_key_messages.is_empty());
    let delivery = restored
        .pending_decrypted_deliveries
        .iter()
        .find(|delivery| is_synthetic_group_delivery(delivery))
        .unwrap();
    let id = delivery.event_id.clone().unwrap();
    let reopened = reload_group_ingress(&restored, restored.storage.clone()).unwrap();
    assert!(reopened
        .pending_group_decrypted_delivery(&id)
        .unwrap()
        .is_some());
}