ipfrs-network 0.2.0

Peer-to-peer networking layer with libp2p and QUIC for IPFRS
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
//! Peer Gossip Filter — probabilistic duplicate/spam/storm suppression
//!
//! Uses a fixed-size ring buffer of FNV-1a fingerprints to detect already-seen
//! gossip messages without unbounded memory growth.  Combines seen-set lookup,
//! per-sender rate limiting, TTL enforcement, and a manual block list.
//!
//! # Example
//!
//! ```rust
//! use ipfrs_network::gossip_filter::{
//!     FilterConfig, GossipMessage, PeerGossipFilter,
//! };
//!
//! let config = FilterConfig::default();
//! let mut filter = PeerGossipFilter::new(config);
//!
//! let mut msg = GossipMessage {
//!     message_id: 1,
//!     topic: "blocks".to_string(),
//!     sender_peer_id: "peer-A".to_string(),
//!     payload_hash: 0xdeadbeef,
//!     received_at_tick: 1,
//!     ttl: 4,
//! };
//!
//! use ipfrs_network::gossip_filter::FilterVerdict;
//! assert_eq!(filter.evaluate(&mut msg, 1), FilterVerdict::Accept);
//! assert_eq!(filter.evaluate(&mut msg, 1), FilterVerdict::Duplicate);
//! ```

use std::collections::{HashMap, HashSet};

// ─────────────────────────────────────────────────────────────────────────────
// FNV-1a constants (64-bit)
// ─────────────────────────────────────────────────────────────────────────────

const FNV_OFFSET_BASIS: u64 = 14_695_981_039_346_656_037;
const FNV_PRIME: u64 = 1_099_511_628_211;

/// Compute an FNV-1a hash over a byte slice.
#[inline]
fn fnv1a(bytes: &[u8]) -> u64 {
    let mut h = FNV_OFFSET_BASIS;
    for &b in bytes {
        h ^= b as u64;
        h = h.wrapping_mul(FNV_PRIME);
    }
    h
}

/// Combine `message_id` and `payload_hash` into a single FNV-1a fingerprint.
///
/// Both values are hashed together so that a reused message ID with different
/// payload content still produces a distinct fingerprint.
fn message_fingerprint(message_id: u64, payload_hash: u64) -> u64 {
    let mut bytes = [0u8; 16];
    bytes[..8].copy_from_slice(&message_id.to_le_bytes());
    bytes[8..].copy_from_slice(&payload_hash.to_le_bytes());
    fnv1a(&bytes)
}

// ─────────────────────────────────────────────────────────────────────────────
// Public data types
// ─────────────────────────────────────────────────────────────────────────────

/// A gossip message flowing through the network layer.
#[derive(Debug, Clone)]
pub struct GossipMessage {
    /// Globally unique message identifier assigned by the originator.
    pub message_id: u64,
    /// Pub/sub topic this message belongs to.
    pub topic: String,
    /// Peer ID string of the direct sender.
    pub sender_peer_id: String,
    /// FNV-1a hash of the raw message payload (content integrity check).
    pub payload_hash: u64,
    /// Logical clock tick at which the local node received this message.
    pub received_at_tick: u64,
    /// Remaining hop count; decremented before forwarding.  When 0 the message
    /// must not be forwarded further.
    pub ttl: u8,
}

/// Decision returned by [`PeerGossipFilter::evaluate`].
#[derive(Clone, Copy, Debug, PartialEq, Eq)]
pub enum FilterVerdict {
    /// New message — should be processed and forwarded.
    Accept,
    /// Already seen this `(message_id, payload_hash)` combination.
    Duplicate,
    /// TTL was 0 before evaluation; message must be discarded.
    Expired,
    /// Sender is on the block list or exceeded the per-tick rate limit.
    Blocked,
}

/// Configuration knobs for [`PeerGossipFilter`].
#[derive(Debug, Clone)]
pub struct FilterConfig {
    /// Number of fingerprint slots in the ring buffer (default 1024).
    pub seen_set_capacity: usize,
    /// Maximum messages accepted from a single peer per scheduling tick
    /// before that peer is auto-blocked (default 10).
    pub max_messages_per_peer_per_tick: u32,
}

impl Default for FilterConfig {
    fn default() -> Self {
        Self {
            seen_set_capacity: 1024,
            max_messages_per_peer_per_tick: 10,
        }
    }
}

/// Cumulative statistics collected by [`PeerGossipFilter`].
#[derive(Debug, Clone, Default)]
pub struct FilterStats {
    /// Total number of messages passed to [`PeerGossipFilter::evaluate`].
    pub total_evaluated: u64,
    /// Messages that received [`FilterVerdict::Accept`].
    pub accepted: u64,
    /// Messages that received [`FilterVerdict::Duplicate`].
    pub duplicates: u64,
    /// Messages that received [`FilterVerdict::Expired`].
    pub expired: u64,
    /// Messages that received [`FilterVerdict::Blocked`].
    pub blocked: u64,
}

// ─────────────────────────────────────────────────────────────────────────────
// PeerGossipFilter
// ─────────────────────────────────────────────────────────────────────────────

/// Stateful filter that suppresses duplicate, expired, and abusive gossip
/// messages using a fixed-memory probabilistic seen-set plus rate limiting.
///
/// ## Evaluation order
///
/// 1. **Block-list check** — if the sender is explicitly blocked → [`FilterVerdict::Blocked`].
/// 2. **Rate-limit check** — if the sender has already sent
///    `max_messages_per_peer_per_tick` messages this tick → [`FilterVerdict::Blocked`]
///    *and* the sender is added to the permanent block list.
/// 3. **TTL check** — if `msg.ttl == 0` before decrement → [`FilterVerdict::Expired`].
///    Otherwise `msg.ttl` is decremented by 1 in-place.
/// 4. **Seen-set check** — fingerprint lookup in the ring buffer:
///    - Match → [`FilterVerdict::Duplicate`].
///    - No match → fingerprint inserted, per-tick count incremented →
///      [`FilterVerdict::Accept`].
pub struct PeerGossipFilter {
    /// Fixed-capacity ring buffer of fingerprints.  Slots initialised to 0.
    seen_ring: Vec<u64>,
    /// Write cursor; wraps at `seen_ring.len()`.
    ring_pos: usize,
    /// Permanently blocked peer IDs.
    blocked_peers: HashSet<String>,
    /// Per-tick message count per sender peer ID.
    per_tick_counts: HashMap<String, u32>,
    /// Filter configuration (immutable after construction).
    config: FilterConfig,
    /// Cumulative evaluation statistics.
    stats: FilterStats,
}

impl PeerGossipFilter {
    /// Create a new filter with the supplied configuration.
    ///
    /// The seen-ring is pre-allocated and zero-initialised to `seen_set_capacity`
    /// slots.  A capacity of 0 is clamped to 1 so the ring is never empty.
    pub fn new(config: FilterConfig) -> Self {
        let capacity = config.seen_set_capacity.max(1);
        Self {
            seen_ring: vec![0u64; capacity],
            ring_pos: 0,
            blocked_peers: HashSet::new(),
            per_tick_counts: HashMap::new(),
            config,
            stats: FilterStats::default(),
        }
    }

    /// Evaluate a gossip message and return the appropriate verdict.
    ///
    /// The message is mutated in-place only when the verdict is [`FilterVerdict::Accept`]
    /// or [`FilterVerdict::Duplicate`] (TTL is decremented once if it was > 0 and the
    /// sender passes the block / rate checks).
    pub fn evaluate(&mut self, msg: &mut GossipMessage, _current_tick: u64) -> FilterVerdict {
        self.stats.total_evaluated += 1;

        let sender = msg.sender_peer_id.clone();

        // ── Step 1: permanent block list ──────────────────────────────────────
        if self.blocked_peers.contains(&sender) {
            self.stats.blocked += 1;
            return FilterVerdict::Blocked;
        }

        // ── Step 2: per-tick rate limit ───────────────────────────────────────
        let tick_count = self.per_tick_counts.get(&sender).copied().unwrap_or(0);
        if tick_count >= self.config.max_messages_per_peer_per_tick {
            // Auto-block the abusive peer permanently.
            self.blocked_peers.insert(sender);
            self.stats.blocked += 1;
            return FilterVerdict::Blocked;
        }

        // ── Step 3: TTL check ─────────────────────────────────────────────────
        if msg.ttl == 0 {
            self.stats.expired += 1;
            return FilterVerdict::Expired;
        }
        msg.ttl -= 1;

        // ── Step 4: seen-set lookup ───────────────────────────────────────────
        let fp = message_fingerprint(msg.message_id, msg.payload_hash);
        let capacity = self.seen_ring.len();

        for &slot in &self.seen_ring {
            if slot == fp {
                self.stats.duplicates += 1;
                return FilterVerdict::Duplicate;
            }
        }

        // Not seen — insert into ring and accept.
        self.seen_ring[self.ring_pos] = fp;
        self.ring_pos = (self.ring_pos + 1) % capacity;

        // ── Step 5: update per-tick count ─────────────────────────────────────
        *self.per_tick_counts.entry(sender).or_insert(0) += 1;

        self.stats.accepted += 1;
        FilterVerdict::Accept
    }

    /// Reset per-tick counters.  Call this at the start of every scheduling
    /// tick.  Note: peers that were auto-blocked due to rate limiting remain
    /// blocked across ticks — call [`PeerGossipFilter::unblock_peer`] explicitly
    /// if recovery is desired.
    pub fn new_tick(&mut self) {
        self.per_tick_counts.clear();
    }

    /// Add a peer ID to the permanent block list.
    pub fn block_peer(&mut self, peer_id: &str) {
        self.blocked_peers.insert(peer_id.to_string());
    }

    /// Remove a peer ID from the permanent block list.
    pub fn unblock_peer(&mut self, peer_id: &str) {
        self.blocked_peers.remove(peer_id);
    }

    /// Return `true` if `peer_id` is currently on the block list.
    pub fn is_blocked(&self, peer_id: &str) -> bool {
        self.blocked_peers.contains(peer_id)
    }

    /// Return a reference to the cumulative statistics.
    pub fn stats(&self) -> &FilterStats {
        &self.stats
    }
}

// ─────────────────────────────────────────────────────────────────────────────
// Tests
// ─────────────────────────────────────────────────────────────────────────────

#[cfg(test)]
mod tests {
    use super::*;

    // ── helpers ───────────────────────────────────────────────────────────────

    fn make_msg(id: u64, sender: &str, ttl: u8, payload_hash: u64) -> GossipMessage {
        GossipMessage {
            message_id: id,
            topic: "test-topic".to_string(),
            sender_peer_id: sender.to_string(),
            payload_hash,
            received_at_tick: 1,
            ttl,
        }
    }

    fn default_filter() -> PeerGossipFilter {
        PeerGossipFilter::new(FilterConfig::default())
    }

    // ── 1. Accept new message ─────────────────────────────────────────────────

    #[test]
    fn test_accept_new_message() {
        let mut f = default_filter();
        let mut msg = make_msg(1, "peer-A", 4, 0xaabbccdd);
        assert_eq!(f.evaluate(&mut msg, 1), FilterVerdict::Accept);
    }

    #[test]
    fn test_accept_decrements_ttl() {
        let mut f = default_filter();
        let mut msg = make_msg(1, "peer-A", 4, 0xaabbccdd);
        f.evaluate(&mut msg, 1);
        assert_eq!(msg.ttl, 3);
    }

    #[test]
    fn test_accept_updates_stats() {
        let mut f = default_filter();
        let mut msg = make_msg(42, "peer-B", 3, 0x1234);
        f.evaluate(&mut msg, 1);
        let s = f.stats();
        assert_eq!(s.total_evaluated, 1);
        assert_eq!(s.accepted, 1);
        assert_eq!(s.duplicates, 0);
    }

    // ── 2. Duplicate detection ────────────────────────────────────────────────

    #[test]
    fn test_duplicate_same_message() {
        let mut f = default_filter();
        let mut msg = make_msg(1, "peer-A", 4, 0xaabbccdd);
        assert_eq!(f.evaluate(&mut msg, 1), FilterVerdict::Accept);
        // Re-submit the same (id, payload_hash) — ttl is now 3 but fingerprint
        // already in ring.
        let mut msg2 = make_msg(1, "peer-A", 3, 0xaabbccdd);
        assert_eq!(f.evaluate(&mut msg2, 1), FilterVerdict::Duplicate);
    }

    #[test]
    fn test_duplicate_different_sender_same_fingerprint() {
        let mut f = default_filter();
        let mut msg1 = make_msg(7, "peer-A", 4, 0x9999);
        assert_eq!(f.evaluate(&mut msg1, 1), FilterVerdict::Accept);
        // Same message relayed by a different peer.
        let mut msg2 = make_msg(7, "peer-B", 4, 0x9999);
        assert_eq!(f.evaluate(&mut msg2, 1), FilterVerdict::Duplicate);
    }

    #[test]
    fn test_no_duplicate_different_payload() {
        let mut f = default_filter();
        let mut msg1 = make_msg(1, "peer-A", 4, 0x1111);
        let mut msg2 = make_msg(1, "peer-A", 4, 0x2222); // same id, different payload
        assert_eq!(f.evaluate(&mut msg1, 1), FilterVerdict::Accept);
        assert_eq!(f.evaluate(&mut msg2, 1), FilterVerdict::Accept);
    }

    #[test]
    fn test_duplicate_updates_stats() {
        let mut f = default_filter();
        let mut msg = make_msg(1, "peer-A", 4, 0xaabbccdd);
        f.evaluate(&mut msg, 1);
        let mut msg2 = make_msg(1, "peer-A", 3, 0xaabbccdd);
        f.evaluate(&mut msg2, 1);
        assert_eq!(f.stats().duplicates, 1);
        assert_eq!(f.stats().total_evaluated, 2);
    }

    // ── 3. Expired (TTL = 0) ──────────────────────────────────────────────────

    #[test]
    fn test_expired_when_ttl_zero() {
        let mut f = default_filter();
        let mut msg = make_msg(1, "peer-A", 0, 0xbeef);
        assert_eq!(f.evaluate(&mut msg, 1), FilterVerdict::Expired);
    }

    #[test]
    fn test_expired_ttl_not_decremented_below_zero() {
        let mut f = default_filter();
        let mut msg = make_msg(1, "peer-A", 0, 0xbeef);
        f.evaluate(&mut msg, 1);
        // u8 stays at 0, not wrapped.
        assert_eq!(msg.ttl, 0);
    }

    #[test]
    fn test_expired_updates_stats() {
        let mut f = default_filter();
        let mut msg = make_msg(1, "peer-A", 0, 0xbeef);
        f.evaluate(&mut msg, 1);
        assert_eq!(f.stats().expired, 1);
        assert_eq!(f.stats().accepted, 0);
    }

    // ── 4. TTL = 1 → decrement to 0 → still Accept ───────────────────────────

    #[test]
    fn test_ttl_one_becomes_zero_and_accepts() {
        let mut f = default_filter();
        let mut msg = make_msg(1, "peer-A", 1, 0xface);
        let verdict = f.evaluate(&mut msg, 1);
        assert_eq!(verdict, FilterVerdict::Accept);
        assert_eq!(msg.ttl, 0);
    }

    // ── 5. Manual block ───────────────────────────────────────────────────────

    #[test]
    fn test_blocked_peer_returns_blocked() {
        let mut f = default_filter();
        f.block_peer("evil-peer");
        let mut msg = make_msg(1, "evil-peer", 4, 0x1234);
        assert_eq!(f.evaluate(&mut msg, 1), FilterVerdict::Blocked);
    }

    #[test]
    fn test_blocked_updates_stats() {
        let mut f = default_filter();
        f.block_peer("evil-peer");
        let mut msg = make_msg(1, "evil-peer", 4, 0x1234);
        f.evaluate(&mut msg, 1);
        assert_eq!(f.stats().blocked, 1);
    }

    #[test]
    fn test_is_blocked_true_after_block() {
        let mut f = default_filter();
        f.block_peer("evil-peer");
        assert!(f.is_blocked("evil-peer"));
    }

    #[test]
    fn test_is_blocked_false_for_unknown() {
        let f = default_filter();
        assert!(!f.is_blocked("unknown-peer"));
    }

    // ── 6. Unblock ────────────────────────────────────────────────────────────

    #[test]
    fn test_unblock_peer_allows_messages() {
        let mut f = default_filter();
        f.block_peer("peer-X");
        f.unblock_peer("peer-X");
        assert!(!f.is_blocked("peer-X"));
        let mut msg = make_msg(1, "peer-X", 4, 0x5678);
        assert_eq!(f.evaluate(&mut msg, 1), FilterVerdict::Accept);
    }

    #[test]
    fn test_unblock_nonexistent_is_noop() {
        let mut f = default_filter();
        // Should not panic.
        f.unblock_peer("nonexistent");
        assert!(!f.is_blocked("nonexistent"));
    }

    // ── 7. Rate limiting ──────────────────────────────────────────────────────

    #[test]
    fn test_rate_limit_triggers_blocked() {
        let config = FilterConfig {
            seen_set_capacity: 1024,
            max_messages_per_peer_per_tick: 3,
        };
        let mut f = PeerGossipFilter::new(config);

        // 3 distinct messages → all accepted.
        for i in 0..3u64 {
            let mut msg = make_msg(i, "spammer", 4, i);
            assert_eq!(f.evaluate(&mut msg, 1), FilterVerdict::Accept, "msg {i}");
        }

        // 4th message exceeds the limit.
        let mut msg4 = make_msg(100, "spammer", 4, 0xaaaa);
        assert_eq!(f.evaluate(&mut msg4, 1), FilterVerdict::Blocked);
    }

    #[test]
    fn test_rate_limit_auto_blocks_peer() {
        let config = FilterConfig {
            seen_set_capacity: 1024,
            max_messages_per_peer_per_tick: 2,
        };
        let mut f = PeerGossipFilter::new(config);

        for i in 0..2u64 {
            let mut msg = make_msg(i, "spammer", 4, i);
            f.evaluate(&mut msg, 1);
        }
        let mut msg_extra = make_msg(99, "spammer", 4, 0xffff);
        f.evaluate(&mut msg_extra, 1);

        assert!(f.is_blocked("spammer"), "peer should be auto-blocked");
    }

    #[test]
    fn test_rate_limit_only_affects_spammer() {
        let config = FilterConfig {
            seen_set_capacity: 1024,
            max_messages_per_peer_per_tick: 2,
        };
        let mut f = PeerGossipFilter::new(config);

        // Exhaust spammer's budget.
        for i in 0..3u64 {
            let mut msg = make_msg(i, "spammer", 4, i);
            f.evaluate(&mut msg, 1);
        }

        // A different peer is unaffected.
        let mut good = make_msg(200, "good-peer", 4, 0xbabe);
        assert_eq!(f.evaluate(&mut good, 1), FilterVerdict::Accept);
    }

    // ── 8. new_tick resets per-tick counts ───────────────────────────────────

    #[test]
    fn test_new_tick_resets_counts() {
        let config = FilterConfig {
            seen_set_capacity: 1024,
            max_messages_per_peer_per_tick: 2,
        };
        let mut f = PeerGossipFilter::new(config);

        // Send 2 messages (fills budget).
        for i in 0..2u64 {
            let mut msg = make_msg(i, "peer-A", 4, i);
            f.evaluate(&mut msg, 1);
        }

        // New tick — counts reset.
        f.new_tick();

        // Send distinct new messages that haven't been seen.
        for i in 100..102u64 {
            let mut msg = make_msg(i, "peer-A", 4, i);
            let v = f.evaluate(&mut msg, 2);
            assert_eq!(
                v,
                FilterVerdict::Accept,
                "msg {i} should be accepted after new_tick"
            );
        }
    }

    #[test]
    fn test_new_tick_does_not_unblock_auto_blocked_peer() {
        let config = FilterConfig {
            seen_set_capacity: 1024,
            max_messages_per_peer_per_tick: 1,
        };
        let mut f = PeerGossipFilter::new(config);

        // First message accepted, second triggers auto-block.
        let mut m1 = make_msg(1, "spammer", 4, 1);
        f.evaluate(&mut m1, 1);
        let mut m2 = make_msg(2, "spammer", 4, 2);
        f.evaluate(&mut m2, 1);

        f.new_tick();

        // Peer is still blocked.
        assert!(f.is_blocked("spammer"));
        let mut m3 = make_msg(3, "spammer", 4, 3);
        assert_eq!(f.evaluate(&mut m3, 2), FilterVerdict::Blocked);
    }

    // ── 9. Ring buffer wrap-around ────────────────────────────────────────────

    #[test]
    fn test_ring_buffer_wraparound_evicts_oldest() {
        // Very small ring so we can force wrap-around quickly.
        let config = FilterConfig {
            seen_set_capacity: 4,
            max_messages_per_peer_per_tick: u32::MAX,
        };
        let mut f = PeerGossipFilter::new(config);

        // Fill ring with 4 distinct messages.
        for i in 0..4u64 {
            let mut msg = make_msg(i, "peer", 4, i);
            assert_eq!(f.evaluate(&mut msg, 1), FilterVerdict::Accept);
        }

        // The 5th message wraps and evicts slot 0 (message 0).
        let mut msg4 = make_msg(4, "peer", 4, 4);
        assert_eq!(f.evaluate(&mut msg4, 1), FilterVerdict::Accept);

        // Message 0 fingerprint is gone — re-submitting it should Accept again.
        let mut msg0_again = make_msg(0, "peer", 4, 0);
        assert_eq!(f.evaluate(&mut msg0_again, 1), FilterVerdict::Accept);
    }

    #[test]
    fn test_ring_buffer_still_detects_recent_duplicates() {
        let config = FilterConfig {
            seen_set_capacity: 8,
            max_messages_per_peer_per_tick: u32::MAX,
        };
        let mut f = PeerGossipFilter::new(config);

        for i in 0..8u64 {
            let mut msg = make_msg(i, "peer", 4, i);
            f.evaluate(&mut msg, 1);
        }

        // All 8 are still in the ring — duplicates detected.
        for i in 0..8u64 {
            let mut msg = make_msg(i, "peer", 3, i);
            assert_eq!(f.evaluate(&mut msg, 1), FilterVerdict::Duplicate, "msg {i}");
        }
    }

    // ── 10. Stats accumulate correctly ────────────────────────────────────────

    #[test]
    fn test_stats_accumulate_across_verdicts() {
        let config = FilterConfig {
            seen_set_capacity: 1024,
            max_messages_per_peer_per_tick: 5,
        };
        let mut f = PeerGossipFilter::new(config);

        // 1 accepted.
        let mut m1 = make_msg(1, "peer-A", 3, 0x1111);
        f.evaluate(&mut m1, 1);

        // 1 duplicate.
        let mut m1_dup = make_msg(1, "peer-A", 3, 0x1111);
        f.evaluate(&mut m1_dup, 1);

        // 1 expired.
        let mut m2 = make_msg(2, "peer-A", 0, 0x2222);
        f.evaluate(&mut m2, 1);

        // 1 manually blocked.
        f.block_peer("peer-B");
        let mut m3 = make_msg(3, "peer-B", 4, 0x3333);
        f.evaluate(&mut m3, 1);

        let s = f.stats();
        assert_eq!(s.total_evaluated, 4);
        assert_eq!(s.accepted, 1);
        assert_eq!(s.duplicates, 1);
        assert_eq!(s.expired, 1);
        assert_eq!(s.blocked, 1);
    }

    // ── 11. Zero-slot ring clamped to 1 ──────────────────────────────────────

    #[test]
    fn test_zero_capacity_clamped_to_one() {
        let config = FilterConfig {
            seen_set_capacity: 0,
            max_messages_per_peer_per_tick: u32::MAX,
        };
        let mut f = PeerGossipFilter::new(config);
        // Should not panic.
        let mut msg = make_msg(1, "peer", 4, 0xdead);
        assert_eq!(f.evaluate(&mut msg, 1), FilterVerdict::Accept);
    }

    // ── 12. FNV-1a fingerprint helper ─────────────────────────────────────────

    #[test]
    fn test_fingerprint_deterministic() {
        let fp1 = message_fingerprint(42, 0xdeadbeef);
        let fp2 = message_fingerprint(42, 0xdeadbeef);
        assert_eq!(fp1, fp2);
    }

    #[test]
    fn test_fingerprint_differs_on_id_change() {
        let fp1 = message_fingerprint(1, 0x1234);
        let fp2 = message_fingerprint(2, 0x1234);
        assert_ne!(fp1, fp2);
    }

    #[test]
    fn test_fingerprint_differs_on_payload_change() {
        let fp1 = message_fingerprint(1, 0x1111);
        let fp2 = message_fingerprint(1, 0x2222);
        assert_ne!(fp1, fp2);
    }

    // ── 13. Zero-slot fingerprint collisions handled gracefully ──────────────

    #[test]
    fn test_zero_fingerprint_not_considered_seen() {
        // Slot initialised to 0; a legitimate message that happens to hash to 0
        // should not be treated as duplicate on the first occurrence.
        // We can't force hash == 0 easily, but we test that newly constructed
        // filters don't incorrectly flag first messages.
        let mut f = default_filter();
        let mut msg = make_msg(0, "peer", 4, 0);
        // The fingerprint of (0, 0) is very unlikely to be 0, but even if it
        // were, the test validates the filter doesn't panic.
        let v = f.evaluate(&mut msg, 1);
        // Either Accept or Duplicate (if hash==0 collides with init value).
        assert!(v == FilterVerdict::Accept || v == FilterVerdict::Duplicate);
    }
}