innodb-utils 5.1.0

InnoDB file analysis toolkit
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
#![cfg(feature = "cli")]
//! Integration tests for `inno audit`.

use byteorder::{BigEndian, ByteOrder};
use std::fs;
use std::io::Write;
use tempfile::TempDir;

use idb::innodb::checksum::ChecksumAlgorithm;
use idb::innodb::constants::*;
use idb::innodb::write;

const PAGE_SIZE: u32 = 16384;
const PS: usize = PAGE_SIZE as usize;

fn build_fsp_hdr_page(space_id: u32, total_pages: u32) -> Vec<u8> {
    write::build_fsp_page(
        space_id,
        total_pages,
        0,
        1000,
        PAGE_SIZE,
        ChecksumAlgorithm::Crc32c,
    )
}

fn build_index_page(
    page_num: u32,
    space_id: u32,
    lsn: u64,
    index_id: u64,
    level: u16,
    n_recs: u16,
    heap_top: u16,
    garbage: u16,
) -> Vec<u8> {
    let mut page = vec![0u8; PS];

    // FIL header
    BigEndian::write_u32(&mut page[FIL_PAGE_OFFSET..], page_num);
    BigEndian::write_u32(&mut page[FIL_PAGE_PREV..], FIL_NULL);
    BigEndian::write_u32(&mut page[FIL_PAGE_NEXT..], FIL_NULL);
    BigEndian::write_u64(&mut page[FIL_PAGE_LSN..], lsn);
    BigEndian::write_u16(&mut page[FIL_PAGE_TYPE..], 17855); // INDEX
    BigEndian::write_u32(&mut page[FIL_PAGE_SPACE_ID..], space_id);

    // INDEX page header
    let ph = FIL_PAGE_DATA;
    BigEndian::write_u16(&mut page[ph + PAGE_N_DIR_SLOTS..], 2);
    BigEndian::write_u16(&mut page[ph + PAGE_HEAP_TOP..], heap_top);
    BigEndian::write_u16(&mut page[ph + PAGE_N_HEAP..], 0x8002);
    BigEndian::write_u16(&mut page[ph + PAGE_GARBAGE..], garbage);
    BigEndian::write_u16(&mut page[ph + PAGE_N_RECS..], n_recs);
    BigEndian::write_u16(&mut page[ph + PAGE_LEVEL..], level);
    BigEndian::write_u64(&mut page[ph + PAGE_INDEX_ID..], index_id);

    // FIL trailer
    let trailer = PS - SIZE_FIL_TRAILER;
    BigEndian::write_u32(&mut page[trailer + 4..], (lsn & 0xFFFFFFFF) as u32);

    idb::innodb::checksum::recalculate_checksum(&mut page, PAGE_SIZE, ChecksumAlgorithm::Crc32c);
    page
}

fn write_ibd_file(dir: &std::path::Path, name: &str, pages: &[Vec<u8>]) {
    let path = dir.join(name);
    let mut f = fs::File::create(path).unwrap();
    for page in pages {
        f.write_all(page).unwrap();
    }
    f.flush().unwrap();
}

/// Create a test data directory with subdirectories and valid .ibd files.
fn create_test_datadir() -> TempDir {
    let dir = TempDir::new().unwrap();

    // db1/orders.ibd — 3 pages, all valid
    let db1 = dir.path().join("db1");
    fs::create_dir(&db1).unwrap();
    let p0 = build_fsp_hdr_page(10, 3);
    let p1 = build_index_page(1, 10, 2000, 100, 0, 50, 8000, 0);
    let p2 = build_index_page(2, 10, 3000, 100, 0, 50, 8000, 0);
    write_ibd_file(&db1, "orders.ibd", &[p0, p1, p2]);

    // db2/users.ibd — 2 pages, all valid
    let db2 = dir.path().join("db2");
    fs::create_dir(&db2).unwrap();
    let p0 = build_fsp_hdr_page(20, 2);
    let p1 = build_index_page(1, 20, 2000, 200, 0, 30, 4000, 0);
    write_ibd_file(&db2, "users.ibd", &[p0, p1]);

    dir
}

fn audit_opts(datadir: &str) -> idb::cli::audit::AuditOptions {
    idb::cli::audit::AuditOptions {
        datadir: datadir.to_string(),
        health: false,
        checksum_mismatch: false,
        verbose: false,
        json: false,
        csv: false,
        prometheus: false,
        page_size: None,
        keyring: None,
        mmap: false,
        min_fill_factor: None,
        max_fragmentation: None,
        bloat: false,
        max_bloat_grade: None,
        depth: None,
    }
}

// -----------------------------------------------------------------------
// Default integrity mode tests
// -----------------------------------------------------------------------

#[test]
fn test_audit_all_clean() {
    let dir = create_test_datadir();
    let datadir = dir.path().to_str().unwrap();

    let mut output = Vec::new();
    let result = idb::cli::audit::execute(&audit_opts(datadir), &mut output);
    assert!(result.is_ok());

    let text = String::from_utf8(output).unwrap();
    assert!(text.contains("PASS"));
    assert!(text.contains("Summary"));
    assert!(text.contains("Integrity"));
}

#[test]
fn test_audit_with_corruption() {
    let dir = create_test_datadir();
    let datadir = dir.path().to_str().unwrap();

    // Corrupt a page in orders.ibd
    let orders_path = dir.path().join("db1").join("orders.ibd");
    let mut data = fs::read(&orders_path).unwrap();
    // Corrupt page 1's checksum (bytes at offset PAGE_SIZE)
    data[PS] = 0xFF;
    data[PS + 1] = 0xFF;
    data[PS + 2] = 0xFF;
    data[PS + 3] = 0xFF;
    fs::write(&orders_path, &data).unwrap();

    let mut output = Vec::new();
    let result = idb::cli::audit::execute(&audit_opts(datadir), &mut output);
    assert!(result.is_err()); // exit code 1

    let text = String::from_utf8(output).unwrap();
    assert!(text.contains("FAIL"));
    assert!(text.contains("corrupt"));
}

#[test]
fn test_audit_json_output() {
    let dir = create_test_datadir();
    let datadir = dir.path().to_str().unwrap();

    let mut opts = audit_opts(datadir);
    opts.json = true;

    let mut output = Vec::new();
    idb::cli::audit::execute(&opts, &mut output).unwrap();

    let json: serde_json::Value = serde_json::from_slice(&output).unwrap();
    assert!(json.get("datadir").is_some());
    assert!(json.get("files").is_some());
    assert!(json.get("summary").is_some());

    let files = json["files"].as_array().unwrap();
    assert_eq!(files.len(), 2);

    let summary = &json["summary"];
    assert_eq!(summary["total_files"], 2);
    assert_eq!(summary["files_passed"], 2);
    assert_eq!(summary["files_failed"], 0);
    assert_eq!(summary["corrupt_pages"], 0);
}

#[test]
fn test_audit_csv_output() {
    let dir = create_test_datadir();
    let datadir = dir.path().to_str().unwrap();

    let mut opts = audit_opts(datadir);
    opts.csv = true;

    let mut output = Vec::new();
    idb::cli::audit::execute(&opts, &mut output).unwrap();

    let text = String::from_utf8(output).unwrap();
    let lines: Vec<&str> = text.lines().collect();
    // Header + 2 data rows
    assert!(lines.len() >= 3);
    assert!(lines[0].contains("file,status,total_pages"));
    assert!(lines[1].contains("PASS"));
}

#[test]
fn test_audit_empty_directory() {
    let dir = TempDir::new().unwrap();
    let datadir = dir.path().to_str().unwrap();

    let mut output = Vec::new();
    let result = idb::cli::audit::execute(&audit_opts(datadir), &mut output);
    assert!(result.is_ok());

    let text = String::from_utf8(output).unwrap();
    assert!(text.contains("No .ibd files found"));
}

#[test]
fn test_audit_empty_directory_prometheus() {
    let dir = TempDir::new().unwrap();
    let datadir = dir.path().to_str().unwrap();

    let mut opts = audit_opts(datadir);
    opts.prometheus = true;

    let mut output = Vec::new();
    let result = idb::cli::audit::execute(&opts, &mut output);
    assert!(result.is_ok());

    // Prometheus output for empty directory should be empty (valid exposition format)
    let text = String::from_utf8(output).unwrap();
    assert!(
        text.is_empty(),
        "expected empty prometheus output, got: {}",
        text
    );
}

#[test]
fn test_audit_unreadable_file() {
    let dir = create_test_datadir();
    let datadir = dir.path().to_str().unwrap();

    // Create a file too small to be a valid tablespace
    let db1 = dir.path().join("db1");
    fs::write(db1.join("broken.ibd"), b"not a tablespace").unwrap();

    let mut opts = audit_opts(datadir);
    opts.json = true;

    let mut output = Vec::new();
    // Should still succeed overall (error files don't cause exit 1)
    idb::cli::audit::execute(&opts, &mut output).unwrap();

    let json: serde_json::Value = serde_json::from_slice(&output).unwrap();
    let files = json["files"].as_array().unwrap();
    // Should have 3 files: orders.ibd, users.ibd, broken.ibd
    assert_eq!(files.len(), 3);

    let error_file = files.iter().find(|f| f["status"] == "error");
    assert!(error_file.is_some());
    assert!(error_file.unwrap()["error"].is_string());

    // The other 2 should be PASS
    let passed = files.iter().filter(|f| f["status"] == "PASS").count();
    assert_eq!(passed, 2);
}

// -----------------------------------------------------------------------
// Health mode tests
// -----------------------------------------------------------------------

#[test]
fn test_audit_health_mode() {
    let dir = create_test_datadir();
    let datadir = dir.path().to_str().unwrap();

    let mut opts = audit_opts(datadir);
    opts.health = true;

    let mut output = Vec::new();
    idb::cli::audit::execute(&opts, &mut output).unwrap();

    let text = String::from_utf8(output).unwrap();
    assert!(text.contains("Directory Health"));
    assert!(text.contains("Fill%"));
    assert!(text.contains("Frag%"));
    assert!(text.contains("Summary"));
}

#[test]
fn test_audit_health_json() {
    let dir = create_test_datadir();
    let datadir = dir.path().to_str().unwrap();

    let mut opts = audit_opts(datadir);
    opts.health = true;
    opts.json = true;

    let mut output = Vec::new();
    idb::cli::audit::execute(&opts, &mut output).unwrap();

    let json: serde_json::Value = serde_json::from_slice(&output).unwrap();
    assert!(json.get("datadir").is_some());
    assert!(json.get("tablespaces").is_some());
    assert!(json.get("summary").is_some());

    let tablespaces = json["tablespaces"].as_array().unwrap();
    assert_eq!(tablespaces.len(), 2);

    for ts in tablespaces {
        assert!(ts.get("avg_fill_factor").is_some());
        assert!(ts.get("avg_fragmentation").is_some());
        assert!(ts.get("index_count").is_some());
    }
}

#[test]
fn test_audit_health_thresholds() {
    let dir = create_test_datadir();
    let datadir = dir.path().to_str().unwrap();

    // Set min-fill-factor very high so all tables appear "unhealthy"
    let mut opts = audit_opts(datadir);
    opts.health = true;
    opts.json = true;
    opts.min_fill_factor = Some(99.0);

    let mut output = Vec::new();
    idb::cli::audit::execute(&opts, &mut output).unwrap();

    let json: serde_json::Value = serde_json::from_slice(&output).unwrap();
    let tablespaces = json["tablespaces"].as_array().unwrap();
    // All should be included since fill < 99%
    assert_eq!(tablespaces.len(), 2);

    // Now set min-fill-factor very low so nothing appears
    let mut opts2 = audit_opts(datadir);
    opts2.health = true;
    opts2.json = true;
    opts2.min_fill_factor = Some(1.0);

    let mut output2 = Vec::new();
    idb::cli::audit::execute(&opts2, &mut output2).unwrap();

    let json2: serde_json::Value = serde_json::from_slice(&output2).unwrap();
    let tablespaces2 = json2["tablespaces"].as_array().unwrap();
    // Fill factor is above 1% so nothing should be filtered in
    assert_eq!(tablespaces2.len(), 0);
}

// -----------------------------------------------------------------------
// Mismatch mode tests
// -----------------------------------------------------------------------

#[test]
fn test_audit_checksum_mismatch_clean() {
    let dir = create_test_datadir();
    let datadir = dir.path().to_str().unwrap();

    let mut opts = audit_opts(datadir);
    opts.checksum_mismatch = true;

    let mut output = Vec::new();
    let result = idb::cli::audit::execute(&opts, &mut output);
    assert!(result.is_ok());

    let text = String::from_utf8(output).unwrap();
    assert!(text.contains("No checksum mismatches found"));
}

#[test]
fn test_audit_checksum_mismatch_with_corruption() {
    let dir = create_test_datadir();
    let datadir = dir.path().to_str().unwrap();

    // Corrupt page 1 in orders.ibd
    let orders_path = dir.path().join("db1").join("orders.ibd");
    let mut data = fs::read(&orders_path).unwrap();
    data[PS] = 0xFF;
    data[PS + 1] = 0xFF;
    data[PS + 2] = 0xFF;
    data[PS + 3] = 0xFF;
    fs::write(&orders_path, &data).unwrap();

    let mut opts = audit_opts(datadir);
    opts.checksum_mismatch = true;

    let mut output = Vec::new();
    let result = idb::cli::audit::execute(&opts, &mut output);
    assert!(result.is_err()); // exit code 1

    let text = String::from_utf8(output).unwrap();
    assert!(text.contains("orders.ibd"));
    assert!(text.contains("0x"));
}

#[test]
fn test_audit_checksum_mismatch_json() {
    let dir = create_test_datadir();
    let datadir = dir.path().to_str().unwrap();

    // Corrupt a page
    let orders_path = dir.path().join("db1").join("orders.ibd");
    let mut data = fs::read(&orders_path).unwrap();
    data[PS] = 0xFF;
    data[PS + 1] = 0xFF;
    data[PS + 2] = 0xFF;
    data[PS + 3] = 0xFF;
    fs::write(&orders_path, &data).unwrap();

    let mut opts = audit_opts(datadir);
    opts.checksum_mismatch = true;
    opts.json = true;

    let mut output = Vec::new();
    let _ = idb::cli::audit::execute(&opts, &mut output);

    let json: serde_json::Value = serde_json::from_slice(&output).unwrap();
    assert!(json.get("datadir").is_some());
    assert!(json.get("mismatches").is_some());
    assert!(json.get("total_files_scanned").is_some());

    let mismatches = json["mismatches"].as_array().unwrap();
    assert!(!mismatches.is_empty());

    let m = &mismatches[0];
    assert!(m.get("file").is_some());
    assert!(m.get("page_number").is_some());
    assert!(m.get("stored_checksum").is_some());
    assert!(m.get("calculated_checksum").is_some());
    assert!(m.get("algorithm").is_some());
}

// -----------------------------------------------------------------------
// Prometheus output tests
// -----------------------------------------------------------------------

#[test]
fn test_audit_integrity_prometheus() {
    let dir = create_test_datadir();
    let datadir = dir.path().to_str().unwrap();

    let mut opts = audit_opts(datadir);
    opts.prometheus = true;

    let mut output = Vec::new();
    idb::cli::audit::execute(&opts, &mut output).unwrap();

    let text = String::from_utf8(output).unwrap();
    assert!(
        text.contains("# TYPE innodb_pages gauge"),
        "missing innodb_pages TYPE line"
    );
    assert!(
        text.contains("# TYPE innodb_audit_integrity_pct gauge"),
        "missing innodb_audit_integrity_pct TYPE line"
    );
    assert!(
        text.contains("innodb_scan_duration_seconds"),
        "missing innodb_scan_duration_seconds metric"
    );
    assert!(
        text.contains("# TYPE innodb_scan_duration_seconds gauge"),
        "missing innodb_scan_duration_seconds TYPE line"
    );
}

#[test]
fn test_audit_health_prometheus() {
    let dir = create_test_datadir();
    let datadir = dir.path().to_str().unwrap();

    let mut opts = audit_opts(datadir);
    opts.health = true;
    opts.prometheus = true;

    let mut output = Vec::new();
    idb::cli::audit::execute(&opts, &mut output).unwrap();

    let text = String::from_utf8(output).unwrap();
    assert!(
        text.contains("# TYPE innodb_fill_factor gauge"),
        "missing innodb_fill_factor TYPE line"
    );
    assert!(
        text.contains("# TYPE innodb_fragmentation_ratio gauge"),
        "missing innodb_fragmentation_ratio TYPE line"
    );
    assert!(
        text.contains("innodb_scan_duration_seconds"),
        "missing innodb_scan_duration_seconds metric"
    );
    assert!(
        text.contains("# TYPE innodb_scan_duration_seconds gauge"),
        "missing innodb_scan_duration_seconds TYPE line"
    );
}

// -----------------------------------------------------------------------
// Flag validation
// -----------------------------------------------------------------------

#[test]
fn test_audit_mutually_exclusive_flags() {
    let dir = create_test_datadir();
    let datadir = dir.path().to_str().unwrap();

    let mut opts = audit_opts(datadir);
    opts.health = true;
    opts.checksum_mismatch = true;

    let mut output = Vec::new();
    let result = idb::cli::audit::execute(&opts, &mut output);
    assert!(result.is_err());

    let err = result.unwrap_err().to_string();
    assert!(err.contains("mutually exclusive"));
}

// -----------------------------------------------------------------------
// Depth flag tests
// -----------------------------------------------------------------------

#[test]
fn test_audit_depth_limits_discovery() {
    let dir = TempDir::new().unwrap();

    // Depth 1: root-level file
    let p0 = build_fsp_hdr_page(1, 2);
    let p1 = build_index_page(1, 1, 2000, 100, 0, 50, 8000, 0);
    write_ibd_file(dir.path(), "root_table.ibd", &[p0, p1]);

    // Depth 2: one subdir down
    let db1 = dir.path().join("db1");
    fs::create_dir(&db1).unwrap();
    let p0 = build_fsp_hdr_page(10, 2);
    let p1 = build_index_page(1, 10, 2000, 200, 0, 30, 4000, 0);
    write_ibd_file(&db1, "orders.ibd", &[p0, p1]);

    // Depth 3: two subdirs down
    let sub = db1.join("sub");
    fs::create_dir(&sub).unwrap();
    let p0 = build_fsp_hdr_page(20, 2);
    let p1 = build_index_page(1, 20, 2000, 300, 0, 20, 3000, 0);
    write_ibd_file(&sub, "deep.ibd", &[p0, p1]);

    let datadir = dir.path().to_str().unwrap();

    // depth=1: only root-level file
    let mut opts = audit_opts(datadir);
    opts.json = true;
    opts.depth = Some(1);

    let mut output = Vec::new();
    idb::cli::audit::execute(&opts, &mut output).unwrap();

    let json: serde_json::Value = serde_json::from_slice(&output).unwrap();
    assert_eq!(json["summary"]["total_files"], 1);

    // depth=None (default 2): root + db1
    let mut opts2 = audit_opts(datadir);
    opts2.json = true;

    let mut output2 = Vec::new();
    idb::cli::audit::execute(&opts2, &mut output2).unwrap();

    let json2: serde_json::Value = serde_json::from_slice(&output2).unwrap();
    assert_eq!(json2["summary"]["total_files"], 2);

    // depth=0 (unlimited): all 3
    let mut opts3 = audit_opts(datadir);
    opts3.json = true;
    opts3.depth = Some(0);

    let mut output3 = Vec::new();
    idb::cli::audit::execute(&opts3, &mut output3).unwrap();

    let json3: serde_json::Value = serde_json::from_slice(&output3).unwrap();
    assert_eq!(json3["summary"]["total_files"], 3);
}

// -----------------------------------------------------------------------
// Bloat alert tests
// -----------------------------------------------------------------------

#[test]
fn test_audit_health_bloat_json() {
    let dir = create_test_datadir();
    let datadir = dir.path().to_str().unwrap();

    let mut opts = audit_opts(datadir);
    opts.health = true;
    opts.bloat = true;
    opts.json = true;

    let mut output = Vec::new();
    idb::cli::audit::execute(&opts, &mut output).unwrap();

    let json: serde_json::Value = serde_json::from_slice(&output).unwrap();
    // With bloat enabled, tablespaces should have worst_bloat_grade
    for ts in json["tablespaces"].as_array().unwrap() {
        if ts["error"].is_null() {
            assert!(
                ts.get("worst_bloat_grade").is_some(),
                "Expected worst_bloat_grade in bloat-enabled output"
            );
            assert!(
                ts.get("worst_bloat_score").is_some(),
                "Expected worst_bloat_score in bloat-enabled output"
            );
        }
    }
    // Summary should also have worst_bloat_grade
    assert!(json["summary"].get("worst_bloat_grade").is_some());
}

#[test]
fn test_audit_health_bloat_text_output() {
    let dir = create_test_datadir();
    let datadir = dir.path().to_str().unwrap();

    let mut opts = audit_opts(datadir);
    opts.health = true;
    opts.bloat = true;

    let mut output = Vec::new();
    idb::cli::audit::execute(&opts, &mut output).unwrap();

    let text = String::from_utf8(output).unwrap();
    // Text output should include Bloat column header
    assert!(
        text.contains("Bloat"),
        "Expected Bloat column in text output"
    );
}

#[test]
fn test_audit_health_max_bloat_grade_filter() {
    let dir = create_test_datadir();
    let datadir = dir.path().to_str().unwrap();

    // Synthetic files have minimal data so bloat should be low (grade A).
    // --max-bloat-grade F means only show grade F or worse, so all healthy
    // files should be filtered out, leaving an empty tablespaces array.
    let mut opts = audit_opts(datadir);
    opts.health = true;
    opts.max_bloat_grade = Some("F".to_string());
    opts.json = true;

    let mut output = Vec::new();
    idb::cli::audit::execute(&opts, &mut output).unwrap();

    let json: serde_json::Value = serde_json::from_slice(&output).unwrap();
    let tablespaces = json["tablespaces"].as_array().unwrap();
    // Synthetic data produces grade A — all should be filtered out
    assert!(
        tablespaces.is_empty(),
        "Expected all healthy tablespaces to be filtered out by --max-bloat-grade F, got {}",
        tablespaces.len()
    );
}

#[test]
fn test_audit_health_max_bloat_grade_invalid() {
    let dir = create_test_datadir();
    let datadir = dir.path().to_str().unwrap();

    let mut opts = audit_opts(datadir);
    opts.health = true;
    opts.max_bloat_grade = Some("X".to_string());
    opts.json = true;

    let mut output = Vec::new();
    let result = idb::cli::audit::execute(&opts, &mut output);
    assert!(
        result.is_err(),
        "Invalid bloat grade should return an error"
    );
}

#[test]
fn test_audit_health_max_bloat_grade_implies_bloat() {
    let dir = create_test_datadir();
    let datadir = dir.path().to_str().unwrap();

    // --max-bloat-grade without --bloat should still compute bloat scores
    let mut opts = audit_opts(datadir);
    opts.health = true;
    opts.max_bloat_grade = Some("A".to_string());
    opts.json = true;

    let mut output = Vec::new();
    idb::cli::audit::execute(&opts, &mut output).unwrap();

    let json: serde_json::Value = serde_json::from_slice(&output).unwrap();
    // With --max-bloat-grade A, all results at A or worse should be retained
    for ts in json["tablespaces"].as_array().unwrap() {
        if ts["error"].is_null() {
            assert!(
                ts.get("worst_bloat_grade").is_some(),
                "--max-bloat-grade should imply bloat scoring"
            );
        }
    }
}