ingredients 0.2.2

Check ingredients of published Rust crates
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
use std::borrow::Cow;
use std::collections::BTreeMap;
use std::fmt::Display;
use std::path::{Path, PathBuf};

use cargo_metadata::camino::Utf8PathBuf;
use cargo_metadata::{Dependency, Target};
use tracing::{debug, trace};

use crate::error::Error;
use crate::format::{format_list, make_diff, path_from_dep, path_from_target, value_from_dep, value_from_target};
use crate::krate::Crate;
use crate::metadata::Metadata;
use crate::report::ReportItem;
use crate::upstream::Repository;
use crate::utils::file_mode;

use super::common::dependency_partial_eq;

pub struct RepoComparator<'a> {
    krate: &'a Crate,
    urepo: &'a Repository<'a>,
}

impl<'a> RepoComparator<'a> {
    pub const fn new(krate: &'a Crate, urepo: &'a Repository) -> Self {
        Self { krate, urepo }
    }

    fn path_in_krate(&self, path: &str) -> String {
        let name = self.krate.metadata.inner.name.as_str();
        let version = self.krate.metadata.inner.version.to_string();

        format!("{name}-{version}/{path}")
    }

    fn path_in_urepo(&self, path: &str) -> String {
        let shortref = &self.urepo.id[0..7];
        let path_in_vcs = &self.urepo.path_in_vcs;

        format!("git#{shortref}/{path_in_vcs}/{path}")
    }

    pub fn compare(&self) -> Result<Vec<ReportItem>, Error> {
        let mut items = Vec::new();

        let krate_cargo_toml = std::fs::read_to_string(self.krate.cargo_toml_orig())?;
        let urepo_cargo_toml = std::fs::read_to_string(self.urepo.cargo_toml())?;

        let krate_metadata = &self.krate.metadata;
        let urepo_metadata = &self.urepo.metadata;

        let krate_contents = self.krate.file_contents()?;
        let urepo_contents = self.urepo.file_contents()?;

        debug!("Comparing crate contents with repository contents");

        items.extend(compare_metadata(krate_metadata, urepo_metadata, &krate_contents.files));

        if krate_cargo_toml != urepo_cargo_toml {
            let kct_lf: Vec<_> = krate_cargo_toml.bytes().filter(|c| *c != b'\r').collect();
            let rct_lf: Vec<_> = urepo_cargo_toml.bytes().filter(|c| *c != b'\r').collect();

            if kct_lf == rct_lf {
                // file contents differ only because of line endings
                items.push(ReportItem::LineEndings {
                    path: String::from("Cargo.toml.orig"),
                });
            } else {
                let diff = Some(make_diff(
                    &krate_cargo_toml,
                    &urepo_cargo_toml,
                    Some((
                        &self.path_in_krate("Cargo.toml.orig"),
                        &self.path_in_urepo("Cargo.toml"),
                    )),
                ));
                items.push(ReportItem::ContentMismatch {
                    path: String::from("Cargo.toml.orig"),
                    diff,
                });
            }
        }

        for file in &krate_contents.broken_links {
            items.push(ReportItem::BrokenSymlinkInCrate {
                path: file.to_string_lossy().to_string(),
            });
        }
        for file in &urepo_contents.broken_links {
            items.push(ReportItem::BrokenSymlinkInRepo {
                path: file.to_string_lossy().to_string(),
            });
        }
        for file in &krate_contents.outside_base {
            items.push(ReportItem::BrokenSymlinkInCrate {
                path: file.to_string_lossy().to_string(),
            });
        }
        for file in &urepo_contents.outside_base {
            items.push(ReportItem::BrokenSymlinkInRepo {
                path: file.to_string_lossy().to_string(),
            });
        }

        for file in &krate_contents.files {
            if !urepo_contents.files.contains(file) {
                items.push(ReportItem::MissingFile {
                    path: file.to_string_lossy().to_string(),
                });
                continue;
            }

            trace!("Comparing files at path: {}", file.to_string_lossy());
            items.extend(self.compare_contents(&file, &file)?);
            items.extend(self.compare_modes(&file, &file)?);
        }

        Ok(items)
    }

    fn compare_contents<P: AsRef<Path>>(&self, krate_path: P, urepo_path: P) -> Result<Vec<ReportItem>, Error> {
        let mut items = Vec::new();

        let krate_file_content = self.krate.read_entry_to_bytes(&krate_path)?;
        let urepo_file_content = self.urepo.read_entry_to_bytes(&urepo_path)?;

        if krate_file_content != urepo_file_content {
            let kfc_lf: Vec<_> = krate_file_content.iter().filter(|c| **c != b'\r').collect();
            let rfc_lf: Vec<_> = urepo_file_content.iter().filter(|c| **c != b'\r').collect();

            if kfc_lf == rfc_lf {
                // file contents differ only because of line endings
                items.push(ReportItem::LineEndings {
                    path: krate_path.as_ref().to_string_lossy().to_string(),
                });
            } else {
                let diff = if let (Ok(ktc), Ok(utc)) = (
                    self.krate.read_entry_to_string(&krate_path),
                    self.urepo.read_entry_to_string(&urepo_path),
                ) {
                    Some(make_diff(
                        &ktc,
                        &utc,
                        Some((
                            &self.path_in_krate(&krate_path.as_ref().to_string_lossy()),
                            &self.path_in_urepo(&urepo_path.as_ref().to_string_lossy()),
                        )),
                    ))
                } else {
                    // file is probably not a text file
                    None
                };

                items.push(ReportItem::ContentMismatch {
                    path: krate_path.as_ref().to_string_lossy().to_string(),
                    diff,
                });
            }
        }

        Ok(items)
    }

    fn compare_modes<P: AsRef<Path>>(&self, krate_path: P, urepo_path: P) -> Result<Vec<ReportItem>, Error> {
        let mut items = Vec::new();

        let krate_file_mode = file_mode(self.krate.root.join(&krate_path))?;
        let urepo_file_mode = file_mode(self.urepo.root.join(&self.urepo.path_in_vcs).join(&urepo_path))?;

        if krate_file_mode != urepo_file_mode {
            items.push(ReportItem::Permissions {
                path: krate_path.as_ref().to_string_lossy().to_string(),
                krate: krate_file_mode,
                urepo: urepo_file_mode,
            });
        }

        Ok(items)
    }
}

fn compare_metadata(krate_metadata: &Metadata, urepo_metadata: &Metadata, krate_files: &[PathBuf]) -> Vec<ReportItem> {
    let mut items = Vec::new();

    let kmd = &krate_metadata.inner;
    let umd = &urepo_metadata.inner;

    items.extend(compare_displayable("package.name", &kmd.name, &umd.name));
    items.extend(compare_displayable("package.version", &kmd.version, &umd.version));
    items.extend(compare_displayable_list("package.authors", &kmd.authors, &umd.authors));

    // package.id: not stable
    // package.source: always None

    items.extend(compare_displayable_option(
        "package.description",
        kmd.description.as_ref(),
        umd.description.as_ref(),
    ));
    items.extend(compare_dependencies(&kmd.dependencies, &umd.dependencies));
    items.extend(compare_displayable_option(
        "package.license",
        kmd.license.as_ref(),
        umd.license.as_ref(),
    ));

    items.extend(compare_path_option(
        "package.license-file",
        kmd.license_file.as_ref(),
        umd.license_file.as_ref(),
    ));

    items.extend(compare_targets(&kmd.targets, &umd.targets, krate_files));
    items.extend(compare_features(&kmd.features, &umd.features));

    // manifest_path: only present in "cargo metadata" output, not in Cargo.toml

    items.extend(compare_displayable_list(
        "package.categories",
        &kmd.categories,
        &umd.categories,
    ));
    items.extend(compare_displayable_list(
        "package.keywords",
        &kmd.keywords,
        &umd.keywords,
    ));

    items.extend(compare_path_option(
        "package.readme",
        kmd.readme.as_ref(),
        umd.readme.as_ref(),
    ));

    items.extend(compare_displayable_option(
        "package.repository",
        kmd.repository.as_ref(),
        umd.repository.as_ref(),
    ));
    items.extend(compare_displayable_option(
        "package.homepage",
        kmd.homepage.as_ref(),
        umd.homepage.as_ref(),
    ));
    items.extend(compare_displayable_option(
        "package.documentation",
        kmd.documentation.as_ref(),
        umd.documentation.as_ref(),
    ));

    items.extend(compare_displayable("package.edition", &kmd.edition, &umd.edition));
    items.extend(compare_displayable("package.metadata", &kmd.metadata, &umd.metadata));

    items.extend(compare_displayable_option(
        "package.links",
        kmd.links.as_ref(),
        umd.links.as_ref(),
    ));

    items.extend(compare_displayable_list_option(
        "package.publish",
        kmd.publish.as_deref(),
        umd.publish.as_deref(),
    ));

    items.extend(compare_displayable_option(
        "package.default-run",
        kmd.default_run.as_ref(),
        umd.default_run.as_ref(),
    ));
    items.extend(compare_displayable_option(
        "package.rust-version",
        kmd.rust_version.as_ref(),
        umd.rust_version.as_ref(),
    ));

    items
}

fn compare_dependencies(kdeps: &[Dependency], udeps: &[Dependency]) -> Vec<ReportItem> {
    if kdeps.len() == udeps.len() && kdeps.iter().zip(udeps).all(|(k, u)| dependency_partial_eq(k, u)) {
        return Vec::new();
    }

    let mut items = Vec::new();

    for kdep in kdeps {
        if udeps.iter().any(|udep| dependency_partial_eq(kdep, udep)) {
            continue;
        }

        let path = path_from_dep(kdep);
        items.push(ReportItem::metadata_mismatch(path, Some(value_from_dep(kdep)), None));
    }

    for udep in udeps {
        if kdeps.iter().any(|kdep| dependency_partial_eq(kdep, udep)) {
            continue;
        }

        // non-crates.io sources (like path- or git-based dependencies) are stripped during publishing
        if let Some(source) = &udep.source
            && !source.is_crates_io()
        {
            debug!("Skipping non-crates.io / git dependency: {}", value_from_dep(udep));
            continue;
        }

        if udep.path.is_some() {
            debug!("Skipping non-crates.io / path dependency: {}", value_from_dep(udep));
            continue;
        }

        let path = path_from_dep(udep);
        items.push(ReportItem::metadata_mismatch(path, None, Some(value_from_dep(udep))));
    }

    items
}

fn compare_targets(ktargets: &[Target], utargets: &[Target], krate_files: &[PathBuf]) -> Vec<ReportItem> {
    if ktargets == utargets {
        return Vec::new();
    }

    let mut items = Vec::new();

    for ktarget in ktargets {
        if utargets.contains(ktarget) {
            continue;
        }

        let path = path_from_target(ktarget);
        items.push(ReportItem::metadata_mismatch(
            path,
            Some(value_from_target(ktarget)),
            None,
        ));
    }

    for utarget in utargets {
        if ktargets.contains(utarget) {
            continue;
        }

        if !krate_files.contains(&PathBuf::from(&utarget.src_path)) {
            // targets for paths that are not included when publishing are stripped
            continue;
        }

        let path = path_from_target(utarget);
        items.push(ReportItem::metadata_mismatch(
            path,
            None,
            Some(value_from_target(utarget)),
        ));
    }

    items
}

type Features = BTreeMap<String, Vec<String>>;
fn compare_features(kfeatures: &Features, ufeatures: &Features) -> Vec<ReportItem> {
    if kfeatures == ufeatures {
        return Vec::new();
    }

    let mut items = Vec::new();

    for (kkey, kvalues) in kfeatures {
        match ufeatures.get(kkey) {
            Some(uvalues) => {
                if kvalues == uvalues {
                    continue;
                }
                items.push(ReportItem::metadata_mismatch(
                    format!("features.{kkey}"),
                    Some(format_list(kvalues)),
                    Some(format_list(uvalues)),
                ));
            },
            None => {
                items.push(ReportItem::metadata_mismatch(
                    format!("features.{kkey}"),
                    Some(format_list(kvalues)),
                    None,
                ));
            },
        }
    }

    for (ukey, uvalues) in ufeatures {
        match kfeatures.get(ukey) {
            Some(kvalues) => {
                if kvalues == uvalues {
                    continue;
                }
                items.push(ReportItem::metadata_mismatch(
                    format!("features.{ukey}"),
                    Some(format_list(kvalues)),
                    Some(format_list(uvalues)),
                ));
            },
            None => {
                items.push(ReportItem::metadata_mismatch(
                    format!("features.{ukey}"),
                    None,
                    Some(format_list(uvalues)),
                ));
            },
        }
    }

    items
}

fn compare_displayable<S: Into<Cow<'static, str>>, D: Display + PartialEq>(
    field: S,
    kitem: &D,
    uitem: &D,
) -> Option<ReportItem> {
    if kitem == uitem {
        None
    } else {
        Some(ReportItem::metadata_mismatch(
            field,
            Some(kitem.to_string()),
            Some(uitem.to_string()),
        ))
    }
}

fn compare_path_option<S: Into<Cow<'static, str>>>(
    field: S,
    kitem: Option<&Utf8PathBuf>,
    uitem: Option<&Utf8PathBuf>,
) -> Option<ReportItem> {
    if kitem == uitem {
        None
    } else {
        Some(ReportItem::metadata_mismatch(
            field,
            kitem.map(ToString::to_string),
            uitem.map(ToString::to_string),
        ))
    }
}

fn compare_displayable_option<S: Into<Cow<'static, str>>, D: Display + PartialEq>(
    field: S,
    kitem: Option<&D>,
    uitem: Option<&D>,
) -> Option<ReportItem> {
    if kitem == uitem {
        None
    } else {
        Some(ReportItem::metadata_mismatch(
            field,
            kitem.map(ToString::to_string),
            uitem.map(ToString::to_string),
        ))
    }
}

fn compare_displayable_list<S: Into<Cow<'static, str>>, D: Display + PartialEq>(
    field: S,
    kitems: &[D],
    uitems: &[D],
) -> Option<ReportItem> {
    if kitems == uitems {
        None
    } else {
        Some(ReportItem::metadata_mismatch(
            field,
            Some(format_list(kitems)),
            Some(format_list(uitems)),
        ))
    }
}

fn compare_displayable_list_option<S: Into<Cow<'static, str>>, D: Display + PartialEq>(
    field: S,
    kitems: Option<&[D]>,
    uitems: Option<&[D]>,
) -> Option<ReportItem> {
    if kitems == uitems {
        None
    } else {
        Some(ReportItem::metadata_mismatch(
            field,
            kitems.map(format_list),
            uitems.map(format_list),
        ))
    }
}