indicatrix-cut 0.7.2

Desktop faceting-design editor: library browsing, spectral 3D rendering, material retargeting, and a solid inspection view.
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
//! Unit tests for the replan/plan-worker path: [`super::super::plan_worker::
//! build_planned_frame`] and its round trip through
//! [`super::super::render::render_request`].

use super::{
    super::{
        FacetMap, MeshCache, SolidRasterizer, live_update,
        plan_worker::{build_planned_frame, survive_panic},
        render::render_request,
        request::{PlanJob, RedrawRequest},
        state::{WorkerMemory, escaping_tier_label},
    },
    *,
};
use glam::Vec3;
use indicatrix::geometry::meet_solver::{MeetConstraint, SolveStrategy, SolvedTier};
use indicatrix_cut_core::{ConstraintTier, Design, PreformSpec, ScheduleMeta};
use indicatrix_solid::preview::StoneGeometryBuf;
use std::{
    sync::{Arc, PoisonError},
    time::Duration,
};

fn tier(name: &str, angle_deg: f64, constraint: MeetConstraint) -> ConstraintTier {
    ConstraintTier {
        angle_deg,
        name: name.to_string(),
        indices: vec![0.0],
        constraint,
        imported_meet: None,
        original_notes: None,
        detached: Vec::new(),
    }
}

/// Every tier `ScaleReference` -- `plan_preview`'s "Pinned" tier, resolved
/// with no solver call, so this plans in microseconds regardless of budget.
/// No real closure guarantee -- fine for tests that never touch
/// `mesh_cache`; see [`closed_design`] for the render-path fixture.
fn pinned_design() -> Design {
    Design::new(
        PreformSpec::block(1.0, 1.0, 1.0),
        ScheduleMeta {
            gear_teeth: 96,
            ..ScheduleMeta::default()
        },
        vec![
            tier("Table", 0.0, MeetConstraint::ScaleReference(0.5)),
            tier("Pavilion", -40.0, MeetConstraint::ScaleReference(0.6)),
        ],
    )
}

/// A synthetic "RBC-445"-style design, reauthored as [`ConstraintTier`]s
/// (mirrors `facet_map.rs`'s private `standard_round_brilliant_design`
/// fixture). Every tier pinned via `ScaleReference`, proven
/// `SolidStatus::Closed` elsewhere (`raster.rs`) -- used here, unlike
/// [`pinned_design`], because these tests need a real closed solid.
fn closed_design() -> Design {
    const GIRDLE_INDICES: [f64; 16] = [
        0.0, 6.0, 12.0, 18.0, 24.0, 30.0, 36.0, 42.0, 48.0, 54.0, 60.0, 66.0, 72.0, 78.0, 84.0,
        90.0,
    ];
    const BREAK_INDICES: [f64; 16] = [
        95.0, 1.0, 11.0, 13.0, 23.0, 25.0, 35.0, 37.0, 47.0, 49.0, 59.0, 61.0, 71.0, 73.0, 83.0,
        85.0,
    ];
    const MAIN_INDICES: [f64; 8] = [0.0, 12.0, 24.0, 36.0, 48.0, 60.0, 72.0, 84.0];
    const STAR_INDICES: [f64; 8] = [6.0, 18.0, 30.0, 42.0, 54.0, 66.0, 78.0, 90.0];

    fn rbc_tier(name: &str, angle_deg: f64, indices: &[f64], mast: f64) -> ConstraintTier {
        ConstraintTier {
            angle_deg,
            name: name.to_string(),
            indices: indices.to_vec(),
            constraint: MeetConstraint::ScaleReference(mast),
            imported_meet: None,
            original_notes: None,
            detached: Vec::new(),
        }
    }

    Design::new(
        PreformSpec::block(2.0, 1.0, 2.0),
        ScheduleMeta {
            gemcad_version: "GemCad 5.0".to_string(),
            gear_teeth: 96,
            gear_reference_angle: 0.0,
            symmetry_order: 8,
            mirror: true,
            refractive_index: 1.54,
            headers: Vec::new(),
            footnotes: Vec::new(),
        },
        vec![
            rbc_tier("Table", 0.0, &[], 0.32),
            rbc_tier("Star", 15.0, &STAR_INDICES, 0.45),
            rbc_tier("Crown Main", 34.5, &MAIN_INDICES, 0.59),
            rbc_tier("Upper Girdle", 41.0, &BREAK_INDICES, 0.67),
            rbc_tier("Girdle", 90.0, &GIRDLE_INDICES, 1.0),
            rbc_tier("Pavilion Main", -41.0, &MAIN_INDICES, 0.67),
            rbc_tier("Lower Girdle", -42.5, &BREAK_INDICES, 0.68),
            rbc_tier("Culet", -0.0, &[], 0.88),
        ],
    )
}

/// One anchored tier plus one free (`MeetExisting`) tier -- a real
/// `resolve_dirty` call happens for this fixture, which is what the
/// `Duration::ZERO` budget below needs to force `Stale` deterministically.
fn free_design() -> Design {
    Design::new(
        PreformSpec::block(2.0, 1.0, 2.0),
        ScheduleMeta {
            gear_teeth: 96,
            ..ScheduleMeta::default()
        },
        vec![
            tier("C1", 30.0, MeetConstraint::ScaleReference(0.6)),
            tier("C2", 40.0, MeetConstraint::MeetExisting),
        ],
    )
}

/// A minimal, all-default [`PlanJob`] for a test that only cares about a
/// couple of fields -- built with `..` from this so a new `PlanJob` field
/// never forces every one of this module's tests to list it.
fn plan_job(design: Design) -> PlanJob {
    let n_d = design.effective_refractive_index();
    PlanJob {
        design: Arc::new(design),
        dirty: std::collections::BTreeSet::new(),
        last_solved: None,
        camera: CAMERA,
        size: (16, 16),
        selected_tier: None,
        n_d,
        view_mode: 0,
        generation: 0,
        show_preform: true,
        enlarged_panel: -1,
        tier_cutoff: None,
        cut_steps: None,
    }
}

#[test]
fn build_planned_frame_returns_the_solved_masts_for_a_pinned_design() {
    let design = pinned_design();
    let frame = build_planned_frame(plan_job(design), live_update::DEFAULT_PREVIEW_BUDGET);
    assert_ne!(frame.planes, Vec::<(Vec3, f32)>::new());
    assert_eq!(frame.solved.map(|s| s.len()), Some(2));
    assert!(!frame.stale, "a pinned design never goes over budget");
}

/// `ReplanRequest`/`PlanJob`/`PlannedFrame` carry `Arc<Design>` end to
/// end, reusing the same allocation across the full path instead of
/// cloning repeatedly. Verifies via `Arc::ptr_eq`.
#[test]
fn build_planned_frame_carries_the_same_design_allocation_through_to_planned_frame() {
    let design = Arc::new(closed_design());
    let job = PlanJob {
        design: Arc::clone(&design),
        ..plan_job(closed_design())
    };
    let frame = build_planned_frame(job, live_update::DEFAULT_PREVIEW_BUDGET);
    assert!(
        Arc::ptr_eq(&design, &frame.design),
        "build_planned_frame must not clone the design -- PlannedFrame::design \
         should be the exact same Arc allocation ReplanRequest/PlanJob were handed"
    );
}

/// Same fixture ("RBC-445"-style, the standard round-brilliant `closed_design`
/// this module's other `PlannedFrame` tests already use), proving the
/// `Arc<Design>` plumbing above changed nothing about what actually gets
/// planned: a real closed solid, all 8 tiers solved, never stale -- byte-
/// for-byte the same shape [`render_request_carries_solved_and_freshness_
/// through_to_the_worker_frame`] below already asserts end to end through
/// `render_request` too.
#[test]
fn build_planned_frame_output_for_the_round_brilliant_fixture_is_unchanged() {
    let design = closed_design();
    let frame = build_planned_frame(plan_job(design), live_update::DEFAULT_PREVIEW_BUDGET);
    assert!(
        !frame.stale,
        "a pinned round-brilliant design never goes over budget"
    );
    assert!(frame.unsolvable_status.is_none());
    assert_eq!(
        frame.solved.map(|s| s.len()),
        Some(8),
        "every one of the fixture's 8 tiers must solve"
    );
    assert_ne!(
        frame.planes,
        Vec::<(Vec3, f32)>::new(),
        "a closed round-brilliant design must produce a real plane arrangement"
    );
}

#[test]
fn a_zero_budget_forces_stale_and_marks_the_dirty_tier_pending() {
    let design = free_design();
    let previous = design.solve().expect("fixture must solve");
    let dirty = std::collections::BTreeSet::from([1]);
    let design_for_facet_map = design.clone();

    let frame = build_planned_frame(
        PlanJob {
            last_solved: Some(previous),
            dirty,
            ..plan_job(design)
        },
        Duration::ZERO,
    );
    assert!(
        frame.stale,
        "a real resolve_dirty call can never finish within 0ns"
    );
    assert!(
        frame.solved.is_some(),
        "the fresh (late) result must still be chained forward"
    );
    // Built from the SAME (new) solved masts `build_planned_frame` used
    // internally -- a `FacetMap` built from the OLD masts is not
    // guaranteed to assign the same facet ids.
    let facet_map = FacetMap::from_design(
        &design_for_facet_map,
        frame.solved.as_deref().unwrap_or(&[]),
    );
    assert!(
        facet_map
            .facets_of_tier(1)
            .iter()
            .all(|&id| frame.style.pending[id as usize]),
        "the edited tier's own facets must be marked pending"
    );
}

/// Two tiers that meet nothing: the design does not solve.
fn unsolvable_design() -> Design {
    Design::new(
        PreformSpec::block(2.0, 1.0, 2.0),
        ScheduleMeta {
            gear_teeth: 96,
            ..ScheduleMeta::default()
        },
        vec![
            tier("C1", 30.0, MeetConstraint::MeetExisting),
            tier("C2", 40.0, MeetConstraint::MeetExisting),
        ],
    )
}

/// F4-8: an unsolvable plan carries NO masts. It used to chain the previous list forward,
/// and the sink filed that list under the plan's NEW generation, so an export asking for the
/// masts "of exactly this generation" got the new angles on the old masts.
#[test]
fn an_unsolvable_plan_carries_no_masts_not_the_previous_ones() {
    let previous = vec![SolvedTier {
        mast: 0.5,
        strategy: SolveStrategy::ScaleReference,
        detail: "the design before the edit".to_string(),
    }];
    let frame = build_planned_frame(
        PlanJob {
            last_solved: Some(previous),
            generation: 9,
            ..plan_job(unsolvable_design())
        },
        live_update::DEFAULT_PREVIEW_BUDGET,
    );
    assert!(
        frame.unsolvable_status.is_some(),
        "the premise: the design does not solve"
    );
    assert!(
        frame.solved.is_none(),
        "the previous masts do not describe this design, whatever its generation"
    );
    assert_eq!(frame.generation, 9);
}

/// The `Unbounded` banner must name the escaping plane's owning tier,
/// not the raw index.
#[test]
fn escaping_tier_label_names_the_owning_tier() {
    let design = pinned_design();
    let solved = design.solve().expect("every tier is pinned");
    let preform_plane_count = design.preform.planes().len();
    // The first plane past the preform's own is tier 0's ("Table")
    // facet -- `Design::tier_for_plane_index`'s own doc comment: it
    // subtracts `preform.planes().len()` before mapping into the
    // schedule tiers, which are laid out in tier order.
    let label = escaping_tier_label(&design, &solved, preform_plane_count);
    assert_eq!(label, "Table (tier 1)");
}

#[test]
fn escaping_tier_label_falls_back_to_a_raw_plane_for_a_preform_plane() {
    let design = pinned_design();
    let solved = design.solve().expect("every tier is pinned");
    // Index 0 is always one of the preform's own planes -- not a
    // schedule-tier facet, so `Design::tier_for_plane_index` returns
    // `None` and the label falls back to the raw index.
    let label = escaping_tier_label(&design, &solved, 0);
    assert_eq!(label, "plane 0");
}

#[test]
fn selected_tier_flags_reach_solid_style_selected() {
    let design = pinned_design();
    let design_for_facet_map = design.clone();
    let frame = build_planned_frame(
        PlanJob {
            selected_tier: Some(0),
            ..plan_job(design)
        },
        live_update::DEFAULT_PREVIEW_BUDGET,
    );
    let style = frame.style;
    // Same masts `build_planned_frame` solved internally (an all-pinned
    // design's `Design::solve()` reads each tier's own `ScaleReference`
    // value).
    let solved = design_for_facet_map.solve().expect("every tier is pinned");
    let facet_map = FacetMap::from_design(&design_for_facet_map, &solved);
    assert!(
        facet_map
            .facets_of_tier(0)
            .iter()
            .all(|&id| style.selected[id as usize]),
        "tier 0's own facets must be marked selected"
    );
    assert!(
        facet_map
            .facets_of_tier(1)
            .iter()
            .all(|&id| !style.selected[id as usize]),
        "tier 1 was never selected"
    );
}

/// Selecting a concave row (table position `tiers.len() + concave index`) tints exactly that
/// tier's tool facets in the solid style, and a flat selection tints none of them.
#[test]
fn a_selected_concave_row_tints_its_tool_facets_in_the_solid_style() {
    let design = Design::concave_fixture();
    let flat_count = design.tiers.len();
    let concave_row = |selected_tier: Option<usize>| {
        let frame = build_planned_frame(
            PlanJob {
                selected_tier,
                ..plan_job(design.clone())
            },
            live_update::DEFAULT_PREVIEW_BUDGET,
        );
        let solved = design.solve().expect("the fixture solves");
        let map = FacetMap::from_design_cut(&design, &solved, &frame.placements, None);
        (frame.style.selected, map)
    };
    let (selected, map) = concave_row(Some(flat_count));
    let first_tool_facets: Vec<usize> = (0..map.facet_count())
        .filter(|&id| {
            matches!(
                map.kind_of(id),
                indicatrix_solid::facet_map::FacetKind::Concave { tier: 0, .. }
            )
        })
        .collect();
    assert!(!first_tool_facets.is_empty(), "the fixture has tool facets");
    for id in 0..map.facet_count() {
        assert_eq!(
            selected.get(id).copied().unwrap_or(false),
            first_tool_facets.contains(&id),
            "facet {id}"
        );
    }
    let (flat_selected, _) = concave_row(Some(0));
    assert!(
        first_tool_facets
            .iter()
            .all(|&id| !flat_selected.get(id).copied().unwrap_or(false)),
        "a flat selection leaves the tool facets alone"
    );
}

/// A `tier_cutoff` of `Some(0)` truncates planes to the first tier only.
#[test]
fn tier_cutoff_truncates_the_planned_frame() {
    let design = pinned_design();
    let full = build_planned_frame(
        plan_job(design.clone()),
        live_update::DEFAULT_PREVIEW_BUDGET,
    );
    let truncated = build_planned_frame(
        PlanJob {
            tier_cutoff: Some(0),
            ..plan_job(design)
        },
        live_update::DEFAULT_PREVIEW_BUDGET,
    );
    assert!(
        truncated.planes.len() < full.planes.len(),
        "cutting off after tier 0 must drop tier 1's (\"Pavilion\") facet(s): \
         full={}, truncated={}",
        full.planes.len(),
        truncated.planes.len()
    );
}

/// [`super::super::SolidPreviewState::set_tier_cutoff`] only caches the value
/// for the NEXT [`super::super::SolidPreviewState::request_replan`] -- this
/// guards that the getter side of that cache (the private `tier_cutoff` field
/// itself, read back through the same lock `set_tier_cutoff` writes through)
/// round-trips both `Some` and back to `None`, independent of the worker
/// thread machinery `request_replan` also drives.
#[test]
fn set_tier_cutoff_round_trips_through_the_cache() {
    let state = SolidPreviewState::new(FakeSink::new());
    let cached = || {
        *state
            .tier_cutoff
            .lock()
            .unwrap_or_else(PoisonError::into_inner)
    };
    assert_eq!(cached(), None);
    state.set_tier_cutoff(Some(3));
    assert_eq!(cached(), Some(3));
    state.set_tier_cutoff(None);
    assert_eq!(cached(), None);
}

/// The Cut slider's `cut_steps` through the planner: `k` steps draw the preform plus the
/// planes of the first `k` tiers of the cutting order, `0` is the preform alone, and the last
/// step is the finished stone. `cut_steps` also wins over the web's `tier_cutoff`.
#[test]
fn cut_steps_truncate_the_planned_frame_and_zero_is_the_preform_alone() {
    let design = closed_design();
    let preform = design.preform.planes().len();
    let plan = |cut_steps: Option<usize>, tier_cutoff: Option<usize>| {
        build_planned_frame(
            PlanJob {
                cut_steps,
                tier_cutoff,
                ..plan_job(design.clone())
            },
            live_update::DEFAULT_PREVIEW_BUDGET,
        )
    };
    let finished = plan(None, None);
    assert_eq!(plan(Some(0), None).planes.len(), preform, "the rough");
    // The steps follow the cutting order (pavilion section first), so the first step of this
    // top-down fixture is the girdle tier: sixteen planes, not the table's one.
    assert_eq!(
        plan(Some(1), None).planes.len(),
        preform + 16,
        "step one is the girdle, sixteen planes"
    );
    let mut previous = preform;
    for steps in 1..=design.tiers.len() {
        let now = plan(Some(steps), None).planes.len();
        assert!(now >= previous, "step {steps} must not remove planes");
        previous = now;
    }
    assert_eq!(plan(Some(design.tiers.len()), None).planes, finished.planes);
    assert_eq!(
        plan(Some(0), Some(3)).planes.len(),
        preform,
        "cut_steps wins over tier_cutoff"
    );
}

/// A replan that was already queued when the slider moved must still see the latest cut:
/// `set_cut_steps` is read at `request_replan` time -- the entry the slider's drain
/// uses -- and reaches the frame that lands on the sink.
#[test]
fn the_controller_hands_the_cut_to_the_replan_it_submits() {
    let sink = FakeSink::new();
    let state = SolidPreviewState::new(sink.clone());
    let design = Arc::new(closed_design());
    let preform = design.preform.planes().len();

    state.set_cut_steps(Some(0));
    state.request_replan(replan_request(&design, 1));
    let calls = sink.wait_until("the rough", DEADLINE, |c| !c.is_empty());
    assert!(calls[0].0, "the preform alone is a closed stone");
    assert_eq!(sink.plane_counts()[0], preform);

    state.set_cut_steps(None);
    state.request_replan(replan_request(&design, 2));
    sink.wait_until("the finished stone", DEADLINE, |c| c.len() >= 2);
    assert!(sink.plane_counts()[1] > preform + 8);
}

/// The freeze behind "the Cut slider stopped following": an unsolvable design planned
/// against masts left over from before an add or remove used to panic inside the plan
/// worker, which then ignored every later replan. The next replan must still land.
#[test]
fn a_stale_mast_list_on_an_unsolvable_design_does_not_kill_the_plan_worker() {
    let sink = FakeSink::new();
    let state = SolidPreviewState::new(sink.clone());
    let unsolvable = Arc::new(Design::new(
        PreformSpec::block(2.0, 1.0, 2.0),
        ScheduleMeta {
            gear_teeth: 96,
            ..ScheduleMeta::default()
        },
        vec![
            tier("C1", 30.0, MeetConstraint::MeetExisting),
            tier("C2", 40.0, MeetConstraint::MeetExisting),
        ],
    ));
    let stale = vec![SolvedTier {
        mast: 0.5,
        strategy: SolveStrategy::ScaleReference,
        detail: "from before the edit".to_string(),
    }];

    state.set_cut_steps(Some(1));
    state.request_replan(ReplanRequest {
        last_solved: Some(stale),
        ..replan_request(&unsolvable, 1)
    });
    sink.wait_until("the unsolvable frame", DEADLINE, |c| !c.is_empty());

    state.set_cut_steps(None);
    state.request_replan(replan_request(&Arc::new(closed_design()), 2));
    let calls = sink.wait_until("the frame after it", DEADLINE, |c| c.len() >= 2);
    assert!(calls[1].0, "the worker is alive and draws the next design");
}

/// A request for [`state.request_replan`](SolidPreviewState::request_replan) with
/// everything defaulted: a full solve of `design` at `generation`.
fn replan_request(design: &Arc<Design>, generation: u64) -> ReplanRequest {
    ReplanRequest {
        design: Arc::clone(design),
        dirty: std::collections::BTreeSet::new(),
        last_solved: None,
        camera: CAMERA,
        size: (16, 16),
        selected_tier: None,
        n_d: design.effective_refractive_index(),
        view_mode: 0,
        generation,
        show_preform: true,
        enlarged_panel: -1,
    }
}

/// A worker loop wraps its work in [`survive_panic`]: a panic is a `None`, not a dead
/// thread.
#[test]
fn survive_panic_turns_a_panic_into_none() {
    assert_eq!(survive_panic("a test", || 7), Some(7));
    assert_eq!(
        survive_panic("a test", || -> u8 { panic!("expected") }),
        None
    );
}

/// The Live Render tab's redraw is the committed design only: the Slice tool's planes
/// override applies to the editor's redraws and not to this one.
#[test]
fn a_committed_redraw_ignores_the_slice_override() {
    let sink = FakeSink::new();
    let state = SolidPreviewState::new(sink.clone());
    // An override that does not close, so which planes were drawn shows in the status.
    state.set_planes_override(Some(unbounded_planes()));

    state.request_redraw_committed_geometry(
        StoneGeometryBuf::from_halfspaces(&box_planes(0.6)),
        CAMERA,
        (16, 16),
        0,
        None,
    );
    let calls = sink.wait_until("the committed frame", DEADLINE, |c| !c.is_empty());
    assert!(calls[0].0);
    assert!(
        !calls[0].1.contains("Unbounded"),
        "the committed box was drawn, not the override: {}",
        calls[0].1
    );

    state.request_redraw(&box_planes(0.6), CAMERA, (16, 16), 0);
    let calls = sink.wait_until("the editor frame", DEADLINE, |c| c.len() >= 2);
    assert!(
        calls[1].1.contains("Unbounded"),
        "the editor's redraw still shows the override: {}",
        calls[1].1
    );
}

/// Builds a `RedrawRequest::Planned` request: [`build_planned_frame`] on
/// a `PlanJob`, then boxed. A test-only stand-in kept synchronous.
fn planned_request(
    design: Design,
    view_mode: u8,
    size: (u32, u32),
    generation: u64,
) -> RedrawRequest {
    let frame = build_planned_frame(
        PlanJob {
            size,
            view_mode,
            generation,
            ..plan_job(design)
        },
        live_update::DEFAULT_PREVIEW_BUDGET,
    );
    RedrawRequest::Planned(Box::new(frame))
}

#[test]
fn render_request_carries_solved_and_freshness_through_to_the_worker_frame() {
    let design = closed_design();
    let mut mesh_cache = MeshCache::default();
    let mut rasterizer = SolidRasterizer::new(16, 16);
    let mut edges_rasterizer = SolidRasterizer::new(16, 16);
    let mut memory = WorkerMemory::default();

    let frame = render_request(
        &mut mesh_cache,
        &mut rasterizer,
        &mut edges_rasterizer,
        &mut memory,
        planned_request(design, 0, (16, 16), 7),
    )
    .expect("a Planned request always resolves");
    assert!(frame.has_solid);
    assert!(!frame.stale);
    assert_eq!(frame.solved.map(|s| s.len()), Some(8));
    assert_eq!(
        frame.generation, 7,
        "the request's own generation must reach the finished frame unchanged"
    );
    assert!(
        frame.edges_image.is_none(),
        "view_mode 0 never builds edges"
    );
    assert!(
        frame.diagram_image.is_none(),
        "view_mode 0 never builds the diagram"
    );
}

/// A camera-follow `Reproject` after a `Planned` frame carries that frame's
/// generation forward but is NOT itself a planned frame -- `gui::solid_sink`'s
/// out-of-order guard must only ever apply to planned frames, or every orbit after a
/// redraw-only cache write (New/Load/Solve, a background solve) is dropped and the
/// solid raster freezes while the path tracer keeps turning.
#[test]
fn a_reproject_after_a_planned_frame_is_not_planned_but_keeps_its_generation() {
    let mut mesh_cache = MeshCache::default();
    let mut rasterizer = SolidRasterizer::new(16, 16);
    let mut edges_rasterizer = SolidRasterizer::new(16, 16);
    let mut memory = WorkerMemory::default();

    let planned = render_request(
        &mut mesh_cache,
        &mut rasterizer,
        &mut edges_rasterizer,
        &mut memory,
        planned_request(closed_design(), 0, (16, 16), 7),
    )
    .expect("a Planned request always resolves");
    assert!(
        planned.planned,
        "a Planned request must produce a planned frame"
    );
    let planes = planned.planes;

    let orbit = render_request(
        &mut mesh_cache,
        &mut rasterizer,
        &mut edges_rasterizer,
        &mut memory,
        RedrawRequest::Reproject {
            geometry: StoneGeometryBuf::from_halfspaces(&planes),
            camera: CameraPose {
                yaw: 1.0,
                pitch: 0.3,
                ..CAMERA
            },
            size: (16, 16),
            view_mode: 0,
            gear: None,
        },
    )
    .expect("a Reproject request always resolves");
    assert!(!orbit.planned, "an orbit frame must not count as planned");
    assert_eq!(
        orbit.generation, 7,
        "an orbit frame carries the last planned generation forward"
    );
    assert!(orbit.has_solid);
}

#[test]
fn view_mode_both_also_produces_an_edges_image() {
    let design = closed_design();
    let mut mesh_cache = MeshCache::default();
    let mut rasterizer = SolidRasterizer::new(16, 16);
    let mut edges_rasterizer = SolidRasterizer::new(16, 16);
    let mut memory = WorkerMemory::default();

    let frame = render_request(
        &mut mesh_cache,
        &mut rasterizer,
        &mut edges_rasterizer,
        &mut memory,
        planned_request(design, 2, (16, 16), 0),
    )
    .expect("a Planned request always resolves");
    assert!(frame.edges_image.is_some());
    assert!(
        frame.diagram_image.is_none(),
        "view_mode 2 never builds the diagram"
    );
}

/// View mode 3: the worker must build the 2D faceting diagram, its own pick
/// buffer, and the facet-id-indexed hover-text/tier tables a diagram click
/// needs -- see `PreviewFrame::diagram_hover_text`'s doc comment for why
/// those travel with the frame instead of being recomputed on the UI thread.
#[test]
fn view_mode_diagram_produces_the_diagram_image_and_its_side_tables() {
    let design = closed_design();
    let mut mesh_cache = MeshCache::default();
    let mut rasterizer = SolidRasterizer::new(16, 16);
    let mut edges_rasterizer = SolidRasterizer::new(16, 16);
    let mut memory = WorkerMemory::default();

    let frame = render_request(
        &mut mesh_cache,
        &mut rasterizer,
        &mut edges_rasterizer,
        &mut memory,
        planned_request(design, 3, (240, 120), 0),
    )
    .expect("a Planned request always resolves");
    assert!(frame.has_diagram);
    assert!(frame.diagram_image.is_some());
    let pick = frame
        .diagram_pick
        .expect("view_mode 3 must produce a diagram pick buffer");
    assert_eq!((pick.width, pick.height), (240, 120));
    // The index wheel's own tooth pick buffer must be threaded through
    // alongside the facet one, at the SAME size (both are built from the
    // same `DiagramFrame`).
    let tooth_pick = frame
        .diagram_tooth_pick
        .expect("view_mode 3 must also produce a tooth pick buffer");
    assert_eq!((tooth_pick.width, tooth_pick.height), (240, 120));
    let hover_text = frame
        .diagram_hover_text
        .expect("view_mode 3 must produce a facet-id-indexed hover-text table");
    assert_eq!(
        hover_text.len(),
        frame.diagram_facet_owners.as_ref().unwrap().flat.len()
    );
    assert_eq!(
        frame.diagram_facet_owners.as_ref().unwrap().concave.len(),
        hover_text.len(),
        "the concave table is parallel to the flat one"
    );
    // The Table tier's facet (id 0, right after the preform's own planes on
    // this fixture -- see `facet_map.rs`'s own doc comment) must have a
    // non-empty hover string and a resolved tier index somewhere in the table.
    assert!(hover_text.iter().any(|t| t.contains("Table")));
}

/// Every frame -- not just Diagram-mode ones -- must carry a real,
/// positive bounding radius once a solid has closed, so `render::
/// camera_lighting`'s orbit-zoom clamp/"Fit" pose never reads the
/// `DEFAULT_MESH_BOUNDING_RADIUS` placeholder for a design that
/// actually solved.
#[test]
fn replan_frame_carries_a_positive_mesh_bounding_radius() {
    let design = closed_design();
    let mut mesh_cache = MeshCache::default();
    let mut rasterizer = SolidRasterizer::new(16, 16);
    let mut edges_rasterizer = SolidRasterizer::new(16, 16);
    let mut memory = WorkerMemory::default();

    let frame = render_request(
        &mut mesh_cache,
        &mut rasterizer,
        &mut edges_rasterizer,
        &mut memory,
        planned_request(design, 0, (16, 16), 0),
    )
    .expect("a Planned request always resolves");
    assert!(frame.has_solid);
    assert!(frame.mesh_bounding_radius > 0.0);
}

/// A replan frame carries the mesh geometry the manipulation handles project
/// with: at the request's own size and camera pose, one centroid slot per plane.
#[test]
fn replan_frame_carries_geometry_at_the_request_size_and_pose() {
    let design = closed_design();
    let mut mesh_cache = MeshCache::default();
    let mut rasterizer = SolidRasterizer::new(16, 16);
    let mut edges_rasterizer = SolidRasterizer::new(16, 16);
    let mut memory = WorkerMemory::default();

    let frame = render_request(
        &mut mesh_cache,
        &mut rasterizer,
        &mut edges_rasterizer,
        &mut memory,
        planned_request(design, 0, (24, 20), 0),
    )
    .expect("a Planned request always resolves");
    let geometry = frame
        .geometry
        .expect("a closed design always carries geometry");
    assert_eq!(geometry.size, (24, 20));
    assert_eq!(geometry.camera, CAMERA);
    assert!(!geometry.corner_points.is_empty());
    assert_eq!(geometry.facet_centroids.len(), frame.planes.len());
    assert!((geometry.bounding_radius - frame.mesh_bounding_radius).abs() < 1e-12);
}

/// A `Reproject` frame carries geometry too, at the NEW pose and size.
#[test]
fn reproject_frame_carries_geometry_at_the_new_pose_and_size() {
    let design = closed_design();
    let mut mesh_cache = MeshCache::default();
    let mut rasterizer = SolidRasterizer::new(16, 16);
    let mut edges_rasterizer = SolidRasterizer::new(16, 16);
    let mut memory = WorkerMemory::default();

    let replan_frame = render_request(
        &mut mesh_cache,
        &mut rasterizer,
        &mut edges_rasterizer,
        &mut memory,
        planned_request(design, 0, (16, 16), 1),
    )
    .expect("a Planned request always resolves");
    let turned = CameraPose { yaw: 0.7, ..CAMERA };
    let reproject_frame = render_request(
        &mut mesh_cache,
        &mut rasterizer,
        &mut edges_rasterizer,
        &mut memory,
        RedrawRequest::Reproject {
            geometry: StoneGeometryBuf::from_halfspaces(&replan_frame.planes),
            camera: turned,
            size: (32, 24),
            view_mode: 0,
            gear: None,
        },
    )
    .expect("a Reproject request always resolves");
    let geometry = reproject_frame
        .geometry
        .expect("a Reproject frame carries geometry too");
    assert_eq!(geometry.size, (32, 24));
    assert_eq!(geometry.camera, turned);
    assert!(!geometry.corner_points.is_empty());
}

/// A `Reproject`/`UpdateFacetOverlay` frame carries no generation of its
/// own; it must reuse the last `Replan`'s generation.
#[test]
fn a_reproject_frame_carries_forward_the_last_replans_generation() {
    let design = closed_design();
    let mut mesh_cache = MeshCache::default();
    let mut rasterizer = SolidRasterizer::new(16, 16);
    let mut edges_rasterizer = SolidRasterizer::new(16, 16);
    let mut memory = WorkerMemory::default();

    let replan_frame = render_request(
        &mut mesh_cache,
        &mut rasterizer,
        &mut edges_rasterizer,
        &mut memory,
        planned_request(design, 0, (16, 16), 42),
    )
    .expect("a Planned request always resolves");
    assert_eq!(replan_frame.generation, 42);

    let reproject_frame = render_request(
        &mut mesh_cache,
        &mut rasterizer,
        &mut edges_rasterizer,
        &mut memory,
        RedrawRequest::Reproject {
            geometry: StoneGeometryBuf::from_halfspaces(&replan_frame.planes),
            camera: CAMERA,
            size: (16, 16),
            view_mode: 0,
            gear: None,
        },
    )
    .expect("a Reproject request always resolves");
    assert_eq!(
        reproject_frame.generation, 42,
        "a camera-follow reproject must not lose the last replan's generation"
    );
}