ifc-lite-geometry 4.1.3

// This Source Code Form is subject to the terms of the Mozilla Public
// License, v. 2.0. If a copy of the MPL was not distributed with this
// file, You can obtain one at https://mozilla.org/MPL/2.0/.

//! Tests for geometry processors.

use super::*;
use crate::router::GeometryProcessor;
use crate::TessellationQuality;
use ifc_lite_core::{EntityDecoder, IfcSchema, IfcType};

/// Read a fixture under `tests/models/`, returning `None` and printing a
/// `pnpm fixtures` hint if the file isn't present yet — either because it's
/// missing on a fresh clone, or because it's still a leftover Git LFS
/// pointer from before the move to `tests/models/manifest.json`.
fn read_fixture(rel: &str) -> Option<String> {
    let path = format!("../../tests/models/{}", rel);
    match std::fs::read_to_string(&path) {
        Ok(s) if s.starts_with("version https://git-lfs.github.com/spec/") => {
            eprintln!(
                "skipping: fixture {} is still a Git LFS pointer — run `pnpm fixtures` from the repo root to download the real bytes",
                path,
            );
            None
        }
        Ok(s) => Some(s),
        Err(e) if e.kind() == std::io::ErrorKind::NotFound => {
            eprintln!(
                "skipping: fixture {} not present — run `pnpm fixtures` to download (sha256 in tests/models/manifest.json)",
                path,
            );
            None
        }
        Err(e) => panic!("failed to read fixture {}: {}", path, e),
    }
}

#[test]
fn test_advanced_brep_file() {
    use crate::router::GeometryRouter;

    let Some(content) = read_fixture("ifcopenshell/advanced_brep.ifc") else { return };

    let entity_index = ifc_lite_core::build_entity_index(&content);
    let mut decoder = EntityDecoder::with_index(&content, entity_index);
    let router = GeometryRouter::new();

    // Process IFCBUILDINGELEMENTPROXY #181 which contains the AdvancedBrep geometry
    let element = decoder.decode_by_id(181).expect("Failed to decode element");
    assert_eq!(element.ifc_type, IfcType::IfcBuildingElementProxy);

    let mesh = router
        .process_element(&element, &mut decoder)
        .expect("Failed to process advanced brep");

    // Should produce geometry (B-spline surfaces tessellated)
    assert!(!mesh.is_empty(), "AdvancedBrep should produce geometry");
    assert!(
        mesh.positions.len() >= 3 * 100,
        "Should have significant geometry"
    );
    assert!(mesh.indices.len() >= 3 * 100, "Should have many triangles");
}

#[test]
fn test_extruded_area_solid() {
    let content = r#"
#1=IFCRECTANGLEPROFILEDEF(.AREA.,$,$,100.0,200.0);
#2=IFCDIRECTION((0.0,0.0,1.0));
#3=IFCEXTRUDEDAREASOLID(#1,$,#2,300.0);
"#;

    let mut decoder = EntityDecoder::new(content);
    let schema = IfcSchema::new();
    let processor = ExtrudedAreaSolidProcessor::new(schema.clone());

    let entity = decoder.decode_by_id(3).unwrap();
    let mesh = processor.process(&entity, &mut decoder, &schema, TessellationQuality::Medium).unwrap();

    assert!(!mesh.is_empty());
    assert!(!mesh.positions.is_empty());
    assert!(!mesh.indices.is_empty());
}

#[test]
fn test_triangulated_face_set() {
    let content = r#"
#1=IFCCARTESIANPOINTLIST3D(((0.0,0.0,0.0),(100.0,0.0,0.0),(50.0,100.0,0.0)));
#2=IFCTRIANGULATEDFACESET(#1,$,$,((1,2,3)),$);
"#;

    let mut decoder = EntityDecoder::new(content);
    let schema = IfcSchema::new();
    let processor = TriangulatedFaceSetProcessor::new();

    let entity = decoder.decode_by_id(2).unwrap();
    let mesh = processor.process(&entity, &mut decoder, &schema, TessellationQuality::Medium).unwrap();

    assert_eq!(mesh.positions.len(), 9); // 3 vertices * 3 coordinates
    assert_eq!(mesh.indices.len(), 3); // 1 triangle
}

#[test]
fn test_boolean_result_with_half_space() {
    // Simplified version of the 764--column.ifc structure
    let content = r#"
#1=IFCRECTANGLEPROFILEDEF(.AREA.,$,$,100.0,200.0);
#2=IFCDIRECTION((0.0,0.0,1.0));
#3=IFCEXTRUDEDAREASOLID(#1,$,#2,300.0);
#4=IFCCARTESIANPOINT((0.0,0.0,150.0));
#5=IFCDIRECTION((0.0,0.0,1.0));
#6=IFCAXIS2PLACEMENT3D(#4,#5,$);
#7=IFCPLANE(#6);
#8=IFCHALFSPACESOLID(#7,.T.);
#9=IFCBOOLEANRESULT(.DIFFERENCE.,#3,#8);
"#;

    let mut decoder = EntityDecoder::new(content);
    let schema = IfcSchema::new();
    let processor = BooleanClippingProcessor::new();

    // First verify the entity types are parsed correctly
    let bool_result = decoder.decode_by_id(9).unwrap();
    println!("BooleanResult type: {:?}", bool_result.ifc_type);
    assert_eq!(bool_result.ifc_type, IfcType::IfcBooleanResult);

    let half_space = decoder.decode_by_id(8).unwrap();
    println!("HalfSpaceSolid type: {:?}", half_space.ifc_type);
    assert_eq!(half_space.ifc_type, IfcType::IfcHalfSpaceSolid);

    // Now process the boolean result
    let mesh = processor
        .process(&bool_result, &mut decoder, &schema, TessellationQuality::Medium)
        .unwrap();
    println!("Mesh vertices: {}", mesh.positions.len() / 3);
    println!("Mesh triangles: {}", mesh.indices.len() / 3);

    // The mesh should have geometry (base extrusion clipped)
    assert!(!mesh.is_empty(), "BooleanResult should produce geometry");
    assert!(!mesh.positions.is_empty());
}

/// Regression test for T1.2: solid-solid `IfcBooleanResult.DIFFERENCE`.
///
/// Pre-T1.2 this was a hard-coded no-op (returned the first operand).
/// On the exact kernel it actually subtracts.
#[test]
fn solid_solid_difference_actually_cuts() {
    // 100×200×300 box with a 50×50×400 cutter punched through it.
    let content = r#"
#1=IFCRECTANGLEPROFILEDEF(.AREA.,$,$,100.0,200.0);
#2=IFCDIRECTION((0.0,0.0,1.0));
#3=IFCEXTRUDEDAREASOLID(#1,$,#2,300.0);
#11=IFCRECTANGLEPROFILEDEF(.AREA.,$,$,50.0,50.0);
#12=IFCDIRECTION((0.0,0.0,1.0));
#13=IFCAXIS2PLACEMENT3D(#14,$,$);
#14=IFCCARTESIANPOINT((0.0,0.0,-50.0));
#15=IFCEXTRUDEDAREASOLID(#11,#13,#12,400.0);
#20=IFCBOOLEANRESULT(.DIFFERENCE.,#3,#15);
"#;
    let mut decoder = EntityDecoder::new(content);
    let schema = IfcSchema::new();
    let processor = BooleanClippingProcessor::new();

    let bool_result = decoder.decode_by_id(20).unwrap();
    let cut_mesh = processor
        .process(&bool_result, &mut decoder, &schema, TessellationQuality::Medium)
        .expect("solid-solid difference must succeed");

    assert!(!cut_mesh.is_empty(), "result must have geometry");

    // Compare to the un-cut base extrusion: the cut should add boundary
    // triangles (the four side walls of the punched hole), so the
    // triangle count must increase.
    use crate::processors::extrusion::ExtrudedAreaSolidProcessor;
    let base = decoder.decode_by_id(3).unwrap();
    let base_mesh = ExtrudedAreaSolidProcessor::new(schema.clone())
        .process(&base, &mut decoder, &schema, TessellationQuality::Medium)
        .unwrap();
    assert!(
        cut_mesh.triangle_count() > base_mesh.triangle_count(),
        "cut mesh must have more triangles than base ({} vs {})",
        cut_mesh.triangle_count(),
        base_mesh.triangle_count(),
    );
    assert_eq!(
        processor.take_failures().len(),
        0,
        "no BoolFailure should fire on the happy solid-solid path",
    );
}

/// Regression test for T1.4: solid-solid `IfcBooleanResult.UNION`.
///
/// Pre-T1.4 this just merged meshes, retaining overlap. On the exact
/// kernel the overlap is removed by a real CSG union.
#[test]
fn solid_solid_union_removes_overlap() {
    // Two overlapping 100×100×100 boxes shifted along X by 50.
    let content = r#"
#1=IFCRECTANGLEPROFILEDEF(.AREA.,$,$,100.0,100.0);
#2=IFCDIRECTION((0.0,0.0,1.0));
#3=IFCEXTRUDEDAREASOLID(#1,$,#2,100.0);
#11=IFCAXIS2PLACEMENT3D(#12,$,$);
#12=IFCCARTESIANPOINT((50.0,0.0,0.0));
#13=IFCEXTRUDEDAREASOLID(#1,#11,#2,100.0);
#20=IFCBOOLEANRESULT(.UNION.,#3,#13);
"#;
    let mut decoder = EntityDecoder::new(content);
    let schema = IfcSchema::new();
    let processor = BooleanClippingProcessor::new();

    let bool_result = decoder.decode_by_id(20).unwrap();
    let union_mesh = processor
        .process(&bool_result, &mut decoder, &schema, TessellationQuality::Medium)
        .expect("solid-solid union must succeed");

    assert!(!union_mesh.is_empty());
    // Naive mesh-merge of two cubes produces exactly 24 triangles
    // (12 per cube, untouched). A real CSG union splits the overlapping
    // faces into new triangles at the intersection seam — the triangle
    // count differs (typically 28 in this configuration). Either way,
    // the failing pre-T1.4 path was the naive merge.
    assert_ne!(
        union_mesh.triangle_count(),
        24,
        "result has the naive mesh-merge triangle count — overlap not removed",
    );
    assert_eq!(
        processor.take_failures().len(),
        0,
        "no BoolFailure should fire on the happy union path",
    );

    // Bbox sanity: the union must span both cubes along X (0..150).
    let (min, max) = union_mesh.bounds();
    let half_w = 100.0_f32 * 0.5;
    let combined_min_x = -half_w; // box A is centred at origin
    let combined_max_x = 50.0 + half_w; // box B is centred at (50,0,0)
    assert!((min.x - combined_min_x).abs() < 1.0);
    assert!((max.x - combined_max_x).abs() < 1.0);
}

/// Regression test for T1.4: solid-solid `IfcBooleanResult.INTERSECTION`.
#[test]
fn solid_solid_intersection_returns_overlap() {
    // Same setup as union but operator INTERSECTION.
    let content = r#"
#1=IFCRECTANGLEPROFILEDEF(.AREA.,$,$,100.0,100.0);
#2=IFCDIRECTION((0.0,0.0,1.0));
#3=IFCEXTRUDEDAREASOLID(#1,$,#2,100.0);
#11=IFCAXIS2PLACEMENT3D(#12,$,$);
#12=IFCCARTESIANPOINT((50.0,0.0,0.0));
#13=IFCEXTRUDEDAREASOLID(#1,#11,#2,100.0);
#20=IFCBOOLEANRESULT(.INTERSECTION.,#3,#13);
"#;
    let mut decoder = EntityDecoder::new(content);
    let schema = IfcSchema::new();
    let processor = BooleanClippingProcessor::new();

    let bool_result = decoder.decode_by_id(20).unwrap();
    let inter_mesh = processor
        .process(&bool_result, &mut decoder, &schema, TessellationQuality::Medium)
        .expect("solid-solid intersection must succeed");

    // Pre-T1.4 this returned an empty mesh.
    assert!(
        !inter_mesh.is_empty(),
        "intersection of two overlapping boxes must be a non-empty volume",
    );
    assert_eq!(processor.take_failures().len(), 0);
}

#[test]
fn test_polygonal_bounded_half_space_respects_boundary() {
    let content = r#"
#1=IFCRECTANGLEPROFILEDEF(.AREA.,$,$,10.0,4.0);
#2=IFCDIRECTION((0.0,0.0,1.0));
#3=IFCEXTRUDEDAREASOLID(#1,$,#2,5.0);
#4=IFCCARTESIANPOINT((-5.0,0.0));
#5=IFCCARTESIANPOINT((5.0,0.0));
#6=IFCCARTESIANPOINT((5.0,3.0));
#7=IFCCARTESIANPOINT((-5.0,3.0));
#8=IFCPOLYLINE((#4,#5,#6,#7,#4));
#9=IFCCARTESIANPOINT((0.0,0.0,5.0));
#10=IFCDIRECTION((0.0,1.0,0.0));
#11=IFCDIRECTION((1.0,0.0,0.0));
#12=IFCAXIS2PLACEMENT3D(#9,#10,#11);
#13=IFCPLANE(#12);
#14=IFCAXIS2PLACEMENT3D(#9,#10,#11);
#15=IFCPOLYGONALBOUNDEDHALFSPACE(#13,.F.,#14,#8);
#16=IFCBOOLEANCLIPPINGRESULT(.DIFFERENCE.,#3,#15);
"#;

    let mut decoder = EntityDecoder::new(content);
    let schema = IfcSchema::new();
    let processor = BooleanClippingProcessor::new();

    let entity = decoder.decode_by_id(16).unwrap();
    let mesh = processor.process(&entity, &mut decoder, &schema, TessellationQuality::Medium).unwrap();

    assert!(
        !mesh.is_empty(),
        "Bounded half-space should still produce geometry"
    );

    let mut has_outer_base = false;
    let mut has_outer_top = false;
    let mut has_clipped_top = false;

    for position in mesh.positions.chunks_exact(3) {
        let y = position[1] as f64;
        let z = position[2] as f64;

        if y > 1.9 && z < 0.1 {
            has_outer_base = true;
        }
        if y > 1.9 && z > 4.9 {
            has_outer_top = true;
        }
        if y.abs() < 0.1 && z > 4.9 {
            has_clipped_top = true;
        }
    }

    assert!(
        has_outer_base,
        "The polygon boundary should only clip the upper strip, not the whole wall side"
    );
    assert!(
        !has_outer_top,
        "The clipped strip should be removed at the top of the bounded region"
    );
    assert!(
        has_clipped_top,
        "The bounded clip should create a new top edge at the cut boundary"
    );
}

#[test]
fn test_764_column_file() {
    use crate::router::GeometryRouter;

    let Some(content) = read_fixture(
        "ifcopenshell/764--column--no-materials-or-surface-styles-found--augmented.ifc",
    ) else {
        return;
    };

    let entity_index = ifc_lite_core::build_entity_index(&content);
    let mut decoder = EntityDecoder::with_index(&content, entity_index);
    let router = GeometryRouter::new();

    // Decode IFCCOLUMN #8930
    let column = decoder.decode_by_id(8930).expect("Failed to decode column");
    println!("Column type: {:?}", column.ifc_type);
    assert_eq!(column.ifc_type, IfcType::IfcColumn);

    // Check representation attribute
    let rep_attr = column
        .get(6)
        .expect("Column missing representation attribute");
    println!("Representation attr: {:?}", rep_attr);

    // Try process_element
    match router.process_element(&column, &mut decoder) {
        Ok(mesh) => {
            println!("Mesh vertices: {}", mesh.positions.len() / 3);
            println!("Mesh triangles: {}", mesh.indices.len() / 3);
            assert!(!mesh.is_empty(), "Column should produce geometry");
        }
        Err(e) => {
            panic!("Failed to process column: {:?}", e);
        }
    }
}

#[test]
fn test_wall_with_opening_file() {
    use crate::router::GeometryRouter;

    let Some(content) = read_fixture("buildingsmart/wall-with-opening-and-window.ifc") else {
        return;
    };

    let entity_index = ifc_lite_core::build_entity_index(&content);
    let mut decoder = EntityDecoder::with_index(&content, entity_index);
    let router = GeometryRouter::new();

    // Decode IFCWALL #45
    let wall = match decoder.decode_by_id(45) {
        Ok(w) => w,
        Err(e) => panic!("Failed to decode wall: {:?}", e),
    };
    println!("Wall type: {:?}", wall.ifc_type);
    assert_eq!(wall.ifc_type, IfcType::IfcWall);

    // Check representation attribute (should be at index 6)
    let rep_attr = wall.get(6).expect("Wall missing representation attribute");
    println!("Representation attr: {:?}", rep_attr);

    // Try process_element
    match router.process_element(&wall, &mut decoder) {
        Ok(mesh) => {
            println!("Wall mesh vertices: {}", mesh.positions.len() / 3);
            println!("Wall mesh triangles: {}", mesh.indices.len() / 3);
            assert!(!mesh.is_empty(), "Wall should produce geometry");
        }
        Err(e) => {
            panic!("Failed to process wall: {:?}", e);
        }
    }

    // Also test window
    let window = decoder.decode_by_id(102).expect("Failed to decode window");
    println!("Window type: {:?}", window.ifc_type);
    assert_eq!(window.ifc_type, IfcType::IfcWindow);

    match router.process_element(&window, &mut decoder) {
        Ok(mesh) => {
            println!("Window mesh vertices: {}", mesh.positions.len() / 3);
            println!("Window mesh triangles: {}", mesh.indices.len() / 3);
        }
        Err(e) => {
            println!("Window error (might be expected): {:?}", e);
        }
    }
}

/// Test that ShellBasedSurfaceModel with IfcAdvancedFace produces geometry.
///
/// CATIA and similar NURBS-based CAD exporters produce SurfaceModel representations
/// containing IfcOpenShell with IfcAdvancedFace entities (B-spline surfaces, planes,
/// cylindrical surfaces). This test verifies the processor handles that correctly
/// instead of silently skipping the faces.
///
/// Addresses: https://github.com/LTplus-AG/ifc-lite/issues/472
#[test]
fn test_shell_based_surface_model_with_advanced_faces() {
    // Minimal IFC snippet: ShellBasedSurfaceModel -> OpenShell -> AdvancedFace (planar)
    // This mimics the CATIA export pattern from issue #472
    let content = r#"
#1=IFCCARTESIANPOINT((0.,0.,0.));
#2=IFCCARTESIANPOINT((100.,0.,0.));
#3=IFCCARTESIANPOINT((100.,100.,0.));
#4=IFCCARTESIANPOINT((0.,100.,0.));
#5=IFCVERTEXPOINT(#1);
#6=IFCVERTEXPOINT(#2);
#7=IFCVERTEXPOINT(#3);
#8=IFCVERTEXPOINT(#4);
#9=IFCDIRECTION((0.,0.,1.));
#10=IFCDIRECTION((1.,0.,0.));
#11=IFCAXIS2PLACEMENT3D(#1,#9,#10);
#12=IFCPLANE(#11);
#13=IFCLINE(#1,#20);
#14=IFCLINE(#2,#21);
#15=IFCLINE(#3,#22);
#16=IFCLINE(#4,#23);
#20=IFCVECTOR(#24,1.);
#21=IFCVECTOR(#25,1.);
#22=IFCVECTOR(#26,1.);
#23=IFCVECTOR(#27,1.);
#24=IFCDIRECTION((1.,0.,0.));
#25=IFCDIRECTION((0.,1.,0.));
#26=IFCDIRECTION((-1.,0.,0.));
#27=IFCDIRECTION((0.,-1.,0.));
#30=IFCEDGECURVE(#5,#6,#13,.T.);
#31=IFCEDGECURVE(#6,#7,#14,.T.);
#32=IFCEDGECURVE(#7,#8,#15,.T.);
#33=IFCEDGECURVE(#8,#5,#16,.T.);
#40=IFCORIENTEDEDGE(*,*,#30,.T.);
#41=IFCORIENTEDEDGE(*,*,#31,.T.);
#42=IFCORIENTEDEDGE(*,*,#32,.T.);
#43=IFCORIENTEDEDGE(*,*,#33,.T.);
#50=IFCEDGELOOP((#40,#41,#42,#43));
#51=IFCFACEOUTERBOUND(#50,.T.);
#52=IFCADVANCEDFACE((#51),#12,.T.);
#53=IFCOPENSHELL((#52));
#54=IFCSHELLBASEDSURFACEMODEL((#53));
"#;

    let mut decoder = EntityDecoder::new(content);
    let schema = IfcSchema::new();
    let processor = ShellBasedSurfaceModelProcessor::new();

    let entity = decoder.decode_by_id(54).unwrap();
    assert_eq!(entity.ifc_type, IfcType::IfcShellBasedSurfaceModel);

    let mesh = processor
        .process(&entity, &mut decoder, &schema, TessellationQuality::Medium)
        .expect("Failed to process ShellBasedSurfaceModel with AdvancedFace");

    // Should produce geometry from the planar AdvancedFace
    assert!(
        !mesh.is_empty(),
        "ShellBasedSurfaceModel with AdvancedFace should produce geometry"
    );
    assert!(
        mesh.positions.len() >= 12,
        "Should have at least 4 vertices (quad face): got {} floats",
        mesh.positions.len()
    );
    assert!(
        mesh.indices.len() >= 6,
        "Should have at least 2 triangles: got {} indices",
        mesh.indices.len()
    );
}

/// Test that ShellBasedSurfaceModel still works with simple PolyLoop faces
/// (regression test to ensure AdvancedFace support doesn't break simple faces)
#[test]
fn test_shell_based_surface_model_with_polyloop() {
    let content = r#"
#1=IFCCARTESIANPOINT((0.,0.,0.));
#2=IFCCARTESIANPOINT((100.,0.,0.));
#3=IFCCARTESIANPOINT((100.,100.,0.));
#4=IFCCARTESIANPOINT((0.,100.,0.));
#10=IFCPOLYLOOP((#1,#2,#3,#4));
#11=IFCFACEOUTERBOUND(#10,.T.);
#12=IFCFACE((#11));
#13=IFCOPENSHELL((#12));
#14=IFCSHELLBASEDSURFACEMODEL((#13));
"#;

    let mut decoder = EntityDecoder::new(content);
    let schema = IfcSchema::new();
    let processor = ShellBasedSurfaceModelProcessor::new();

    let entity = decoder.decode_by_id(14).unwrap();
    let mesh = processor
        .process(&entity, &mut decoder, &schema, TessellationQuality::Medium)
        .expect("Failed to process ShellBasedSurfaceModel with PolyLoop");

    assert!(
        !mesh.is_empty(),
        "ShellBasedSurfaceModel with PolyLoop should still produce geometry"
    );
    assert_eq!(
        mesh.positions.len(),
        12,
        "Should have 4 vertices (12 floats)"
    );
    assert_eq!(mesh.indices.len(), 6, "Should have 2 triangles (6 indices)");
}

/// Test with the actual CATIA file from issue #472.
/// Verifies that all 306 AdvancedFaces (145 B-spline, 115 planar,
/// 38 linear extrusion, 8 cylindrical) produce geometry.
#[test]
fn test_catia_surface_model_file() {
    use crate::router::GeometryRouter;

    let path = "../../tests/models/various/2222.ifc";
    let content = match std::fs::read_to_string(path) {
        Ok(c) => c,
        Err(_) => {
            eprintln!("Skipping test_catia_surface_model_file: {} not found", path);
            return;
        }
    };

    let entity_index = ifc_lite_core::build_entity_index(&content);
    let mut decoder = EntityDecoder::with_index(&content, entity_index);
    let router = GeometryRouter::with_units(&content, &mut decoder);

    // IfcRamp #7963 has SurfaceModel with AdvancedFaces (B-spline, plane,
    // linear extrusion, cylindrical surfaces)
    let ramp = decoder.decode_by_id(7963).expect("Failed to decode IfcRamp #7963");
    assert_eq!(ramp.ifc_type, IfcType::IfcRamp);

    let mesh = router
        .process_element(&ramp, &mut decoder)
        .expect("Failed to process CATIA IfcRamp SurfaceModel");

    println!(
        "CATIA IfcRamp: {} vertices, {} triangles",
        mesh.positions.len() / 3,
        mesh.indices.len() / 3
    );

    // Should produce significant geometry from all surface types
    assert!(
        !mesh.is_empty(),
        "CATIA SurfaceModel should produce geometry"
    );
    assert!(
        mesh.positions.len() / 3 > 500,
        "Should have >500 vertices from AdvancedFaces, got {}",
        mesh.positions.len() / 3
    );
}

#[test]
fn test_triangulated_face_set_out_of_bounds_indices() {
    // Simulates a Revit export with indices beyond vertex count (issue #471)
    let content = r#"
#1=IFCCARTESIANPOINTLIST3D(((0.0,0.0,0.0),(100.0,0.0,0.0),(50.0,100.0,0.0)));
#2=IFCTRIANGULATEDFACESET(#1,$,$,((1,2,3),(1,2,99)),$);
"#;

    let mut decoder = EntityDecoder::new(content);
    let schema = IfcSchema::new();
    let processor = TriangulatedFaceSetProcessor::new();

    let entity = decoder.decode_by_id(2).unwrap();
    let mesh = processor.process(&entity, &mut decoder, &schema, TessellationQuality::Medium).unwrap();

    // Should produce valid mesh — the out-of-bounds triangle (1,2,99) is stripped
    assert!(!mesh.is_empty());
    // Only 1 valid triangle should remain (indices 0,1,2)
    assert_eq!(mesh.indices.len(), 3, "Should have exactly 1 valid triangle");
    assert!(mesh.indices.iter().all(|&i| (i as usize) < mesh.positions.len() / 3));
}

#[test]
fn test_triangulated_face_set_all_invalid_indices() {
    // All indices are beyond vertex count — should produce empty mesh
    let content = r#"
#1=IFCCARTESIANPOINTLIST3D(((0.0,0.0,0.0),(1.0,0.0,0.0),(0.0,1.0,0.0)));
#2=IFCTRIANGULATEDFACESET(#1,$,$,((10,20,30)),$);
"#;

    let mut decoder = EntityDecoder::new(content);
    let schema = IfcSchema::new();
    let processor = TriangulatedFaceSetProcessor::new();

    let entity = decoder.decode_by_id(2).unwrap();
    let mesh = processor.process(&entity, &mut decoder, &schema, TessellationQuality::Medium).unwrap();

    // All indices invalid — mesh should have positions but no valid triangles
    assert!(mesh.indices.is_empty(), "All invalid indices should be stripped");
}

#[test]
fn test_extruded_area_solid_tapered() {
    // Mirrors the structure of the IFC sample in issue #628: a beam tapering
    // from 200x200 at the base to 200x600 at the top, extruded 2000 along Z.
    let content = r#"
#1=IFCCARTESIANPOINT((0.,0.));
#2=IFCDIRECTION((1.,0.));
#3=IFCAXIS2PLACEMENT2D(#1,#2);
#4=IFCRECTANGLEPROFILEDEF(.AREA.,'Start',#3,200.,200.);
#5=IFCRECTANGLEPROFILEDEF(.AREA.,'End',#3,200.,600.);
#6=IFCCARTESIANPOINT((0.,0.,0.));
#7=IFCAXIS2PLACEMENT3D(#6,$,$);
#8=IFCDIRECTION((0.,0.,1.));
#9=IFCEXTRUDEDAREASOLIDTAPERED(#4,#7,#8,2000.,#5);
"#;

    let mut decoder = EntityDecoder::new(content);
    let schema = IfcSchema::new();
    let processor = ExtrudedAreaSolidTaperedProcessor::new(schema.clone());

    let entity = decoder.decode_by_id(9).unwrap();
    assert_eq!(entity.ifc_type, IfcType::IfcExtrudedAreaSolidTapered);
    let mesh = processor.process(&entity, &mut decoder, &schema, TessellationQuality::Medium).unwrap();

    assert!(!mesh.is_empty());
    let (min, max) = mesh.bounds();
    // Bottom rectangle is 200x200 → ±100 in both X and Y at z=0.
    // Top rectangle is 200x600 → ±100 in X but ±300 in Y at z=2000.
    // Bounding box of the union is (±100, ±300, 0..2000).
    assert!((min.x - -100.0).abs() < 0.01, "min.x = {}", min.x);
    assert!((max.x - 100.0).abs() < 0.01, "max.x = {}", max.x);
    assert!((min.y - -300.0).abs() < 0.01, "min.y = {}", min.y);
    assert!((max.y - 300.0).abs() < 0.01, "max.y = {}", max.y);
    assert!((min.z - 0.0).abs() < 0.01);
    assert!((max.z - 2000.0).abs() < 0.01);
}

/// Issue #631, sample `IfcReinforcingBar.ifc` (stirrup).
///
/// `IfcSweptDiskSolid` directrix is an `IfcIndexedPolyCurve` over an
/// `IfcCartesianPointList3D`. Before this fix the 3D curve dispatcher had no
/// arm for `IfcIndexedPolyCurve`, so points were re-read as 2D and collapsed
/// onto z=0 — the stirrup rendered as a flat near-zero-length line. Verify
/// that the swept tube spans the full Z range of the input points.
#[test]
fn test_swept_disk_indexed_polycurve_3d() {
    // A simple 3D arc: start (0,0,0), mid (10,0,10), end (20,0,0).
    // This lives in the XZ plane — Y stays zero, Z varies non-trivially.
    let content = r#"
#1=IFCCARTESIANPOINTLIST3D(((0.0,0.0,0.0),(10.0,0.0,10.0),(20.0,0.0,0.0)));
#2=IFCINDEXEDPOLYCURVE(#1,(IFCARCINDEX((1,2,3))),.F.);
#3=IFCSWEPTDISKSOLID(#2,1.0,$,$,$);
"#;

    let mut decoder = EntityDecoder::new(content);
    let schema = IfcSchema::new();
    let processor = SweptDiskSolidProcessor::new(schema.clone());

    let entity = decoder.decode_by_id(3).unwrap();
    assert_eq!(entity.ifc_type, IfcType::IfcSweptDiskSolid);
    let mesh = processor.process(&entity, &mut decoder, &schema, TessellationQuality::Medium).unwrap();

    assert!(!mesh.is_empty(), "3D indexed polycurve directrix should produce geometry");

    let (min, max) = mesh.bounds();
    // The tube radius is 1.0, so Z extent of the mesh should be close to
    // (arc max Z + radius) - (-radius) ≈ 11. Without this fix the directrix
    // collapses to a 1-D line on x and Z extent is ~2 (just the tube radius
    // around z=0).
    let z_extent = (max.z - min.z) as f64;
    assert!(
        z_extent > 5.0,
        "stirrup arc should span its declared 3D Z range; got z_extent={}",
        z_extent
    );
}

/// Issue #631, sample `Rebar2.ifc`.
///
/// The directrix is a planar `IfcCompositeCurve` whose arc segments are
/// authored as `IfcTrimmedCurve` over an `IfcCircle` placed by
/// `IfcAxis2Placement3D`. `get_placement_2d` used to read attribute index 1 of
/// the placement as `RefDirection`, but on a 3D placement that index is the
/// `Axis` (Z direction). Every arc came back with rotation=0° regardless of
/// the file's actual `RefDirection`, twisting each bend by the file's
/// authored angle — visibly distorting Revit-exported bent rebar.
///
/// Verify that an arc anchored to `IfcAxis2Placement3D` with `RefDirection`
/// rotated 90° actually rotates: the bottom of the arc (parameter 270°) lands
/// at the rotated +X direction, not at world -Y.
#[test]
fn test_trimmed_circle_3d_placement_reads_ref_direction() {
    // Circle radius 10, centred at (100, 100, 0), placed in XY plane with
    // RefDirection = +Y (rotation 90°). A 270° trim with sense=T produces a
    // point at radius * (cos(270°+90°), sin(270°+90°)) = (10, 0) in the local
    // frame ⇒ (100 + 10*cos(90°), 100 + 10*sin(90°)) ≈ (100, 110) in world.
    //
    // Without the fix the rotation reads as 0° (the Z-axis x/y components),
    // so 270° lands at (100, 90) — visibly off.
    // Project + IFCCONVERSIONBASEDUNIT 'DEGREE' makes the IFCPARAMETERVALUE
    // trim parameters below explicitly degrees. Without this, the spec
    // default (RADIAN) interprets 270 as 270 rad ≈ 43 revolutions and the
    // arc samples come out wrong (see EntityDecoder::plane_angle_to_radians).
    let content = r#"
#1=IFCCARTESIANPOINT((100.0,100.0,0.0));
#2=IFCDIRECTION((0.0,0.0,1.0));
#3=IFCDIRECTION((0.0,1.0,0.0));
#4=IFCAXIS2PLACEMENT3D(#1,#2,#3);
#5=IFCCIRCLE(#4,10.0);
#6=IFCTRIMMEDCURVE(#5,(IFCPARAMETERVALUE(270.0)),(IFCPARAMETERVALUE(0.0)),.T.,.PARAMETER.);
#7=IFCCOMPOSITECURVESEGMENT(.CONTINUOUS.,.T.,#6);
#8=IFCCOMPOSITECURVE((#7),.F.);
#9=IFCSWEPTDISKSOLID(#8,0.5,$,$,$);
#10=IFCPROJECT('p',$,'Test',$,$,$,$,(#11),#12);
#11=IFCGEOMETRICREPRESENTATIONCONTEXT($,'Model',3,1.E-5,#4,$);
#12=IFCUNITASSIGNMENT((#13,#14));
#13=IFCSIUNIT(*,.LENGTHUNIT.,$,.METRE.);
#14=IFCCONVERSIONBASEDUNIT(#15,.PLANEANGLEUNIT.,'DEGREE',#16);
#15=IFCDIMENSIONALEXPONENTS(0,0,0,0,0,0,0);
#16=IFCMEASUREWITHUNIT(IFCRATIOMEASURE(0.0174532925199433),#17);
#17=IFCSIUNIT(*,.PLANEANGLEUNIT.,$,.RADIAN.);
"#;

    let mut decoder = EntityDecoder::new(content);
    let schema = IfcSchema::new();
    let processor = SweptDiskSolidProcessor::new(schema.clone());

    let entity = decoder.decode_by_id(9).unwrap();
    let mesh = processor.process(&entity, &mut decoder, &schema, TessellationQuality::Medium).unwrap();
    assert!(!mesh.is_empty());

    let (_min, max) = mesh.bounds();
    // With RefDirection respected (90° rotation), the trim from 270° to 360°
    // sweeps from local-frame "below center" to local-frame "right of center";
    // in world that maps to "left of center" to "below center" because +X
    // local = +Y world. Mesh extents should clear well above center.y - radius
    // in the bug case (would otherwise stay near y=100-r).
    assert!(
        (max.y as f64) > 105.0,
        "Arc should rotate with RefDirection — max.y={} suggests rotation was ignored",
        max.y
    );
}

#[test]
fn test_extruded_area_solid_tapered_falls_back_when_end_missing() {
    // A malformed file with no EndSweptArea should still render as a uniform
    // extrusion of the start profile.
    let content = r#"
#1=IFCCARTESIANPOINT((0.,0.));
#2=IFCDIRECTION((1.,0.));
#3=IFCAXIS2PLACEMENT2D(#1,#2);
#4=IFCRECTANGLEPROFILEDEF(.AREA.,'Start',#3,100.,100.);
#5=IFCCARTESIANPOINT((0.,0.,0.));
#6=IFCAXIS2PLACEMENT3D(#5,$,$);
#7=IFCDIRECTION((0.,0.,1.));
#8=IFCEXTRUDEDAREASOLIDTAPERED(#4,#6,#7,500.,$);
"#;

    let mut decoder = EntityDecoder::new(content);
    let schema = IfcSchema::new();
    let processor = ExtrudedAreaSolidTaperedProcessor::new(schema.clone());

    let entity = decoder.decode_by_id(8).unwrap();
    let mesh = processor.process(&entity, &mut decoder, &schema, TessellationQuality::Medium).unwrap();
    assert!(!mesh.is_empty());
    let (_min, max) = mesh.bounds();
    assert!((max.z - 500.0).abs() < 0.01);
    assert!((max.x - 50.0).abs() < 0.01);
}

// ---------------------------------------------------------------------------
// Regression: schependomlaan "zinkwerk" misformed coverings
// ---------------------------------------------------------------------------
//
// IfcShellBasedSurfaceModel / IfcFaceBasedSurfaceModel used a naive fan
// triangulation ("works for convex faces") and silently dropped hole bounds.
// Zinc-flashing coverings in schependomlaan author CONCAVE folded sheet-metal
// faces; fanning from vertex 0 sweeps triangles ACROSS the concavity, emitting
// flipped "flap" triangles outside the polygon (mesh area up to 2.44x the
// authored area, e.g. covering #974441 / 2U4A8Ms4v0auESKMfvz85Y: 17.42 m²
// rendered vs 7.15 m² authored). The fix routes both surface-model processors
// through the shared `FacetedBrepProcessor::triangulate_face` (convexity test
// + ear clipping + hole support).
//
// These tests use a U-shaped (channel) face that is NOT star-shaped from
// vertex 0: authored area 9.0; the old fan emitted 17.0 of triangle area
// (including an inverted flap across the notch), so they fail before the fix
// and pass after.

/// Sum of unsigned triangle areas of a mesh (f64 accumulation).
fn mesh_surface_area(mesh: &crate::mesh::Mesh) -> f64 {
    let p = &mesh.positions;
    let mut area = 0.0f64;
    for tri in mesh.indices.chunks_exact(3) {
        let (a, b, c) = (tri[0] as usize * 3, tri[1] as usize * 3, tri[2] as usize * 3);
        let v0 = [p[a] as f64, p[a + 1] as f64, p[a + 2] as f64];
        let v1 = [p[b] as f64, p[b + 1] as f64, p[b + 2] as f64];
        let v2 = [p[c] as f64, p[c + 1] as f64, p[c + 2] as f64];
        let e1 = [v1[0] - v0[0], v1[1] - v0[1], v1[2] - v0[2]];
        let e2 = [v2[0] - v0[0], v2[1] - v0[1], v2[2] - v0[2]];
        let cx = e1[1] * e2[2] - e1[2] * e2[1];
        let cy = e1[2] * e2[0] - e1[0] * e2[2];
        let cz = e1[0] * e2[1] - e1[1] * e2[0];
        area += 0.5 * (cx * cx + cy * cy + cz * cz).sqrt();
    }
    area
}

/// U-shaped (channel) concave face, area = 5x3 outer - 3x2 notch = 9.0.
/// Not star-shaped from vertex 0: the old fan triangulation emitted a
/// flipped triangle across the notch (total unsigned area 17.0).
const CONCAVE_U_FACE_POINTS: &str = r#"
#1=IFCCARTESIANPOINT((0.,0.,0.));
#2=IFCCARTESIANPOINT((5.,0.,0.));
#3=IFCCARTESIANPOINT((5.,3.,0.));
#4=IFCCARTESIANPOINT((4.,3.,0.));
#5=IFCCARTESIANPOINT((4.,1.,0.));
#6=IFCCARTESIANPOINT((1.,1.,0.));
#7=IFCCARTESIANPOINT((1.,3.,0.));
#8=IFCCARTESIANPOINT((0.,3.,0.));
#10=IFCPOLYLOOP((#1,#2,#3,#4,#5,#6,#7,#8));
#11=IFCFACEOUTERBOUND(#10,.T.);
#12=IFCFACE((#11));
"#;

#[test]
fn test_shell_based_surface_model_concave_face_no_fan_flap() {
    let content = format!(
        "{CONCAVE_U_FACE_POINTS}#13=IFCOPENSHELL((#12));\n#14=IFCSHELLBASEDSURFACEMODEL((#13));\n"
    );

    let mut decoder = EntityDecoder::new(&content);
    let schema = IfcSchema::new();
    let processor = ShellBasedSurfaceModelProcessor::new();

    let entity = decoder.decode_by_id(14).unwrap();
    let mesh = processor
        .process(&entity, &mut decoder, &schema, TessellationQuality::Medium)
        .expect("concave shell-based surface model must tessellate");

    let area = mesh_surface_area(&mesh);
    assert!(
        (area - 9.0).abs() < 1e-3,
        "mesh area must equal the authored face area 9.0 (naive fan emits 17.0 \
         with a flipped flap across the concavity), got {area}"
    );
}

#[test]
fn test_face_based_surface_model_concave_face_no_fan_flap() {
    let content = format!(
        "{CONCAVE_U_FACE_POINTS}#13=IFCCONNECTEDFACESET((#12));\n#14=IFCFACEBASEDSURFACEMODEL((#13));\n"
    );

    let mut decoder = EntityDecoder::new(&content);
    let schema = IfcSchema::new();
    let processor = FaceBasedSurfaceModelProcessor::new();

    let entity = decoder.decode_by_id(14).unwrap();
    let mesh = processor
        .process(&entity, &mut decoder, &schema, TessellationQuality::Medium)
        .expect("concave face-based surface model must tessellate");

    let area = mesh_surface_area(&mesh);
    assert!(
        (area - 9.0).abs() < 1e-3,
        "mesh area must equal the authored face area 9.0 (naive fan emits 17.0 \
         with a flipped flap across the concavity), got {area}"
    );
}

#[test]
fn test_shell_based_surface_model_hole_bound_not_dropped() {
    // 10x10 outer with a 2x2 hole: area = 96. The old path ignored the
    // IFCFACEBOUND entirely and emitted the full 100.0 outer quad.
    let content = r#"
#1=IFCCARTESIANPOINT((0.,0.,0.));
#2=IFCCARTESIANPOINT((10.,0.,0.));
#3=IFCCARTESIANPOINT((10.,10.,0.));
#4=IFCCARTESIANPOINT((0.,10.,0.));
#5=IFCCARTESIANPOINT((4.,4.,0.));
#6=IFCCARTESIANPOINT((6.,4.,0.));
#7=IFCCARTESIANPOINT((6.,6.,0.));
#8=IFCCARTESIANPOINT((4.,6.,0.));
#10=IFCPOLYLOOP((#1,#2,#3,#4));
#11=IFCFACEOUTERBOUND(#10,.T.);
#12=IFCPOLYLOOP((#5,#6,#7,#8));
#13=IFCFACEBOUND(#12,.T.);
#14=IFCFACE((#11,#13));
#15=IFCOPENSHELL((#14));
#16=IFCSHELLBASEDSURFACEMODEL((#15));
"#;

    let mut decoder = EntityDecoder::new(content);
    let schema = IfcSchema::new();
    let processor = ShellBasedSurfaceModelProcessor::new();

    let entity = decoder.decode_by_id(16).unwrap();
    let mesh = processor
        .process(&entity, &mut decoder, &schema, TessellationQuality::Medium)
        .expect("shell-based surface model with hole must tessellate");

    let area = mesh_surface_area(&mesh);
    assert!(
        (area - 96.0).abs() < 1e-3,
        "mesh area must be outer minus hole = 96.0 (the old path dropped the \
         hole bound and emitted 100.0), got {area}"
    );
}

/// Issue #1661: an advanced-face boundary edge whose geometry is an
/// IfcTrimmedCurve over an IfcCircle collapsed to a single vertex (only the
/// exact strings IFCBSPLINECURVEWITHKNOTS/IFCCIRCLE were sampled), so a
/// half-disc face bounded by one arc + one line had a 2-point loop and was
/// silently dropped. CATIA wall exports hit this constantly.
#[test]
fn test_advanced_face_trimmed_circle_edge_sampled() {
    let content = r#"
#1=IFCCARTESIANPOINT((50.,0.,0.));
#2=IFCCARTESIANPOINT((-50.,0.,0.));
#3=IFCCARTESIANPOINT((0.,0.,0.));
#5=IFCVERTEXPOINT(#1);
#6=IFCVERTEXPOINT(#2);
#9=IFCDIRECTION((0.,0.,1.));
#10=IFCDIRECTION((1.,0.,0.));
#11=IFCAXIS2PLACEMENT3D(#3,#9,#10);
#12=IFCPLANE(#11);
#13=IFCCIRCLE(#11,50.);
#14=IFCTRIMMEDCURVE(#13,(#1),(#2),.T.,.CARTESIAN.);
#15=IFCLINE(#2,#20);
#20=IFCVECTOR(#21,1.);
#21=IFCDIRECTION((1.,0.,0.));
#30=IFCEDGECURVE(#5,#6,#14,.T.);
#31=IFCEDGECURVE(#6,#5,#15,.T.);
#40=IFCORIENTEDEDGE(*,*,#30,.T.);
#41=IFCORIENTEDEDGE(*,*,#31,.T.);
#50=IFCEDGELOOP((#40,#41));
#51=IFCFACEOUTERBOUND(#50,.T.);
#52=IFCADVANCEDFACE((#51),#12,.T.);
#53=IFCOPENSHELL((#52));
#54=IFCSHELLBASEDSURFACEMODEL((#53));
"#;

    let mut decoder = EntityDecoder::new(content);
    let schema = IfcSchema::new();
    let processor = ShellBasedSurfaceModelProcessor::new();

    let entity = decoder.decode_by_id(54).unwrap();
    let mesh = processor
        .process(&entity, &mut decoder, &schema, TessellationQuality::Medium)
        .expect("half-disc face with trimmed-circle edge must tessellate");

    assert!(
        mesh.positions.len() / 3 >= 5,
        "arc edge must contribute intermediate samples, got {} vertices",
        mesh.positions.len() / 3
    );
    let area = mesh_surface_area(&mesh);
    let expected = std::f64::consts::PI * 50.0 * 50.0 / 2.0;
    assert!(
        (area - expected).abs() < expected * 0.1,
        "half-disc area should be ~{expected:.0}, got {area:.0} (single-vertex \
         collapse yields an empty mesh)"
    );
}

/// Issue #1661: IfcEllipse edge geometry fell to the start-vertex-only branch.
#[test]
fn test_advanced_face_ellipse_edge_sampled() {
    let content = r#"
#1=IFCCARTESIANPOINT((50.,0.,0.));
#2=IFCCARTESIANPOINT((-50.,0.,0.));
#3=IFCCARTESIANPOINT((0.,0.,0.));
#5=IFCVERTEXPOINT(#1);
#6=IFCVERTEXPOINT(#2);
#9=IFCDIRECTION((0.,0.,1.));
#10=IFCDIRECTION((1.,0.,0.));
#11=IFCAXIS2PLACEMENT3D(#3,#9,#10);
#12=IFCPLANE(#11);
#13=IFCELLIPSE(#11,50.,25.);
#15=IFCLINE(#2,#20);
#20=IFCVECTOR(#21,1.);
#21=IFCDIRECTION((1.,0.,0.));
#30=IFCEDGECURVE(#5,#6,#13,.T.);
#31=IFCEDGECURVE(#6,#5,#15,.T.);
#40=IFCORIENTEDEDGE(*,*,#30,.T.);
#41=IFCORIENTEDEDGE(*,*,#31,.T.);
#50=IFCEDGELOOP((#40,#41));
#51=IFCFACEOUTERBOUND(#50,.T.);
#52=IFCADVANCEDFACE((#51),#12,.T.);
#53=IFCOPENSHELL((#52));
#54=IFCSHELLBASEDSURFACEMODEL((#53));
"#;

    let mut decoder = EntityDecoder::new(content);
    let schema = IfcSchema::new();
    let processor = ShellBasedSurfaceModelProcessor::new();

    let entity = decoder.decode_by_id(54).unwrap();
    let mesh = processor
        .process(&entity, &mut decoder, &schema, TessellationQuality::Medium)
        .expect("half-ellipse face must tessellate");

    let area = mesh_surface_area(&mesh);
    let expected = std::f64::consts::PI * 50.0 * 25.0 / 2.0;
    assert!(
        (area - expected).abs() < expected * 0.1,
        "half-ellipse area should be ~{expected:.0}, got {area:.0}"
    );
    // The semi-minor axis bounds the sampled arc: max |y| must be ~25, not 50
    // (a circle-style sampler ignoring SemiAxis2 would overshoot).
    let max_y = mesh
        .positions
        .chunks_exact(3)
        .map(|p| p[1])
        .fold(f32::MIN, f32::max);
    assert!(
        (20.0..=26.0).contains(&max_y),
        "ellipse apex must be at y~25, got {max_y}"
    );
}

/// Issue #1661: the rational NURBS variant missed the exact-string
/// IFCBSPLINECURVEWITHKNOTS match and collapsed to one vertex.
#[test]
fn test_advanced_face_rational_bspline_edge_sampled() {
    let content = r#"
#1=IFCCARTESIANPOINT((50.,0.,0.));
#2=IFCCARTESIANPOINT((-50.,0.,0.));
#3=IFCCARTESIANPOINT((0.,0.,0.));
#4=IFCCARTESIANPOINT((0.,60.,0.));
#5=IFCVERTEXPOINT(#1);
#6=IFCVERTEXPOINT(#2);
#9=IFCDIRECTION((0.,0.,1.));
#10=IFCDIRECTION((1.,0.,0.));
#11=IFCAXIS2PLACEMENT3D(#3,#9,#10);
#12=IFCPLANE(#11);
#13=IFCRATIONALBSPLINECURVEWITHKNOTS(2,(#1,#4,#2),.UNSPECIFIED.,.F.,.F.,(3,3),(0.,1.),.UNSPECIFIED.,(1.,1.,1.));
#15=IFCLINE(#2,#20);
#20=IFCVECTOR(#21,1.);
#21=IFCDIRECTION((1.,0.,0.));
#30=IFCEDGECURVE(#5,#6,#13,.T.);
#31=IFCEDGECURVE(#6,#5,#15,.T.);
#40=IFCORIENTEDEDGE(*,*,#30,.T.);
#41=IFCORIENTEDEDGE(*,*,#31,.T.);
#50=IFCEDGELOOP((#40,#41));
#51=IFCFACEOUTERBOUND(#50,.T.);
#52=IFCADVANCEDFACE((#51),#12,.T.);
#53=IFCOPENSHELL((#52));
#54=IFCSHELLBASEDSURFACEMODEL((#53));
"#;

    let mut decoder = EntityDecoder::new(content);
    let schema = IfcSchema::new();
    let processor = ShellBasedSurfaceModelProcessor::new();

    let entity = decoder.decode_by_id(54).unwrap();
    let mesh = processor
        .process(&entity, &mut decoder, &schema, TessellationQuality::Medium)
        .expect("rational-bspline-bounded face must tessellate");

    assert!(
        mesh.positions.len() / 3 >= 5,
        "rational B-spline edge must contribute intermediate samples, got {} vertices",
        mesh.positions.len() / 3
    );
    // Quadratic Bezier from (50,0) to (-50,0) with control (0,60): apex y=30.
    let max_y = mesh
        .positions
        .chunks_exact(3)
        .map(|p| p[1])
        .fold(f32::MIN, f32::max);
    assert!(
        max_y > 20.0,
        "curve interior must be sampled (apex y~30), got max y = {max_y}"
    );
}

/// Issue #1661: IfcCompositeCurve edge geometry (two quarter-arc trimmed
/// segments) collapsed to a single vertex per edge.
#[test]
fn test_advanced_face_composite_curve_edge_sampled() {
    let content = r#"
#1=IFCCARTESIANPOINT((50.,0.,0.));
#2=IFCCARTESIANPOINT((-50.,0.,0.));
#3=IFCCARTESIANPOINT((0.,0.,0.));
#4=IFCCARTESIANPOINT((0.,50.,0.));
#5=IFCVERTEXPOINT(#1);
#6=IFCVERTEXPOINT(#2);
#9=IFCDIRECTION((0.,0.,1.));
#10=IFCDIRECTION((1.,0.,0.));
#11=IFCAXIS2PLACEMENT3D(#3,#9,#10);
#12=IFCPLANE(#11);
#13=IFCCIRCLE(#11,50.);
#14=IFCTRIMMEDCURVE(#13,(#1),(#4),.T.,.CARTESIAN.);
#16=IFCTRIMMEDCURVE(#13,(#4),(#2),.T.,.CARTESIAN.);
#17=IFCCOMPOSITECURVESEGMENT(.CONTINUOUS.,.T.,#14);
#18=IFCCOMPOSITECURVESEGMENT(.CONTINUOUS.,.T.,#16);
#19=IFCCOMPOSITECURVE((#17,#18),.F.);
#15=IFCLINE(#2,#20);
#20=IFCVECTOR(#21,1.);
#21=IFCDIRECTION((1.,0.,0.));
#30=IFCEDGECURVE(#5,#6,#19,.T.);
#31=IFCEDGECURVE(#6,#5,#15,.T.);
#40=IFCORIENTEDEDGE(*,*,#30,.T.);
#41=IFCORIENTEDEDGE(*,*,#31,.T.);
#50=IFCEDGELOOP((#40,#41));
#51=IFCFACEOUTERBOUND(#50,.T.);
#52=IFCADVANCEDFACE((#51),#12,.T.);
#53=IFCOPENSHELL((#52));
#54=IFCSHELLBASEDSURFACEMODEL((#53));
"#;

    let mut decoder = EntityDecoder::new(content);
    let schema = IfcSchema::new();
    let processor = ShellBasedSurfaceModelProcessor::new();

    let entity = decoder.decode_by_id(54).unwrap();
    let mesh = processor
        .process(&entity, &mut decoder, &schema, TessellationQuality::Medium)
        .expect("composite-curve-bounded face must tessellate");

    let area = mesh_surface_area(&mesh);
    let expected = std::f64::consts::PI * 50.0 * 50.0 / 2.0;
    assert!(
        (area - expected).abs() < expected * 0.1,
        "half-disc (two quarter-arc segments) area should be ~{expected:.0}, got {area:.0}"
    );
}

/// Issue #1661: CATIA writes IFCSHAPEREPRESENTATION(#ctx,'Body','',(items)) -
/// RepresentationIdentifier 'Body', RepresentationType EMPTY STRING. The body
/// filter ran on the raw type, so the whole representation was vetoed and the
/// element meshed to zero triangles ($ null type never hit the filter; only
/// the empty-string spelling did). The filter must fall back to the
/// identifier when the type is blank - and an 'Axis' identifier with a blank
/// type must still be skipped.
#[test]
fn test_element_with_blank_representation_type_uses_identifier() {
    use crate::router::GeometryRouter;

    let content = r#"
#1=IFCCARTESIANPOINT((0.,0.,0.));
#2=IFCCARTESIANPOINT((100.,0.,0.));
#3=IFCCARTESIANPOINT((100.,100.,0.));
#4=IFCCARTESIANPOINT((0.,100.,0.));
#10=IFCPOLYLOOP((#1,#2,#3,#4));
#11=IFCFACEBOUND(#10,.T.);
#12=IFCFACE((#11));
#13=IFCOPENSHELL((#12));
#14=IFCSHELLBASEDSURFACEMODEL((#13));
#20=IFCSHAPEREPRESENTATION(#99,'Body','',(#14));
#21=IFCPRODUCTDEFINITIONSHAPE($,$,(#20));
#22=IFCWALL('3xxxxxxxxxxxxxxxxxxxx1',$,$,$,$,$,#21,$);
#30=IFCSHAPEREPRESENTATION(#99,'Axis','',(#14));
#31=IFCPRODUCTDEFINITIONSHAPE($,$,(#30));
#32=IFCWALL('3xxxxxxxxxxxxxxxxxxxx2',$,$,$,$,$,#31,$);
"#;

    let entity_index = ifc_lite_core::build_entity_index(content);
    let mut decoder = EntityDecoder::with_index(content, entity_index);
    let router = GeometryRouter::new();

    let wall = decoder.decode_by_id(22).expect("decode wall");
    let mesh = router
        .process_element(&wall, &mut decoder)
        .expect("process wall");
    assert!(
        !mesh.is_empty(),
        "blank RepresentationType with 'Body' identifier must still mesh (#1661)"
    );

    let axis_wall = decoder.decode_by_id(32).expect("decode axis wall");
    let axis_mesh = router
        .process_element(&axis_wall, &mut decoder)
        .expect("process axis wall");
    assert!(
        axis_mesh.is_empty(),
        "blank RepresentationType with 'Axis' identifier must stay skipped"
    );
}

/// PR #1673 review follow-up: an IfcTrimmedCurve over a B-spline basis whose
/// trims select only a SUBSPAN must not sample the basis curve's full knot
/// range - intermediate samples would jump outside the trimmed edge and
/// corrupt the face loop. Quadratic B-spline through (50,0) (25,40) (-25,40)
/// (-50,0) with knots [0,0,0,.5,1,1,1]; the edge is trimmed to t in [0,0.5]
/// (endpoints (50,0,0) -> (0,40,0)). Untrimmed sampling would emit points
/// approaching (-50,0,0).
#[test]
fn test_advanced_face_trimmed_bspline_respects_trim_params() {
    let content = r#"
#1=IFCCARTESIANPOINT((50.,0.,0.));
#2=IFCCARTESIANPOINT((0.,40.,0.));
#3=IFCCARTESIANPOINT((0.,0.,0.));
#5=IFCVERTEXPOINT(#1);
#6=IFCVERTEXPOINT(#2);
#7=IFCCARTESIANPOINT((25.,40.,0.));
#8=IFCCARTESIANPOINT((-25.,40.,0.));
#18=IFCCARTESIANPOINT((-50.,0.,0.));
#9=IFCDIRECTION((0.,0.,1.));
#10=IFCDIRECTION((1.,0.,0.));
#11=IFCAXIS2PLACEMENT3D(#3,#9,#10);
#12=IFCPLANE(#11);
#13=IFCBSPLINECURVEWITHKNOTS(2,(#1,#7,#8,#18),.UNSPECIFIED.,.F.,.F.,(3,1,3),(0.,0.5,1.),.UNSPECIFIED.);
#14=IFCTRIMMEDCURVE(#13,(IFCPARAMETERVALUE(0.)),(IFCPARAMETERVALUE(0.5)),.T.,.PARAMETER.);
#15=IFCLINE(#2,#20);
#20=IFCVECTOR(#21,1.);
#21=IFCDIRECTION((1.,0.,0.));
#30=IFCEDGECURVE(#5,#6,#14,.T.);
#31=IFCEDGECURVE(#6,#5,#15,.T.);
#40=IFCORIENTEDEDGE(*,*,#30,.T.);
#41=IFCORIENTEDEDGE(*,*,#31,.T.);
#50=IFCEDGELOOP((#40,#41));
#51=IFCFACEOUTERBOUND(#50,.T.);
#52=IFCADVANCEDFACE((#51),#12,.T.);
#53=IFCOPENSHELL((#52));
#54=IFCSHELLBASEDSURFACEMODEL((#53));
"#;

    let mut decoder = EntityDecoder::new(content);
    let schema = IfcSchema::new();
    let processor = ShellBasedSurfaceModelProcessor::new();

    let entity = decoder.decode_by_id(54).unwrap();
    let mesh = processor
        .process(&entity, &mut decoder, &schema, TessellationQuality::Medium)
        .expect("trimmed-bspline-bounded face must tessellate");

    assert!(
        mesh.positions.len() / 3 >= 5,
        "trimmed B-spline edge must contribute intermediate samples, got {} vertices",
        mesh.positions.len() / 3
    );
    // All samples stay on the trimmed half (x in [0, 50]); full-basis sampling
    // would emit points with x approaching -50.
    let min_x = mesh
        .positions
        .chunks_exact(3)
        .map(|p| p[0])
        .fold(f32::MAX, f32::min);
    assert!(
        min_x > -5.0,
        "samples must stay on the trimmed subspan (t <= 0.5, x >= 0), got min x = {min_x}"
    );
}