hydro_optimize 0.13.0

Automatic decoupling and partitioning
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
use std::cell::RefCell;
use std::collections::HashMap;
use std::rc::Rc;

use hydro_lang::ClusterId;
use hydro_lang::ir::{
    DebugInstantiate, DebugType, HydroIrMetadata, HydroLeaf, HydroNode, TeeNode,
    transform_bottom_up, traverse_dfir,
};
use hydro_lang::location::LocationId;
use hydro_lang::stream::{deserialize_bincode_with_type, serialize_bincode_with_type};
use proc_macro2::Span;
use serde::{Deserialize, Serialize};
use stageleft::quote_type;
use syn::visit_mut::VisitMut;

use crate::repair::{cycle_source_to_sink_input, inject_id, inject_location};
use crate::rewrites::ClusterSelfIdReplace;

#[derive(Clone, Serialize, Deserialize)]
pub struct Decoupler {
    pub output_to_decoupled_machine_after: Vec<usize>, /* The output of the operator at this index should be sent to the decoupled machine */
    pub output_to_original_machine_after: Vec<usize>, /* The output of the operator at this index should be sent to the original machine */
    pub place_on_decoupled_machine: Vec<usize>, /* This operator should be placed on the decoupled machine. Only for sources */
    pub orig_location: LocationId,
    pub decoupled_location: LocationId,
}

fn add_network(node: &mut HydroNode, new_location: &LocationId) {
    let metadata = node.metadata().clone();
    let output_debug_type = metadata.output_type.clone().unwrap();

    let parent_id = metadata.location_kind.root().raw_id();
    let node_content = std::mem::replace(node, HydroNode::Placeholder);

    // Map from b to (ClusterId, b), where ClusterId is the id of the decoupled (or original) node we're sending to
    let ident = syn::Ident::new(
        &format!("__hydro_lang_cluster_self_id_{}", parent_id),
        Span::call_site(),
    );
    let f: syn::Expr = syn::parse_quote!(|b| (
        ClusterId::<()>::from_raw(#ident),
        b
    ));
    let cluster_id_type = quote_type::<ClusterId<()>>();
    let mapped_output_type: syn::Type = syn::parse_quote!((#cluster_id_type, #output_debug_type));
    let mapped_node = HydroNode::Map {
        f: f.into(),
        input: Box::new(node_content),
        metadata: HydroIrMetadata {
            location_kind: metadata.location_kind.root().clone(), // Remove any ticks
            backtrace: metadata.backtrace.clone(),
            output_type: Some(DebugType(Box::new(mapped_output_type.clone()))),
            cardinality: None,
            cpu_usage: None,
            network_recv_cpu_usage: None,
            id: None,
        },
    };

    // Set up the network node
    let output_type = output_debug_type.clone().0;
    let network_node = HydroNode::Network {
        serialize_fn: Some(serialize_bincode_with_type(true, &output_type)).map(|e| e.into()),
        instantiate_fn: DebugInstantiate::Building,
        deserialize_fn: Some(deserialize_bincode_with_type(
            Some(&quote_type::<()>()),
            &output_type,
        ))
        .map(|e| e.into()),
        input: Box::new(mapped_node),
        metadata: HydroIrMetadata {
            location_kind: new_location.clone(),
            backtrace: metadata.backtrace.clone(),
            output_type: Some(DebugType(Box::new(mapped_output_type))),
            cardinality: None,
            cpu_usage: None,
            network_recv_cpu_usage: None,
            id: None,
        },
    };

    // Map again to remove the cluster Id (mimicking send_anonymous)
    let f: syn::Expr = syn::parse_quote!(|(_, b)| b);
    let mapped_node = HydroNode::Map {
        f: f.into(),
        input: Box::new(network_node),
        metadata: HydroIrMetadata {
            location_kind: new_location.clone(),
            backtrace: metadata.backtrace.clone(),
            output_type: Some(output_debug_type),
            cardinality: None,
            cpu_usage: None,
            network_recv_cpu_usage: None,
            id: None,
        },
    };
    *node = mapped_node;
}

fn add_tee(
    node: &mut HydroNode,
    new_location: &LocationId,
    new_inners: &mut HashMap<(usize, LocationId), Rc<RefCell<HydroNode>>>,
) {
    let metadata = node.metadata().clone();
    let inner_id = if let HydroNode::Tee { inner, .. } = node {
        inner.0.borrow().metadata().id.unwrap()
    } else {
        std::panic!("Decoupler add_tee() called on non-Tee");
    };

    let new_inner = new_inners
        .entry((inner_id, new_location.clone()))
        .or_insert_with(|| {
            println!(
                "Adding network before Tee to location {:?} after id: {}",
                new_location, inner_id
            );
            add_network(node, new_location);
            let node_content = std::mem::replace(node, HydroNode::Placeholder);
            Rc::new(RefCell::new(node_content))
        })
        .clone();

    let teed_node = HydroNode::Tee {
        inner: TeeNode(new_inner),
        metadata,
    };
    *node = teed_node;
}

fn decouple_node(
    node: &mut HydroNode,
    decoupler: &Decoupler,
    next_stmt_id: &mut usize,
    new_inners: &mut HashMap<(usize, LocationId), Rc<RefCell<HydroNode>>>,
) {
    // Replace location of sources, if necessary
    if decoupler.place_on_decoupled_machine.contains(next_stmt_id) {
        match node {
            HydroNode::Source { metadata, .. } | HydroNode::Network { metadata, .. } => {
                println!(
                    "Changing source/network destination from {:?} to location {:?}, id: {}",
                    metadata.location_kind,
                    decoupler.decoupled_location.clone(),
                    next_stmt_id
                );
                metadata
                    .location_kind
                    .swap_root(decoupler.decoupled_location.clone());
            }
            _ => {
                std::panic!(
                    "Decoupler placing non-source/network node on decoupled machine: {}",
                    node.print_root()
                );
            }
        }
        return;
    }

    // Otherwise, replace where the outputs go
    let new_location = if decoupler
        .output_to_decoupled_machine_after
        .contains(next_stmt_id)
    {
        &decoupler.decoupled_location
    } else if decoupler
        .output_to_original_machine_after
        .contains(next_stmt_id)
    {
        &decoupler.orig_location
    } else {
        return;
    };

    match node {
        HydroNode::Placeholder | HydroNode::Network { .. } => {
            std::panic!(
                "Decoupler modifying placeholder node or incorrectly handling network node: {}",
                next_stmt_id
            );
        }
        HydroNode::Tee { .. } => {
            println!(
                "Creating a TEE to location {:?}, id: {}",
                new_location, next_stmt_id
            );
            add_tee(node, new_location, new_inners);
        }
        _ => {
            println!(
                "Creating network to location {:?} after node {}, id: {}",
                new_location,
                node.print_root(),
                next_stmt_id
            );
            add_network(node, new_location);
        }
    }
}

fn fix_cluster_self_id_leaf(leaf: &mut HydroLeaf, mut locations: ClusterSelfIdReplace) {
    if let ClusterSelfIdReplace::Decouple {
        decoupled_cluster_id,
        ..
    } = locations
    {
        if leaf.metadata().location_kind.root().raw_id() == decoupled_cluster_id {
            leaf.visit_debug_expr(|expr| {
                locations.visit_expr_mut(&mut expr.0);
            });
        }
    }
}

fn fix_cluster_self_id_node(node: &mut HydroNode, mut locations: ClusterSelfIdReplace) {
    if let ClusterSelfIdReplace::Decouple {
        decoupled_cluster_id,
        ..
    } = locations
    {
        if node.metadata().location_kind.root().raw_id() == decoupled_cluster_id {
            node.visit_debug_expr(|expr| {
                locations.visit_expr_mut(&mut expr.0);
            });
        }
    }
}

pub fn decouple(ir: &mut [HydroLeaf], decoupler: &Decoupler) {
    let mut new_inners = HashMap::new();
    traverse_dfir(
        ir,
        |_, _| {},
        |node, next_stmt_id| {
            decouple_node(node, decoupler, next_stmt_id, &mut new_inners);
        },
    );

    // Fix IDs since we injected nodes
    inject_id(ir);
    // Fix locations since we changed some
    let cycle_source_to_sink_input = cycle_source_to_sink_input(ir);
    inject_location(ir, &cycle_source_to_sink_input);
    // Fix CLUSTER_SELF_ID for the decoupled node
    let locations = ClusterSelfIdReplace::Decouple {
        orig_cluster_id: decoupler.orig_location.raw_id(),
        decoupled_cluster_id: decoupler.decoupled_location.raw_id(),
    };
    transform_bottom_up(
        ir,
        &mut |leaf| {
            fix_cluster_self_id_leaf(leaf, locations);
        },
        &mut |node| {
            fix_cluster_self_id_node(node, locations);
        },
        true,
    );
}

#[cfg(test)]
mod tests {
    use std::collections::HashSet;

    use hydro_deploy::Deployment;
    use hydro_lang::location::LocationId;
    use hydro_lang::rewrites::persist_pullup::persist_pullup;
    use hydro_lang::{FlowBuilder, Location, ir};
    use stageleft::q;

    use crate::decoupler;
    use crate::decoupler::decouple;
    use crate::repair::inject_id;

    fn decouple_mini_program(
        with_decoupler: &decoupler::Decoupler,
    ) -> (
        hydro_lang::Cluster<'_, ()>,
        hydro_lang::Cluster<'_, ()>,
        hydro_lang::Cluster<'_, ()>,
        hydro_lang::builder::built::BuiltFlow<'_>,
    ) {
        let builder = FlowBuilder::new();
        let send_cluster = builder.cluster::<()>();
        let recv_cluster = builder.cluster::<()>();

        send_cluster
            .source_iter(q!(0..10))
            .map(q!(|a| a + 1))
            .broadcast_bincode_anonymous(&recv_cluster)
            .for_each(q!(|a| println!("Got it: {}", a)));

        let decoupled_cluster = builder.cluster::<()>();
        let decoupler = decoupler::Decoupler {
            output_to_decoupled_machine_after: with_decoupler
                .output_to_decoupled_machine_after
                .clone(),
            output_to_original_machine_after: with_decoupler
                .output_to_original_machine_after
                .clone(),
            place_on_decoupled_machine: with_decoupler.place_on_decoupled_machine.clone(),
            decoupled_location: decoupled_cluster.id().clone(),
            orig_location: send_cluster.id().clone(),
        };

        let built = builder
            .optimize_with(persist_pullup)
            .optimize_with(inject_id)
            .optimize_with(|ir| decouple(ir, &decoupler));
        (send_cluster, recv_cluster, decoupled_cluster, built)
    }

    async fn check_decouple_mini_program(with_decoupler: &decoupler::Decoupler) {
        let (send_cluster, recv_cluster, decoupled_cluster, built) =
            decouple_mini_program(with_decoupler);

        // Check outputs
        let mut deployment = Deployment::new();
        let nodes = built
            .with_cluster(&send_cluster, vec![deployment.Localhost(); 1])
            .with_cluster(&recv_cluster, vec![deployment.Localhost(); 3])
            .with_cluster(&decoupled_cluster, vec![deployment.Localhost(); 1])
            .deploy(&mut deployment);

        deployment.deploy().await.unwrap();

        let recv_members = nodes.get_cluster(&recv_cluster).members();
        let mut stdouts = vec![];
        for member in recv_members {
            use hydro_lang::deploy::DeployCrateWrapper;

            stdouts.push(member.stdout().await);
        }

        deployment.start().await.unwrap();

        for mut stdout in stdouts {
            let mut expected = HashSet::new();
            let mut received = HashSet::new();
            for i in 1..11 {
                received.insert(stdout.recv().await.unwrap());
                expected.insert(format!("Got it: {}", i));
            }
            assert_eq!(expected, received);
        }
    }

    #[test]
    fn decouple_after_source_ir() {
        let decoupler = decoupler::Decoupler {
            output_to_decoupled_machine_after: vec![0],
            output_to_original_machine_after: vec![],
            place_on_decoupled_machine: vec![],
            decoupled_location: LocationId::Cluster(0), // Doesn't matter, will be ignored
            orig_location: LocationId::Cluster(0),
        };

        let built = decouple_mini_program(&decoupler).3;

        ir::dbg_dedup_tee(|| {
            insta::assert_debug_snapshot!(built.ir());
        });
    }

    #[tokio::test]
    async fn decouple_after_source() {
        let decoupler = decoupler::Decoupler {
            output_to_decoupled_machine_after: vec![0],
            output_to_original_machine_after: vec![],
            place_on_decoupled_machine: vec![],
            decoupled_location: LocationId::Cluster(0), // Doesn't matter, will be ignored
            orig_location: LocationId::Cluster(0),
        };

        check_decouple_mini_program(&decoupler).await
    }

    #[test]
    fn move_source_decouple_map_ir() {
        let decoupler = decoupler::Decoupler {
            output_to_decoupled_machine_after: vec![],
            output_to_original_machine_after: vec![1],
            place_on_decoupled_machine: vec![0],
            decoupled_location: LocationId::Cluster(0), // Doesn't matter, will be ignored
            orig_location: LocationId::Cluster(0),
        };

        let built = decouple_mini_program(&decoupler).3;

        ir::dbg_dedup_tee(|| {
            insta::assert_debug_snapshot!(built.ir());
        });
    }

    #[tokio::test]
    async fn move_source_decouple_map() {
        let decoupler = decoupler::Decoupler {
            output_to_decoupled_machine_after: vec![],
            output_to_original_machine_after: vec![1],
            place_on_decoupled_machine: vec![0],
            decoupled_location: LocationId::Cluster(0), // Doesn't matter, will be ignored
            orig_location: LocationId::Cluster(0),
        };

        check_decouple_mini_program(&decoupler).await
    }
}