hyalo-cli 0.14.0

use std::fs;

use super::common::{hyalo, hyalo_no_hints, write_md};
use serde_json::Value;
use tempfile::TempDir;

/// Set a "drafts" view and return the temp dir.
fn setup_with_view() -> TempDir {
    let tmp = setup();
    let output = hyalo()
        .current_dir(tmp.path())
        .args(["views", "set", "drafts", "--property", "status=draft"])
        .output()
        .unwrap();
    assert!(
        output.status.success(),
        "views set failed: {}",
        String::from_utf8_lossy(&output.stderr)
    );
    tmp
}

fn setup() -> TempDir {
    let tmp = tempfile::tempdir().unwrap();
    write_md(
        tmp.path(),
        "note1.md",
        "---\nstatus: draft\ntags:\n  - project\n---\nHello world",
    );
    write_md(
        tmp.path(),
        "note2.md",
        "---\nstatus: completed\ntags:\n  - research\n---\nGoodbye world",
    );
    tmp
}

#[test]
fn views_set_and_list() {
    let tmp = setup();
    // Set a view
    let output = hyalo()
        .current_dir(tmp.path())
        .args(["views", "set", "drafts", "--property", "status=draft"])
        .output()
        .unwrap();
    assert!(
        output.status.success(),
        "set failed: {}",
        String::from_utf8_lossy(&output.stderr)
    );

    // List views
    let output = hyalo()
        .current_dir(tmp.path())
        .args(["views", "list"])
        .output()
        .unwrap();
    assert!(
        output.status.success(),
        "list failed: {}",
        String::from_utf8_lossy(&output.stderr)
    );
    let json: serde_json::Value = serde_json::from_slice(&output.stdout).unwrap();
    assert_eq!(json["total"], 1);
    assert_eq!(json["results"][0]["name"], "drafts");
}

#[test]
fn views_remove() {
    let tmp = setup();
    // Set then remove
    hyalo()
        .current_dir(tmp.path())
        .args(["views", "set", "drafts", "--property", "status=draft"])
        .output()
        .unwrap();

    let output = hyalo()
        .current_dir(tmp.path())
        .args(["views", "remove", "drafts"])
        .output()
        .unwrap();
    assert!(output.status.success());

    // List should be empty
    let output = hyalo()
        .current_dir(tmp.path())
        .args(["views", "list"])
        .output()
        .unwrap();
    let json: serde_json::Value = serde_json::from_slice(&output.stdout).unwrap();
    assert_eq!(json["total"], 0);
}

#[test]
fn find_with_view() {
    let tmp = setup();
    // Set a view
    hyalo()
        .current_dir(tmp.path())
        .args(["views", "set", "drafts", "--property", "status=draft"])
        .output()
        .unwrap();

    // Use the view with find
    let output = hyalo_no_hints()
        .current_dir(tmp.path())
        .args(["find", "--view", "drafts"])
        .output()
        .unwrap();
    assert!(
        output.status.success(),
        "find --view failed: {}",
        String::from_utf8_lossy(&output.stderr)
    );
    let json: serde_json::Value = serde_json::from_slice(&output.stdout).unwrap();
    assert_eq!(json["total"], 1);
    assert!(
        json["results"][0]["file"]
            .as_str()
            .unwrap()
            .contains("note1")
    );
}

#[test]
fn find_with_view_and_overrides() {
    let tmp = setup();
    // Create more files
    write_md(
        tmp.path(),
        "note3.md",
        "---\nstatus: draft\ntags:\n  - project\n---\nAnother draft",
    );

    // Set a view with property filter
    hyalo()
        .current_dir(tmp.path())
        .args(["views", "set", "drafts", "--property", "status=draft"])
        .output()
        .unwrap();

    // Use view with limit override
    let output = hyalo_no_hints()
        .current_dir(tmp.path())
        .args(["find", "--view", "drafts", "--limit", "1"])
        .output()
        .unwrap();
    assert!(output.status.success());
    let json: serde_json::Value = serde_json::from_slice(&output.stdout).unwrap();
    assert_eq!(json["results"].as_array().unwrap().len(), 1);
}

#[test]
fn find_with_unknown_view_errors() {
    let tmp = setup();
    let output = hyalo()
        .current_dir(tmp.path())
        .args(["find", "--view", "nonexistent"])
        .output()
        .unwrap();
    assert!(!output.status.success());
    let stderr = String::from_utf8_lossy(&output.stderr);
    assert!(stderr.contains("unknown view"), "stderr: {stderr}");
}

#[test]
fn views_remove_nonexistent_errors() {
    let tmp = setup();
    let output = hyalo()
        .current_dir(tmp.path())
        .args(["views", "remove", "nonexistent"])
        .output()
        .unwrap();
    assert!(!output.status.success());
    let stderr = String::from_utf8_lossy(&output.stderr);
    assert!(stderr.contains("not found"), "stderr: {stderr}");
}

#[test]
fn views_set_empty_filters_errors() {
    let tmp = setup();
    let output = hyalo()
        .current_dir(tmp.path())
        .args(["views", "set", "empty"])
        .output()
        .unwrap();
    assert!(!output.status.success());
    let stderr = String::from_utf8_lossy(&output.stderr);
    assert!(stderr.contains("no filters"), "stderr: {stderr}");
}

#[test]
fn views_set_preserves_existing_config() {
    let tmp = setup();
    // Write a .hyalo.toml with dir set
    fs::write(tmp.path().join(".hyalo.toml"), "dir = \".\"\n").unwrap();

    // Set a view
    hyalo()
        .current_dir(tmp.path())
        .args(["views", "set", "drafts", "--property", "status=draft"])
        .output()
        .unwrap();

    // Verify dir is preserved
    let content = fs::read_to_string(tmp.path().join(".hyalo.toml")).unwrap();
    assert!(content.contains("dir = \".\""), "dir was lost: {content}");
    assert!(
        content.contains("[views.drafts]"),
        "view not written: {content}"
    );
}

#[test]
fn hint_suggests_saving_non_trivial_query_as_view() {
    let tmp = setup();
    // Two filters = non-trivial → should suggest saving as a view
    let output = hyalo()
        .current_dir(tmp.path())
        .args([
            "find",
            "--property",
            "status=draft",
            "--tag",
            "project",
            "--hints",
        ])
        .output()
        .unwrap();
    assert!(output.status.success());
    let json: Value = serde_json::from_slice(&output.stdout).unwrap();
    let hints = json["hints"].as_array().unwrap();
    let has_view_hint = hints
        .iter()
        .any(|h| h["cmd"].as_str().unwrap_or("").contains("views set"));
    assert!(
        has_view_hint,
        "expected 'views set' hint for non-trivial query, got: {hints:?}"
    );
}

#[test]
fn hint_does_not_suggest_view_for_single_filter() {
    let tmp = setup();
    // Single filter = trivial → should NOT suggest saving as a view
    let output = hyalo()
        .current_dir(tmp.path())
        .args(["find", "--property", "status=draft", "--hints"])
        .output()
        .unwrap();
    assert!(output.status.success());
    let json: Value = serde_json::from_slice(&output.stdout).unwrap();
    let hints = json["hints"].as_array().unwrap();
    let has_view_hint = hints
        .iter()
        .any(|h| h["cmd"].as_str().unwrap_or("").contains("views set"));
    assert!(
        !has_view_hint,
        "should not suggest view for single-filter query, got: {hints:?}"
    );
}

#[test]
fn views_no_subcommand_defaults_to_list() {
    let tmp = setup_with_view();

    let list_output = hyalo_no_hints()
        .current_dir(tmp.path())
        .args(["views", "list"])
        .output()
        .unwrap();
    let default_output = hyalo_no_hints()
        .current_dir(tmp.path())
        .args(["views"])
        .output()
        .unwrap();

    assert!(list_output.status.success());
    assert!(default_output.status.success());
    assert_eq!(
        list_output.stdout, default_output.stdout,
        "`hyalo views` should produce same output as `hyalo views list`"
    );
}

#[test]
fn views_list_format_text() {
    let tmp = setup_with_view();

    let output = hyalo_no_hints()
        .current_dir(tmp.path())
        .args(["views", "list", "--format", "text"])
        .output()
        .unwrap();
    assert!(
        output.status.success(),
        "stderr: {}",
        String::from_utf8_lossy(&output.stderr)
    );
    let text = String::from_utf8_lossy(&output.stdout);
    // Text output should not start with '{' (JSON object)
    assert!(
        !text.trim_start().starts_with('{'),
        "expected text output, got JSON-like: {text}"
    );
    // Should contain the view name
    assert!(
        text.contains("drafts"),
        "expected 'drafts' in text output: {text}"
    );
}

#[test]
fn views_set_format_text() {
    let tmp = setup();

    let output = hyalo_no_hints()
        .current_dir(tmp.path())
        .args([
            "views",
            "set",
            "my-view",
            "--property",
            "status=draft",
            "--format",
            "text",
        ])
        .output()
        .unwrap();
    assert!(
        output.status.success(),
        "stderr: {}",
        String::from_utf8_lossy(&output.stderr)
    );
    let text = String::from_utf8_lossy(&output.stdout);
    // Text output should not start with '{'
    assert!(
        !text.trim_start().starts_with('{'),
        "expected text output, got JSON-like: {text}"
    );
    // Should mention the action and view name
    assert!(
        text.contains("set") && text.contains("my-view"),
        "expected action and name in text output: {text}"
    );
}

#[test]
fn views_remove_format_text() {
    let tmp = setup_with_view();

    let output = hyalo_no_hints()
        .current_dir(tmp.path())
        .args(["views", "remove", "drafts", "--format", "text"])
        .output()
        .unwrap();
    assert!(
        output.status.success(),
        "stderr: {}",
        String::from_utf8_lossy(&output.stderr)
    );
    let text = String::from_utf8_lossy(&output.stdout);
    assert!(
        !text.trim_start().starts_with('{'),
        "expected text output, got JSON-like: {text}"
    );
    assert!(
        text.contains("removed") && text.contains("drafts"),
        "expected action and name in text output: {text}"
    );
}

#[test]
fn views_list_jq_total() {
    let tmp = setup_with_view();

    let output = hyalo()
        .current_dir(tmp.path())
        .args(["views", "list", "--jq", ".total"])
        .output()
        .unwrap();
    assert!(
        output.status.success(),
        "stderr: {}",
        String::from_utf8_lossy(&output.stderr)
    );
    let text = String::from_utf8_lossy(&output.stdout).trim().to_owned();
    assert_eq!(text, "1", "expected total=1, got: {text}");
}

#[test]
fn views_list_jq_results() {
    let tmp = setup_with_view();

    let output = hyalo()
        .current_dir(tmp.path())
        .args(["views", "list", "--jq", ".results[0].name"])
        .output()
        .unwrap();
    assert!(
        output.status.success(),
        "stderr: {}",
        String::from_utf8_lossy(&output.stderr)
    );
    let text = String::from_utf8_lossy(&output.stdout).trim().to_owned();
    assert_eq!(text, "drafts", "expected view name, got: {text}");
}

#[test]
fn views_list_count() {
    let tmp = setup_with_view();

    let output = hyalo()
        .current_dir(tmp.path())
        .args(["views", "list", "--count"])
        .output()
        .unwrap();
    assert!(
        output.status.success(),
        "stderr: {}",
        String::from_utf8_lossy(&output.stderr)
    );
    let text = String::from_utf8_lossy(&output.stdout).trim().to_owned();
    assert_eq!(text, "1", "expected count=1, got: {text}");
}

#[test]
fn hint_does_not_suggest_view_when_using_view() {
    let tmp = setup();
    // Create a view with two filters
    let set_output = hyalo()
        .current_dir(tmp.path())
        .args([
            "views",
            "set",
            "drafts",
            "--property",
            "status=draft",
            "--tag",
            "project",
        ])
        .output()
        .unwrap();
    assert!(
        set_output.status.success(),
        "views set failed: {}",
        String::from_utf8_lossy(&set_output.stderr)
    );

    // Use it — should NOT suggest saving again
    let output = hyalo()
        .current_dir(tmp.path())
        .args(["find", "--view", "drafts", "--hints"])
        .output()
        .unwrap();
    assert!(output.status.success());
    let json: Value = serde_json::from_slice(&output.stdout).unwrap();
    let hints = json["hints"].as_array().unwrap();
    let has_view_hint = hints
        .iter()
        .any(|h| h["cmd"].as_str().unwrap_or("").contains("views set"));
    assert!(
        !has_view_hint,
        "should not suggest view when already using --view, got: {hints:?}"
    );
}

#[test]
fn views_set_with_bm25_pattern_and_find() {
    let tmp = tempfile::tempdir().unwrap();

    // File that contains the search term and matching tag
    write_md(
        tmp.path(),
        "relevant.md",
        "---\nstatus: active\ntags:\n  - sometag\n---\nThis document discusses fermentation in detail.",
    );
    // File with matching tag but no search term in body
    write_md(
        tmp.path(),
        "other.md",
        "---\nstatus: active\ntags:\n  - sometag\n---\nThis document is about something else entirely.",
    );
    // File with the search term but wrong tag
    write_md(
        tmp.path(),
        "untagged.md",
        "---\nstatus: active\ntags:\n  - othertag\n---\nThis document discusses fermentation as well.",
    );

    // Set a view with a BM25 pattern and tag filter
    let output = hyalo()
        .current_dir(tmp.path())
        .args([
            "views",
            "set",
            "test-pattern",
            "fermentation",
            "--tag",
            "sometag",
        ])
        .output()
        .unwrap();
    assert!(
        output.status.success(),
        "views set with pattern failed: {}",
        String::from_utf8_lossy(&output.stderr)
    );

    // Verify the view appears in views list with the pattern stored in filters
    let output = hyalo()
        .current_dir(tmp.path())
        .args(["views", "list"])
        .output()
        .unwrap();
    assert!(
        output.status.success(),
        "views list failed: {}",
        String::from_utf8_lossy(&output.stderr)
    );
    let json: Value = serde_json::from_slice(&output.stdout).unwrap();
    assert_eq!(json["total"], 1);
    let view = &json["results"][0];
    assert_eq!(view["name"], "test-pattern");
    assert_eq!(
        view["filters"]["pattern"], "fermentation",
        "pattern should be stored in view filters"
    );
    assert!(
        view["filters"]["tag"]
            .as_array()
            .unwrap()
            .contains(&Value::String("sometag".to_owned())),
        "tag filter should be stored in view"
    );

    // Use the view with find — should return only the file with the term AND the tag
    let output = hyalo_no_hints()
        .current_dir(tmp.path())
        .args(["find", "--view", "test-pattern"])
        .output()
        .unwrap();
    assert!(
        output.status.success(),
        "find --view test-pattern failed: {}",
        String::from_utf8_lossy(&output.stderr)
    );
    let json: Value = serde_json::from_slice(&output.stdout).unwrap();
    let results = json["results"].as_array().unwrap();
    assert_eq!(results.len(), 1, "expected exactly one result: {results:?}");
    assert!(
        results[0]["file"].as_str().unwrap().contains("relevant"),
        "expected relevant.md in results: {results:?}"
    );
}

/// Regression test: when `.hyalo.toml` in the project root has `dir = "subdir"`,
/// views must be read from the root config — not from `subdir/.hyalo.toml`.
#[test]
fn views_work_when_dir_is_a_subdir() {
    let tmp = tempfile::tempdir().unwrap();
    let subdir = tmp.path().join("notes");
    fs::create_dir_all(&subdir).unwrap();
    write_md(&subdir, "a.md", "---\nstatus: draft\n---\nhello");

    // Write root .hyalo.toml with dir pointing to subdir
    fs::write(tmp.path().join(".hyalo.toml"), "dir = \"notes\"\n").unwrap();

    // Set a view (should write to root .hyalo.toml)
    let output = hyalo()
        .current_dir(tmp.path())
        .args(["views", "set", "drafts", "--property", "status=draft"])
        .output()
        .unwrap();
    assert!(
        output.status.success(),
        "views set failed: {}",
        String::from_utf8_lossy(&output.stderr)
    );

    // Root config should have the view; subdir should NOT have a .hyalo.toml
    let root_toml = fs::read_to_string(tmp.path().join(".hyalo.toml")).unwrap();
    assert!(
        root_toml.contains("[views.drafts]"),
        "view should be in root .hyalo.toml: {root_toml}"
    );
    assert!(
        !subdir.join(".hyalo.toml").exists(),
        "subdir should not have its own .hyalo.toml"
    );

    // List views — should find the view
    let output = hyalo_no_hints()
        .current_dir(tmp.path())
        .args(["views", "list"])
        .output()
        .unwrap();
    assert!(output.status.success());
    let json: Value = serde_json::from_slice(&output.stdout).unwrap();
    assert_eq!(json["total"], 1, "expected 1 view: {json}");

    // find --view should work
    let output = hyalo_no_hints()
        .current_dir(tmp.path())
        .args(["find", "--view", "drafts"])
        .output()
        .unwrap();
    assert!(
        output.status.success(),
        "find --view failed: {}",
        String::from_utf8_lossy(&output.stderr)
    );
    let json: Value = serde_json::from_slice(&output.stdout).unwrap();
    let results = json["results"].as_array().unwrap();
    assert_eq!(results.len(), 1, "expected 1 result: {results:?}");
}